--- Log opened Wed Apr 22 00:01:00 2020 00:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 00:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-builds 01:18 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-builds 03:06 -!- Abdul4MacGyver [~Abdul4Mac@ns334669.ip-5-196-64.eu] has joined #bitcoin-builds 04:43 -!- mol_ [~molly@unaffiliated/molly] has joined #bitcoin-builds 04:44 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-builds 04:46 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 04:48 -!- mol_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 06:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 06:23 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-builds 07:46 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 07:46 -!- mfoolb_ [~mfoolb@gateway/tor-sasl/mfoolb] has quit [Ping timeout: 240 seconds] 07:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 07:47 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 256 seconds] 07:49 -!- jonatack [~jon@213.152.161.138] has joined #bitcoin-builds 08:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-builds 08:01 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has joined #bitcoin-builds 08:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-builds 08:02 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has left #bitcoin-builds [] 08:21 -!- Tomas123 [bcc3e48d@ipbcc3e48d.dynamic.kabel-deutschland.de] has joined #bitcoin-builds 08:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-builds 08:49 -!- Abdul4MacGyver [~Abdul4Mac@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 09:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-builds 09:11 -!- mol_ [~molly@unaffiliated/molly] has joined #bitcoin-builds 09:14 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 12:20 -!- Tomas123 [bcc3e48d@ipbcc3e48d.dynamic.kabel-deutschland.de] has quit [Remote host closed the connection] 13:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 13:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-builds 14:46 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 14:48 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-builds 15:09 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-builds 16:09 < hebasto> dongcarl: re https://github.com/bitcoin/bitcoin/pull/18556#issuecomment-617917226 Which way does make reviewing simpler? 16:10 < dongcarl> hebasto: Probably just do it as is and merge yours first :-) I'll ACK it 16:14 < hebasto> dongcarl: sure 16:17 < fanquake> hebasto: re https://github.com/bitcoin/bitcoin/pull/18556#discussion_r410202021. In the build system in general I'd definitely rather we don't include extra, undocumented code, just because it might be convenient for testing. However if we've got a few ACKs for this then sure. 16:20 < hebasto> fanquake: followup #18741 is coming to improve that 16:20 < gribble> https://github.com/bitcoin/bitcoin/issues/18741 | guix: Make source tarball using git-archive by dongcarl · Pull Request #18741 · bitcoin/bitcoin · GitHub 16:22 < fanquake> I'm not sure what you mean. That PR doesn't change anything in make_git_archive 16:23 < hebasto> it removes it :) 16:24 < hebasto> in ab65fe2555eb59633578b4f89c525470e36dd1c3 16:26 < fanquake> Weird. I thought GH always showed removed files in the /files view. https://github.com/bitcoin/bitcoin/pull/18741/files 16:26 < hebasto> I was confused too... 16:28 < hebasto> fanquake: there was dongcarl's question about that commit https://github.com/bitcoin/bitcoin/pull/18556#issuecomment-617917226 16:28 < dongcarl> Oh I think we found a bug then 16:28 < dongcarl> I first `git mv`ed it 16:29 < dongcarl> That must have marked it as something that GitHub has faulty logic for? 16:30 < fanquake> I'll will open an issue with GitHub, see what we can find out.. 16:40 < dongcarl> fanquake: I think I `git mv`ed it, then changed the file enough for it to stop being recognized as the same file the next time I `git add`ed it 16:42 < fanquake> dongcarl: ok. I've opened an issue in the maintainer feedback group, so should get someones attention 16:42 < dongcarl> <3 17:43 -!- mol_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 17:51 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-builds 18:14 -!- jonatack [~jon@213.152.161.138] has quit [Ping timeout: 256 seconds] 18:16 -!- jonatack [~jon@37.173.202.229] has joined #bitcoin-builds 23:59 -!- cfields [~cfields@unaffiliated/cfields] has quit [Ping timeout: 260 seconds] --- Log closed Thu Apr 23 00:00:01 2020