--- Log opened Sun Jun 05 00:00:43 2022
01:23 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-builds
01:27 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds]
01:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
02:56 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 272 seconds]
03:27 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
04:22 < hebasto> while #24994 has already been NACKed, it appears, that it wipes all of unnecessary symbols being exported from `libbitcoinconsensus.so`. It makes me believe, that that PR deserves another look :)
04:22 < gribble> https://github.com/bitcoin/bitcoin/issues/24994 | build: Build `libbitcoinconsensus` from its own convenience library by hebasto · Pull Request #24994 · bitcoin/bitcoin · GitHub
05:23 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
05:30 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-builds
05:33 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds]
05:53 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-builds
06:40 < fanquake> I’m still a NACK for that change. The symbol exporting could be solved another way if needed.
07:24 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-builds
08:18 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 246 seconds]
08:19 < davidbakin> i got CI errors last night becuase libtest_util.a wouldn't link - but wasn't getting that on my machine.  does "make" with no targets not build _everything_?
08:19 < davidbakin> or maybe I inadvertently turned it off in my configure?
08:21 < sipa> no
08:21 < sipa> ah, i think it builds everything yes
08:21 < sipa> but what "everything" means depends on configuration
08:21 < sipa> e.g. the qt gui may not be built if you don't have qt
08:24 < davidbakin> yes i don't build the gui, but would have thought something "simple" like something called "libtest_util" which near as I can tell just has stuff from src/test/util would be universal ... guess I'll play around wiht my configure so that when I'm building for a PR submission I'm building more stuff than I actually "need" myself ...
08:25 < sipa> CI only tests way more configurations probably, multiple architectures, OSes, environments, ...
08:25 < sipa> *also
08:26 < davidbakin> yes ... I do know that the Windows build at least is invaluable as I get bit a couple of weeks ago by using a variable name the same as one of Window's nasty #defines ...
08:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
09:44 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-builds
09:47 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
09:49 < hebasto> fanquake: "The symbol exporting could be solved another way if needed." -- I think it is needed, as exporting unused symbols is well known bad practice for shared libraries
09:51 < hebasto> agree that other ways to do this exist, but they looks more hacky and less maintainable
10:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 255 seconds]
10:44 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
13:38 -!- jtraub91 [~Jason@098-147-176-043.res.spectrum.com] has joined #bitcoin-core-builds
13:39 -!- jtraub91 [~Jason@098-147-176-043.res.spectrum.com] has quit [Client Quit]
13:42 -!- meshcollider [meshcollid@jujube.rpblc.net] has quit [Changing host]
13:42 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-builds
14:05 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-builds
14:08 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
14:26 -!- jtraub91 [~Jason@098-147-176-043.res.spectrum.com] has joined #bitcoin-core-builds
15:04 -!- darosior [~darosior@194.36.189.246] has quit [Quit: Ping timeout (120 seconds)]
15:05 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-builds
16:14 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 244 seconds]
17:11 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-builds
17:14 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 256 seconds]
20:27 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Remote host closed the connection]
23:49 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
23:56 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-builds
--- Log closed Mon Jun 06 00:00:44 2022