--- Day changed Fri Oct 23 2015
00:26 < GitHub136> [bitcoin] laanwj opened pull request #6877: rpc: Add maxmempool and effective min fee to getmempoolinfo (master...2015_10_mempool_effective_fee) https://github.com/bitcoin/bitcoin/pull/6877
00:36 -!- dcousens [~anon@203-206-217-234.perm.iinet.net.au] has quit [Ping timeout: 260 seconds]
00:40 -!- ParadoxSpiral [~ParadoxSp@p508B9986.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:43 -!- ParadoxSpiral_ [~ParadoxSp@p508B8D51.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
00:54 -!- CodeShark [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 264 seconds]
00:57 -!- Guest17781 [~quassel@106.120.101.38] has joined #bitcoin-core-dev
00:59 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:04 < GitHub27> [bitcoin] laanwj pushed 1 new commit to 0.11: https://github.com/bitcoin/bitcoin/commit/95a50390e1052a0a501eb446f87d63f58d95b7e7
01:04 < GitHub27> bitcoin/0.11 95a5039 Gregory Maxwell: Set TCP_NODELAY on P2P sockets....
01:04 -!- BashCo [BashCo@gateway/vpn/mullvad/x-himpyklvkjsseysc] has quit [Remote host closed the connection]
01:11 -!- Guest17781 [~quassel@106.120.101.38] has quit [Remote host closed the connection]
01:12 < GitHub187> [bitcoin] laanwj pushed 1 new commit to 0.10: https://github.com/bitcoin/bitcoin/commit/5297194bbd6e0d6730515567248caf9c135e296c
01:12 < GitHub187> bitcoin/0.10 5297194 Gregory Maxwell: Set TCP_NODELAY on P2P sockets....
01:22 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
01:25 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
01:43 -!- matsjj_ [~matsjj@p20030089EA0DC591BC81F9738A7B8A07.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:46 < GitHub44> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2b173acabea...fa1d252e82a8
01:46 < GitHub44> bitcoin/master 338f62f MarcoFalke: [devtools] add clang-format.py
01:46 < GitHub44> bitcoin/master 8c15f33 MarcoFalke: [trivial] Update contrib/devtools/README.md
01:46 < GitHub44> bitcoin/master fa1d252 Wladimir J. van der Laan: Merge pull request #6790...
01:46 < GitHub153> [bitcoin] laanwj closed pull request #6790: [devtools] add clang-format.py (master...MarcoFalke-2015-clangFormatWrapper) https://github.com/bitcoin/bitcoin/pull/6790
01:53 -!- lightningbot` [supybot@2400:8900::f03c:91ff:fedf:3a06] has quit [K-Lined]
02:06 < GitHub149> [bitcoin] TheBlueMatt reopened pull request #6875: Fix pre-push-hook regexes (master...verify-commits-fixes) https://github.com/bitcoin/bitcoin/pull/6875
02:19 -!- rubensayshi [~ruben@91.206.81.13] has joined #bitcoin-core-dev
02:20 -!- maaku [~quassel@botbot.xen.prgmr.com] has quit [Read error: Connection reset by peer]
02:21 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds]
02:21 -!- maaku__ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Ping timeout: 265 seconds]
02:21 -!- maaku [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #bitcoin-core-dev
02:22 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
02:22 -!- maaku is now known as Guest6474
02:22 -!- maaku__ [~quassel@botbot.xen.prgmr.com] has joined #bitcoin-core-dev
02:40 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
02:43 -!- dcousens [~anon@eth3224.nsw.adsl.internode.on.net] has joined #bitcoin-core-dev
02:52 < GitHub150> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa1d252e82a8...923c5e93a90a
02:52 < GitHub150> bitcoin/master b48da5c David Hill: script:  Remove magic numbers...
02:52 < GitHub150> bitcoin/master 923c5e9 Wladimir J. van der Laan: Merge pull request #6818...
02:56 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
03:00 -!- instagibbs_ [~greg@pool-108-31-210-40.washdc.fios.verizon.net] has joined #bitcoin-core-dev
03:01 -!- GAit_Alt [~GAit@2-228-102-100.ip191.fastwebnet.it] has joined #bitcoin-core-dev
03:04 -!- wump [~quassel@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
03:05 -!- michagogo_ [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
03:07 -!- Netsplit *.net <-> *.split quits: wumpus, Ylbam, michagogo, GAit, midnightmagic, instagibbs
03:07 -!- GAit_Alt is now known as GAit
03:08 -!- Netsplit over, joins: midnightmagic
03:10 -!- go111111111 [~go1111111@162.244.138.37] has joined #bitcoin-core-dev
03:12 -!- go1111111 [~go1111111@104.200.154.61] has quit [Ping timeout: 256 seconds]
03:13 -!- michagogo_ is now known as michagogo
03:14 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
03:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-jreqsdbhxfwnbdit] has joined #bitcoin-core-dev
03:23 -!- GAit [~GAit@2-228-102-100.ip191.fastwebnet.it] has quit [Ping timeout: 260 seconds]
03:28 -!- GAit [~GAit@2-228-102-100.ip191.fastwebnet.it] has joined #bitcoin-core-dev
03:34 < GitHub148> [bitcoin] laanwj opened pull request #6878: doc: Add developer notes about gitignore (master...2015_10_ignore_files) https://github.com/bitcoin/bitcoin/pull/6878
03:47 < GitHub128> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/923c5e93a90a...bf7c1958d199
03:47 < GitHub128> bitcoin/master 212bcca Tom Harding: Add optional locktime to createrawtransaction...
03:47 < GitHub128> bitcoin/master bf7c195 Wladimir J. van der Laan: Merge pull request #5936...
03:47 < GitHub70> [bitcoin] laanwj closed pull request #5936: [RPC] Add optional locktime to createrawtransaction (master...createraw_locktime) https://github.com/bitcoin/bitcoin/pull/5936
03:49 -!- lightningbot [supybot@2400:8900::f03c:91ff:fedf:3a06] has joined #bitcoin-core-dev
03:59 -!- dcousens [~anon@eth3224.nsw.adsl.internode.on.net] has quit [Ping timeout: 240 seconds]
04:03 -!- wump is now known as wumpus
04:33 < GitHub151> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf7c1958d199...2a1090d4f55c
04:33 < GitHub151> bitcoin/master 287f54f Peter Todd: Add CHECKLOCKTIMEVERIFY (BIP65) soft-fork logic...
04:33 < GitHub151> bitcoin/master cde7ab2 Peter Todd: Add RPC tests for the CHECKLOCKTIMEVERIFY (BIP65) soft-fork...
04:33 < GitHub151> bitcoin/master 65ef372 Peter Todd: Add BIP65 to getblockchaininfo softforks list
04:34 < GitHub0> [bitcoin] laanwj closed pull request #6706: CLTV IsSuperMajority() soft-fork, rebased against v0.10.2 (0.10...cltv-soft-fork-v0.10) https://github.com/bitcoin/bitcoin/pull/6706
04:34  * btcdrak jumps for joy
04:57 < GitHub121> [bitcoin] laanwj opened pull request #6879: doc: mention BIP65 softfork in bips.md (master...2015_10_bip65) https://github.com/bitcoin/bitcoin/pull/6879
05:36 -!- danielsocials [~quassel@124.64.104.198] has joined #bitcoin-core-dev
05:41 < GitHub155> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a1090d4f55c...c719cefc417c
05:41 < GitHub155> bitcoin/master d3b09f6 Alex Morcos: Do not allow blockfile pruning during reindex....
05:41 < GitHub155> bitcoin/master c719cef Wladimir J. van der Laan: Merge pull request #6856...
05:41 < GitHub81> [bitcoin] laanwj closed pull request #6856: Do not allow block file pruning during reindex. (master...noPruneDuringReindex) https://github.com/bitcoin/bitcoin/pull/6856
05:42 < GitHub177> [bitcoin] laanwj pushed 1 new commit to 0.11: https://github.com/bitcoin/bitcoin/commit/dfe55bdc32b5333dcce1a7f2c74628f64028d1fe
05:42 < GitHub177> bitcoin/0.11 dfe55bd Alex Morcos: Do not allow blockfile pruning during reindex....
05:51 -!- treehug8_ [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:09 < GitHub89> [bitcoin] jgarzik pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/c719cefc417c...46f74379b86b
06:09 < GitHub89> bitcoin/master 6ec4b7e Jeff Garzik: leveldbwrapper: Remove unused .Prev(), .SeekToLast() methods...
06:09 < GitHub89> bitcoin/master 8587b23 Jeff Garzik: leveldbwrapper symbol rename: Remove "Level" from class, etc. names
06:09 < GitHub89> bitcoin/master 3795e81 Jeff Garzik: leveldbwrapper file rename to dbwrapper.*
06:09 < GitHub179> [bitcoin] jgarzik closed pull request #6873: [cleanup] leveldbwrapper becomes more generic 'dbwrapper' module (master...2015_dbwrapper) https://github.com/bitcoin/bitcoin/pull/6873
06:20 -!- harding [~harding@mail.dtrt.org] has joined #bitcoin-core-dev
06:31 -!- treehug8_ [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
06:35 -!- treehug8_ [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:49 -!- rubensayshi [~ruben@91.206.81.13] has quit [Remote host closed the connection]
08:06 -!- treehug8_ [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
08:08 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
08:12 -!- treehug8_ [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:23 < GitHub199> [bitcoin] gavinandresen opened pull request #6880: New -logtimerelative option to do millisec debug.log timestamps (master...millisec_debuglog) https://github.com/bitcoin/bitcoin/pull/6880
08:30 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds]
08:30 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 255 seconds]
08:31 -!- zxzzt_ [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds]
08:32 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:32 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:33 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:40 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.]
08:41 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:49 -!- maaku__ is now known as maaku
08:58 -!- danielsocials [~quassel@124.64.104.198] has quit [Ping timeout: 255 seconds]
09:22 < GitHub54> [bitcoin] gavinandresen closed pull request #6880: New -logtimerelative option to do millisec debug.log timestamps (master...millisec_debuglog) https://github.com/bitcoin/bitcoin/pull/6880
09:54 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
09:55 -!- matsjj_ [~matsjj@p20030089EA0DC591BC81F9738A7B8A07.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
09:59 -!- gmaxwell [greg@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev
10:17 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
11:07 -!- fkhan [weechat@gateway/vpn/mullvad/x-skroeccqmaqfpcro] has quit [Ping timeout: 260 seconds]
11:21 -!- fkhan [weechat@gateway/vpn/mullvad/x-wbcbtnufevfsefeb] has joined #bitcoin-core-dev
11:23 < GitHub0> [bitcoin] sdaftuar opened pull request #6881: Debug: Add option for microsecond precision in debug.log (master...add-microsecond-timestamps) https://github.com/bitcoin/bitcoin/pull/6881
11:25 -!- Dyanisus [~Dyanisus@unaffiliated/dyanisus] has joined #bitcoin-core-dev
11:26 < maaku> I am leaving bitcoin core development for a while, not sure how long. If someone wants to take over pushing for #6312, #6564, and #6566 please contact me.
11:26 < Dyanisus> why you leaving?
11:27 < btcdrak> maaku: why are you leaing?
11:27 < btcdrak> maaku: we're literally right at the end!
11:28 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
11:28 < Dyanisus> maaku: did you get some sort of subpoena or something?
11:30 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
11:35 < btcdrak> maaku: I've sent you an email about those PRs.
11:52 -!- molly [~molly@unaffiliated/molly] has quit [Quit: //..//..]
12:09 -!- fkhan [weechat@gateway/vpn/mullvad/x-wbcbtnufevfsefeb] has quit [Ping timeout: 252 seconds]
12:13 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 264 seconds]
12:26 -!- fkhan [weechat@gateway/vpn/mullvad/x-pafengwxecqdlpgq] has joined #bitcoin-core-dev
12:47 -!- Guest89666 is now known as pigeons
12:49 -!- CodeShark [~androirc@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 272 seconds]
13:02 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.]
13:16 -!- treehug8_ [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
13:17 < GitHub65> [bitcoin] petertodd opened pull request #6883: Add BIP65 CHECKLOCKTIMEVERIFY to release notes (master...cltv-release-notes-v0.12.0) https://github.com/bitcoin/bitcoin/pull/6883
13:21 < GitHub95> [bitcoin] btcdrak opened pull request #6884: Backport #6566, median-past locktime, rebased against 0.11 (0.11...mpl-0.11) https://github.com/bitcoin/bitcoin/pull/6884
13:28 -!- dhill [~dhill@phengo.phobia.ms] has joined #bitcoin-core-dev
13:28 < dhill> maaku: hi
13:29 < dhill> maaku: regarding checksequenceverify, i ran your tests against btcd, and they all pass
13:29 < dhill> but
13:30 < dhill> +    if (txToSequence & CTxIn::SEQUENCE_LOCKTIME_DISABLED_FLAG)
13:30 < dhill> +        return false;
13:30 < dhill> was not hit
13:30 < dhill> i think there is a dup test in tx_invalid.json
14:21 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
14:43 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
14:50 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
14:59 < maaku> I added btcdrak as a collaborator for my personal repo, so he should be able to update the 'sequencenumbers' 'checksequenceverify' and 'medianpastlocktime' branches
15:32 < btcdrak> maaku: thanks!
16:11 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
16:14 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
16:30 < cfields> sipa: ping. I'm trying to understand the current dnsseed thread behavior. It looks like in the non-proxied case, we resolve all seed nodes and add them to addrman without testing them. In the proxied case, we connect to each resolved entry as a oneshot...
16:30 < cfields> i assume the goal is to query them all once if possible in order to never have to touch 'em again?
16:32 < cfields> just seems a bit unbalanced between the proxy/non-proxy cases, want to be sure i'm not missing anything in the big picture
16:39  * jgarzik wonders about the proxy case behavior
16:40 < jgarzik> cfields, The add-untested logic follows the getaddr logic, where it is unknown possibly garbage data coming in from unknown sources
16:40 < jgarzik> cfields, overall I do think addrman must do a much better job of testing and expiring bad addresses
16:41 < jgarzik> cfields, notably we engage in the poor network behaviors of (1) propagating known bad addresses and (2) repeatedly trying the same dead nodes, in some near-empty-bucket edge cases
16:44 < gmaxwell> The proxy behavior is simply because we cannot do the dns lookup via the proxy. So connecting to the addresses returned (by proxy connecting to the names) was the best thing we could do.
16:44 < cfields> jgarzik: ok, that lines up with how i read it. Looks like in the proxied case where we can't run a query, we just connect to all reachable nodes (query done through the proxy), getaddr on them, and disconnect. seems to me like that'd yield less garbage, but i suppose you're right about letting addrman do it.
16:44 < gmaxwell> It does a less good job of initilizing the state for sure.
16:45 < gmaxwell> not to all reachable nodes, we connect 'to' each dnsseed by name (meaning connect to one of the results of it).
16:45 < cfields> gmaxwell: less good because the dns seeds tend to be much fresher, i assume?
16:46 < jgarzik> dns seeds are fresh and quick and easy and wonderfully centralizing ;p
16:46 < gmaxwell> cfields: no, just less good because it any one of the dnsseed results could be broken or malicious.
16:46 < cfields> gmaxwell: ah right, only one-per-seed that way.
16:46 < jgarzik> notably there is now code that "waits a bit, before checking seeds" to attempt to P2P without DNS seeds
16:46 < gmaxwell> e.g. dns seed returns nodes a,b,c,d,e,f,g  ... and we only end up connecting to g (out of that dns seed's results) and perhaps g gives us useless answers.
16:46 < jgarzik> so DNS seeding is intentionally not immediate
16:47 < cfields> ok, all clear now. thanks.
16:49 < cfields> ok, along those lines, are there concerns (fingerprinting) about hitting the seeds too quickly or uniformly? I don't see any active approach in the current code to avoid that
16:50 < jgarzik> cfields, sure those concerns exist
16:50 < jgarzik> cfields, that's part of the reason why the current code tries to avoid DNS lookups
16:51 < jgarzik> cfields, a DNS seed can build a picture of bitcoin users etc.
16:52 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
16:52 < jgarzik> cfields, Current logic is:  (1) if addrman.size() > 0, Attempt to connect to network given current peer database  (2) If "too few" P2P connections after 11 seconds, perform DNS lookup.
16:52 < cfields> obviously not worried about the seeds themselves, since they're already trusted. more about someone trying to get 2+ entries in a seed's current entries in order to distinguish individuals
16:52 < gmaxwell> cfields: DNS seeds are prohibited by policy from having a TTL less than 60 seconds, so recursive resolution provides some increase in privacy.
16:53 < jgarzik> I think it's quite likely that a single DNS seed might spit out two addresses which are in fact controlled by one person/org
16:53 < gmaxwell> it's almost certan. well plus a substantial number of nodes on the network are sybil attackers in any case.
16:53 < gmaxwell> :P
16:53 < cfields> jgarzik: sure, i'm speaking of the procedure when we do fall into the dns lookup logic.
16:54 < jgarzik> sure.  the logic is dumb:  query all DNS seeds, let addrman sort it out
16:55 < gmaxwell> cfields: addrman knows where addresses came from to e.g. prevent any one source from dominating the table. There is only so much it can do.
16:55 < cfields> ok. no problem with that, just want to be sure i'm understanding the logic that's there
16:55 < gmaxwell> Lack of actual users running nodes provides a very limiting upper bound on how much protection is possible.
16:57 < cfields> got it. thanks jgarzik/gmaxwell.
16:58 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
17:25 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
17:26 -!- CodeShark [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev
17:36 < phantomcircuit> gmaxwell, *substantial*
17:42 -!- danielsocials [~quassel@221.220.232.153] has joined #bitcoin-core-dev
18:03 -!- CodeShark [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 260 seconds]
18:13 -!- danielsocials [~quassel@221.220.232.153] has quit [Ping timeout: 272 seconds]
18:21 -!- danielsocials [~quassel@221.220.232.153] has joined #bitcoin-core-dev
18:34 < phantomcircuit> uh
18:34 < phantomcircuit> yeah we definitely have some kind of memory issue in getblocktemplate
18:34 < phantomcircuit> it's trivial to recreate
18:34 < phantomcircuit> while true;do bitcoin-cli getblocktemplate > /dev/null;done
18:34 < phantomcircuit> is enough
18:42 < phantomcircuit> actually no this is expected
18:43 < phantomcircuit> 4GB dbcache + 1.3GB mempool + 800 MB of ?
18:49 < phantomcircuit> BlueMatt, you have code to walk the cache for stuff nothing depends on?
18:51 < BlueMatt> nope
18:51 < BlueMatt> its not hard, though
19:01 -!- danielsocials [~quassel@221.220.232.153] has quit [Ping timeout: 246 seconds]
19:01 < sipa> there is no "depends"
19:01 < sipa> it's a cache
19:01 < BlueMatt> sipa: you know what he meant
19:04 < sipa> it's expected tgat gbt increases the cache size, as it will pull in all dependencies
19:04 < BlueMatt> sipa: indeed, not sure what phantomcircuit is seeing is unexpected or not, but the graphs in the ml related to https://github.com/bitcoin/bitcoin/issues/6876 are not expected at all
19:06 < sipa> well i have no idea what the gbt code is all doing
19:09 -!- Dyanisus [~Dyanisus@unaffiliated/dyanisus] has quit [Ping timeout: 256 seconds]
19:14 < phantomcircuit> BlueMatt, what im seeing is 6.3GB of ram being used with dbcache=4096
19:15 < BlueMatt> phantomcircuit: in dbcache? that sounds about right
19:15 < phantomcircuit> and calling gettxoutsetinfo (which calls FlushStateToDisk) not changing that
19:15 < BlueMatt> oh
19:15 < BlueMatt> hmm
19:20 < sipa> GBT copies a significant portion of the cache into its own view
19:20 < sipa> so it can pretty much double the memory usage
19:22 < phantomcircuit> sipa, yeah but that view is destroyed at the end of the CreateNewBlock call
19:22 < sipa> does change your res
19:22 < sipa> *doesn't
19:22 < phantomcircuit> right because of memory allocation stuff
19:23 < sipa> fragmentation etc
19:23 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:27 < phantomcircuit> sipa, hmm boost::unordered_map is buckets so make expanding easier
19:35 < phantomcircuit> im not sure that's it though since memory usage just jumped 700MB more
19:35 < phantomcircuit> i cant imagine that's from fragmentation alone
19:36 < sipa> well if there is 800 MB chaonstatr depended on by the mempool, then GBT will add another 800 MB
19:37 < sipa> fragmentation just makes it not able to release it back
19:37 < phantomcircuit> chainstate?
19:38 < sipa> yes
19:38 < sipa> typing in a driving car on a small keyboard
19:42 < phantomcircuit> oh duh right they're separate
19:45 -!- fanquake [~Adium@unaffiliated/fanquake] has joined #bitcoin-core-dev
20:02 -!- Dyanisus [~Dyanisus@unaffiliated/dyanisus] has joined #bitcoin-core-dev
20:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-jreqsdbhxfwnbdit] has quit [Quit: Connection closed for inactivity]
20:08 -!- Dyanisus [~Dyanisus@unaffiliated/dyanisus] has left #bitcoin-core-dev ["Leaving"]
20:28 -!- fanquake [~Adium@unaffiliated/fanquake] has quit [Quit: Leaving.]
20:28 -!- danielsocials [~quassel@221.220.232.153] has joined #bitcoin-core-dev
20:30 -!- Guest6474 [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has quit [Ping timeout: 265 seconds]
20:30 -!- maaku__ [~quassel@173-228-107-141.dsl.static.fusionbroadband.com] has joined #bitcoin-core-dev
20:33 < morcos> the problem with GBT is it can create that much memory usage per each of the RPC threads
20:34 -!- danielsocials [~quassel@221.220.232.153] has quit [Ping timeout: 252 seconds]
20:34 < morcos> each thread allocates the memory in a separate arena, and even though the objects are destroyed at the end of the call, there tends to be enough fragmentation that the memory isn't entirely free
20:36 < morcos> in addition, if your chainstate expands during an RPC call (such as due to GBT) enough to cause a rehash of the unordered map
20:36 < morcos> then this also will be allocated in a new arena, and possibly all the old chainstate won't be cleaned up
20:38 < morcos> phantomcircuit: sipa: ^  not sure if you followed the earlier conversation i had with wumpus and gmaxwell about this
20:42 -!- jgarzik_ [~jgarzik@104-178-201-106.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
20:42 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has quit [Read error: Connection reset by peer]
20:45 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:00 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
21:08 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
21:19 -!- maaku [~quassel@botbot.xen.prgmr.com] has quit [Read error: Connection reset by peer]
21:23 -!- jgarzik_ is now known as jgarzik
21:23 -!- jgarzik [~jgarzik@104-178-201-106.lightspeed.tukrga.sbcglobal.net] has quit [Changing host]
21:23 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has joined #bitcoin-core-dev
21:27 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has quit [Remote host closed the connection]
21:30 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
21:32 -!- danielsocials [~quassel@221.220.232.153] has joined #bitcoin-core-dev
21:55 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
21:58 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 255 seconds]
22:20 -!- danielsocials [~quassel@221.220.232.153] has quit [Ping timeout: 252 seconds]
22:58 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Quit: .]
23:00 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
23:01 < cfields> gmaxwell: for backlog, i added in Tor's RESOLVE extension to SOCKS5 so that we can query all seeds up front without making actual node connections. Not sure if there's any real benefit, but it was trivial to add.
23:04 < wumpus> cfields: nice
23:33 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]