--- Day changed Fri Nov 13 2015 00:01 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 00:09 < sipa_> gmaxwell: i rebased it 00:09 < sipa_> it conflicted with the PIE change in Makefile.am 00:09 < sipa_> only the full validation pull conflicted, but Ibdidn't bother looking and rebased both 00:16 -!- mably [56401ed0@gateway/web/freenode/ip.86.64.30.208] has joined #bitcoin-core-dev 00:26 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 260 seconds] 00:40 -!- mably [56401ed0@gateway/web/freenode/ip.86.64.30.208] has quit [Ping timeout: 246 seconds] 00:40 < BlueMatt> jonasschnelli's pgp key isnt signed at all :( 00:43 -!- fkhan [weechat@gateway/vpn/mullvad/x-ukhjypffubvqyonq] has quit [Ping timeout: 255 seconds] 00:45 -!- mably [56401ec3@gateway/web/freenode/ip.86.64.30.195] has joined #bitcoin-core-dev 00:48 < wumpus> we should definitely change that 00:49 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 00:56 -!- fkhan [weechat@gateway/vpn/mullvad/x-iruedugszfxodfum] has joined #bitcoin-core-dev 00:56 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 00:56 -!- aburan28 [~xypher@static-108-45-93-78.washdc.fios.verizon.net] has quit [Ping timeout: 244 seconds] 00:58 < BlueMatt> where in .ch is jonasschnelli anyway? could probably go meet up with sipa, if no one else 01:00 < CodeShark_> in europe, nothing is very far away (except russia) :p 01:01 < wumpus> he has met up with sipa a few times IIRC 01:01 < wumpus> and he was in Montreal. I can confirm jonasschnelli is a real person :p 01:02 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Quit: Arnavion] 01:02 < BlueMatt> wumpus: yes, he was around then 01:03 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ymwvyiwlvagetqzk] has joined #bitcoin-core-dev 01:03 < sipa_> BlueMatt: not in Zurich 01:04 < CodeShark_> there are counties in california with a bigger area than switzerland :p 01:05 -!- mably [56401ec3@gateway/web/freenode/ip.86.64.30.195] has quit [Quit: Page closed] 01:05 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 01:06 < CodeShark_> or at least one county 01:06 < CodeShark_> san bernadino county is larger than switzerland by area 01:08 < CodeShark_> incidentally, san francisco is the smallest county in california by area 01:11 < GitHub86> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/38ed190eefcc...24c4841d1686 01:11 < GitHub86> bitcoin/master 01afa80 Wladimir J. van der Laan: doc: Remove mention of pulltester from README.md... 01:11 < GitHub86> bitcoin/master 24c4841 Wladimir J. van der Laan: Merge pull request #6998... 01:11 < GitHub153> [bitcoin] laanwj closed pull request #6998: doc: Remove mention of pulltester from README.md (master...2015_11_readme_pull_pulltester) https://github.com/bitcoin/bitcoin/pull/6998 01:12 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 01:35 -!- jl2012 [~jl2012@unaffiliated/jl2012] has quit [Ping timeout: 240 seconds] 01:36 -!- jl2012 [~jl2012@unaffiliated/jl2012] has joined #bitcoin-core-dev 01:45 -!- rubensayshi [~ruben@91.206.81.13] has joined #bitcoin-core-dev 01:51 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 260 seconds] 02:35 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Quit: she's probably out making total destroy on all of the things] 02:45 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 02:45 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Client Quit] 02:58 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 03:03 < GitHub28> [bitcoin] laanwj opened pull request #7003: doc: Add non-style-related development guidelines (master...2015_11_development_guidelines) https://github.com/bitcoin/bitcoin/pull/7003 03:03 < fanquake> Looking forward ot being able to attend one of the meetups some day 03:03 < wumpus> where are you based fanquake? 03:03 < fanquake> Western Australia 03:04 < fanquake> To far away from everywhere 03:04 < wumpus> whoa, you could say so :) 03:05 < wumpus> development is pretty distributed over the world as it is, that's nice 03:05 < fanquake> Yea, even inside West Aus, I used to live on a farm 100km from the nearest city. 03:05 < fanquake> So building precision agriculture software atm. 03:05 < fanquake> Only place we wouldn't have a developer might be in asia? 03:06 < jonasschnelli> BlueMatt: yes. I need to get my gpg key signed... will try to get some signatures within the next days. 03:06 < wumpus> cool. I think agriculture is one place where software can still change a lot 03:06 < wumpus> did you see my PM about gpg keys jonasschnelli? 03:06 < fanquake> absolutely, the adoption cycle is quite slow also, lots of oppoutunity for innovation. 03:08 < wumpus> no I don't think we have anyone in Asia, maybe some drive-by contributores but no one who stuck around 03:34 < GitHub106> [bitcoin] jonasschnelli opened pull request #7004: update jonasschnellis gpg key (master...2015/11/signing_key_jonasschnelli) https://github.com/bitcoin/bitcoin/pull/7004 03:36 < sdaftuar> \ 03:40 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:41 < Luke-Jr> jonasschnelli: why a new key? :/ 03:41 < michagogo> Hm, the signer failed on 0.11.2 03:41 < wumpus> michagogo: what error? 03:42 < michagogo> tar: signature/osx: Cannot read: Is a directory 03:43 < michagogo> Maybe it's because I just signed 0.10.4 03:43 < wumpus> weird - are you using the commands from the right build process, and descriptors from the right version? 03:43 < michagogo> I rm'd the flag file that tells my script it can reuse the existing target for the mac signer, rerunning now 03:44 < michagogo> I should be -- I have a script that does all that 03:44 < michagogo> (checks out the tag, etc) 03:44 < michagogo> And yeah, I have separate versions for 0.10 and 0.11 03:44 < Luke-Jr> sdaftuar: where is the debug file for the test? 03:44 < michagogo> (I probably could have made it one script, but I was lazy/in a hurry when I made it) 03:45 < michagogo> Anyway, it's running again now with a fresh vm 03:46 < wumpus> yes I have a series of scripts for those things too, lots of subtle differenes 03:48 < michagogo> Hm, wt 03:48 < michagogo> f 03:48 < michagogo> http://paste.ubuntu.com/13246889/ 03:48 < michagogo> OH 03:48 < michagogo> wait 03:48 * michagogo check something 03:48 < michagogo> checks* 03:49 * wumpus blames his lack of ruby chops for, instead of attacking gitian directly, writing tons of wrapper scripts around it :-) 03:49 < michagogo> Dammit 03:50 < michagogo> The 0.10 build clobbered the 0.11 unsigned package 03:50 < michagogo> Got a copy? (don't worry, I'll check the hash) 03:50 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 03:51 < wumpus> hm not sure I don't have it anymore, which one do you need mac or win or both? 03:51 < michagogo> Mac 03:51 < michagogo> (we don't do detached win signing for 0.10, thankfully) 03:51 < michagogo> fanquake: around? 03:52 < michagogo> Do you have a copy of the 0.11.2 Mac unsigned tarball? 03:52 < michagogo> I wish the way gitian did inputs didn't force us to have unversioned filenames 03:54 < wumpus> agreed 03:59 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:59 < Luke-Jr> michagogo: eh, they're not unversioned 03:59 < Luke-Jr> http://luke.dashjr.org/programs/bitcoin/files/bitcoind/0.11.2/ 03:59 < wumpus> would be nice to fix some long-running complaints about how gitian handles things some time (also the "output files are nuked" on next run), if I wasn't already completely overloaded 04:00 < wumpus> Luke-Jr: not al, but the intermediate files for signing have to be 04:00 < michagogo> bitcoin-osx-unsigned.tar.gz 04:00 < Luke-Jr> the file gitian generates is bitcoin-0.11.2-osx-unsigned.tar.gz 04:01 < michagogo> The input is unversioned 04:01 < wumpus> Luke-Jr: you're right 04:01 < michagogo> Maybe I could move the unsigned bundle, 04:01 < wumpus> but to copy it into inputs, it needs to be made unversions 04:02 < michagogo> And then copy it to the generic name prebuild 04:02 < michagogo> That would probably work, actually 04:02 < wumpus> 0.11.2 binaries are live: https://bitcoin.org/bin/bitcoin-core-0.11.2/ 04:03 < Luke-Jr> wumpus: ! but we don't have 3 sigs yet 04:03 < Luke-Jr> (on the signed bins, that is) 04:04 < wumpus> OK, won't do the official announcement (and merge it on the site) yet, then 04:04 < michagogo> Luke-Jr: we will momentarily 04:06 < michagogo> (Thanks, grabbed the unsigned bundle) 04:07 < michagogo> wumpus: you could kick off the Travis rebuild on the PR for the site 04:09 < wumpus> still have to fill in the torrent magnet link anyhow 04:10 < michagogo> wumpus: can do that after 04:10 < michagogo> Uh, wtf? 04:10 < michagogo> gzip: stdin: not in gzip formal 04:10 < michagogo> Format 04:10 * michagogo checks something 04:11 < michagogo> Hmm. 04:12 < michagogo> Oh, that was me being stupid 04:12 * michagogo sighs 04:13 < michagogo> I took the dmg instead of the tarvall 04:13 < midnightmagic> :-/ 04:14 < midnightmagic> my gitian sigs aren't matching up anymore. 04:14 < midnightmagic> but I have to go to bed, so I'll debug it tomorrow. 04:14 < michagogo> Okay, THIS time it should work 04:22 * michagogo points at the PR page 04:27 < GitHub22> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/24c4841d1686...d2e987aa1929 04:27 < GitHub22> bitcoin/master b27e81f MarcoFalke: [net] Cleanup maxuploadtarget... 04:27 < GitHub22> bitcoin/master 9c3ee3b MarcoFalke: [doc] Add -maxuploadtarget release notes 04:27 < GitHub22> bitcoin/master d2e987a Wladimir J. van der Laan: Merge pull request #6958... 04:27 < GitHub8> [bitcoin] laanwj closed pull request #6958: [trivial] Cleanup maxuploadtarget (doc & log) (master...MarcoFalke-2015-maxupload) https://github.com/bitcoin/bitcoin/pull/6958 04:37 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:40 -!- ParadoxSpiral [~ParadoxSp@p508B8A0F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:12 < michagogo> Merged \o/ 05:14 < wumpus> yes, sent announcement mail 05:16 < michagogo> https://www.reddit.com/r/Bitcoin/comments/3snpg9/bitcoin_core_version_0112_released_bringing_the/ as well 05:16 < michagogo> Erm, oops, forgot the website doesn't update in realtime 05:16 < wumpus> takes a few minutes at most 05:23 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Quit: Leaving.] 05:24 < wumpus> site is updated 05:27 < michagogo> Are you opped in #bitcoin? 05:27 < michagogo> (for the topic) 05:37 < michagogo> wumpus: hm, my torrent client is telling me the demonii tracker doesn't exist 05:40 -!- sipa_ is now known as sipa 05:42 < wumpus> "Seeding to 0 of 0 peers" hmm maybe the torrent tracker needs some time to spin up too 05:47 < wumpus> and all the trackers except tracker.coppersurfer.tk give me "Connection failed" 05:50 -!- sipa [~pw@2a02:348:86:3011::1] has quit [Changing host] 05:50 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev 05:52 < fanquake> wumpus Who should be adding their key to trusted-keys? 05:52 < wumpus> fanquake: people that merge things 05:53 < fanquake> Is Jonass being given GH merge access? 05:53 < wumpus> yep 05:54 < wumpus> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2015-November/011728.html 06:29 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds] 06:30 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:40 < jonasschnelli> [12:41:14] jonasschnelli: why a new key? :/ <-- the new key is not really new, It's just the one that I use for bitcoin-dev posts, etc. The "old" key is used for non-bitcoin software-projects (and sadly, i have used it for gitian signatures) 06:47 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 07:11 < sdaftuar> Luke-Jr: around? 07:16 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Quit: Leaving.] 07:21 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 07:25 -!- zooko [~user@72.42.70.227] has joined #bitcoin-core-dev 07:25 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:33 < GitHub147> [bitcoin] jgarzik opened pull request #7005: Add MAINTAINERS file, a user guide to code subsystems (master...2015_maintainer) https://github.com/bitcoin/bitcoin/pull/7005 07:34 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 07:38 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Ping timeout: 260 seconds] 07:38 < GitHub21> [bitcoin] jonasschnelli opened pull request #7006: [Qt] add startup option to reset Qt settings (master...2015/11/qt_resetsettings) https://github.com/bitcoin/bitcoin/pull/7006 07:52 < GitHub104> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d2e987aa1929...4f09b77c7fa5 07:52 < GitHub104> bitcoin/master 1d84107 Pieter Wuille: Squashed 'src/secp256k1/' changes from 22f60a6..2bfb82b... 07:52 < GitHub104> bitcoin/master 9e475d5 Pieter Wuille: Update libsecp256k1 07:52 < GitHub104> bitcoin/master 48edf57 Pieter Wuille: Update key.cpp to new secp256k1 API 07:52 < GitHub8> [bitcoin] sipa closed pull request #6983: Update libsecp256k1 (master...secp256k1new) https://github.com/bitcoin/bitcoin/pull/6983 07:52 < GitHub75> [bitcoin] morcos opened pull request #7007: Fix bug in unit mempool_tests unit test (master...unitTestBugFix) https://github.com/bitcoin/bitcoin/pull/7007 07:54 -!- fanquake [~Adium@unaffiliated/fanquake] has quit [Quit: Leaving.] 08:06 < GitHub121> [bitcoin] morcos opened pull request #7008: Lower bound priority (master...lowerBoundPriority) https://github.com/bitcoin/bitcoin/pull/7008 08:08 < morcos> Luke-Jr: When you get a chance, please see #7008. I think you had indicated that if at least originally in chain inputs age, that would be close enough. Upon further reflection, I think this is a much better compromise than trying to put through the full #6357 dynamic priority calculation. (it's basically a small subset) 08:11 < wumpus> jonasschnelli: you can set the 'GUI' label yourself now :) say on https://github.com/bitcoin/bitcoin/pull/7006 08:11 < jonasschnelli> wumpus: hah. Right. I missed that. Done! 08:21 < btcdrak> sipa: wonderful! 08:46 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 09:04 -!- rubensayshi [~ruben@91.206.81.13] has quit [Remote host closed the connection] 09:22 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Quit: Leaving.] 09:37 < GitHub165> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4f09b77c7fa5...d3565604e3d9 09:37 < GitHub165> bitcoin/master a78e6ea Alex Morcos: Fix bug in mempool_tests unit test 09:37 < GitHub165> bitcoin/master d356560 Wladimir J. van der Laan: Merge pull request #7007... 09:38 < GitHub155> [bitcoin] laanwj closed pull request #7007: Fix bug in mempool_tests unit test (master...unitTestBugFix) https://github.com/bitcoin/bitcoin/pull/7007 09:55 -!- zooko [~user@72.42.70.227] has quit [Ping timeout: 276 seconds] 10:24 -!- zooko [~user@72.42.70.227] has joined #bitcoin-core-dev 11:08 < Luke-Jr> sdaftuar: 11:09 < sdaftuar> Luke-Jr: i wanted to follow up on the issue you reported with that bip65-cltv-p2p test this morning. i updated the issue with my observations 11:10 < Luke-Jr> k, catching up on emails now, so I haven't seen it yet 11:15 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:21 < Luke-Jr> sdaftuar: I don't have any env vars set related to Bitcoin 11:21 < sdaftuar> odd. any ideas why it's running the wrong binary? 11:21 < Luke-Jr> maybe because the build never puts bitcoind in the checkout dir.. 11:21 < Luke-Jr> why is that the default? 11:22 < sdaftuar> er, i think i meant checkout-dir/src 11:22 < sdaftuar> anyway not sure, that's how all the rpc tests have ever worked as far as i know 11:22 < Luke-Jr> well, setting BITCOIND to $PWD/src/bitcoind fixes it 11:23 < sdaftuar> ok cool 11:23 < sdaftuar> oh -- i think you're supposed to run the rpc-tests from the rpc-tests directory. does that also fix it? 11:25 * Luke-Jr waits for his new build to finish to test that 11:26 -!- zooko [~user@72.42.70.227] has quit [Ping timeout: 252 seconds] 11:32 < GitHub138> [bitcoin] gmaxwell pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/dbd2c135ddb96bdc3a4e870c2371cb1fac227135 11:32 < GitHub138> bitcoin/master dbd2c13 Gregory Maxwell: Merge pull request #6990... 11:32 < GitHub117> [bitcoin] gmaxwell closed pull request #6990: http: speed up shutdown (master...2015_11_threadexit) https://github.com/bitcoin/bitcoin/pull/6990 11:37 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:40 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:43 < gmaxwell> Is the torcontrol port password basically ever empty? 12:02 < morcos> I asked this in bitcion-mining but got no response. I'm 95% sure this couldn't have been caused by my changes to CreateNewBlock, but of the 20 testnet blocks I mined, one was invalid 12:02 < morcos> ERROR: CheckBlock(): hashMerkleRoot mismatch 12:02 < morcos> Anybody have any idea why that might have happened? 12:02 < morcos> It was invalid after being submitted by the miner, not in the TestBlockValidity from CreateNewBlock 12:02 < gmaxwell> eerk 12:03 < morcos> yeah thats kind of my response 12:03 < gmaxwell> Not a known behavior. Possibly that the transmission from the miner got truncated? 12:03 < gmaxwell> phantomcircuit: seen anything like that? ^ 12:43 -!- zooko [~user@72.42.70.227] has joined #bitcoin-core-dev 12:46 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 12:55 < GitHub157> [bitcoin] petertodd opened pull request #7010: Fix fundrawtransaction handling of includeWatching (master...2015-11-fix-fundrawtransaction-bugs) https://github.com/bitcoin/bitcoin/pull/7010 13:16 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 13:17 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:20 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 13:24 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 13:25 < phantomcircuit> morcos, what where you using to mine? 13:25 < morcos> phantomcircuit: antminer s7 13:26 < kanzure> BlueMatt: strange that fundrawtransaction with watchonlys/includewatching has been so difficult to get correct 13:26 < kanzure> BlueMatt: maybe we're trying to stuff too much into that function 13:27 < phantomcircuit> morcos, what stratum software? 13:27 < phantomcircuit> unless you were running bfgminer w/ getblocktemplate you need something else in the middle 13:27 < BlueMatt> kanzure: hmm? the latest bugs have been in the rpc wrapper for the function 13:27 < morcos> phantomcircuit: i was using the installed cgminer 4.8 to connect directly to bitcoind 13:27 < BlueMatt> kanzure: the actual function was rather doable 13:27 < kanzure> BlueMatt: well, ok. fair. comment rescinded. 13:27 < morcos> it seems to support getblocktemplate 13:27 < BlueMatt> kanzure: and, really, there's only been one actual bug? (the assume-if-argument-bool-is-true) 13:28 < phantomcircuit> morcos, i doubt very much that cgminer correctly implements getblocktemplate 13:28 < kanzure> BlueMatt: the previous implementation had some issues too. but your version fixed those. 13:28 < kanzure> BlueMatt: but yes your point about the rpc wrapper is sufficient to explain this. 13:28 < gmaxwell> phantomcircuit: would be useful to know how it doesn't assuming it doesn't. 13:29 < morcos> phantomcircuit: ok... maybe i'll stick some stratum software in the middle then and try that instead. what would you recommend 13:29 < gmaxwell> phantomcircuit: not just cgminer but whatever is on the miner, dunno about s7 but prior ones have all been really old versions. 13:29 < phantomcircuit> morcos, need a tcpdump of the rpc calls to diagnose 13:30 < phantomcircuit> morcos, eloipool 13:30 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 13:30 < BlueMatt> kanzure: yea, the previous version did, but thats what code review is for :) (it forces us to not implement hacky things and to do it The Right Way (tm) so that we fix subtle bugs) 13:30 < morcos> phantomcircuit: i was trying to play around with that, and the debugging from cgminer is either a flood or nothing useful. now i'm hacking up bitcoind to try to just dump any submitted blocks anyway, so if it happens again i can manually inspect the block 13:31 < morcos> for what its worth, it mostly seems to mine fine 13:31 < Luke-Jr> morcos: cgminer's GBT "support" is /probably/ broken 13:31 < gmaxwell> morcos: might be a worthwhile thing to just support as an option. savesubmitblocks=1 13:32 < Luke-Jr> morcos: I'd suggest BFGMiner over Eloipool FWIW 13:32 < phantomcircuit> morcos, to debug i'd also need the block templates though, so a tcpdump would be best 13:32 < morcos> gmaxwell: ha ha, well i'll let someone else write that, my version has already coredumped a few times 13:32 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 13:33 < morcos> phantomcircuit: ok, well its not happening often enough for that right now.. maybe i'll hack up something to decrease the difficulty or do somehting on regtest, but at this point its all going to have to wait for next week 13:33 < morcos> thanks for your help... i'll ping you when i have more info. also. stop orphaning my testnet blocks! 13:34 < phantomcircuit> morcos, ha 13:34 < phantomcircuit> an excellent demonstration of what low block intervals do to centralization :P 13:39 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 13:39 < GitHub38> [bitcoin] petertodd opened pull request #7011: Add mediantime to getblockchaininfo (master...2015-11-add-mediantime-to-getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/7011 13:40 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 13:43 -!- skyraider [uid41097@gateway/web/irccloud.com/x-atsrxeplycbyniho] has joined #bitcoin-core-dev 13:43 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Quit: Leaving.] 13:44 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 13:50 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 276 seconds] 13:52 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:55 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 14:09 < morcos> Luke-Jr: any chance you got to look at 7008? 14:09 < morcos> I'm hoping you are ok with closing the dynamicPriority pull (6357) and focusing attention on something more likely to be ok with everyone 14:10 < Luke-Jr> morcos: not planning to, as I strongly prefer #6357 14:10 < phantomcircuit> CodeShark, can you comment on issue 7012 ? 14:10 < morcos> Luke-Jr: hmm, ok then maybe i misunderstood you the other day 14:11 < Luke-Jr> morcos: I may have said something suggesting this, before I understood 6357 to be inexpensive 14:11 < morcos> I thought you did not like using starting priority as an approximation, but that you thought priority where aging did happen but only affected originally confirmed inputs was ok 14:12 < Luke-Jr> morcos: it's okay, if the alternative is expensive. 14:12 < Luke-Jr> but if it's not expensive, there is no reason to cheat on it 14:12 < morcos> Luke-Jr: well fundamentally part of my problem is just merge conflicts 14:13 < morcos> I want to fix the issue you pointed out with sigops having a default value 14:13 < morcos> but both priority pulls and sdaftuars mempool reorg pull all change the signature of TxMemPoolEntry constructor 14:13 < Luke-Jr> morcos: my plan right now, is to deep-review 6357 and write tests (unless you get to that first) 14:13 < morcos> 6357 is tested by having the priority recalced in mempool.check 14:14 < morcos> but yes more tests couldn't hurt 14:14 < Luke-Jr> morcos: I mean unit tests 14:14 < Luke-Jr> something Travis will detect breaking 14:15 < morcos> If I rebased 6357 on top of 7008, would you be willing to get 7008 merged. its really a precursor anyway, and the change to the constructor is the same. 14:15 < morcos> i'm going away at the end of next week, and i need to get all these merge conflicts sorted so we can get the createnewblock pull merged 14:16 < morcos> i'm perfectly happy with 6357, but lets not let the perfect be the enemy of the good.. getting 7008 in at least lets us do everything else. if we also get 6357, then great. but we haven't held up progress 14:21 < GitHub74> [bitcoin] petertodd opened pull request #7013: Remove LOCK(cs_main) from decodescript (master...2015-11-remove-cs-main-from-decodescript) https://github.com/bitcoin/bitcoin/pull/7013 14:34 < Luke-Jr> morcos: I'm not willing to ACK the createnewblock pull until 6357 is merged, so I'm not sure what the point is. 14:34 < Luke-Jr> rebasing 6357 on top of 7008 may be better just structually though 14:35 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Ping timeout: 260 seconds] 14:42 < morcos> Luke-Jr: I'm not sure whether or not 6357 will get merged. If not, the original plan was to put createnewblock pull back to the way I first had it. so it still calls the CCoinsViewCache GetPriority function which is right but slow. 14:42 < morcos> this will preserve the ability to do old policy, but limit a significant part of the speed up to code that does not use that policy 14:44 < morcos> to be clear, i'm happy for you or anyone else to appropriate the pulls and do the right thing, but i won't be around to make the changes past the first 4 days of next week 14:44 < morcos> so i'd like to leave things in the most likely to be merged state before that point. 14:45 < Luke-Jr> morcos: maybe push branches for each possibility, and I'll do what I can to keep things moving? 14:47 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 14:48 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 14:55 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Read error: Connection reset by peer] 14:56 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 14:56 -!- zooko [~user@72.42.70.227] has quit [Ping timeout: 252 seconds] 15:07 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:07 -!- bitdevsnyc [~bitdevsny@cpe-74-68-119-97.nyc.res.rr.com] has joined #bitcoin-core-dev 15:08 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:46 -!- bitdevsnyc [~bitdevsny@cpe-74-68-119-97.nyc.res.rr.com] has quit [] 15:47 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:52 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:52 -!- skyraider [uid41097@gateway/web/irccloud.com/x-atsrxeplycbyniho] has quit [Quit: Connection closed for inactivity] 16:06 -!- squidicuz [~squid@pool-173-48-117-206.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again] 16:24 < gmaxwell> wumpus: jonasschnelli: Care to give me a quick design sniff test? I'm thinking of having someone implement functionality for external signers in Bitcoin core along these lines, http://0bin.net/paste/7HCkLWNJBDqJB7Up#hPgdwfs06m7FJw-WQZUCBNTNfCZnrix2K0Mo++6jpbH 16:25 < gmaxwell> I realize that some might want a more extensive wallet redesign, but I think this would be good incremental progress and would enable a _lot_ of flexibility for minimal code impact. 16:29 -!- Squidicuz [~squid@pool-173-48-117-206.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 17:13 -!- JackH [~Jack@host-80-43-141-3.as13285.net] has quit [Ping timeout: 276 seconds] 17:45 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:53 -!- ParadoxSpiral [~ParadoxSp@p508B8A0F.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 17:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ymwvyiwlvagetqzk] has quit [Quit: Connection closed for inactivity] 18:16 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 18:21 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 19:52 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 19:55 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 260 seconds] 20:00 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 20:00 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 20:33 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Quit: .] 20:33 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 20:37 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:00 -!- tulip [~tulip@128.199.135.43] has joined #bitcoin-core-dev --- Log closed Fri Nov 13 21:09:23 2015 --- Log opened Fri Nov 13 21:10:00 2015 21:10 -!- kanzure_ [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 21:10 -!- Irssi: #bitcoin-core-dev: Total of 79 nicks [0 ops, 0 halfops, 0 voices, 79 normal] 21:10 -!- nkuttler_ [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 21:10 -!- petertod1 [~pete@ec2-52-5-185-120.compute-1.amazonaws.com] has joined #bitcoin-core-dev 21:10 -!- tripleslash_l [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 21:14 -!- Netsplit *.net <-> *.split quits: tripleslash, nkuttler, kanzure, petertodd, bsm117532 21:14 -!- nkuttler_ is now known as nkuttler 21:15 -!- Netsplit over, joins: bsm117532 21:17 < GitHub147> [bitcoin] gmaxwell pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/dbd2c135ddb9...e0a5ef84272b 21:17 < GitHub147> bitcoin/master 61e1eb2 Peter Todd: Actually use includeWatching value in fundrawtransaction... 21:17 < GitHub147> bitcoin/master 10953a7 Peter Todd: Better error message for fundrawtransaction w/ empty vout... 21:17 < GitHub147> bitcoin/master e0a5ef8 Gregory Maxwell: Merge pull request #7010... 21:18 < GitHub67> [bitcoin] gmaxwell closed pull request #7010: Fix fundrawtransaction handling of includeWatching (master...2015-11-fix-fundrawtransaction-bugs) https://github.com/bitcoin/bitcoin/pull/7010 21:18 -!- Irssi: Join to #bitcoin-core-dev was synced in 562 secs 21:31 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 21:35 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 255 seconds] 21:48 -!- luke-jr_ [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 21:49 -!- pmienk_ [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 21:50 -!- michagogo_ [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 21:51 -!- nkuttler_ [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 21:51 -!- michagogo [uid14316@wikia/Michagogo] has quit [Ping timeout: 250 seconds] 21:51 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 250 seconds] 21:51 -!- teward [teward@ubuntu/member/teward] has quit [Ping timeout: 250 seconds] 21:51 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 250 seconds] 21:51 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has quit [Ping timeout: 250 seconds] 21:51 -!- phantomcircuit [phantomcir@2600:3c01::f03c:91ff:fe73:6892] has quit [Ping timeout: 250 seconds] 21:51 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 250 seconds] 21:51 -!- pmienk [~pmienk@c-71-227-177-179.hsd1.wa.comcast.net] has quit [Ping timeout: 250 seconds] 21:51 -!- zmanian_ [uid113594@gateway/web/irccloud.com/x-ctiruyqstvnupaaf] has quit [Ping timeout: 250 seconds] 21:51 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 250 seconds] 21:51 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 250 seconds] 21:51 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Read error: Connection reset by peer] 21:51 -!- nkuttler_ is now known as nkuttler 21:51 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev 21:52 -!- zmanian_ [uid113594@gateway/web/irccloud.com/x-gsfqmaxordvbkuwq] has joined #bitcoin-core-dev 21:52 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 21:52 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 21:52 -!- michagogo_ is now known as michagogo 21:53 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 21:53 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:54 -!- phantomcircuit [~phantomci@strateman.ninja] has joined #bitcoin-core-dev 21:57 -!- teward [teward@ubuntu/member/teward] has joined #bitcoin-core-dev 21:59 < phantomcircuit> gmaxwell, thoughts on a "-miner" mode that does things like reduce (or even remove) the sleep calls in some of the networking threads? 21:59 < phantomcircuit> (ie please do everything possible to reduce latency even if you spin my cpu at 100% constantly) 22:07 < gmaxwell> phantomcircuit: what sleep calls are there at all in networking? (other than in e.g. connect loops, which are needed to avoid dos attacking peers) 22:08 -!- luke-jr_ is now known as Luke-Jr 22:09 < Luke-Jr> we probably should have a miner mode regardless. relay nodes have no real need for the mempool. 22:09 < Luke-Jr> (they just need to relay and forget, plus some txid record so they can't be DoS'd) 22:10 < phantomcircuit> Luke-Jr, please define relay node more specifically 22:12 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:12 < Luke-Jr> phantomcircuit: a node that wishes to participate (non-leech) in the p2p network, but has no miners 22:12 < phantomcircuit> Luke-Jr, they require a mempool if they are going to forward transactions otherwise they become a DoS amplifier 22:12 < phantomcircuit> gmaxwell, there's a sleep on select() error (im not even sure why that's there actually) 22:12 < Luke-Jr> phantomcircuit: why can't they just remember txids? 22:13 < phantomcircuit> and there's messageHandlerCondition which can be replaced by a spin lock 22:14 < phantomcircuit> there's also a bunch of other things like changing the defaults for various things to be much much larger 22:14 < gmaxwell> Luke-Jr: forgetting things is not so useful for avoiding the 2x++ redundant transmission when the same data shows up again in a block. 22:15 < phantomcircuit> gmaxwell, i'd also add a background thread that just calls CreateNewBlock in a loop trying to improve on the current cached block template 22:16 < Luke-Jr> gmaxwell: hm, that's a point 22:16 < Luke-Jr> phantomcircuit: merely calling CNB won't use/update the cache 22:16 < phantomcircuit> Luke-Jr, yes i know 22:17 * phantomcircuit hand waves details 22:24 < phantomcircuit> Luke-Jr, it'll update every 5 seconds if the memory pool was modified, correct? 22:24 < phantomcircuit> (or the tip changes obviously) 22:25 < Luke-Jr> phantomcircuit: the cache is in the RPC code 22:25 < phantomcircuit> yes i know 22:25 < phantomcircuit> that's the logic though right? (just verifying i read it correctly) 22:27 < gmaxwell> phantomcircuit: I was recommending before that we change the gbt behavior to _never_ run createnewblock at the time the rpc is called. 22:27 < phantomcircuit> gmaxwell, yes that's what i would be implementing, a background thread only 22:29 < phantomcircuit> there's some interesting optimizations that can be done if we're willing to spend a bunch of cpu time on it 22:30 < phantomcircuit> the obvious one is optimizing for the block that pays the highest fee 22:30 < phantomcircuit> (or whatever) 22:44 < wumpus> gmaxwell: concept ACK 22:44 < wumpus> gmaxwell: I'd personally prefer not adding more 'invoke external programs', I know we already have walletnotify etc but it makes sandboxing the thing harder because we can't disable fork/exec 22:45 < wumpus> gmaxwell: I know there is walletnotify, blocknotify etc but at least we have an alternative notification mechanism for that now, so they may be deprecated in some future version 22:51 < wumpus> gmaxwell: anyhow so I'm not strongly against that, just wary of it, also with regard to argument shell injection. Although at least that an be easily avoided by executing a program directly instead of using ::system 22:58 < wumpus> an alternative would be to use a little protocol intead for communicating with the signer 23:00 < gmaxwell> wumpus: hm. we can limit to what we can exec (via seccomp) .. interesting I was thinking the seperate process there was a sandboxing benefit, e.g. because it can have totally distinct selinux / seccomp settings. 23:00 < wumpus> sure, just be really careful 23:00 < gmaxwell> But the biggest reason for the seperate process is to tear down development barriers. E.g. so someone can build a module without the scarryness in bitcoin core. :) 23:00 < wumpus> walletnotify/blocknotify use ::system that has always bugged me 23:01 < wumpus> sure that's why I dont give "integrate it into bitcoin core" as an alternative, but say communicate through a pipe or socket 23:01 < gmaxwell> wumpus: still need a way to start the thing that speaks the protocol. 23:02 < wumpus> could be similar to e.g. torcontrol.cpp which speaks a simple protocol with Tor 23:02 < gmaxwell> But okay, reasonable. 23:02 < wumpus> true 23:02 < wumpus> ok, let's leave that isue for later 23:02 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 23:02 < wumpus> for initial version invoking a process is fine 23:03 < wumpus> just don't use ::system :D 23:03 -!- pigeons [~pigeons@94.242.209.214] has joined #bitcoin-core-dev 23:03 -!- Guest78100 [~pigeons@94.242.209.214] has quit [Ping timeout: 255 seconds] 23:03 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 255 seconds] 23:04 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Ping timeout: 255 seconds] 23:04 -!- pigeons is now known as Guest25458 23:04 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:05 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev 23:24 < GitHub73> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0a5ef84272b...36baa9f47587 23:24 < GitHub73> bitcoin/master b3ae384 Peter Todd: Remove LOCK(cs_main) from decodescript... 23:24 < GitHub73> bitcoin/master 36baa9f Wladimir J. van der Laan: Merge pull request #7013... 23:24 < GitHub81> [bitcoin] laanwj closed pull request #7013: Remove LOCK(cs_main) from decodescript (master...2015-11-remove-cs-main-from-decodescript) https://github.com/bitcoin/bitcoin/pull/7013 23:26 < GitHub151> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/44ac42e50d567b08d3cb3f3c5766588468ce5bbf 23:26 < GitHub151> bitcoin/master 44ac42e Wladimir J. van der Laan: Merge pull request #7004... 23:26 < GitHub79> [bitcoin] laanwj closed pull request #7004: update jonasschnellis gpg key (master...2015/11/signing_key_jonasschnelli) https://github.com/bitcoin/bitcoin/pull/7004 23:47 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 23:50 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 260 seconds] 23:55 < GitHub18> [bitcoin] gmaxwell pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/44ac42e50d56...9ffc687288dd 23:55 < GitHub18> bitcoin/master d61fcff Jonas Schnelli: don't enforce maxuploadtargets disconnect for whitelisted peers 23:55 < GitHub18> bitcoin/master 5760749 Jonas Schnelli: [docs] rename reducetraffic.md to reduce-traffic.md 23:55 < GitHub18> bitcoin/master e495ed5 Jonas Schnelli: add documentation for exluding whitelistes peer from maxuploadtarget 23:55 < GitHub44> [bitcoin] gmaxwell closed pull request #6984: don't enforce maxuploadtarget's disconnect for whitelisted peers (master...2015/11/maxupload_whitebind) https://github.com/bitcoin/bitcoin/pull/6984