--- Day changed Sat Nov 28 2015 00:18 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 272 seconds] 00:25 -!- Ylbam [uid99779@gateway/web/irccloud.com/session] has joined #bitcoin-core-dev 00:25 -!- wump is now known as wumpus 00:30 -!- Amnez777- [~Amnez777@37.157.216.168] has quit [Changing host] 00:30 -!- Amnez777- [~Amnez777@unaffiliated/amnez777] has joined #bitcoin-core-dev 00:30 -!- Amnez777- is now known as Amnez777 00:35 -!- CodeShark_ [CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 240 seconds] 00:51 -!- Guest6056 is now known as petertodd 00:51 -!- Ylbam [uid99779@gateway/web/irccloud.com/session] has quit [Changing host] 00:51 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-zajqjulcxzyeqdvq] has joined #bitcoin-core-dev 01:44 < GitHub62> [bitcoin] robegan21 opened pull request #7122: simple fix to mask command line arguments after they are copied (master...MaskCommandLineArgs) https://github.com/bitcoin/bitcoin/pull/7122 01:52 -!- Guest44645 [~ParadoxSp@p508B9162.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:59 -!- d_t_ [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:27 < GitHub170> [bitcoin] gmaxwell opened pull request #7123: [WIP] Make trickle logic useful again, delay trickle when past upload limit. (master...actually_trickle) https://github.com/bitcoin/bitcoin/pull/7123 02:36 -!- Guest36383 [uid115429@gateway/web/irccloud.com/x-yjhlfmaugpqhkuob] has quit [Quit: Connection closed for inactivity] 02:43 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Quit: Leaving.] 02:58 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 03:05 < phantomcircuit> sipa, i guess i dont actually care that maxsigcachesize= isn't compatible since the chainstate isn't either 03:06 < sipa> chainstate isn't? 03:06 < sipa> between which versions? 03:13 < phantomcircuit> sipa, 0.12.0 -> 0.11.2 03:13 < phantomcircuit> because of obfuscation 03:14 < phantomcircuit> oh actually it doesn't need to be changed 03:14 < phantomcircuit> anybody who set it and goes to 0.12.0 will run out of memory 03:16 < sipa> eh, we should change the name :) 03:16 < sipa> grr, where did i put my glasses last noght? 03:22 < gmaxwell> lol 100000 mb memory usage. darn non-typesafty of commandlines. 03:22 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 03:23 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 03:24 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 03:24 < sipa> foubd! 03:30 -!- cocoBTC [~cocoBTC__@c-233a71d5.136-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 03:35 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.] 03:36 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 03:37 -!- arowser_ [~quassel@106.120.101.38] has joined #bitcoin-core-dev 03:38 -!- arowser [~quassel@2001:0:53aa:64c:20cb:3acf:9587:9ad9] has quit [Ping timeout: 264 seconds] 03:55 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.] 03:58 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 04:00 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 04:15 < phantomcircuit> gmaxwell, any opposition to adding a new checkpoint (keeping in mind that it's just to skip script validation now) 04:23 < gmaxwell> Yes. 04:23 < gmaxwell> As in yes, I'm opposed to doing that. 04:24 < gmaxwell> The difference in validation time is basically negligible now; and to the extent that it's not we should address it by implementing the latching worth threshold shortcutting. 04:24 < phantomcircuit> gmaxwell, failed to parse the last part of that sentence 04:25 < gmaxwell> If the saved verification time isn't enough to justify implementing the real solution, then it's not enough to justify perpetuating the terrible screwup of checkpoints that causes material harm to the ecosystem in several ways. 04:26 < phantomcircuit> ah right 04:27 < gmaxwell> phantomcircuit: The signature shortcutting should just work based on a threshold difficulty; like skip verifying up to 2016 blocks from the tip on any chain whos total headers show work > X... but only on the initial sync (latching), don't skip in reorgs. 04:28 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 04:28 < gmaxwell> So then we don't lose the optimization when we fail to constantly update some stupid constants, don't continue to give academics (for example) a reason to argue the consenus is actually hard coding blocks by us... 04:29 < gmaxwell> And the only exposure it creates is a one time install time vulnerablity to attackers powerful enough that they could totally break everything anyways. 04:32 < phantomcircuit> gmaxwell, my thinking on that was that the CScriptCheck objects could be queued on disk for processing later and then we could process them backwards 04:33 < phantomcircuit> which also has the nice benefit of making it trivial to do the io bound stuff in parallel with the script checks 04:33 < sipa> phantomcircuit: there's a much more elegant solution in just introduces an extra step in validation 04:34 < sipa> and doing script validation in the background 04:34 < sipa> but it's not trivial 04:34 < gmaxwell> well you cannot verify scripts once the utxo are removed; unless you're extracting and storing the pubkeys. 04:35 < sipa> they're stored in the undo files 04:36 < phantomcircuit> sipa, i never thought about using the undo files for that 04:36 < sipa> undo data may lack nLockTime though :s 04:37 < sipa> so you can't validate bip65/bip112 that way :( 04:53 < gmaxwell> sipa: does #7099 need rebase again? 04:53 < gmaxwell> (I just rebased it before your comment) 04:55 -!- Guest36383 [uid115429@gateway/web/irccloud.com/x-ebpvpqbxoxebkzki] has joined #bitcoin-core-dev 05:05 -!- Guest36383 is now known as btcdrak 05:06 -!- btcdrak is now known as Guest8622 05:06 -!- Guest8622 [uid115429@gateway/web/irccloud.com/x-ebpvpqbxoxebkzki] has quit [Quit: Updating details, brb] 05:06 -!- btcdrak_ [uid115429@gateway/web/irccloud.com/x-kptbjlqnhftmioth] has joined #bitcoin-core-dev 05:07 -!- btcdrak_ [uid115429@gateway/web/irccloud.com/x-kptbjlqnhftmioth] has quit [Client Quit] 05:07 < gmaxwell> sipa: should I go update 7100 to remove the mruset? 05:08 < sipa> gmaxwell: yes 05:09 -!- btcdrak_ [uid115429@gateway/web/irccloud.com/x-tibhgopyxerhuahf] has joined #bitcoin-core-dev 05:10 -!- btcdrak_ [uid115429@gateway/web/irccloud.com/x-tibhgopyxerhuahf] has quit [Client Quit] 05:10 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-imneqdqceqwudrgv] has joined #bitcoin-core-dev 05:15 < GitHub38> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8284feb3c91f...8332457e95c9 05:15 < GitHub38> bitcoin/master b8c06ef Wladimir J. van der Laan: doc: Add non-style-related development guidelines... 05:15 < GitHub38> bitcoin/master 8332457 Pieter Wuille: Merge pull request #7003... 05:15 < GitHub104> [bitcoin] sipa closed pull request #7003: doc: Add non-style-related development guidelines (master...2015_11_development_guidelines) https://github.com/bitcoin/bitcoin/pull/7003 05:18 < GitHub0> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8332457e95c9...92aa7311d64c 05:18 < GitHub0> bitcoin/master e482a7f Peter Josling: Fix CCoins serialization documentation... 05:18 < GitHub0> bitcoin/master 92aa731 Pieter Wuille: Merge pull request #6942... 05:18 < GitHub105> [bitcoin] sipa closed pull request #6942: Fix CCoins serialization documentation (master...docfix) https://github.com/bitcoin/bitcoin/pull/6942 05:21 -!- cocoBTC [~cocoBTC__@c-233a71d5.136-1-64736c10.cust.bredbandsbolaget.se] has quit [Remote host closed the connection] 05:26 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 06:43 < GitHub142> [bitcoin] jonasschnelli closed pull request #7067: [Wallet] improve detection of conflicted transactions (master...2015/11/mempool_wallet) https://github.com/bitcoin/bitcoin/pull/7067 06:57 < GitHub147> [bitcoin] sipa opened pull request #7125: Replace global trickle node with random delays (master...timetrickle) https://github.com/bitcoin/bitcoin/pull/7125 07:42 -!- SomeT [~SomeT@31.205.90.67] has joined #bitcoin-core-dev 07:42 < SomeT> hi, is there a tutorial on how to modify bitcoin from the source code? so many files I have no idea where to start 07:44 < sipa> what do you want to change? 07:45 < SomeT> I wanted to see if I could start building my own cryptocurrency in a sense 07:46 < sipa> i would suggest you to try understanding the code that is already there before deciding you need to change things 07:46 < sipa> perhaps you'll even find things to improve and start contributing to bitcoin 07:47 < SomeT> that was kinda my main goal really more understanding the code to see how it all works 07:47 < SomeT> but where would I even start in that respect? I can not find any sort of tutorials via google 07:47 < sipa> in that case, i suggest you to go over the issues, and see if there's something you feel is doable 07:47 < sipa> you can always ask specific questions here, especially if it's about improving the code 07:48 < sipa> where do you start? read the code... it will take a while, but it's much easier if you have a specific goal 07:48 < SomeT> ok many thanks 07:50 < SomeT> this looks useful?: http://chimera.labs.oreilly.com/books/1234000001802/index.html 07:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:53 < phantomcircuit> SomeT, useless 07:53 < phantomcircuit> actually worse than useless since it'll confuse you 07:54 < SomeT> ok what would be a better book like that aimed more at a beginner? 07:54 < SomeT> this is what I am trying to get at, like an outline 07:54 < sipa> SomeT: https://bitcoin.org/en/developer-guide 07:55 < SomeT> ok many thanks 07:56 -!- SomeT [~SomeT@31.205.90.67] has left #bitcoin-core-dev [] 08:23 -!- Guest44645 [~ParadoxSp@p508B9162.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 09:15 -!- ParadoxSpiral [~ParadoxSp@p508B9162.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:25 -!- MarcoFalke [05c7b6cb@gateway/web/cgi-irc/kiwiirc.com/ip.5.199.182.203] has joined #bitcoin-core-dev 09:37 -!- ParadoxSpiral [~ParadoxSp@p508B9162.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds] 09:42 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Read error: No route to host] 10:04 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev 10:04 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host] 10:04 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:13 -!- d_t [~textual@c-50-136-139-144.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:14 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 10:42 -!- MarcoFalke [05c7b6cb@gateway/web/cgi-irc/kiwiirc.com/ip.5.199.182.203] has quit [Remote host closed the connection] 10:59 -!- jouke [~jouke@unaffiliated/komkommer] has joined #bitcoin-core-dev 11:01 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:57 -!- raedah [~raedah@172.56.39.224] has quit [Remote host closed the connection] 11:58 -!- raedah [~raedah@172.56.39.224] has joined #bitcoin-core-dev 12:07 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has joined #bitcoin-core-dev 12:21 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has joined #bitcoin-core-dev 12:44 -!- ParadoxSpiral [~ParadoxSp@p508B8EBD.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 12:46 -!- ParadoxSpiral [~ParadoxSp@p508B8EBD.dip0.t-ipconnect.de] has quit [Client Quit] 12:49 -!- MarcoFalke [05c7b6cb@gateway/web/cgi-irc/kiwiirc.com/ip.5.199.182.203] has joined #bitcoin-core-dev 13:10 < MarcoFalke> sipa, we are logging time stamps by default 13:10 < MarcoFalke> It's just the diff which looks weird 13:12 < MarcoFalke> missed your second comment ;) 13:13 -!- Netsplit *.net <-> *.split quits: Anduck 13:13 < sipa> MarcoFalke: just doing due diligence :) 13:13 < sipa> MarcoFalke: looks all good, going to merge 13:15 < MarcoFalke> sounds good, I don't think there is anything left to get into the PR 13:15 < GitHub17> [bitcoin] sipa pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/92aa7311d64c...8d26289c9a7c 13:15 < GitHub17> bitcoin/master b966aa8 Luke Dashjr: Constrain constant values to a single location in code 13:15 < GitHub17> bitcoin/master 3307bdb Luke Dashjr: Bugfix: Omit wallet-related options from -help when wallet is not supported 13:15 < GitHub17> bitcoin/master faf93f3 MarcoFalke: [trivial] Reuse translation and cleanup DEFAULT_* values... 13:15 < GitHub37> [bitcoin] sipa closed pull request #6961: luke-jr constants (master...luke-jr-const) https://github.com/bitcoin/bitcoin/pull/6961 13:16 < GitHub101> [bitcoin] sipa closed pull request #6349: Constrain constant values to a single location in code (master...opt_defaults) https://github.com/bitcoin/bitcoin/pull/6349 13:27 < GitHub109> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8d26289c9a7c...61457c29d735 13:27 < GitHub109> bitcoin/master ee60e56 Pieter Wuille: Add merkle.{h,cpp}, generic merkle root/branch algorithm 13:27 < GitHub109> bitcoin/master eece63f Pieter Wuille: Switch blocks to a constant-space Merkle root/branch algorithm.... 13:28 < GitHub109> bitcoin/master 61457c2 Pieter Wuille: Merge pull request #6508... 13:28 < GitHub168> [bitcoin] sipa closed pull request #6508: Switch to a constant-space Merkle root/branch algorithm. (master...constmerkle) https://github.com/bitcoin/bitcoin/pull/6508 13:29 < Luke-Jr> MarcoFalke: what does https://github.com/bitcoin/bitcoin/pull/6349#issuecomment-160335992 mean? 13:30 < MarcoFalke> The last commit of this PR is not yet rebased 13:31 < Luke-Jr> oh, I figured you got all of them 13:31 < MarcoFalke> I only did 1 and 2 + 3 and 4 13:31 < GitHub79> [bitcoin] MarcoFalke opened pull request #7126: [trivial] Move blocksonly parameter interaction to InitParameterInteraction() (master...MarcoFalke-2015-initParam) https://github.com/bitcoin/bitcoin/pull/7126 13:31 < Luke-Jr> k 13:36 < MarcoFalke> Also I haven't looked at chainparams https://github.com/bitcoin/bitcoin/pull/6349/files#diff-dbba8d0e1257cc14ce18de8fd6c9a0b1 Not sure if still relevant 13:41 < Luke-Jr> MarcoFalke: eh, how did you do rpcport then? 13:41 < Luke-Jr> … you didn't :/ 13:41 < MarcoFalke> Just left it how it was 13:41 < MarcoFalke> yes 13:41 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 13:41 < Luke-Jr> anything else missing? 13:42 < MarcoFalke> no 13:43 -!- Squidicuz [~squid@pool-173-48-117-206.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 13:44 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 13:45 < gmaxwell> sipa: RE #7125 by 'No removal of the "1/4 blast to all" behaviour, as #7123 seems to offer a better replacement.' do you mean the sticky electricted trickling nodes? And darn wrt sorting the INV, I hadn't considered that the sort needs to be topological. 13:46 < sipa> gmaxwell: i just mean "other pull requests exist that deal with this in a different way, let's not touch the code too much" 13:46 < GitHub26> [bitcoin] luke-jr opened pull request #7127: Bugfix: Default -uiplatform is not actually the platform this build was compiled on (master...bugfix_uiplatform) https://github.com/bitcoin/bitcoin/pull/7127 13:46 < sipa> without judging whether those others are a good idea, getting the non-controversial parts in first is priority 13:47 < sipa> :) 13:48 < gmaxwell> sipa: yea, I think that 7125 is easier to merge. 13:49 < gmaxwell> I'd been debating to do per-peer timers in mine; it has some negative privacy effects when an observer has multiple connections to you (since they get the min of all of them); but it lets you have longer intervals with less effect. 13:50 < gmaxwell> It also breaks up bandwidth usage more, which is probably good for usability. 13:54 < sipa> gmaxwell: i would not be confortable with just per-peer timers if there was no bypass mechanism (like the 1/4 blast to all, or specific nodes that get everything instantly, ...) 13:54 < sipa> as that would introduce inevitable delays on every hop 13:58 < gmaxwell> In the per-peer, the 'delay per hop' is minimum (/second from minimum) of all those uniform numbers; e.g. ~N/2 fold smaller. 14:00 < sipa> and the more independent paths (of the same length) there are between two nodes, the lower the delay would be 14:03 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 14:54 -!- Anduck [~anduck@aom.fi] has joined #bitcoin-core-dev 14:55 -!- Anduck is now known as Guest17335 14:56 -!- Guest17335 [~anduck@aom.fi] has quit [Quit: Reconnecting] 14:56 -!- Anduck [~anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 15:10 -!- MarcoFalke [05c7b6cb@gateway/web/cgi-irc/kiwiirc.com/ip.5.199.182.203] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 15:10 -!- baldur [~baldur@pool-173-52-43-219.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 15:53 < GitHub170> [bitcoin] luke-jr opened pull request #7128: Constrain rpcport default values to a single location in code (master...const_rpcport) https://github.com/bitcoin/bitcoin/pull/7128 16:06 < GitHub107> [bitcoin] gmaxwell closed pull request #7123: [WIP] Make trickle logic useful again, delay trickle when past upload limit. (master...actually_trickle) https://github.com/bitcoin/bitcoin/pull/7123 16:10 < GitHub27> [bitcoin] gmaxwell pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/61457c29d735...c894fbbb1dc0 16:10 < GitHub27> bitcoin/master a9f3d3d Pieter Wuille: Fix and improve relay from whitelisted peers... 16:10 < GitHub27> bitcoin/master c894fbb Gregory Maxwell: Merge pull request #7106... 16:10 < GitHub63> [bitcoin] gmaxwell closed pull request #7106: Fix and improve relay from whitelisted peers (master...realwhiterelay) https://github.com/bitcoin/bitcoin/pull/7106 16:19 -!- michagogo [uid14316@wikia/Michagogo] has quit [Quit: Connection closed for inactivity] 17:44 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-zajqjulcxzyeqdvq] has quit [Quit: Connection closed for inactivity] 17:45 -!- jtimon [~quassel@74.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 17:59 < GitHub12> [bitcoin] gmaxwell closed pull request #7119: Add option to opt into full-RBF when sending funds (master...2015-11-opt-into-full-rbf-option) https://github.com/bitcoin/bitcoin/pull/7119 18:10 -!- raedah [~raedah@172.56.39.224] has quit [Quit: Leaving] 18:56 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 18:56 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 19:14 -!- guest234234 [~guest2342@223.207.206.21] has joined #bitcoin-core-dev 19:23 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 19:23 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 19:24 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Client Quit] 19:25 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 19:25 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 19:36 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 21:05 -!- Dyanisus [~Dyanisus@unaffiliated/dyanisus] has joined #bitcoin-core-dev 22:07 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev 22:11 -!- guest234234 [~guest2342@223.207.206.21] has quit [Ping timeout: 246 seconds] 22:33 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 22:34 -!- tulip [~tulip@unaffiliated/tulip] has quit [Client Quit] 22:34 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 22:48 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 23:03 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 23:13 -!- CodeShark_ [~CodeShark@cpe-76-167-237-202.san.res.rr.com] has quit [Ping timeout: 240 seconds] 23:27 -!- guest234234 [~guest2342@223.207.206.21] has joined #bitcoin-core-dev 23:47 -!- tulip [~tulip@unaffiliated/tulip] has quit [] 23:52 -!- tulip [~tulip@unaffiliated/tulip] has joined #bitcoin-core-dev 23:57 -!- ParadoxSpiral [~ParadoxSp@p508B8EBD.dip0.t-ipconnect.de] has joined #bitcoin-core-dev