--- Day changed Wed Jan 13 2016
00:00 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
00:01 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
00:01 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Quit: Ctrl-C at console.]
00:12 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev
00:18 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
00:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
00:57 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Remote host closed the connection]
00:57 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev
01:13 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
01:28 -!- murch [~murch@p4FE39B53.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:28 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Remote host closed the connection]
01:28 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev
01:33 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:37 -!- mode/#bitcoin-core-dev [+o wumpus] by ChanServ
01:37 -!- mode/#bitcoin-core-dev [+b *!*@unaffiliated/quent] by wumpus
01:37 -!- Quent was kicked from #bitcoin-core-dev by wumpus [persistently offtopic]
01:55 < GitHub88> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dd1304ec216c...18ca3fa84058
01:55 < GitHub88> bitcoin/master d570a1f Luke Dashjr: doc/bips: Document BIP 125 support
01:55 < GitHub88> bitcoin/master 18ca3fa Wladimir J. van der Laan: Merge pull request #7324...
01:55 < GitHub165> [bitcoin] laanwj closed pull request #7324: doc/bips: Document BIP 125 support (master...bips_rbf) https://github.com/bitcoin/bitcoin/pull/7324
01:55 < GitHub173> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/8f25d6eb0e0a4c1a369878808fb041283617081c
01:55 < GitHub173> bitcoin/0.12 8f25d6e Wladimir J. van der Laan: Merge pull request #7324
02:04 < GitHub133> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/18ca3fa84058...c49551886a75
02:04 < GitHub133> bitcoin/master 995b9f3 Alex Morcos: Always respect GetRequiredFee for wallet txs
02:04 < GitHub133> bitcoin/master e420a1b Alex Morcos: Add sane fallback for fee estimation...
02:04 < GitHub133> bitcoin/master bebe58b Alex Morcos: SQUASHME: Fix rpc tests that assumed fallback to minRelayTxFee
02:04 < GitHub162> [bitcoin] laanwj closed pull request #7296: Add sane fallback for fee estimation (master...fallbackfee) https://github.com/bitcoin/bitcoin/pull/7296
02:04 < GitHub35> [bitcoin] laanwj closed pull request #7321: Always respect GetRequiredFee for wallet txs (master...Mf1601-walletFeeFix) https://github.com/bitcoin/bitcoin/pull/7321
02:06 < GitHub37> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/a36d79bfe247e7fc5c6296fd8603f5094edfe558
02:06 < GitHub37> bitcoin/0.12 a36d79b Alex Morcos: Add sane fallback for fee estimation...
02:37 < GitHub195> [bitcoin] MarcoFalke opened pull request #7332: [wallet] Clarify rpc help message with regard to rounding (master...Mf1601-docAmount) https://github.com/bitcoin/bitcoin/pull/7332
02:42 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
02:43 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
02:50 < GitHub104> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c49551886a75...2cd004b1232a
02:50 < GitHub104> bitcoin/master 3a9dfe9 paveljanik: Fix typo, wrong information in gettxout help text.
02:50 < GitHub104> bitcoin/master 2cd004b Wladimir J. van der Laan: Merge pull request #7326...
02:50 < GitHub32> [bitcoin] laanwj closed pull request #7326: [Trivial] Fix typo, wrong information in gettxout help text (master...patch-15) https://github.com/bitcoin/bitcoin/pull/7326
02:59 -!- NicolasDorier [uid129442@gateway/web/irccloud.com/x-jtytiycxyqddiyiv] has quit []
02:59 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-ajrjswqcyfsnleaj] has joined #bitcoin-core-dev
03:08 -!- jcorgan|away is now known as jcorgan
03:09 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 250 seconds]
03:09 -!- Squidicuz [~squid@pool-173-48-117-206.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]
03:09 -!- MarcoFalke [8af602fd@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.253] has joined #bitcoin-core-dev
03:09 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
03:11 -!- SmiteMeSmith__ [~SmiteMeSm@WLLDON1606W-LP140-02-1279535220.dsl.bell.ca] has joined #bitcoin-core-dev
03:13 -!- dcousens [~anon@203-206-217-234.perm.iinet.net.au] has quit [Ping timeout: 265 seconds]
03:15 -!- SmiteMeSmith_ [~SmiteMeSm@WLLDON1606W-LP140-02-1279535220.dsl.bell.ca] has quit [Ping timeout: 250 seconds]
03:23 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
03:36 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 250 seconds]
03:37 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev
03:43 < GitHub11> [bitcoin] laanwj closed pull request #7309: [0.12] Update release-notes.md (0.12...Mf1601-releaseNotes0.12) https://github.com/bitcoin/bitcoin/pull/7309
03:44 < GitHub158> [bitcoin] laanwj pushed 5 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/a36d79bfe247...2c5c2154c935
03:44 < GitHub158> bitcoin/0.12 fabba1c MarcoFalke: Update release-notes.md...
03:44 < GitHub158> bitcoin/0.12 fa4ba40 MarcoFalke: Expand section "Wallet transaction fees" & fix format and typos
03:44 < GitHub158> bitcoin/0.12 fa0a391 MarcoFalke: Add Replace-by-fee to release-notes
03:44 -!- jcorgan is now known as jcorgan|away
04:11 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
04:16 -!- dcousens [~anon@d110-33-200-231.mas801.nsw.optusnet.com.au] has joined #bitcoin-core-dev
04:16 -!- xiangfu [~xiangfu@111.198.29.54] has quit [Ping timeout: 276 seconds]
04:18 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
04:30 -!- MarcoFalke [8af602fd@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.253] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
04:31 -!- dcousens [~anon@d110-33-200-231.mas801.nsw.optusnet.com.au] has quit [Remote host closed the connection]
04:47 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
05:02 -!- guest21333 [~02@6e.17.01a8.ip4.static.sl-reverse.com] has joined #bitcoin-core-dev
05:15 < morcos> wumpus: thanks for taking a look at 7312.  i liked the hack of reusing hashBlock b/c that meant whenever hashBlock was already being set/unset the abandon status would be kept in sync.  but perhas that was not the best way to create a special value which flagged it?
05:17 <@wumpus> CMerkleTx just doesn't look like the place for it
05:17 <@wumpus> conceptually
05:17 <@wumpus> why not  a field on CWallet instead?
05:18 <@wumpus> also it lacks documentation; so this field is 'the last transaction marked abandoned'
05:18 <@wumpus> ?
05:20 < morcos> yes i'll definitely add documentation
05:20 < morcos> the field is just a special flag 
05:20 <@wumpus> yes, but it has nothing to do with MerkleTx - it's a wallet internal detail
05:20 < morcos> blockHash is the hash of the block that the tx is confirmed iin
05:20 <@wumpus> I'm not sure it should be global static something
05:21 < morcos> in the even blockHash.isNull that means it is not confirmed
05:21 < morcos> recently we made it so that if the nIndex is -1 
05:21 < morcos> then hashBlock is now the hash of the conflicting tx
05:21 < morcos> all that stuff is in CMerkle
05:22 < morcos> So I was kind of overloading that hashBlock one more time to say, if it's 0 or 1 that means its not in a block and not conflicted, but 0 means regular and 1 means abandoned
05:22 <@wumpus> but conceptually it is wallet state, right, not global state? say if there are multiple CWallet objects, would they interfere with each other?
05:22 < morcos> its not a variable, its just a constant
05:22 <@wumpus> oh!
05:22 < morcos> hashBlock is the variable
05:22 <@wumpus> let me recheck
05:22 < morcos> i'm not arguing its right btw
05:23 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
05:23 <@wumpus> right, I missed the const, oops
05:23 <@wumpus> the field is hashBlock which already exists and is not a static
05:23 < morcos> i was trying to encapsulate the constant somewhere that made sense, but perhaps it would have been better to just make it outside the class, or to just recreate it when we're checking it?  i'm not sure
05:23 < morcos> correct
05:24 < morcos> so if you are ok with perpetuating hte hack, i'm happy to move the constant whereever you think it should live, and comment it
05:25 <@wumpus> I think for most constants we use UPPER_CASE
05:25 <@wumpus> that's what made me confused... the field looks the same as the constant
05:25 <@wumpus> e.g. call it ABANDON_HASH
05:26 < morcos> you're right.  i'm a copy paste coder and was copying the constant "one" from signature checking..  : )  but yes happy to
05:29 < morcos> but should i move it?  it does seem like this is kind of a slippery slope from thread safety perspective right?  of course these things are all heavily locked now but if in the future you wanted multiple threads accessing different wallet tx's it seems silly to worry about synchronizing around a constnat
05:29 -!- Chris_Stewart_5 [~Chris_Ste@173-26-115-141.client.mchsi.com] has joined #bitcoin-core-dev
05:32 <@wumpus> but there is no sync problem if it is a const
05:33 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
05:33 <@wumpus> disregard that, I was confused, I thought it was a global value that changed
05:33 < morcos> i don't know, one of you guys scared me with that article on thread safety
05:33 <@wumpus> no need to move it, just make clear it is a constant marker value
05:34 < morcos> ok, well like i said, happy to capitalize, and comment, but please let me know if you think that is ok ..   ok great.   thanks
05:34 -!- guest21333 [~02@6e.17.01a8.ip4.static.sl-reverse.com] has quit [Ping timeout: 240 seconds]
05:47 < morcos> wumpus: ok pushed.  thanks for waiting for this.  i think we'll be very happy we have it around if there is another major spam attack or other surge of transactions.  If not, no one has to use it.
05:48 <@wumpus> agreed
06:00 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Ping timeout: 246 seconds]
06:00 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Disconnected by services]
06:00 -!- Arnavion3 [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
06:00 -!- Arnavion3 is now known as AtashiCon
06:06 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
06:47 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:47 < GitHub13> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2cd004b1232a...be6d5a617d29
06:47 < GitHub13> bitcoin/master 9e69717 Alex Morcos: Make wallet descendant searching more efficient
06:47 < GitHub13> bitcoin/master 01e06d1 Alex Morcos: Add new rpc call: abandontransaction...
06:47 < GitHub13> bitcoin/master df0e222 Alex Morcos: Add RPC test for abandoned and conflicted transactions.
06:47 < GitHub146> [bitcoin] laanwj closed pull request #7312: Add RPC call abandontransaction (master...forgetstuck) https://github.com/bitcoin/bitcoin/pull/7312
06:52 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has joined #bitcoin-core-dev
06:59 < GitHub179> [bitcoin] laanwj pushed 3 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/2c5c2154c935...afe825f0758a
06:59 < GitHub179> bitcoin/0.12 fd4bd50 Alex Morcos: Add RPC call abandontransaction...
06:59 < GitHub179> bitcoin/0.12 071f704 Wladimir J. van der Laan: Preliminary release notes 0.12.0
06:59 < GitHub179> bitcoin/0.12 afe825f Wladimir J. van der Laan: Update translations pre-rc1
06:59 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
07:00 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
07:01 < GitHub69> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/be6d5a617d29...17ef279304a9
07:01 < GitHub69> bitcoin/master faf671b MarcoFalke: [wallet] Clarify rpc help message with regard to rounding
07:01 < GitHub69> bitcoin/master 17ef279 Wladimir J. van der Laan: Merge pull request #7332...
07:01 < GitHub168> [bitcoin] laanwj closed pull request #7332: [wallet] Clarify rpc help message with regard to rounding (master...Mf1601-docAmount) https://github.com/bitcoin/bitcoin/pull/7332
07:02 < GitHub22> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/2a3161bf8bd458ef44a53af37899fad684b257d6
07:02 < GitHub22> bitcoin/0.12 2a3161b Wladimir J. van der Laan: Merge pull request #7332
07:03 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
07:05 <@wumpus> ok, that should be all, going to tag 0.12.0rc1 in a minute
07:11 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
07:14 <@wumpus>  * [new tag]         v0.12.0rc1 -> v0.12.0rc1
07:14 < MarcoFalke> woohoo!
07:14 < JackH> yay we have 0.12 incoming :)
07:15 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
07:29 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
07:46 < btcdrak> w00t
07:51 < btcdrak> wumpus: pm
08:06 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving]
08:20 < morcos> wumpus, your release candidate isn't compiling for me, looking into it
08:20 <@wumpus> linux build is still in progress here
08:20 < morcos> ah backport failure of my pr, damn it, sorry i should have tested it in 0.12
08:20 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
08:20 < morcos> will get you a fix
08:21 <@wumpus> ok, probably better to revert it, this was a bad idea last minute
08:22 < morcos> wumpus: the problem was simple, it just used a function that hadn't been backported
08:22 <@wumpus> going to remove the rc1 tag again
08:22 < morcos> give me 10 mins before making any decisions
08:23 <@wumpus>  - [deleted]         v0.12.0rc1   sorry for the noise...
08:23 < morcos> probably the right answer is #7154 should be backported to.  it will be better UI for 0.12 and should fix the problem
08:23 <@wumpus> nah, I'm not going to do any last minute UI backports
08:24 <@wumpus> is there any quick fix?
08:24 < morcos> yes, i can just inline the contents of the inmempool function
08:24 < morcos> you don't want to do a UI backport because of translations?
08:24 <@wumpus> yes
08:25 < morcos> ok, i'll just take the part of his commit in that pull that creates InMempool
08:25 < morcos> thats cleanest
08:25 <@wumpus> makes sense, thanks
08:26 <@wumpus> can do the GUI part for 0.12.1, but it's too late for 0.12.0
08:29 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
08:32 -!- adam3us [~Adium@c-98-234-64-218.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
08:32 -!- Chris_Stewart_5 [~Chris_Ste@173-26-115-141.client.mchsi.com] has quit [Ping timeout: 240 seconds]
08:37 < morcos> wumpus: ok i did it. but show me how you want to give it to you.  my branch v12rebase adds the commit in the right place.   and my branch forgetstuck12 has the commit just on top if you want to do the rebasing yourself.  
08:37 < morcos> in the v12rebase, i tried to comment the commit appropriately.  i didn't really put detail in the commit message on the forgetstuck12 branch
08:38 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
08:38 < morcos> i'm not sure how it is easiest for you to merge
08:38 < morcos> also i tested
08:38 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
08:39 < MarcoFalke> Did you test the v12rebase?
08:40 < morcos> MarcoFalke: yes
08:40 < MarcoFalke> Then just merge that into bitcoin/bitcoin
08:40 < morcos> its not a commit its a branch with the ordering of commits
08:42 < MarcoFalke> a06a8b488896dd83a320fff10d48300ca01e9ba4 looks fine, I mean.
08:43 < GitHub114> [bitcoin] morcos opened pull request #7333: add InMempool() function (0.12...forgetstuck12) https://github.com/bitcoin/bitcoin/pull/7333
08:47 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
08:49 < MarcoFalke> morcos, we can't rewrite history if that's what you mean?
08:49 < MarcoFalke> Merging a06a is good enough
08:52 < morcos> MarcoFalke: whatever wumpus wants as far as i'm concerned, but yes i guess 0.12 is already a public branch, so you might be right
08:52 <@wumpus> I'm just going to merge #7333, no need to change history
08:55 < MarcoFalke> each commit should be atomic and compile on its own but that was never true anyway.
08:59 <@wumpus> it's usually the case
09:00 < MarcoFalke> s/never/not always/
09:05 < MarcoFalke> travis is smiling again
09:08 < GitHub99> [bitcoin] laanwj closed pull request #7333: add InMempool() function (0.12...forgetstuck12) https://github.com/bitcoin/bitcoin/pull/7333
09:08 < GitHub149> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/2a3161bf8bd4...3d5cf698d60e
09:08 < GitHub149> bitcoin/0.12 a06a8b4 Jonas Schnelli: add InMempool() function
09:08 < GitHub149> bitcoin/0.12 3d5cf69 Wladimir J. van der Laan: Merge pull request #7333...
09:08 < Luke-Jr> at the very least, 7149 is still needed to fix a bug in 0.12 (although note even with it, there are still bugs I am working on fixing/testing)
09:08 < Luke-Jr> could wait for rc2 I suppose
09:09 < MarcoFalke> There is indeed more bugs
09:09 < MarcoFalke> We need to leave some for later
09:09 < Luke-Jr> yeah, I guess we should get rc1 out ASAP so users can begin *finding* [more] bugs :p
09:09 < morcos> MarcoFalke: more bugs?
09:10 < MarcoFalke> I will create pulls in the coming days
09:10 < MarcoFalke> Some of those exist for a long time
09:10 < MarcoFalke> It's not too critical
09:11 < MarcoFalke> +1 Luke-Jr :)
09:12 <@wumpus> of course there is always more work to be done, but we can't keep postponing 0.12 forever
09:12 < MarcoFalke> Sure, there are 351 other bugs open at this time, I think
09:13 < MarcoFalke> But nothing holding back a rc1
09:16 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
09:17 <@wumpus>  * [new tag]         v0.12.0rc1 -> v0.12.0rc1   ok,. this time for real
09:17 < michagogo> Release notes talk about BIP65 locking in in future tense...
09:18 <@wumpus> hm, that probably shouldn't be there at al
09:18 < Luke-Jr> XD
09:20 < michagogo> (Also, is github being weird or did v0.11.2 have a handful of version numbers that stayed at 0.10?)
09:20 < Luke-Jr> huh?
09:20 < GitHub52> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/5771b71ca533d712893c7895204a47c9ad70c9c7
09:20 < GitHub52> bitcoin/0.12 5771b71 Wladimir J. van der Laan: doc: Remove BIP65 mention from release notes...
09:21 < michagogo> Luke-Jr: GitHub's v0.11.2...0.12 comparison shows a bunch of lines replacing 0.10 or 0.10.99 with 0.12
09:22 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
09:22 <@wumpus> no, 0.11.x doesn't have any 0.10 versions, I don't think we've ever had a wrong version number slip into a (non-rc) release
09:25 < michagogo> Hm, GitHub must be messing up somehow then.
09:25 < MarcoFalke> GitHub diff is not git diff
09:25 < michagogo> I'm also seeing changes that I *know* were in 0.11
09:26 < michagogo> MarcoFalke: I know that, but how do you mean exactly?
09:27 < MarcoFalke> GitHub compare will go back to the common branch point to compare, I think.
09:28 < MarcoFalke> You can't compare branches in GitHub when they conflict each otehr
09:31 < michagogo> Meh, really?
09:31 < michagogo> :-/
09:31 < michagogo> It certainty doesn't make that obvious.
09:37 < morcos> wumpus: ok it passed extended rpc tests for me now.  woo hoo!
09:42 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Quit: leaving]
09:42 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev
09:51 < GitHub193> [bitcoin] MarcoFalke opened pull request #7334: [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (master...Mf1601-qt55Workaround) https://github.com/bitcoin/bitcoin/pull/7334
09:53 < cfields> MarcoFalke: that looks like it should be a runtime check?
09:53 -!- murch [~murch@p4FE39B53.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
09:53 < MarcoFalke> jonas didn't like that
09:54 < cfields> hmm
09:55 < MarcoFalke> by runtime check you mean compile time check?
09:55 < MarcoFalke> #if QT_VERSION >= 0x050000 && QT_VERSION <= 0x050500
09:55 < cfields> no, i mean the opposite of that :)
09:56 < MarcoFalke> Why is that preferred?
09:57 < cfields> what if it's built against 5.5 and run against 5.2?
09:58 < Luke-Jr> cfields: is that even supported? O.o
09:58 < cfields> Luke-Jr: sure, official builds used qt shared libs for a long time, remember?
09:58 <@wumpus> I don't think that's supported, you can run against newer versions but *not* older
09:59 < Luke-Jr> cfields: doesn't mean it's supported to run against older libs
09:59 <@wumpus> so you can build against 5.2 and run against 5.5 (probably), but not the other way around
09:59 < Luke-Jr> ^
09:59 < cfields> wumpus: yes, sorry
10:00 -!- brg444 [18257df2@gateway/web/freenode/ip.24.37.125.242] has joined #bitcoin-core-dev
10:01 < cfields> MarcoFalke: i suppose there's no harm in running that code unconditionally, though?
10:01 < MarcoFalke> not that I am aware of
10:02 < cfields> ok, not worth worrying about then. nm.
10:08 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tmgxyeetykjfwetu] has quit [K-Lined]
10:08 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-bgxboebvjwjmiryd] has quit [K-Lined]
10:08 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-fzphogalqxypmnno] has quit [K-Lined]
10:08 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-ajrjswqcyfsnleaj] has quit [K-Lined]
10:08 -!- zmanian_ [sid113594@gateway/web/irccloud.com/x-jhcqauvabmzklqzo] has quit [K-Lined]
10:08 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-pzvdwcplsqlazteq] has quit [K-Lined]
10:08 -!- mturquette [sid66043@gateway/web/irccloud.com/x-exufktwfgulmpnmb] has quit [K-Lined]
10:08 -!- michagogo [uid14316@wikia/Michagogo] has quit [K-Lined]
10:16 -!- Guest31456 is now known as mr_burdell
10:16 -!- mr_burdell [~mr_burdel@bounce.cryptolabs.net] has quit [Changing host]
10:16 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev
10:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bfujopogqteqggkb] has joined #bitcoin-core-dev
10:18 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-thvwlxiazgnebhvh] has joined #bitcoin-core-dev
10:20 -!- zmanian_ [sid113594@gateway/web/irccloud.com/x-pfgahnjwyncrhxcs] has joined #bitcoin-core-dev
10:22 -!- mturquette [sid66043@gateway/web/irccloud.com/x-musbyzdzgcjdnrpl] has joined #bitcoin-core-dev
10:23 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
10:28 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-cdlcafrxzmhtlqub] has joined #bitcoin-core-dev
10:29 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-jtogtwzntzabjsdx] has joined #bitcoin-core-dev
10:31 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-zwxfnvosepvfacmu] has joined #bitcoin-core-dev
10:34 -!- Dizzle [~Dizzle@104-6-36-162.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
10:44 -!- p15 [~p15@70.91.145.64.client.static.strong-tk2.bringover.net] has quit [Ping timeout: 260 seconds]
10:57 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
10:57 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
11:12 < GitHub111> [bitcoin] MarcoFalke opened pull request #7335: [qa] Fix pyton syntax in rpc tests (master...Mf1601-rpcSyntax) https://github.com/bitcoin/bitcoin/pull/7335
11:25 < michagogo> Can someone please pastebin a git diff from v0.11.2..v0.12.0rc1 of any gitian-building related files (especially release-process.md)?
11:33 < arubi> michagogo, http://paste.debian.net/plain/365610
11:39 -!- MarcoFalke [c3523fc8@gateway/web/cgi-irc/kiwiirc.com/ip.195.82.63.200] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
12:05 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has joined #bitcoin-core-dev
12:10 < michagogo> arubi: וחשמלי
12:10 < michagogo> Thanks*
12:10 < arubi> 'קךבםצק!
12:10 < arubi> welcome ;)
12:11  * michagogo whoises
12:11 < michagogo> Ah, I see
12:11 < arubi> hehe :)
12:12 < GitHub173> [bitcoin] jtimon closed pull request #6382: DEPENDENT: Chainparams: Introduce N testnet chains to test different block sizes (master...chainparams-sizetest-0.11.99) https://github.com/bitcoin/bitcoin/pull/6382
12:14 < michagogo> Okay, cool, so no changes to the gbuild instructions. I think I should be able to reuse the same script from 0.11.
12:15 < michagogo> (Other than optional gverify lines, which I might add if I get a chance)
12:16 < Luke-Jr> new base image IIRC
12:24 < GitHub31> [bitcoin] morcos opened pull request #7336: release note fixups (0.12...rnfixes) https://github.com/bitcoin/bitcoin/pull/7336
12:25 < GitHub69> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/17ef279304a9...c079d79c9a9c
12:25 < GitHub69> bitcoin/master 30cdace crowning-: [Wallet] Transaction View: LastMonth calculation fixed
12:25 < GitHub69> bitcoin/master c079d79 Jonas Schnelli: Merge pull request #7327...
12:25 < GitHub103> [bitcoin] jonasschnelli closed pull request #7327: [Wallet] Transaction View: LastMonth calculation fixed (master...patch-2) https://github.com/bitcoin/bitcoin/pull/7327
12:28 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
12:29 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
12:40 < Luke-Jr> btw, the pruning test seems to presently fail in master
12:40 < Luke-Jr> s/presently/whenever I pulled last/
12:48 < morcos> Luke-Jr: can you paste me the error
12:49 < Luke-Jr> morcos: I'd have to run it again, and it's .. slow :<
12:50 < morcos> yep!
12:50 < morcos> i'll run it on master
12:51 < Luke-Jr> did the OP_NOP2 replacement get into 0.12rc1?
12:55 < Luke-Jr> apparently not. why?
12:58 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
13:17 < GitHub107> [bitcoin] luke-jr opened pull request #7338: Backports for 0.12.0 (updated to e289807) (0.12...backports-for-0.12.0) https://github.com/bitcoin/bitcoin/pull/7338
13:17 < Luke-Jr> wumpus: ^
13:18 <@wumpus> couldn't you have opened that last week?
13:18 < Luke-Jr> wumpus: I didn't know they were missing until now :p
13:18 <@wumpus> I don't agree on porting most of those, let's leave that for important fixes
13:18 < Luke-Jr> O.o
13:19 < Luke-Jr> so delay these for 0.12.1, or just close it and forget?
13:19 <@wumpus> I mean something like "rpc: remove cs_main lock from `createrawtransaction`" I've done on 0.13 on purpose, it's not something that needs to be backported
13:20 <@wumpus> it's a small improvement, but also has a small risk, not really user visible in any case
13:20 < Luke-Jr> or I could remove that one, if it's uniquely undesired.
13:21 <@wumpus> and certainly things that involve translation changes are too late
13:21 < Luke-Jr> even if the current strings are outright wrong?
13:22 <@wumpus> the Rename OP_NOP2 to OP_CHECKLOCKTIMEVERIFY makes sense ofc
13:22 <@wumpus> String freeze was *december 1* for 0.12.0, more than a month ago
13:23 <@wumpus> not something you'd propose inserting between two rcs
13:23 <@wumpus> for 0.12.1 it's ok
13:23 <@wumpus> but that will have to wait, then
13:24 < Luke-Jr> yes, I know that. but usually I would consider "this string is wrong" to trump a string freeze (and the PR it's a backport of didn't even exist back then) :p
13:24 < Luke-Jr> ok, so remove the cs_main lock thing, and delay the string change?
13:25 <@wumpus> if there is a strong that is so wrong it could cause serious harm to users of course an exception can be made but that's shouldn't be the assumption.
13:26 < Luke-Jr> k, removed those two then
13:34 < Luke-Jr> wumpus: added the release-notes combine
13:37 < Luke-Jr> (also, https://github.com/bitcoin/bitcoin/pull/7149 needs 0.12.0 milestone too)
13:38 <@wumpus> 7149 has no ACKs at all
13:39 <@wumpus> it doesn't seem it will still make 0.12.0
13:40 <@wumpus> (fine with adding 0.12 milestone, but that will mean 0.12.1 at first)
13:40 < Luke-Jr> just added unit tests, so not much more I can do at this point to help it along
13:42 <@wumpus> why does it include some commits from morcos last year? is it a continuation of one of his pulls? your description is very short for relatively many changes
13:43 <@wumpus> and it's open since dec 1, don't know why no one has looked at it yet
13:43 <@wumpus> maybe discuss at the meeting tomrrow
13:46 < morcos> wumpus: 7149 is based off my code to keep the priority calculation the same as it was in 0.11 but to calculate it dynamically so it was not expensive to GetPriority 
13:46 < Luke-Jr> yes, the bugs go back a long ways, but morcos introduced them into the mining code with the CNB rewrite and also wrote those commits to fix it
13:46 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
13:46 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Remote host closed the connection]
13:46 < morcos> I think the consensus other than Luke-Jr was the modified priority calculation that exists in 0.12/master right now is good enough.  
13:47 < morcos> This has the effect of not increasing prioirty of txs for inputs that were not already in the block chain at the time the tx was accepted to the mempool.  
13:47 < Luke-Jr> "good enough" isn't a strong reason not to fix bugs..
13:47 < morcos> So it will still age and increase in priority but by a smaller amount.  There may be some inaccuracy around reorgs to.
13:48 < morcos> It only affects how priority is calculated for mining
13:49 < morcos> If we were going to keep priority as it exists now for the long term.  I might think it was worth adding this code.  But it is somewhat complicated and I believe it would be better not to add this complication if we're not fully committed to maintaining priority
13:49 < morcos> It was discussed at length previously
13:50 < Luke-Jr> fixing this also means we can have working tests for it
13:50 < Luke-Jr> (and it isn't that complicated)
13:51 < Luke-Jr> in any case, I do plan to maintain priority
14:12 -!- zookolaptop [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev
14:34 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]
14:35 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev
14:36 -!- murch [~murch@p4FE39B53.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
14:55 -!- thrasher` [~thrasher@unaffiliated/thrasher/x-7291870] has joined #bitcoin-core-dev
15:19 -!- Dizzle [~Dizzle@104-6-36-162.lightspeed.austtx.sbcglobal.net] has quit [Quit: Leaving...]
15:24 < GitHub46> [bitcoin] luke-jr opened pull request #7339: Support building without libevent (master...opt_libevent) https://github.com/bitcoin/bitcoin/pull/7339
15:31  * Luke-Jr should have done that one a few weeks ago <.<
15:35 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
15:55 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.]
15:59 -!- murch [~murch@p4FE39B53.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
16:17 -!- guest21333 [~02@6e.17.01a8.ip4.static.sl-reverse.com] has joined #bitcoin-core-dev
16:28 < GitHub196> [bitcoin] luke-jr opened pull request #7340: Replace univalue subtree with proper dependency on external UniValue (master...sys_univalue) https://github.com/bitcoin/bitcoin/pull/7340
16:33 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-thvwlxiazgnebhvh] has quit [Read error: Connection reset by peer]
16:33 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-yszvbzkjamupxhwt] has joined #bitcoin-core-dev
17:00 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
17:09 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
17:34 -!- xiangfu [~xiangfu@111.198.29.54] has joined #bitcoin-core-dev
17:39 -!- jtimon [~quassel@126.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds]
17:54 -!- kangx [d846a833@gateway/web/freenode/ip.216.70.168.51] has joined #bitcoin-core-dev
17:55 < kangx> hello.
18:06 -!- kangx [d846a833@gateway/web/freenode/ip.216.70.168.51] has quit [Ping timeout: 252 seconds]
18:08 -!- brg444 [18257df2@gateway/web/freenode/ip.24.37.125.242] has quit [Quit: Page closed]
18:08 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bfujopogqteqggkb] has quit [Quit: Connection closed for inactivity]
18:16 -!- p15 [~p15@9.91.145.64.client.static.strong-tk2.bringover.net] has joined #bitcoin-core-dev
18:19 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has quit [Quit: Leaving.]
18:49 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has joined #bitcoin-core-dev
18:50 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
18:52 -!- JackH [~Jack@host-80-43-143-228.as13285.net] has quit [Ping timeout: 246 seconds]
18:53 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Ping timeout: 246 seconds]
18:53 -!- Anduck [~anduck@unaffiliated/anduck] has quit [Ping timeout: 246 seconds]
18:53 -!- Anduck [~anduck@unaffiliated/anduck] has joined #bitcoin-core-dev
18:53 -!- JackH [~Jack@host-80-43-143-228.as13285.net] has joined #bitcoin-core-dev
18:59 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has quit [Quit: Leaving.]
19:01 < michagogo> cfields: detached sigs on the way?
19:01 < cfields> michagogo: signing this very second
19:02 < cfields> there's a snag with one of the descriptors, but nothing to worry about for rc1 i think
19:02 < michagogo> Cool, I'll see if I can kick off my script before I leave
19:03 < cfields> michagogo: you'll have to hand-edit one of the descriptors
19:03 < michagogo> Hm?
19:03 < michagogo> How so?
19:04 < cfields> i'll PR it in a sec, doing sanity checks on the build atm
19:04 < michagogo> (They're hashed, right?
19:04 < michagogo> )
19:04 < cfields> need to remove libc6:i386 out of the osx signer
19:05 < michagogo> Can you just push it to the 0.12 branch, and then I'll check that out instead of the tag?
19:06 < cfields> still need to build from the tag, just change the descriptor locally for the sig attach
19:06 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has joined #bitcoin-core-dev
19:07 < michagogo> But gitian keeps its own git repo and brings in the tag on its own
19:07 < cfields> yes, but the descriptor is local
19:07 < michagogo> So if that's the only change to the descriptors from the tag, the clone of the repo that I have outside gitian can be checked out to the branch
19:08 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has joined #bitcoin-core-dev
19:08 < michagogo> Er, can have the branch checked out
19:08 < michagogo> Since its ignored other than the descriptors
19:08 < cfields> you can copy the descriptor to /tmp, it doesn't matter where it lives or what's checked out
19:10 < michagogo> cfields: I know that. I'm saying, it's probably easiest if you just commit the fix to the 0.12 branch, since I assume that needs to be in rc2 anyway.
19:10 < cfields> oh
19:10 < cfields> <cfields> i'll PR it in a sec, doing sanity checks on the build atm
19:10 < cfields> :)
19:10 < michagogo> That way the fixed descriptor can easily be used by checking out 0.12 in the external copy of the repo
19:11 < michagogo> Yeah, just saying that makes the hand-editing unneeded as soon as that's in
19:11 < cfields> sure, gotcha
19:18 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has quit [Quit: Leaving.]
19:19 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]
19:19 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
19:21 < GitHub160> [bitcoin] theuni opened pull request #7342: release: remove libc6 dependency from the osx signing descriptor (master...gitian-quickfix) https://github.com/bitcoin/bitcoin/pull/7342
19:23 < cfields> sigs pushed
19:24 -!- p15 [~p15@9.91.145.64.client.static.strong-tk2.bringover.net] has quit [Ping timeout: 265 seconds]
19:31 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has joined #bitcoin-core-dev
19:43 -!- thrasher` [~thrasher@unaffiliated/thrasher/x-7291870] has left #bitcoin-core-dev []
19:50 -!- Squidicuz [~squid@pool-173-48-117-206.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
19:52 -!- jgarzik [~jgarzik@unaffiliated/jgarzik] has joined #bitcoin-core-dev
19:53 < Luke-Jr> jgarzik: can you 1.0.2 univalue?
19:53 < Luke-Jr> although it might have a bug, so maybe we should figure that out first..
19:54 < jgarzik> Luke-Jr, sure
19:55 < Luke-Jr> jgarzik: any idea on how to determine the cause of https://travis-ci.org/bitcoin/bitcoin/jobs/102242679 ?
19:55 < Luke-Jr> I can't reproduce it.. :/
20:00 < cfields> Luke-Jr: it's a string being constructed from setNumStr(), i'd guess null pointer as input
20:00 < Luke-Jr> hmm
20:01 < Luke-Jr> if I hack the travis config to --enable-debug, think it'd give line numbers? <.<
20:03 < cfields> Luke-Jr: you can track it back with that, sec
20:03 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Quit: .]
20:04 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
20:04 < cfields> Luke-Jr: looks like it's internal to univalue, barring some race condition
20:04 -!- ryitpm [~ryitpm@87.121.52.41] has quit [Ping timeout: 260 seconds]
20:05 < Luke-Jr> :x
20:05 < jgarzik> Luke-Jr, quickest debug solution is running it under gdb in a VM that mimics travis OS setup
20:05 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]
20:05 < jgarzik> Smart to have such a VM lying around anyway
20:05 < Luke-Jr> that doesn't sound quick, considering Travis is closed source.. :/
20:06 < cfields> UniValue::setInt(int64_t val) -> setNumStr()
20:06 < jgarzik> the OS setup is easy to reproduce
20:06 < cfields> looks like your crash is at univalue.cpp:129
20:06 < jgarzik> setNumStr(oss.str());
20:07 < cfields> Luke-Jr: throw an assert(!oss.empty()) in there
20:07 < jgarzik> if css is empty, something is majorly broken with libstdc++
20:08  * jgarzik kicks autocorrect
20:08 < cfields> no clue how that would happen though
20:08 -!- ryitpm [~ryitpm@87.121.52.41] has joined #bitcoin-core-dev
20:08 < cfields> jgarzik: yea, threading/shutdown issue seems much more likely
20:10 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 256 seconds]
20:12 < Luke-Jr> ⁂ glibc detected ⁂ /home/travis/build/bitcoin/bitcoin/bitcoin-i686-pc-linux-gnu/src/bitcoin-cli: free(): invalid pointer: 0xb7774348 ⁂
20:12 < Luke-Jr> really doesn't suggest a NULL ptr thing
20:12 < Luke-Jr> IMO
20:13 < cfields> Luke-Jr: yea
20:14 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev
20:15 -!- adam3us [~Adium@184-23-239-227.dedicated.static.sonic.net] has quit [Quit: Leaving.]
20:21 < Luke-Jr> 1 hour download for old Ubuntu Server that Travis uses.. :/
20:25  * Luke-Jr kicks DSL
20:25 < Luke-Jr> at least I've confirmed Travis reproduces it..
20:35 < cfields> Luke-Jr: looking more closely, i think it's probably at univalue.cpp:118
20:35 < cfields> new guess is that the object is already destructed when that assign is attempted
20:38 -!- jcorgan|away is now known as jcorgan
20:50 < cfields> Luke-Jr: bitcoin-cli.cpp:214 as an example. Isn't that returning a bound temporary?
20:52 < Luke-Jr>     const UniValue& reply = valReply.get_obj(); ?
20:52 < Luke-Jr> seems get_obj just throws or returns *this
20:55 < cfields> Luke-Jr: yes, but it's a temporary bound to valReply, which goes out of scope when the function returns.
20:55 < Luke-Jr> oh, right
20:55 < Luke-Jr> didn't realise it was being returned
20:55 < cfields> unless there's some funky RVO that makes that legal
20:56 < Luke-Jr> doubt it
20:56 < Luke-Jr> oh
20:56 < Luke-Jr> it's probably because the return type is not a reference
20:56 < Luke-Jr> so it makes a copy
20:56 < Luke-Jr> ?
20:57 < jgarzik> correct - return value is not a reference
20:58 < jgarzik> FYI - get_obj() is legacy and should not be used
20:58 < jgarzik> it's just a dumb type check with a nutty assignment style
20:58 -!- guest21333 [~02@6e.17.01a8.ip4.static.sl-reverse.com] has quit [Ping timeout: 276 seconds]
20:59 < jgarzik> i.e. the purpose is simply to throw an exception if the type check fails
21:01 < cfields> erm, that still doesn't look right
21:06 < cfields> http://en.cppreference.com/w/cpp/language/reference_initialization
21:07 < cfields> see the first exception under "Lifetime of a temporary"
21:10 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Remote host closed the connection]
21:10 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev
21:11 < Luke-Jr> cfields: but it's not a temporary, it's scoped
21:12 < Luke-Jr> reply and valReply are literally the same thing
21:14 < Luke-Jr> lovely, ubuntu-12.04.5-server-amd64.iso doesn't work in KVM
21:14 < Luke-Jr> (and probably not at all)
21:21 < cfields> mm, ok
21:34 < Luke-Jr> put bitcoin-cli through valgrind for that rpc-test and it sees no issues
21:38 -!- xiangfu [~xiangfu@111.198.29.54] has quit [Ping timeout: 250 seconds]
21:51 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
22:01 -!- adam3us [~Adium@c-98-234-64-218.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:22 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 264 seconds]
22:22 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
22:26 -!- p15 [~p15@34.91.145.64.client.static.strong-tk2.bringover.net] has joined #bitcoin-core-dev
22:42 -!- brg444 [415ce066@gateway/web/freenode/ip.65.92.224.102] has quit [Ping timeout: 252 seconds]
22:53 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sqqdojcnesouwuls] has joined #bitcoin-core-dev
23:12 -!- jcorgan is now known as jcorgan|away