--- Day changed Wed Mar 09 2016 00:01 -!- chris200_ [~chris2000@p54B2C1FB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:05 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 00:08 -!- xabbix [~xabbix@unaffiliated/xabbix] has quit [Ping timeout: 244 seconds] 00:08 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:08 -!- xabbix [~xabbix@unaffiliated/xabbix] has joined #bitcoin-core-dev 00:10 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 00:24 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 00:36 -!- Don_John [~Don@247-223-114-134.nat.resnet.nau.edu] has quit [Ping timeout: 244 seconds] 00:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:41 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 00:42 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:43 -!- chris200_ [~chris2000@p54B2C1FB.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 00:59 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 01:06 -!- jtimon [~quassel@35.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 276 seconds] 01:11 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:17 -!- AaronvanW_ [~ewout@x4db483f1.dyn.telefonica.de] has joined #bitcoin-core-dev 01:22 < GitHub57> [bitcoin] btcdrak opened pull request #7658: Add curl to Gitian setup instrustions (master...curl) https://github.com/bitcoin/bitcoin/pull/7658 01:27 < phantomcircuit> are we using git submodule or git subtree ? 01:29 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [] 01:33 -!- wallet42 [~wallet42@unaffiliated/wallet42] has quit [Quit: Leaving.] 01:35 < jonasschnelli> phantomcircuit: subtree 01:35 < jonasschnelli> secp256k1, univalue, leveldb 01:39 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 01:40 < nsh> jgarzik, is univalue de novo code or based on another library? 01:40 < nsh> (parsers scare me from a software security perspective. i wonder if it should be fuzzed or otherwise audited) 01:43 < gmaxwell> it's denovo. it was originally vulnerable when it was merged in bitcoin core. 01:43 < gmaxwell> after the first vulnerability was found extensive fuzz testing was done. 01:44 < gmaxwell> Andytoshi implemented a functional equivilent in rust so we could do cross implementation round-trip/agreement tests, and a number of non-security bugs were found in it which haven't been fixed yet. 01:44 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:44 < nsh> ah, great 01:44 < nsh> i scanned the respository for the words 'grammar' 'lexer' and 'parser' and was disappointface but not surpriseface :) 01:45 < jonasschnelli> univalue was used <0.12 for bitcoin-tx ... and its the default json parser/encode since 0.12 01:46 < jonasschnelli> And by default I think there are no attack vectors for the JSON parser/encode...because you can't parse/encode unless you can do RPC auth or unless you enabled -rest=1 01:46 < gmaxwell> nsh: fortunately we also do not take json from untrusted inputs. 01:46 < nsh> right 01:46 < gmaxwell> (even with rest=1) 01:47 < gmaxwell> so that helps too. 01:47 < nsh> there may be some instances where people are running services that expose the RPC to unvalidated input 01:47 < nsh> even though this would be inadvisable. we can't really see how people use bitcoind in their services easily 01:47 < gmaxwell> yea, maybe but I caution against that. 01:47 * nsh nods 01:48 < gmaxwell> I would be kind of surprised if there werent vulnerabilities there beyond the obvious. 01:48 < nsh> likewise 01:48 < gmaxwell> (obvious being that the walletexport/backup rpcs that take files can overwrite anything bitcoind can write to.) 01:49 < gmaxwell> there are almost certantly memory exhaustion attacks one can perform from the RPC. 01:49 < nsh> in principle bitcoind could be containerised to only have write access to the leveldb and config files it needs to overwrite 01:49 < nsh> but that might not be proportionate 01:49 < nsh> (and container solutions are not mature yet) 01:49 < gmaxwell> it doesn't overwrite its own config files. 01:49 < nsh> ah, my bad 01:50 < phantomcircuit> nsh, backupwallet can write anywhere 01:51 < phantomcircuit> which makes building a selinux profile mostly useless 01:51 * nsh nods 01:51 < phantomcircuit> etc etc for containerization 01:51 < nsh> what's a sensible way forward in terms of least privilegeing [if that can be granted as a verb] 01:52 < nsh> ? 01:53 < jonasschnelli> phantomcircuit: In case you want to check my first logdb implementation, check: https://github.com/libbtc/libbtc/pull/41 and feel free to feedback 01:53 < gmaxwell> phantomcircuit: warren has been working on selinux policy that just denies that external FS access, and there is an selinux bool to reenable it if you really want it to be able to access outside of its directory. 01:53 < jonasschnelli> format is explained here: https://github.com/jonasschnelli/libbtc/commit/319cce54c34f6c91a4f58d4bd4823c177f206579#diff-73f280355a901d2fc049af287aed9e90R29 01:54 < gmaxwell> phantomcircuit: ultimately I think we should add replacements for those rpcs that send the data over the rpc... and depricate the ones that write locally. 01:55 < phantomcircuit> gmaxwell, that sounds like a sound plan 01:59 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 02:23 -!- AaronvanW_ [~ewout@x4db483f1.dyn.telefonica.de] has quit [Quit: Leaving] 02:24 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:26 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 244 seconds] 02:30 < GitHub190> [bitcoin] btcdrak opened pull request #7659: gitian: Add suport for deterministic armhf builds (master...arm) https://github.com/bitcoin/bitcoin/pull/7659 03:40 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 03:40 -!- fengling [~fengling@111.198.29.53] has quit [Ping timeout: 240 seconds] 03:49 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt] 03:53 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 03:53 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 04:04 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 04:24 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:24 -!- laurentmt1 [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 04:25 -!- hsmiths2 [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev 04:26 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-myaeonkojypkrslr] has joined #bitcoin-core-dev 04:27 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Ping timeout: 240 seconds] 04:27 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Ping timeout: 240 seconds] 04:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hmxflbffbbbimrql] has quit [Ping timeout: 240 seconds] 04:27 -!- Guest30748 [~ChillazZ@194.97.152.20] has quit [Ping timeout: 240 seconds] 04:27 -!- jron [~okok@ec2-54-161-129-226.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds] 04:27 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 04:27 -!- viderizer2 [~viderizer@qux.fi] has quit [Ping timeout: 240 seconds] 04:27 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 240 seconds] 04:27 -!- xabbix [~xabbix@unaffiliated/xabbix] has quit [Ping timeout: 240 seconds] 04:27 -!- JackH [~Jack@host-2-103-125-30.as13285.net] has quit [Ping timeout: 240 seconds] 04:27 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds] 04:27 -!- anttea [~anttea@a88-112-146-73.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 04:27 -!- laurentmt1 is now known as laurentmt 04:27 -!- Ylbam_ is now known as Ylbam 04:27 -!- ChillazZ [~ChillazZ@194.97.152.20] has joined #bitcoin-core-dev 04:27 -!- anttea [~anttea@a88-112-146-73.elisa-laajakaista.fi] has joined #bitcoin-core-dev 04:27 -!- JackH [~Jack@host-2-103-125-30.as13285.net] has joined #bitcoin-core-dev 04:27 -!- ChillazZ is now known as Guest15994 04:28 -!- xabbix [~xabbix@unaffiliated/xabbix] has joined #bitcoin-core-dev 04:28 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 04:34 -!- jron [~okok@ec2-54-161-129-226.compute-1.amazonaws.com] has joined #bitcoin-core-dev 04:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:39 -!- viderizer2 [~viderizer@qux.fi] has joined #bitcoin-core-dev 04:41 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 04:46 -!- jtimon [~quassel@35.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:51 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Disconnected by services] 04:52 -!- Guyver2_ is now known as Guyver2 05:28 -!- lysobit [~musalbas@2001:bc8:30c2::] has joined #bitcoin-core-dev 05:34 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 05:40 -!- chris200_ [~chris2000@p54B2C1FB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:51 -!- cjcj [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has joined #bitcoin-core-dev 06:18 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 06:18 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt] 06:25 -!- chris200_ [~chris2000@p54B2C1FB.dip0.t-ipconnect.de] has quit [] 06:42 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 06:54 -!- zooko [~user@2601:281:8301:eb00::b051] has joined #bitcoin-core-dev 07:05 -!- xiangfu [~xiangfu@114.111.167.250] has joined #bitcoin-core-dev 07:22 -!- xiangfu [~xiangfu@114.111.167.250] has quit [Ping timeout: 248 seconds] 07:22 -!- zooko [~user@2601:281:8301:eb00::b051] has quit [Ping timeout: 248 seconds] 07:23 < GitHub137> [bitcoin] MarcoFalke opened pull request #7660: [amount] Extend GetFee() by optional flag ceil (master...Mf1603-amountCeil) https://github.com/bitcoin/bitcoin/pull/7660 07:24 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt] 07:25 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.] 07:25 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 07:25 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Client Quit] 07:26 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev 07:34 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:38 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 07:38 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has quit [Changing host] 07:38 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 07:45 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 07:48 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 07:56 < instagibbs> what does this mean: 07:56 < instagibbs> The command "if [ "$RUN_TESTS" = "true" ]; then qa/pull-tester/rpc-tests.py --coverage; fi" exited with 1. 07:57 < MarcoFalke> Some issue in the rpc test suite? 07:57 < MarcoFalke> Likely the well know wallet issue? 07:58 < instagibbs> hmm, my pull is failing this for one travis build, i barely changed the test too, before it was fine. Is it likely my fault? 07:59 < MarcoFalke> Just look for the line with "AssertionError" or something like this, to see where it fails. (Or send us the link) 07:59 < warren> gmaxwell: oops, I forgot about the FS access part, only the exec bool, I'll have both. 08:04 < instagibbs> MarcoFalke, nevermind, I'll do more investigation first thanks 08:06 < instagibbs> https://travis-ci.org/bitcoin/bitcoin/jobs/114248476#L4131 08:14 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:16 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 08:17 < GitHub107> [bitcoin] MarcoFalke opened pull request #7661: [wallet] Round up to the next satoshi on odd fee rates (master...Mf1603-walletCeil) https://github.com/bitcoin/bitcoin/pull/7661 08:26 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 08:29 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Ping timeout: 244 seconds] 08:36 < GitHub100> [bitcoin] rat4 opened pull request #7662: remove unused NOBLKS_VERSION_{START,END} constants (master...patch) https://github.com/bitcoin/bitcoin/pull/7662 08:42 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 08:42 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:44 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Disconnected by services] 08:44 -!- Guyver2_ is now known as Guyver2 08:47 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 08:47 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has quit [Changing host] 08:47 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 08:50 < MarcoFalke> morcos, IsStandard depends on IsDust which depends on GetFee() 08:50 < MarcoFalke> so making GetFee() do a ceil all the time would cause unwanted side effects prob. 08:51 < morcos> MarcoFalke: eh.. then make it truncate all the time 08:51 < MarcoFalke> ... would introduce the regression for small fee rates 08:51 < MarcoFalke> https://github.com/bitcoin/bitcoin/pull/4465#issue-37199263 08:51 < MarcoFalke> second bullet point 08:51 < morcos> I'm not sure that really counts though, who cares if the defniition of IsDust changes microscopically. It already changed drastically from 0.11.1 to 0.11.2 and back for 0.12.0 08:52 -!- zooko [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev 08:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:53 < morcos> MarcoFalke: yeah i read that bullet point... is that even how the code works now? 08:53 < MarcoFalke> yup, I guess so: https://github.com/MarcoFalke/bitcoin/commit/1923bb13de2bb45646b3437ecfa1781df15f88e9 08:53 < MarcoFalke> if (nFeeNeeded == 0) check is still there 08:53 < morcos> yeah 08:54 < morcos> but that seems intended behavior right 08:54 < morcos> at least if you change it round (neither ceil nor trunc) 08:55 < MarcoFalke> If I `settxfee 1e-8`, I expect the wallet to go into the paytxfee-branch 08:55 < morcos> if you say you want to pay 1 sat per 1000 bytes, and you put something of 499 bytes in there. why should we intrepet that as you intending to pay 1 satoshi and not 0 08:55 < morcos> we already don't let you pay 0... so if you specify 0 another way, why is that different 08:56 < morcos> i don't really care, but i just think the CFeeRate class needs to not get more convoluted 08:56 < morcos> its already an annoying class 08:56 < MarcoFalke> In the first case you pay fallbackfee, in the other case you pay 1 sat 08:56 < MarcoFalke> It's mostly not relevant for mainnet 08:56 < morcos> but you asked to pay 0 08:56 < morcos> make it do ceiling then, i agree we need to just look through the follow on effects 08:57 < morcos> but i don't see a priori why they would be a problem 08:57 < MarcoFalke> You asked to pay 1 sat per kB and the wallet should always pay that fee rate (or slightly more) 08:58 < MarcoFalke> Ok, I had the ceil-only patch somwhere laying around this mornig but I deleted it in the meantime 08:58 < morcos> so are you ok with just making it always ceiling then? 08:58 < MarcoFalke> I will just create a pull and see what others think 08:59 < morcos> anyway, got to run, i don't like making that silly class more complicated though 09:18 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 09:20 -!- skyraider_ [uid41097@gateway/web/irccloud.com/x-pympxvmdwsjfwzsp] has joined #bitcoin-core-dev 09:21 -!- skyraider_ is now known as skyraider 09:27 < wumpus> back in NL 09:28 < sipa> congrats! 09:29 < btcdrak> wumpus: \o/ now for jetlag sleep :) 09:33 < Bootvis_> welcome back 09:33 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 09:38 -!- Tasoshi [~Tasoshi@unaffiliated/tasoshi] has joined #bitcoin-core-dev 09:43 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Quit: WeeChat 1.4-dev] 09:48 < wumpus> thanks :) 09:48 -!- Don_John [~Don@251-223-114-134.nat.resnet.nau.edu] has joined #bitcoin-core-dev 09:50 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 09:50 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 244 seconds] 09:53 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 10:01 -!- Don_John [~Don@251-223-114-134.nat.resnet.nau.edu] has quit [Read error: Connection reset by peer] 10:14 < jonasschnelli> wumpus: welcome back, hope you had a good flight! 10:16 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 10:16 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 10:25 < sipa> i'll be back in europe on friday 10:25 -!- zooko [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 250 seconds] 10:25 < jonasschnelli> sipa: still in Boston? 10:26 < sipa> sf now 10:27 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:27 < jonasschnelli> hah. Globetrotter. 10:28 < morcos> jonasschnelli: missed you in boston, we were about to split the wallet out from Core, but decided to push it off another 5 years since you weren't there 10:29 < sipa> haha 10:29 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 10:32 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 10:36 < Luke-Jr> lol 10:40 -!- fkhan_ [weechat@gateway/vpn/mullvad/x-iltxbgikbwiodkxe] has quit [Ping timeout: 264 seconds] 10:48 -!- zooko [~user@c-73-14-173-69.hsd1.co.comcast.net] has joined #bitcoin-core-dev 10:48 -!- zooko` [~user@c-73-14-173-69.hsd1.co.comcast.net] has joined #bitcoin-core-dev 10:52 < morcos> sipa: did you see my other comment on versionbits. about setting block version = 4? 10:52 -!- fkhan_ [weechat@gateway/vpn/mullvad/x-jfhvxzubeusqxhba] has joined #bitcoin-core-dev 10:52 < morcos> i think it would make sense to also include in the first version bits soft fork a requirement that block version > 4 10:53 < morcos> then the warning code can ignore blocks <= 4 because they will be invalid once the soft fork activates. this is analogous to how ISM soft forks have worked 10:54 < morcos> we should also start setting TOP_BITS immediately... yes that means that old code will be warned to upgrade potentially before any soft fork is being rolled out, but that to me only serves to be more warning time. 10:54 < morcos> if we were going to roll out verison bits code without the soft fork included, then i could see the argument against, b/c they'd get tricked into upgrading twice. but as long as they only need to upgrade that first time, its only a good thing that they are warned about it earlier 11:05 -!- cfields [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev 11:18 -!- zooko` [~user@c-73-14-173-69.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 11:19 -!- zooko [~user@c-73-14-173-69.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 11:22 < jonasschnelli> morcos: haha! 11:22 < jonasschnelli> morcos: You and Suhas where there? 11:25 < morcos> yeah, just came for the day monday 11:28 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt] 11:29 -!- zooko [~user@172.58.136.30] has joined #bitcoin-core-dev 11:31 < jonasschnelli> To bad I had to fly home on sunday. 11:31 < cfields> jonasschnelli: you didn't come home and find a new baby, i hope? :) 11:32 < jonasschnelli> cfields: Not yet. Still a couple of month to go... 11:32 < jonasschnelli> (buhh...) 11:32 < cfields> heh, good 11:34 -!- zooko [~user@172.58.136.30] has quit [Ping timeout: 276 seconds] 11:43 -!- wallet42 [~wallet42@unaffiliated/wallet42] has joined #bitcoin-core-dev 11:47 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:49 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 11:51 -!- p15 [~p15@111.193.183.186] has quit [Ping timeout: 276 seconds] 12:06 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:11 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 12:12 < GitHub69> [bitcoin] btcdrak closed pull request #7659: gitian: Add suport for deterministic armhf builds (master...arm) https://github.com/bitcoin/bitcoin/pull/7659 12:13 -!- moli [~molly@unaffiliated/molly] has quit [Quit: //..//..] 12:26 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 12:32 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:40 < GitHub124> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/87d65622996d...386f4385ab04 12:40 < GitHub124> bitcoin/master 7d2f84c Pavel Vasin: remove unused NOBLKS_VERSION_{START,END} constants 12:40 < GitHub124> bitcoin/master 386f438 Pieter Wuille: Merge #7662: remove unused NOBLKS_VERSION_{START,END} constants... 12:40 < GitHub8> [bitcoin] sipa closed pull request #7662: remove unused NOBLKS_VERSION_{START,END} constants (master...patch) https://github.com/bitcoin/bitcoin/pull/7662 12:43 < jonasschnelli> sipa: BTW, I have written a C implementation of "logdb". If you want to rain down your criticism (which is appreciated!). 12:43 < jonasschnelli> https://github.com/libbtc/libbtc/pull/41 12:44 < jonasschnelli> It will be used as wallet data-format in the SPV implementation I'm writing. 12:46 < cfields> jonasschnelli: nice 12:46 < jonasschnelli> cfields: a design decision would be, to use your libbtcnet implementation for the network layer. 12:47 < jonasschnelli> Though, would be C++ then. 12:47 < jonasschnelli> I guess even C++11. 12:47 < cfields> jonasschnelli: It was designed so that a C api should be simple enough 12:47 < jonasschnelli> But,... I don't expect people using the net layer on a MCU device. C++ could be fine for that case... 12:48 < cfields> jonasschnelli: so you'd end up with the c++ runtime, but it wouldn't require a c++ compiler for your stuff 12:48 < jonasschnelli> cfields: Hmm.. but I guess the c++ runtime is to big for atmel cortex chips... 12:50 < cfields> jonasschnelli: unsure what spec you're dealing with, but yes, i can see how that'd be much heavier than what you're currently working with 12:50 < jonasschnelli> I just hope I made the right design choices... always unsure about C vs C++ 12:51 < sipa> jonasschnelli: you're not alone :) 12:51 < sipa> libsecp256k1 started as C++, btw :p 12:51 < sipa> then C99, then C89 12:51 < cfields> jonasschnelli: well c++11 adds even more into the mix. It hugely reduces allocations 12:51 < jonasschnelli> sipa: ah. Didn't know that. But C makes certainly sense for a crypto library... not sure for a SPV library.. 12:52 < jonasschnelli> But I kinda like the simpleness and portability of C 12:52 < GitHub95> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/386f4385ab04...c8d2473e6cb0 12:52 < GitHub95> bitcoin/master 9988554 R E Broadley: No "Unknown command" for getaddr command. 12:52 < GitHub95> bitcoin/master c8d2473 Pieter Wuille: Merge #7642: Avoid "Unknown command" messages when receiving getaddr on outbound c…... 12:53 < GitHub152> [bitcoin] sipa closed pull request #7642: Avoid "Unknown command" messages when receiving getaddr on outbound c… (master...GetAddrUnknownCommand) https://github.com/bitcoin/bitcoin/pull/7642 12:55 < cfields> sipa: i managed to process where we were mis-aligned wrt threading models. I was far too close to the code to see what you were asking. I'll add some notes to the design doc to explain. 12:56 < sipa> cfields: please don't let my comments cause you extra work 12:56 < sipa> i think the model you used is perfect as a lowest-layer replacement for the current network code, and we should work to get it in 12:56 < cfields> sipa: tl;dr: the event loop is essentially a large wrapper around select/epoll/etc, so thread management must be done a layer above 12:58 < cfields> sipa: no problem, i just want to be able to explain the design choices, so that discussion was helpful. 13:04 -!- zooko [~user@50.246.213.170] has joined #bitcoin-core-dev 13:09 -!- moli [~molly@unaffiliated/molly] has quit [Quit: //..//..] 13:16 -!- zooko [~user@50.246.213.170] has quit [Ping timeout: 260 seconds] 13:20 -!- skyraider [uid41097@gateway/web/irccloud.com/x-pympxvmdwsjfwzsp] has quit [Quit: Connection closed for inactivity] 13:32 < GitHub45> [bitcoin] sipa opened pull request #7663: Make the generate RPC call function for non-regtest (master...generatenonreg) https://github.com/bitcoin/bitcoin/pull/7663 13:32 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 13:44 < gmaxwell> I'm concerned about this: https://github.com/bitcoin/bitcoin/issues/7657 13:48 < gmaxwell> My analysis on #1643 was that the change suggested there would potentially cause wallets to be more ground up into small coins; the author there did some simulation and and it least some models saw that effect. (doubling the utxo set size in test case 7, and increasing it by 40% in test case 8). 13:48 < gmaxwell> And now we have a user complaining about the effect. 13:51 < gmaxwell> I missed that we merged this.... I think immediate action may be needed to improve the situation, explosion in the utxo set size may take a long time to reverse. 13:51 < sipa> which PR changed it? 13:51 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/4906 13:52 < gmaxwell> sipa: basically the old behavior didn't do what it said on the tin, the coin selection would sometimes select extra coins that it technically didn't have to select. 13:52 < gmaxwell> So the change fixed that to prune them out. 13:54 < gmaxwell> and I'm wondering if this wasn't responsible for the increase we've seen in the utxo growth rate even after filtering out some of the obvious dust-spam. 13:54 < sipa> perhaps we should make the wallet produce 2 change outputs, where one mimicks the amount sent (mimcks, not equals) 13:55 < sipa> that's for privacy, not for utxo optimization, but i expect it to lead to a better distribution of coin sizes to pick from 14:00 < gmaxwell> sipa: I've suggested a scheme before where you do two change outputs and flip a coin: either you split the change amount, OR you copy the output amount. 14:01 < gmaxwell> (though I suggested doing this only when the change would be fairly large) 14:02 < gmaxwell> in general I think we should have a scheme which does not select coins but selects 'taint groups' (maybe a taint group is just a particular scriptpubkey) and spends all the coins in it, subject to some sanity limitation. 14:02 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 14:14 -!- treehug88 [~textual@static-108-30-103-59.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:24 < cfields> morcos: https://github.com/theuni/bitcoin/commit/eeda3643766b2110ecf6596d7fb24718412a043a 14:27 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 14:28 -!- nsh [~lol@wikipedia/nsh] has quit [Quit: ZNC - http://znc.in] 14:30 -!- lysobit [~musalbas@2001:bc8:30c2::] has quit [Read error: Connection reset by peer] 14:33 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 14:33 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 14:34 -!- lysobit [~musalbas@2001:bc8:30c2::] has joined #bitcoin-core-dev 14:43 -!- wallet42 [~wallet42@unaffiliated/wallet42] has quit [Quit: Leaving.] 14:45 -!- wallet42 [~wallet42@unaffiliated/wallet42] has joined #bitcoin-core-dev 14:45 -!- wallet42 [~wallet42@unaffiliated/wallet42] has quit [Client Quit] 15:00 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 15:00 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 250 seconds] 15:01 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 268 seconds] 15:01 -!- amiller [~socrates1@unaffiliated/socrates1024] has quit [Ping timeout: 268 seconds] 15:03 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev 15:04 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 15:11 -!- Guest88865 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 15:16 -!- Guest88865 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 268 seconds] 15:17 < cfields> sipa: re our aes impl. Would you prefer to remove the tables before merge? Or ok to do it as a next step? 15:17 < cfields> (assuming it wouldn't be worse than what we currently have with openssl) 15:21 -!- amiller_ [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 15:23 < cfields> sipa: by which i mean "would you prefer that i remove the tables" ofc :) 15:24 < sipa> cfields: i'm now thinking about how you would implement all of the AES steps without tables 15:25 < gmaxwell> AES is notoriously painful to do both sidechannel free and fast. 15:25 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 15:25 < gmaxwell> The tables could be converted into CMOV oblivious lookups, for a big speed hit. 15:26 < cfields> sipa: ah, our discussion had me believe that there was a standard alternate approach 15:27 < sipa> cfields: hmm, no; i think you'll find plenty of academic work for fast & sidechannel free AES, but nothing standard 15:27 < sipa> *but* i think AES is trivial to do slow & sidechannel free 15:27 < sipa> well, constant-time 15:29 < sipa> hmm, the S-box is nontrivial 15:39 < sipa> i guess you'll need a cmov for the sbox 15:39 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 15:40 < sipa> everything else can be done algebraically... the first thing besides the S-box is a GF(2^8) multiplication by 3 15:40 < sipa> s/first thing/worst thing/ 15:42 < morcos> gmaxwell: re: #4906, i flagged that shortly after it got merged echoing your concerns. wumpus asked us if we should revert it and you and i both told him no. 15:43 < gmaxwell> lol 15:43 < morcos> gmaxwell: i think its unlikely that its had much of an effect on utxo set already, b/c its only been included since 0.12 right? but this is an example of something that we'll all forget about revisiting in time for 0.13 if we don't put it on a list somewhere 15:44 < gmaxwell> morcos: it's been merged for a while, so it may be the case that people running pre-releases have had an effect. 15:44 < gmaxwell> certantly if it is the cause of this user's complaint it's a cause for concern. 15:44 < gmaxwell> But I think we wouldn't revert regardless, we would move forward. 15:45 < morcos> Should we maintain an issue that includes goals for 0.13, or open a new issue and tag it with milestone 0.13 or something.. it'd be nice if we were more organized about this stuff 15:46 < gmaxwell> I think perhaps one reason I also might have said to not revert it was a belief that we'd move forward and further fix the issue before the release but then it fell off the radar. A milestoned issue would probably be fine. 15:53 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Quit: Connection reset by Beer] 15:53 < morcos> ttps://github.com/bitcoin/bitcoin/issues/7664 15:53 < morcos> oops 15:53 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 15:53 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has quit [Changing host] 15:53 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:54 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Ping timeout: 246 seconds] 15:55 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev 16:15 -!- zooko [~user@c-73-229-199-227.hsd1.co.comcast.net] has joined #bitcoin-core-dev 16:25 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 16:34 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 16:34 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 16:38 -!- Don_John [~Don@247-223-114-134.nat.resnet.nau.edu] has joined #bitcoin-core-dev 16:39 -!- Don_John [~Don@247-223-114-134.nat.resnet.nau.edu] has quit [Client Quit] 16:43 -!- anchow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 16:44 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 16:45 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Disconnected by services] 16:45 -!- Arnavion3 [~Arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 16:45 -!- Arnavion3 is now known as Arnavion 16:45 -!- jl2012_ [uid133844@gateway/web/irccloud.com/x-ufuxzpbpvcgskxkg] has joined #bitcoin-core-dev 16:45 -!- ibrightly_ [sid113387@gateway/web/irccloud.com/x-zrjpujtphdfdsqln] has joined #bitcoin-core-dev 16:49 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Ping timeout: 248 seconds] 16:49 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-zjhuubqerntidnbi] has quit [Ping timeout: 248 seconds] 16:49 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-derycaicqwgctjsg] has quit [Ping timeout: 248 seconds] 16:49 -!- aknix [~aknix@65.78.54.2] has quit [Ping timeout: 248 seconds] 16:49 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Ping timeout: 248 seconds] 16:49 -!- cfields [~quassel@unaffiliated/cfields] has quit [Ping timeout: 248 seconds] 16:49 -!- cfields_ [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev 16:49 -!- jl2012_ is now known as jl2012 16:49 -!- ibrightly_ is now known as ibrightly 16:50 -!- aknix [~aknix@65.78.54.2] has joined #bitcoin-core-dev 16:54 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 17:12 -!- Don_John [~Don@247-223-114-134.nat.resnet.nau.edu] has joined #bitcoin-core-dev 17:17 -!- Arnavion [~Arnavion@unaffiliated/arnavion] has quit [Quit: Arnavion] 17:17 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 17:20 -!- grassass [grass@gateway/vpn/mullvad/x-yaezckkzxnxrkwro] has quit [Ping timeout: 260 seconds] 17:22 -!- fengling [~fengling@111.198.29.53] has joined #bitcoin-core-dev 17:35 -!- zooko [~user@c-73-229-199-227.hsd1.co.comcast.net] has quit [Ping timeout: 276 seconds] 18:00 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-myaeonkojypkrslr] has quit [Quit: Connection closed for inactivity] 18:12 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.] 18:12 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 18:32 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 18:44 -!- zooko [~user@50.141.118.255] has joined #bitcoin-core-dev 18:45 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 18:46 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:58 -!- zooko [~user@50.141.118.255] has quit [Remote host closed the connection] 19:00 -!- wallet42 [~wallet42@unaffiliated/wallet42] has joined #bitcoin-core-dev 19:21 -!- murr4y [murray@54.77.13.229] has quit [Ping timeout: 264 seconds] 19:21 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Ping timeout: 252 seconds] 19:23 -!- murr4y [murray@54.77.13.229] has joined #bitcoin-core-dev 19:23 -!- p15 [~p15@131.91.145.64.unassigned.bringover.net] has joined #bitcoin-core-dev 19:26 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 19:27 -!- p15 [~p15@131.91.145.64.unassigned.bringover.net] has quit [Client Quit] 19:27 -!- p15 [~p15@131.91.145.64.unassigned.bringover.net] has joined #bitcoin-core-dev 19:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:37 -!- anchow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer] 19:43 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 19:55 < GitHub50> [bitcoin] jtimon opened pull request #7665: Contrib: Introduce script to tag compiled binaries for convenience (py) (master...0.12.99-contrib-tag) https://github.com/bitcoin/bitcoin/pull/7665 20:12 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 20:14 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 20:14 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Remote host closed the connection] 20:20 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 20:32 -!- murr4y [murray@54.77.13.229] has quit [Ping timeout: 240 seconds] 20:43 -!- Cory [~C@unaffiliated/cory] has quit [Ping timeout: 268 seconds] 20:43 -!- Chris_Stewart_5 [~Chris_Ste@179.43.176.194] has quit [Ping timeout: 240 seconds] 20:44 -!- Pasha [~C@unaffiliated/cory] has joined #bitcoin-core-dev 20:51 -!- Pasha is now known as Cory 20:52 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Ping timeout: 248 seconds] 20:55 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Ping timeout: 246 seconds] 20:58 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:59 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:59 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 21:18 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.] 21:30 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 21:40 -!- Netsplit *.net <-> *.split quits: anttea, Guest15994, cfields_ 21:46 -!- Netsplit over, joins: cfields_, anttea, Guest15994 21:51 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has quit [Ping timeout: 268 seconds] 21:51 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has joined #bitcoin-core-dev 21:58 -!- fengling [~fengling@111.198.29.53] has quit [Ping timeout: 240 seconds] 22:00 -!- fengling [~fengling@111.198.29.53] has joined #bitcoin-core-dev 22:03 -!- Netsplit *.net <-> *.split quits: cfields_, anttea, Guest15994 22:03 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:04 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:08 -!- Netsplit over, joins: cfields_, anttea, Guest15994 22:36 -!- murr4y [murray@54.77.13.229] has joined #bitcoin-core-dev 23:06 -!- Tasoshi [~Tasoshi@unaffiliated/tasoshi] has quit [Ping timeout: 244 seconds] 23:16 -!- hybridsole [~hybridsol@c-67-177-114-112.hsd1.fl.comcast.net] has quit [Ping timeout: 244 seconds] 23:32 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Quit: Leaving.] 23:38 -!- Don_John [~Don@247-223-114-134.nat.resnet.nau.edu] has quit [Read error: Connection reset by peer] 23:45 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 244 seconds] 23:46 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 23:53 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:57 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 23:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rxylxvosbtclpvch] has joined #bitcoin-core-dev