--- Day changed Mon Mar 21 2016
00:04 -!- pigeons [~pigeons@94.242.209.214] has joined #bitcoin-core-dev
00:05 -!- pigeons is now known as Guest16439
00:06 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
00:08 -!- B4ckJ4ck007 [~ipalyi@213.4.200.211] has joined #bitcoin-core-dev
00:20 -!- Guest16439 [~pigeons@94.242.209.214] has quit [Ping timeout: 244 seconds]
00:21 -!- pigeons_ [~pigeons@94.242.209.214] has joined #bitcoin-core-dev
00:23 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
00:35 -!- wallet42 [~wallet42@unaffiliated/wallet42] has joined #bitcoin-core-dev
01:01 -!- fengling [~fengling@111.198.29.53] has quit [Ping timeout: 240 seconds]
01:01 -!- fengling_ [~fengling@111.198.29.53] has joined #bitcoin-core-dev
01:06 < jonasschnelli> sipa: we might want to list the datadir in the debug window...
01:06 < jonasschnelli> We could remove the "build date" for stable releases (keep it for self compiled versions).
01:10 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
01:12 -!- fengling_ [~fengling@111.198.29.53] has quit [Ping timeout: 240 seconds]
01:16 -!- wallet42 [~wallet42@unaffiliated/wallet42] has quit [Quit: Leaving.]
01:20 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:21 -!- fengling_ [~fengling@111.198.29.53] has joined #bitcoin-core-dev
01:28 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
02:08 -!- madu [~madu@89-64-212-2.dynamic.chello.pl] has joined #bitcoin-core-dev
02:15 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
02:24 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
02:28 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:42 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev
02:45 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Remote host closed the connection]
02:47 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
03:00 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
03:18 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection]
03:21 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
03:21 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]
03:21 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev
03:26 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev
03:30 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev
03:38 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
03:45 < wumpus> jonasschnelli: +1 on removing build date and adding the datadir
03:45 < jonasschnelli> Okay. Will change that soon.
03:45 < wumpus> build date should really be removed, it's non sensical for gitian builds anyway
03:46 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
04:04 < GitHub112> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/29e1131c4642...7b832d286bd1
04:04 < GitHub112> bitcoin/master 3252208 João Barbosa: Improve EncodeBase58 performance
04:04 < GitHub112> bitcoin/master 7b832d2 Wladimir J. van der Laan: Merge #7656: Improve EncodeBase58 performance...
04:04 < GitHub94> [bitcoin] laanwj closed pull request #7656: Improve EncodeBase58 performance (master...enhancement/speedup-encodebase58) https://github.com/bitcoin/bitcoin/pull/7656
04:08 < MarcoFalke> wumpus, to be consistent, I'd have to add the future import for every .py file in /qa ?!
04:09 < wumpus> MarcoFalke: yes
04:09 < wumpus> any that uses print as a function, at least
04:09 < wumpus> it *enforces* using print as a function
04:09 < wumpus> so it's better to do it for all I guess
04:10 < wumpus> that's why I started with the files used directly by the build system in #7723 - we can require python2.7 for the qa tests for now, but it's more annoying if `make check` needs a special dependency
04:11 < MarcoFalke> You are planning to support py2 and py3 for the build system?
04:11 < wumpus> yes
04:11 < MarcoFalke> Sounds reasonable, but I don't think we can do it for the rpc tests
04:12 < wumpus> it's only a few files, anyway
04:12 < wumpus> I agree
04:12 < wumpus> but please do the print_functions properly, that's all I ask :p
04:12 < wumpus> unicode literal is more annoying, in general
04:12 < MarcoFalke> Ok, will do; but don't complain about the huge diff
04:12 < wumpus> I never complained about a huge diff in the test code
04:13 < MarcoFalke> fine :)
04:15 < wumpus> and I mean if everyone is okay with dropping python2 support I'm fine with that, but I predict it's going to be another thing people feel very strongly about, and I'm saving that energy for arguing for c++11 for now :)
04:21 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
04:26 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
04:28 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:32 < wumpus> MarcoFalke: https://github.com/bitcoin/bitcoin/issues/7717#issuecomment-199233464
04:37 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
04:40 < GitHub165> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b832d286bd1...ddfd79659e31
04:40 < GitHub165> bitcoin/master fab6880 MarcoFalke: [qa] Add amount tests
04:40 < GitHub165> bitcoin/master faf756a MarcoFalke: [amount] Make GetFee() monotonic...
04:40 < GitHub165> bitcoin/master fad13b1 MarcoFalke: [amount] Preempt issues with negative fee rates
04:41 < GitHub81> [bitcoin] laanwj closed pull request #7705: [amount] Add tests and make GetFee() monotonic (master...Mf1603-amountFix) https://github.com/bitcoin/bitcoin/pull/7705
04:42 -!- fengling_ [~fengling@111.198.29.53] has quit [Quit: WeeChat 1.4]
04:44 < GitHub166> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ddfd79659e31...9426632cb58d
04:44 < GitHub166> bitcoin/master c90036f Patrick Strateman: Always disconnect old nodes which request filtered connections.
04:44 < GitHub166> bitcoin/master 9426632 Wladimir J. van der Laan: Merge #7708: De-neuter NODE_BLOOM...
04:44 < GitHub6> [bitcoin] laanwj closed pull request #7708: De-neuter NODE_BLOOM (master...2016-03-17-nodebloom) https://github.com/bitcoin/bitcoin/pull/7708
04:45 < wumpus> BlueMatt: can you take a look at https://github.com/bitcoin/bitcoin/pull/7713, it changes verify-commits.sh
04:47 < GitHub129> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9426632cb58d...3b4324b1edd7
04:47 < GitHub129> bitcoin/master fab3890 MarcoFalke: [qa] rpc-test: Normalize assert()
04:47 < GitHub129> bitcoin/master 3b4324b Wladimir J. van der Laan: Merge #7720: [qa] rpc-test: Normalize assert()...
04:47 < GitHub82> [bitcoin] laanwj closed pull request #7720: [qa] rpc-test: Normalize assert() (master...Mf1603-qaAssertNorm) https://github.com/bitcoin/bitcoin/pull/7720
04:51 < GitHub97> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b4324b1edd7...3c27067dd2db
04:51 < GitHub97> bitcoin/master 0f17692 João Barbosa: Improve COutPoint less operator
04:51 < GitHub97> bitcoin/master 3c27067 Wladimir J. van der Laan: Merge #7712: Improve COutPoint less operator...
04:51 < GitHub164> [bitcoin] laanwj closed pull request #7712: Improve COutPoint less operator (master...enhancement/improve-coutpoint-less-operator) https://github.com/bitcoin/bitcoin/pull/7712
04:51 < GitHub131> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c27067dd2db...9af69fa7e7b7
04:51 < GitHub131> bitcoin/master c5825d2 Denis Lukianov: Correct importaddress help reference to importpubkey
04:51 < GitHub131> bitcoin/master 9af69fa Wladimir J. van der Laan: Merge #7726: Correct importaddress help reference to importpubkey...
04:52 < GitHub194> [bitcoin] laanwj closed pull request #7726: Correct importaddress help reference to importpubkey (master...master) https://github.com/bitcoin/bitcoin/pull/7726
05:13 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
05:18 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
05:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
05:35 -!- MrHodl [~fuc@91.210.105.101] has joined #bitcoin-core-dev
05:37 -!- jajc [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has quit [Ping timeout: 252 seconds]
05:41 < GitHub99> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/9af69fa7e7b7...29b2be6ad789
05:41 < GitHub99> bitcoin/master bbb9d1d BtcDrak: Remove p2p alert handling
05:41 < GitHub99> bitcoin/master 9206634 BtcDrak: Update alert notification and GUI
05:41 < GitHub99> bitcoin/master 01fdfef BtcDrak: Remove `-alerts` option
05:41 < GitHub62> [bitcoin] laanwj closed pull request #7692: Remove p2p alert system (master...remove_alert) https://github.com/bitcoin/bitcoin/pull/7692
05:48 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
05:56 -!- cjcj [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has joined #bitcoin-core-dev
06:00 < sipa> wumpus: i was thinking of writing an alert replacement based on theymos's proposal, using schnorr multisig once that's stable in libsecp256k1 (that would allow the entire message, including signature(s), to fit in an op_return)
06:00 < wumpus> sipa: sgtm
06:35 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
06:36 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
06:42 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
06:51 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
06:54 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
06:55 < GitHub114> [bitcoin] jtimon opened pull request #7727: Travis test (not to merge): Introduce silent bug in CFeeRate (master...0.12.99-feerate-test-bug) https://github.com/bitcoin/bitcoin/pull/7727
06:57 -!- jtimon [~quassel@227.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
07:21 -!- madu [~madu@89-64-212-2.dynamic.chello.pl] has quit [Ping timeout: 250 seconds]
07:31 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev
07:31 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host]
07:31 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
07:41 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
07:54 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
07:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
07:58 -!- go1111111 [~go1111111@104.200.154.101] has quit [Ping timeout: 248 seconds]
07:58 -!- jarret [~jarret@162.216.46.119] has quit [Ping timeout: 260 seconds]
08:06 -!- jarret [~jarret@162.216.46.119] has joined #bitcoin-core-dev
08:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
08:20 < morcos> Luke-Jr and any one else: I'd like to improve fee estimation for 0.13.  I think it'll be a lot easier if I can start from cleaner code by ripping out priority estimation.  I believe no one cares much about that?
08:20 < morcos> It looks to me like you don't get a valid priority estimate until 66 blocks (hacked up with longer block estimates)
08:21 < morcos> So the effect of the priority estimation cdoe now is to do basically only 1 thing, not let you send a free transaction if your mempool is limited, otherwise it gets an answer of -1 for priority estimation and defaults to AllowFree
08:22 -!- G1lius [~stefangil@94.242.243.252] has joined #bitcoin-core-dev
08:24 < morcos> That seems like pretty bad behavior, but its also only available from a debug option now anyway after #7686
08:24 < morcos> Are there any objections to removing priority estimation?
08:27 -!- pigeons_ is now known as pigeons
08:29 -!- B4ckJ4ck007 [~ipalyi@213.4.200.211] has quit [Quit: B4ckJ4ck007]
08:31 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:41 -!- drumf [~fdrumf@50.248.81.65] has quit [Quit: Leaving]
08:42 < GitHub50> [bitcoin] jtimon opened pull request #7728: Fees: Tests: Check CFeeRate internal precision in mempool_tests.cpp (master...0.12.99-feerate-precision-test) https://github.com/bitcoin/bitcoin/pull/7728
08:46 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
08:47 -!- viderizer2 [~viderizer@qux.fi] has quit [Quit: WeeChat 1.4-rc2]
08:55 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
09:00 -!- zooko [~user@70-91-193-41-BusName-NewEngland.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:02 < GitHub184> [bitcoin] laanwj opened pull request #7729: rpc: introduce 'label' API for wallet (master...2016_03_wallet_label_api) https://github.com/bitcoin/bitcoin/pull/7729
09:07 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
09:20 -!- zooko [~user@70-91-193-41-BusName-NewEngland.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds]
09:45 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt]
09:50 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
10:03 < GitHub174> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/29b2be6ad789...c946a15075ba
10:03 < GitHub174> bitcoin/master 9e072a6 Alex Morcos: Implement "feefilter" P2P message....
10:03 < GitHub174> bitcoin/master 5fa66e4 Alex Morcos: Create SingleNodeConnCB class for RPC tests
10:03 < GitHub174> bitcoin/master b536a6f Alex Morcos: Add p2p test for feefilter
10:03 < GitHub196> [bitcoin] laanwj closed pull request #7542: Implement "feefilter" P2P message (master...feefilter) https://github.com/bitcoin/bitcoin/pull/7542
10:03 < GitHub37> [bitcoin] jtimon closed pull request #7727: Travis test (not to merge): Introduce silent bug in CFeeRate (master...0.12.99-feerate-test-bug) https://github.com/bitcoin/bitcoin/pull/7727
10:04 < sipa> morcos: agree on removing the estimation
10:04 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
10:04 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
10:10 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Ping timeout: 276 seconds]
10:12 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
10:16 < morcos> wumpus: i think you accidentally applied the feefilter to github's web server.  
10:17 < wumpus> it will only accept http requests with enough fee now?
10:18 < morcos> apparently
10:18 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-lxexebqbrnrtpvjr] has quit [Ping timeout: 260 seconds]
10:18 < wumpus> angry unicorn: 402 Payment Required 
10:33 -!- btcdrak [uid115429@gateway/web/irccloud.com/x-piaiavzxuegqlcli] has joined #bitcoin-core-dev
10:34 -!- heath__ is now known as heath
10:35 < GitHub169> [bitcoin] morcos opened pull request #7730: Remove priority estimation (master...removePriEst) https://github.com/bitcoin/bitcoin/pull/7730
10:56 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
10:56 -!- go1111111 [~go1111111@104.232.116.217] has joined #bitcoin-core-dev
10:57 -!- MrHodl [~fuc@91.210.105.101] has quit []
11:06 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
11:38 -!- evoskuil [~evoskuil@c-73-225-134-208.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
11:59 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
12:01 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
12:11 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
12:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
12:33 < GitHub31> [bitcoin] jtimon opened pull request #7731: Discussion: By "more precision", I don't mean using rational numbers in CFeeRate (master...0.12.99-feerate) https://github.com/bitcoin/bitcoin/pull/7731
12:33 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
12:34 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
12:36 < jtimon> morcos: wumpus: MarcoFalke this is what I meant the other day, I'm sorry it took me days to have something that could potentially make some sense: https://github.com/bitcoin/bitcoin/pull/7731
12:38 -!- madu [~madu@89-64-212-2.dynamic.chello.pl] has joined #bitcoin-core-dev
12:45 < jtimon> could we need more precision in practice in the foreseable future? it is the first time that I consider this from the "we may actually need this at some point" and not just purely from "reusable style is generally better unless tradeoffs" standpoint
12:48 < jtimon> anyway, just food for thought (and 1 test I wasn't expecting), should go do some actual work, this was too much of a distraction
13:06 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
13:19 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
13:35 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:37 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
13:38 -!- Guyver2_ is now known as Guyver2
14:07 -!- Don_John [~Don@250-223-114-134.nat.resnet.nau.edu] has joined #bitcoin-core-dev
14:11 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
14:25 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
14:45 -!- murch [~murch@p4FE3B602.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
15:03 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
15:12 -!- madu [~madu@89-64-212-2.dynamic.chello.pl] has quit [Quit: Leaving.]
15:15 -!- lahwran [~lahwran@python/site-packages/lahwran] has quit [Ping timeout: 260 seconds]
15:16 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
15:16 -!- lahwran [~lahwran@python/site-packages/lahwran] has joined #bitcoin-core-dev
15:21 -!- lahwran [~lahwran@python/site-packages/lahwran] has quit [Ping timeout: 240 seconds]
15:24 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
15:34 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
15:35 < BlueMatt> wumpus: will do
15:38 -!- G1lius [~stefangil@94.242.243.252] has quit [Read error: Connection reset by peer]
16:13 -!- gevs [~greg@unaffiliated/gevs] has quit [Remote host closed the connection]
17:14 -!- BCB [4241870d@gateway/web/freenode/ip.66.65.135.13] has joined #bitcoin-core-dev
17:17 -!- murch [~murch@p4FE3B602.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
17:33 < Chris_Stewart_5> I have a question about BIP66 and this test case inside of script_valid.json 
17:33 < Chris_Stewart_5> [
17:33 < Chris_Stewart_5>     "1",
17:33 < Chris_Stewart_5>     "0x21 0x038282263212c609d9ea2a6e3e172de238d8c39cabd5ac1ca10646e23fd5f51508 CHECKSIG NOT",
17:33 < Chris_Stewart_5>     "",
17:34 < Chris_Stewart_5>     "BIP66 example 6, without DERSIG"
17:34 < Chris_Stewart_5> ]
17:34 < Chris_Stewart_5> BIP66 says that "if the signature does not pass the IsValidSignatureEncoding check below, the entire script evaluates to false immediately."
17:34 -!- go1111111 [~go1111111@104.232.116.217] has quit [Ping timeout: 244 seconds]
17:35 < Chris_Stewart_5> why would this script evaluate to true? Wouldn't it fail immediately after seeing "1" since it is not DER compliant
17:35 < Chris_Stewart_5> shouldn't it just fail immediately
17:35 < Chris_Stewart_5> ?
17:37 < gmaxwell> Chris_Stewart_5: I assume because it is not run with the DERSIG flag. (as is the case for most of the blocks in the chain)
17:39 -!- fengling [~fengling@111.198.29.53] has joined #bitcoin-core-dev
17:40 < Chris_Stewart_5> gmaxwell: So after BIP66 this would fail, pre BIP66 this would pass, correct?
17:40 < Chris_Stewart_5> and this is indicated with the flags
17:48 -!- go1111111 [~go1111111@104.200.154.106] has joined #bitcoin-core-dev
17:56 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev
17:57 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Client Quit]
18:18 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
18:21 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-btbypynbpgpggzlx] has quit [Quit: Connection closed for inactivity]
18:29 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
18:45 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
18:47 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
18:55 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
18:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
19:13 -!- roasbeef_ is now known as roasbeef
19:27 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev
19:37 -!- mkarrer [~mkarrer@224.Red-83-50-56.dynamicIP.rima-tde.net] has quit [Read error: Connection reset by peer]
19:38 -!- mkarrer [~mkarrer@224.Red-83-50-56.dynamicIP.rima-tde.net] has joined #bitcoin-core-dev
19:38 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:39 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
19:43 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:44 -!- BCB [4241870d@gateway/web/freenode/ip.66.65.135.13] has quit [Ping timeout: 252 seconds]
19:44 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
19:47 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev
19:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
19:49 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit [Ping timeout: 264 seconds]
19:49 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:50 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
19:55 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
19:55 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:55 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
19:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
19:56 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:57 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
19:58 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:58 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
20:02 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving]
20:06 -!- zooko [~user@65.118.40.231] has joined #bitcoin-core-dev
20:12 -!- zooko [~user@65.118.40.231] has quit [Ping timeout: 240 seconds]
20:33 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer]
20:46 -!- jannes [~jannes@178.132.211.90] has quit [Read error: Connection reset by peer]
21:08 -!- mrkent [~textual@unaffiliated/mrkent] has quit []
21:08 < phantomcircuit> do i need a lock for Params() ?
21:14 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
21:18 < sipa> i'd say no
21:21 -!- challisto [~challisto@unaffiliated/challisto] has quit [Quit: Leaving]
21:29 -!- PaulCape_ [~PaulCapes@204.28.124.82] has quit [Quit: .]
21:30 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
21:55 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
22:46 < phantomcircuit> sipa: what about CBlockIndex objects? I would assume yes but that they remain valid between lock acquisitions
22:47 < phantomcircuit> (i mean pointers)
22:59 < sipa> phantomcircuit: some fields are immutable
23:00 -!- dermoth [~thomas@175-79.162.dsl.aei.ca] has quit [Read error: Connection reset by peer]
23:00 < sipa> if you take a CBlockIndex object from mapBlockIndex, its CBlockHeader fields, chainWork, pprev, ... are immutable
23:00 < sipa> so you can use GetAncestor without lock
23:00 -!- dermoth [~thomas@175-79.162.dsl.aei.ca] has joined #bitcoin-core-dev
23:01 < sipa> nStatus, nFile, nBlockPos, nUndoPos, ... are mutable and need cs_main
23:05 < phantomcircuit> sipa: just interested in whether a CBlockIndex pointed from mapBlockIndex will continue to work when passed to chainActive.Next
23:11 < sipa> phantomcircuit: yes, it will
23:11 < sipa> pointers to CBlockIndex remain vlaid forever
23:12 < sipa> chainActive.Next will return NULL if the passed CBlockIndex is no longer in the main chaim
23:19 -!- dermoth_ [~thomas@dsl-216-221-53-213.mtl.contact.net] has joined #bitcoin-core-dev
23:19 -!- dermoth [~thomas@175-79.162.dsl.aei.ca] has quit [Disconnected by services]
23:19 -!- dermoth_ is now known as dermoth
23:20 -!- baldur [~baldur@pool-72-69-12-130.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
23:20 -!- baldur [~baldur@pool-72-69-12-130.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
23:35 -!- jtimon [~quassel@227.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds]
23:40 -!- Thireus1 [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev
23:42 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Ping timeout: 276 seconds]
23:44 < sipa> phantomcircuit: i'm wrong
23:44 < sipa> chainActive itself needs cs_main
23:44 < sipa> though the CBlockIndex pointer do remain valid across different lockings
23:45 < sipa> which may be enough