--- Day changed Tue Apr 05 2016 00:01 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 00:14 < jonasschnelli> gmaxwell: Nice! Will try to fully understand it now... 00:22 -!- chris2000 [~chris2000@p5082AA2F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:36 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 00:44 < GitHub111> [bitcoin] paveljanik opened pull request #7810: Refactor AlertNotifyOnce out of UpdateTip (master...20160405_AlertNotifyOnce) https://github.com/bitcoin/bitcoin/pull/7810 00:55 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 00:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 00:59 -!- lejitz [~lejitz@cpe-72-181-158-116.tx.res.rr.com] has joined #bitcoin-core-dev 01:02 -!- lejitz [~lejitz@cpe-72-181-158-116.tx.res.rr.com] has quit [Client Quit] 01:09 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 240 seconds] 01:11 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 01:11 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev 01:29 < jonasschnelli> This looks ready: https://github.com/bitcoin/bitcoin/pull/7753 01:40 -!- abritoid [~abritoid@46.16.193.99] has joined #bitcoin-core-dev 01:46 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:50 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev 01:56 < StringerBell> ok it's killing me. How does that github bot work? 01:58 < jonasschnelli> StringerBell: Its publishing created/closed/merged PRs issues? 01:58 * jonasschnelli thinks GitHub is extraslow today. 01:59 < StringerBell> I mean it is a user but it's not connected to the channel 01:59 < StringerBell> Don't mean to get off topic but never seen that before. 01:59 < Luke-Jr> StringerBell: the channel is not +n which restricts sending to members 01:59 < sipa> StringerBell: be default you can send messages to a channel without being joined 02:00 < StringerBell> oh lol ok 02:00 < Luke-Jr> IRC isn't designed to be "rooms" as much as it is pub/sub IM ;) 02:00 < Luke-Jr> so JOIN = subscribe, and PRIVMSG = publish 02:01 < StringerBell> ah 02:05 < btcdrak> It can be set to authorise, join, mag and leave but then it is a lot more messages 02:05 < btcdrak> It is a github commit hook 02:05 < Luke-Jr> not like anyone abuses the -n 02:38 < wumpus> yes the side is a tad slow 02:38 < wumpus> site* 02:38 -!- lejitz [~lejitz@cpe-72-181-158-116.tx.res.rr.com] has joined #bitcoin-core-dev 02:39 -!- wallet42 [uid154231@gateway/web/irccloud.com/x-lndjowlgfnvcxsdz] has quit [Quit: Connection closed for inactivity] 02:43 -!- lejitz [~lejitz@cpe-72-181-158-116.tx.res.rr.com] has quit [Client Quit] 02:49 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has joined #bitcoin-core-dev 02:49 -!- AaronvanW [~ewout@172pc231.sshunet.nl] has quit [Changing host] 02:49 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:59 < GitHub37> [bitcoin] MarcoFalke opened pull request #7811: [0.12.2] qa Backports (0.12...Mf1604-qa012) https://github.com/bitcoin/bitcoin/pull/7811 03:09 -!- murch [~murch@p4FE39993.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 03:18 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 260 seconds] 03:18 -!- fengling [~fengling@111.198.29.53] has quit [Quit: WeeChat 1.4] 03:19 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev 03:30 -!- gevs [~greg@ip-81-11-204-86.dsl.scarlet.be] has joined #bitcoin-core-dev 03:30 -!- gevs [~greg@ip-81-11-204-86.dsl.scarlet.be] has quit [Changing host] 03:30 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 03:35 -!- xabbix [~xabbix@unaffiliated/xabbix] has quit [Ping timeout: 248 seconds] 03:36 -!- xabbix [~xabbix@unaffiliated/xabbix] has joined #bitcoin-core-dev 03:44 -!- gevs [~greg@unaffiliated/gevs] has quit [Remote host closed the connection] 03:44 -!- chris2000 [~chris2000@p5082AA2F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 03:46 -!- gevs [~greg@ip-81-11-204-86.dsl.scarlet.be] has joined #bitcoin-core-dev 03:46 -!- gevs [~greg@ip-81-11-204-86.dsl.scarlet.be] has quit [Changing host] 03:46 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 04:06 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:07 -!- Luke-Jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 04:26 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 260 seconds] 04:32 < btcdrak> Last week's meeting summary: https://bitcoincore.org/en/meetings/2016/03/31/ 04:34 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:35 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 04:38 -!- cryptapus_ is now known as cryptapus 04:38 < btcdrak> wumpus: can you try an experiment for me please, by kicking slackircbridge 04:40 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 04:40 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 04:51 < sipa> hmm, when i regenerate the script_tests, i get lines like: 04:51 < sipa> [ 04:51 < sipa> ... 04:51 < sipa> ], 04:51 < sipa> instead of: 04:51 < sipa> [ 04:51 < sipa> ... 04:51 < sipa> ], 04:51 < sipa> wumpus: you touched that code last 04:52 -!- mode/#bitcoin-core-dev [+o sipa] by ChanServ 04:52 -!- slackircbridge was kicked from #bitcoin-core-dev by sipa [btcdrak does not like you] 04:52 <@sipa> btcdrak: done 04:52 -!- mode/#bitcoin-core-dev [-o sipa] by ChanServ 04:52 < btcdrak> sipa thanks 04:57 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 04:57 < btcdrak> sipa: thanks. one last time please boot him again. 04:58 -!- slackircbridge [~slackircb@45.55.41.36] has quit [Remote host closed the connection] 04:58 < jonasschnelli> ping sdaftuar 04:59 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 04:59 < sipa> btcdrak: you've got op 04:59 < jonasschnelli> Or anyone else... check https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR85 I think this is wrong. 04:59 < jonasschnelli> (Already merged) 05:00 < jonasschnelli> If a tx is not in the mempool and signal rbf, we can't be sure if it's rbfable. 05:00 < jonasschnelli> *signals 05:01 < sipa> why not? 05:03 < jonasschnelli> sipa: ancestors? 05:04 < jonasschnelli> sipa: I think this check is more appropriate: https://github.com/bitcoin/bitcoin/pull/7222/files#diff-d0eca4d0f80c5b045d2aa64609e811ecR28? 05:05 < jonasschnelli> Because a unconfirmed input could signal RBF? 05:06 -!- mode/#bitcoin-core-dev [+o btcdrak] by ChanServ 05:06 -!- slackircbridge was kicked from #bitcoin-core-dev by btcdrak [testing rejoin] 05:07 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 05:08 -!- slackircbridge was kicked from #bitcoin-core-dev by btcdrak [remember false != true] 05:08 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 05:10 -!- mode/#bitcoin-core-dev [-o btcdrak] by ChanServ 05:17 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has left #bitcoin-core-dev [] 05:23 -!- SteveTaylor [~textual@cpe-72-181-158-116.tx.res.rr.com] has joined #bitcoin-core-dev 05:24 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 05:25 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 05:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:29 < sipa> jonasschnelli: i think it's correct 05:29 < jonasschnelli> sipa: Yes. Me2! 05:29 < sipa> if it signals rbf by itself, it should be yes; if it doesn't, it's unknown 05:29 < sipa> and IsRBFOptIn can't be called for things not in the mempool 05:29 < jonasschnelli> I overlooked https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR85 05:29 < jonasschnelli> if (!mempool.exists(hash)) { 05:30 < jonasschnelli> The "unknown" https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR89 is not 100% true. 05:30 < jonasschnelli> But "unknown" from the local peer perspective is right. 05:30 < sipa> what other perspective is there? 05:31 < jonasschnelli> We could miss a ancestor/input in the mempool that has a final nSequence and therefore the transaction would _not_ be replaceable. 05:33 < jonasschnelli> But however, I think its correct. Yes. 05:33 < jonasschnelli> But doing a tiny refactor (before I extend it to the GUI) 05:34 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 05:40 < sipa> jonasschnelli, wumpus: i don't understand the univalue json pretty printer 05:40 < jonasschnelli> write(2) 05:40 < jonasschnelli> sipa: what is unclear? 05:41 < sipa> it puts spaces between comma's and the end of a line 05:41 < jonasschnelli> sipa: yes. You need to ask jeff. :) Or fix it. 05:41 < jonasschnelli> sipa: Are you referring to your script_tests issue above? 05:42 < sipa> yes 05:43 < GitHub178> [bitcoin] jonasschnelli opened pull request #7812: Tiny refactor of `IsRBFOptIn`, avoid exception (master...2016/04/rbf_refact) https://github.com/bitcoin/bitcoin/pull/7812 05:44 < jonasschnelli> sipa: https://github.com/bitcoin/univalue/blob/master/lib/univalue_write.cpp#L79 05:44 < sdaftuar> jonasschnelli: pong. happy to review any refactors of that code... 05:44 -!- dermoth [~thomas@dsl-216-221-56-157.mtl.aei.ca] has joined #bitcoin-core-dev 05:45 < jonasschnelli> sdaftuar: Thanks. Not sure if it makes sense. I think the code is fine. Its just the exception that kinda disturbs me. 05:45 < jonasschnelli> sipa: https://github.com/bitcoin/univalue/blob/master/lib/univalue_write.cpp#L100 05:45 < jonasschnelli> sipa: it misses a newline before L100 05:46 < jonasschnelli> no wait... 05:46 < sipa> jonasschnelli: it's complicated; i'm writing a workaround for now 05:46 < jonasschnelli> L98-99 is wrong. 05:46 < jonasschnelli> I'll fix it. 05:47 < sipa> please add tests for the pretty printer, i think it's very easy to break 05:47 < jonasschnelli> sipa: yes. 05:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:49 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds] 05:51 -!- jannes [~jannes@178.132.211.90] has quit [Read error: Connection reset by peer] 05:54 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 05:57 < GitHub91> [bitcoin] MarcoFalke opened pull request #7813: [doc] Update port in tor.md (master...Mf1604-docTor) https://github.com/bitcoin/bitcoin/pull/7813 05:58 -!- jtimon [~quassel@227.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:00 < GitHub153> [bitcoin] MarcoFalke opened pull request #7814: [qa] Switch to py3 (master...Mf1604-qaPy3) https://github.com/bitcoin/bitcoin/pull/7814 06:08 < jonasschnelli> sipa: script_tests.cpp uses "write(1,4)" (which means 1 whitespace indent, start at level 4). 06:08 < jonasschnelli> But there is a bug at the opening "[" (not the closing) 06:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 06:12 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 06:12 -!- Cheeseo [~x@c-71-58-178-138.hsd1.pa.comcast.net] has quit [Changing host] 06:12 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 06:16 -!- gavinandresen [~gavin@unaffiliated/gavinandresen] has joined #bitcoin-core-dev 06:17 -!- cfields_ [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev 06:21 < GitHub79> [bitcoin] laanwj opened pull request #7815: Break circular dependency main ↔ txdb (master...2016_04_break_txdb_main_dep) https://github.com/bitcoin/bitcoin/pull/7815 06:21 < jonasschnelli> sipa: The pretty print is okay. It's the script_tests.cpp 06:22 -!- Netsplit *.net <-> *.split quits: mesmer_, michagogo, Guest27562, p15, mturquette, lightningbot, nsh, Taek, sipa, cheese_, (+5 more, use /NETSPLIT to show all of them) 06:23 < wumpus> btcdrak: still want me to kick slackircbridge? 06:23 -!- Netsplit over, joins: mesmer_ 06:23 < jonasschnelli> sipa: The pretty print is okay. It's the script_tests.cpp 06:23 < jonasschnelli> (sry) 06:23 < kinlo> is there a slackircbridge? 06:24 -!- Netsplit over, joins: p15, lightningbot, Taek, NicolasDorier, sipa, jron, nsh, lysobit, michagogo, mturquette (+1 more) 06:24 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L667 should be write(1) 06:24 -!- michagogo [uid14316@wikia/Michagogo] has quit [Max SendQ exceeded] 06:26 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:26 < wumpus> sipa: jonasschnelli: yes I had some problems generating the tests as well last time 06:26 < jl2012> sorry for OT. OP_VERIF is invalid even when occuring in an unexecuted OP_IF branch. Where this rule is defined in the code? 06:27 < wumpus> I added the pretty printing because it ended up all on one line 06:27 < wumpus> I don't think this was tested after introducing univalue 06:27 < jonasschnelli> wumpus: the issue is here: https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L667 06:28 < jonasschnelli> you add a root level on level 4 06:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:28 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 06:28 < wumpus> ok 06:28 < jonasschnelli> I guess if i change this i need to update all static test data. 06:28 < wumpus> apparently I didn't really know what pretty print arguments to use 06:28 < jonasschnelli> heh. Yes. I was also not sure. 06:28 < wumpus> no, I don't think you need to do that 06:29 < wumpus> I probably fixed the excessive indent by hand last time 06:29 < sipa> wumpus: i'm making some changes, and fixing it 06:30 < jonasschnelli> sipa: thanks! 06:30 < wumpus> this was less work than manually formatting the json from everything on one line 06:30 < wumpus> but stil not ideal no 06:30 < wumpus> sipa: ok great! 06:30 * jonasschnelli is heading back to GUI RBF 06:30 < sipa> wumpus: any objections to merging the valid and invalid script tests into one file? 06:31 < sipa> it's annoying for generating, and makes the tests less clear 06:31 < wumpus> sipa: I haven't; though you could consider it an interface change, as it's used by other projects 06:31 < jonasschnelli> sipa: I think you should use write(1) (1 whitespace ident) and only use write(1, X) if you want to insert a sublevel at level x 06:31 < wumpus> and it makes it harder to backport/forward-port tests 06:31 < wumpus> so I'm not sure 06:31 < wumpus> I did consider the same at some point 06:32 < sipa> wumpus: well, i'm working on segwit tests, and i have no intention of manually writing everything for both master and backports 06:32 < sipa> so that would also mean backporting that merging 06:32 < btcdrak> wumpus: no thanks! 06:32 < wumpus> okay 06:32 < btcdrak> kinlo: yes, it's only one way though, so you can read on the Bitcoin Core Slack 06:33 < kinlo> as long as this is the only official channel and we don't actually use slack it's all ok 06:34 < sipa> wumpus: and for segwit, an interface change is inevitable, as we'll need to add a witness field 06:34 < wumpus> sipa: I agree 06:34 < wumpus> sipa: that's a good excuse, go ahead :) 06:35 < wumpus> kinlo: I'm not sure how happy I really am about it. I mean, in principe everything here is public, but on the other hand non-technical people will put everything under a magnifying glass and are bound to misinterpret things 06:35 < btcdrak> wumpus: no thanks! 06:36 < wumpus> this happened before a while ago though i don't remember the specific instance, oh yeah some commit that bumped the version to 0.12.1 on the 0.12 branch was misinterpreted as '0.12.1 tagged!' 06:38 -!- cryptapus__ [~cyptapus@87.254.202.204] has joined #bitcoin-core-dev 06:38 -!- cryptapus__ [~cyptapus@87.254.202.204] has quit [Changing host] 06:38 -!- cryptapus__ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:40 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Read error: Connection reset by peer] 06:40 < GitHub15> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a9149688f87c...214ec0b5e8b2 06:40 < GitHub15> bitcoin/master 3373c43 Adam Brown: [doc] Update port in tor.md... 06:40 < GitHub15> bitcoin/master 214ec0b Wladimir J. van der Laan: Merge #7813: [doc] Update port in tor.md... 06:40 -!- cryptapus__ is now known as cryptapus 06:40 < GitHub21> [bitcoin] laanwj closed pull request #7813: [doc] Update port in tor.md (master...Mf1604-docTor) https://github.com/bitcoin/bitcoin/pull/7813 06:41 < GitHub48> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/214ec0b5e8b2...55db5f07b1c4 06:41 < GitHub48> bitcoin/master 10d3ae1 Wladimir J. van der Laan: devtools: Auto-set branch to merge to in github-merge... 06:41 < GitHub48> bitcoin/master 55db5f0 Wladimir J. van der Laan: Merge #7781: devtools: Auto-set branch to merge to in github-merge... 06:42 < GitHub91> [bitcoin] laanwj closed pull request #7781: devtools: Auto-set branch to merge to in github-merge (master...2016_04_github_merge_autobranch) https://github.com/bitcoin/bitcoin/pull/7781 06:43 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 06:45 < GitHub129> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55db5f07b1c4...3cc0fb3a23e5 06:45 < GitHub129> bitcoin/master f063863 Wladimir J. van der Laan: build: Remove unnecessary executables from gitian release... 06:45 < GitHub129> bitcoin/master 3cc0fb3 Wladimir J. van der Laan: Merge #7776: build: Remove unnecessary executables from gitian release... 06:45 < GitHub28> [bitcoin] laanwj closed pull request #7776: build: Remove unnecessary executables from gitian release (master...2016_03_gitian_release_cleanup) https://github.com/bitcoin/bitcoin/pull/7776 06:46 < GitHub41> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/a784675a329d6206af125d997381221dd1e99d11 06:46 < GitHub41> bitcoin/0.12 a784675 Wladimir J. van der Laan: build: Remove unnecessary executables from gitian release... 06:47 -!- crescendo [~mozart@unaffiliated/crescendo] has quit [Ping timeout: 244 seconds] 06:48 -!- crescendo [~mozart@unaffiliated/crescendo] has joined #bitcoin-core-dev 06:51 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds] 06:56 < jl2012> re OP_VERIF I think I find the answer at https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L295 06:57 < GitHub158> [bitcoin] jonasschnelli opened pull request #7816: [Wallet] slighly refactor GetOldestKeyPoolTime() (master...2016/04/wallet_oldest_key) https://github.com/bitcoin/bitcoin/pull/7816 07:08 < btcdrak> wumpus: kinlo: the slackbridge has been in operation for a few months already 07:09 < btcdrak> I was just setting the rejoin flag 07:09 < GitHub91> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cc0fb3a23e5...916b15a87a1f 07:09 < GitHub91> bitcoin/master 92107d5 mruddy: RPC: add versionHex in getblock and getblockheader JSON results; expand data in getblockchaininfo bip9_softforks field. 07:09 < GitHub91> bitcoin/master 916b15a Wladimir J. van der Laan: Merge #7774: RPC: add versionHex in getblock and getblockheader JSON results... 07:09 < GitHub102> [bitcoin] laanwj closed pull request #7774: RPC: add versionHex in getblock and getblockheader JSON results (master...hexver) https://github.com/bitcoin/bitcoin/pull/7774 07:14 < wumpus> btcdrak: okay 07:14 < GitHub49> [bitcoin] jonasschnelli opened pull request #7817: [Qt] attribute replaceable (RBF) transactions (master...2016/04/qt_rbf) https://github.com/bitcoin/bitcoin/pull/7817 07:16 < btcdrak> wumpus: do we need to do a hard coded seeds update for 0.12.1? 07:16 < wumpus> I only do that for major releases 07:17 < GitHub175> [bitcoin] sipa opened pull request #7818: Refactor script tests (master...refactorscriptests) https://github.com/bitcoin/bitcoin/pull/7818 07:17 < wumpus> should update the translation strings though 07:21 < GitHub48> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/916b15a87a1f...e30a5b0aaaa9 07:21 < GitHub48> bitcoin/master 190c1e2 JeremyRand: Doc: change Precise to Trusty in gitian-building.md... 07:21 < GitHub48> bitcoin/master e30a5b0 Wladimir J. van der Laan: Merge #7791: Doc: change Precise to Trusty in gitian-building.md... 07:21 < GitHub42> [bitcoin] laanwj closed pull request #7791: Doc: change Precise to Trusty in gitian-building.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7791 08:06 < Chris_Stewart_5> I'm looking at this test case from script_invalid.json inside of bitcoin core, shouldn't this have a MINIMALDATA flag? 08:06 < Chris_Stewart_5> ["0x4c01","0x01 NOP", "P2SH,STRICTENC", "PUSHDATA1 with not enough bytes"] 08:12 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 08:15 < GitHub68> [bitcoin] jonasschnelli opened pull request #7819: [Qt] Simple opt-in-RBF checkbox (master...2016/04/qt_rbf_set) https://github.com/bitcoin/bitcoin/pull/7819 08:17 -!- zooko [~user@50.141.117.112] has joined #bitcoin-core-dev 08:18 < sipa> Chris_Stewart_5: the test should fail even without minimaldata rule 08:19 < sipa> Chris_Stewart_5: as it's trying to push a 1-byte value which is past the end of scriptSig 08:23 -!- abritoid [~abritoid@46.16.193.99] has quit [Ping timeout: 246 seconds] 08:39 < GitHub31> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e30a5b0aaaa9...4dc1b3a29693 08:39 < GitHub31> bitcoin/master 0087f26 Pavel Janík: Use relative paths instead of absolute paths 08:39 < GitHub31> bitcoin/master 4dc1b3a Wladimir J. van der Laan: Merge #7788: Use relative paths instead of absolute paths in protoc calls... 08:39 < GitHub118> [bitcoin] laanwj closed pull request #7788: Use relative paths instead of absolute paths in protoc calls (master...20160402_protoc_use_relpath) https://github.com/bitcoin/bitcoin/pull/7788 08:40 < Chris_Stewart_5> sipa: interesting. I didn't realize that limitation was there. I thought you think of the scriptSig & scriptPubKey as one big concatenated list when you were running it through the interpreter. 08:41 < sipa> Chris_Stewart_5: yes 08:41 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:41 < sipa> Chris_Stewart_5: but the scriptSig here contains an opcode that says "The next 1 byte is to be pushed: ", and then no more bytes 08:41 < sipa> which is obviously invalid 08:42 < sipa> it's like an unterminated quotation mark, or a missing endif 08:45 < sipa> Chris_Stewart_5: typically you want negative tests that specify the weakest condition under which failure is expected 08:48 < Chris_Stewart_5> sipa: If it was evaluated at as one big concatenated list though the next byte could be in the scriptPubKey. Where does the validation fail in bitcoin core? 08:48 < Chris_Stewart_5> is it this line? https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L294 08:49 < sipa> Chris_Stewart_5: that changed in early 2010 08:49 < sipa> Chris_Stewart_5: scriptPubKey and scriptSig are evaluated separately 08:49 < Chris_Stewart_5> haha just realized that :-) 08:49 < Chris_Stewart_5> stack state is shared between the two, is there a reason this is done? Is it one of those things "Its always been done this way so we are going to keep doing it that way" or is there more reason to it 08:50 < GitHub120> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4dc1b3a29693...1b2460bd5824 08:50 < GitHub120> bitcoin/master fada0c4 MarcoFalke: [doc] Fix doxygen comments for members 08:50 < GitHub120> bitcoin/master 1b2460b Wladimir J. van der Laan: Merge #7793: [doxygen] Fix member comments... 08:50 < GitHub171> [bitcoin] laanwj closed pull request #7793: [doxygen] Fix member comments (master...Mf1604-doxygenMembers) https://github.com/bitcoin/bitcoin/pull/7793 08:51 < sipa> Chris_Stewart_5: that's how the scriptSig communicates its resulting stack to the scriptPubKey 08:51 < sipa> Chris_Stewart_5: what alternative would you suggest? 08:52 < Chris_Stewart_5> concatenate the scriptSig ++ scriptPubKey together and run the entire thing through the interpreter instead of mamking two calls to EvalScript and maintaing stack state 08:53 < sipa> that's how Bitcoin was in 2009, and it had massive security risks 08:53 < sipa> as the scriptSig is under control of the attacker 08:54 < sipa> say your scriptPubKey is 47 bytes, you'd just make a scriptSig 0x3F (which means "push the next 47 bytes onto the stack"), and the result would be accepted 08:54 < sipa> as it would treat the whole scriptPubKey that's concatenated after it as data being pushed, rather than code 08:54 < instagibbs> sipa, ok now that section of code makes sense 08:56 < Chris_Stewart_5> sipa: Wow that is a great way to explain it. So basically that would allow the script to trivially succeed since the scriptPubKey != OP_0 || OP_FALSE right? 08:57 < sipa> Chris_Stewart_5: furthermore, changing it back to that model of execution would almost by definition be a hard fork 08:57 < sipa> because if it has any effect at all, it's going to turn invalid things into valid things 08:58 < Chris_Stewart_5> sipa: Ok. Thanks for the explanation. I appreciate it 09:01 < GitHub166> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/c2106543fe017d443c2e50daf3dd1d42e6ec35a2 09:01 < GitHub166> bitcoin/0.12 c210654 Wladimir J. van der Laan: pre-rc1 translations update... 09:08 < GitHub174> [bitcoin] laanwj closed pull request #7654: Add net2 debug option (master...DebugNet2) https://github.com/bitcoin/bitcoin/pull/7654 09:17 < gmaxwell> "errors": "WARNING: check your network connection, 5 blocks received in the last 4 hours (24 expected)" 09:17 < gmaxwell> of course I dunno when that triggered, though I don't think that host has had any network outages. 09:18 < wumpus> that's the one we disabled on 0.12 right? 09:18 < gmaxwell> yep. 09:18 -!- zooko [~user@50.141.117.112] has quit [Ping timeout: 244 seconds] 09:35 -!- cjcj [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has quit [Ping timeout: 250 seconds] 09:51 -!- Don_John [~Don@250-223-114-134.nat.resnet.nau.edu] has joined #bitcoin-core-dev 10:01 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:08 -!- abritoid [~abritoid@84.40.68.253] has joined #bitcoin-core-dev 10:11 -!- cjcj [2e3b026a@gateway/web/freenode/ip.46.59.2.106] has joined #bitcoin-core-dev 10:28 < cfields_> wumpus: have you looked into the spurious (possible) race condition that we're hitting on travis sometimes? I'm going to poke at it now, curious if you have anything to go on 10:29 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 10:29 < MarcoFalke> which one do you mean? 10:30 < cfields_> MarcoFalke: https://github.com/bitcoin/bitcoin/issues/7470 10:30 -!- bsm1175321 is now known as bsm117532 10:30 < cfields_> I've noticed a few of those (or similar) lately 10:31 < MarcoFalke> Ok, this is not travis only. I think some people could "reproduce" those locally 10:31 < MarcoFalke> Note: Please don't retrigger https://github.com/bitcoin/bitcoin/pull/7817 (just reported the issue to travis) 10:31 < cfields_> MarcoFalke: ah nice, you happen to have a repro case handy? 10:32 < MarcoFalke> Unfortunatley not, but didn't someone mention it can happen after some time? 10:33 < cfields_> not sure 10:33 < MarcoFalke> So I was thinking about adding some random sleeps in the test suite and let it run over night 10:37 < cfields_> sure, if there's a race condition caused by arbitrary sleeps, we'd definitely want to know about those 10:52 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has quit [Remote host closed the connection] 10:52 -!- Thireus [~Thireus@vps-92.197.170.217.stwvps.net] has joined #bitcoin-core-dev 10:59 -!- e0_ [~e0@cs10-dhcp127.bu.edu] has quit [Ping timeout: 276 seconds] 11:03 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .] 11:05 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 11:05 -!- Don_John [~Don@250-223-114-134.nat.resnet.nau.edu] has quit [Quit: Later] 11:08 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 11:10 -!- jtimon [~quassel@227.31.134.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 11:13 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:21 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev 11:34 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 240 seconds] 11:42 -!- d_t [~textual@185.69.203.10] has joined #bitcoin-core-dev 11:47 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev 11:57 < paveljanik> GH is a bit slow right now... 11:57 -!- abritoid [~abritoid@84.40.68.253] has quit [Read error: Connection reset by peer] 12:33 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds] 12:41 < GitHub127> [bitcoin] jtimon opened pull request #7820: Consensus: Policy: Move CFeeRate out of consensus module and create CPolicy interface (master...0.12.99-consensus-dust-out) https://github.com/bitcoin/bitcoin/pull/7820 12:45 -!- jtimon [~quassel@227.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 12:53 -!- e0_ [~e0@cs10-dhcp127.bu.edu] has joined #bitcoin-core-dev 12:57 -!- xabbix [~xabbix@unaffiliated/xabbix] has quit [Ping timeout: 244 seconds] 13:02 -!- xabbix [~xabbix@bzq-79-178-52-49.red.bezeqint.net] has joined #bitcoin-core-dev 13:02 -!- xabbix [~xabbix@bzq-79-178-52-49.red.bezeqint.net] has quit [Changing host] 13:02 -!- xabbix [~xabbix@unaffiliated/xabbix] has joined #bitcoin-core-dev 13:03 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: Leaving] 13:03 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 13:13 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 13:21 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 13:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 13:36 -!- MarcoFalke [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Remote host closed the connection] 13:41 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:45 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 13:45 -!- Guyver2_ is now known as Guyver2 13:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:04 -!- d_t [~textual@185.69.203.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:07 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 264 seconds] 14:20 -!- zmanian__ [sid113594@gateway/web/irccloud.com/x-ewsxkjvafvmqgppd] has quit [Ping timeout: 264 seconds] 14:22 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev 14:23 -!- zmanian__ [sid113594@gateway/web/irccloud.com/x-jitgikxosldlemzm] has joined #bitcoin-core-dev 14:45 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 14:45 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer] 14:46 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Disconnected by services] 14:46 -!- Arnavion3 [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 14:46 -!- Arnavion3 is now known as Arnavion 14:48 -!- fkhan_ [weechat@gateway/vpn/mullvad/x-xiqjbqzchbzsxmxc] has quit [Ping timeout: 248 seconds] 14:52 -!- fkhan_ [weechat@gateway/vpn/mullvad/x-tybwsejfjbsbwaca] has joined #bitcoin-core-dev 15:10 -!- frankenmint [~frankenmi@c-76-115-142-189.hsd1.or.comcast.net] has joined #bitcoin-core-dev 15:13 -!- p15 [~p15@131.91.145.64.unassigned.bringover.net] has quit [Ping timeout: 250 seconds] 15:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 15:40 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:57 < sipa> oh, github supports verifying gpg signatures now 15:58 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 16:15 < PRab> sipa: You figure out how to verify your gpg key? I added mine to https://github.com/settings/keys, but its still showing "Unverified". 16:15 < sipa> yeah, works for me: https://github.com/bitcoin/secp256k1/commits/master 16:16 < sipa> does your commit email address match an email address in the key? 16:18 < PRab> sipa: It should. Maybe it doesn't scan old commits. I believe https://github.com/bitcoin/gitian.sigs/commits/master/0.12.0rc5-linux/prab/bitcoin-linux-0.12-build.assert should have been signed with that key. 16:20 < sipa> committer Paul Rabahy 1455405253 -0500 16:20 < sipa> maybe upper/lower case mix? 16:21 < PRab> Looks the same to me. 16:21 < PRab> https://imgur.com/WN1kiEt 16:22 < sipa> PRab: ah, but that email address is not associated with your github account 16:22 < PRab> Ah, got it. 16:23 < PRab> github has it as prabahy@gmail.com 16:23 < PRab> I'll get ahold of github support. 16:27 < sipa> and it works pretty far back: https://github.com/bitcoin/bitcoin/commit/9269d0e96e621a6e02da8074785ac310ce64db73 16:28 < PRab> Hum, I managed to fix my email address (had to go through a temp email because of case insensitivity), but its still not working. 16:30 -!- frankenmint [~frankenmi@c-76-115-142-189.hsd1.or.comcast.net] has quit [Remote host closed the connection] 16:31 -!- frankenmint [~frankenmi@c-76-115-142-189.hsd1.or.comcast.net] has joined #bitcoin-core-dev 16:31 < PRab> Anyway, really cool feature. 16:35 -!- frankenmint [~frankenmi@c-76-115-142-189.hsd1.or.comcast.net] has quit [Ping timeout: 244 seconds] 16:47 -!- wallet42 [uid154231@gateway/web/irccloud.com/x-dfkctkfwpodedaib] has joined #bitcoin-core-dev 16:50 -!- frankenmint [~frankenmi@c-76-115-142-189.hsd1.or.comcast.net] has joined #bitcoin-core-dev 17:05 -!- aureianimus [~quassel@s55963df3.adsl.online.nl] has quit [Ping timeout: 240 seconds] 17:09 < Luke-Jr> now git just needs to allow signatures after-the-commit 17:19 -!- aureianimus [~quassel@s55963df3.adsl.online.nl] has joined #bitcoin-core-dev 17:42 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has joined #bitcoin-core-dev 17:43 -!- frankenmint [~frankenmi@c-76-115-142-189.hsd1.or.comcast.net] has quit [Remote host closed the connection] 17:48 -!- laurentmt [~Thunderbi@128-79-141-196.hfc.dyn.abo.bbox.fr] has quit [Quit: laurentmt] 18:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vpohxsuqdskqbace] has quit [Quit: Connection closed for inactivity] 18:34 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev 18:38 -!- jtimon [~quassel@227.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds] 18:53 -!- xabbix [~xabbix@unaffiliated/xabbix] has quit [Ping timeout: 248 seconds] 18:54 -!- xabbix [~xabbix@bzq-79-178-52-49.red.bezeqint.net] has joined #bitcoin-core-dev 18:54 -!- xabbix [~xabbix@bzq-79-178-52-49.red.bezeqint.net] has quit [Changing host] 18:54 -!- xabbix [~xabbix@unaffiliated/xabbix] has joined #bitcoin-core-dev 19:00 -!- dermoth [~thomas@dsl-216-221-56-157.mtl.aei.ca] has quit [Read error: Connection reset by peer] 19:01 -!- dermoth [~thomas@dsl-216-221-56-157.mtl.aei.ca] has joined #bitcoin-core-dev 19:09 -!- wallet42 [uid154231@gateway/web/irccloud.com/x-dfkctkfwpodedaib] has quit [Quit: Connection closed for inactivity] 19:22 -!- fengling [~fengling@111.198.29.53] has joined #bitcoin-core-dev 19:35 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has quit [Read error: Connection reset by peer] 19:37 -!- hsmiths [~hsmiths@cpe-76-174-26-91.socal.res.rr.com] has joined #bitcoin-core-dev 19:46 -!- fengling [~fengling@111.198.29.53] has quit [Ping timeout: 240 seconds] 19:46 -!- xiangfu [~xiangfu@111.198.29.53] has quit [Ping timeout: 260 seconds] 19:48 -!- xiangfu [~xiangfu@111.198.29.53] has joined #bitcoin-core-dev 19:54 -!- fengling [~fengling@111.198.29.53] has joined #bitcoin-core-dev 20:05 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has joined #bitcoin-core-dev 20:24 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 252 seconds] 20:25 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev 20:39 -!- wallet42 [uid154231@gateway/web/irccloud.com/x-whhcxbzstbftrcdc] has joined #bitcoin-core-dev 20:50 -!- gevs [~greg@unaffiliated/gevs] has quit [Remote host closed the connection] 20:56 -!- go1111111 [~go1111111@104.200.154.72] has quit [Quit: Leaving] 21:00 -!- go1111111 [~go1111111@104.232.116.217] has joined #bitcoin-core-dev 21:21 -!- p15x [~p15x@179.91.145.64.unassigned.bringover.net] has joined #bitcoin-core-dev 21:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:57 -!- Alopex [~bitcoin@176.9.70.183] has joined #bitcoin-core-dev 22:18 -!- OGF-US [~StringerB@c-73-210-225-26.hsd1.il.comcast.net] has joined #bitcoin-core-dev 22:21 -!- river__ [uid155689@gateway/web/irccloud.com/x-yxxlxrsxngalzybn] has joined #bitcoin-core-dev 22:21 -!- StringerBell [~StringerB@c-73-210-225-26.hsd1.il.comcast.net] has quit [Ping timeout: 252 seconds] 22:22 -!- fengling [~fengling@111.198.29.53] has quit [Ping timeout: 240 seconds] 22:23 -!- frankenmint [~frankenmi@174-25-22-102.ptld.qwest.net] has quit [Remote host closed the connection] 22:27 -!- arubi is now known as ^arubi 22:50 -!- jannes [~jannes@178.132.211.90] has quit [Ping timeout: 246 seconds] 22:59 -!- fengling [~fengling@111.198.29.53] has joined #bitcoin-core-dev 22:59 -!- wallet42 [uid154231@gateway/web/irccloud.com/x-whhcxbzstbftrcdc] has quit [Quit: Connection closed for inactivity] 23:00 -!- dermoth [~thomas@dsl-216-221-56-157.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:00 -!- dermoth [~thomas@dsl-216-221-56-157.mtl.aei.ca] has joined #bitcoin-core-dev 23:19 -!- go1111111 [~go1111111@104.232.116.217] has quit [Ping timeout: 276 seconds] 23:27 -!- assder [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has joined #bitcoin-core-dev 23:38 -!- supasonic [~supasonic@172-11-188-117.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 244 seconds]