--- Day changed Mon May 30 2016 00:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds] 00:27 -!- p15 [~p15@114.243.158.148] has joined #bitcoin-core-dev 00:28 -!- p15 [~p15@114.243.158.148] has quit [Client Quit] 00:33 -!- Naphex [~naphex@unaffiliated/naphex] has joined #bitcoin-core-dev 00:34 -!- fengling [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 00:34 -!- gevs_ [~greg@62.235.81.101] has quit [Remote host closed the connection] 00:34 -!- fengling [~fengling@58.135.95.132] has joined #bitcoin-core-dev 00:36 < wumpus> interesting, I have a bitcoind that hangs at "Loading banlist..." 00:37 < wumpus> well it responds to RPC requests with that 00:39 < wumpus> it does actually seem to be syncing with the network 00:40 < wumpus> ok initialization completed now, seems to be a case of misreporting what it is doing 00:41 -!- fengling_ [~fengling@58.135.95.134] has joined #bitcoin-core-dev 00:42 -!- fengling [~fengling@58.135.95.132] has quit [Ping timeout: 240 seconds] 00:53 -!- gevs [~greg@62.235.81.101] has joined #bitcoin-core-dev 00:53 -!- gevs [~greg@62.235.81.101] has quit [Changing host] 00:53 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 00:55 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ytmmgzbimhljchqg] has joined #bitcoin-core-dev 01:08 -!- G1lius [~stefangil@85.17.25.34] has joined #bitcoin-core-dev 01:08 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Read error: Connection reset by peer] 01:15 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 01:16 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 01:28 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 01:45 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:05 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 02:07 -!- p15 [~p15@136.91.145.64.unassigned.bringover.net] has joined #bitcoin-core-dev 02:08 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 02:12 -!- AaronvanW [~ewout@220pc230.sshunet.nl] has joined #bitcoin-core-dev 02:12 -!- AaronvanW [~ewout@220pc230.sshunet.nl] has quit [Changing host] 02:12 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:35 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 02:46 -!- p15 [~p15@136.91.145.64.unassigned.bringover.net] has quit [Ping timeout: 240 seconds] 02:49 -!- fengling_ [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 02:56 -!- fengling_ [~fengling@58.135.95.134] has joined #bitcoin-core-dev 02:58 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has joined #bitcoin-core-dev 02:58 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has quit [Client Quit] 03:01 -!- fengling_ [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 03:07 -!- fengling_ [~fengling@58.135.95.134] has joined #bitcoin-core-dev 03:14 < GitHub101> [bitcoin] jonasnick opened pull request #8118: Reduce unnecessary hashing in signrawtransaction (master...faster-signraw) https://github.com/bitcoin/bitcoin/pull/8118 03:39 < GitHub154> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ff2c8d29f6b...61b86848b163 03:39 < GitHub154> bitcoin/master 619d569 Pieter Wuille: Benchmark SipHash 03:39 < GitHub154> bitcoin/master 61b8684 Wladimir J. van der Laan: Merge #8111: Benchmark SipHash... 03:40 < GitHub166> [bitcoin] laanwj closed pull request #8111: Benchmark SipHash (master...benchsiphash) https://github.com/bitcoin/bitcoin/pull/8111 03:40 < GitHub141> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/61b86848b163...989df7ecf3a1 03:40 < GitHub141> bitcoin/master fc95f6e Chris Moore: fix typo in help text... 03:40 < GitHub141> bitcoin/master 989df7e Wladimir J. van der Laan: Merge #7896: fix typo in help text... 03:40 < GitHub103> [bitcoin] laanwj closed pull request #7896: fix typo in help text (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7896 03:43 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:46 -!- G1lius [~stefangil@85.17.25.34] has quit [Read error: Connection reset by peer] 03:58 -!- JackH [~Jack@79-73-185-113.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 04:06 < GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/989df7ecf3a1...52b803e09b16 04:06 < GitHub29> bitcoin/master 5fac1f3 Yuri Zhykin: bench: Added base58 encoding/decoding benchmarks 04:06 < GitHub29> bitcoin/master 52b803e Wladimir J. van der Laan: Merge #8107: bench: Added base58 encoding/decoding benchmarks... 04:06 < GitHub51> [bitcoin] laanwj closed pull request #8107: bench: Added base58 encoding/decoding benchmarks (master...benchmarks) https://github.com/bitcoin/bitcoin/pull/8107 04:20 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has joined #bitcoin-core-dev 04:29 < GitHub138> [bitcoin] fanquake opened pull request #8119: [trivial] Add .DSYM to .gitignore (master...ignore_debug) https://github.com/bitcoin/bitcoin/pull/8119 04:30 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Remote host closed the connection] 04:42 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has quit [Quit: laurentmt] 04:44 -!- fengling_ [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 04:55 -!- fengling_ [~fengling@58.135.95.134] has joined #bitcoin-core-dev 05:00 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 05:05 -!- fengling_ [~fengling@58.135.95.134] has quit [Ping timeout: 240 seconds] 05:12 -!- bustd_soket [weechat@gateway/vpn/mullvad/x-mgmxcottmwptuxvo] has quit [Ping timeout: 244 seconds] 05:17 -!- bustd_soket [weechat@gateway/vpn/mullvad/x-mseehmuykjnwmrfu] has joined #bitcoin-core-dev 05:28 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 05:31 -!- squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Ping timeout: 258 seconds] 05:34 -!- dermoth [~thomas@dsl-216-221-55-197.mtl.contact.net] has quit [Ping timeout: 246 seconds] 05:35 -!- dermoth [~thomas@dsl-66-36-145-213.mtl.aei.ca] has joined #bitcoin-core-dev 05:45 < GitHub15> [bitcoin] fanquake opened pull request #8121: [Doc] Update implemented BIPs list (master...missing_bips) https://github.com/bitcoin/bitcoin/pull/8121 06:20 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 06:27 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 06:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 06:39 -!- G1lius [~stefangil@109.201.143.216] has joined #bitcoin-core-dev 06:40 < GitHub73> [bitcoin] sipa opened pull request #8123: Use std::atomic for fRequestShutdown and fReopenDebugLog (master...notsigbutatomic) https://github.com/bitcoin/bitcoin/pull/8123 06:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:57 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 07:00 < GitHub196> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/52b803e09b16...950be19727a5 07:00 < GitHub196> bitcoin/master fa2637a Pieter Wuille: Always require OS randomness when generating secret keys 07:00 < GitHub196> bitcoin/master 628cf14 Pieter Wuille: Don't use assert for catching randomness failures 07:00 < GitHub196> bitcoin/master 950be19 Pieter Wuille: Merge #7891: Always require OS randomness when generating secret keys... 07:00 < GitHub132> [bitcoin] sipa closed pull request #7891: Always require OS randomness when generating secret keys (master...betterrng) https://github.com/bitcoin/bitcoin/pull/7891 07:13 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has quit [Remote host closed the connection] 07:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 07:29 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 07:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:38 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:54 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 08:24 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 08:30 -!- rubensayshi [~ruben@c89225.upc-c.chello.nl] has joined #bitcoin-core-dev 08:43 < gmaxwell> \O/ (randomness) 08:48 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 08:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 09:04 < GitHub170> [bitcoin] sipa opened pull request #8126: std::shared_ptr based CTransaction storage in mempool (master...sharedmempool) https://github.com/bitcoin/bitcoin/pull/8126 09:05 -!- murch [~murch@p4FE39931.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:06 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 260 seconds] 09:09 < gmaxwell> \O/ 09:12 < luke-jr> O.o 09:14 < sipa> ^^ 09:17 < sipa> gmaxwell: it also conflicts with a few of your PRs, but it should simplify them 09:18 < gmaxwell> I don't mind. 09:18 < btcdrak> a rebase is a small price to pay for randomness 09:19 < btcdrak> the new currency shall be called rebases. 09:19 < gmaxwell> sipa: Is CTxMempool::CompareDepthAndScore dead code after the change that puts int in the Comparitor directly? 09:19 < luke-jr> might be useful to have a typedef though? 09:20 < gmaxwell> btcdrak: Sipa and I were commenting there about the shared_ptr change. 09:20 < luke-jr> CTransactionRef or something? 09:21 < gmaxwell> I kinda like knowing that its a shared_ptr, but... nevermind my taste. 09:22 < luke-jr> I don't feel strongly about this, was mainly thinking if we ever had to go back to pre-C++11 for some reason 09:22 < luke-jr> which seems unlikely 09:24 < sipa> luke-jr: sounds fine... std::shared_ptr is a bit awkward to type 09:24 < sipa> on the aother hand... auto works well :) 09:24 < sipa> gmaxwell: no, still used from the heapifier in message handling 09:26 < luke-jr> 'auto' certainly tells even less that it is a shared_ptr :P 09:27 < luke-jr> so if the long type is going to encourage using auto everywhere, perhaps gmaxwell's goal is actually better suited by a typedef as well 09:27 < gmaxwell> I think I'm going to have to give up on editing this code using an editor that can't go and read faraway prototypes. Auto for return types is pretty useful, but it currently results in me grepping to go find out what the type actually is. 09:28 * sipa abandons his rewrite to increase usage of auto 09:28 < gmaxwell> I hope not. Don't change what you're doing because of my very C-like preferences. 09:28 < sipa> it's a valid argument 09:29 < gmaxwell> I think it is best when the return type is obvious. E.g. functions that give you an iterator. 09:29 < sipa> we could of course go back to strict hungarian notation :D 09:29 * luke-jr understood that as abandoning "a PR intentionally doing nothing but changing stuff to 'auto' where possible" 09:30 < sipa> luke-jr: oh, no, i mean improving my current shared_ptr PR 09:30 < luke-jr> oh, ok 09:31 < gmaxwell> sipa: is there something we can do at shutdown to tell if all the txn have been freed? even in just some debugging build? 09:32 < sipa> gmaxwell: how could they not? 09:32 < luke-jr> CTx constructor could increment a global, and destructor decrement it? 09:33 < sipa> luke-jr: yup 09:33 < sipa> an atomic global :) 09:33 < sipa> and on every decrement, print to stderr 09:35 < gmaxwell> in the current code, they couldn't AFAICT. But if we leaked some object with a shared ptr we'd leak the transaction. It's generally pretty hard to leak shared_ptr... but seems prudent to check for. 09:35 < gmaxwell> Yea, that would work. 09:36 < sipa> also: the glibc implementation of std::shared_ptr is not readable 09:40 < gmaxwell> BlueMatt: thoughts on #8126 ? would you like to rebase compactblocks on that? 09:46 < sipa> with --patience i get much more readable diffs often 09:49 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 250 seconds] 10:16 < gmaxwell> http://blog.invisiblethings.org/2016/05/30/build-security.html < on build enviroment security. 10:28 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 10:38 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:39 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 10:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:02 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 11:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 11:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:10 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 11:48 -!- G1lius [~stefangil@109.201.143.216] has quit [] 11:59 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:02 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 12:02 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:05 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 12:05 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 12:15 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:17 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 12:29 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 12:36 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:38 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 12:42 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:44 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 12:47 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 12:49 < BlueMatt> gmaxwell: I probably will after its merged, sure 12:50 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:53 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 13:00 < btcdrak> BlueMatt: could you say so on the ticket so people arent waiting for it? 13:05 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:10 < BlueMatt> btcdrak: who's waiting for what? 13:17 < sipa> it shouldn't interfere with review of compact blocks otherwise 13:17 < sipa> just the refcounting in the mempool can go away 13:34 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Remote host closed the connection] 13:37 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 13:44 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 14:03 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:10 -!- murch [~murch@p4FE39931.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 14:27 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:32 < gmaxwell> BlueMatt: you might want to review sipa's patch (or try the rebase) to make sure it won't get in your way. 14:35 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has joined #bitcoin-core-dev 14:35 < sipa> i'll do the rebase for you, if it helps things forward 14:41 -!- frankenmint [~frankenmi@174-25-25-137.ptld.qwest.net] has quit [Ping timeout: 264 seconds] 14:45 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: WeeChat 0.4.3] 14:49 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:51 -!- jarret [~jarret@162.216.46.179] has quit [Ping timeout: 264 seconds] 14:58 -!- slackircbridge [~slackircb@45.55.41.36] has quit [Remote host closed the connection] 15:00 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 15:27 < gmaxwell> sipa: might be a good review excercise even if matt doesn't want to use the result. 15:30 < gmaxwell> Opinion piece against most uses of unit tests that I think makes some nice points: http://rbcs-us.com/documents/Why-Most-Unit-Testing-is-Waste.pdf (the biggest exceptions he makes are cases where there is a clear formal defintion of correctness that can be tested against for the function, and also when the tests are realistically able to completely test the function; otherwise he favors system 15:30 < gmaxwell> tests and gives arguments from a number of angles). 15:31 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 15:41 -!- jarret [~jarret@162.216.46.179] has joined #bitcoin-core-dev 15:46 -!- jarret [~jarret@162.216.46.179] has quit [Ping timeout: 260 seconds] 15:46 -!- jarret [~jarret@72.53.24.148] has joined #bitcoin-core-dev 15:51 -!- jarret [~jarret@72.53.24.148] has quit [Ping timeout: 264 seconds] 15:53 -!- slackircbridge [~slackircb@45.55.41.36] has quit [Remote host closed the connection] 15:54 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 16:11 -!- slackircbridge [~slackircb@45.55.41.36] has quit [Remote host closed the connection] 16:12 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 16:20 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:26 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 16:27 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 16:54 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 264 seconds] 17:02 -!- spudowiar1 [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 17:03 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 260 seconds] 17:04 -!- spudowiar1 is now known as spudowiar 17:07 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev 17:13 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 17:21 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ytmmgzbimhljchqg] has quit [Quit: Connection closed for inactivity] 17:24 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:36 -!- fengling_ [~fengling@58.135.95.134] has joined #bitcoin-core-dev 17:37 -!- fengling_ [~fengling@58.135.95.134] has quit [Client Quit] 17:37 -!- cryptapus_ [~cyptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 17:37 -!- cryptapus_ [~cyptapus@jupiter.osmus.org] has quit [Changing host] 17:37 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 17:42 -!- cryptapus_ [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds] 18:05 -!- dermoth [~thomas@dsl-66-36-145-213.mtl.aei.ca] has quit [Read error: Connection reset by peer] 18:05 -!- dermoth [~thomas@dsl-66-36-145-213.mtl.aei.ca] has joined #bitcoin-core-dev 18:21 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 18:35 -!- dermoth [~thomas@dsl-66-36-145-213.mtl.aei.ca] has quit [Read error: Connection reset by peer] 18:35 -!- dermoth [~thomas@dsl-66-36-145-213.mtl.aei.ca] has joined #bitcoin-core-dev 18:37 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 18:51 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:52 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 18:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 18:58 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 19:05 -!- BonyM [~BonyM-I@ua-83-227-211-4.cust.bredbandsbolaget.se] has quit [Ping timeout: 276 seconds] 19:07 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 19:09 -!- teward [teward@ubuntu/member/teward] has quit [Ping timeout: 260 seconds] 19:13 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 276 seconds] 19:14 -!- teward [teward@ubuntu/member/teward] has joined #bitcoin-core-dev 19:15 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:17 -!- p15 [~p15@159.91.145.64.unassigned.bringover.net] has joined #bitcoin-core-dev 19:19 < kanzure> i do not feel entirely comfortable with his "throw tests away" comment 19:21 -!- p15 [~p15@159.91.145.64.unassigned.bringover.net] has left #bitcoin-core-dev [] 19:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 19:27 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 19:35 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 19:41 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 276 seconds] 19:57 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 272 seconds] 20:03 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Quit: Leaving] 20:09 -!- xiangfu [~xiangfu@58.135.95.136] has joined #bitcoin-core-dev 20:12 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev 20:27 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 272 seconds] 20:32 -!- BonyM [~BonyM-I@ua-83-227-211-4.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 20:51 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:52 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:56 < gmaxwell> kanzure: I thought the same, but on reflection, I dunno, any generic advice is ... generic. I've certantly seen tests that should be thrown away. Ones that basically could never catch an error but still manage to produce false positives. Those should probably be thrown away. 21:27 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:48 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:49 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:17 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:18 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:18 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has joined #bitcoin-core-dev 22:18 -!- paveljanik [~paveljani@79-98-72-216.sys-data.com] has quit [Changing host] 22:18 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 22:39 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.] 22:48 -!- go1111111 [~go1111111@104.200.154.22] has joined #bitcoin-core-dev 23:09 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 23:10 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 23:13 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-odvfewbbjkucatak] has joined #bitcoin-core-dev 23:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:32 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 250 seconds] 23:51 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:57 < jonasschnelli> cfields_, wumpus: re: https://github.com/bitcoin/bitcoin/issues/8120, "make deploy" is unused during gitian? right?