--- Day changed Mon Jun 06 2016
00:05 -!- trippysalmon [~trippy@cyberdynesys.org] has joined #bitcoin-core-dev
00:11 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
00:11 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
00:16 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
00:20 -!- ozanyurt [~ozanyurt@78.190.170.0] has joined #bitcoin-core-dev
00:33 -!- calibre720 [~calibre72@182.57.38.226] has quit [Quit: Leaving]
00:53 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.]
00:58 -!- AaronvanW [~ewout@220pc230.sshunet.nl] has joined #bitcoin-core-dev
00:58 -!- AaronvanW [~ewout@220pc230.sshunet.nl] has quit [Changing host]
00:58 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:07 -!- jarret_ [~jarret@162.216.46.170] has quit [Ping timeout: 276 seconds]
01:09 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
01:23 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev
01:23 -!- G1lius [~stefangil@85.17.25.43] has joined #bitcoin-core-dev
01:34 < GitHub130> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/e6b141acf9dcc0a12f49d53c0bb8a892bae72217
01:34 < GitHub130> bitcoin/master e6b141a Wladimir J. van der Laan: qt: translation strings update
02:17 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:33 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
02:36 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
02:49 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit []
02:54 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev
03:09 -!- ozanyurt_ [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
03:10 -!- ozanyurt [~ozanyurt@78.190.170.0] has quit [Ping timeout: 246 seconds]
03:28 -!- ozanyurt_ [~ozanyurt@78.185.248.35] has quit [Ping timeout: 250 seconds]
03:28 -!- ozanyurt [~ozanyurt@178.162.216.49] has joined #bitcoin-core-dev
03:29 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev []
03:32 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Remote host closed the connection]
03:47 -!- gevs_ [~greg@ip-62-235-153-94.dsl.scarlet.be] has joined #bitcoin-core-dev
03:48 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 272 seconds]
04:32 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
04:43 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Quit: Textual IRC Client: www.textualapp.com]
04:49 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
05:11 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:24 -!- jarret [~jarret@162.216.46.104] has joined #bitcoin-core-dev
05:59 < GitHub71> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6b141acf9dc...243ac0c75b1b
05:59 < GitHub71> bitcoin/master 9dfaa1c Patrick Strateman: Improve CWallet API with new AccountMove function.
05:59 < GitHub71> bitcoin/master 243ac0c Wladimir J. van der Laan: Merge #8137: Improve CWallet API with new AccountMove function....
05:59 < GitHub112> [bitcoin] laanwj closed pull request #8137: Improve CWallet API with new AccountMove function. (master...2016-06-02-cwallet-accountmove) https://github.com/bitcoin/bitcoin/pull/8137
06:06 < GitHub174> [bitcoin] sipa opened pull request #8149: Segregated witness rebased (master...segwit-master2) https://github.com/bitcoin/bitcoin/pull/8149
06:07 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev
06:12 -!- gevs_ [~greg@ip-62-235-153-94.dsl.scarlet.be] has quit [Quit: bye]
06:13 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
06:13 < sipa_> #8149 is 25% consensus/p2p/node changes, 10% wallet/signing changes, and 65% tests
06:14 < sipa_> (the tests mostly due to sdaftuar)
06:15 < sipa_> well, mostly is exaggerated, but more than half of it is from his p2p test
06:15  * sipa_ wishes that git/github had a way to organize commits in a PR hierarchically
06:22 < instagibbs> yes, those tests are very comprehensive, thanks sdaftuar :)
06:22 -!- helo_ is now known as helo
06:36 < kanzure> sipa_: could you add some text to the top-level comment in pull request 7910 to refer to 8149 (otherwise folks will have to read all the way to the bottom to learn about 8149)
06:38 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev
06:38 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
06:39 -!- zooko [~user@209.49.240.226] has joined #bitcoin-core-dev
06:39 < sipa_> kanzure: done
06:44 -!- zooko [~user@209.49.240.226] has quit [Ping timeout: 246 seconds]
06:45 < GitHub6> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/243ac0c75b1b...6b781df74fc2
06:45 < GitHub6> bitcoin/master f0fdda0 Kaz Wesley: IsInitialBlockDownload: usually avoid locking...
06:46 < GitHub6> bitcoin/master 6b781df Wladimir J. van der Laan: Merge #8007: Minor locking improvements...
06:46 < GitHub99> [bitcoin] laanwj closed pull request #8007: Minor locking improvements (master...locknits) https://github.com/bitcoin/bitcoin/pull/8007
06:46 < cfields_> luke-jr: ping. I'm not seeing your "-dirty" behavior
06:46 < MarcoFalke> sipa_: How do you plan to handle "segnet is not intended to be merged into Core"
06:47 < MarcoFalke> is it going to be merged to result in the same tree hash?
06:47 < sipa_> MarcoFalke: in 7910 i will add a commit to remove it; in 8149 is will be removed from history
06:48 < sipa_> i'll keep updating both PRs now, as i don't expect many changes anymore
06:49 < kanzure> i wonder if git can revert a (given) patch post-rebase
06:49 < sipa_> but there are still a few (GBT, dns seeds, segnet, ...)
06:49 < sipa_> kanzure: pretty sure it can, if it doesn't conflict
06:50 < kanzure> alright then the check is "post-rebase, revert the remove-segnet patch, then check to see if the tree matches" (or you can compare 7910 latest tree hash with 8149 latest tree hash)
06:50 -!- gevs [~greg@unaffiliated/gevs] has quit [Ping timeout: 250 seconds]
06:50 < sipa_> i'll just keep both in sync
06:50 < MarcoFalke> Also, I think GitHub orders by commit date and not author date.
06:51 < MarcoFalke> If that is something to care about
06:51 < sipa_> MarcoFalke: that's why i provide my own list of commits...
06:51 < sipa_> i want them to be dependency-ordered, not time
06:52 < sdaftuar> sipa_: what's your preference for which PR we should post additional review comments?
06:53 < sipa_> sdaftuar: 7910
06:53 < MarcoFalke> Better keep it in 7910, so it is not all over the place?
06:53 < sdaftuar> sounds good
07:03 < instagibbs> might want to note that directly in both PRs
07:07 < MarcoFalke> wumpus: I am happy to fix that as well in the pull ( https://github.com/bitcoin/bitcoin/pull/8144#discussion-diff-65889382 ) but I'd like to know if the current wording is suitable, first.
07:08 < MarcoFalke> For the general direction, I agree with what sipa commented on the pull. We should probably rework the wallet fee behavior... But I don't see that happen in 0.13.0
07:09 < wumpus> yes, the wording sounds good to me
07:09 < wumpus> and indeed an option for confirm target would be nice too
07:09 < wumpus> but that's something else, no need to do it there
07:10 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Ping timeout: 264 seconds]
07:11 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev
07:11 < wumpus> I think being consistent with amounts is pretty important, there is already one place where satoshis values leaked in the RPC API (the fee delta in mining.cpp), we were too late with changing there as that version was already deployed
07:11 < MarcoFalke> Making it confirm target would change the behavior and users seem to be very sensitive to such wallet behavior changes
07:11 < MarcoFalke> as we noticed in 0.12
07:12 < helo> sorry to bikeshed... i know a confrimation target can't be guaranteed, but can it have confidence intervals to temper expectations?
07:12 < wumpus> don't we already have a confirm target?
07:12 < wumpus> this would just override the global steting
07:12 < MarcoFalke> not for fundrawtx?
07:12 < wumpus> ok, then only use it when the option is specified
07:13 < wumpus> I  assumed it'd just use the global default confirmtarget unles specified otherwise
07:13 < MarcoFalke> And if the users didn't set anything, it will also happen to "fall back" to txconfirmtarget
07:13 < MarcoFalke> jup
07:13 < wumpus> that's what I mean
07:13 -!- Inaltoasinistra [~jonathan@88-149-160-115.v4.ngi.it] has quit [Ping timeout: 276 seconds]
07:14 < wumpus> helo: if you find a way to compute those, sure
07:14 -!- Inaltoasinistra [~jonathan@88-149-242-82.v4.ngi.it] has joined #bitcoin-core-dev
07:15 < helo> i'll give it a shot, we'll see
07:17 -!- ozanyurt [~ozanyurt@178.162.216.49] has quit [Read error: Connection reset by peer]
07:17 < sipa_> helo: it aims for 95% confidence, iirc
07:17 < phantomcircuit> wumpus, rebased #8142
07:17 < MarcoFalke> based on the observations from the past
07:18 < wumpus> phantomcircuit: thanks
07:18 < MarcoFalke> But I don't think you can figure out confidence intervals for the future
07:18 < sipa_> MarcoFalke: of course
07:18 < helo> yeah, you can't... just bayesian i'd assum
07:19 < MarcoFalke> Yet another 32-bit 64-bit issue...
07:20 < MarcoFalke> Can we forbid floating point multiplication for CAmount?
07:20 < sipa_> MarcoFalke: where?
07:20 < MarcoFalke> In the tests
07:21 -!- ozanyurt [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
07:21 < MarcoFalke> behavior is not the same on 32bit arch and 64
07:22 < wumpus> floating point for CAmounts? heresy!
07:22 < MarcoFalke> .6 * 100000 sat will give 59999 sat on 32bit under some circumstances
07:23 < wumpus> (and if you do you at least use correct rounding instead of truncation, but please don't use floating point for monetary amounts)
07:23 < MarcoFalke> Haven't yet figured out why it is working right now, but I was doing some refactor and triggered it.
07:29 < GitHub154> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6b781df74fc2...52c3f348bec3
07:29 < GitHub154> bitcoin/master 152ab23 Patrick Strateman: Improve CWallet API  with new GetAccountPubkey function....
07:29 < GitHub154> bitcoin/master 52c3f34 Wladimir J. van der Laan: Merge #8142: Improve CWallet API  with new GetAccountPubkey function....
07:29 < GitHub33> [bitcoin] laanwj closed pull request #8142: Improve CWallet API  with new GetAccountPubkey function. (master...2016-06-02-cwallet-getaccountpubkey) https://github.com/bitcoin/bitcoin/pull/8142
07:29 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
07:38 -!- cryptapus_afk is now known as cryptapus
07:40 < sipa_> i'd like to see some P2P tests for the eviction logic being touched in #8084 etc
07:41 < sipa_> but i don't know how to do that easily, as you'd need to spoof ip addresses
07:49 < kanzure> maybe te network refactor stuff could make that easier?
07:49 < kanzure> *the network
07:51 < sipa_> i expect it to, indeed
07:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
07:56 < luke-jr> cfields_: pong
08:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
08:25 -!- ozanyurt [~ozanyurt@78.185.248.35] has quit [Ping timeout: 246 seconds]
08:30 -!- ozanyurt [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
08:31 < GitHub72> [bitcoin] MarcoFalke opened pull request #8151: [init] Make feefilter option debug option (master...Mf1606-feefilterDebug) https://github.com/bitcoin/bitcoin/pull/8151
08:31 < MarcoFalke> wumpus, I think the issue is "JSONRPC error: Expected type number for feeRate, got string"
08:32 < MarcoFalke> ups
08:32 < MarcoFalke> forget what I said
08:33 -!- hello_ [3b60c788@gateway/web/freenode/ip.59.96.199.136] has joined #bitcoin-core-dev
08:33 < hello_> Could someone explain the most recent issue raised on github ""Tell other nodes to filter invs to us by our mempool min fee" message is too technical"
08:34 < hello_> What is "invs" ... and what is the context here?
08:42 < sipa_> helo: if you need to ask what invs are, then it's an indication that the messages is indeed too technical
08:42 < sipa_> and that is the issue
08:43 < gmaxwell> it's not even a setting an ordinary user should ever touch.
08:43 < gmaxwell> -makemynodeworkworse
08:43 < instagibbs> jl2012, have you adapted the BIP/PR for relaxing witness program size yet?
08:44 < sipa_> instagibbs: yes, it's already included
08:44 < sipa_> (to length 40)
08:46 < instagibbs> ah thanks
08:47 < hello_> Well Im trying to  contribute to bitcoin... So I would be happy if you could just give a line of explanation. :) Cheers..
08:47 < hello_> sipa_: I already understand about 50% of the software so ....
08:48 < sipa_> hello_: i'll gladly explain things, but i don't think this is the place to explain the basic p2p protocol :)
08:49 < MarcoFalke> hello_: There is a bitcoin wiki with the basic description
08:50 < sipa_> hello_: https://bitcoin.org/en/developer-guide#transaction-broadcasting for explanation of the transaction relay protocol
08:51 < sipa_> hello_: https://github.com/bitcoin/bips/blob/master/bip-0133.mediawiki for feefilter
08:53 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
08:54 < hello_> Thank you a lot Peter Wuille. ( I hope)
08:56 < hello_> MarcoFalke: Thank you
08:57 -!- G1lius [~stefangil@85.17.25.43] has quit []
08:58 < jl2012> sipa_ , instagibbs: we need to remind all alternative implementations to update their consensus rules
08:58 < instagibbs> roasbeef, ^^^
09:00 < jl2012> should I make an announcement on the ML?
09:01 < instagibbs> better safe than sorry
09:01 < btcdrak> yup
09:03 -!- gevs [~greg@ip-62-235-153-94.dsl.scarlet.be] has joined #bitcoin-core-dev
09:03 -!- gevs [~greg@ip-62-235-153-94.dsl.scarlet.be] has quit [Changing host]
09:03 -!- gevs [~greg@unaffiliated/gevs] has joined #bitcoin-core-dev
09:11 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 246 seconds]
09:13 -!- G1lius [stefangili@46.59-242-81.adsl-dyn.isp.belgacom.be] has joined #bitcoin-core-dev
09:30 -!- ozanyurt [~ozanyurt@78.185.248.35] has quit [Read error: Connection reset by peer]
09:31 -!- ozanyurt_ [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
09:32 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
09:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
09:45 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
09:50 < sipa_> Lightsword: can you review https://github.com/bitcoin/bitcoin/pull/7935 ?
09:52 < sipa_> for breaking changes (not csv, but for segwit it would) it requires that explicit support be indicated in the GBT call request
09:53 < sipa_> (which makes sense, as they'd construct bogus blocks without, but i wonder if that's not a problem for downstream software)
09:53 < sipa_> perhaps a command-line flag saying "yes, my mining client supports feature X, don't require it to tell you every time" is more convenient
09:58 < luke-jr> and then have downstream software fail to implement it?..
09:58 < luke-jr> easier to just tell you every time
09:58 < luke-jr> especially considering this is GBT so there's no bandwidth savings from omitting it
09:58 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.]
09:59 < gmaxwell> commandline flag seems error prone, you don't upgrade one piece of downstream software and 20% of your infrastructure is producing invalid blocks.
10:00 -!- ozanyurt_ [~ozanyurt@78.185.248.35] has quit [Read error: Connection reset by peer]
10:01 -!- ozanyurt [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
10:02 < sipa_> luke-jr: that seems reasonable, but i haven't seen anyone comment on what changes this would require in their stack
10:03 < luke-jr> adding a key to the JSON object is trivial in every stack I know of
10:04 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Read error: Connection reset by peer]
10:08 < Lightsword> sipa_, since stratum server requries a patch anyways can easially include the explicit support in the patch
10:08 < sipa_> ok, thanks
10:09 < Lightsword> sipa_, are there any potential issues with making a request indicating SW support to a non-SW capable node?
10:09 < Lightsword> it’s common to upgrade nodes separately from the stratum server
10:12 < sipa_> i do not believe that's a problem... you can always indicate support for more things than the server
10:13 < luke-jr> it shouldn't be a problem, GBT has always required the Object, and while bitcoind tolerates it being omitted, it also tolerates it being provided as spec'd
10:17 < sipa_> i think the PR always does what you'd expect; if you upgrade bitcoind before the client, it will not set the relevant bit by default during the started phase, and fail after activation (as you're unable to construct a valid block anymore)
10:17 < sipa_> if you upgrade the client before the server, no effect
10:48 < GitHub189> [bitcoin] pstratem opened pull request #8152: Remove CWalletDB* parameter from CWallet::AddToWallet (master...2016-06-06-cwallet-addtowallet-remove-cwalletdb) https://github.com/bitcoin/bitcoin/pull/8152
10:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
10:56 -!- G1lius [stefangili@46.59-242-81.adsl-dyn.isp.belgacom.be] has quit []
11:00 -!- sipa_ is now known as sipa
11:00 -!- sipa [~pw@2a02:348:86:3011::1] has quit [Changing host]
11:00 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev
11:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:10 -!- tErik_mc [~tErik@unaffiliated/terik] has quit [Ping timeout: 240 seconds]
11:11 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
11:12 < GitHub142> [bitcoin] MarcoFalke opened pull request #8153:  [rpc] fundrawtransaction feeRate: Use BTC/kB  (master...Mf1606-univalAny) https://github.com/bitcoin/bitcoin/pull/8153
11:12 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev
11:15 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev
11:15 < MarcoFalke> jonasschnelli: I think to make it BTC/kB, you'd need to modify univalue.
11:15 < MarcoFalke> (see pull)
11:17 < jonasschnelli> MarcoFalke: hmm.. i think you have added the VANY only because of the RPCTypeCheckObj check? Right?
11:17 < MarcoFalke> jup
11:17 < MarcoFalke> it is ugly
11:18 < jonasschnelli> Can you not add a third parameter to RPCTypeCheckObj's array?
11:18 < jonasschnelli> mandatory, or something...
11:23 < luke-jr> everyone is using satoshis per byte these days, which is much more logical in this case
11:23 < luke-jr> we haven't counted fees per kB in a long time
11:24 < sipa> i think consistency is more important
11:25 < luke-jr> I suppose
11:25 < jonasschnelli> sipa: agree with sipa
11:25 < luke-jr> it should probably be documented that it's not *actually* BTC/kB though
11:25 < sipa> how do you mean?
11:25 < luke-jr> in the RPC help or whatever
11:26 < jonasschnelli> If you use "estimatefee 10", you should be able to take the output as a fundrawtransaction feerate input
11:26 < jonasschnelli> so, BTC/kb
11:27 < luke-jr> mBTC/B
11:29 < MarcoFalke> luke-jr: Would work but you'd have to replace it in every doc/rpc help
11:29 < MarcoFalke> and I don't think it's less confusing
11:30 < jonasschnelli> If we should change the API, we would use satoshis everywhere.
11:30 < luke-jr> we switched from BTC/kB to mBTC/B in 0.10
11:30 < luke-jr> all the RPCs already use mBTC/B afaik
11:31 < jonasschnelli> luke-jr: estimatefee -> "(numeric) estimated fee-per-kilobyte"
11:31  * luke-jr is pretty sure that's a documentation error
11:32 < jonasschnelli> -minrelaytxfee -> Fee-per-kilobyte
11:33 < luke-jr> yeah, policy/fees.cpp uses CFeeRate, so estimatefee is almost certainly mBTC/B in practice
11:33 < jonasschnelli> maxtxfee: /** Absolute maximum transaction fee (in satoshis)
11:34 < luke-jr> anyway, this seems to be a deeper documentation issue than expected, so perhaps out of scope for MarcoFalke's PR
11:44 -!- ozanyurt [~ozanyurt@78.185.248.35] has quit [Read error: Connection reset by peer]
11:45 -!- ozanyurt [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
11:54 -!- murch [~murch@p4FDB6B46.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
11:59 -!- ozanyurt [~ozanyurt@78.185.248.35] has quit [Read error: Connection reset by peer]
12:00 -!- ozanyurt [~ozanyurt@78.185.248.35] has joined #bitcoin-core-dev
12:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
12:03 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
12:04 < cfields_> luke-jr: could you please specify the case where you see "-dirty" and shouldn't? I
12:04 < cfields_> I'm missing some detail to reproduce
12:06 -!- jarret [~jarret@162.216.46.104] has quit [Ping timeout: 240 seconds]
12:08 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 276 seconds]
12:09 < sipa> luke-jr: BTC/kB or mBTC/B is the same thing; i assume you're talking about whether it's counted per full byte or not... but fuel prices are also advertized per gallon, but counted at much smaller increments
12:10 < luke-jr> cfields_: git clone /path/to/your/repo -b branchname bitcoin && cd bitcoin && ./autogen.sh && mkdir build && sudo chown root:root -R . && sudo chown youruser build && cd build && ./configure && make && make DESTDIR=$PWD/ii install && ii/usr/local/bin/bitcoin-qt -testnet
12:10 < luke-jr> cfields_: it seems the chown is important
12:10 -!- afk11 [~afk11@109.255.154.81] has joined #bitcoin-core-dev
12:10 -!- afk11 [~afk11@109.255.154.81] has quit [Changing host]
12:10 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
12:10 < luke-jr> sipa: fair enough, but historically we have counted per full kB, so it's confusing
12:10 < cfields_> luke-jr: interesting. thanks.
12:11 < cfields_> luke-jr: just as an aside, you know about git new-workdir/git worktree, right?
12:11 < sipa> luke-jr: agree, but i guess we can add a "counted per byte" somewhere
12:11 < luke-jr> cfields_: no, I don't..
12:11 < sipa> worktree is awesome
12:12 < cfields_> luke-jr: ah, you'll want to google that then. sounds like you may be making your life harder if this test represents your workflow at all
12:12 < luke-jr> how is it different than git-clone?
12:12 < sipa> it doesn't create a new repository
12:12 < sipa> so not duplicate storage of the entire history
12:12 < cfields_> luke-jr: clone once, then have as many local checkouts in separate dirs as you want
12:13 < cfields_> ^^ what he said
12:13 < sipa> this creates multiple workdirs with the same repo
12:13 < luke-jr> git-clone uses hardlinks..
12:13 < sipa> ah, didn't know that
12:14 < sipa> well, it also has the advantage of not needing to push/pull between them
12:14 < cfields_> luke-jr: iirc the hardlinks are optional if you have fs restrictions
12:14 < luke-jr> ah
12:14 < luke-jr> that might be handy
12:15 < cfields_> sorry for the tangent, just thought it may be useful. I'll try to reproduce the case above.
12:15 < luke-jr> on another note, I wouldn't suggest using it with the test case I just gave, and might even want --no-hardlinks.. who knows what the chown will do :P
12:17 < cfields_> heh
12:21 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kgxcrkkfqfdtbrvl] has quit [Quit: Connection closed for inactivity]
12:22 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
12:28 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: WeeChat 0.4.3]
12:29 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev
12:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
12:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vajxegvgmsyjzpth] has joined #bitcoin-core-dev
13:30 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
13:43 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev []
14:01 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection]
14:02 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
14:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
14:08 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]
14:40 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
14:40 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
14:42 -!- mkarrer [~mkarrer@3.red-83-55-151.dynamicip.rima-tde.net] has quit []
14:47 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
14:47 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
14:51 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 244 seconds]
14:52 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has quit [Ping timeout: 252 seconds]
14:56 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
14:56 -!- murch [~murch@p4FDB6B46.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
15:13 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
15:17 < GitHub51> [bitcoin] kazcw opened pull request #8154: drop vAddrToSend after sending big addr message (master...drop-vAddrToSend) https://github.com/bitcoin/bitcoin/pull/8154
15:18 -!- cryptapus is now known as cryptapus_afk
15:25 -!- hello_ [3b60c788@gateway/web/freenode/ip.59.96.199.136] has quit [Ping timeout: 250 seconds]
15:30 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
15:43 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
15:43 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
15:48 -!- cryptapus [~cyptapus@unaffiliated/cryptapus] has quit [Ping timeout: 258 seconds]
15:52 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
15:56 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
16:10 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection]
16:11 -!- jiggalator is now known as nets1n
16:11 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]
16:12 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 244 seconds]
16:12 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
16:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
16:27 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
16:48 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
16:52 -!- TomMc [~tom@unaffiliated/tommc] has quit [Quit: WeeChat 1.3]
17:11 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:15 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
17:19 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
17:21 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vajxegvgmsyjzpth] has quit [Quit: Connection closed for inactivity]
17:21 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
17:24 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
17:25 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
17:28 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
17:42 < GitHub8> [bitcoin] tatobg opened pull request #8155: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/8155
17:43 < GitHub28> [bitcoin] sipa closed pull request #8155: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/8155
17:50 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Disconnected by services]
17:51 -!- Arnavion3 [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev
17:51 -!- Arnavion3 is now known as Arnavion
17:57 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 240 seconds]
17:59 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
18:00 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
18:03 -!- afk11 [~afk11@109.255.154.81] has joined #bitcoin-core-dev
18:03 -!- afk11 [~afk11@109.255.154.81] has quit [Changing host]
18:03 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
18:06 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 276 seconds]
18:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
18:09 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
18:33 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
18:35 -!- dermoth [~thomas@dial-216-221-43-121.mtl.aei.ca] has quit [Read error: Connection reset by peer]
18:38 -!- dermoth [~thomas@dial-216-221-43-121.mtl.aei.ca] has joined #bitcoin-core-dev
18:40 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
19:01 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
19:05 -!- fengling [~fengling@58.135.95.134] has joined #bitcoin-core-dev
19:07 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Ping timeout: 244 seconds]
19:09 -!- jarret [~jarret@162.216.46.142] has joined #bitcoin-core-dev
19:12 -!- adiabat [~adiabat@159.203.193.74] has joined #bitcoin-core-dev
19:12 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
19:18 -!- nets1n [~jiggalato@unaffiliated/jiggalator] has quit [Remote host closed the connection]
19:18 -!- xiangfu [~xiangfu@58.135.95.136] has joined #bitcoin-core-dev
19:29 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving]
19:40 -!- raedah [~x@172.58.41.91] has quit [Remote host closed the connection]
19:41 -!- raedah [~x@172.58.41.91] has joined #bitcoin-core-dev
19:43 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has quit [Ping timeout: 250 seconds]
19:53 -!- nets1n [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
20:01 -!- ryanrobertson21 [4208d74c@gateway/web/freenode/ip.66.8.215.76] has joined #bitcoin-core-dev
20:02 -!- ryanrobertson21 [4208d74c@gateway/web/freenode/ip.66.8.215.76] has left #bitcoin-core-dev []
20:03 -!- masterroshi [4208d74c@gateway/web/freenode/ip.66.8.215.76] has joined #bitcoin-core-dev
20:08 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Ping timeout: 272 seconds]
20:09 -!- xiangfu [~xiangfu@58.135.95.131] has joined #bitcoin-core-dev
20:20 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.]
20:21 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev
20:24 -!- achow101 [~achow101@pool-96-227-114-115.phlapa.fios.verizon.net] has quit [Remote host closed the connection]
20:30 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
20:31 -!- masterroshi [4208d74c@gateway/web/freenode/ip.66.8.215.76] has quit [Ping timeout: 250 seconds]
20:39 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
21:14 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:15 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:17 -!- grassass [grass@gateway/vpn/mullvad/x-qtcodeaifkizgjlp] has joined #bitcoin-core-dev
21:20 -!- nets1n [~jiggalato@unaffiliated/jiggalator] has quit []
21:20 -!- xiangfu [~xiangfu@58.135.95.131] has quit [Ping timeout: 260 seconds]
21:21 -!- jiggalator [~jiggalato@unaffiliated/jiggalator] has joined #bitcoin-core-dev
21:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:39 -!- supasonic [~supasonic@172-11-188-177.lightspeed.rcsntx.sbcglobal.net] has joined #bitcoin-core-dev
21:46 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
21:47 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
21:47 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
21:48 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
21:50 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
21:50 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
21:51 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
21:51 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
21:57 -!- blur3d [~blur3d@49.187.26.218] has joined #bitcoin-core-dev
22:11 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 244 seconds]
22:21 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
22:28 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
22:41 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mmdmflqryqcjokrl] has joined #bitcoin-core-dev
23:01 -!- xiangfu [~xiangfu@58.135.95.136] has joined #bitcoin-core-dev
23:03 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
23:04 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
23:07 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mmdmflqryqcjokrl] has quit [Ping timeout: 258 seconds]
23:07 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-izdgswuchwrrbabq] has quit [Ping timeout: 260 seconds]
23:08 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-nxfabflynovjfgfy] has joined #bitcoin-core-dev
23:08 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-hjwrojpksxoiknqt] has joined #bitcoin-core-dev
23:15 -!- shesek [~shesek@bzq-84-110-7-120.red.bezeqint.net] has joined #bitcoin-core-dev
23:18 -!- xiangfu [~xiangfu@58.135.95.136] has quit [Ping timeout: 264 seconds]
23:28 -!- blur3d [~blur3d@49.187.26.218] has quit [Quit: blur3d]
23:30 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
23:31 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
23:36 -!- jtimon [~quassel@4.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
23:40 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev
23:42 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection]
23:56 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Ping timeout: 244 seconds]
23:59 < GitHub25> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/52c3f348bec3...cfc6da0b1b81
23:59 < GitHub25> bitcoin/master fa51a1d MarcoFalke: [init] Make feefilter option debug option
23:59 < GitHub25> bitcoin/master cfc6da0 Wladimir J. van der Laan: Merge #8151: [init] Make feefilter option debug option...
23:59 < GitHub52> [bitcoin] laanwj closed pull request #8151: [init] Make feefilter option debug option (master...Mf1606-feefilterDebug) https://github.com/bitcoin/bitcoin/pull/8151