--- Day changed Sun Jun 19 2016 00:04 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 00:05 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 00:11 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Ping timeout: 260 seconds] 00:19 -!- gavinandresen [~gavin@unaffiliated/gavinandresen] has quit [Ping timeout: 260 seconds] 00:21 -!- gavinandresen [~gavin@unaffiliated/gavinandresen] has joined #bitcoin-core-dev 00:26 -!- jonasschnelli [~jonasschn@2a01:4f8:200:7025::2] has quit [Changing host] 00:26 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev 00:30 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ujfhslecglvaegzx] has joined #bitcoin-core-dev 00:46 <@wumpus> luke-jr: no, I don't 00:54 <@wumpus> luke-jr: we do test windows on travis AFAIK? 01:00 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 01:03 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 01:03 <@wumpus> e.g. cross-build for windows, then run the tests in wine 01:04 <@wumpus> but not sure this covers all the tests 01:09 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:24 -!- JackH [~Jack@79-73-186-51.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 01:57 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 01:59 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 02:07 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 03:03 -!- whphhg [whphhg@gateway/vpn/mullvad/x-zsvtqpcazoedlzzl] has joined #bitcoin-core-dev 04:06 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has joined #bitcoin-core-dev 04:06 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has quit [Client Quit] 04:19 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 05:19 -!- Naphex [~naphex@unaffiliated/naphex] has joined #bitcoin-core-dev 05:32 -!- Thireus [~Thireus@icy.thireus.fr] has joined #bitcoin-core-dev 06:04 -!- Thireus [~Thireus@icy.thireus.fr] has quit [Quit: Leaving.] 06:21 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has joined #bitcoin-core-dev 06:43 < luke-jr> wumpus: the Trusty changes appear to have disabled the GUI build and WINE testing :/ 06:43 < luke-jr> ie, just builds bitcoind and doesn't test it 06:51 < sipa> luke-jr: https://travis-ci.org/bitcoin/bitcoin/jobs/138611890#L2144 06:51 < sipa> seems it does 06:51 < luke-jr> hm 06:52 < sipa> ah, but not the RPC tests 06:52 < sipa> only comparison tool and unit tests 06:54 < sipa> wumpus: https://github.com/bitcoin/bitcoin/pull/5677#issuecomment-136646964 06:54 < sipa> wumpus: does that still apply? 06:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:55 < luke-jr> - env: HOST=i686-w64-mingw32 PPA="ppa:ubuntu-wine/ppa" PACKAGES="nsis gcc-mingw-w64-i686 g++-mingw-w64-i686 binutils-mingw-w64-i686 mingw-w64-dev wine1.7 bc" RUN_TESTS=true GOAL="deploy" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" MAKEJOBS="-j2" 06:55 < luke-jr> + env: HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="nsis g++-mingw-w64-i686 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports" 06:55 < luke-jr> I guess I misread the RUN_TESTS part, but what does the GOAL change imply? 06:58 < sipa> i think it just means we don't build the installer 07:55 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 250 seconds] 08:11 < Chris_Stewart_5> sipa: Do you have any thoughts on property based checking? I'm starting to integrate it into a library I'm writing and it seems it would be useful in Bitcoin Core. I was looking at this library for C++ 08:11 < Chris_Stewart_5> https://github.com/emil-e/rapidcheck 08:12 < Chris_Stewart_5> I'm wondering if there is any outright objections before I put more time into investigating this for Core.. 08:20 <@wumpus> luke-jr: yes the GUI build is disabled for travis, for all platforms, that's intentional as there is still some caching issue 08:21 <@wumpus> sipa: no idea, could be that the RPC tests could be re-enabled, just no one has tried since 08:21 < sipa> Chris_Stewart_5: no objections to the concept, but i have no experience with the code/logistics of integrating it 08:22 < sipa> Chris_Stewart_5: perhaps you want to talk to Marco Falke (our qa maintainer) 08:23 <@wumpus> Chris_Stewart_5: I have no experience with it either, if you can apply it to improve test coverage of bitcoin core, why not try it 08:23 <@wumpus> at first glance it looks like a type of fuzzing, you could take a look at https://github.com/bitcoin/bitcoin/pull/7940 08:24 < Chris_Stewart_5> Will do. Is it best to submit a pull request with a [WIP] on it, or just develop on my own branch and submit a pull request later on? 08:25 <@wumpus> that's really up to you 08:25 <@wumpus> in both cases you develop on your own branch, in the former cast it has somewhat more visibility, which is useful if you want other people's opinions about things 08:33 < Chris_Stewart_5> good point, another question, is there any vetting process for dependencies that are being added to our src files? 08:34 < Chris_Stewart_5> I get that this one isn't as crucial since it is test dependecy, but it would be important if a dependency was affect src files 08:34 < Chris_Stewart_5> src meaning everything but the child test dir 08:35 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 08:46 -!- achow101 [~achow101@pool-108-2-58-173.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 09:00 < sipa> Chris_Stewart_5: if you add a dependency, you need to make sure that it's available in the depends system (see the depends subdir), so that it's available to the deterministic build system 09:01 < Chris_Stewart_5> Hmm ok. I'm just starting to look at this stuff. Doesn't look quite as simple as maven on the JVM :-). Cory is the build expert right? 09:05 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]] 09:05 < sipa> Chris_Stewart_5: indeed 09:06 < sipa> Chris_Stewart_5: deterministic building is a pretty new concept, and there are few tools available to do it for you, so it's all pretty custom 09:07 < sipa> Chris_Stewart_5: though, generally don't worry about that, if it's useful we'll find a way to integrate it 09:08 < Chris_Stewart_5> sipa: Ok, I'm just going to hack it together to start and submit a pull request testing a few simple properties 09:12 < GitHub4> [bitcoin] wbinns opened pull request #8224: readme: Revise 'an experimental new' phrasing in reference to Bitcoin (master...binns-update-readme) https://github.com/bitcoin/bitcoin/pull/8224 09:13 -!- netsinn [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 09:25 -!- netsinn [~jiggalato@198.16.176.10] has quit [Remote host closed the connection] 09:40 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has joined #bitcoin-core-dev 09:41 -!- laurentmt [~Thunderbi@213-245-86-6.rev.numericable.fr] has quit [Client Quit] 09:43 -!- netsin_ [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 09:48 -!- netsin_ [~jiggalato@198.16.176.10] has quit [] 09:48 -!- netsinn [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 09:48 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 09:56 -!- netsinn [~jiggalato@198.16.176.10] has quit [Remote host closed the connection] 10:02 -!- netsin_ [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 10:03 -!- netsin_ [~jiggalato@198.16.176.10] has quit [Remote host closed the connection] 10:23 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:23 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 10:27 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 250 seconds] 10:38 -!- Thireus [~Thireus@37.235.49.227] has joined #bitcoin-core-dev 10:43 -!- zooko [~user@2601:281:8000:8387:75d5:557e:7670:63d0] has quit [Ping timeout: 250 seconds] 11:01 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 11:04 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:07 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 11:09 < Chris_Stewart_5> So i've created a file inside of package giving the instructions of how to build the library, what is the next step? I've tried to add the header to the test file and it fails. 11:10 < Chris_Stewart_5> I've also added it to the first line in packages.mk 11:12 < Chris_Stewart_5> See https://github.com/Christewart/bitcoin/commit/18638a532a8977d19a104f7fca76783b74d5e9fb 11:17 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:17 -!- Thireus [~Thireus@37.235.49.227] has left #bitcoin-core-dev [] 11:20 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 11:42 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-iwblcemccdfswzlg] has joined #bitcoin-core-dev 11:43 -!- michagogo_ [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 11:45 -!- pigeons_ [~pigeons@94.242.209.214] has joined #bitcoin-core-dev 11:45 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev 11:48 -!- teward- [teward@ubuntu/member/teward] has joined #bitcoin-core-dev 11:48 -!- Lightsword_ [~Lightswor@107.170.253.193] has joined #bitcoin-core-dev 11:48 -!- GreenIsMyPepper_ [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 11:50 -!- Netsplit *.net <-> *.split quits: GreenIsMyPepper, Giszmo, face, Ylbam, Guest31006, teward, musalbas, mn3monic, michagogo, d9b4bef9, (+2 more, use /NETSPLIT to show all of them) 11:50 -!- Lightsword_ is now known as Lightsword 11:50 -!- Ylbam_ is now known as Ylbam 11:50 -!- teward- is now known as teward 11:51 -!- Netsplit over, joins: d9b4bef9 11:52 -!- Netsplit over, joins: musalbas 11:53 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 264 seconds] 11:56 -!- Netsplit over, joins: face 11:56 -!- Guest31006 [~null@unaffiliated/madars] has joined #bitcoin-core-dev 11:56 -!- Netsplit over, joins: Giszmo 11:57 -!- michagogo_ is now known as michagogo 11:59 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Quit: Arnavion] 12:03 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:03 -!- teward [teward@ubuntu/member/teward] has quit [Quit: The Darkness Will Rise Again.] 12:05 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 12:06 -!- challisto [~challisto@c-76-16-149-33.hsd1.il.comcast.net] has joined #bitcoin-core-dev 12:06 -!- challisto [~challisto@c-76-16-149-33.hsd1.il.comcast.net] has quit [Changing host] 12:06 -!- challisto [~challisto@unaffiliated/challisto] has joined #bitcoin-core-dev 12:06 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 12:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 12:16 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has quit [Quit: Leaving.] 12:16 -!- teward [teward@ubuntu/member/teward] has joined #bitcoin-core-dev 12:32 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:34 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 12:34 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:36 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:38 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 13:03 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 13:04 -!- zooko [~user@2601:281:8000:8387:35d7:183d:ffbb:f950] has joined #bitcoin-core-dev 13:07 -!- davec_ [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 13:08 -!- davec_ [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 13:29 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection] 13:30 -!- zooko [~user@2601:281:8000:8387:35d7:183d:ffbb:f950] has quit [Ping timeout: 250 seconds] 13:39 -!- mn3monic [~guido@176.9.68.68] has joined #bitcoin-core-dev 13:56 -!- whphhg [whphhg@gateway/vpn/mullvad/x-zsvtqpcazoedlzzl] has quit [Remote host closed the connection] 13:57 -!- whphhg [whphhg@gateway/vpn/mullvad/x-hihrneolelyxiolm] has joined #bitcoin-core-dev 14:10 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev 14:35 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 14:36 -!- cheese_ [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 14:36 -!- raedah [~x@172.56.42.64] has quit [Remote host closed the connection] 14:37 -!- raedah [~x@172.56.42.64] has joined #bitcoin-core-dev 15:11 -!- raedah [~x@172.56.42.64] has quit [Remote host closed the connection] 15:11 -!- raedah [~x@172.56.42.64] has joined #bitcoin-core-dev 15:18 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 250 seconds] 15:23 -!- Giszmo [~leo@pc-122-14-46-190.cm.vtr.net] has joined #bitcoin-core-dev 15:35 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection] 15:42 -!- pigeons_ is now known as pigeons 15:44 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 16:12 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 258 seconds] 16:15 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 16:23 -!- Guest31006 [~null@unaffiliated/madars] has quit [Quit: reconnect] 16:24 -!- xiangfu [~xiangfu@124.207.50.216] has joined #bitcoin-core-dev 16:26 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 16:29 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Ping timeout: 276 seconds] 16:31 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 16:44 < GitHub63> [bitcoin] wbinns opened pull request #8226: contributing.md: Fix formatting (line lengths and smart quotes) (master...binns-contributing-formatting) https://github.com/bitcoin/bitcoin/pull/8226 16:50 -!- alpalp [~allen@2605:6000:f4d6:d600:d568:ff79:a7ec:9d8a] has joined #bitcoin-core-dev 16:50 -!- alpalp [~allen@2605:6000:f4d6:d600:d568:ff79:a7ec:9d8a] has quit [Changing host] 16:50 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 17:05 -!- xiangfu [~xiangfu@124.207.50.216] has quit [Remote host closed the connection] 17:12 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:51 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-iwblcemccdfswzlg] has quit [Quit: Connection closed for inactivity] 18:07 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds] 18:29 < gmaxwell> seeing a lot of non-final txn 18:45 -!- netsinn [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 18:49 -!- netsinn [~jiggalato@198.16.176.10] has quit [Ping timeout: 244 seconds] 19:16 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev 19:16 -!- netsinn [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 19:23 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection] 19:26 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev 19:27 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection] 19:30 -!- netsinn [~jiggalato@198.16.176.10] has quit [Remote host closed the connection] 19:38 -!- netsinn [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 19:40 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev 19:41 -!- netsinn [~jiggalato@198.16.176.10] has quit [Client Quit] 19:41 -!- netsinn [~jiggalato@198.16.176.10] has joined #bitcoin-core-dev 19:41 -!- netsinn [~jiggalato@198.16.176.10] has quit [Read error: Connection reset by peer] 19:45 -!- challisto [~challisto@unaffiliated/challisto] has quit [Quit: Leaving] 19:57 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 250 seconds] 20:14 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has quit [Remote host closed the connection] 20:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 20:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:29 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 20:32 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 20:34 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 20:43 -!- frankenmint [~frankenmi@67-5-211-132.ptld.qwest.net] has joined #bitcoin-core-dev 21:31 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:32 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:05 -!- xiangfu [~xiangfu@58.135.95.132] has joined #bitcoin-core-dev 23:25 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 23:29 -!- assder [82ebca3a@gateway/web/freenode/ip.130.235.202.58] has joined #bitcoin-core-dev 23:49 -!- [Author] [~Author]@2401:a400:3202:2000:bad:d09:15:90d] has quit [Ping timeout: 250 seconds] 23:54 -!- [Author] [~Author]@2401:a400:3202:2000:bad:d09:15:90d] has joined #bitcoin-core-dev