--- Day changed Wed Aug 17 2016
00:04 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
00:10 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
00:12 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
00:16 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds]
00:16 -!- rubensayshi [~ruben@82.201.93.169] has joined #bitcoin-core-dev
00:28 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev
00:33 -!- laurentmt [~Thunderbi@80.215.234.148] has joined #bitcoin-core-dev
00:34 -!- laurentmt [~Thunderbi@80.215.234.148] has quit [Client Quit]
00:35 < jonasschnelli> luke-jr: requesting BIP number for the authentication BIP: https://github.com/jonasschnelli/bips/blob/2016/07/auth_bip/bip-undef-0.mediawiki
00:38 < luke-jr> jonasschnelli: isn't that what we already gave BIP 150?
00:39 < luke-jr> hm, I guess it's still marked tentative on my end; so BIP 150 :p
00:39 < jonasschnelli> luke-jr: Could be? Wasn't aware of that. Thanks
00:39 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev
00:39 < luke-jr> jonasschnelli: used to be part of https://github.com/bitcoin/bips/pull/362, right?
00:39 < jonasschnelli> Ah. Right... it was combine at the PR level once.
01:03 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
01:08 -!- JackH [~Jack@79-73-188-45.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
01:09 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
01:13 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev
01:18 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:38 -!- laurentmt [~Thunderbi@80.215.234.148] has joined #bitcoin-core-dev
01:38 -!- laurentmt [~Thunderbi@80.215.234.148] has quit [Client Quit]
01:40 -!- ratoder [~ratoder@static.111.19.201.138.clients.your-server.de] has joined #bitcoin-core-dev
01:58 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Leaving.]
02:12 -!- Giszmo [~leo@2001:a61:32b9:3501:9822:c139:6c1c:51fc] has joined #bitcoin-core-dev
02:19 -!- Megaf [~quassel@unaffiliated/megaf] has joined #bitcoin-core-dev
02:31 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ssaeaoxwzdmireec] has joined #bitcoin-core-dev
02:51 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
02:52 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
03:00 < GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c2d471e18f0...b40e19c6c48f
03:00 < GitHub26> bitcoin/master 936c144 Wladimir J. van der Laan: build: Remove check for `openssl/ec.h`...
03:00 < GitHub26> bitcoin/master b40e19c Wladimir J. van der Laan: Merge #8520: build: Remove check for `openssl/ec.h`...
03:00 < GitHub114> [bitcoin] laanwj closed pull request #8520: build: Remove check for `openssl/ec.h` (master...2016_08_remove_openssl_ech_check) https://github.com/bitcoin/bitcoin/pull/8520
03:00 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 276 seconds]
03:01 < GitHub99> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b40e19c6c48f...b41ac928b89f
03:01 < GitHub99> bitcoin/master c1582d5 Wladimir J. van der Laan: qa: Remove duplicate `hash160` implementation...
03:01 < GitHub99> bitcoin/master b41ac92 Wladimir J. van der Laan: Merge #8521: qa: Remove duplicate `hash160` implementation...
03:01 < GitHub157> [bitcoin] laanwj closed pull request #8521: qa: Remove duplicate `hash160` implementation (master...2016_08_hash160_dupe) https://github.com/bitcoin/bitcoin/pull/8521
03:02 < GitHub138> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b41ac928b89f...29496fc9e095
03:02 < GitHub138> bitcoin/master 6ffd996 Sev: Corrected JSON typo on setban of net.cpp
03:02 < GitHub138> bitcoin/master 29496fc Wladimir J. van der Laan: Merge #8512: Trivial: Corrected JSON typo on setban of net.cpp...
03:02 < GitHub20> [bitcoin] laanwj closed pull request #8512: Trivial: Corrected JSON typo on setban of net.cpp (master...setban) https://github.com/bitcoin/bitcoin/pull/8512
03:06 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev
03:06 -!- mapass [~martin@91-235-54-11.s.azet.sk] has joined #bitcoin-core-dev
03:07 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
03:16 -!- owowo [~ovovo@185.65.134.78] has joined #bitcoin-core-dev
03:16 -!- owowo [~ovovo@185.65.134.78] has quit [Changing host]
03:16 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
03:20 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]
03:26 < GitHub170> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/29496fc9e095...740cff5808c3
03:26 < GitHub170> bitcoin/master fae596f MarcoFalke: [qa] Sort scripts by time for pull_tester and don't overwrite setup_chain
03:26 < GitHub170> bitcoin/master fa2d68f MarcoFalke: [qa] Adjust timeouts for micro-optimization of run time
03:26 < GitHub170> bitcoin/master fad8cf6 MarcoFalke: [qa] Use single cache dir for chains
03:26 < GitHub62> [bitcoin] laanwj closed pull request #8296: [qa] Don't overwrite setup_chain and sort scripts (master...Mf1607-qaSetupChain) https://github.com/bitcoin/bitcoin/pull/8296
03:26 < GitHub83> [bitcoin] laanwj closed pull request #8482: [qa] Use single cache dir for chains (master...Mf1608-qaCache) https://github.com/bitcoin/bitcoin/pull/8482
03:33 < GitHub110> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/740cff5808c3...65e644418106
03:33 < GitHub110> bitcoin/master 8194a6e Jeremy Rubin: Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
03:33 < GitHub110> bitcoin/master 65e6444 Wladimir J. van der Laan: Merge #8513: Fix a type error that would not compile on OSX....
03:33 < GitHub120> [bitcoin] laanwj closed pull request #8513: Fix a type error that would not compile on OSX. (master...fix-osx-break) https://github.com/bitcoin/bitcoin/pull/8513
03:34 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev
03:46 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
03:51 < GitHub146> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65e644418106...e753eaeb343c
03:51 < GitHub146> bitcoin/master 1aacfc2 leijurv: various typos
03:51 < GitHub146> bitcoin/master e753eae Wladimir J. van der Laan: Merge #8505: Trivial: Fix typos in various files...
03:51 < GitHub132> [bitcoin] laanwj closed pull request #8505: Trivial: Fix typos in various files (master...replacable-typo) https://github.com/bitcoin/bitcoin/pull/8505
03:53 < sipa> m-m-m-megamerge
03:58 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
03:59 -!- rubensayshi [~ruben@82.201.93.169] has quit [Remote host closed the connection]
04:00 -!- laurentmt [~Thunderbi@80.215.234.148] has joined #bitcoin-core-dev
04:01 -!- laurentmt [~Thunderbi@80.215.234.148] has quit [Client Quit]
04:07 < GitHub176> [bitcoin] laanwj pushed 4 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/4374f0ee35f8...a402396dce64
04:07 < GitHub55> [bitcoin] laanwj closed pull request #8490: [0.13] release notes: Mention new relevance of non-mining nodes on network policy; and misc fixes (0.13...relnotes_013_misc) https://github.com/bitcoin/bitcoin/pull/8490
04:07 < GitHub176> bitcoin/0.13 4f55293 Luke Dashjr: doc/release-notes: Misc
04:07 < GitHub176> bitcoin/0.13 40d705c Luke Dashjr: doc/release-notes: Mention the relevance of Compact Blocks on non-mining nodes' influence on network policy
04:07 < GitHub176> bitcoin/0.13 5e499e7 Luke Dashjr: doc/release-notes: Document changed bytespersigop behaviour
04:12 < GitHub138> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e753eaeb343c...733035bdb755
04:12 < GitHub138> bitcoin/master 3c5251d Wladimir J. van der Laan: test: Remove java comparison tool
04:12 < GitHub138> bitcoin/master eb0c52e Wladimir J. van der Laan: travis: Remove hostname hack...
04:12 < GitHub138> bitcoin/master 733035b Wladimir J. van der Laan: Merge #8504: test: Remove java comparison tool...
04:12 < GitHub95> [bitcoin] laanwj closed pull request #8504: test: Remove java comparison tool (master...2016_08_jexit) https://github.com/bitcoin/bitcoin/pull/8504
04:15 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Quit: Textual IRC Client: www.textualapp.com]
04:28 < GitHub97> [bitcoin] MarcoFalke opened pull request #8531: [qa] abandonconflict: Use assert_equal (master...Mf1608-qaAssert) https://github.com/bitcoin/bitcoin/pull/8531
04:55 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
05:00 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
05:35 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ssaeaoxwzdmireec] has quit [Quit: Connection closed for inactivity]
05:40 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
05:41 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 252 seconds]
05:42 -!- murch [~murch@p4FE38BBB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
05:56 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
06:00 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
06:01 < jonasschnelli> Is there a way to locally detect unsafe iterator usage? https://travis-ci.org/bitcoin/bitcoin/jobs/152408747#L1413
06:01 < jonasschnelli> I compiled it locally on different machines and can't get that test failure...
06:02 < sipa> jonasschnelli: it requires rebuilding glibc with debug options, i think
06:02 < jonasschnelli> It could be a bug in gcc, I'm using std::prev(myVector.end()) which should be valid and safe?
06:02 < sipa> jonasschnelli: only if the vector is not empty
06:02 < jonasschnelli> Yes. There is a check for empty vectors above..
06:02 < sipa> ah, right
06:03 < jonasschnelli> I stepped with the debugger through the whole unit test and cannot fine a invalid std::prev
06:03 < jonasschnelli> *find
06:04 < sipa> maybe it's not in a call to std::prev?
06:05 < jonasschnelli> wait.. found the issue! nm
06:06 < jonasschnelli> There is a call of std::prev(vector.begin()) which is invalid
06:07 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
06:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:34 -!- Samdney [~Samdney@maus.hawo.stw.uni-erlangen.de] has joined #bitcoin-core-dev
06:39 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev
06:48 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-stkkzbjsdkujygzr] has joined #bitcoin-core-dev
06:55 -!- murch [~murch@p4FE38BBB.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
06:57 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
07:02 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
07:04 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection]
07:10 -!- Samdney [~Samdney@maus.hawo.stw.uni-erlangen.de] has quit [Quit: Verlassend]
07:31 -!- laurentmt [~Thunderbi@80.215.138.129] has joined #bitcoin-core-dev
07:32 -!- laurentmt [~Thunderbi@80.215.138.129] has quit [Client Quit]
07:33 -!- zooko [~user@2601:281:8500:fc65:f0a:33e8:fd71:e637] has joined #bitcoin-core-dev
07:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
07:55 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:58 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
07:58 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
08:03 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
08:12 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
08:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:27 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Client Quit]
08:42 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
08:47 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev []
09:00 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
09:05 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
09:18 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev
09:19 -!- mapass [~martin@91-235-54-11.s.azet.sk] has left #bitcoin-core-dev []
09:30 -!- zooko [~user@2601:281:8500:fc65:f0a:33e8:fd71:e637] has quit [Ping timeout: 250 seconds]
09:40 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev
09:47 < btcdrak> Seeking reviews of the 0.13.0 release blog post https://github.com/bitcoin-core/bitcoincore.org/pull/199
10:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:02 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
10:02 -!- Yogh [~Yogh@f36186.upc-f.chello.nl] has quit [Ping timeout: 276 seconds]
10:03 -!- Yogh [~Yogh@f36186.upc-f.chello.nl] has joined #bitcoin-core-dev
10:06 -!- belcher [~user@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
10:06 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
10:08 -!- Guest21946 [~user@93-142-186-192.adsl.net.t-com.hr] has joined #bitcoin-core-dev
10:17 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
10:25 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]
10:28 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has joined #bitcoin-core-dev
10:30 -!- zooko [~user@50.246.213.170] has joined #bitcoin-core-dev
10:37 < Anduck> bitcoin core slack has leaked my e-mail to scammers
10:37 < Anduck> i used unique e-mail when i joined bitcoincore.slack.com
10:38 < Anduck> do bitcoincore.slack.com maintainer/admin have access to the e-mails or does slack only have them?
10:44 -!- brg444 [18257df2@gateway/web/freenode/ip.24.37.125.242] has joined #bitcoin-core-dev
10:45 < brg444> Anduck unfortunately that is just how slack is set up, every user's email address is public
10:45 -!- zooko [~user@50.246.213.170] has quit [Ping timeout: 260 seconds]
10:46 < Anduck> i've not received any attempts from other slacks
10:47 < btcdrak> Anduck, this is a feature of Slack and cannot be changed. Anyone can slurp up all member emails addresses.
10:47 < Anduck> ok.
10:47 < Anduck> thanks for replys
10:47 < btcdrak> Anduck, make sure you use 2FA and a unique password.
10:47 < brg444> It's likely Core's slack is particularly targeted, unfortunately :/
10:49 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-vrmatxqqogmrpfzo] has quit [Ping timeout: 260 seconds]
10:50 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-stkkzbjsdkujygzr] has quit [Ping timeout: 260 seconds]
10:50 < Anduck> i see, i see
10:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-maeinkfegdarqzbt] has joined #bitcoin-core-dev
10:57 < GitHub166> [bitcoin] jl2012 opened pull request #8533: Implement LOW_S and NULLDUMMY softfork (BIP146) (master...bip146) https://github.com/bitcoin/bitcoin/pull/8533
10:59 < GitHub170> [bitcoin] jl2012 closed pull request #8514: Enforce LOW_S rules on all transactions with WITNESS BIP9 parameters (master...lows) https://github.com/bitcoin/bitcoin/pull/8514
11:01 -!- Guest21946 [~user@93-142-186-192.adsl.net.t-com.hr] has quit [Quit: Leaving]
11:02 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-fbivtzmlncynrgqt] has joined #bitcoin-core-dev
11:03 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Read error: Connection reset by peer]
11:03 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
11:03 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev
11:05 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-maeinkfegdarqzbt] has quit [Quit: Connection closed for inactivity]
11:08 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
11:14 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
11:17 -!- ArthurNumbanumba [~ArthurNum@h247079.upc-h.chello.nl] has joined #bitcoin-core-dev
11:27 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: cya]
11:53 -!- lextt [~l3xtt@95.215.44.99] has joined #bitcoin-core-dev
11:56 -!- Megaf [~quassel@unaffiliated/megaf] has quit [Read error: Connection reset by peer]
11:59 -!- shesek [~shesek@bzq-84-110-209-223.red.bezeqint.net] has quit [Ping timeout: 244 seconds]
12:00 -!- execut3 [~shesek@bzq-84-110-209-223.red.bezeqint.net] has quit [Ping timeout: 240 seconds]
12:05 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
12:06 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:08 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev
12:09 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
12:33 -!- adiabat [~adiabat@h96-61-12-58.cntcnh.dsl.dynamic.tds.net] has joined #bitcoin-core-dev
12:37 < GitHub1> [bitcoin] MarcoFalke opened pull request #8534: [travis] Drop java (master...Mf1608-qaJava) https://github.com/bitcoin/bitcoin/pull/8534
12:49 -!- adiabat [~adiabat@h96-61-12-58.cntcnh.dsl.dynamic.tds.net] has quit [Quit: WeeChat 0.4.2]
12:55 -!- Megaf [~quassel@unaffiliated/megaf] has joined #bitcoin-core-dev
12:57 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!]
12:57 -!- cryptapus [~cryptapus@87.254.202.189] has joined #bitcoin-core-dev
12:57 -!- cryptapus [~cryptapus@87.254.202.189] has quit [Changing host]
12:57 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
12:59 -!- brg444 [18257df2@gateway/web/freenode/ip.24.37.125.242] has quit [Quit: Page closed]
13:06 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
13:11 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
13:13 -!- harrymm [~wayne@178.162.199.116] has quit [Remote host closed the connection]
13:23 -!- harrymm [~wayne@46.165.228.92] has joined #bitcoin-core-dev
13:25 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 260 seconds]
13:29 -!- Megaf [~quassel@unaffiliated/megaf] has quit [Ping timeout: 240 seconds]
13:35 -!- Megaf [~quassel@unaffiliated/megaf] has joined #bitcoin-core-dev
13:35 -!- Megaf [~quassel@unaffiliated/megaf] has quit [Remote host closed the connection]
13:39 -!- adiabat [~adiabat@h96-61-12-58.cntcnh.dsl.dynamic.tds.net] has joined #bitcoin-core-dev
13:47 -!- adiabat [~adiabat@h96-61-12-58.cntcnh.dsl.dynamic.tds.net] has quit [Quit: WeeChat 0.4.2]
13:47 -!- adiabat [~adiabat@h96-61-12-58.cntcnh.dsl.dynamic.tds.net] has joined #bitcoin-core-dev
13:49 -!- adiabat [~adiabat@h96-61-12-58.cntcnh.dsl.dynamic.tds.net] has quit [Client Quit]
13:50 -!- adiabat [~adiabat@159.203.193.74] has joined #bitcoin-core-dev
13:51 -!- waxwing [~waxwing@62.205.214.125] has joined #bitcoin-core-dev
13:52 -!- mkarrer [~mkarrer@142.red-83-47-107.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
13:54 < Chris_Stewart_5> In the bitcoin developer reference, when decoding a partial merkle tree it says: Fail if there are unused flag bits—except for the minimum number of bits necessary to pad up to the next full byte.
13:54 < Chris_Stewart_5> I can't seem to actually find this anywhere in Core though -- is this an actual requirement?
13:54 < Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/merkleblock.cpp#L136
13:55 < sipa> line 177
13:59 < Chris_Stewart_5> Hmm I guess I thought it would be in TraverseAndExtract I guess. Thanks 
14:01 -!- mappum [sid43795@gateway/web/irccloud.com/x-cpheoswxhcnmevug] has joined #bitcoin-core-dev
14:05 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev []
14:07 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
14:09 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pjnzxvglwuiqibfo] has joined #bitcoin-core-dev
14:12 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
14:15 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
14:21 < phantomcircuit> while trying to fix 8445 i noticed that pwalletMain is NULL if -disablewallet is passed
14:22 < phantomcircuit> and yet the disablewallet test passes despite there being things doing pwalletMain-> accesses
14:22 < phantomcircuit> sipa: ^
14:22 < phantomcircuit> jonasschnelli: ^
14:22 < phantomcircuit> am i missing something here?
14:23 < gmaxwell> may be due to the compiler rerorginzing things so that those accesses don't happen
14:24 < phantomcircuit> gmaxwell: oooh im dumb
14:24 < phantomcircuit> pwalletMain ? pwalletMain->GetKeyPoolSize() : 0
14:26 -!- shesek [~shesek@bzq-84-110-111-200.red.bezeqint.net] has joined #bitcoin-core-dev
14:26 -!- execut3 [~shesek@bzq-84-110-111-200.red.bezeqint.net] has joined #bitcoin-core-dev
14:28 < gmaxwell> or that
14:44 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]
14:49 -!- murch [~murch@p4FE38BBB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
15:04 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 252 seconds]
15:08 -!- whphhg [whphhg@gateway/vpn/mullvad/x-sqmjxdwfxfftelsw] has quit [Quit: Leaving]
15:08 -!- whphhg [whphhg@gateway/vpn/mullvad/x-tzpquxdbdfmuhhld] has joined #bitcoin-core-dev
15:09 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
15:11 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev
15:12 -!- lextt [~l3xtt@95.215.44.99] has quit [Read error: Connection reset by peer]
15:14 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
15:16 -!- Megaf [~quassel@unaffiliated/megaf] has joined #bitcoin-core-dev
15:16 -!- lextt [~lextt@95.215.44.99] has joined #bitcoin-core-dev
15:33 -!- cryptapus is now known as cryptapus_afk
15:35 < jeremyrubin> Hey, what's the preffered practice for rebasing a PR onto master?
15:36 < jeremyrubin> push -f onto my branch ok?
15:37 < sipa> sure
15:45 -!- Giszmo [~leo@2001:a61:32b9:3501:9822:c139:6c1c:51fc] has quit [Quit: Leaving.]
15:53 -!- FNinTak [~jonhbit@216.133.125.107] has joined #bitcoin-core-dev
16:06 < achow101> what's up with this: https://bitcoin.org/en/alert/2016-08-17-binary-safety
16:06 < sipa> we don't know
16:07 < achow101> so cobra went rogue?
16:07 -!- FNinTak [~jonhbit@216.133.125.107] has quit [Ping timeout: 250 seconds]
16:07 < Lauda> If by rogue, you mean skipping the peer review process, then yes.
16:10 -!- FNinTak [~jonhbit@216.133.125.107] has joined #bitcoin-core-dev
16:10 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
16:15 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
16:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]
16:29 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev
16:36 < phantomcircuit> cfields: is travis broken?
16:36 < phantomcircuit> 8445 passes on my local system but not on travis and the travis failures keep changing
16:37 < cfields> phantomcircuit: unsure, will have a look
16:37 < cfields> achow101: erm, i'd say. no mention of gitian...
16:40 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-vsjmuzfvpelkrvqb] has quit [Quit: Connection closed for inactivity]
16:41 < cfields> phantomcircuit: https://github.com/bitcoin/bitcoin/issues/8532
16:50 < kanzure> jeremyrubin: force-pushing to your branch might be a little rude if anyone has been doing work on top of your branch. if you're pretty sure that's not happening, then go for it.
16:51 < gmaxwell> the question was related to PRs against master. people should not generally be doing work on top of those.
16:51 < gmaxwell> And we will often _require_ people to tidy up their branches before merging in any case.
17:00 -!- murch [~murch@p4FE38BBB.dip0.t-ipconnect.de] has quit [Quit: Leaving.]
17:01 -!- FNinTak [~jonhbit@216.133.125.107] has quit [Quit: Leaving]
17:12 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
17:17 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds]
17:23 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev
17:23 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
17:28 < phantomcircuit> cfields: alrighty then
17:28 < phantomcircuit> gmaxwell: things have been a bit lax on that front recently actually
17:29 < phantomcircuit> personally i strongly prefer that each commit in a pr is itself functional
17:29 < phantomcircuit> we've had a few where that's a commit at the end which fixes a bug in the first commit
17:30 < jcorgan> it is nice to have all commits compile nicely to be able to use git bisect
17:31 < instagibbs> I kind of like to see changes as they are worked on personally, with cleanup at the end. Often force pushes means I can't really track what has changed super easily. But I'm sure that's my lack of foo
17:31 < cfields> phantomcircuit: looking at the rpc tests, i'm not seeing how the caches don't stomp eachother
17:34 < phantomcircuit> instagibbs: the idea is that you do the normal thing with cleanup and then before merge rebase such that the overall change is identical
17:34 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has quit [Quit: Verlassend]
17:40 -!- Megaf [~quassel@unaffiliated/megaf] has quit [Remote host closed the connection]
17:41 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
17:41 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
17:41 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
17:44 < sipa> phantomcircuit: every commit must compile and run tests
17:44 < sipa> phantomcircuit: that's not something a manually verify when reviewing, but i won't ack a PR if i know it isn't the case
17:47 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 250 seconds]
17:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]
17:52 < phantomcircuit> sipa: sure... but there's things where they compile and pass tests and we know them to be broken
17:54 < sipa> ah, that shouldn't be
17:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:05 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
18:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
18:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:27 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
18:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
18:35 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pjnzxvglwuiqibfo] has quit [Quit: Connection closed for inactivity]
18:50 -!- PaulCapestany [~PaulCapes@204.28.124.82] has quit [Quit: .]
18:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
18:52 -!- PaulCapestany [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev
19:09 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
19:11 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:15 -!- dstadulis [~dstadulis@c-73-189-234-152.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:26 -!- pero [~pero@unaffiliated/pero] has joined #bitcoin-core-dev
19:28 -!- pero [~pero@unaffiliated/pero] has quit [Quit: Leaving]
19:32 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has quit [Changing host]
19:32 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev
20:30 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
20:31 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:11 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-omqvecysnhidvdvp] has joined #bitcoin-core-dev
21:12 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:13 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:24 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:38 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
21:39 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
21:42 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]
21:59 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
22:00 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
22:10 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
22:11 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
22:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
22:24 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
22:29 -!- dstadulis [~dstadulis@c-73-189-234-152.hsd1.ca.comcast.net] has quit [Quit: ZZZzzz…]
22:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
22:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
23:38 < wumpus> travis is extremely broken
23:44 < GitHub150> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/733035bdb755...a78f95a976de
23:44 < GitHub150> bitcoin/master fa64306 MarcoFalke: [qa] abandonconflict: Use assert_equal
23:44 < GitHub150> bitcoin/master a78f95a Wladimir J. van der Laan: Merge #8531: [qa] abandonconflict: Use assert_equal...
23:44 < GitHub90> [bitcoin] laanwj closed pull request #8531: [qa] abandonconflict: Use assert_equal (master...Mf1608-qaAssert) https://github.com/bitcoin/bitcoin/pull/8531
23:55 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]
23:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev
23:57 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
23:59 < jonasschnelli> For the binary verification problem, we should have a verification process in Bitcoin-Qt/bitcoin-cli (or maybe an additional tool) that can verify a downloaded binary by downloading the gitian.sigs
23:59 < jonasschnelli> It would require to also produce ECDSA sigs per assets file