--- Day changed Wed Aug 24 2016 00:00 -!- harrymm [~wayne@49.49.138.193] has joined #bitcoin-core-dev 00:03 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 00:08 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 276 seconds] 00:08 < GitHub21> [bitcoin] rebroad opened pull request #8572: Don't effectively blacklist pruned nodes. (master...Don'tBanPrunedNodes) https://github.com/bitcoin/bitcoin/pull/8572 00:08 < GitHub193> [bitcoin] jonasschnelli opened pull request #8573: Set jonasschnellis dns-seeder filter flag (master...2016/08/filter_seed) https://github.com/bitcoin/bitcoin/pull/8573 00:15 < wumpus> midnightmagic: yes, lots of gitian builders this time around, this is great 00:15 < wumpus> (although 0.12.0 had a lot too) 00:16 -!- rubensayshi [~ruben@82.201.93.169] has joined #bitcoin-core-dev 00:16 < sipa> 14 for 0.13.0-linux 00:16 < sipa> i think that's a record 00:17 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:17 < sipa> oh, no, 15 for 0.12.0-linux 00:21 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 00:39 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 00:51 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 00:52 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 01:00 -!- murch [~murch@p4FE3B7EE.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:11 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 01:12 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 01:15 < GitHub21> [bitcoin] jonasschnelli opened pull request #8574: [Wallet] refactor CWallet/CWalletDB/CDB (master...2016/08/bdb_abstraction_2) https://github.com/bitcoin/bitcoin/pull/8574 01:16 < wumpus> sipa: though those accumulated over a longer time 01:16 < wumpus> sipa: very likely 0.13.0 will still be a record 01:16 < sipa> yeah 01:16 -!- JackH [~Jack@79-73-189-132.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 01:19 -!- laurentmt [~Thunderbi@80.215.178.227] has joined #bitcoin-core-dev 01:21 < jonasschnelli> The CWallet/CWalletDB/CDB interleaving is really a mess. I fear nobody will review the just opened refactoring PR. They are much larger then I had originally expected. 01:22 < jonasschnelli> But if we want to add support for a different wallet database format, we need better abstraction of wallet logic, wallet database logic and pure database storage logic 01:22 < jonasschnelli> Somehow I think we need to do this before we add Multi Wallet Support,... 01:24 < wumpus> agree that some refactoring of the wallet code is long due 01:24 < sipa> jonasschnelli: will have a look 01:24 < wumpus> but yes, assuring that it doesnt introduce nasty bugs or funcitonality people are relying on is hard 01:24 < wumpus> +break 01:24 < wumpus> which reminds me we still haven't add the label API to replace the accounts API 01:25 < jonasschnelli> Yes. I try to move the BDB code carefully and keep its behavior (even if it silly sometimes). 01:25 < wumpus> that makes sense for a refactor 01:25 < jonasschnelli> wumpus: We should have a look at your PR 01:25 < jonasschnelli> BTW: travis has failed on walletbackup.py randomly, the PR does not change anything there IMO: https://travis-ci.org/bitcoin/bitcoin/jobs/154141125#L1464 01:26 < jonasschnelli> Will re-trigger travis on that PR 01:26 < wumpus> yes, the code is pretty much outdated and useless at this point, but we should make sure at least the API is what we want 01:26 < gmaxwell> FWIW, phantomcircuit spent basically months with a bunch of wallet refactors pipelined waiting for changes to go in. 01:27 < gmaxwell> If people turn in broken up changes, they get randomly stuck waiting, presumably because few care to review things that don't seem important. If people submit large all at once changes, they get stuck because no one is able to review big changes. 01:27 < wumpus> this is especially true for the wallet 01:28 < jonasschnelli> Indeed. Maybe I should split up the PR in smaller chunks.. 01:28 < wumpus> and, perversely, the refactors would probably make it easier to review changes in the future 01:28 < jonasschnelli> There is a very small PR for those we care: :) https://github.com/bitcoin/bitcoin/pull/8564 01:28 < wumpus> but quite some people get a headache just for looking at the wallet code as it is now, which prevents them from reviewing it, and thus from those (necessary) changes from getting in 01:28 < gmaxwell> what I'm saying is that phantomcircuit did split up his changes into chunks, submitted the first one, then it sat for ages. 01:29 * jonasschnelli will have a look at phantomcircuit PRs 01:29 < wumpus> yes, that's how it has always gone with wallet changes, even CodeShark's multiwallet PR back in the day sat for ages, without useful review or testing 01:29 < gmaxwell> He had more pipelined, but I don't know if he gave up, or if its just because he's been sick that he hasn't PRed more of them since the longest standing went in just recently. 01:30 < gmaxwell> probably the latter, he's not prone to giving up. 01:30 < gmaxwell> :) 01:30 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xyayktavumijmjcn] has joined #bitcoin-core-dev 01:30 < wumpus> it's just difficult to do, I don't have any useful advice for anyone trying unfortunately, as you say both breaking the change up as well as doing a lot at the same time run against barreirs 01:30 < wumpus> changing the consensus code seems easier :) 01:31 < jonasschnelli> I think https://github.com/bitcoin/bitcoin/pull/8445 is ready for merge 01:31 < jonasschnelli> (one of Patricks) 01:31 < wumpus> let's merge it then 01:33 * wumpus is still looking for someone to stand up to be wallet maintainer 01:33 < wumpus> maybe Patrick? 01:33 < GitHub147> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9358893518a1...f9167003d947 01:33 < GitHub147> bitcoin/master e86eb71 Patrick Strateman: Move CWallet::setKeyPool to private section of CWallet 01:33 < GitHub147> bitcoin/master 8680d3a Patrick Strateman: Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet 01:33 < GitHub147> bitcoin/master f916700 Wladimir J. van der Laan: Merge #8445: Move CWallet::setKeyPool to private section of CWallet.... 01:33 < GitHub83> [bitcoin] laanwj closed pull request #8445: Move CWallet::setKeyPool to private section of CWallet. (master...2016-07-01-cwallet-api-cleanup) https://github.com/bitcoin/bitcoin/pull/8445 01:35 < jonasschnelli> I'm happy to co-maintain the wallet. I think I can now understand most of its code (also the silly one) 01:37 < wumpus> thanks, you're very welcome to participate in wallet changes, but I think it'd be good to bring someone else on board 01:37 < wumpus> otherwise you end up with everything on your plate 01:37 < jonasschnelli> Yes. Agree. 01:38 < murch> What responsibilities does being the wallet maintainer entail? 01:38 < wumpus> work on the wallet, do a lot of work on the wallet, and review other people's work on the wallet 01:39 < jonasschnelli> Review PRs, make sure we make progress with the wallet 01:39 < wumpus> and have a very strong clue about the crypto and how the parts interact 01:41 < wumpus> and doesn't get dizzyness and/or headaches or bouts of panic while reading the current wallet code, or changes to it 01:41 < sipa> i'd love to spend time on making bitcoin core function as an SPV client, and make the wallet changes that are necessary 01:41 < wumpus> (as I do) 01:42 < sipa> but i think i have a bit too many other things to do first 01:42 < wumpus> yes, I think you have enough on your plate too 01:42 < murch> Unfortunately, I'm not really familiar with the crypto used in the wallet. I mean, I know in broad strokes what it is supposed to do, but I'd be lying if I said I have a strong clue. 01:42 < wumpus> and you're already maintainer too 01:42 < jonasschnelli> gmaxwell: "cat dnsseed.dump | grep 00000005 | grep " 1 " | wc -l" = 2590 01:42 < GitHub15> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f9167003d947...f12d2b5a8ac3 01:42 < GitHub15> bitcoin/master 7bd5ff4 Christian Barcenas: Trivial: Fix two VarInt examples in serialize.h 01:42 < GitHub15> bitcoin/master f12d2b5 Pieter Wuille: Merge #8560: Trivial: Fix two VarInt examples in serialize.h... 01:42 < sipa> yes, i'm not volunteering for the wallet maintainer position... just saying i'd like to work more on it :) 01:42 < GitHub188> [bitcoin] sipa closed pull request #8560: Trivial: Fix two VarInt examples in serialize.h (master...fix_varint_examples) https://github.com/bitcoin/bitcoin/pull/8560 01:42 < jonasschnelli> I guess there are plenty of node signaling NODE_BLOOM, though not sure if they are really offering the service 01:43 < sipa> can i have ACK on 8451? 01:43 < jonasschnelli> sipa: Not sure if the SPV mode would be utterly complex. 01:43 < sipa> jonasschnelli: it won't be, but there are a few subtle changes to make 01:43 < jonasschnelli> A first step would be to allow the wallet to run in mode without mempool knownlage 01:44 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 01:44 < jonasschnelli> Then a way how the wallet can "ask for blocks",... main.cpp needs to download them, check headers (SPV pure PoW check) and passes the txes through the SyncWithWallet signal 01:44 < wumpus> I don't like #8451 very much, it seems a step the wrong way around 01:45 < gmaxwell> using undefined behavior isn't acceptable however. 01:45 < jonasschnelli> sipa: what are the benefits of 8451? 01:45 < wumpus> no, it's not, but that dosn't mean I have to like the solution 01:46 < sipa> jonasschnelli: fixing our code, which is currently undefined (as in: the compiler is allowed to make it fire all the nukes) 01:46 < sipa> wumpus: understood, and agree 01:46 < wumpus> I really like the idea of having a transaction-set-ins-stone object, as well as a transaction builder (ImmutableTransaction). We should have that for more things, such as Script 01:46 < sipa> but i think a better solution is too far off (modifying the serializing framework to support constructing-while-deserializing) 01:47 < sipa> or encapsulating all fields in CTransaction 01:47 < wumpus> eh s/ImmutableTransaction/MutableTransaction 01:47 < wumpus> it separates building and checking at aconceptual level 01:47 < gmaxwell> wumpus: by builder, do you imagine that a transaction would always be built in one atomic step? 01:48 < sipa> hmm, maybe there is a possibility to change all the places where CTransaction is deserialized to first deserialize into a CMutableTransaction, and then convert to a CTransaction? 01:48 < sipa> there may not be very many of those 01:48 < wumpus> gmaxwell: no. Not necessarily, but it is a "MutableTransaction" scaffold until it no longer needs to be one 01:48 < gmaxwell> gotcha. 01:48 < sipa> let's try. 01:49 < gmaxwell> Thats really what I thought the intent was there in the past. 01:49 < wumpus> sipa: sounds quite sensible 01:49 < wumpus> the serialization framework *needs* a mutable object,so give it one 01:49 < gmaxwell> (in particular making CTransaction always fully immutable allows changing its representation to an efficient one) 01:49 < wumpus> gmaxwell: exactly! 01:49 < sipa> gmaxwell: it requires more than that though 01:50 < sipa> (also encapsulating its fields) 01:50 < gmaxwell> I know. 01:50 < wumpus> sipa: sure, it's only one step 01:50 < gmaxwell> (as in one malloc per CTransaction, and only one-- oh to dream) 01:50 < wumpus> that's what I meant with that making Transaction mutable is a step in the wrong direction 01:50 < wumpus> just a step, not armageddon 01:51 < gmaxwell> well, I think in C++ we shouldn't equat const/non-constness with immutability. They're partially orthorgonal concepts. 01:51 < gmaxwell> er equate* 01:51 < wumpus> I agree, though const helps enforce that at the compiler level 01:51 < sipa> ugh. 01:52 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:52 < gmaxwell> oh no, sipa found something awful, I can tell. 01:52 < sipa> no more CTransaction::operator= or CTransaction::swap 01:52 < wumpus> uh oh 01:52 < wumpus> hmm. atomic replacement is ungood too? 01:53 < wumpus> when you regard CTransaction as a reference to a transaction, those may be acceptable 01:53 < wumpus> otherwise, yes, it's mutating 01:55 < wumpus> though the future 'CTransaction needs one malloc' would imply it has one pointer, which could trivially be swapped with another one 01:56 < wumpus> assignment would still need copying, or a shared pointer 01:56 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 01:56 < gmaxwell> wumpus: well no, because a single malloced chunk could have pointers internally... so you can't say it implies it alone 01:57 < gmaxwell> though obviously it would be better if it didn't. :) 01:57 < wumpus> gmaxwell: oh, sure, then you'd need to do some more accounting 01:57 < wumpus> I don't mean 'atomic' in the threading sense 01:58 < gmaxwell> I was reading 'trivially swapped' meaning not needing any deep operations. 01:58 < wumpus> it doesn't need any deep operations, just swap the surface pointers 01:58 < wumpus> if there are more, pointing inside the structure, well swap all of them 02:00 < wumpus> but if you have all pointers pointing inside the stucture as part of the malloc'ed structure itself you can easily keep it to one pointer 02:01 < wumpus> depends on how much indirection is a performance bottleneck I guess... 02:04 < gmaxwell> wumpus: fyi there was a thread on bitcointalk recently where someone profiled bitcoin core, and was asking why we weren't using faster sha2 because it was 35% in their benchmarks. I pointed them to your work with the SIMD sha2. They seemed to think that there would be 10x speedups, so I was sad to have to disappoint them. :) 02:05 < wumpus> gmaxwell: yeah it was disappointing :( would still make some sense to integrate that, for a bit of speedup, but the overall gains were so little it demotivated me at least 02:06 < gmaxwell> they were clearly measurable at least. 02:06 -!- laurentmt [~Thunderbi@80.215.178.227] has quit [Quit: laurentmt] 02:06 < wumpus> but if anyone wants to continue that work they're welcome to, of course 02:06 < gmaxwell> Thats something to be proud of, even if they aren't huge. They'll become more important as everything else gets optimized. 02:07 < wumpus> true 02:08 < wumpus> which reminds me of #8524 02:08 < gmaxwell> he also commented on the leveldb crc 02:08 < wumpus> hah :) 02:09 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 02:09 < MarcoFalke> jonasschnelli: Can you explain? 02:10 < MarcoFalke> we don't have auto stretch in master 02:10 < MarcoFalke> I think 02:10 < jonasschnelli> MarcoFalke: let me look at the code.. 02:11 < jonasschnelli> It just looks strange (part of the row don't use full width) 02:11 < jonasschnelli> And I think its avoidable 02:11 < wumpus> did that once, too https://github.com/laanwj/bitcoin/commit/431c1b987b34589f32f4c2d0ee0f2571ba70e349 I don't really know where that went, looks like I never did any high-level performance measurements, only benchmark of the CRC function itself 02:12 < MarcoFalke> ok, let me check... 02:12 < jonasschnelli> MarcoFalke: https://github.com/bitcoin/bitcoin/pull/8463/files#r76021780 02:13 -!- Megaf [~quassel@unaffiliated/megaf] has joined #bitcoin-core-dev 02:13 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 02:13 < wumpus> but the CRC instruction is 7-8 times faster than leveldb's crc implementatino on Haswell: https://github.com/laanwj/crcbench 02:14 < jonasschnelli> MarcoFalke: 84+100+170+290+110+100+100 = 954, window width = 1000px, some padding 02:14 < wumpus> and it works, I verified it's the same ariant of CRC (crc32c) and has the same output 02:15 < wumpus> what is lacking/to be done: CPU detection at startup, replace those functions by function pointers, based on the best implementation for detected CPU 02:16 < wumpus> in the case of leveldb maybe trying to upstream it 02:17 < jonasschnelli> wumpus: nice work! 02:17 < wumpus> thanks :) 02:17 < jonasschnelli> Not sure hoe active upstream is 02:17 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 02:17 * wumpus should finish more projects instead of starting more 02:17 < wumpus> agreed, that's why that's a 'maybe', normally it'd be a requirement 02:18 < jonasschnelli> heh... yes. 02:20 < wumpus> https://github.com/google/leveldb: last update 13 days ago - it's less dead than univalue's upstream at least 02:20 < jonasschnelli> Indeed. :-) 3xpings from paveljanik 02:21 < jonasschnelli> But UniValue upstream is now bitcoin-core/univalue, right? 02:21 < wumpus> though I think all of recent leveldb changes have been OS-support changes, not so much consequential database performance changes, but I haven't looked very recently 02:21 < MarcoFalke> No, I think we keep bitcoin-core/stuff only for bitcoin-core related patches 02:21 < wumpus> (or correctness fixes for that matter) 02:22 < wumpus> jonasschnelli: well, effectively, for bitcoin it is. I think we're the only client for univalue anyhow. 02:22 < jonasschnelli> Digital Bitbox also depends on UniValue. But thats it I guess. 02:23 < jonasschnelli> IMO if jeff is not maintaining it, we should take care about bitcoin-core/UniValue 02:23 < paveljanik> first, we should ask jeff. 02:23 < wumpus> I tend to agree, though I can't spend much time being maintainer of yet another project 02:23 < MarcoFalke> pff, it is always a mess to have several repos on github and no one knows whcih one is maintained 02:24 < wumpus> bitcoin-core's is maintained, in the sense that it will always be the best version for our use 02:25 < wumpus> well I know only one thing for sure: Jeff's isn't 02:25 < wumpus> I'll merge patches when necessary for bitcoin or general performance/correctness 02:25 < wumpus> which reminds me I still need to cean up my univalue fuzzing framework some time 02:26 < wumpus> (and do the necessary build system changes, analogous to Patrick's https://github.com/bitcoin/bitcoin/pull/7940) 02:27 < gmaxwell> I don't know if andytoshi published his test harness. He rewrote a functional equivilent to univale in rust, then wrote a test harness that compared the two against each other and found a number of bugs in univale (though I believe they were all already bugs wumpus had found). 02:27 * sipa tries compiling after making CTransaction deserializable-at-construct-time 02:27 < gmaxwell> I think thats a really really useful testing technique for a parser. 02:28 < wumpus> jonasschnelli: in any case univalue is a good choice when dealing with bitcoind client-side from C or C++, I don't think using it is a bad chocie, maybe it just needs very little maintenance 02:28 < wumpus> gmaxwell: yes having two implementations and comparing them is a good way of testing 02:34 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 02:34 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 02:38 < wumpus> cfields_: we should start working at replacing boost::chrono too :) https://github.com/zcash/zcash/issues/1241 02:38 < gmaxwell> I got cancer from just looking at that backtrace. 02:39 < gmaxwell> I've run core in valgrind quite a bit and not seen those errors. 02:39 < gmaxwell> not that I doubt them. 02:44 < paveljanik> Can anyone please explain to me, what is the purpose of this line? https://github.com/bitcoin/bitcoin/blob/master/src/qt/recentrequeststablemodel.h#L34? 02:55 < wumpus> gmaxwell: boost is so difficult to debug, with all the c++ template magic 02:55 < wumpus> gruesomely overdesigned, even for something like time getting/conversion 02:56 < wumpus> paveljanik: I think it is spurious, don't take my word for it though 02:57 < jonasschnelli> paveljanik: agree with wumpus 02:57 < jonasschnelli> How could such code end up here in the first place. :-) 02:58 < paveljanik> I think it was cut&pasted... 02:58 < paveljanik> the same line is present 6 times in our sources... 02:59 < wumpus> it makes sense to have (de)serialization code there, as those entries are (de)serialized 02:59 < wumpus> paveljanik: but the big question is, does gcc even generate code for them :D 03:00 < wumpus> it would only make sense if there is a local veriable nVersion 03:00 < GitHub158> [bitcoin] ajtowns opened pull request #8575: leveldb: generate lib independent of locale sort (master...leveldb-locale-reproducible) https://github.com/bitcoin/bitcoin/pull/8575 03:00 < wumpus> which there isn't, so it'sa self-assign 03:01 < wumpus> EH. Well there is, one of the arguments 03:01 < paveljanik> yes 8) 03:02 < wumpus> so take care that if nVersion is used after that line, you can't remove the line (without changing the use of nVersion to this->nVersion) 03:02 < paveljanik> and this is where I'm lost ;-) 03:02 < wumpus> having the structure field have the same name as a parameter is unadvisable here, as it causes confustion 03:02 < wumpus> confusion* 03:03 < wumpus> I think I get it 03:03 < paveljanik> nVersion is not used at all after this line in all 6 cases. 03:03 < wumpus> the same function is used for reading and writing 03:03 < wumpus> on writing, this->nVersion is written to the serialization 03:03 < wumpus> on reading, this->nVersion is read from the serialization, then assigned to nVersion 03:04 < wumpus> but why? nVersion argument to Serialization is of a different sort than nVersion used internally 03:04 < wumpus> .?!?!?? core dump 03:05 < wumpus> I know I just copied that code, I can't have written it :) 03:05 < MarcoFalke> The code is copied from the initial git commit 03:05 < paveljanik> we have to ask the "TwoSpaces" man ;-) 03:05 < MarcoFalke> ask satoshi or something 03:05 < wumpus> I'd be very careful with touching it though or the whole pyramid may come down 03:05 < wumpus> hah yes 03:05 < paveljanik> yes, definitely 03:07 < wumpus> this is why I wondered whether gcc generates code for it in the first place 03:07 < wumpus> "-*- sipa tries compiling after making CTransaction deserializable-at-construct-time", that was his last comment and then he went silent, ominous 03:07 < gmaxwell> haha 03:09 < phantomcircuit> gmaxwell: im waiting on 8450 before making more changes 03:10 < phantomcircuit> the next one is to change the accounting tests, but that needs to actually change the tests themselves 03:10 < wumpus> are you waiting on that one? let's merge it, it's a test change and two acks already 03:10 < phantomcircuit> so it's a bit more involved 03:10 < phantomcircuit> (basically im going to be removing like 50% of the tests since they're nonsensical) 03:11 < GitHub65> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f12d2b5a8ac3...21857d2bf746 03:11 < GitHub65> bitcoin/master 25400c4 Patrick Strateman: Account wallet feature RPC tests. 03:11 < GitHub65> bitcoin/master 9578333 Patrick Strateman: Remove rpc_wallet_tests.cpp 03:11 < GitHub65> bitcoin/master 21857d2 Wladimir J. van der Laan: Merge #8450: [Test] Replace rpc_wallet_tests.cpp with python RPC unit tests... 03:11 < phantomcircuit> wumpus: yeah i was waiting 03:11 < GitHub112> [bitcoin] laanwj closed pull request #8450: [Test] Replace rpc_wallet_tests.cpp with python RPC unit tests (master...2016-08-03-remove-rpc-wallet-tests) https://github.com/bitcoin/bitcoin/pull/8450 03:11 < phantomcircuit> great there's now only a single thing external to CWallet using CWalletDB which is the accounting_tests.cpp 03:11 < phantomcircuit> which mostly make no sense 03:11 < wumpus> why does it use CWalletDB? 03:11 < wumpus> or maybe better not to ask, sorry 03:12 < wumpus> I'm sure accounting tests can be done with just a CWallet object 03:12 < phantomcircuit> indeed better not to ask (it's adding the accounting entries directly...) 03:14 < phantomcircuit> walletdb.ListAccountCreditDebit is the culprit really 03:15 < wumpus> oh, crap related to the account sytem 03:15 < sipa> accounting details are the only thing from wallet db we don't load into memory 03:17 < wumpus> if we only removed that functionality already, we could have effortlessly gotten rid of this 03:24 < paveljanik> wumpus, qt_libbitcoinqt_a-recentrequeststablemodel.o is different when this line is commented, so it is used... 03:25 < gmaxwell> wumpus: https://bitcoin.org/laanwj-releases.asc should probably come with the signature of that key by your personal key. Keyserver retention of keys that are leafs isn't always all that good. 03:25 < paveljanik> but I think this line has no meaning in the read case as the value is assigned to the shadowed nVersion, argument one, and discarded at the end... 03:34 < wumpus> gmaxwell: yes, good idea 03:36 -!- JZA [JZA@gateway/shell/elitebnc/x-nozaowfwouhrmcnf] has quit [Excess Flood] 03:39 < wumpus> gmaxwell: do I need to do anything special for that? I just did gpg --export --armor 0x90C8019E36C2E964 > ../websites/bitcoin.org/laanwj-releases.asc and git sees no difference 03:41 < gmaxwell> hm. maybe I'm wrong and it has it already, let me check. 03:42 < gmaxwell> it does, I'm sorry to have wasted your time. 03:42 < wumpus> ok, well good to know 03:43 < gmaxwell> someone in #bitcoin said it didn't, which primed me to conclude it didn't when I looked. :) 03:45 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: gtg] 03:55 -!- harrymm [~wayne@49.49.138.193] has quit [Ping timeout: 264 seconds] 03:56 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 03:56 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:04 -!- JZA [JZA@gateway/shell/elitebnc/x-oemgpzvxfynbjwuy] has joined #bitcoin-core-dev 04:06 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:09 < wumpus> should probably update my key at bitcoin.org with all the new signatures though 04:09 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 04:12 -!- harrymm [~wayne@223.207.216.165] has joined #bitcoin-core-dev 04:40 -!- cryptapus [~cryptapus@87.254.202.219] has joined #bitcoin-core-dev 04:40 -!- cryptapus [~cryptapus@87.254.202.219] has quit [Changing host] 04:40 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:55 -!- JZA [JZA@gateway/shell/elitebnc/x-oemgpzvxfynbjwuy] has quit [Excess Flood] 04:56 < GitHub145> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/21857d2bf746...85d4e21a6178 04:56 < GitHub145> bitcoin/master c911035 djpnewton: Add default port numbers to REST doc 04:56 < GitHub145> bitcoin/master 85d4e21 Wladimir J. van der Laan: Merge #8567: Add default port numbers to REST doc... 04:57 < GitHub2> [bitcoin] laanwj closed pull request #8567: Add default port numbers to REST doc (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8567 05:00 < GitHub112> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/85d4e21a6178...62a5a8a01866 05:00 < GitHub112> bitcoin/master fa8dd78 MarcoFalke: [qt] Remove Priority from coincontrol dialog 05:00 < GitHub112> bitcoin/master 62a5a8a Jonas Schnelli: Merge #8463: [qt] Remove Priority from coincontrol dialog... 05:00 < GitHub94> [bitcoin] jonasschnelli closed pull request #8463: [qt] Remove Priority from coincontrol dialog (master...Mf1608-qtPrio) https://github.com/bitcoin/bitcoin/pull/8463 05:12 < jonasschnelli> MarcoFalke, paveljanik: interested in testing an ACK/NACK https://github.com/bitcoin/bitcoin/pull/7826? 05:16 < paveljanik> jonasschnelli, well, Marco's suggestion to add "how to test" would be great ;-) I'll test compilation now at least. 05:16 < paveljanik> I do not use GUI much... 05:18 < jonasschnelli> Ah. Right. Also, I overlooked his point with non-std transactions.. will try to fix 05:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Client Quit] 05:32 -!- aalex [~aalex@64.187.177.58] has quit [Read error: Connection reset by peer] 05:33 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 05:36 -!- JZA [JZA@gateway/shell/elitebnc/x-yunatrarwksypxwk] has joined #bitcoin-core-dev 05:41 < sipa> making CTransaction actually immutable is a huge rathole... 05:42 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:44 < sipa> 3 hours straight of fixing compile errors, and now the tests don't run :) 05:44 < sipa> notably, almost all the compile errors were in the compact blocks code and in wallet tests 05:47 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has quit [] 05:49 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 05:55 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xyayktavumijmjcn] has quit [Quit: Connection closed for inactivity] 05:57 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 06:02 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has quit [] 06:02 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:05 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds] 06:23 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 06:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-lfdssrqvfstmpume] has joined #bitcoin-core-dev 06:31 -!- interseption [~baldor@175.100.145.22] has joined #bitcoin-core-dev 06:32 < paveljanik> FWIW, Jeff just merged one univalue PR... 06:37 -!- interseption [~baldor@175.100.145.22] has quit [Quit: leaving] 06:49 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 06:50 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:50 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 06:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:52 -!- TomMc [~tom@unaffiliated/tommc] has quit [Quit: WeeChat 1.3] 06:54 -!- jannes [~jannes@178.132.211.90] has quit [Ping timeout: 244 seconds] 06:57 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 06:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 07:00 < jonasschnelli> Oh. Bitcoin-Core 0.13.0 does not run on OSX 10.7, sanity check issue 07:01 < jonasschnelli> which means ECC or glibc sanity check are firing... 07:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:16 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 07:16 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 07:19 -!- harrymm [~wayne@223.207.216.165] has quit [Ping timeout: 260 seconds] 07:23 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 07:24 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:24 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 07:25 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 07:27 -!- cryptapus_ is now known as cryptapus 07:28 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 07:34 -!- harrymm [~wayne@49.49.73.252] has joined #bitcoin-core-dev 07:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Client Quit] 08:01 -!- skyraider [uid41097@gateway/web/irccloud.com/x-hlqiypxksfnfmtjx] has joined #bitcoin-core-dev 08:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:08 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has joined #bitcoin-core-dev 08:10 -!- Megaf [~quassel@unaffiliated/megaf] has quit [Ping timeout: 244 seconds] 08:21 < GitHub13> [bitcoin] MarcoFalke opened pull request #8578: [test] Remove unused code (master...Mf1608-qaUnused) https://github.com/bitcoin/bitcoin/pull/8578 08:51 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 08:52 < sipa> wumpus: ok, tests run; ~400 lines changed 08:53 -!- laurentmt [~Thunderbi@80.215.178.227] has joined #bitcoin-core-dev 08:54 < sipa> i'm not sure if i dare trying to sync 08:54 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: gtg] 08:54 -!- laurentmt [~Thunderbi@80.215.178.227] has quit [Client Quit] 08:56 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: This computer has gone to sleep] 08:57 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 09:01 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:32 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:34 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Ping timeout: 244 seconds] 09:35 < sipa> wumpus, gmaxwell: so, i think it works, but there is one giant uglyness 09:35 -!- rubensayshi [~ruben@82.201.93.169] has quit [Read error: Connection reset by peer] 09:35 < sipa> you can't modify the first transaction in a std::vector without destroying the entire bector 09:35 < sipa> which is needed in some of the mining code 09:36 < sipa> two possible solutions: copy the entire transaction set of a block (that's a deep copy, even...) 09:36 < sipa> or deconstruct and reconstruct the coinbase in-place using placement new 09:36 < sipa> (which is incredibly ugly, but i think well-defined) 09:37 < GitHub185> [bitcoin] MarcoFalke opened pull request #8579: Performance: Prefer prefix operator for non-primitive types (master...Mf1608-perfIter) https://github.com/bitcoin/bitcoin/pull/8579 09:39 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 09:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 09:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:47 < GitHub18> [bitcoin] sipa opened pull request #8580: Make CTransaction actually immutable (master...pain) https://github.com/bitcoin/bitcoin/pull/8580 09:58 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 09:58 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has quit [Client Quit] 10:02 -!- skyraider [uid41097@gateway/web/irccloud.com/x-hlqiypxksfnfmtjx] has quit [Quit: Connection closed for inactivity] 10:12 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 10:17 < MarcoFalke> (master...pain) 10:17 < MarcoFalke> lol 10:28 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 10:30 < GitHub45> [bitcoin] MarcoFalke opened pull request #8581: [wallet] rpc: Drop misleading option (master...Mf1608-walletDropRpc) https://github.com/bitcoin/bitcoin/pull/8581 10:34 -!- zooko [~user@73.95.137.67] has joined #bitcoin-core-dev 10:35 < arubi> MarcoFalke, <3 "swinging the (block)chain.." 10:36 < sipa> MarcoFalke: it was painful! 10:36 < MarcoFalke> There is more pain to come 10:36 < MarcoFalke> I suggest you don't look at the travi result 10:37 < sipa> already on it 10:37 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 10:38 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:42 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 244 seconds] 10:42 -!- harrymm [~wayne@49.49.73.252] has quit [Ping timeout: 265 seconds] 10:56 -!- zooko [~user@73.95.137.67] has quit [Remote host closed the connection] 10:56 -!- harrymm [~wayne@171.5.188.243] has joined #bitcoin-core-dev 10:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 11:00 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:07 -!- mkarrer [~mkarrer@159.red-83-47-122.dynamicip.rima-tde.net] has quit [] 11:30 -!- JZA [JZA@gateway/shell/elitebnc/x-yunatrarwksypxwk] has quit [Ping timeout: 250 seconds] 11:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 11:39 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 11:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:47 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 11:50 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 11:50 -!- Cheeseo [~x@c-174-54-219-36.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 11:50 -!- Cheeseo [~x@c-174-54-219-36.hsd1.pa.comcast.net] has quit [Changing host] 11:50 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 11:55 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 12:29 -!- Megaf [~quassel@unaffiliated/megaf] has joined #bitcoin-core-dev 12:31 -!- Cheeseo [~x@c-174-54-219-36.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 12:31 -!- Cheeseo [~x@c-174-54-219-36.hsd1.pa.comcast.net] has quit [Changing host] 12:31 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 12:32 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 12:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:52 < cfields_> wumpus: yes, boost::chrono is very much in my sights. Got to dump boost::condition_variable first, though. 12:53 < cfields_> wumpus: I'm making headway on killing off the interruptible threads. I slashed a bunch of them last week, but got distracted with something else. 12:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 12:58 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 258 seconds] 13:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:08 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 13:13 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 264 seconds] 13:20 -!- nibor [~nibor@185.9.34.66] has joined #bitcoin-core-dev 13:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 13:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 14:02 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 14:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:31 -!- Megaf [~quassel@unaffiliated/megaf] has quit [Ping timeout: 244 seconds] 14:40 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has joined #bitcoin-core-dev 14:50 -!- cryptapus_afk is now known as cryptapus 14:51 -!- whphhg [whphhg@gateway/vpn/mullvad/x-jgpugtgpgykfwwbp] has quit [Quit: Leaving] 14:51 -!- whphhg [whphhg@gateway/vpn/mullvad/x-lhemvrhoowbzbaqf] has joined #bitcoin-core-dev 14:51 -!- whphhg [whphhg@gateway/vpn/mullvad/x-lhemvrhoowbzbaqf] has quit [Remote host closed the connection] 14:51 -!- whphhg [whphhg@gateway/vpn/mullvad/x-sdunvtgykxwvumsz] has joined #bitcoin-core-dev 14:52 -!- cryptapus is now known as cryptapus_afk 14:53 -!- JZA [JZA@gateway/shell/elitebnc/x-idavvrwllxfepbwj] has joined #bitcoin-core-dev 15:05 -!- spudowiar [~spudowiar@unaffiliated/spudowiar] has quit [Quit: Leaving.] 15:06 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 15:22 -!- murch [~murch@p4FE3B7EE.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 15:27 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 15:28 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 15:42 -!- tom3 [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 15:55 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 15:55 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 15:55 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 15:55 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 16:00 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 260 seconds] 16:21 -!- tom3 [~tom@unaffiliated/tommc] has quit [Ping timeout: 276 seconds] 16:26 < kanzure> wumpus: is there an issue or pull request for http/2 things? 16:26 -!- JZA [JZA@gateway/shell/elitebnc/x-idavvrwllxfepbwj] has quit [Excess Flood] 16:27 < kanzure> wumpus: specifically i am wondering what you meant by "http streaming" 16:28 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 16:42 -!- harrymm [~wayne@171.5.188.243] has quit [Read error: Connection reset by peer] 16:43 -!- belcher [~user@unaffiliated/belcher] has quit [Quit: Leaving] 16:59 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 17:00 -!- harrymm [~wayne@171.5.188.243] has joined #bitcoin-core-dev 17:00 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:04 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 17:04 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 17:08 -!- pedrobranco [~pedrobran@167.225.61.94.rev.vodafone.pt] has quit [Ping timeout: 250 seconds] 17:26 -!- achow101 [~achow101@pool-108-2-70-199.phlapa.fios.verizon.net] has quit [Quit: Leaving] 17:40 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-darlkygeeqfouneq] has quit [Quit: Connection closed for inactivity] 17:44 -!- harrymm [~wayne@171.5.188.243] has quit [Quit: Leaving.] 17:45 -!- harrymm [~wayne@171.5.188.243] has joined #bitcoin-core-dev 17:53 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Remote host closed the connection] 18:00 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 18:12 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 18:19 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 18:44 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 18:44 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 18:45 -!- justanotheruser [~Justan@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:57 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 19:05 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-lfdssrqvfstmpume] has quit [Quit: Connection closed for inactivity] 19:13 -!- slackircbridge [~slackircb@45.55.41.36] has quit [Remote host closed the connection] 19:13 -!- slackircbridge [~slackircb@45.55.41.36] has joined #bitcoin-core-dev 19:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 19:24 < GitHub109> [bitcoin] rebroad opened pull request #8583: Show XTHIN in GUI (master...ShowXTHINinGUI) https://github.com/bitcoin/bitcoin/pull/8583 19:34 -!- tom3 [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 19:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:36 -!- achow101 [~achow101@pool-108-2-70-199.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 19:37 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:37 < achow101> There appears to be a problem with verifying the email that wladimir sent for announcing the release key. See https://bitcointalk.org/index.php?topic=1596294.msg16030908#msg16030908 19:39 < phantomcircuit> indeed the signature is bad when you copy/paste from the website thing 19:40 < phantomcircuit> the actual email is correct though 19:40 -!- Samdney [~Samdney@dyn-ant666999.hawo.ipv6.uni-erlangen.de] has left #bitcoin-core-dev ["Verlassend"] 20:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:09 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:27 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 20:30 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-ncvmplahvpivbtoo] has joined #bitcoin-core-dev 20:30 -!- harrymm [~wayne@171.5.188.243] has quit [Ping timeout: 276 seconds] 20:46 -!- harrymm [~wayne@171.5.179.111] has joined #bitcoin-core-dev 20:59 -!- achow101 [~achow101@pool-108-2-70-199.phlapa.fios.verizon.net] has quit [Read error: Connection reset by peer] 21:08 < GitHub124> [bitcoin] pstratem opened pull request #8585: Remove last caller of IncOrderPosNext (master...2016-08-24-cwallet-incorderposnext) https://github.com/bitcoin/bitcoin/pull/8585 21:08 -!- tom3 [~tom@unaffiliated/tommc] has quit [Ping timeout: 244 seconds] 21:09 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 21:10 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 21:14 < phantomcircuit> can someone cancel all those travis jobs 21:14 < phantomcircuit> sipa: ^ 21:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:39 < jl2012> wumpus: please do not include any email address within a PGP signed message. The signature is invalid because the "@" is replaced by "at": https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2015-June/009045.html 21:40 < jl2012> achow101, phantomcircuit: s/ at /@/ and you will have a good signature 21:45 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 22:10 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:11 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:15 -!- fengling [~fengling@58.135.95.136] has quit [Ping timeout: 240 seconds] 22:48 -!- fengling [~fengling@58.135.95.136] has joined #bitcoin-core-dev 22:50 < luke-jr> sigh, can't we just flip a switch so the ML sw doesn't edit it? :/ 22:55 < kanzure> perhaps that's a "feature" enforced by linuxfoundation (which also doesn't make sense-- are they not signing email?) 22:59 < wumpus> I don't think I'm gonig to send asignedmessage with release announcement again, too many snags 22:59 < wumpus> the annouunce mailing list mutillated initial spaces converted to non-breaking spaces, \# converted to # 22:59 < wumpus> the -dev mailing list malformed the message in digest mode (which can't be disabled) 23:00 < wumpus> and now @'s are verboten too? 23:00 < wumpus> meh :-) 23:02 < wumpus> as if using GPG itsels isn't enough of a monster to get right (what, your key is only 2048 bits!) 23:03 < wumpus> sending a link to a .asc on a server may work 23:05 * wumpus first creates a gpg release mail signing key of 65537 bits 23:05 < wumpus> or maybe a bunch of sed scripts with transformations before validation 23:06 < paveljanik> I think we should abandon GPG and Bitcoin sign everything... 23:06 < wumpus> if only it was all GPG's fault 23:07 < paveljanik> and mailing lists ;-) Of course :-) 23:07 < wumpus> hehe 23:07 < paveljanik> sending announcements via OP_RETURN 8) 23:07 < paveljanik> think a bit of it... 23:08 * luke-jr glares. 23:08 < Lightsword> we could just upload the release itself using OP_RETURN’s :P 23:09 * Lightsword hides 23:09 < wumpus> in any case the release announcement doesn't need to be signed, people should verify the SHA256SUMS.asc tha tcomes *wth* the rekease 23:09 < wumpus> I tend to sign important mails to the mailing list, but this just created a diversion 23:10 < wumpus> verifying the release email itself does nothing, it provides no security, the binaries *at* the link may still be tampered with 23:11 < luke-jr> hm, that's a good point. this doesn't just screw up release mail, it screws up even when we want to sign discussion messages 23:15 < wumpus> would be nice if the archive had a 'RAW' button like github 23:15 < wumpus> that gives you the original text of the message, to paste into gpg 23:16 < wumpus> then again, the anti-@ 'feature' mentioned by jl2012 is probably against spam, so I doubht they'll disable that transformation. They may disable all others though. 23:18 < jl2012> or you may just use an attachment 23:21 < wumpus> put the text in an attachment? fullsigning the mail and putting the signature in the attachment would work worse because any footers added will invalidate it too 23:26 < gmaxwell> wumpus: just send the whole thing ascii armored. 23:27 < wumpus> gmaxwell: that'd work! 23:27 < wumpus> can't find any problems with that, it's what ASCII armoring is supposed to protect against. I guess it will generate no @, no # and doesn't depend on spaces 23:28 < wumpus> people without GPG can't read it anymore, but who cares, they don't take security seriously so shouldn't be using bitcoin in the first place right :) 23:31 * wumpus still remembers uuencode 23:34 < wumpus> GPG base64 characters are A-Za-z0-9+/= 23:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:44 -!- Squidicc [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 23:48 -!- Squidicuz [~squid@pool-173-48-102-116.bstnma.fios.verizon.net] has quit [Ping timeout: 244 seconds] 23:57 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev