--- Day changed Tue Sep 20 2016 00:37 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Quit: Quit] 00:37 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 00:44 -!- go1111111 [~go1111111@104.232.116.217] has quit [Ping timeout: 244 seconds] 00:50 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Read error: Connection timed out] 00:51 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 00:53 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 00:58 < wumpus> gmaxwell: that's useful to know but IMO an issue for another time and should not hold up progress on 8753. If only 32kb is available the first arena will be 32kb, which means it will at least use everything allotted to it. We coudl add a warning to the log in that case I guess but the only solution is to a) use a distribution with sane defaults b) change the ulimits 00:58 -!- go1111111 [~go1111111@104.232.116.217] has joined #bitcoin-core-dev 00:59 < jonasschnelli> Anyone interested in reviewing/acking https://github.com/bitcoin/bitcoin/pull/7783 (nested commands for Qt), and https://github.com/bitcoin/bitcoin/pull/8371 (out-of-sync info layer)? 00:59 < jonasschnelli> Getting them in asap leave enough time to polish them for 0.14 01:00 < wumpus> I don't know exactly why it uses so much locked memory, I do know that the usage is about 50% less with 8753, so it's on the right track to improving things 01:01 < gmaxwell> wumpus: I wouldn't consider suggesting delaying that PR. 01:01 < wumpus> this makes it easier to figure out though, at least more statistics could be addede to getmemoryinfo 01:01 < wumpus> e.g. number of allocated chunks may be useful 01:01 < wumpus> could even use standard heap profiling techniques now such as storing the traceback for every alloc 01:03 < GitHub102> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d8b4b631c5be...82eacc786d8d 01:03 < GitHub102> bitcoin/master 0766d1c isle2983: [copyright] add MIT license headers to .sh scripts where missing... 01:03 < GitHub102> bitcoin/master 82eacc7 Wladimir J. van der Laan: Merge #8700: [copyright] add MIT license headers to .sh scripts where missing... 01:03 < GitHub147> [bitcoin] laanwj closed pull request #8700: [copyright] add MIT license headers to .sh scripts where missing (master...sh-copyright) https://github.com/bitcoin/bitcoin/pull/8700 01:03 < gmaxwell> how many keys did your 300k-mlockedmemory wallet have? 01:05 < wumpus> let me see. gah getwalletinfo is hanging 01:05 < wumpus> "keypoolsize": 10000, 01:05 < gmaxwell> well.. 300k ~= 10000*32 01:06 < wumpus> yes :) 01:06 < gmaxwell> It would be sad if we successfully get N bytes of locked ram, use it to store X encrypted keys, then when decrypting the decrypted keys end up in non-locked ram. 01:07 < wumpus> it's not an encrypted wallet 01:07 < wumpus> but yes that'd be sad, I don't think it's necessary to use locked ram for encrypted keys? 01:08 < wumpus> I mean it's the same data as is in wallet.dat anyhow 01:08 < gmaxwell> I'd guess we should only put the master key and unencrypted keys in locked ram. And if the wallet is encrypted then we should need very little locked ram, since we really only need to have one key actually decrypted at a time. 01:08 < wumpus> this would only be an issue if you have an encrypted disk but not encrypted swap 01:08 < wumpus> in which case your setup is stupid 01:09 < gmaxwell> wumpus: I agree. (though also discovered that somehow my swap wasn't encrypted.. just recently) 01:09 < wumpus> so yes, encrypted keys do not need to be stored in lcoked ram 01:09 < wumpus> openbsd does that by default since 2005 *ducks* 01:10 < gmaxwell> wumpus: I've done it by default since before then. :P 01:12 < wumpus> I was surprised openbsd gives 5MiB or so of locked ram by default to processes, it's not usually known for its lenient ulimits ( https://github.com/bitcoin/bitcoin/blob/master/doc/build-openbsd.md#resource-limits :p) 01:12 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 248 seconds] 01:14 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 01:17 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 01:34 -!- mn3monic [~guido@176.9.68.68] has quit [Ping timeout: 244 seconds] 01:44 -!- AaronvanW [~ewout@185pc230.sshunet.nl] has joined #bitcoin-core-dev 01:44 -!- DigiByteDev [~JT2@185.29.164.51] has joined #bitcoin-core-dev 01:45 -!- AaronvanW [~ewout@185pc230.sshunet.nl] has quit [Changing host] 01:45 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:48 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 01:49 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has joined #bitcoin-core-dev 01:53 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Ping timeout: 264 seconds] 01:57 < wumpus> "chunks_used": 10190, yes, the steady state seems a chunk for each key 02:01 -!- DigiByteDev [~JT2@185.29.164.51] has quit [Quit: DigiByteDev] 02:01 < wumpus> which makes sense. We should change the wallet to not use locked memory for encrypted keys, and it will go to around ~0 02:02 < wumpus> (well, for encrypted wallets, but that's when you'd expect increased security. For the unencrypted wallet the attacker can grab wallet.dat instead of the swap file) 02:03 < wumpus> also on platforms such as windows (I think), osx, ubuntu, openbsd it's no problem to use a lot of locked memory. It's mostly just fine 02:03 < wumpus> (to be clear here I call 512kB 'a lot') 02:06 -!- rebroad [b7592517@gateway/web/freenode/ip.183.89.37.23] has joined #bitcoin-core-dev 02:15 -!- JackH [~laptop@79-73-191-94.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 02:16 < phantomcircuit> wumpus: can you take a look at 8696 ? 02:17 < phantomcircuit> im blocked on other changes to the CWalletDB stuff 02:35 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 02:40 -!- Atomic_zEU0b [~atomic@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has quit [Ping timeout: 260 seconds] 02:48 -!- rubensayshi [~ruben@82.201.93.169] has quit [Ping timeout: 276 seconds] 03:01 -!- rubensayshi [~ruben@64.145.76.142] has joined #bitcoin-core-dev 03:02 < wumpus> jonasschnelli, phantomcircuit will take a look at those 03:03 -!- mang0_ [4713fc72@gateway/web/freenode/ip.71.19.252.114] has joined #bitcoin-core-dev 03:04 < mang0_> Does anyone know the best place to get a small fast bitcoin loan? 03:04 < mang0_> whoops wrong channel 03:04 -!- mang0_ [4713fc72@gateway/web/freenode/ip.71.19.252.114] has quit [Client Quit] 03:25 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 03:37 -!- laurentmt [~Thunderbi@80.215.178.70] has joined #bitcoin-core-dev 03:40 -!- JackH [~laptop@79-73-191-94.dynamic.dsl.as9105.com] has quit [Ping timeout: 244 seconds] 03:46 < GitHub13> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/82eacc786d8d...02ac669730c0 03:46 < GitHub13> bitcoin/master faddd62 MarcoFalke: init: Get rid of some ENABLE_WALLET 03:46 < GitHub13> bitcoin/master 02ac669 Wladimir J. van der Laan: Merge #8760: [init] Get rid of some ENABLE_WALLET... 03:46 < GitHub78> [bitcoin] laanwj closed pull request #8760: [init] Get rid of some ENABLE_WALLET (master...Mf1609-walletInitGuard) https://github.com/bitcoin/bitcoin/pull/8760 03:47 < GitHub55> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/02ac669730c0...a1f8d3ed9569 03:47 < GitHub55> bitcoin/master 59adc86 Patrick Strateman: Add CWallet::ListAccountCreditDebit... 03:47 < GitHub55> bitcoin/master d2e678d Patrick Strateman: Add CWallet::ReorderTransactions and use in accounting_tests.cpp 03:47 < GitHub55> bitcoin/master 02e2a81 Patrick Strateman: Remove pwalletdb parameter from CWallet::AddAccountingEntry 03:48 < GitHub182> [bitcoin] laanwj closed pull request #8696: [Wallet] Remove last external reference to CWalletDB (master...2016-09-09-cwallet-listaccountcreditdebit) https://github.com/bitcoin/bitcoin/pull/8696 03:50 < GitHub169> [bitcoin] laanwj pushed 4 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/4731623777ab...8d9e8adc05f4 03:50 < GitHub21> [bitcoin] laanwj closed pull request #8744: [0.13.1] qa Backports (0.13...Mf1609-qaBackports) https://github.com/bitcoin/bitcoin/pull/8744 03:50 < GitHub169> bitcoin/0.13 63462c2 whythat: [qa] remove root test directory for RPC tests... 03:50 < GitHub169> bitcoin/0.13 ae8c7df MarcoFalke: [qa] create_cache: Delete temp dir when done... 03:50 < GitHub169> bitcoin/0.13 d6ebe13 MarcoFalke: [qa] Refactor RPCTestHandler to prevent TimeoutExpired... 03:50 < phantomcircuit> wumpus: ty 03:52 -!- dermoth [~thomas@dsl-216-221-54-208.mtl.contact.net] has joined #bitcoin-core-dev 03:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:56 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Ping timeout: 255 seconds] 03:57 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 04:03 -!- cryptapus [~cryptapus@87.254.202.159] has joined #bitcoin-core-dev 04:03 -!- cryptapus [~cryptapus@87.254.202.159] has quit [Changing host] 04:03 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:09 -!- JackH [~laptop@host86-136-108-82.range86-136.btcentralplus.com] has joined #bitcoin-core-dev 04:20 -!- rebroad [b7592517@gateway/web/freenode/ip.183.89.37.23] has quit [Ping timeout: 240 seconds] 04:33 -!- murch [~murch@p4FE3BE89.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:44 -!- cdecker [~cdecker@2a02:aa16:1105:4a80:9484:c95b:8d6f:faa4] has quit [Ping timeout: 265 seconds] 04:56 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:00 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 260 seconds] 05:00 < wumpus> jonasschnelli: #7783 seems to work great, can't seem to break it on first try at least :) 05:01 < jonasschnelli> wumpus: heh. Yes. It's surprisingly stable. :) 05:03 < wumpus> created some monster expressions using echo/echon and it works 05:03 -!- cryptapus_ is now known as cryptapus 05:04 -!- laurentmt [~Thunderbi@80.215.178.70] has quit [Quit: laurentmt] 05:05 < jonasschnelli> wumpus: It would also be not-very-complicate to add some expressions (basic math ops). Like sendtoaddress(getnewaddress(), getbalance()/2) 05:05 < jonasschnelli> but meh 05:06 -!- JackH [~laptop@host86-136-108-82.range86-136.btcentralplus.com] has quit [Quit: Leaving] 05:06 < wumpus> nah, that's probably going too far 05:06 < wumpus> may as well add a complete js interpreter then and ne done with it *ducks* 05:06 < jonasschnelli> heh 05:07 < jonasschnelli> we could include node.js ... 05:07 < jonasschnelli> and migrate the whole Qt stack to CSS/HTML with node.js. 05:07 < jonasschnelli> And.. while we'r at it,... include an app store 05:09 < wumpus> hahahah there have actually been people proposing that last thing 05:09 < wumpus> 'wallet applications' that run inside bitcoin core 05:09 < wumpus> absolutely crazy from a security perspective 05:10 < jonasschnelli> heh. Yes. Full access to privat keys... the plugin may want to do a sweep operation. :) 05:10 < wumpus> even having a semi-capable interpreter in the address space makes exploitation easier, but ok, that's pretty far-out. But explicitly including a sandbox for third-party code in your wallet is plain sick. 05:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 05:11 < wumpus> yes :) 05:12 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 265 seconds] 05:12 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:12 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 05:13 < wumpus> from a technical point of view it'd be really easy to do, just link qtscript/qjsengine 05:15 < wumpus> anyhow ACK on #7783 05:15 < GitHub67> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1f8d3ed9569...4335d5a41bc2 05:15 < GitHub67> bitcoin/master 1586044 Jonas Schnelli: [Qt] RPC-Console: support nested commands and simple value queries... 05:15 < GitHub67> bitcoin/master 4335d5a Wladimir J. van der Laan: Merge #7783: [Qt] RPC-Console: support nested commands and simple value queries... 05:16 < GitHub141> [bitcoin] laanwj closed pull request #7783: [Qt] RPC-Console: support nested commands and simple value queries (master...2016/04/qt_console_nested) https://github.com/bitcoin/bitcoin/pull/7783 05:29 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Read error: Connection reset by peer] 05:30 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 05:35 -!- rubensayshi [~ruben@64.145.76.142] has quit [Ping timeout: 244 seconds] 05:44 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 05:51 -!- achow101 [~achow101@129-2-207-18.student.umd.edu] has quit [Quit: Leaving] 05:54 -!- YOU-JI [~youyouyou@y195091.dynamic.ppp.asahi-net.or.jp] has joined #bitcoin-core-dev 05:54 -!- rubensayshi [~ruben@82.201.93.169] has joined #bitcoin-core-dev 05:57 < GitHub129> [bitcoin] jonasschnelli opened pull request #8764: [Wallet] get rid of pwalletMain, add simple CWallets infrastructure (master...2016/09/wallet_pointer) https://github.com/bitcoin/bitcoin/pull/8764 06:03 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 06:03 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:09 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Ping timeout: 240 seconds] 06:14 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 06:19 -!- user_8488 [779dee85@gateway/web/cgi-irc/kiwiirc.com/ip.119.157.238.133] has joined #bitcoin-core-dev 06:19 -!- jyap [~jyap@unaffiliated/jyap] has quit [Ping timeout: 250 seconds] 06:19 -!- user_8488 is now known as Guest_49853 06:22 -!- jyap [~jyap@server1.getjumbucks.com] has joined #bitcoin-core-dev 06:22 -!- jyap [~jyap@server1.getjumbucks.com] has quit [Changing host] 06:22 -!- jyap [~jyap@unaffiliated/jyap] has joined #bitcoin-core-dev 06:27 -!- tadasv [ttttt@gateway/shell/panicbnc/x-oylfhgwxfkapjjns] has quit [Ping timeout: 265 seconds] 06:34 < GitHub161> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4335d5a41bc2...6052d5091057 06:34 < GitHub161> bitcoin/master fdf82fb Hampus Sjöberg: Adding method GetTotalSize() to CTransaction... 06:34 < GitHub161> bitcoin/master c015634 Hampus Sjöberg: qt: Adding transaction size to transaction details window 06:34 < GitHub161> bitcoin/master 6052d50 Jonas Schnelli: Merge #8672: Qt: Show transaction size in transaction details window... 06:35 < GitHub165> [bitcoin] jonasschnelli closed pull request #8672: Qt: Show transaction size in transaction details window (master...qttxsizeindetails) https://github.com/bitcoin/bitcoin/pull/8672 06:38 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev 06:42 -!- Guest_49853 [779dee85@gateway/web/cgi-irc/kiwiirc.com/ip.119.157.238.133] has left #bitcoin-core-dev [] 06:45 < GitHub175> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6052d5091057...aff69278063c 06:45 < GitHub175> bitcoin/master 12a721b Marty Jones: Trivial: Fix typo 06:45 < GitHub175> bitcoin/master aff6927 Wladimir J. van der Laan: Merge #8762: Trivial: Fix typo... 06:45 < GitHub164> [bitcoin] laanwj closed pull request #8762: Trivial: Fix typo (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8762 06:48 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcdump.cpp#L347 06:48 < jonasschnelli> (doesn't this spin off another wallet flush thread that runs endless)? 06:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 06:49 < wumpus> eh ... 06:49 < wumpus> it changes a RPC thread to another wallet flush thread 06:49 < wumpus> good catch, that's weird 06:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:50 < wumpus> (to actually spawn a thread it'd need to do create_thread, but wtf why would it call a thread main function from aRPC call?!?) 06:50 < wumpus> does that RPC ever return? I'd guess not 06:51 < jonasschnelli> wumpus: Yes. It grabs the RPC thread and runs endless... right? 06:53 < jonasschnelli> I guess this occupies a rpc-thread per removeprunedfunds call 06:53 < wumpus> how the hell can the RPC test 'importprunedfunds.py' pass 06:53 < wumpus> it exercises that RPC 06:54 < wumpus> the same is done in IMportPrunedFunds btw 06:54 < jonasschnelli> I think it can pass because the test does not exceed the amount of parallel PRC threads... 06:55 < wumpus> but it should never return 06:55 < jonasschnelli> But... right.. the calls never returns?! 06:55 < wumpus> anyhow if the author wast rying to flush the wallet database, that's not the right way to do it 06:55 < jonasschnelli> wumpus: timeout? 06:55 < wumpus> not sure if explicit flushes are even needed? 06:55 < wumpus> timeout would be an error 06:56 < wumpus> it never gets to loopin, see the fOneThread check in the beginning 06:56 < jonasschnelli> I guess a CWallet::Flush() should also do it. 06:57 < wumpus> the whole thing is NOP, *apart* from renaming the RPC thread to 'bitcoin-wallet' :') 06:57 < jonasschnelli> wumpus: Ah. Right. the fOneThread 06:57 < wumpus> we should delete these, replace with CWallet::Flush if it needs explicit flush 06:58 < wumpus> although I don't see the logic here, why do some wallet calls need explicit flush and others don't? 06:58 < sipa> importing a key should flush 06:58 < sipa> sending a transaction maybe not 06:58 < jonasschnelli> A flush in pruning funds could be done for privacy ... but also on lots of other locations.. 06:59 < sipa> what does privacy have to do with it? 06:59 < wumpus> apparently the importprunedfunds doesn't flush, only the removepruned funds tries to (in this weird way) 06:59 < wumpus> I think this requirement needs to be well-documented 06:59 < wumpus> when does the wallet need explicit flushes and how to do it 07:00 < wumpus> this easily confuses me at least 07:00 < sipa> well whenever you could otherwise lose data, i would say 07:00 < sipa> *lose funds 07:00 < wumpus> isn't that on all calls that mutate wallet state? 07:01 < wumpus> okay, only those that add or generate keys then 07:02 < sipa> getnewaddress no, but yes when the keypool was topped up 07:02 < wumpus> right 07:02 < wumpus> and we should rename THreadFlushWalletDB. It doesn't just flush, it periodically closes and checkpoints (compacts) the database. 07:03 < sipa> phantomcircuit: are you working on thatm 07:03 < wumpus> so it's different from cwallet->Flush which (I assume) does a flush 07:05 < jonasschnelli> ThreadFlushWalletDB directly operates with a file to the walletdb and with the global bitdb 07:05 < wumpus> yes. It's pretty serious magic. 07:06 < jonasschnelli> heh 07:06 < wumpus> we shoud be happy the the fOneTHread check is at the top of it, or I could imagine two of those threads shredding the wallet together 07:07 < jonasschnelli> I really wonder how a repetitive call `bitdb.CloseDb(strFile);` without a follow up "Open" does work 07:07 < wumpus> it's automagically reopened on next use 07:07 < jonasschnelli> hahaha 07:07 < jonasschnelli> automagically ... lol 07:08 < wumpus> but yes it's things like this that make people afraid to touch, maybe even look at the wallet code :) 07:09 < wumpus> I really wonder if it's necessary to be so hacky there, maybe it simply is, but it need 100% more comments 07:09 < jonasschnelli> Yes. I really dislike the time based periodical flushing... 07:10 < wumpus> well periodical flushing in itself makes sense I think 07:10 < wumpus> e.g. important changes flush and sync immediately, like adding new keys to the keypool 07:10 < wumpus> other changes can potentially wait until shutdown or the next timer 07:12 < jonasschnelli> I'm not opposed against periodical flushing.. but why time based in a separate thread. 07:12 < jonasschnelli> Hmm.. maybe it makes sense if the flushing takes a couple of seconds... 07:13 < wumpus> what is being done is not completely insane, it's just heavily underdocumented, and function names and variable names don't match what is being done, which is deceptive 07:13 < wumpus> yes, right, for big wallets this periodical compaction can take a while 07:13 < wumpus> so it makes sense to do it in a thread in that regard 07:14 < wumpus> but anyhow we should have caught the ThreadFlushWalletDB() in review :) 07:15 < wumpus> calling into another thread's main function is 100% of times a mistake 07:16 < wumpus> are you going to submit a pull to remove it or shoudl I? 07:16 < jonasschnelli> I think removing the line in rpcdump.cpp would probably the best solution for now (should not change the behavior). 07:16 < jonasschnelli> I can to a PR 07:16 < wumpus> it's in 0.12 too 07:16 < jonasschnelli> can do 07:16 < wumpus> yes 07:18 -!- cryptapus_ [~cryptapus@87.254.202.179] has joined #bitcoin-core-dev 07:18 -!- cryptapus_ [~cryptapus@87.254.202.179] has quit [Changing host] 07:18 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:22 < btcdrak> https://github.com/bitcoin-core/bitcoincore.org/pull/214 07:22 < GitHub50> [bitcoin] jonasschnelli opened pull request #8765: [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds (master...2016/09/flush_wallet_dump) https://github.com/bitcoin/bitcoin/pull/8765 07:22 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds] 07:22 < GitHub189> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aff69278063c...1c24d5f63720 07:22 < GitHub189> bitcoin/master 157254a Suhas Daftuar: Fix broken sendcmpct test in p2p-compactblocks.py... 07:22 < GitHub189> bitcoin/master 1c24d5f Wladimir J. van der Laan: Merge #8739: [qa] Fix broken sendcmpct test in p2p-compactblocks.py... 07:22 < GitHub94> [bitcoin] laanwj closed pull request #8739: [qa] Fix broken sendcmpct test in p2p-compactblocks.py (master...fix-cb-test) https://github.com/bitcoin/bitcoin/pull/8739 07:24 -!- tadasv [ttttt@gateway/shell/panicbnc/x-gruuuqrezizolbha] has joined #bitcoin-core-dev 07:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:27 < GitHub110> [bitcoin] unsystemizer opened pull request #8766: Fix URL for Debian 8.5.0 ISO (master...patch-3) https://github.com/bitcoin/bitcoin/pull/8766 07:31 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:53 -!- YOU-JI [~youyouyou@y195091.dynamic.ppp.asahi-net.or.jp] has quit [Quit: Leaving...] 07:57 -!- achow101 [~achow101@129-2-207-18.student.umd.edu] has joined #bitcoin-core-dev 08:03 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:05 -!- rubensayshi [~ruben@82.201.93.169] has quit [Remote host closed the connection] 08:06 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 08:32 < GitHub147> [bitcoin] MarcoFalke opened pull request #8768: init: Get rid of fDisableWallet (master...Mf1609-initDisableWallet) https://github.com/bitcoin/bitcoin/pull/8768 08:37 < gmaxwell> jonasschnelli: luke-jr submitted a fix for removeprunedfunds a week or so ago, #8687 08:39 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 08:40 < wumpus> that doesn't seem to be the right solution 08:40 < wumpus> there's no need to call the compaction there 08:53 -!- cryptapus_ is now known as cryptapus 09:48 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 09:48 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 09:48 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 09:57 -!- laurentmt [~Thunderbi@80.215.210.161] has joined #bitcoin-core-dev 09:58 -!- laurentmt [~Thunderbi@80.215.210.161] has quit [Client Quit] 10:07 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:10 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 10:10 -!- rogerwilco [~rogerwilc@193-81-96-69.adsl.highway.telekom.at] has joined #bitcoin-core-dev 10:20 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 10:21 -!- Atomic_zEU0b [~atomic@209.171.88.162] has joined #bitcoin-core-dev 10:35 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 10:38 -!- Atomic_zEU0b [~atomic@209.171.88.162] has quit [Ping timeout: 248 seconds] 10:38 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 10:42 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 10:43 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 10:46 -!- tucker111 [18e2f570@gateway/web/freenode/ip.24.226.245.112] has joined #bitcoin-core-dev 10:47 < tucker111> I recently updated btc core to 0.13.0 and my btc and transactions history is gone. pls help I ve re scan .dat to make sure and nothing happened 10:49 < sipa> what did you update from? 10:49 < tucker111> 0.12 10:50 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 250 seconds] 10:50 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 10:51 < tucker111> I have all addresses that I ve generated from the core and the amount I ve sent and received to authenticate...could it help? 10:53 < sipa> go to the debug window, and type "validateaddress
" 10:53 < sipa> without the "", and with
replaced by an address you know is yours 10:53 < sipa> that you've received funds on 11:01 < tucker111> do I type it in ''debug log file'' or ''console'' in debug window? 11:01 < achow101> the console tab on the textbox at the bottom 11:04 < sipa> console 11:06 < sipa> does it say ismine true or false? 11:11 < tucker111> false 11:13 < tucker111> ''isvalid'' false 11:14 < sipa> that means you're not pasting an address 11:15 < sipa> maybe you left off some characters from the beginning or the end? 11:16 < tucker111> i ve checked the address 3 times 11:17 < gmaxwell> are you confusing addresses for different cryptocurrencies? 11:17 < tucker111> all in btcv 11:17 < tucker111> btc 11:18 < sipa> it should be 11:18 < sipa> validateaddress 1bcdefhdhduabandkdbsvag 11:18 < sipa> for example 11:18 < sipa> no other characters 11:19 < tucker111> without < >? 11:19 < sipa> yes 11:19 < sipa> <> just means "replace something here" 11:21 < gmaxwell> sipa: you should have given a valid example. 11:21 < tucker111> sometimes theyre important tho 11:22 < tucker111> ismine false 11:26 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev 11:29 < tucker111> what does ismine false means? 11:30 < achow101> it means that the address is not in your wallet 11:31 < tucker111> can I recover the btc that were on it? 11:31 < btcdrak> well it means you dont have the private key for it. 11:32 < tucker111> i do 11:32 < achow101> you don't have the private key so you can't get any of the Bitcoin that was associated with it 11:32 < achow101> if it isn't in your wallet, you don't have the key 11:33 < gmaxwell> tucker111: how did you upgrade? 11:40 < tucker111> actually I did a tails usb driver and then logged back into win10 and then plane mode was stuck, so I had to do a factory reset after trying millions solutions to get rid of plane mode 11:40 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds] 11:40 < tucker111> and then i download the core again... 11:41 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 11:41 < sipa> factory reset of what? 11:41 < achow101> doesn't the factory reset wipe everything? 11:41 < tucker111> couldnt login to btc core at all to do the transfer before hand 11:41 < achow101> did Core have to resync when you first started it after reinstall 11:41 < tucker111> it should 11:41 < tucker111> no it didnt 11:42 < tucker111> i m still reinstalling it so i dont know yet 11:42 < achow101> well if it wiped your wallet.dat file you're screwed 11:43 < sipa> if you type 11:43 < sipa> getblockcount 11:43 < sipa> in the debug console, what does it say? 11:44 < tucker111> 278384 11:45 < achow101> well there's your problem 11:45 < tucker111> i not synced yet thats why? 11:46 < achow101> yes 11:46 < tucker111> should i get it afterward? 11:46 < achow101> right now you are still syncing. If your factory reset wiped the drive, then your wallet.dat and the blockchain got wiped to 11:46 < achow101> so if your wallet.dat is gone (as it likely is) then you have lost your bitcoin 11:47 < tucker111> i know but is there a way to go back to the same wallet since i cant use it offline? 11:47 < tucker111> ok 11:47 < gmaxwell> tucker111: do you have a backup of your wallet? 11:47 < tucker111> i couldnt do it! 11:51 < arubi> tucker111, did you use windows 10 "reset this pc" when you did factory reset? 11:51 < jonasschnelli> How would it be if we change __rpcfunc(const UniValue& params, bool fHelp) to __rpcfunc(const RPCContext& ctx), where ctx would contain const UniValue& params, bool fHelp along with info about the request 11:51 < MarcoFalke> Arg, the review divs won't collapse when they are outdated 11:51 < jonasschnelli> MarcoFalke: Yes. Thats bad. 11:51 < arubi> tucker111, -> #bitcoin 11:51 < jonasschnelli> Maybe they get removed when you do another github "review"? 11:51 < gmaxwell> tucker111: arubi: achow101: etc. please move to #bitcoin for further discussion. :) 11:52 < jonasschnelli> If we change it to __rpcfunc(const RPCContext& ctx), we could add the request URI, etc. which would allow accessing multiple wallets 12:01 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 12:03 < gmaxwell> wumpus: if your locked page ulimit is (say) 64k and you try to lock 256k... will it fail to lock anything at all? Might be useful to make the mlocks run in smaller increments to at least get some locked. 12:03 -!- achow101 [~achow101@129-2-207-18.student.umd.edu] has quit [Quit: Leaving] 12:04 -!- achow101 [~achow101@129-2-207-18.student.umd.edu] has joined #bitcoin-core-dev 12:10 < gmaxwell> someone in #bitcoin with a gdb backtrace of a node that keeps crashing during sync running 0.13 ppa... crashing at assert(coins) in CheckTxInputs. 12:10 < gmaxwell> about to hop a flight, but someone might want to look at it. 12:10 < gmaxwell> user reports 0.12 was running fine before. 12:11 < gmaxwell> (user is nou1) 12:11 < sipa> gmaxwell: his PR checks the locked page limit, and if it nonzero, it first allocates that amount immediately 12:11 < gmaxwell> oh great! 12:11 < sipa> so if you have 64kb it will still allocate 64, even if the default is 256 12:13 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 265 seconds] 12:17 -!- tucker111 [18e2f570@gateway/web/freenode/ip.24.226.245.112] has quit [Ping timeout: 240 seconds] 12:30 < GitHub4> [bitcoin] unsystemizer closed pull request #8766: Fix URL for Debian 8.5.0 ISO (master...patch-3) https://github.com/bitcoin/bitcoin/pull/8766 12:39 < GitHub79> [bitcoin] unsystemizer opened pull request #8769: Trivial: Fix ISO URL, capitalization (master...patch-4) https://github.com/bitcoin/bitcoin/pull/8769 12:39 < phantomcircuit> sipa: yes that's something i am working on 12:40 < phantomcircuit> before trying to fix the flush logic im cleaning things up in general 13:03 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:03 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 13:10 -!- xiangfu [~xiangfu@58.135.95.141] has quit [Ping timeout: 244 seconds] 13:18 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 13:37 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 13:42 -!- xiangfu [~xiangfu@58.135.95.141] has joined #bitcoin-core-dev 13:50 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has quit [Ping timeout: 244 seconds] 14:00 -!- jtimon [~quassel@150.110.132.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 14:04 < GitHub150> [bitcoin] MarcoFalke closed pull request #8286: [doc] Docs and copyright headers bump (master...Mf1607-trivialPre13) https://github.com/bitcoin/bitcoin/pull/8286 14:12 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 14:47 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 14:47 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 14:48 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 14:52 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 14:57 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 15:01 < jtimon> is "functions start with uppercase" still part of our style guidelines? I can't find them (maybe they're now reduced to src/.clang-format )? 15:07 < sipa> yes it is 15:08 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 255 seconds] 15:14 -!- droark [~droark@c-24-22-36-12.hsd1.or.comcast.net] has joined #bitcoin-core-dev 15:18 -!- ___tau___ [user@gateway/vpn/mullvad/x-dzppazocdlqtihnl] has joined #bitcoin-core-dev 15:22 < jtimon> sipa: I was asking because ___tau___ and I are discussing the namin in https://github.com/bitcoin/bitcoin/pull/8493/commits/ca1f6622f49cf5653ba074a9392102ef515c9d3c#diff-646fe6309aabacfd041a20dcad10be05R11 and https://github.com/bitcoin/bitcoin/pull/8493/commits/3165f95cc2f60ebf37d073da10640fbfa141b765#diff-c2a099d775bac1dccc5f146a3cda81b8R16 15:24 < jtimon> he suggested get_ancestor_fn get_ancestor; is clearer, but since we have uppercase for functions as a style rule maybe GetAncestor_fn GetAncestor; is a good compromise ? 15:26 < jtimon> nothing urgent, but yeah, AncestorGetter Ancestor; seems less clear 15:26 < ___tau___> Ah, the point was to not drop the verbs from the function names rather than use underscores (that was just an example for explaining) 15:28 < jtimon> yeah, just saying that it will be free for me to change the names to anything else while I do that, so if there's any other bike-shedding to put in or reject (ie the _fn ending), now it's better than any other time 15:28 < jtimon> personally I like the _fn convention 15:32 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Ping timeout: 244 seconds] 15:32 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 15:42 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 16:01 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 16:02 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 16:15 -!- rogerwilco [~rogerwilc@193-81-96-69.adsl.highway.telekom.at] has quit [Ping timeout: 265 seconds] 16:15 -!- rogerwilco [~rogerwilc@193-81-229-137.adsl.highway.telekom.at] has joined #bitcoin-core-dev 16:27 -!- murch [~murch@p4FE3BE89.dip0.t-ipconnect.de] has quit [Quit: Leaving.] 17:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 17:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:43 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:46 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 17:46 -!- brg444 [415ce2de@gateway/web/freenode/ip.65.92.226.222] has joined #bitcoin-core-dev 17:46 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gskxxshabyrubmqw] has quit [Quit: Connection closed for inactivity] 18:04 -!- analpaper [~analpaper@85.red-88-17-205.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 18:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 18:39 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:5415:c093:e98:94c1] has joined #bitcoin-core-dev 18:40 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 18:57 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-gwhetevlfdqtmpgj] has quit [Quit: Connection closed for inactivity] 18:59 < phantomcircuit> is there some reason im not aware of that the wallet functions aren't acquiring the lock themselves? 18:59 < phantomcircuit> instead of relying on the caller to have acquired the lock? 19:11 -!- brg444 [415ce2de@gateway/web/freenode/ip.65.92.226.222] has quit [Quit: Page closed] 19:13 -!- jchrome [~circuser-@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 19:29 -!- jchrome [~circuser-@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has quit [Remote host closed the connection] 19:30 -!- jchrome [~jchrome@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 19:39 < phantomcircuit> luke-jr: ^ 19:40 < phantomcircuit> it *should* be safe for me to simpyl add LOCK(cs_wallet); calls to all methods which assume a lock? (which is basically all of them) 19:41 < luke-jr> phantomcircuit: my guess would be so they could be used recursively 19:53 -!- go1111111 [~go1111111@104.232.116.217] has quit [Quit: Leaving] 19:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:57 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:01 -!- Atomic_zEU0b [~atomic@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 20:02 -!- Atomic_zEU0b [~atomic@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has left #bitcoin-core-dev [] 20:02 < Atomic_zEU0b> hey 20:08 -!- jchrome [~jchrome@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has left #bitcoin-core-dev [] 20:15 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Remote host closed the connection] 20:18 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:19 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:19 < phantomcircuit> gmaxwell: the LOCK construct is recursive right? 20:33 < luke-jr> pretty sure it isn't. or at least can't be relied on to be. 20:42 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 20:53 -!- jchrome [~jchrome@sydnns0115w-047055195222.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 21:00 -!- dermoth [~thomas@dsl-216-221-54-208.mtl.contact.net] has quit [Read error: Connection reset by peer] 21:00 -!- dermoth [~thomas@dsl-216-221-54-208.mtl.contact.net] has joined #bitcoin-core-dev 21:08 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has quit [Ping timeout: 244 seconds] 21:18 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 21:58 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:58 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer] 21:58 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 21:59 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:06 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 22:11 -!- kyletorpey [~kyle@pool-71-176-227-116.rcmdva.fios.verizon.net] has quit [Ping timeout: 276 seconds] 22:12 -!- kyletorpey [~kyle@pool-71-176-227-116.rcmdva.fios.verizon.net] has joined #bitcoin-core-dev 22:20 -!- analpaper [~analpaper@85.red-88-17-205.dynamicip.rima-tde.net] has quit [Read error: Connection reset by peer] 22:27 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 22:38 < wumpus> phantomcircuit: yes, the default mutex used in bitcoin core is a recursive one 22:39 < wumpus> we'd rather have it otherwise, there are a few solid software engineering reasons to avoid recursive mutexes, but that's part of our inheritance and it's terribly difficult to change (and be sure of the result) 22:39 < wumpus> note that new code in general tries to use normal, single-use mutexes 22:40 -!- mn3monic [~guido@176.9.68.68] has joined #bitcoin-core-dev 22:56 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 22:56 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 22:56 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 23:08 < luke-jr> wumpus: pretty sure I hit a deadlock from locking the same mutex twice in a thread, fwiw 23:09 < wumpus> that is very possible, but not with the main, wallet locks and such as they are recursive mutexes 23:09 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hrhcrmzsqmtobfsq] has joined #bitcoin-core-dev 23:10 < wumpus> you can try locking them 100 times in a loop in the same thread, they just keep track of a counter, so as long as you unlock the same number of times you will be fine 23:11 < luke-jr> wumpus: I guess I should just close https://github.com/bitcoin/bitcoin/pull/8687 and simply remove the call in a new PR? 23:11 < wumpus> let's close it in favor of #8765 23:12 < luke-jr> oh, missed that 23:12 < wumpus> he had missed your pull too 23:12 < GitHub113> [bitcoin] laanwj closed pull request #8687: Bugfix: RPC/Wallet: removeprunedfunds should flush the wallet db (master...bugfix_removeprunedfunds) https://github.com/bitcoin/bitcoin/pull/8687 23:15 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-ejtpdluxuyrinlbv] has joined #bitcoin-core-dev 23:16 < GitHub23> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1c24d5f63720...b4f53641a95d 23:16 < GitHub23> bitcoin/master c6f5ca8 Jonas Schnelli: [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds 23:16 < GitHub23> bitcoin/master b4f5364 Wladimir J. van der Laan: Merge #8765: [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds... 23:16 < GitHub106> [bitcoin] laanwj closed pull request #8765: [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds (master...2016/09/flush_wallet_dump) https://github.com/bitcoin/bitcoin/pull/8765 23:16 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: leaving] 23:27 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 23:38 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 23:39 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 23:55 -!- rubensayshi [~ruben@82.201.93.169] has joined #bitcoin-core-dev