--- Day changed Fri Oct 28 2016 00:05 -!- jnewshoes [~jodie@sydnns0115w-142167035138.dhcp-dynamic.FibreOp.ns.bellaliant.net] has quit [Ping timeout: 245 seconds] 00:08 -!- jnewshoes [~jodie@sydnns0115w-142167035138.dhcp-dynamic.FibreOp.ns.bellaliant.net] has joined #bitcoin-core-dev 00:08 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 00:13 -!- harrymm [~wayne@104.222.140.53] has quit [Ping timeout: 252 seconds] 00:15 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:21 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 00:26 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Ping timeout: 245 seconds] 00:28 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 00:29 -!- harrymm [~wayne@104.222.140.89] has joined #bitcoin-core-dev 00:36 -!- harrymm [~wayne@104.222.140.89] has quit [Ping timeout: 276 seconds] 00:50 -!- harrymm [~wayne@104.238.45.39] has joined #bitcoin-core-dev 00:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:07 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 260 seconds] 01:09 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev 01:09 -!- laurentmt [~Thunderbi@80.215.234.211] has joined #bitcoin-core-dev 01:09 -!- laurentmt [~Thunderbi@80.215.234.211] has quit [Client Quit] 01:21 -!- laurentmt [~Thunderbi@80.215.234.211] has joined #bitcoin-core-dev 01:21 -!- laurentmt [~Thunderbi@80.215.234.211] has quit [Client Quit] 01:24 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 245 seconds] 01:24 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:28 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 01:29 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:34 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Ping timeout: 250 seconds] 01:35 -!- DigiByteDev [~JT2@178.208.160.244] has joined #bitcoin-core-dev 01:35 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 01:35 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 01:35 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:37 -!- DigiByteDev [~JT2@178.208.160.244] has quit [Client Quit] 01:42 < phantomcircuit> the problem is more so that pwalletMain is a thing i guess 01:50 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 01:56 -!- harrymm [~wayne@104.238.45.39] has quit [Ping timeout: 244 seconds] 01:58 -!- harrymm [~wayne@104.238.45.39] has joined #bitcoin-core-dev 02:07 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 02:40 -!- Victor_sueca is now known as Victorsueca 02:53 -!- laurentmt [~Thunderbi@80.215.234.211] has joined #bitcoin-core-dev 02:54 -!- laurentmt [~Thunderbi@80.215.234.211] has quit [Client Quit] 02:58 -!- mkarrer [~mkarrer@128.red-83-47-106.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 02:59 -!- mkarrer_ [~mkarrer@7.red-83-47-85.dynamicip.rima-tde.net] has quit [Ping timeout: 252 seconds] 03:19 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 245 seconds] 03:20 -!- tulip [uid192128@gateway/web/irccloud.com/x-dtpbqwufvtgwmbxn] has quit [Quit: Connection closed for inactivity] 03:21 -!- rebroad [~rebroad@223.205.208.152] has quit [Ping timeout: 276 seconds] 03:21 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has left #bitcoin-core-dev [] 03:22 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 03:23 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 03:29 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 03:33 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 03:40 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 03:44 -!- Bi_ [~Bi@31-179-199-111.kamnet.pl] has joined #bitcoin-core-dev 03:45 < Bi_> Hi. Can someone please help me to understand one of the unit tests / script_tests 03:45 < Bi_> Its then one 03:46 < Bi_> that is called "Basic P2WSH" 03:46 < Bi_> My main question is: is the script expected to fail or pass? 03:50 < Bi_> Because in script_tests.json file I see "OK" for this test vector. But looking how the script gets executed (from script_tests.cpp) I see it actually failing. But the test itself is passing, like it was expecting the script to fail 03:50 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 03:53 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 03:54 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-pdpfnyqfpkgmuvhl] has joined #bitcoin-core-dev 03:54 < phantomcircuit> Bi_: there are tests which pass when the test fails intentionally 03:55 < Bi_> phantomcircuit, yes I know it 03:55 < Bi_> Bus is this such a one? 03:56 < phantomcircuit> no idea 03:56 < phantomcircuit> it should say 03:58 < Bi_> Well, in the jason file it says "OK" - so I'd assume it's expecting OK from the script function 03:58 < Bi_> But that's not what I see it getting from the script function 03:59 -!- aalex [~aalex@64.187.177.58] has quit [Max SendQ exceeded] 03:59 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 04:00 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 04:16 -!- cdecker [~quassel@2a02:aa16:1105:4a80:d552:a356:122b:b11d] has joined #bitcoin-core-dev 04:17 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 04:33 -!- laurentmt [~Thunderbi@80.215.234.211] has joined #bitcoin-core-dev 04:33 -!- laurentmt [~Thunderbi@80.215.234.211] has quit [Client Quit] 04:35 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 04:50 < GitHub119> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fea5e05a6380...0dcb888266ea 04:50 < GitHub119> bitcoin/master 169bdab instagibbs: Return useful error message on ATMP failure 04:50 < GitHub119> bitcoin/master 0dcb888 Wladimir J. van der Laan: Merge #9016: Return useful error message on ATMP failure... 04:50 < GitHub28> [bitcoin] laanwj closed pull request #9016: Return useful error message on ATMP failure (master...atmperror) https://github.com/bitcoin/bitcoin/pull/9016 05:00 -!- cryptapus_afk is now known as cryptapus 05:09 -!- gijensen92 [~gijensen@gijensen.xyz] has joined #bitcoin-core-dev 05:10 -!- gijensen [~gijensen@gijensen.xyz] has quit [Ping timeout: 276 seconds] 05:10 -!- gijensen92 is now known as gijensen 05:10 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 250 seconds] 05:13 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 05:15 < GitHub65> [bitcoin] laanwj closed pull request #8989: [Qt] overhaul smart-fee slider, adjust default confirmation target (master...2016/10/qt_slider) https://github.com/bitcoin/bitcoin/pull/8989 05:16 < GitHub166> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0dcb888266ea...d2143dc937e3 05:16 < GitHub166> bitcoin/master 004168d Jonas Schnelli: CoinControl: add option for custom confirmation target 05:16 < GitHub166> bitcoin/master 6f02899 Jonas Schnelli: [Qt] Hide nTxConfirmTarget behind WalletModel 05:16 < GitHub166> bitcoin/master cfe77ef Jonas Schnelli: [Qt] overhaul smart-fee slider, adjust default confirmation target 05:20 < GitHub64> [bitcoin] laanwj opened pull request #9036: wallet: Change default confirm target from 2 to 6 (master...2016_10_txconfirmtarget) https://github.com/bitcoin/bitcoin/pull/9036 05:20 -!- Netsplit *.net <-> *.split quits: Guyver2, murr4y, roasbeef 05:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:35 -!- roasbeef [~root@104.131.26.124] has joined #bitcoin-core-dev 05:36 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:36 -!- murr4y [~murr4y@17.57.211.130.bc.googleusercontent.com] has joined #bitcoin-core-dev 05:52 -!- PatBoy [xyz@192.99.249.194] has quit [Ping timeout: 250 seconds] 05:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 05:56 -!- PatBoy [xyz@192.99.249.194] has joined #bitcoin-core-dev 05:57 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:57 -!- tinkerbell11_ [02daf379@gateway/web/freenode/ip.2.218.243.121] has joined #bitcoin-core-dev 05:58 < tinkerbell11_> lots of places shouting about november 15th startdate for checking flags.. but dates are meaningless.. anyone know the first blockheight where checking will begin?? 05:58 < tinkerbell11_> eg 440,000? 06:08 < aj> probably block 441504 would be the first block where the 95% test could theoretically pass; so around dec 3rd for earliest conceivable lockedin? 06:11 < btcdrak> New blog post by aj on Segwit Costs: https://bitcoincore.org/en/2016/10/28/segwit-costs/ 06:12 <@wumpus> jonasschnelli: do you know why do we still change payTxFee globally in the GUI when there's a perfectly usable fOverrideFeeRate in coincontrol? 06:14 <@wumpus> seems like an unnecessary source of potential conflicts 06:14 <@wumpus> btcdrak: great! 06:15 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 06:19 -!- laurentmt [~Thunderbi@80.215.234.211] has joined #bitcoin-core-dev 06:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:21 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 06:21 < aj> wumpus: fwiw bitcoin 0.13.1 is in debian unstable now too. 06:21 <@wumpus> aj: okay 06:21 < timothy> archlinux too 06:22 < btcdrak> Viva la revoluciĆ³n! 06:34 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 06:38 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 06:39 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 06:39 -!- tinkerbell11_ [02daf379@gateway/web/freenode/ip.2.218.243.121] has quit [Quit: Page closed] 06:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 06:47 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 06:50 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 06:53 -!- laurentmt [~Thunderbi@80.215.234.211] has quit [Remote host closed the connection] 06:56 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:59 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:19a4:48b3:7218:f2a5] has quit [Read error: Network is unreachable] 07:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:01 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:70ff:a4d5:8d0d:8cf3] has joined #bitcoin-core-dev 07:02 -!- laurentmt [~Thunderbi@80.215.138.203] has joined #bitcoin-core-dev 07:15 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 07:23 -!- Bi_ [~Bi@31-179-199-111.kamnet.pl] has quit [Quit: Leaving] 07:38 -!- laurentmt [~Thunderbi@80.215.138.203] has quit [Remote host closed the connection] 07:39 -!- laurentmt [~Thunderbi@80.215.138.203] has joined #bitcoin-core-dev 07:43 -!- laurentmt [~Thunderbi@80.215.138.203] has quit [Client Quit] 07:50 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-pdpfnyqfpkgmuvhl] has quit [Quit: Connection closed for inactivity] 07:52 < BlueMatt> wtf is pnodeLocalHost? 07:52 -!- rebroad [~rebroad@223.205.208.152] has joined #bitcoin-core-dev 07:52 < BlueMatt> looks like we maintain a persistent connection to ourselves? 07:53 < BlueMatt> cfields_: ^? 08:03 < BlueMatt> lol, fibre test network reliable much? https://imgur.com/a/W3dhx 08:03 < BlueMatt> flat top to the graph is amazing 08:06 < kanzure> axis labels plz 08:09 < BlueMatt> oops, heh, cut off the explination text 08:11 < BlueMatt> anyway, left axis is ms from first-recv to which the 1st, 2nd, 3rd, etc node received the block...so T1-T4 (the bottom 4 lines) are pretty noisy because it depends on where things entered the network....T5 is super flat, meaning the network is highly reliable in terms of time take to transmit around the globe 08:11 < sipa> it's an exponential scale 08:11 < BlueMatt> note log scale, but its still super flat ignoring that...just under 180ms almost always, with peaks reaching 190/195 08:11 < sipa> ok 08:16 < aj> BlueMatt: which lines correspond to the right hand axis? 08:17 < BlueMatt> honestly i have nfc wtf the right axis is, none of the lines correspond to it 08:17 < BlueMatt> would have to go read the source 08:17 < aj> haha, awesome 08:19 < cfields_> BlueMatt: yea, we do. I've never gotten around to asking why, kept assuming i'd bump into the reason. Still haven't though. 08:19 < BlueMatt> wtf.... 08:20 < cfields_> BlueMatt: i've always assumed the intent was to be able to query our own node state in the same place as the others 08:21 < BlueMatt> that sounds like some satoshi-era bullshit right there :p 08:21 < cfields_> BlueMatt: well it's completely made up, just my best guess :) 08:21 < cfields_> but yes, let's kill it 08:22 < cfields_> BlueMatt: i'll nuke it after the PR that changes message sending around? Otherwise killing it would stomp on that i believe 08:22 < BlueMatt> yes, agreed, no rush there 08:22 < BlueMatt> reviewing that one now :) 08:22 < BlueMatt> (thats why i saw it) 08:22 < cfields_> figured 08:22 < cfields_> BlueMatt: need to double-check all accounting to make sure it doesn't +1 something important 08:22 < BlueMatt> yea 08:32 -!- laurentmt [~Thunderbi@80.215.138.203] has joined #bitcoin-core-dev 08:33 -!- laurentmt [~Thunderbi@80.215.138.203] has quit [Client Quit] 08:34 < phantomcircuit> kanzure: he's lying it's kittens/time 08:35 < kanzure> thank you. 08:35 < BlueMatt> that is a strange unit 08:37 < phantomcircuit> kittens over time? 08:37 < BlueMatt> kittens strangled? kittens hugged? kittens adopted? 08:38 < phantomcircuit> so in all seriousness 08:38 < phantomcircuit> pwalletMain 08:38 < BlueMatt> needs to die? 08:38 < phantomcircuit> that isn't used internally in CWallet or CWalletDB is it? 08:38 < phantomcircuit> (also yes) 08:39 < phantomcircuit> i went to wrap CWallet in a class for the tests so i can make a bunch of methods protected and ran into pwalletMain being global for tests and normal use 08:43 < BlueMatt> it shouldnt be? is it really? 08:51 < phantomcircuit> BlueMatt: yeah... 08:51 < phantomcircuit> wallet.h 08:51 < BlueMatt> thats not "used", just defined 08:51 < BlueMatt> move the definition? 08:52 < phantomcircuit> it's used in accounting_tests.cpp 08:52 < phantomcircuit> and is initialized in wallet_test_fixture.cpp 08:54 < phantomcircuit> afaict those are the only things which even use the CDB::MakeMock stuff 08:54 < phantomcircuit> and they aren't really 09:01 < BlueMatt> https://www.reddit.com/r/Bitcoin/comments/59rlgq/ubuntu_bitcoin_core_ppa_updated_to_0131/d9bjp5z/ 09:01 < BlueMatt> anyone got an idea why the fuck that assert would trigger??? 09:06 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 09:06 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:11 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 245 seconds] 09:13 <@wumpus> no clue,my guess would be database corruption 09:14 < gmaxwell> It's a common place where DB corruption manifests. Perhaps we should change that from an assert to be something telling you to reindex. 09:14 < gmaxwell> https://github.com/bitcoin/bitcoin/issues/5670 09:14 < gmaxwell> https://github.com/bitcoin/bitcoin/issues/7258 09:14 < gmaxwell> https://github.com/bitcoin/bitcoin/issues/6196 09:14 <@wumpus> probably 09:15 <@wumpus> I think it ends up there if things are missing in the block index 09:16 < BlueMatt> cfields_: ok, reviewed 8708 09:16 < BlueMatt> gmaxwell: heh, ok 09:16 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:19 < gmaxwell> BlueMatt: did you see my comment from last night that perhaps we should be banning peers that send us an unsolicited block message now that we have compact blocks? (perhaps also unsolicited CB when that peer is not requested for HB mode, but I think thats less important)... there are a number of peers on the network which 'helpfully' send blocks without asking, causing some n-fold bandwidth inc 09:19 < gmaxwell> rease (esp for blocks only nodes). 09:20 < BlueMatt> gmaxwell: i did not, but I'm not against it particularly 09:21 < BlueMatt> I'd like to nominate https://github.com/bitcoin/bitcoin/pull/9026 (well, a variant of it, because that is gonna end up adapting to some reorgs that are in-progress) for 0.13.2 09:23 < gmaxwell> With 9026 will peers still get banned if the block fails the stateless checks (e.g. bad pow)? 09:23 < BlueMatt> i think that is the intention? 09:24 < gmaxwell> k 09:24 < BlueMatt> not with the current implementation, i think, but could be done 09:24 < BlueMatt> and i think maybe should 09:25 < BlueMatt> anyway, i think sdaftuar might be waiting for #8969 and the commits i posted based on it yesterday to tweak it, since it simplifies it 09:26 < cfields_> BlueMatt: https://github.com/theuni/bitcoin/commits/connman-const 09:26 < BlueMatt> though if we backport it.... 09:27 < cfields_> BlueMatt: i agree with your nits about locking, so I whipped up the changes in the branch above. I didn't want that PR to creep on forever though, so I was going to add them as a next step. Would you be more comfortable if i tacked them on? 09:27 < BlueMatt> cfields_: that looks sane to me? though i havent audited where we have those strange threading bugs 09:28 < cfields_> BlueMatt: well if they're const, they can't be racy. No need to make things atomic if they can't change. 09:28 < BlueMatt> indeed 09:28 < cfields_> ok, I'll add them to the PR. Thanks for the review. 09:28 < BlueMatt> cfields_: I'd be ok if they're next-step, i think, though i didnt bother to audit if they were possibly correct, it just looked very wrong and i gave up and pointed it out 09:29 < BlueMatt> i dont think you need to 09:29 < BlueMatt> i agree I'd prefer to move the pr forward 09:29 < BlueMatt> i can go audit more fully to figure out if there are any actual bugs introduced 09:29 < cfields_> ok. Well, you can take the branch above as proof that they don't change :) 09:30 < cfields_> BlueMatt: ok, yes, that'd be easier. I was wanting to get gmaxwell/sipa's opinion on deterministic siphash for node nonce first anyway. 09:31 < Victorsueca> gmaxwell: wouldn't that potentially lead to a split network with the nodes that ban peers that send unsolicited blocks on one side and the peers that don't know they're not supposed to send unsolicited blocks on the other? 09:33 < BlueMatt> cfields_: heh, thanks for pointing out that nVersion is already const - your SetVersion violates C++ spec :p 09:33 < BlueMatt> cfields_: https://github.com/bitcoin/bitcoin/pull/8708/files#r85565594 09:34 < cfields_> BlueMatt: same hack we use for serializing tx/block, so i figured i could get away with it :) 09:34 < BlueMatt> cfields_: sipa has open prs to fix it for tx/block :p 09:34 < BlueMatt> soo....no 09:34 < BlueMatt> :p 09:35 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 09:35 -!- gluytium [~g@45.63.76.107] has quit [Ping timeout: 252 seconds] 09:35 < cfields_> BlueMatt: must exist non-const? I'm going to have to call you on that. Going to either learn something or look like an idiot :) 09:36 < BlueMatt> cfields_: i dont recall the exact wording, it either must exist somewhere as non-const reference (so possibly the constructor is enough), or it must exist afterwards as non-const 09:36 < BlueMatt> I'm sure there is something like this in the spec, just not sure if the setting in the constructor qualifies 09:39 < BlueMatt> sipa: might recall better than I 09:40 -!- binns [sid105317@21/bitcoin/binns] has quit [Write error: Connection reset by peer] 09:40 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-rciknzszcjtggjyd] has quit [Read error: Connection reset by peer] 09:40 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-gyndjovkttvjkawj] has quit [Read error: Connection reset by peer] 09:40 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Remote host closed the connection] 09:41 -!- binns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 09:41 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-mstznvfiweecveal] has joined #bitcoin-core-dev 09:42 -!- adiabat [~adiabat@67.205.158.84] has quit [Ping timeout: 256 seconds] 09:42 -!- helo [~helo@unaffiliated/helo] has quit [Ping timeout: 256 seconds] 09:42 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 09:43 -!- helo [~helo@unaffiliated/helo] has joined #bitcoin-core-dev 09:43 < cfields_> BlueMatt: thanks, on phone, will take a look in a sec 09:44 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-deyaewtponxupkoo] has joined #bitcoin-core-dev 09:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:52 -!- d_t [~textual@83-244-233-135.cust-83.exponential-e.net] has joined #bitcoin-core-dev 09:53 < BlueMatt> cfields_: stack overflow, as well as how i read the notes section on cppreference, indicate this is undefined...so folks are stating it clearly as anything defined with const cannot be const_cast'ed, cppreference says "Modifying a const object through a non-const access path...results in undefined behavior" 09:58 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has quit [Quit: WeeChat 1.4] 09:59 < jtimon> am I doing something obviously wrong to get memory access violations in the market lines here https://0bin.net/paste/3ytYmDeGLDb+tlZy#sQXtt4ZyeODcf2u-wuibKPFEr9LsL8hr/bRHSIEVoVr ? 10:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 10:01 < BlueMatt> jtimon: secp context not set up? 10:01 < BlueMatt> (ie no ECC_Start call) 10:03 < jtimon> I thought that was done globally for the tests in test_bitcoin.cpp, but let me try 10:03 < BlueMatt> oh, in tests? dunno 10:07 < jtimon> oh, I need to do the BOOST_FIXTURE_TEST_SUITE thing if I want to reuse that ECC_Start, if I do my own it seems to cause conflicts with the other call 10:07 < jtimon> thanks a lot! 10:07 < sipa> BlueMatt: correct... though i'm sure we already violate that elsewhere 10:08 < sipa> BlueMatt: in particular in CTransaction, which i have a PR for to fix 10:08 < BlueMatt> sipa: still, best not to introduce more :p 10:09 < sipa> agree. 10:10 * BlueMatt is available to trade reviews 10:10 < BlueMatt> still trying to get 8969 in 10:11 < BlueMatt> :p 10:11 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 10:12 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 10:12 -!- ghtdak [~ghtdak@unaffiliated/ghtdak] has joined #bitcoin-core-dev 10:21 < sipa> BlueMatt: can you have a look at 8580? 10:21 < cfields_> BlueMatt: i'll look through again and ack in a min 10:21 < BlueMatt> sipa: lol, needs rebase again :p 10:21 < BlueMatt> but I can look, is that your preferred version? 10:22 -!- rebroad [~rebroad@223.205.208.152] has quit [Ping timeout: 260 seconds] 10:22 -!- harrymm [~wayne@104.238.45.39] has quit [Ping timeout: 244 seconds] 10:22 < sipa> BlueMatt: i expect the rebase to be trivial 10:22 -!- rebroad [~rebroad@223.205.208.152] has joined #bitcoin-core-dev 10:22 < cfields_> BlueMatt: mm, how can you move a class with a const member, then? I assumed a const_cast there was correct. Looks like I need to read up. 10:22 < BlueMatt> sipa: k, will look 10:23 < BlueMatt> cfields_: move doesnt specify that the originating object must be invalidated, only that it may be and any future access is undefined? 10:24 < cfields_> BlueMatt: yes, but the target object's const member must be re-assigned 10:25 < BlueMatt> cfields_: hmm? I may be missing what you're referring to with move here 10:25 < cfields_> BlueMatt: nm, not relevant. 10:26 < cfields_> BlueMatt: i'll just give nVersion a const accessor and leave the assert in Set(). I just hope there aren't a million users of pnode->nSendVersion 10:26 < cfields_> *i'll just give nSendVersion. 10:26 < BlueMatt> make it private? 10:26 < cfields_> yea 10:27 < cfields_> oh wait, it already is. that was easy :) 10:27 < BlueMatt> heh 10:30 < sipa> BlueMatt: move must bring the moved-from object in a valid, but not further soecified state 10:31 < sipa> BlueMatt: it *is* allowed to reuse a moved from object if you first use a call that fixes all its observable behaviour again 10:31 < BlueMatt> sipa: yea, thats what i said? 10:32 < sipa> ah, i didn't read the whole conversation 10:32 < BlueMatt> hum, yea, i cant claim to be a C++11 person yet 10:32 < sipa> cfields_: you cannot move an object with a const member 10:32 < BlueMatt> you cant? 10:32 < sipa> well, you can if you fon't modify the source 10:32 < BlueMatt> well, yes, that was my comment 10:32 < sipa> but that would make it a copy 10:33 < BlueMatt> only for that member 10:33 < sipa> right 10:33 < sipa> seems i'm not fully awake yet 10:33 < cfields_> sipa: yes, I see that now. I've always just setup a move operator that does a const_cast and changes. In some places that makes perfect sense. Seems it's not actually to spec, though. 10:33 < cfields_> (again, like our current tx serializers) 10:34 < sipa> cfields_: see 8580 :) 10:34 < cfields_> heh, right 10:34 < BlueMatt> bbl, lunch 10:34 < sipa> there is an annoying confusion between observably constant and representation constness in c++ 10:35 < cfields_> i suppose i should review/ack that too, then. adding it to the list. 10:35 -!- harrymm [~wayne@104.238.32.102] has joined #bitcoin-core-dev 10:35 < cfields_> sipa: mind explaining the distinction? 10:48 -!- harrymm [~wayne@104.238.32.102] has quit [Ping timeout: 265 seconds] 10:49 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-dijhunzhwyrvlgbn] has joined #bitcoin-core-dev 10:50 -!- Ylbam_ is now known as Ylbam 10:50 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dijhunzhwyrvlgbn] has quit [Client Quit] 10:50 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sschuuzlamsnhwcm] has joined #bitcoin-core-dev 10:51 -!- todamoon [57033f8b@gateway/web/freenode/ip.87.3.63.139] has joined #bitcoin-core-dev 10:51 -!- rebroad [~rebroad@223.205.208.152] has quit [Ping timeout: 250 seconds] 10:51 -!- todamoon [57033f8b@gateway/web/freenode/ip.87.3.63.139] has quit [Client Quit] 10:58 -!- pigeons [~pigeons@94.242.209.214] has joined #bitcoin-core-dev 11:07 -!- harrymm [~wayne@104.238.32.8] has joined #bitcoin-core-dev 11:12 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [] 11:21 -!- harrymm [~wayne@104.238.32.8] has quit [Ping timeout: 256 seconds] 11:35 -!- harrymm [~wayne@171.5.190.134] has joined #bitcoin-core-dev 12:00 -!- harrymm [~wayne@171.5.190.134] has quit [Ping timeout: 256 seconds] 12:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:04 -!- harrymm [~wayne@171.5.190.134] has joined #bitcoin-core-dev 12:08 -!- harrymm [~wayne@171.5.190.134] has quit [Ping timeout: 244 seconds] 12:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 12:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 12:25 -!- randy-waterhouse [~kiwigb@43.228.156.99] has joined #bitcoin-core-dev 12:26 -!- randy-waterhouse [~kiwigb@43.228.156.99] has quit [Changing host] 12:26 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 12:26 -!- harrymm [~wayne@104.222.140.123] has joined #bitcoin-core-dev 12:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:08 < BlueMatt> sipa: can a constructor call a function which then const_casts? 13:28 < luke-jr> 0.13.1 fails tests on sparc64? https://buildd.debian.org/status/package.php?p=bitcoin&suite=sid#problem-6 13:29 < BlueMatt> what the shit 13:30 < BlueMatt> and alpha 13:30 < luke-jr> yeah 13:30 < BlueMatt> similar errors on both 13:32 < sipa> BlueMatt: a bit more detail? 13:32 < luke-jr> looks like they have a few patches, not clear if relevant 13:32 < BlueMatt> sipa: nvm 13:32 < luke-jr> seems like just portability-related 13:37 -!- ArtGravity [~artgravit@2602:47:d89d:b600:5091:bc2b:ea68:f97e] has joined #bitcoin-core-dev 13:38 < ArtGravity> Does anyone know how to fix the bitcoin-qt tray icon and integrated menus in the most recent Trusty client from the Ubuntu PPA? 13:38 < BlueMatt> ArtGravity: ruh roh, they not work? 13:39 < ArtGravity> The tray icon is in the upper left 13:39 < ArtGravity> the integrated menus are MIA 13:39 < BlueMatt> were they working in 0.13.0? 13:39 < ArtGravity> They worked before I upgraded today 13:39 < ArtGravity> I cannot guarantee that I was on 0.13.0, but is likely I was 13:40 < luke-jr> check your debug.log 13:40 < ArtGravity> What am I looking for in ~/.bitcoin/debug.log ? 13:41 < ArtGravity> just version number prior to today? 13:41 < luke-jr> yeah 13:41 < ArtGravity> Confirmed 13:41 < ArtGravity> I was on 0.13.0 13:42 < ArtGravity> The qt-tray icon was in the ubuntu notification area on that version 13:42 < ArtGravity> It's been some time since I have used the menus, so I cannot confirm or deny their presence on that version 13:42 < BlueMatt> ArtGravity: see https://github.com/bitcoin/bitcoin/issues/8043 and https://github.com/bitcoin/bitcoin/issues/7497#issuecomment-182341185 - does removing appmenu-qt5 fix it? 13:43 < BlueMatt> oh, wait, thats non-unity des 13:43 < BlueMatt> anyway, does it look like 8043 for you? 13:43 < ArtGravity> I am on Unity 13:44 < ArtGravity> my icon appears where the B in Bitcoin Core is in the image on 8043 13:44 < ArtGravity> In the top left of the screen 13:44 < BlueMatt> I'm not farmiliar with unity...is that the equivalent of the screenshot in 8043? 13:45 < ArtGravity> I'm not having the missing menu problem 13:45 < ArtGravity> Same desktop environment as in the 8043 screenshot 13:45 < ArtGravity> different symptoms 13:45 < BlueMatt> wait, so whats the bug? that you dont get the file, settings, etc menus? 13:46 < ArtGravity> Tray icon appears in upper left of screen instead of in notification area 13:46 < BlueMatt> cfields_: welp, looks like the ppa is gonna switch back to qt4 13:46 < cfields_> BlueMatt: ? 13:46 < ArtGravity> menus that should appear in the top menu bar of unity are missing 13:46 < BlueMatt> ArtGravity: I really dont know what that means...screenshot? I have no idea where its /supposed/ to show up :p 13:46 < BlueMatt> cfields_: 0.13.1 was the first release with qt5, and if there are bugs gotta go back 13:47 < ArtGravity> in the 8043 screenshot, where it says Bitcoin Core - Wallet at the top left of the screen is where it should have the usual menus 13:47 < ArtGravity> like File, Edit, View, Help, etc 13:47 < BlueMatt> and what does it have there? 13:48 < BlueMatt> the logo 13:48 < BlueMatt> but the menus are in the window, i assume? 13:48 < BlueMatt> ie not missing 13:48 -!- dzijeka [~dzijeka@95.215.44.99] has quit [Quit: Leaving] 13:48 < ArtGravity> Just the logo covering the "Bit" in Bitcoin Core 13:48 < ArtGravity> No menus 13:48 < cfields_> BlueMatt: Ah yea, 0.13 -> 0.13.1 definitely shouldn't switch qt4 -> qt5. I didn't realize 0.13 used qt4. 13:48 < BlueMatt> ArtGravity: anyway, can you file an issue on github? 13:48 < ArtGravity> Yes 13:48 < BlueMatt> ArtGravity: thanks 13:49 < BlueMatt> probably with screenshot 13:49 < ArtGravity> NP 13:49 < BlueMatt> cfields_: well the only way to switch was dropping precise, which i did in 0.13, but only after uploading for others 13:49 < BlueMatt> so this was the first opportunity 13:49 < luke-jr> cfields_: PPA, not gitian binaries 13:49 < ArtGravity> I do have appmenu-qt5 installed 13:49 < BlueMatt> ArtGravity: hmm, try without? 13:49 < BlueMatt> if it works without thats an easier fix 13:49 < ArtGravity> I can try removing that first and see what happens 13:50 < BlueMatt> thanks 13:50 < cfields_> BlueMatt: mm, even if it does work, that's definitely an unexpected change imo 13:50 < BlueMatt> cfields_: it /should/ just be a library change, not anything a user would see 13:51 < ArtGravity> I remember this happening before and doing something to fix it 13:51 < cfields_> BlueMatt: eh? guis and integration are vastly different between qt4 and qt5 13:51 < ArtGravity> My Dogecoin had the problem too 13:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 13:53 < cfields_> bbl 13:57 < ArtGravity> w/o appmenu-qt5 I get the menu in the app instead of integrated into Unity 13:57 < ArtGravity> The tray icon still appears in the wrong location 14:02 < BlueMatt> arg, ok, thanks 14:02 < BlueMatt> can you file an issue? 14:02 < ArtGravity> Sure 14:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:15 < BlueMatt> sipa: ok, you owe me review :p 14:18 < sipa> BlueMatt: this is true. 14:19 -!- d_t [~textual@83-244-233-135.cust-83.exponential-e.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:22 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 250 seconds] 14:24 < sipa> BlueMatt: the whole reason for needing the stream::Construct() rather than T(Steam&) is nVersion and nType 14:25 < sipa> BlueMatt: the stream determines the value of those 14:25 < sipa> i've argued before that we need to get rid of the nVersion and nType being passed around everywhere, and instead just make them accessors on the stream 14:26 < BlueMatt> sipa: then please do :p 14:27 < sipa> please review 8468 then :) 14:27 < BlueMatt> sipa: I meant just for CTransaction initially 14:28 < sipa> BlueMatt: bleh 14:28 < BlueMatt> sipa: its incredibly shitty to have the Construct stuff there, especially given the random hacks and tons of assert(false) functions 14:28 < sipa> BlueMatt: i agree 14:28 < BlueMatt> so break the shitty api :p 14:41 * sipa breaks it thoroughly 14:41 < BlueMatt> it deserved it 14:42 < Victorsueca> lol 14:54 < GitHub166> [bitcoin] EthanHeilman opened pull request #9037: net: Add test-before-evict discipline to addrman (master...test-before-evict) https://github.com/bitcoin/bitcoin/pull/9037 15:09 < ArtGravity> BlueMatt: Issue #9038 submitted 15:10 -!- cryptapus is now known as cryptapus_afk 15:13 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 15:18 -!- ArtGravity [~artgravit@2602:47:d89d:b600:5091:bc2b:ea68:f97e] has quit [Quit: ArtGravity] 15:28 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 15:32 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 16:01 -!- Lauda_ [~quassel@2a06:8ec0:3::1:b224] has joined #bitcoin-core-dev 16:01 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Read error: Connection reset by peer] 16:04 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 16:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Disconnected by services] 16:04 -!- Victor_sueca is now known as Victorsueca 16:09 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 16:13 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 16:42 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 16:44 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 16:45 -!- zooko [~user@73.93.143.0] has joined #bitcoin-core-dev 17:08 -!- Squidicc [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 17:08 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:10 -!- squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Ping timeout: 252 seconds] 18:04 -!- rebroad [~rebroad@223.205.208.152] has joined #bitcoin-core-dev 18:13 -!- jtimon [~quassel@211.28.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 18:45 < GitHub115> [bitcoin] sipa opened pull request #9039: Various serialization simplifcations and optimizations (master...simpleserial) https://github.com/bitcoin/bitcoin/pull/9039 18:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 18:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:57 -!- achow101 [~achow101@unaffiliated/achow101] has left #bitcoin-core-dev ["Leaving"] 18:58 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 19:02 -!- zooko [~user@73.93.143.0] has quit [Ping timeout: 268 seconds] 19:03 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 19:26 -!- fengling [~fengling@110.241.61.9] has joined #bitcoin-core-dev 19:50 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sschuuzlamsnhwcm] has quit [Quit: Connection closed for inactivity] 19:55 -!- Squidicc is now known as squidicuz 20:03 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:05 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 20:07 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-mstznvfiweecveal] has quit [Quit: Connection closed for inactivity] 20:19 -!- fengling [~fengling@110.241.61.9] has quit [Ping timeout: 268 seconds] 20:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 20:59 -!- rebroad [~rebroad@223.205.208.152] has quit [Ping timeout: 250 seconds] 21:15 -!- fengling [~fengling@110.241.61.9] has joined #bitcoin-core-dev 21:37 -!- fengling [~fengling@110.241.61.9] has quit [Ping timeout: 268 seconds] 21:58 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 21:58 -!- rebroad [~rebroad@183.89.27.17] has joined #bitcoin-core-dev 22:33 -!- rebroad [~rebroad@183.89.27.17] has quit [Ping timeout: 256 seconds] 22:35 -!- dermoth [~thomas@dsl-66-36-159-136.mtl.aei.ca] has quit [Read error: Connection reset by peer] 22:36 -!- dermoth [~thomas@dsl-66-36-159-136.mtl.aei.ca] has joined #bitcoin-core-dev 22:41 -!- Lauda_ is now known as Lauda 22:41 -!- Lauda [~quassel@2a06:8ec0:3::1:b224] has quit [Changing host] 22:41 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 22:45 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 22:51 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 22:59 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-wahkdadkfteibdna] has joined #bitcoin-core-dev 23:00 -!- dermoth [~thomas@dsl-66-36-159-136.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:01 -!- dermoth [~thomas@dsl-66-36-159-136.mtl.aei.ca] has joined #bitcoin-core-dev 23:20 -!- dermoth [~thomas@dsl-66-36-159-136.mtl.aei.ca] has quit [Ping timeout: 256 seconds] 23:37 -!- rebroad [~rebroad@183.89.25.98] has joined #bitcoin-core-dev