--- Day changed Mon Nov 07 2016
00:12 -!- DigiByteDev [~JT2@101.78.224.202] has quit [Quit: DigiByteDev]     
00:17 -!- DigiByteDev [~JT2@101.78.224.202] has joined #bitcoin-core-dev     
00:19 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:21 < GitHub70> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/05009935f9ac...7b22e5001a3d
00:21 < GitHub70> bitcoin/master 21b8f3d Kaz Wesley: LockedPool: test handling of invalid allocations...
00:21 < GitHub70> bitcoin/master 0b59f80 Kaz Wesley: LockedPool: fix explosion for illegal-sized alloc...
00:21 < GitHub70> bitcoin/master b3ddc5e Kaz Wesley: LockedPool: avoid quadratic-time allocation...
00:22 < GitHub111> [bitcoin] laanwj closed pull request #9070: Lockedpool fixes (master...lockedpool) https://github.com/bitcoin/bitcoin/pull/9070
00:26 -!- DigiByteDev [~JT2@101.78.224.202] has quit [Quit: DigiByteDev]     
00:27 -!- DigiByteDev [~JT2@101.78.224.202] has joined #bitcoin-core-dev     
00:28 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev     
00:28 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host]     
00:28 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
00:34 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
00:42 -!- eljaycee [~eljaycee@2a02:c7d:2a3a:8b00:ddc:36df:8cfc:e514] has quit [Quit: Leaving]     
00:47 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev     
00:51 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
00:53 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit []     
00:59 -!- laurentmt [~Thunderbi@80.215.138.152] has joined #bitcoin-core-dev     
01:00 -!- laurentmt [~Thunderbi@80.215.138.152] has quit [Client Quit]     
01:07 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
01:15 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev     
01:22 -!- rubensayshi [~ruben@82.201.92.138] has joined #bitcoin-core-dev     
01:27 -!- JackH [~laptop@79-73-184-38.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]     
01:32 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
01:36 < GitHub190> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b22e5001a3d...c8c572f8f1ea
01:36 < GitHub190> bitcoin/master b98c14c Cory Fields: serialization: teach serializers variadics...
01:36 < GitHub190> bitcoin/master 3e32cd0 Cory Fields: connman is in charge of pushing messages...
01:36 < GitHub190> bitcoin/master ea33268 Cory Fields: net: switch all callers to connman for pushing messages...
01:37 < GitHub0> [bitcoin] laanwj closed pull request #8708: net: have CConnman handle message sending (master...connman-send) https://github.com/bitcoin/bitcoin/pull/8708
01:38 -!- udiWertheimer [~udi@bzq-82-81-94-166.red.bezeqint.net] has joined #bitcoin-core-dev     
01:40 < MarcoFalke> I feel like we should change the releases to only contain a link to the release notes and not the full release notes copied: https://github.com/bitcoin/bitcoin/releases
01:40 -!- udiWertheimer [~udi@bzq-82-81-94-166.red.bezeqint.net] has quit [Client Quit]     
01:40 <@wumpus> why? redundancy is pretty good for distributed projects? :-)
01:40 -!- udiWerth_ [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has joined #bitcoin-core-dev     
01:41 < MarcoFalke> There is no redundancy when the link point to github as well.
01:41 -!- udiWerth_ [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has quit [Client Quit]     
01:41 <@wumpus> ah you mean linking to the release notes on github - yes that'd make sense
01:41 <@wumpus> true
01:42 < MarcoFalke> It takes 10 minutes to scroll though the releases page
01:42 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has joined #bitcoin-core-dev     
01:42 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 250 seconds]     
01:43 <@wumpus> I'm ok with replacing them with a link, on the other hand sipa did all this work to put them in in the first place, I'm not sure it's worth the trouble re-doing it another way
01:43 < MarcoFalke> Also, no one will notice if they are changed by someone. They are not signed and can not be verified
01:43 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has quit [Client Quit]     
01:43 -!- laurentmt [~Thunderbi@80.215.138.152] has joined #bitcoin-core-dev     
01:43 < MarcoFalke> Should be a matter of less than 10 minutes. I am happy to do it if sipa is ok with it.
01:44 <@wumpus> also updating that page should probably be part of the release process
01:57 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has joined #bitcoin-core-dev     
02:09 < GitHub68> [bitcoin] MarcoFalke opened pull request #9093: [doc] release-process: Mention GitHub release and archived release notes (master...Mf1611-docRel) https://github.com/bitcoin/bitcoin/pull/9093
02:16 -!- laurentmt [~Thunderbi@80.215.138.152] has quit [Quit: laurentmt]     
02:29 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
02:37 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-amndriljvxezdqkn] has quit [Quit: Connection closed for inactivity]     
02:40 -!- DigiByteDev [~JT2@101.78.224.202] has quit [Quit: DigiByteDev]     
02:45 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit []     
02:46 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
02:51 < GitHub89> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c8c572f8f1ea...5fa7b07565d2
02:51 < GitHub89> bitcoin/master 159ed95 Jiaxing Wang: base58: Improve DecodeBase58 performance....
02:51 < GitHub89> bitcoin/master e892dc1 Jiaxing Wang: Use prefix operator in for loop of DecodeBase58.
02:51 < GitHub89> bitcoin/master 5fa7b07 Wladimir J. van der Laan: Merge #8736: base58: Improve DecodeBase58 performance....
02:51 < GitHub141> [bitcoin] laanwj closed pull request #8736: base58: Improve DecodeBase58 performance. (master...speedup-decodebase58) https://github.com/bitcoin/bitcoin/pull/8736
03:02 -!- cdecker [~quassel@2a02:aa16:1105:4a80:9979:e33b:d876:1cde] has joined #bitcoin-core-dev     
03:05 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-vrlgzvmlmvabyfww] has joined #bitcoin-core-dev     
03:13 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
03:15 < GitHub10> [bitcoin] laanwj opened pull request #9094: qt: Use correct conversion function for boost::path datadir (master...2016_11_datadir_in_console) https://github.com/bitcoin/bitcoin/pull/9094
03:18 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
03:21 < btcdrak> luke-jr: I think Andreas has a point https://github.com/bitcoin/bips/pull/472#issuecomment-258794458
03:22 -!- windsok [~windsok@45.63.59.8] has quit [Remote host closed the connection]     
03:29 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev     
03:30 < GitHub154> [bitcoin] laanwj closed pull request #8158: Simplify calls to retrieve credit and balance (master...enhancement/unification-wallet-balance) https://github.com/bitcoin/bitcoin/pull/8158
03:42 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Ping timeout: 250 seconds]     
03:46 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev     
03:52 < GitHub181> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5fa7b07565d2...44f2df613f23
03:52 < GitHub181> bitcoin/master 4b04e32 isle2983: [copyright] copyright header style uniform...
03:52 < GitHub181> bitcoin/master 44f2df6 Wladimir J. van der Laan: Merge #8675: Make copyright header lines uniform...
03:52 < GitHub151> [bitcoin] laanwj closed pull request #8675: Make copyright header lines uniform (master...copyright-made-uniform) https://github.com/bitcoin/bitcoin/pull/8675
03:54 < GitHub23> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/44f2df613f23...2b799ae9e1e0
03:54 < GitHub23> bitcoin/master 66ca6cd S. Matthew English: Enforcing consistency, 'gitian' to 'Gitian'...
03:54 < GitHub23> bitcoin/master 2b799ae MarcoFalke: Merge #9083: Enforcing consistency, 'gitian' to 'Gitian'...
03:54 < GitHub179> [bitcoin] MarcoFalke closed pull request #9083: Enforcing consistency, 'gitian' to 'Gitian' (master...patch-9) https://github.com/bitcoin/bitcoin/pull/9083
04:01 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]     
04:03 < GitHub3> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b799ae9e1e0...2fae5b93468c
04:03 < GitHub3> bitcoin/master faead5e MarcoFalke: [doc] release-process: Mention GitHub release and archived release notes
04:03 < GitHub3> bitcoin/master 2fae5b9 Wladimir J. van der Laan: Merge #9093: [doc] release-process: Mention GitHub release and archived release notes...
04:04 < GitHub31> [bitcoin] laanwj closed pull request #9093: [doc] release-process: Mention GitHub release and archived release notes (master...Mf1611-docRel) https://github.com/bitcoin/bitcoin/pull/9093
04:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
04:07 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
04:07 < GitHub126> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2fae5b93468c...078900df75f1
04:07 < GitHub126> bitcoin/master 1ee6f91 nomnombtc: new var DIST_CONTRIB adds useful things for packagers from contrib/ to EXTRA_DIST
04:07 < GitHub126> bitcoin/master 078900d Wladimir J. van der Laan: Merge #8568: new var DIST_CONTRIB adds useful things for packagers from contrib...
04:10 < bitcoin-git> [bitcoin] laanwj closed pull request #8568: new var DIST_CONTRIB adds useful things for packagers from contrib (master...DIST_CONTRIB) https://github.com/bitcoin/bitcoin/pull/8568
04:10 < gribble> https://github.com/bitcoin/bitcoin/issues/8568 | new var DIST_CONTRIB adds useful things for packagers from contrib by nomnombtc · Pull Request #8568 · bitcoin/bitcoin · GitHub
04:14 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
04:14 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/078900df75f1...c113a651f1f5
04:14 < bitcoin-git> bitcoin/master d32036a Gregory Maxwell: Use RelevantServices instead of node_network in AttemptToEvict....
04:14 < bitcoin-git> bitcoin/master c113a65 Wladimir J. van der Laan: Merge #9052: Use RelevantServices instead of node_network in AttemptToEvict....
04:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9052 | Use RelevantServices instead of node_network in AttemptToEvict. by gmaxwell · Pull Request #9052 · bitcoin/bitcoin · GitHub
04:14 < bitcoin-git> [bitcoin] laanwj closed pull request #9052: Use RelevantServices instead of node_network in AttemptToEvict. (master...prefer_relevant2) https://github.com/bitcoin/bitcoin/pull/9052
04:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9052 | Use RelevantServices instead of node_network in AttemptToEvict. by gmaxwell · Pull Request #9052 · bitcoin/bitcoin · GitHub
04:15 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds]     
04:17 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
04:19 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
04:19 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
04:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds]     
04:20 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c113a651f1f5...1e50d22ed2df
04:20 < bitcoin-git> bitcoin/master 1f951c6 R E Broadley: Allow filterclear messages for enabling TX relay only....
04:20 < bitcoin-git> bitcoin/master 1e50d22 Wladimir J. van der Laan: Merge #8709: Allow filterclear messages for enabling TX relay only....
04:20 < gribble> https://github.com/bitcoin/bitcoin/issues/8709 | Allow filterclear messages for enabling TX relay only. by rebroad · Pull Request #8709 · bitcoin/bitcoin · GitHub
04:20 < bitcoin-git> [bitcoin] laanwj closed pull request #8709: Allow filterclear messages for enabling TX relay only. (master...AllowFilterclear) https://github.com/bitcoin/bitcoin/pull/8709
04:20 < gribble> https://github.com/bitcoin/bitcoin/issues/8709 | Allow filterclear messages for enabling TX relay only. by rebroad · Pull Request #8709 · bitcoin/bitcoin · GitHub
04:22 -!- Victor_sueca is now known as Victorsueca     
04:22 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 265 seconds]     
04:33 <@wumpus> can whoever is in charge of gribble please make it ignore user 'bitcoin-git'?
04:34 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
04:34 <@wumpus> nanotube ^^
04:35 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
04:38 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1e50d22ed2df...3c03dc2cfc07
04:38 < bitcoin-git> bitcoin/master b2322e0 Alex Morcos: Remove priority estimation
04:38 < bitcoin-git> bitcoin/master 0bd581a Alex Morcos: add release notes for removal of priority estimation
04:38 < bitcoin-git> bitcoin/master 3c03dc2 Wladimir J. van der Laan: Merge #7730: Remove priority estimation...
04:38 < gribble> https://github.com/bitcoin/bitcoin/issues/7730 | Remove priority estimation by morcos · Pull Request #7730 · bitcoin/bitcoin · GitHub
04:38 < bitcoin-git> [bitcoin] laanwj closed pull request #7730: Remove priority estimation (master...removePriEst) https://github.com/bitcoin/bitcoin/pull/7730
04:38 < gribble> https://github.com/bitcoin/bitcoin/issues/7730 | Remove priority estimation by morcos · Pull Request #7730 · bitcoin/bitcoin · GitHub
04:40 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev     
04:42 -!- murch_ [~murch@p4FE38D58.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
04:43 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c03dc2cfc07...8c6218a28ae8
04:43 < bitcoin-git> bitcoin/master 5ca8ef2 Wladimir J. van der Laan: libconsensus: Add input validation of flags...
04:43 < bitcoin-git> bitcoin/master 8c6218a Wladimir J. van der Laan: Merge #8976: libconsensus: Add input validation of flags...
04:43 < gribble> https://github.com/bitcoin/bitcoin/issues/8976 | libconsensus: Add input validation of flags by laanwj · Pull Request #8976 · bitcoin/bitcoin · GitHub
04:43 < bitcoin-git> [bitcoin] laanwj closed pull request #8976: libconsensus: Add input validation of flags (master...2016_10_bitcoinconsensus_input_checking) https://github.com/bitcoin/bitcoin/pull/8976
04:43 < gribble> https://github.com/bitcoin/bitcoin/issues/8976 | libconsensus: Add input validation of flags by laanwj · Pull Request #8976 · bitcoin/bitcoin · GitHub
04:44 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c6218a28ae8...0b2322b144a0
04:44 < bitcoin-git> bitcoin/master ff6639b Pavel Janík: Do not shadow local variable
04:44 < bitcoin-git> bitcoin/master 0b2322b Wladimir J. van der Laan: Merge #8981: Wshadow: Do not shadow argument with a local variable...
04:44 < gribble> https://github.com/bitcoin/bitcoin/issues/8981 | Wshadow: Do not shadow argument with a local variable by paveljanik · Pull Request #8981 · bitcoin/bitcoin · GitHub
04:44 < bitcoin-git> [bitcoin] laanwj closed pull request #8981: Wshadow: Do not shadow argument with a local variable (master...20161020_Wshadow_rpcdump) https://github.com/bitcoin/bitcoin/pull/8981
04:44 < gribble> https://github.com/bitcoin/bitcoin/issues/8981 | Wshadow: Do not shadow argument with a local variable by paveljanik · Pull Request #8981 · bitcoin/bitcoin · GitHub
04:55 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
04:55 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has joined #bitcoin-core-dev     
05:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds]     
05:09 -!- rebroad [~rebroad@175.143.63.250] has joined #bitcoin-core-dev     
05:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
05:15 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
05:17 < nanotube> wumpus: done
05:20 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
05:20 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0b2322b144a0...78cdd643d317
05:20 < bitcoin-git> bitcoin/master e760b30 Wladimir J. van der Laan: qt: Use correct conversion function for boost::path datadir...
05:20 < bitcoin-git> bitcoin/master 78cdd64 Jonas Schnelli: Merge #9094: qt: Use correct conversion function for boost::path datadir...
05:20 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9094: qt: Use correct conversion function for boost::path datadir (master...2016_11_datadir_in_console) https://github.com/bitcoin/bitcoin/pull/9094
05:24 < MarcoFalke> jonasschnelli: Can you check if test_random.h is on your gitian machine?
05:24 < MarcoFalke> the builds are broken since https://github.com/bitcoin/bitcoin/blob/cdfb7755a6af2e95e8598ca8e8d6896c745bcd72/src/test/test_random.h is merged
05:26 < jonasschnelli> MarcoFalke: the first errored build was on 19th of october https://bitcoin.jonasschnelli.ch/nightlybuilds/2016-10-19/
05:26 < jonasschnelli> Matches ~PR8914
05:29 -!- laurentmt [~Thunderbi@80.215.138.152] has joined #bitcoin-core-dev     
05:29 -!- laurentmt [~Thunderbi@80.215.138.152] has quit [Client Quit]     
05:30 < MarcoFalke> Jup, I am assuming the file is locally corrupted on your machine
05:33 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever]     
05:35 < jonasschnelli> MarcoFalke: hmm... rm inputs/bitcoin and do a fresh local heckout?
05:36 < jonasschnelli> File looks good:
05:36 < jonasschnelli> openssl dgst -sha256 src/test/test_random.h 
05:36 < jonasschnelli> SHA256(src/test/test_random.h)= a118ebaa4c62ee05eddd516a819d8311613140abd8fda70fa9ec62e20b2bd83b
05:37 < sipa> wumpus, MarcoFalke: it wasn't much work, and i was a bit surprised there was no way to collapse the notes in the releases page, so of anyone cares, i'm fine with changing it to links (but i hope it doesn't cause mass mails again)
05:39 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev     
05:43 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
05:44 -!- ChillazZ [~ChillazZ@194.97.152.20] has quit [Ping timeout: 256 seconds]     
06:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9095: test: Fix test_random includes (master...Mf1611-testRand) https://github.com/bitcoin/bitcoin/pull/9095
06:04 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:07 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
06:07 -!- mol is now known as moli     
06:08 < MarcoFalke> Did anyone receive a email for the edit of https://github.com/bitcoin/bitcoin/releases/tag/v0.13.1?
06:10 <@wumpus> I didn't
06:11 < jonasschnelli> No email
06:11 <@wumpus> looks like you're safe, or maybe gh is queing them all up to send them at once once you finish editing all the tags :)
06:16 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
06:17 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]     
06:21 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
06:24 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
06:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]     
06:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:44 < jonasschnelli> MarcoFalke: compiling 9095 over gitian still gives me: test/coins_tests.cpp:10:30: fatal error: test/test_random.h: No such file or directory
06:44 < MarcoFalke> :/     
06:45 < MarcoFalke> Trying local gitian build
06:45 < jonasschnelli> I don't understand why we don't have the test headers in the Makefile.test.include
06:45 < jonasschnelli> I know it can't be the reason.. but still
06:48 <@wumpus> I don't understand it either
06:49 <@wumpus> the .h files should be in SOURCES too
06:49 <@wumpus> maybe just try adding them?
06:53 < sdaftuar> MarcoFalke: regarding the wallet-dump.py test issues i've been seeing, here's an example of a test failure on the machine in question: https://0bin.net/paste/iL+SYGPlmsW0E4DH#
06:53 < sdaftuar> MarcoFalke: and the associated debug.log: https://0bin.net/paste/MB8ipmBEQ9WgjMYS#
06:54 < sdaftuar> i don't really have any idea why it's so slow on this machine that i use to run all the tests.  i agree with your observation that on other hardware, like the machine i do most of my work on, the test is very fast.
06:54 < jtimon> jonasschnelli: any thoughts on https://github.com/bitcoin/bitcoin/compare/master...jtimon:0.13-wallet-less-global ?
06:55 < jonasschnelli> jtimon: Yes. Why not. But I think there are more important global stuff to get rid of first.
06:56 < jonasschnelli> But your change makes sense
06:56 < jonasschnelli> But stuff like "nTxConfirmTarget" and "payTxFee" should be removed from the global scope
06:56 < jtimon> yeah, besides I didn't noticed the use of SoftSetBoolArg() when I wrote it though, I would like to do something about that first
06:57 < jonasschnelli> Also, there is no reason for declaring fWalletRbf in the header IMO.
06:57 < jtimon> just wanted to hear about the const versions of GetArg in general, 
06:57 < jtimon> thanks
06:57 < jonasschnelli> SetSoft is kinda magical. :)
06:57 < jtimon> mhmm, more kind of cheating :p
06:58 < MarcoFalke> sdaftuar: Can't decrypt the content in the link
06:58 < MarcoFalke> Is there a password after the hash#
06:58 < MarcoFalke> missing
06:58 <@wumpus> overhauling argument handling is kind of a project in itself, I wouldn't confound it with other refactors
06:59 < sdaftuar> MarcoFalke: oops.  here are the links again: https://0bin.net/paste/iL+SYGPlmsW0E4DH#mK-4hZ5Lc535os5rJ7Cr6MtHsqRaIOt7PIXpHN82qcX
06:59 < sdaftuar> https://0bin.net/paste/MB8ipmBEQ9WgjMYS#xGW8WnlIgwDGqWv9-6bbqtV5lvYXTt2jIDPohSVvfgR
07:04 < MarcoFalke> Maybe you are out of randomness
07:04 < MarcoFalke> Hmm, iirc we are using urandom, so it should not be the cause...
07:06 < MarcoFalke> Basically the refill key pool method "sleeps" for 8-9 seconds after generating a couple of keys
07:06 < sdaftuar> yeah i see that
07:10 < MarcoFalke> Would you mind benchmarking around that?
07:10 < MarcoFalke> Maybe around here: https://dev.visucore.com/bitcoin/doxygen/wallet_8cpp_source.html#l00098
07:10 < MarcoFalke> jonasschnelli: gitian fails locally
07:11 < MarcoFalke> for me as well
07:11 < jonasschnelli> MarcoFalke: Okay. Thats good.
07:11 < sdaftuar> sure, i'll give it a shot.
07:12 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]     
07:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:17 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
07:20 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
07:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Disconnected by services]     
07:21 -!- Victor_sueca is now known as Victorsueca     
07:22 < MarcoFalke> jtimon: Wouldn't it make sense to create a separate class for parsing instead.
07:22 < MarcoFalke> I mean not passing the global is a trivial improvement, but it won't help us in the long term goal
07:22 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
07:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
07:23 < jtimon> not sure, maybe, so far it would be just those 3 getarg methods, maybe getAmountArg too
07:24 < jtimon> I don't really see much diferrence on passing the map as it is as const or pass it as a class (also as const)
07:24 < MarcoFalke> I mean why would the wallet need to know that mapArgs is of such type? Why would the wallet need to know mapArgs exists at all?
07:25 < jtimon> why would it need to know about the new class? it's the same, no?
07:26 < MarcoFalke> Imo you are exposing too much internal details with the new interface.
07:30 < MarcoFalke> It is similar, but not the same. I think a new class could help to rework the arg handling.
07:30 < MarcoFalke> First, you instanciate CArgParse with the args provided by each module. Then you can parse the args and finally each module can ask the instance for the value of each arg...
07:31 -!- otium [~otium@2a01:e35:2eeb:c00:dec:a40d:7bf3:cd8f] has joined #bitcoin-core-dev     
07:31 -!- otium [~otium@2a01:e35:2eeb:c00:dec:a40d:7bf3:cd8f] has quit [Remote host closed the connection]     
07:31 < MarcoFalke> If there are args present in the map which are not provided by any module you can warn the user
07:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:42 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-cftvpgorvnftvcmm] has quit [Ping timeout: 250 seconds]     
07:42 -!- zmanian____ [sid113594@gateway/web/irccloud.com/x-hhiqaucswzfvpkcs] has quit [Ping timeout: 250 seconds]     
07:42 -!- wbnns [sid105317@21/bitcoin/binns] has quit [Ping timeout: 250 seconds]     
07:42 -!- mturquette [sid66043@gateway/web/irccloud.com/x-qwldozdxdmyanpcv] has quit [Ping timeout: 250 seconds]     
07:42 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-qhhgwhmscdkvqvnn] has quit [Ping timeout: 250 seconds]     
07:43 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-vrlgzvmlmvabyfww] has quit [Ping timeout: 250 seconds]     
07:43 -!- limpkin [sid20909@gateway/web/irccloud.com/x-gwoatmpugvodpsqj] has quit [Ping timeout: 250 seconds]     
07:43  * jtimon notes MANDATORY_SCRIPT_VERIFY_FLAGS is outdated
07:43 -!- cfields_ [~quassel@unaffiliated/cfields] has quit [Ping timeout: 250 seconds]     
07:43 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-deexnrkkxikxfyfb] has joined #bitcoin-core-dev     
07:44 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-ohuasgcdyuzafmef] has joined #bitcoin-core-dev     
07:44 -!- cfields [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev     
07:45 -!- zmanian____ [sid113594@gateway/web/irccloud.com/x-ctgdweobnuquhglt] has joined #bitcoin-core-dev     
07:45 < jtimon> MarcoFalke: oh, I see, yeah I guess for extra checks it may make sense, not sure it's worth it to parse a different mapArgs for each module and sounds like nasty work
07:45 -!- mturquette [sid66043@gateway/web/irccloud.com/x-fhbzdqqgycstsihd] has joined #bitcoin-core-dev     
07:45 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-zewodfzhphqgnbhi] has joined #bitcoin-core-dev     
07:46 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev     
07:46 < jtimon> regarding "exposing too much details" maybe a typedef for the map will help? or you just want to encapsulate the map? in that case you will definitely need more methods, like getAmountArg
07:48 -!- limpkin [sid20909@gateway/web/irccloud.com/x-frukujvobiddjahi] has joined #bitcoin-core-dev     
07:48 < MarcoFalke> It is a single mapArgs internally and each module provides all valid parameter names to the arg parse class somwehere in init.cpp
07:50 < MarcoFalke> In a second step you actually parse. And thereafter, the modules can query their values by providing a the corresponding parameter name
07:55 -!- rebroad [~rebroad@175.143.63.250] has quit [Ping timeout: 260 seconds]     
07:57 < MarcoFalke> jonasschnelli: amended your suggestion. #9095 should pass now
07:57 < gribble> https://github.com/bitcoin/bitcoin/issues/9095 | test: Fix test_random includes by MarcoFalke · Pull Request #9095 · bitcoin/bitcoin · GitHub
07:57 < jonasschnelli> MarcoFalke: okay. Building again
08:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-deexnrkkxikxfyfb] has quit [Ping timeout: 260 seconds]     
08:07 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-guattnkxvlglpmvz] has joined #bitcoin-core-dev     
08:09 -!- JackH [~laptop@79-73-184-38.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
08:11 < jonasschnelli> MarcoFalke: still got: test/coins_tests.cpp:10:30: fatal error: test/test_random.h: No such file or directory
08:11 < jonasschnelli> Do i need to flush/remove something?
08:11 < jonasschnelli> Ah.. shit..
08:11 < jonasschnelli> checked wrong log... still compiling. False alarm.
08:16 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-zewodfzhphqgnbhi] has quit [Ping timeout: 260 seconds]     
08:16 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-ohuasgcdyuzafmef] has quit [Ping timeout: 260 seconds]     
08:17 < MarcoFalke> Heh, the fact that it didn't fail until now probably means it will pass.
08:17 -!- mturquette [sid66043@gateway/web/irccloud.com/x-fhbzdqqgycstsihd] has quit [Ping timeout: 260 seconds]     
08:18 -!- mturquette [sid66043@gateway/web/irccloud.com/x-lwwjtoejssgjzblf] has joined #bitcoin-core-dev     
08:18 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
08:18 < jonasschnelli> Yes. Seems to be passing... qt stuff is now compiling
08:20 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-lhwyokbgpkjevnxv] has joined #bitcoin-core-dev     
08:20 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-ovekpyinvfqfazqh] has joined #bitcoin-core-dev     
08:22 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
08:34 -!- JackH_ [~laptop@79-73-184-38.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
08:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]     
08:37  * jtimon doesn't like BlockAssembler::CreateNewBlock uses global chainActive, could just take CBlockIndex* pindexPrev = chainActive.Tip() as param...
08:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
08:46 -!- JackH_ [~laptop@79-73-184-38.dynamic.dsl.as9105.com] has quit [Quit: Leaving]     
08:48 < sdaftuar> MarcoFalke: i tried adding some instrumentation to GenerateNewKey.  It looks like the disk-related calls (WriteHDChain, AddKeyPubKey) are what can be slow, but aren't always
08:49 < sdaftuar> MarcoFalke: i'm guessing it's just an issue with my disk being a bottleneck when the machine gets loaded.  it's a spinning disk, and i have a lot of jobs running on this machine potentially at the same time
08:55 < sdaftuar> MarcoFalke: i'll probably migrate my test-running to a new machine that's less loaded but i think bumping timeouts to avoid transient errors is still something we might as well do, not really any downside right?
08:56 < MarcoFalke> Yeah, a minute should do it, though. No need to wait for a quarter hour to see something timed out.
08:57 < sdaftuar> yeah
08:59 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 260 seconds]     
09:03 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
09:05 -!- rubensayshi [~ruben@82.201.92.138] has quit [Remote host closed the connection]     
09:11 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev     
09:12 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]     
09:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
09:18 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has quit [Ping timeout: 256 seconds]     
09:18 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
09:19 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
09:22 < andytoshi> is there a simple or linkable reason that segwit blocks need to commit to witness data at all? this is hard to google for, seems like this is always a background assumption, but it's coming up in context of mimblewimble..
09:24 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
09:24 < sipa> the most important reason is DoS protection
09:25 < sipa> usually, we can assume that a high frequency of incoming blocks (which pass PoW) is impossible, because PoW prevents that
09:27 < sipa> but if witness data is not committed to, you cannot distinguish between the case where a miner simply created an invalid block, or your relay peer damaged the witness in flight, and thus you can no longer make validation failure result in the block being marked permanently invalid
09:27 < andytoshi> ok, cool, that's what i had thought
09:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]     
09:28 < andytoshi> there is a related DoS vector with in-flight transactions though, and they don't have PoW
09:28 < andytoshi> i guess that is dealt with by just banning peers?
09:29 < sipa> right
09:29 < sipa> the issue does exist for transactions
09:30 < sipa> but the cost of a transaction for validation is much lower
09:30 < andytoshi> ok, great, thanks
09:30 < sipa> and failure to process a transaction in a short time does not result in network convergence being hurt
09:30 < andytoshi> yeah, that just occured to me
09:31 < sipa> ... though after compact blocks, they sort of do, in a weaker way
09:31 < andytoshi> well, peer banning on bad blocks (that aren't actually bad) could lead to a sybil attack being amplified to a permanent fork i suspect
09:32 < andytoshi> the risk with CB is that things will be slower
09:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/78cdd643d317...1253f8692fc3
09:32 < bitcoin-git> bitcoin/master 8463aaa Russell Yanofsky: [qa] Increase wallet-dump RPC timeout...
09:32 < bitcoin-git> bitcoin/master e89614b Russell Yanofsky: [qa] Add more helpful RPC timeout message...
09:32 < bitcoin-git> bitcoin/master 1253f86 MarcoFalke: Merge #9077: [qa] Increase wallet-dump RPC timeout...
09:32 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9077: [qa] Increase wallet-dump RPC timeout (master...fix-wallet-dump-timeout) https://github.com/bitcoin/bitcoin/pull/9077
09:47 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
09:47 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-lhwyokbgpkjevnxv] has quit [Quit: Connection closed for inactivity]     
09:48 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
09:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
09:52 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds]     
09:58 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev     
10:04 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: brb]     
10:05 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Ping timeout: 260 seconds]     
10:06 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
10:07 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 256 seconds]     
10:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:08 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev     
10:14 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
10:19 < instagibbs> So I noticed that AcceptBlock attempts to validate various amounts of the genesisblock upon reindexing. Is this desired behavior? For example, it checks for height in coinbase if bip34height is set to <= 0
10:20 < instagibbs> I don't know the validation flow very well, so perhaps this is ok, but I've been told Core doesn't validate the genesis block.
10:20 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
10:20 < BlueMatt> reminder: the first round of public 33c3 tickets go on sale in ~40 minutes
10:21 < BlueMatt> wumpus: ^ :p
10:21 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
10:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]     
10:25 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
10:30 < instagibbs> I now understand that this won't fork anyone off, but it might make sense to special case the genesis block again for this case.
10:30 < instagibbs> (this meaning current behavior)
10:32 < sipa> instagibbs: imho, we should not apply any tests to genssis
10:32 < instagibbs> Ok, I can PR something
10:35 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
10:46 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-idxixcedxfipcdxs] has joined #bitcoin-core-dev     
10:49 < instagibbs> sipa, ConnectBlock calls CheckBlock on genesis right before it short-circuits the rest of the logic. Comment above said CheckBlock is "// Check it again in case a previous version let a bad block in"
10:52 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
10:52 < sipa> instagibbs: that's a very old comment
10:53 < instagibbs> Could you elaborate on what a newer comment explaining the line would entail :)
10:54 < instagibbs> From a naive reviewer I'd say it's a bunch of cheap checks to run before loading coins, validating everything else.
10:57 < cfields> sipa / wumpus: thanks for helping out on #8708. Just catching up after being out of town for the weekend. I was expecting to fix it up today, but finding it already merged is even better :)
10:57 < gribble> https://github.com/bitcoin/bitcoin/issues/8708 | net: have CConnman handle message sending by theuni · Pull Request #8708 · bitcoin/bitcoin · GitHub
11:11 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
11:21 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
11:22 -!- owowo [ovovo@gateway/vpn/mullvad/x-yavnffflcmltyatz] has quit [Ping timeout: 244 seconds]     
11:24 -!- owowo [ovovo@gateway/vpn/mullvad/x-eesgnexftnadgctu] has joined #bitcoin-core-dev     
11:25 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:55ae:c649:d4a3:c159] has joined #bitcoin-core-dev     
11:26 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
11:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9097: [qa] Rework sync_* and preciousblock.py (master...Mf1611-qaSyncAndPrecious) https://github.com/bitcoin/bitcoin/pull/9097
11:41 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]     
11:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
11:59 < jtimon> how can the same test pass when make check but not with test_bitcoin --run_test=MyTest ?
12:00 < sipa> it means you're leaving some state around and not cleaning it up
12:06 < jtimon> within the test?
12:07 < MarcoFalke> In a previous test. So MyTest depends on a previous test, which it should not.
12:09 < jtimon> oh, I see
12:10 < jtimon> may be, let me comment the previous test
12:10 < jtimon> thanks
12:10 < sipa> or _any_ previous test
12:21 < jtimon> yes, it is my own previous test in the same file, but I still don't understand why, thanks again
12:22 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
12:24 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Write error: Broken pipe]     
12:25 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev     
12:27 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
12:30 -!- satosh-777-xl_ [d13ab931@gateway/web/freenode/ip.209.58.185.49] has joined #bitcoin-core-dev     
12:36 -!- murch_ is now known as murch     
12:42 < satosh-777-xl_> I asked this on bitcoin-dev and was told to check the developer notes and then post on here if I couldn't find anything.. Anyways as core is moving away from boost and BOOST_FOREACH loops in favor of standard C++ (11), is the following for loop syntax acceptable?
12:42 < satosh-777-xl_> for (Class c : vClass) { c.nonce++ }
12:48 < sipa> that won't work. that syntax will make c into a copy of the item being iterator over
12:50 < satosh-777-xl_> I'm sorry, that loop is broken. I was just wondering if that code style (if it didn't have the error of copying c) is okay or if for (size_t i = 0; i < 10; i++) should be the only style used
12:52 < sipa> (Class c& : vClass) {
12:52 < sipa> for (Class c& : vClass) {
12:54 < satosh-777-xl_> Okay, so if used correctly that style of for loop is okay to use in a new pull request?
12:54 < sipa> yes     
12:56 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]     
12:56 < satosh-777-xl_> Thanks you I was curious, thats all :)
12:57 < satosh-777-xl_> *thank you
13:04 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]     
13:17 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
13:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
13:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
13:23 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
13:25 < cfields> morcos: re yesterday's ping, it should be fixed in master now. The fix (8708) was PR'd a long time ago, it just took a while to get merged.
13:27 < morcos> cfields: thanks! i did try scanning open PR's but not thoroughly enough I guess and missed it.
13:28 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
13:32 -!- whphhg [whphhg@gateway/vpn/mullvad/x-fkakaixnogyxmsvf] has quit [Quit: Leaving]     
13:39 < btcdrak> wumpus: looks like jgarzik merged that JSON whitespace issue upstream, what is the next step - once that is merged into core we'll need to remove the white space from a couple of fixtures in src/test/data/*.json files.
13:55 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has quit [Ping timeout: 250 seconds]     
13:58 -!- webi [~webi@217-197-180-31.pool.digikabel.hu] has quit [Quit: leaving]     
14:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9098: [qa] Handle zombies and cluttered tmpdirs (master...Mf1611-qaZombies) https://github.com/bitcoin/bitcoin/pull/9098
14:04 -!- MarcoFalke [~marco@5.199.182.203] has joined #bitcoin-core-dev     
14:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
14:17 -!- destry [18ff78ae@gateway/web/freenode/ip.24.255.120.174] has joined #bitcoin-core-dev     
14:18 -!- destry [18ff78ae@gateway/web/freenode/ip.24.255.120.174] has left #bitcoin-core-dev []     
14:20 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1253f8692fc3...9f554e03ebe5
14:20 < bitcoin-git> bitcoin/master fe1dc62 Matt Corallo: Hash P2P messages as they are received instead of at process-time
14:20 < bitcoin-git> bitcoin/master 9f554e0 Pieter Wuille: Merge #9045: Hash P2P messages as they are received instead of at process-time...
14:20 < bitcoin-git> [bitcoin] sipa closed pull request #9045: Hash P2P messages as they are received instead of at process-time (master...2016-10-p2p-hash) https://github.com/bitcoin/bitcoin/pull/9045
14:20 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]     
14:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
14:21 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
14:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
14:24 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
14:29 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
14:34 < BlueMatt> lol, sipa, did you go through all my pulls just to tell me that i need to rebase all of them? :p
14:34 < BlueMatt> fucking cfields and his refactors....
14:35 < cfields> BlueMatt: i could say the same about you :)
14:35 < BlueMatt> heh, true
14:35 < sipa> BlueMatt: yes
14:36 < sipa> BlueMatt: i didn't expect they'd all need rebasing
14:37 < BlueMatt> heh, all good
14:38 < cfields> BlueMatt: I'm getting ready to PR the layer violation fix you requested (avoiding having CConnman do the serializing). It'll touch all PushMessage one last time. Would you like me to hold off until some of yours go in?
14:38 < cfields> not sure if that disrupts you at all
14:39 < BlueMatt> naa, all good, those are trivial rebaes
14:39 < BlueMatt> rebases
14:39 < cfields> ok     
14:39 < gmaxwell> sipa: "an unintentionally strong preference for witness peers" < well it was as strong as I intend it to be, after SW activates I was planning on merging the NODE_WITNESS preference into the node-network one and making it absolute and not a preference. In releases post sw I think we shouldn't connect out at all to non sw peers.
14:40 < cfields> sipa: i think i've decided against the refcounted messages altogether. I just can't see a clean way to make it happen. And you pretty much convinced me it wouldn't be effective anyway.
14:41 < cfields> gmaxwell: heh, sorry, apparently i type too slowly :)
14:43 < sipa> gmaxwell: it seems arbitrary to base it on the number of connections, and not the number of witness connections
14:43 < sipa> maybe it was what you intended, but then i misunderstood the intention
14:44 -!- satosh-777-xl_ [d13ab931@gateway/web/freenode/ip.209.58.185.49] has quit [Quit: Page closed]     
14:44 < gmaxwell> sipa: the intention was "don't leave ourselves totally disconnected because we're insisting on witness peers"-- which is a reasonable thing to do before segwit is activated and when the number of witness peers is low. 
14:45 < gmaxwell> I would much rather prefer that all of a node's outbound were witness peers, even now. But that was unrealistic in 0.13.1 due to the chicken/egg problem. :)
14:45 < sipa> gmaxwell: i see
14:46 < phantomcircuit> rebased #8831
14:46 < gribble> https://github.com/bitcoin/bitcoin/issues/8831 | Replace CWalletDB::ReadKeyValue with CWallet::LoadKeyValue by pstratem · Pull Request #8831 · bitcoin/bitcoin · GitHub
14:58 < BlueMatt> rebased all the things
15:00 < phantomcircuit> BlueMatt: indeed
15:00 < phantomcircuit> this one is my own fault though
15:01 < phantomcircuit> so i dont get to blame anybody else
15:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]     
15:20 -!- cdecker [~quassel@2a02:aa16:1105:4a80:9979:e33b:d876:1cde] has quit [Ping timeout: 250 seconds]     
15:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
15:23 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev     
15:23 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]     
15:23 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev     
15:24 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 260 seconds]     
15:25 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
15:26 -!- MarcoFalke [~marco@5.199.182.203] has left #bitcoin-core-dev []     
15:27 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
15:28 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 256 seconds]     
15:28 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
15:30 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
15:32 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
15:41 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
15:41 -!- cheese_ [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
15:59 < jtimon> BlueMatt: btw I read the last commit of TheBlueMatt/net_processing_file and I like the movement at the end
16:00 < phantomcircuit> there's no actual bug but it's kind of annoying
16:01 < phantomcircuit> there's a warding about nLowestTimestamp in importmulti
16:01 < phantomcircuit> potentially being used uninitalized
16:01 < sipa> phantomcircuit: yeah, we should fix that
16:02 < jtimon> I have understood and like some of the commits in the middle, just not enough to give an utACK in any of the PRs (note ven the merged ones yet)
16:06 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]     
16:07 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]     
16:07 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
16:07 -!- cheese_ [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer]     
16:23 -!- gluytium [~g@45.63.76.107] has joined #bitcoin-core-dev     
16:26 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
16:28 < phantomcircuit> im kind of confused
16:28 < phantomcircuit> sipa: in 8831 you can see i moved IsKeyType
16:28 < phantomcircuit> but im getting wallet/walletdb.h:45: multiple definition of `IsKeyType(std::string)'
16:29 < phantomcircuit> it's protected by #ifndef BITCOIN_WALLET_WALLETDB_H
16:29 < phantomcircuit> so it shouldn't be doing that
16:29 < phantomcircuit> moving the definition to walletdb.cpp fixes this
16:29 < phantomcircuit> but i cant see why
16:29 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Ping timeout: 265 seconds]     
16:31 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
16:34 < phantomcircuit> https://api.travis-ci.org/jobs/174075001/log.txt?deansi=true
16:39 -!- murch [~murch@p4FE38D58.dip0.t-ipconnect.de] has quit [Remote host closed the connection]     
16:43 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 268 seconds]     
16:58 < phantomcircuit> sipa: nvm i see where i went wrong
16:58 < phantomcircuit> derp
16:59 < bitcoin-git> [bitcoin] dcousens opened pull request #9100: tx_valid: re-order inputs to how they are encoded (master...testorder) https://github.com/bitcoin/bitcoin/pull/9100
17:06 < phantomcircuit> uh     
17:07 < phantomcircuit> CWalletDB::Recover has a dummyWallet which only prints a line in debug.log if LoadKeyValue fails to parse the key/value pair
17:07 < phantomcircuit> this either should fail the recovery or just be removed
17:13 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev     
17:20 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-guattnkxvlglpmvz] has quit [Quit: Connection closed for inactivity]     
17:23 < bitcoin-git> [bitcoin] pstratem opened pull request #9101: [Wallet] Do not parse ssValue in CWalletDB::Recover (master...2016-11-07-cwalletdb-recover) https://github.com/bitcoin/bitcoin/pull/9101
17:26 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
17:27 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
17:27 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds]     
17:32 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
17:36 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev     
17:38 -!- rebroad [~rebroad@202.56.91.35] has joined #bitcoin-core-dev     
17:55 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
18:03 -!- molz is now known as moli     
18:05 < bitcoin-git> [bitcoin] instagibbs opened pull request #9102: Really don't validate genesis block (master...dontvalidategenesis) https://github.com/bitcoin/bitcoin/pull/9102
18:09 -!- rebroad [~rebroad@202.56.91.35] has quit [Ping timeout: 252 seconds]     
18:11 < bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f554e03ebe5...dc6b9406bdfa
18:11 < bitcoin-git> bitcoin/master c93beac Suhas Daftuar: [qa] Test that invalid compactblocks don't result in ban
18:11 < bitcoin-git> bitcoin/master 88c3549 Suhas Daftuar: Fix compact block handling to not ban if block is invalid
18:11 < bitcoin-git> bitcoin/master d4833ff Suhas Daftuar: Bump the protocol version to distinguish new banning behavior....
18:11 < bitcoin-git> [bitcoin] sipa closed pull request #9026: Fix handling of invalid compact blocks (master...fix-invalidcb-handling) https://github.com/bitcoin/bitcoin/pull/9026
18:28 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
18:33 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
18:38 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer]     
18:38 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev     
18:39 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
18:40 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
18:47 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 240 seconds]     
18:59 -!- fengling_ [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
19:20 -!- abpa [~abpa@2604:5500:16:6:151f:30a7:79fa:9a95] has joined #bitcoin-core-dev     
19:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]     
19:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
19:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
19:43 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:55ae:c649:d4a3:c159] has quit []     
19:49 -!- rebroad [~rebroad@1.9.216.87] has joined #bitcoin-core-dev     
19:49 -!- tunafizz [tunafizz@c-71-207-55-31.hsd1.pa.comcast.net] has joined #bitcoin-core-dev     
19:53 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev     
20:03 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
20:04 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
20:09 -!- rebroad [~rebroad@1.9.216.87] has quit [Ping timeout: 260 seconds]     
20:30 -!- rebroad [~rebroad@1.9.216.87] has joined #bitcoin-core-dev     
20:38 -!- rebroad [~rebroad@1.9.216.87] has quit [Ping timeout: 260 seconds]     
20:51 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]     
21:03 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 250 seconds]     
21:07 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
21:07 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-idxixcedxfipcdxs] has quit [Quit: Connection closed for inactivity]     
21:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
21:12 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.]     
21:13 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Read error: Connection timed out]     
21:18 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has quit [Ping timeout: 260 seconds]     
21:19 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev     
21:22 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Quit: Leaving]     
21:22 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]     
21:22 -!- wasi [~Wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev     
21:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
21:25 -!- wasi_ [~Wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev     
21:25 -!- wasi_ [~Wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Remote host closed the connection]     
21:25 -!- wasi [~Wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Client Quit]     
21:25 -!- wasi [~Wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev     
21:53 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev     
21:58 -!- DigiByteDev [~JT2@101.78.224.202] has joined #bitcoin-core-dev     
22:02 -!- fengling_ [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds]     
22:20 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev     
22:20 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
22:35 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-fmbptvdexwdqmusp] has joined #bitcoin-core-dev     
22:46 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-eesvncxrykzgokou] has joined #bitcoin-core-dev     
23:02 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]     
23:03 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
23:24 -!- wasi [~Wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Quit: Leaving]     
23:24 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev     
23:39 -!- testnet [~testnet@gateway/tor-sasl/testnet] has joined #bitcoin-core-dev     
23:40 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 260 seconds]     
23:42 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc6b9406bdfa...b8f43e33316c
23:42 < bitcoin-git> bitcoin/master fa8278e MarcoFalke: test: Fix test_random includes
23:42 < bitcoin-git> bitcoin/master b8f43e3 Jonas Schnelli: Merge #9095: test: Fix test_random includes...
23:42 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9095: test: Fix test_random includes (master...Mf1611-testRand) https://github.com/bitcoin/bitcoin/pull/9095
23:48 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 265 seconds]     
23:49 -!- whphhg [whphhg@gateway/vpn/mullvad/x-udcjsykndpanjzoc] has joined #bitcoin-core-dev     
23:57 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev