--- Day changed Tue Nov 08 2016 00:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:15 -!- rubensayshi [~ruben@82.201.92.138] has joined #bitcoin-core-dev 00:27 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:30 -!- DigiByteDev [~JT2@101.78.224.202] has quit [Quit: DigiByteDev] 00:44 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 01:04 -!- MarcoFalke [~marco@5.199.182.203] has joined #bitcoin-core-dev 01:05 -!- gielbier [~michiel@unaffiliated/gielbier] has quit [Ping timeout: 245 seconds] 01:09 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:14 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 01:23 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 244 seconds] 01:24 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-zfbtboastiqsdekd] has quit [Read error: Connection reset by peer] 01:25 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-ctnitoalwwunkyyt] has joined #bitcoin-core-dev 01:37 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-ctnitoalwwunkyyt] has quit [Read error: Connection reset by peer] 01:37 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-btidavtkyosjetfi] has joined #bitcoin-core-dev 01:55 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b8f43e33316c...f53023dbb860 01:55 < bitcoin-git> bitcoin/master bd0de13 UdjinM6: Fix exit codes:... 01:55 < bitcoin-git> bitcoin/master 4441018 UdjinM6: Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers 01:55 < bitcoin-git> bitcoin/master f53023d Wladimir J. van der Laan: Merge #9067: Fix exit codes... 01:55 < bitcoin-git> [bitcoin] laanwj closed pull request #9067: Fix exit codes (master...fixExitCodesBitcoin) https://github.com/bitcoin/bitcoin/pull/9067 01:56 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f53023dbb860...71ab476b0482 01:56 < bitcoin-git> bitcoin/master fae19aa MarcoFalke: [qa] test_framework: Exit when tmpdir exists 01:56 < bitcoin-git> bitcoin/master fab0f07 MarcoFalke: [qa] rpc-tests: Apply random offset to portseed... 01:56 < bitcoin-git> bitcoin/master 71ab476 Wladimir J. van der Laan: Merge #9098: [qa] Handle zombies and cluttered tmpdirs... 01:56 < bitcoin-git> [bitcoin] laanwj closed pull request #9098: [qa] Handle zombies and cluttered tmpdirs (master...Mf1611-qaZombies) https://github.com/bitcoin/bitcoin/pull/9098 01:57 <@wumpus> now the tests can even jump over zombies in graveyards \o/ 02:03 -!- fengling [~fengling@123.117.43.214] has joined #bitcoin-core-dev 02:05 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71ab476b0482...4e5782438c3d 02:05 < bitcoin-git> bitcoin/master 77cbbd9 R E Broadley: Make warning message about wallet balance possibly... 02:05 < bitcoin-git> bitcoin/master 4e57824 Wladimir J. van der Laan: Merge #9088: Reduce ambiguity of warning message... 02:05 < bitcoin-git> [bitcoin] laanwj closed pull request #9088: Reduce ambiguity of warning message (master...LessAmbiguousWalletWarning) https://github.com/bitcoin/bitcoin/pull/9088 02:05 < MarcoFalke> Heh, I hope it is a good thing because whenever there is a zombie there is a prob of about 0.0016 that you will step on them :P 02:06 < MarcoFalke> Previously the prob was 1, so at least you knew there is a zombie 02:17 -!- Alina-malina [~Alina-mal@37.157.216.189] has joined #bitcoin-core-dev 02:21 -!- jyap [~jyap@unaffiliated/jyap] has quit [Ping timeout: 260 seconds] 02:25 -!- jyap [~jyap@2604:180:1:7f5::b59a] has joined #bitcoin-core-dev 02:25 -!- jyap [~jyap@2604:180:1:7f5::b59a] has quit [Changing host] 02:25 -!- jyap [~jyap@unaffiliated/jyap] has joined #bitcoin-core-dev 02:33 -!- MarcoFalke [~marco@5.199.182.203] has left #bitcoin-core-dev [] 02:42 -!- PatBoy [xyz@192.99.249.194] has quit [Ping timeout: 256 seconds] 02:53 -!- fengling [~fengling@123.117.43.214] has quit [Ping timeout: 268 seconds] 03:05 -!- murch [~murch@p4FDB609D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 03:10 -!- PatBoy [xyz@192.99.249.194] has joined #bitcoin-core-dev 03:10 -!- PatBoy [xyz@192.99.249.194] has quit [Excess Flood] 03:11 -!- PatBoy [xyz@192.99.249.194] has joined #bitcoin-core-dev 03:19 -!- crudel [crudel@gateway/shell/fnordserver.eu/x-sdcqlzuncoodqokh] has quit [Remote host closed the connection] 03:30 -!- cdecker [~quassel@2a02:aa16:1105:4a80:6540:bcad:48df:1694] has joined #bitcoin-core-dev 04:05 -!- whphhg [whphhg@gateway/vpn/mullvad/x-udcjsykndpanjzoc] has quit [Quit: Leaving] 04:07 -!- laurentmt [~Thunderbi@80.215.138.146] has joined #bitcoin-core-dev 04:17 <@wumpus> well the best way of deailng with zombies would be to no create them in the first place, make sure the test framework cleans up the dead properly 04:17 <@wumpus> this is not always possible, of course 04:19 -!- laurentmt [~Thunderbi@80.215.138.146] has quit [Quit: laurentmt] 04:24 -!- dermoth_ [~thomas@dsl-216-221-56-109.mtl.aei.ca] has joined #bitcoin-core-dev 04:24 -!- dermoth [~thomas@dial-216-221-46-134.mtl.aei.ca] has quit [Disconnected by services] 04:24 -!- dermoth_ is now known as dermoth 04:39 -!- crescendo [~mozart@unaffiliated/crescendo] has quit [Ping timeout: 248 seconds] 04:40 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 04:42 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:50 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 04:50 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 04:54 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 260 seconds] 04:58 -!- cryptapus [~cryptapus@87.254.202.250] has joined #bitcoin-core-dev 04:58 -!- cryptapus [~cryptapus@87.254.202.250] has quit [Changing host] 04:58 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:02 -!- erasmospunk [~erasmospu@2a02:587:3a12:5f00:29af:c508:4180:e3f4] has joined #bitcoin-core-dev 05:05 -!- erasmospunk [~erasmospu@2a02:587:3a12:5f00:29af:c508:4180:e3f4] has quit [Client Quit] 05:11 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 05:11 -!- Alina-malina [~Alina-mal@37.157.216.189] has quit [Changing host] 05:11 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 05:12 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 05:16 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Ping timeout: 244 seconds] 05:21 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 05:23 -!- laurentmt [~Thunderbi@80.215.138.146] has joined #bitcoin-core-dev 05:23 -!- laurentmt [~Thunderbi@80.215.138.146] has quit [Client Quit] 05:25 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 05:26 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 256 seconds] 05:40 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 05:52 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:55 -!- laurentmt [~Thunderbi@80.215.138.146] has joined #bitcoin-core-dev 06:01 -!- laurentmt [~Thunderbi@80.215.138.146] has quit [Quit: laurentmt] 06:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:32 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:44 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:45 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Ping timeout: 252 seconds] 06:47 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 06:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e5782438c3d...924de0bd75a7 06:56 < bitcoin-git> bitcoin/master 1adf82a Jorge Timón: RPC: Give more details when "generate" fails 06:56 < bitcoin-git> bitcoin/master 924de0b MarcoFalke: Merge #9087: RPC: why not give more details when "generate" fails?... 06:56 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9087: RPC: why not give more details when "generate" fails? (master...0.13-errors-rpc-mining) https://github.com/bitcoin/bitcoin/pull/9087 07:15 -!- abpa [~abpa@2604:5500:16:6:151f:30a7:79fa:9a95] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:20 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 248 seconds] 07:20 -!- laurentmt [~Thunderbi@80.215.138.146] has joined #bitcoin-core-dev 07:30 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:31 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 07:31 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has quit [Client Quit] 07:32 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:32 -!- cryptapus_ is now known as cryptapus 07:39 -!- Guyver2__ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:40 -!- aalex [~aalex@64.187.177.58] has quit [Quit: Connection reset by beer] 07:42 -!- laurentmt [~Thunderbi@80.215.138.146] has quit [Quit: laurentmt] 07:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 07:42 -!- Guyver2__ is now known as Guyver2 07:48 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 08:00 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer] 08:00 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 08:02 -!- laurentmt [~Thunderbi@80.215.138.146] has joined #bitcoin-core-dev 08:03 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 08:11 -!- murch [~murch@p4FDB609D.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 08:20 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 08:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer] 08:27 -!- laurentmt [~Thunderbi@80.215.138.146] has quit [Quit: laurentmt] 08:38 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer] 08:45 -!- testnet [~testnet@gateway/tor-sasl/testnet] has quit [Remote host closed the connection] 08:45 -!- testnet [~testnet@gateway/tor-sasl/testnet] has joined #bitcoin-core-dev 08:46 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:55 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:56 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 08:59 -!- rubensayshi [~ruben@82.201.92.138] has quit [Remote host closed the connection] 09:07 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: ZZZzzz…] 09:07 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 09:09 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:10 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 09:14 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 09:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 09:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:40 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 256 seconds] 09:41 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:50 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 09:56 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:03 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 10:10 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 10:31 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 10:35 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 10:40 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:42 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [] 10:45 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 10:51 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Remote host closed the connection] 11:11 < gmaxwell> sipa: so perhaps the mempool saving functionality should be saving the mempoolminfee... as it goes to zero after a restart. 11:15 < sipa> gmaxwell: good point 11:16 < sipa> file an issue 11:17 < gmaxwell> sipa: #9103 11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9103 | An error has occurred and has been logged. Please contact this bot's administrator for more information. 11:29 -!- testnet [~testnet@gateway/tor-sasl/testnet] has quit [Remote host closed the connection] 11:34 < morcos> sipa: i also thought mempool saving was going to be optional? 11:35 < morcos> on a separately question, is it fine to leave a bunch of BOOST_TEST_MESSAGE(..) in unit_tests or will they slow them down... 11:35 < morcos> coins_tests are so complicated, might be useful to not have to readd all this debugging information next time they are changed 11:36 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Quit: Leaving.] 11:36 -!- Guest89259 [~chatzilla@71-84-219-33.dhcp.ccmn.ca.charter.com] has joined #bitcoin-core-dev 11:36 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 11:38 -!- Guest89259 is now known as roidster 11:43 -!- testnet [~testnet@gateway/tor-sasl/testnet] has joined #bitcoin-core-dev 11:58 -!- harrymm [~wayne@104.222.140.40] has quit [Ping timeout: 250 seconds] 12:03 < BlueMatt> jtimon: cool, thanks 12:16 -!- harrymm [~wayne@104.222.140.19] has joined #bitcoin-core-dev 12:27 < jtimon> wumpus: instagibbs I added the reindex rpc tests to #8994, to test #9102 (well, and #8994 in general), if you think of other rpc tests that would be interesting to duplicate for this or default values for the custom chain (ie maybe consensus.BIP34Height = 0 or whatever ) please let me know 12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/9102 | An error has occurred and has been logged. Please contact this bot's administrator for more information. 12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 12:28 < jtimon> strangely enough locally walletbackup is failing, but only when I run all of them, not when I run it individually, there must be something I haven't cleanup up properly because travis seems to be happy 12:39 -!- whphhg [whphhg@gateway/vpn/mullvad/x-ekalgpqenpfpspgz] has joined #bitcoin-core-dev 12:42 < sdaftuar> jtimon: if you're seeing failures related to block sync failure in sync_blocks(), there's a good chance that 12:42 < sdaftuar> is related to #9058 12:42 < gribble> https://github.com/bitcoin/bitcoin/issues/9058 | Fixes for p2p-compactblocks.py test timeouts on travis (#8842) by ryanofsky · Pull Request #9058 · bitcoin/bitcoin · GitHub 12:44 < jtimon> I'm not really sure what's happening, it's not a very clear error and the fact that walletbackup passes individually makes it more weird, but I will take a look, thanks 12:47 -!- juscamarena [~jus@47.148.176.74] has joined #bitcoin-core-dev 12:48 -!- e4xit [~e4xit@cpc92302-cmbg19-2-0-cust1369.5-4.cable.virginm.net] has quit [Quit: Right I'm out!] 12:52 -!- juscamarena [~jus@47.148.176.74] has quit [Ping timeout: 252 seconds] 13:00 -!- whphhg is now known as montau 13:02 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 248 seconds] 13:04 -!- juscamarena [~jus@47.148.176.74] has joined #bitcoin-core-dev 13:07 < bitcoin-git> [bitcoin] morcos opened pull request #9107: Safer modify new coins (master...saferModifyNewCoins) https://github.com/bitcoin/bitcoin/pull/9107 13:49 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 14:01 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 14:04 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 250 seconds] 14:05 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9108: WIP: Use importmulti timestamp when importing watch only keys (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108 14:06 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 14:25 < gmaxwell> morcos: it's optional, you can totally kill -9 the process instead of calling stop. :P 14:25 < gmaxwell> (I suppose it would be reasonable to add an option to let people disable it, though I don't know why anyone would set it, except perhaps saving 150 mb of disk space. 14:29 < sipa> morcos: i'm not opposed to making it optional, i just didn't think it was a requirement for the first PR 14:34 < sipa> gmaxwell: i assume you're joking, but there are downsides to killing that may be worse, like not storing the latest blocks' effect to disk 14:39 -!- roidster [~chatzilla@71-84-219-33.dhcp.ccmn.ca.charter.com] has quit [Quit: ChatZilla 0.9.92 [SeaMonkey 2.39/20151103191810]] 14:42 < cfields> sdaftuar: regarding #9026, did you consider adding fMayBanPeerIfInvalid to CState rather than passing it around? I realize it's merged, just curious after starting to review 9075 14:42 < gribble> https://github.com/bitcoin/bitcoin/issues/9026 | Fix handling of invalid compact blocks by sdaftuar · Pull Request #9026 · bitcoin/bitcoin · GitHub 14:44 < sipa> cfields: i dislike turning CValidationState into an input parameter as well 14:49 < cfields> sipa: fair enough, I suppose that would be the only input. I was thinking there were already some there. 14:53 < gmaxwell> sipa: well we should fix those downsides if they're actually a concern. :) losing a few blocks of verification should be a non-issue. 14:54 < phantomcircuit> gmaxwell: i think it can be more than a few 15:02 < sipa> gmaxwell: not needing a shutdown procedure is a nice design principle, but i don't think we're there 15:07 < gmaxwell> seems pretty fine to me. 15:07 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-fmbptvdexwdqmusp] has quit [Quit: Connection closed for inactivity] 15:30 -!- cdecker [~quassel@2a02:aa16:1105:4a80:6540:bcad:48df:1694] has quit [Ping timeout: 260 seconds] 15:32 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.] 15:32 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 16:07 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-jvgmjcxkofstkzbl] has joined #bitcoin-core-dev 16:22 -!- veleiro [~veleiro@fsf/member/veleiro] has joined #bitcoin-core-dev 16:33 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:45 < sdaftuar> cfields: i think it'd also get tricky because the CValidationState passed in to ProcessNewBlock can be referencing a different block than where it might be used in ActivateBestChainStep 16:45 < sipa> sdaftuar: good point 16:51 < cfields> sdaftuar: yes, makes sense. thanks. 17:03 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 17:19 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #9014: Fix block-connection performance regression (master...2016-10-fix-tx-regression) https://github.com/bitcoin/bitcoin/pull/9014 17:24 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 17:42 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 17:42 < BlueMatt> jtimon: so i think i need to revert #9087 for #9075 17:42 < gribble> https://github.com/bitcoin/bitcoin/issues/9087 | RPC: why not give more details when "generate" fails? by jtimon · Pull Request #9087 · bitcoin/bitcoin · GitHub 17:42 < gribble> https://github.com/bitcoin/bitcoin/issues/9075 | Decouple peer-processing-logic from block-connection-logic (#3) by TheBlueMatt · Pull Request #9075 · bitcoin/bitcoin · GitHub 17:43 < BlueMatt> because 9074 removes the state parameter from ProcessNewBlock - it only is used if CheckBlock fails, not if there is an actual failure 17:45 < jtimon> #9087 is just something I found while trying to fix the blocksigning branch, but it surprises me that you need to revert it 17:45 < gribble> https://github.com/bitcoin/bitcoin/issues/9087 | RPC: why not give more details when "generate" fails? by jtimon · Pull Request #9087 · bitcoin/bitcoin · GitHub 17:45 < BlueMatt> well it already doesnt work - the state object to ProcessNewBlock is only used if CheckBlock fails, not if the block is invalid for any other reason 17:46 < BlueMatt> the only way to get useful info from ProcessNewBlock is to register, then de-register a CValidationInterface, already 17:46 < BlueMatt> so I was removing it 17:46 < sipa> or if processblock doens't run... if someone another new block was received? 17:46 < sipa> *somehow 17:46 < jtimon> oh, I see, and in my case it was failing on checkblockheader 17:47 < jtimon> so with 9087 I was able to see "high hash" 17:47 < BlueMatt> if someone actually cares, I can fix it by doing the register, de-register hack 17:47 < BlueMatt> but....its a dirty hack 17:48 < jtimon> btw, after you matt took the time check out checkblockheader is just like checkpow but putting a message on the validation state and with and absurd bool arg 17:48 < sipa> jtimon: assuming the block wasn't reorged out, for what reason other than high hash would generate fail? 17:49 < jtimon> feel free to revert the change, I can always have it locally, it shouldn't normally fail anyway, just because I'm doing another version of checkpow for the block signing stuff 17:50 < sipa> jtimon: with matt's change, processnewblock doesn't take a CValidateState anymore 17:51 < jtimon> I just thought there was no harm and maybe was useful in more cases besides mine, seriously, no need to pass CValidateState to processnewblock only for rpc/mining 17:51 < sipa> BlueMatt, jtimon: perhaps it can be fixed by invoking AcceptNewHeader explicitly from RPC, and report the result from that? 17:51 < BlueMatt> ehh, please no...CheckBlock 17:51 < BlueMatt> not Accept*Header 17:51 < sipa> ah 17:51 < sipa> ok 17:52 < jtimon> I can do it locally if I need to, but right now I know where the things are failing, just don't understand why, please feel free to revert 9087, np 17:53 < BlueMatt> ok 17:53 < jtimon> it just felt kind of free to upstream 17:53 < BlueMatt> yupyup, all right decisions, just randomly gets in the way :) 17:54 < jtimon> ok, good, same page it seems 17:56 < jtimon> sipa: the last idea may be interesting for mining::generate though 17:56 < jtimon> but yeah, later 17:57 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:59 < jtimon> does it make sense for me to try that the custom chain (by default just like regstes, just with a different genesis block and a different directory) passes all rpc python tests just like regtest does? 18:00 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-eesvncxrykzgokou] has quit [Quit: Connection closed for inactivity] 18:00 -!- fengling [~fengling@123.117.40.160] has joined #bitcoin-core-dev 18:00 < jtimon> never mind, I'll try first, ask later 18:17 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-jvgmjcxkofstkzbl] has quit [Quit: Connection closed for inactivity] 18:18 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 18:22 -!- afk11_ [~afk11@79.97.105.226] has quit [Ping timeout: 250 seconds] 18:23 -!- afk11 [~afk11@79.97.105.226] has joined #bitcoin-core-dev 18:23 -!- afk11 [~afk11@79.97.105.226] has quit [Changing host] 18:23 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev 18:41 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 250 seconds] 18:43 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 18:54 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 19:18 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 258 seconds] 19:27 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 19:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 19:57 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-dkpjrlshrnelfhak] has joined #bitcoin-core-dev 19:59 -!- abpa [~abpa@199.87.86.217] has joined #bitcoin-core-dev 20:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 20:04 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 20:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 20:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:39 -!- shesek [~shesek@bzq-84-110-60-45.red.bezeqint.net] has quit [Ping timeout: 268 seconds] 20:53 -!- veleiro [~veleiro@fsf/member/veleiro] has quit [Ping timeout: 258 seconds] 21:14 -!- juscamarena [~jus@47.148.176.74] has quit [Ping timeout: 256 seconds] 21:18 -!- go1111111 [~go1111111@104.200.154.47] has joined #bitcoin-core-dev 21:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 21:42 -!- fengling [~fengling@123.117.40.160] has quit [Ping timeout: 268 seconds] 21:49 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Ping timeout: 256 seconds] 21:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 22:07 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Quit: Leaving] 22:07 -!- testnet [~testnet@gateway/tor-sasl/testnet] has quit [Quit: Leaving] 22:09 -!- fengling [~fengling@123.117.40.160] has joined #bitcoin-core-dev 22:10 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev 22:11 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 22:11 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev 22:11 -!- testnet [~testnet@gateway/tor-sasl/testnet] has joined #bitcoin-core-dev 22:16 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev] 22:17 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-dkpjrlshrnelfhak] has quit [Quit: Connection closed for inactivity] 22:49 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev 23:11 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-giniuspiverieohf] has joined #bitcoin-core-dev 23:36 -!- LeMiner2 [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 23:39 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Ping timeout: 260 seconds] 23:39 -!- LeMiner2 is now known as LeMiner 23:47 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:59 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]