--- Day changed Tue Nov 22 2016 00:00 < wumpus> but without having to actaully write dtrace scripts :) 00:08 -!- baldur [~baldur@pool-100-2-139-91.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 00:13 < jonasschnelli> wumpus: when compiling with CPPFLAGS/LDFLAGS +"-fsanitize=address", I get Undefined symbols during liking (___asan_stack_malloc_5, etc.)? Any ideas? 00:14 -!- gielbier [~michiel@unaffiliated/gielbier] has quit [Ping timeout: 245 seconds] 00:21 < wumpus> jonasschnelli: it should try to link against the asan runtime library 00:21 < jonasschnelli> I passed -fasnitize=address as LDFLAGS ... hmm... 00:22 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 00:22 < jonasschnelli> *-fsanitize=address 00:22 < wumpus> things like "libclang_rt.asan_cxx-i686.a" 00:22 -!- rubensayshi [~ruben@82.201.92.138] has joined #bitcoin-core-dev 00:22 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 00:23 < wumpus> I had to put compiler-rt in my llvm/clang build to get them in the first place, but I'd expect distro-build versions to have that enabled by default 00:23 < wumpus> in any case yes passing that to the linker should try to link them automatically 00:25 < jonasschnelli> hmm... libclang_rt.asan_osx_dynamic is present... 00:29 < jonasschnelli> I guess OSX XCode clang uses a different linking approach in oder to support ASAN for all its supported platforms (iOS/ apple tv/ apple watch, etc.). 00:29 < jonasschnelli> Probably better to use a self-compiled clang (or though homebrew) 00:31 < fanquake> I know we already need documentation for lots of existing stuff, but this kind of debugging/configuration/dev tool type stuff would also be worth documenting. At least more than what we have now. 00:31 < fanquake> It'd be nice to have *lots* of people running the identical binary, and similar tools. 00:32 < jonasschnelli> I tried to add the ASAN to the cofigure.ac 00:34 < wumpus> agree that tooling documentation would be useful, though none of this is specific to bitcoin core 00:35 < wumpus> some projects have a wiki with this kind of auxiliary documentation 00:36 < fanquake> Yes I'm assuming there must be similar projects, maybe something like Tor, that would already have alot of this kind of stuff written/documented somewhere. 00:40 < paveljanik> fanquake, the documentation is generic for debugging tools... 00:40 < paveljanik> and there already is a lot of such documentation. 00:49 * wumpus is trying to add CPU cycles measure to the bench framework and probably stumbled on a subtle counting bug w/ rescaling the iteration count 00:49 < wumpus> this can cause especially the 'min' time to be off 00:55 < gmaxwell> wumpus: darn. I thought I'd tested that fairly well. 01:00 < bitcoin-git> [bitcoin] laanwj opened pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200 01:08 < gmaxwell> oh pfft. 01:08 < wumpus> yea :) 01:16 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 01:17 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:28 < gmaxwell> wumpus: I guess I'd reasoned it would be 0 mod n due to the initial count, oh well. 01:29 < wumpus> yes it's really subtle, I only discovered it because I was printing lots of debug info to debug the cycle counter, then saw the first run after a scale was off 01:31 < wumpus> the use of floating point arithmetic in the benchmarking loop isn't too great either but I'll leave that for another time 01:32 < gmaxwell> yea, esp on the kind of platforms that you really need to benchmark things on. 01:33 < gmaxwell> I wanted to eliminate that too when I last touched it but I thought it would be too much at once. :) 01:47 < wumpus> exactly 01:52 -!- laurentmt [~Thunderbi@80.215.178.91] has joined #bitcoin-core-dev 01:55 -!- laurentmt [~Thunderbi@80.215.178.91] has quit [Client Quit] 01:56 < jouke> re IRC meeting: we use the account system 01:59 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 02:00 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 02:01 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 02:01 -!- echonaut7 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 02:10 < jouke> Basically the same use case as dooglus in https://github.com/bitcoin/bitcoin/issues/3816 02:11 < wumpus> yes there needs to be an explanation how to do that without accounts / with the new labels API 02:11 < jouke> Not something we can't do ourselves, but it was there, so why not use it :P 02:12 < wumpus> and for that specific use case you don't really need accounts, just a way to track/group incoming payments using a label 02:16 < jouke> And keep track of reorgs? 02:24 -!- jeroen [~jeroen@2001:981:9573:1:705d:c26:c676:d340] has joined #bitcoin-core-dev 02:27 < jouke> Again, not something we can't do ourselves and we've known that accounts are deprecated for a while, but I was reading the IRC meeting summary and someone was wondering if anyone talking to the devs was using accounts, so I started talking :P 02:29 < Victorsueca> the whole accounts thing doesn't make a lot of sense 02:30 < jouke> What do you mean Victorsueca? 02:30 < Victorsueca> I received some bitcoins to a address labeled "Victor" and later spent them all 02:31 < Victorsueca> now the account "Victor" still has the balance and the default "" account is in negative 02:31 < Victorsueca> and I didn't use the move command 02:31 < jouke> Victorsueca: because you didn't use "senfrom"? 02:32 -!- gielbier [~michiel@unaffiliated/gielbier] has joined #bitcoin-core-dev 02:32 < Victorsueca> nope, didn't use that either 02:32 < thermoman> sdaftuar: we do import privkeys every 2 or 3 days 02:32 < jouke> That's why it's negative :). 02:33 < jouke> Victorsueca: but I get why it's confusing, that's one of the reasons it's deprecated :) 02:35 < Victorsueca> is it safe if I move all from bitcoin to "" or I would mess with the wallet balance calculation? 02:36 < Victorsueca> from Victor* 02:37 < jouke> Victorsueca: sendtoaddress only subtracts the amount from the default account, sendfrom subtracts the amount from a specific account. Victorsueca it's safe, but again, don't start using accounts, it will be removed in future versions. 02:38 < Victorsueca> ahh nice 02:47 < luke-jr> Victorsueca: it makes sense. 02:48 < luke-jr> jouke: unless you're willing to *maintain* the account system, your usage isn't likely to change its removal 02:48 < luke-jr> jouke: and even if you're willing to maintain it, I think the conclusion will be "please do it outside bitcoind" 02:49 < jouke> luke-jr: I know. 02:49 < Victorsueca> luke-jr: btw, I was wondering when will you be able to push segwit into bfgminer 02:50 < luke-jr> Victorsueca: you mean libblkmaker :P 02:50 < luke-jr> Victorsueca: testing would be helpful 02:51 < Victorsueca> luke-jr: I would, but my Antminer U3 seems to only work on windows and I didn't find any instructions on how to cross-compile 02:52 < luke-jr> review is helpful too 02:52 < Victorsueca> don't know coding C++ 02:54 < luke-jr> https://github.com/bitcoin/libblkmaker/pull/6 https://github.com/luke-jr/eloipool/pull/15 02:54 < luke-jr> Eloipool is Python <.< 02:54 < luke-jr> will get you Windows bins for BFG in a min 02:55 < Victorsueca> nice thanks 02:57 < luke-jr> :| build failure, a few more min.. 02:58 < Victorsueca> hehhehe 02:58 < Victorsueca> windoze will always be windoze 03:02 < luke-jr> in this case, it is libgcrypt's fault 03:03 < luke-jr> but that's okay because it shouldn't be using libgcrypt in the first place :P 03:04 -!- shesek [~shesek@bzq-84-110-57-133.cablep.bezeqint.net] has quit [Ping timeout: 256 seconds] 03:07 < luke-jr> Victorsueca: http://luke.dashjr.org/tmp/code/webisect/webisect.php?dobuild=segwit 03:09 < Victorsueca> nice, going to try it out 03:10 < thermoman> gmaxwell, sipa, sdaftuar: https://github.com/bitcoin/bitcoin/issues/9201 03:16 < luke-jr> Victorsueca: p.s. if you want to mine testnet with it, tmp.pool.bitcoin.dashjr.org port 3334 (stratum) or 8337 (GBT & getwork) 03:17 < luke-jr> Victorsueca: no promises I don't kill it in a few hours tho, it's eating CPU time 03:17 -!- shesek [~shesek@bzq-84-110-178-34.cablep.bezeqint.net] has joined #bitcoin-core-dev 03:17 < luke-jr> besides, better to solo mine :P 03:17 < wumpus> jouke: no, with labels instead of accounts you don't have to manually keep track of reorgs, you can still check the total balance received to a label, for example. You just cannot do accounting, so move coins instead of addresses from one label to another 03:18 < luke-jr> can't send from labels either :p 03:18 < wumpus> right 03:19 -!- fanquake [~fanquake@unaffiliated/fanquake] has left #bitcoin-core-dev [] 03:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4dbeb94998d...55b2eddcc8fd 03:21 < bitcoin-git> bitcoin/master e0a9cb2 Wladimir J. van der Laan: bench: Fix subtle counting issue when rescaling iteration count... 03:21 < bitcoin-git> bitcoin/master 55b2edd Wladimir J. van der Laan: Merge #9200: bench: Fix subtle counting issue when rescaling iteration count... 03:21 < bitcoin-git> [bitcoin] laanwj closed pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200 03:22 < Victorsueca> luke-jr: thanks, I will try to solo-mine for a while too to see if it signals segwit properly 03:23 < bitcoin-git> [bitcoin] laanwj opened pull request #9202: bench: Add support for measuring CPU cycles (master...2016_11_bench_cpu_cycles) https://github.com/bitcoin/bitcoin/pull/9202 03:45 -!- abpa [~abpa@2602:306:b837:dbf0:10e0:d560:7f6f:8a8] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:57 < Victorsueca> luke-jr: any tip on how to detect my Antminer U3? I've been following the instructions on README.ASIC ut it won't detect it 03:57 < Victorsueca> but* 03:57 < luke-jr> Victorsueca: the official drivers are installed? (not WinUSB/Zadig) 03:59 < Victorsueca> ahh, It needs to be with the default driver? 03:59 < Victorsueca> I have WinUSB 04:02 < luke-jr> yes 04:08 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 04:27 < Victorsueca> luke-jr: still not detecting it 04:27 < luke-jr> with the options in README.ASIC? 04:28 < Victorsueca> yep, and with the default sillabs driver 04:28 < wumpus> this is not related to bitcoin core development, can you move this to #bitcoin? 04:28 < Victorsueca> sure 04:57 < bitcoin-git> [bitcoin] jnewbery opened pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203 05:08 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:12 < bitcoin-git> [bitcoin] jnewbery closed pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203 05:13 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 05:31 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 05:46 -!- laurentmt [~Thunderbi@80.215.178.91] has joined #bitcoin-core-dev 05:46 -!- laurentmt [~Thunderbi@80.215.178.91] has quit [Client Quit] 05:48 < instagibbs> ;;later tell vanishing-coins Looks like you are trying to make dust, aka too-small outputs, and your wallet is refusing to send them 05:48 < gribble> The operation succeeded. 05:52 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 05:58 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 06:04 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 06:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:05 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 06:16 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:23 -!- cryptapus [~cryptapus@199.47.67.34] has joined #bitcoin-core-dev 06:23 -!- cryptapus [~cryptapus@199.47.67.34] has quit [Changing host] 06:23 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:31 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 06:32 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:32 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Client Quit] 06:33 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55b2eddcc8fd...ac489b24453c 06:33 < bitcoin-git> bitcoin/master 1260c11 Pavel Janík: Mention the new network toggle functionality in the tooltip. 06:33 < bitcoin-git> bitcoin/master ac489b2 Jonas Schnelli: Merge #9130: Mention the new network toggle functionality in the tooltip.... 06:33 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9130: Mention the new network toggle functionality in the tooltip. (master...20161111_disable_network_tooltip) https://github.com/bitcoin/bitcoin/pull/9130 06:34 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:42 < nsh> toggles all network activity? 06:42 < nsh> handy i guess 06:42 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 06:43 < jonasschnelli> nsh: The PR above is just a cosmetic one. 06:43 < jonasschnelli> The actual toggle It's in master since some days 06:43 < jonasschnelli> Just press the network-icon on the top right in the status bar. 06:43 < jonasschnelli> (if you are using the GUI) 06:43 * nsh nods 06:45 -!- laurentmt [~Thunderbi@80.215.178.91] has joined #bitcoin-core-dev 06:50 < wumpus> setnetworkactive through rpc 06:52 -!- laurentmt [~Thunderbi@80.215.178.91] has quit [Quit: laurentmt] 07:56 -!- abpa [~abpa@2602:306:b837:dbf0:6cb2:7248:5989:ef27] has joined #bitcoin-core-dev 07:58 -!- abpa [~abpa@2602:306:b837:dbf0:6cb2:7248:5989:ef27] has quit [Client Quit] 08:21 -!- jeroen [~jeroen@2001:981:9573:1:705d:c26:c676:d340] has quit [Remote host closed the connection] 08:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 08:54 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 268 seconds] 09:00 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 09:03 -!- rubensayshi [~ruben@82.201.92.138] has quit [Remote host closed the connection] 09:05 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:34 -!- atroxes_ [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 09:35 -!- atroxes_ [~atroxes@unaffiliated/atroxes] has quit [Client Quit] 09:36 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 256 seconds] 09:39 -!- protomar [~protomar@91.214.169.69] has joined #bitcoin-core-dev 09:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 10:00 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 10:12 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:14 -!- aalex__ is now known as aalex 10:17 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:22 < bitcoin-git> [bitcoin] instagibbs opened pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204 10:23 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:29 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 10:36 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:38 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 10:38 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 10:38 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:41 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Client Quit] 10:43 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:43 -!- laurentmt [~Thunderbi@80.215.234.175] has joined #bitcoin-core-dev 10:44 -!- laurentmt [~Thunderbi@80.215.234.175] has quit [Client Quit] 10:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:06 < bitcoin-git> [bitcoin] in3rsha opened pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205 11:33 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Remote host closed the connection] 11:33 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 11:38 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 260 seconds] 11:43 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 11:45 < adiabat> howdy, I've having trouble getting 0.13.1 synced up to testnet3 11:45 < adiabat> running on a raspi2 11:45 < adiabat> got a "EXCEPTION: St9bad_alloc" in debug.log 11:45 < sipa> how much ram does that have? 11:45 < adiabat> 1G 11:46 < adiabat> I've gotten that exception in different places when deleting and starting over 11:46 < sipa> hmm, maybe you need a bit of tweaking to reduce dbcache/mempool, and limit the number of peers? 11:46 < sipa> it shouldn't be much 11:46 < adiabat> this is all with 1 peer via connect= in the conf 11:46 < adiabat> also I'm running txindex=1 11:47 < sipa> ah 11:48 < adiabat> it was working OK on 0.13.1 but that had been upgraded many times. Then I broke my microSD card in half :( 11:48 < adiabat> IBD from scratch on .13.1 on the pi may need different settings? 11:50 < sipa> maybe... it clearly means OOM 11:50 < adiabat> I'll try dbcache=64 11:56 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 11:57 -!- cfields [~quassel@unaffiliated/cfields] has quit [Remote host closed the connection] 12:00 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 258 seconds] 12:00 -!- cfields [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev 12:02 < adiabat> If this works (will know in ~24hrs) maybe we can put a readme or something. With the arm binaries I think more people will try running on a pi2/pi3 12:03 < adiabat> also far be it from me to complain but trashing the who DB requiring re-index on an OOM error is... unfortunate. 12:03 < adiabat> (Not offering to fix that! heh) 12:03 < adiabat> who = *whole 12:05 < sipa> we should work on being able to dump the utxo set to a file and load it back 12:07 < adiabat> I've never had bitcoind get in trouble with RAM on a regular x86 computer, and I've run it on PCs with 2G of RAM 12:10 -!- cysm [cysm@unaffiliated/paracyst] has quit [Remote host closed the connection] 12:15 < gmaxwell> 2GB is a lot more than 1GB. :) 12:17 < adiabat> heh... I wonder what the least powerful full node is. raspi is getting close maybe, but I'm sure someone out there has it running with 512MB 12:17 < Victorsueca> adiabat: just download more ram ;) 12:18 < sipa> it's not cisco hardware 12:18 < pigeons> ramdoubler.exe 12:31 < Chris_Stewart_5> Is the serialization format described in BIP141 only used when calculating a wtxid, or is this serialization format also used when propogating a tx across the p2p network? 12:31 < Chris_Stewart_5> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#transaction-id 12:32 < sipa> Chris_Stewart_5: see bip144 for that 12:32 < Chris_Stewart_5> ahhh that makes a lot more sense :-) 12:37 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 12:41 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 12:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:42 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 12:48 < instagibbs> too-many-bips problem :P 12:48 < instagibbs> is there a zmq/rest test suite? 13:29 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 13:38 < bitcoin-git> [bitcoin] btcdrak opened pull request #9206: Make test constant consistent with consensus.h (master...consistency) https://github.com/bitcoin/bitcoin/pull/9206 13:45 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:51 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:00 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:03 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:06 < jtimon> updated https://github.com/bitcoin/bitcoin/pull/9177 's description 14:15 < jtimon> also if anyone is bored, you can fetch #8994 , grep and remove 'self.chain = "regtest"' and you should have 4 tests failing, ie p2p-comapctblocks.py, segwit.py, mempool_packages.py (extended) and pruning.py (extended) 14:15 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 14:17 < jtimon> also please review #8855 (takes +86 −81 out of review from #8994 's +360 −201 and #9177 's +866 −286) 14:17 < gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub 14:17 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 14:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9177 | NOMERGE: WIP: Support block signed custom testchains by jtimon · Pull Request #9177 · bitcoin/bitcoin · GitHub 14:18 < jtimon> plus I wouldn't need to rebase every time a new test uses Params(std::string) 14:18 < jtimon> 14:20 < jtimon> final note (I believe #8994 could be merged as it is modulo squash) 14:20 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 14:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:31 -!- protomar [~protomar@91.214.169.69] has quit [Quit: Leaving] 14:36 < luke-jr> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/8877#discussion_r89126900 <-- ? 15:36 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 15:37 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 17:38 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 17:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yxcnmjaozpbjrxnr] has quit [Quit: Connection closed for inactivity] 17:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 19:37 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 19:40 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 19:42 -!- abpa [~abpa@2602:306:b837:dbf0:fd15:d93:60c0:af91] has joined #bitcoin-core-dev 19:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 20:26 -!- abpa [~abpa@2602:306:b837:dbf0:fd15:d93:60c0:af91] has quit [Remote host closed the connection] 20:39 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:40 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:45 -!- dermoth [~thomas@dsl-216-221-51-181.mtl.aei.ca] has joined #bitcoin-core-dev 20:49 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 21:06 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:07 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:21 -!- jujumax [~jujumax@host250.190-137-164.telecom.net.ar] has joined #bitcoin-core-dev 21:30 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:31 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:41 < wumpus> instagibbs: yes there are testcases for zmq and rest 21:47 -!- takashi [~takashi@194.250.149.210.rev.vmobile.jp] has joined #bitcoin-core-dev 21:58 -!- jujumax [~jujumax@host250.190-137-164.telecom.net.ar] has quit [Ping timeout: 248 seconds] 22:11 -!- jujumax [~jujumax@host250.190-137-164.telecom.net.ar] has joined #bitcoin-core-dev 22:12 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 22:14 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac489b24453c...4d8558a2871e 22:14 < bitcoin-git> bitcoin/master ce2bb23 jnewbery: getrawtransaction should take a bool for verbose 22:14 < bitcoin-git> bitcoin/master 240189b John Newbery: add testcases for getrawtransaction 22:14 < bitcoin-git> bitcoin/master 4d8558a Wladimir J. van der Laan: Merge #9025: getrawtransaction should take a bool for verbose... 22:14 -!- takashi [~takashi@194.250.149.210.rev.vmobile.jp] has quit [Remote host closed the connection] 22:16 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 22:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4d8558a2871e...40022fe5f2b5 22:18 < bitcoin-git> bitcoin/master 2e44893 Jonas Schnelli: Move -salvagewallet, -zap(wtx) to where they belong 22:18 < bitcoin-git> bitcoin/master 40022fe Wladimir J. van der Laan: Merge #9142: Move -salvagewallet, -zap(wtx) to where they belong... 22:18 < bitcoin-git> [bitcoin] laanwj closed pull request #9142: Move -salvagewallet, -zap(wtx) to where they belong (master...2016/11/wallet_init) https://github.com/bitcoin/bitcoin/pull/9142 22:19 < wumpus> can people please notify me if there is a pull which is clearly ready for merging? (e.g. 9142 had three utacks and was ready for merge for ~7 days already) 22:19 < wumpus> there are too many open for me to keep track of so I really need help in that 22:23 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 22:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/40022fe5f2b5...5ea5e0401cb3 22:25 < bitcoin-git> bitcoin/master 4512550 Jonas Schnelli: Remove unnecessary calls to CheckFinalTx 22:25 < bitcoin-git> bitcoin/master 5ea5e04 Wladimir J. van der Laan: Merge #9141: Remove unnecessary calls to CheckFinalTx... 22:25 < bitcoin-git> [bitcoin] laanwj closed pull request #9141: Remove unnecessary calls to CheckFinalTx (master...2016/11/istrusted) https://github.com/bitcoin/bitcoin/pull/9141 22:29 < cfields> wumpus: sure 22:30 -!- shangzhou [uid156782@gateway/web/irccloud.com/x-tnmqvwbsllijytjr] has joined #bitcoin-core-dev 22:30 < wumpus> cfields: thanks 22:30 < cfields> wumpus: would a "looks ready" label help? 22:30 < cfields> not sure if that would just be noisy 22:32 < shangzhou> wumpus: #9037 per author's last comment 22:32 < gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub 22:33 < wumpus> well, setting a label or even a github notification is easy to miss too :) 22:33 < cfields> sure, i just figured it'd be an easy filter 22:34 < wumpus> shangzhou: will take a look 22:34 < wumpus> shangzhou: it has no (ut)ACKs at all,certainly still needs review 22:35 < wumpus> cfields: btw good call in #9128 on not cleansing memory after every message anymore, it's always been kind of silly 22:35 < gribble> https://github.com/bitcoin/bitcoin/issues/9128 | net: Decouple CConnman and message serialization by theuni · Pull Request #9128 · bitcoin/bitcoin · GitHub 22:36 < cfields> wumpus: yea, i suspect that's actually a major part of the sending overhead 22:37 < cfields> it showed to be a majority when profiling, though i built at -O0 or -O1 for that, so it probably wasn't realistic 22:37 < wumpus> well overwriting memory with zeros shouldn't be too bad, though apparently it gets the openssl lock which is bad 22:37 < fanquake> It'd be handy if you could change the default PR ordering to something like that. 22:37 < cfields> wumpus: see the suggestion in https://github.com/bitcoin/bitcoin/issues/9198 as well 22:38 < cfields> or maybe that's what reminded you :) 22:38 -!- harrymm [~wayne@104.222.140.19] has quit [Ping timeout: 260 seconds] 22:38 < wumpus> cfields: yes that's what reminded me 22:39 < wumpus> I had seen it before and wondered wtf, but seemed too invasive to change at the time 22:39 < cfields> wumpus: well the zero-write goes out of its way to be a pain-in-the-ass, and therefor slower than it should be. Otherwise it'd just be optimized out 22:39 < wumpus> now that things have beeen disentangled a bit it is easier 22:39 < cfields> so i think much of the hit just comes from having any non-trivial dtor, regardless of what it is 22:40 < cfields> but again, that's coming from profiling data in the non-optimized case. Much of that probably goes away at -O2 or -O3 22:40 < wumpus> yes could be 22:40 < cfields> so yea, the locks probably account for most of it at that point 22:40 < wumpus> right, profiling results at O0 are useless :) 22:42 < cfields> wumpus: i can't think of where cleansing is really necessary other than private keys and passphrases? 22:43 < cfields> though i'd like to be sufficiently paranoid if i'm going to be the one PRing the removals :) 22:44 < wumpus> I think so, I'm not entirely sure 22:45 < wumpus> if that is the case we wouldn't even need the zero_after_free allocator, just the lockedpool one used for key data 22:46 < wumpus> but in any case yes such a PR would have to evalutate all uses of zero after free individually 22:47 < cfields> that makes sense. Hard to make the case for something sensitive enough to zero but not memlock 22:47 < fanquake> Does anyone have some inputs to share for testing #9172 22:47 < gribble> https://github.com/bitcoin/bitcoin/issues/9172 | An error has occurred and has been logged. Please contact this bot's administrator for more information. 22:48 < wumpus> fanquake: yes I do now, let me upload 22:48 < cfields> ah damn, that one slipped away from me again 22:49 -!- jujumax [~jujumax@host250.190-137-164.telecom.net.ar] has quit [Ping timeout: 248 seconds] 22:49 < cfields> will review in the morning. The build-side looked fine, I just wanted to find something to plug in to test 22:50 < wumpus> fanquake: https://download.visucore.com/bitcoin/bitcoin_fuzzy_in.tar.xz 22:50 < fanquake> cfields talking about 9172? Did you install afl via brew or download and install? 22:50 < fanquake> wumpus thanks 22:51 < cfields> fanquake: not tested yet, just a quick review of the build changes 22:51 -!- harrymm [~wayne@104.222.140.34] has joined #bitcoin-core-dev 22:52 < fanquake> Ok. I'll try using brew'd afl, seems to be up to date (2.35b) 22:57 < wumpus> cfields: "Note that each message should be padded in the front by at least CSerializedNetMsg::header_pad_size bytes. This allows for a header to be inserted without requring a copy." awesome, we're getting our own skb's :) 22:57 < wumpus> (reminds me of http://vger.kernel.org/~davem/skb_data.html) 23:01 < cfields> wumpus: hah! that's exactly what it's like. Wish I would've known to google "skb" earlier, would've saved me some head-scratching. Good to know it's a reasonable approach, though :) 23:06 < wumpus> instagibbs: eh in #9073 you changed the bitcoin-cli message but it's confusing now: error: couldn't connect to server (make sure server is running and you are connecting to the correct RPC port: -1 unknown) 23:06 < gribble> https://github.com/bitcoin/bitcoin/issues/9073 | Trivial: Add common failure cases for rpc server connection failure by instagibbs · Pull Request #9073 · bitcoin/bitcoin · GitHub 23:06 < wumpus> instagibbs: that's as if the *port* is unknown. The error code and message should be on the first line, not the second :) 23:06 < wumpus> cfields: yes it's a great way of handling packet processing 23:09 < wumpus> btw RPC named arguments is feature-complete now (support in bitcoin-cli landed) and ready for testing https://github.com/bitcoin/bitcoin/pull/8811 23:15 < cfields> wumpus: thanks. I'd really like to see that. Pushing on my review stack as well. 23:18 < fanquake> wumpus did you need to set a higher (>50mb) memory limit when running the fuzzer? 23:18 < wumpus> fanquake: no,I did not change any afl settings 23:19 < wumpus> may make sense though 23:19 < wumpus> cfields: thanks 23:20 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ea5e0401cb3...791b58d148ab 23:20 < bitcoin-git> bitcoin/master a33b169 Pieter Wuille: Do not fully sort all nodes for addr relay... 23:20 < bitcoin-git> bitcoin/master 791b58d Wladimir J. van der Laan: Merge #8690: Do not fully sort all nodes for addr relay... 23:22 < fanquake> wumpus: Ok, I must have a different issue, as I've upped the memory limit to 12GB and it's still warning that may be to restrictive. 23:25 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mbzagksyprqdjcek] has joined #bitcoin-core-dev 23:25 < wumpus> heh 23:28 < jonasschnelli> I think this is ready: https://github.com/bitcoin/bitcoin/pull/9196 23:39 < wumpus> jonasschnelli: looking 23:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/791b58d148ab...7e2bfd62419f 23:40 < bitcoin-git> bitcoin/master 67c6326 Russell Yanofsky: Send tip change notification from invalidateblock... 23:40 < bitcoin-git> bitcoin/master 7e2bfd6 Wladimir J. van der Laan: Merge #9196: Send tip change notification from invalidateblock... 23:40 < bitcoin-git> [bitcoin] laanwj closed pull request #9196: Send tip change notification from invalidateblock (master...pr/notify-tip) https://github.com/bitcoin/bitcoin/pull/9196 23:41 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7e2bfd62419f...5e8631b6cb5b 23:41 < bitcoin-git> bitcoin/master f004e67 Greg Walker: Minor change to comment above new NODE_WITNESS service flag to keep it consitent with existing comment structure. Helps with readability. 23:41 < bitcoin-git> bitcoin/master 5e8631b Wladimir J. van der Laan: Merge #9205: Minor change to comment for consistency.... 23:41 < bitcoin-git> [bitcoin] laanwj closed pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205 23:42 < luke-jr> [07:28:49] I think this is ready: https://github.com/bitcoin/bitcoin/pull/9196 <-- am I missing something? what if the new best isn't pprev? 23:42 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e8631b6cb5b...74ced54b7e7b 23:42 < bitcoin-git> bitcoin/master 918b126 instagibbs: fix CreateTransaction error messages 23:42 < bitcoin-git> bitcoin/master 74ced54 Wladimir J. van der Laan: Merge #9204: Clarify CreateTransaction error messages... 23:42 < bitcoin-git> [bitcoin] laanwj closed pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204 23:42 < jonasschnelli> Luke-Jr: how could that be the case in InvalidateBlock()? 23:43 < luke-jr> jonasschnelli: a->b->c->d->e vs a->b->c->x; invalidate d 23:43 * jonasschnelli verifying 23:46 < jonasschnelli> Luke-Jr: You mean what happens if you invalidate block x) in a->b->c->d->e? (block thats not part of the main-chain)? 23:47 < luke-jr> jonasschnelli: no, I mean invalidate block D 23:47 < jonasschnelli> if you invalidate d) in a->b->c->d->e, pindex==d and pprev should match 23:47 < luke-jr> it should end up on block X 23:47 < luke-jr> X > C 23:48 < jonasschnelli> Hmm... let me test this though... 23:53 < bitcoin-git> [bitcoin] AmirAbrams opened pull request #9207: [Doc] Add missing bash # comment characters (master...patch-2) https://github.com/bitcoin/bitcoin/pull/9207