--- Day changed Fri Nov 25 2016 00:07 < wumpus> happy it was not targeted specifically at least 00:26 < bitcoin-git> [bitcoin] laanwj opened pull request #9219: doc: Improve windows build instructions using Linux subsystem (master...2016_11_windows_build_update) https://github.com/bitcoin/bitcoin/pull/9219 00:33 < bitcoin-git> [bitcoin] fanquake closed pull request #8983: WIP: Log block height and size when received (master...ShowBlockHeightAndSizeWhenReceived) https://github.com/bitcoin/bitcoin/pull/8983 00:36 < fanquake> sipa any opinion on #8844 ? 00:36 < gribble> https://github.com/bitcoin/bitcoin/issues/8844 | Change sigops cost to sigops weight by jnewbery · Pull Request #8844 · bitcoin/bitcoin · GitHub 01:03 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:09 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 01:29 < gmaxwell> rusty: https://people.xiph.org/~greg/temp/fee_avail3.png looking pretty good the last couple days. 01:33 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:34 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:36 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 01:36 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 01:36 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:38 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 01:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d932159f3467...97ec6e5c9098 01:39 < bitcoin-git> bitcoin/master 5262a15 Daniel Cousens: tx_valid: re-order inputs to how they are encoded 01:39 < bitcoin-git> bitcoin/master 97ec6e5 MarcoFalke: Merge #9100: tx_valid: re-order inputs to how they are encoded... 01:39 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9100: tx_valid: re-order inputs to how they are encoded (master...testorder) https://github.com/bitcoin/bitcoin/pull/9100 02:11 -!- LeMiner [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 02:15 -!- laurentmt [~Thunderbi@80.215.178.136] has joined #bitcoin-core-dev 02:26 < MarcoFalke> #9220 has same binaries, so fine to merge right now. 02:26 < gribble> https://github.com/bitcoin/bitcoin/issues/9220 | Refactor: Stop using namespace std (bitcoin-cli/-tx). by kallewoof · Pull Request #9220 · bitcoin/bitcoin · GitHub 02:35 -!- liuhuanjie_ [~jenenliu@183.6.157.58] has quit [Read error: Connection reset by peer] 02:36 < MarcoFalke> Just going to merge. Hope this is fine 02:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/97ec6e5c9098...e22f409f1888 02:36 < bitcoin-git> bitcoin/master 2f2625a Karl-Johan Alm: Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. 02:36 < bitcoin-git> bitcoin/master e22f409 MarcoFalke: Merge #9220: Refactor: Stop using namespace std (bitcoin-cli/-tx).... 02:37 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9220: Refactor: Stop using namespace std (bitcoin-cli/-tx). (master...no-using-ns) https://github.com/bitcoin/bitcoin/pull/9220 02:38 < MarcoFalke> #8776 looks good as well. Anyone other than jonas or me give another review on that one? 02:38 < gribble> https://github.com/bitcoin/bitcoin/issues/8776 | Wallet refactoring leading up to multiwallet by luke-jr · Pull Request #8776 · bitcoin/bitcoin · GitHub 02:40 * luke-jr wonders if we can ionice historical blocks somehow 02:52 < jonasschnelli> Would appreciate if someone reviews #9143 (~moveonly) 02:52 < gribble> https://github.com/bitcoin/bitcoin/issues/9143 | Refactor ZapWalletTxes to avoid layer vialotions by jonasschnelli · Pull Request #9143 · bitcoin/bitcoin · GitHub 02:53 < jonasschnelli> 9143 leads to CWallet* free CWalletDB which allows compiling CWalletDB without circular dependencies which would allow writing a tool that could create / manipulate wallets 02:53 < jonasschnelli> (next to a better class design) 02:56 < jonasschnelli> MarcoFalke: Yes. 8776 should go in as well.. maybe wait for a final (ut)ACK from wumpus 03:04 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 03:07 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:53 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 268 seconds] 03:58 -!- Noth [~Noth@194.254.61.161] has joined #bitcoin-core-dev 04:11 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 04:18 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 04:22 -!- Noth [~Noth@194.254.61.161] has left #bitcoin-core-dev ["Leaving..."] 05:31 -!- laurentmt1 [~Thunderbi@80.215.178.136] has joined #bitcoin-core-dev 05:32 -!- laurentmt [~Thunderbi@80.215.178.136] has quit [Ping timeout: 265 seconds] 05:32 -!- laurentmt1 is now known as laurentmt 06:05 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 06:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:14 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 06:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:26 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 06:38 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 06:50 -!- YOU-JI [~youyouyou@y194065.dynamic.ppp.asahi-net.or.jp] has joined #bitcoin-core-dev 06:52 -!- YOU-JI [~youyouyou@y194065.dynamic.ppp.asahi-net.or.jp] has quit [Client Quit] 07:03 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 07:03 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:12 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-jsksbxeqncicgoyo] has quit [Quit: Connection closed for inactivity] 07:12 -!- laurentmt [~Thunderbi@80.215.178.136] has quit [Quit: laurentmt] 07:14 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:18 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:23 -!- chris200_ [~chris2000@p5082AE53.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 07:24 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 07:25 -!- laurentmt [~Thunderbi@80.215.178.136] has joined #bitcoin-core-dev 07:26 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pdxlxrtgqzrnswnz] has joined #bitcoin-core-dev 07:38 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]] 07:39 -!- laurentmt [~Thunderbi@80.215.178.136] has quit [Quit: laurentmt] 07:56 -!- laurentmt [~Thunderbi@80.215.178.136] has joined #bitcoin-core-dev 08:19 -!- laurentmt [~Thunderbi@80.215.178.136] has quit [Quit: laurentmt] 08:21 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 08:25 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 268 seconds] 08:29 -!- laurentmt [~Thunderbi@80.215.178.136] has joined #bitcoin-core-dev 08:29 -!- laurentmt [~Thunderbi@80.215.178.136] has quit [Client Quit] 08:49 -!- NLNico [~NLNico@unaffiliated/nlnico] has joined #bitcoin-core-dev 09:00 -!- JackH [~laptop@79-73-184-38.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 09:02 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 09:07 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 09:08 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #8859: WIP: [qa] Add script to check for datadir compatibility between versions (master...Mf1610-qaCompat) https://github.com/bitcoin/bitcoin/pull/8859 09:13 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9221: [qa] maxuploadtarget: Get rid of duplicate code (master...Mf1611-qaMaxUploadDuplCode) https://github.com/bitcoin/bitcoin/pull/9221 09:27 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 09:32 -!- laurentmt [~Thunderbi@80.215.178.136] has joined #bitcoin-core-dev 09:48 -!- laurentmt [~Thunderbi@80.215.178.136] has quit [Quit: laurentmt] 09:58 -!- NLNico [~NLNico@unaffiliated/nlnico] has quit [Quit: Leaving] 10:33 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:33 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:06 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:18 < bitcoin-git> [bitcoin] sipa pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/e22f409f1888...76fec09d878d 11:19 < bitcoin-git> bitcoin/master d74e352 Cory Fields: net: Set feelers to disconnect at the end of the version message... 11:19 < bitcoin-git> bitcoin/master fedea8a Cory Fields: net: don't send any messages before handshake or after requested disconnect... 11:19 < bitcoin-git> bitcoin/master b7695c2 Cory Fields: net: No need to check individually for disconnection anymore 11:19 < bitcoin-git> [bitcoin] sipa closed pull request #9128: net: Decouple CConnman and message serialization (master...connman-send) https://github.com/bitcoin/bitcoin/pull/9128 11:20 < sipa> wumpus: opinion on #8610? 11:20 < gribble> https://github.com/bitcoin/bitcoin/issues/8610 | Share unused mempool memory with coincache by sipa · Pull Request #8610 · bitcoin/bitcoin · GitHub 11:26 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:29 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:30 < Chris_Stewart_5> To use CPFP you don't have to have sequence numbers set to 0xffffffff - 1 correct? 11:31 < sipa> indeed, it always works 11:32 -!- snaka12 [~snaka12@119.81.159.208] has joined #bitcoin-core-dev 11:56 -!- jannes [~jannes@178.132.211.90] has quit [Remote host closed the connection] 12:07 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:22 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 12:25 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 248 seconds] 12:27 -!- Jarid [5b6d1e6c@gateway/web/freenode/ip.91.109.30.108] has joined #bitcoin-core-dev 12:27 < Jarid> Site where you can double your bitcoins in 48h [proof on site fb page] ----> https://coinfever.me/?ref=520be735339 12:27 -!- Jarid [5b6d1e6c@gateway/web/freenode/ip.91.109.30.108] has quit [Client Quit] 12:28 < Lauda> #ban 12:29 < Chris_Stewart_5> So if you use the 'createrawtransactino' rpc, does this circumvent other flags you had set when starting bitcoind just as -walletrbf 12:36 < btcdrak> Looking for a review of #7562 12:36 < gribble> https://github.com/bitcoin/bitcoin/issues/7562 | Bump transaction version default to 2 by btcdrak · Pull Request #7562 · bitcoin/bitcoin · GitHub 12:43 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 12:46 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:50 < arubi> Chris_Stewart_5, if you're specifying the inputs, then you should also specify the sequence. afaik createrawtransaction is not a wallet function. you could createrawtransaction with just the outputs, then fundrawtransaction, and you'll get the inputs with opt-in rbf sequence 12:57 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 12:57 < Chris_Stewart_5> arubi: Thanks, yeah I was getting all maxed sequence numbers when using 'createrawtransaction' with -walletrbf set 12:58 < arubi> well if you're already specifying the inputs verbatim, just use "::" sequence is base 10.. 12:59 < arubi> or I guess, it takes json, add the "sequence" field. I just use bitcoin-tx :) 12:59 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:10 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 13:13 < Chris_Stewart_5> arubi: I'm using sendtoaddress rpc command with rbf and creates a tx with sequence number 4294967294 which is 0xffffffff - 1. This seems to be contradictory to BIP 125 which says the seqeuence number needs to be < 0xffffffff -1 13:14 < Chris_Stewart_5> with -walletrbf I should say 13:18 -!- oddcomet [369924af@gateway/web/freenode/ip.54.153.36.175] has joined #bitcoin-core-dev 13:25 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 13:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:32 < arubi> Chris_Stewart_5, right, I use 2^32-3. I think that's what core does too 13:45 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 13:49 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:57 -!- oddcomet [369924af@gateway/web/freenode/ip.54.153.36.175] has quit [Ping timeout: 260 seconds] 13:59 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:22 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:31 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 14:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:32 -!- snaka12 [~snaka12@119.81.159.208] has quit [] 14:33 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit] 14:55 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 15:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:37 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 15:53 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:7042:fa97:b53d:cf4c] has joined #bitcoin-core-dev 15:55 < bitcoin-git> [bitcoin] dooglus opened pull request #9222: Add 'subtractFeeFromAmount' option to 'fundrawtransaction'. (master...subtractFeeFromAmount-in-fundraw) https://github.com/bitcoin/bitcoin/pull/9222 16:20 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 248 seconds] 16:21 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:7042:fa97:b53d:cf4c] has quit [Remote host closed the connection] 16:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 16:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 17:04 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 17:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:35 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 17:40 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:55 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 258 seconds] 18:23 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 18:42 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pdxlxrtgqzrnswnz] has quit [Quit: Connection closed for inactivity] 19:27 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 19:43 -!- crudel [crudel@gateway/shell/fnordserver.eu/x-amffvsnnapeceuas] has joined #bitcoin-core-dev 19:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds] 19:57 < morcos> sipa: what did you think about my last comment on 8610. i think that alleviates both issues and doesn't cause the concern suhas was worried about 19:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 20:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 20:21 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:58 -!- chris200_ [~chris2000@p5082AE53.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds] 21:09 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 260 seconds] 21:11 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:11 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 21:12 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:38 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 21:39 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 250 seconds] 21:45 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 22:20 -!- CubicEarth [~cubiceart@c-50-135-106-66.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 22:48 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 22:49 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 22:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 23:05 -!- CubicEar_ [~cubiceart@73.109.60.205] has joined #bitcoin-core-dev 23:08 -!- CubicEarth [~cubiceart@c-50-135-106-66.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 23:17 -!- CubicEarth [~cubiceart@c-50-135-106-66.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 23:17 -!- CubicEarth [~cubiceart@c-50-135-106-66.hsd1.wa.comcast.net] has quit [Client Quit] 23:20 -!- CubicEar_ [~cubiceart@73.109.60.205] has quit [Ping timeout: 245 seconds] 23:24 < gmaxwell> oh god, does zapwallet not backup the wallet before zapping like salvage does? 23:38 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds] 23:54 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev