--- Day changed Mon Dec 05 2016
00:00 < BlueMatt> sipa: strange...I was not doing that, iirc
00:01 < BlueMatt> I think I tried -march=native originally, but turned it off when it didnt work
00:01 < BlueMatt> (and ccache and all that shit)
00:01 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection]     
00:02 < BlueMatt> gmaxwell: this is why I auto-ban on strange-ass nodes like that (and had already banned that ip)
00:02 < BlueMatt> and why my public node is behind stupid-ridiculous ddos protection :)
00:03 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
00:04 < gmaxwell> sipa: why does O3 break it?!
00:05 < sipa> gmaxwell: sense it makes none
00:05 < sipa> a linker error with ~boost::filesystem::path
00:07 < wumpus> never tried flto with -O3, no issues with -O2
00:09 < sipa> (which afaik was what BlueMatt was seeing as well)
00:10 < BlueMatt> sipa: yes, it was, though I thought I went back and disabled all the strange optimizations for testing when it failed
00:10 < BlueMatt> actually, pretty sure I did
00:17 < gmaxwell> I have a newly updated mass-connector/spy banlist which added 13 new entries:  
00:17 < gmaxwell> https://0bin.net/paste/iSGeBTgtmA8cSHGX#VBd97-ME4hUiIqJIOsd24oLfM57UXP3F3QfgzuoVHAD  -- with commandline syntax
00:17 < gmaxwell> https://0bin.net/paste/zplzkwGmn6oeP6Ec#oTFWsZFpGQ1zR10Ofv3mJbIOGCnoshxQBQBJoWhSaip -- with debug console syntax
00:19 -!- LeMiner2 [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
00:21 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]     
00:21 < wumpus> thanks
00:21 -!- LeMiner [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds]     
00:21 -!- LeMiner2 is now known as LeMiner     
00:24 -!- LeMiner2 [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
00:25 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 260 seconds]     
00:26 -!- afk11 [~afk11@176.61.67.182] has joined #bitcoin-core-dev     
00:26 -!- afk11 [~afk11@176.61.67.182] has quit [Changing host]     
00:26 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev     
00:26 -!- LeMiner [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds]     
00:26 -!- LeMiner2 is now known as LeMiner     
00:30 < Lightsword> gmaxwell, maybe 138.197.197.164 as well
00:31 < Lightsword> and 138.197.197.132 and 180.173.203.229 and 138.197.197.108
00:31 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9280: [Qt] Show ModalOverlay by pressing the progress bar, allow hiding (master...2016/12/qt_modal) https://github.com/bitcoin/bitcoin/pull/9280
00:32 < gmaxwell> Lightsword: I've only been including ones that show up on all my input hosts, unfortunately since everyone is at limits, that conceals a few.
00:35 < BlueMatt> gmaxwell: just take the unlimited-connection-slots patch?
00:37 < sipa> you can set -maxconnections=1000 without any patches
00:41 < BlueMatt> sipa: huh? I thought that sets you at 125?
00:42 < sipa> no     
00:42 < sipa> 125 is just the default
00:42 < BlueMatt> sipa: its limited by available sockets
00:42 < wumpus> depends on what the fd lmiit is
00:42 < BlueMatt> which can be super low, because select()
00:42 < BlueMatt> or this used to be the case
00:43 < sipa> Warning: Reducing -maxconnections from 1000 to 873, because of system limitations.
00:43 < sipa> ok, 873.
00:43 < BlueMatt> oh, 873, hum, I thought it was lower
00:43 < wumpus> select() can handle 1024 on most systems, that's pretty much enough for most cases
00:43 < BlueMatt> whatever, I carry a patch to use poll() to make it actually higher....
00:44 < wumpus> I guess we've held up switching to poll because we expected to switch to libevent any day, that's taking a bit longer than expected :)
00:44 < sipa> Soon! (tm)
00:44 < wumpus> yea :-)
00:44 < gmaxwell> IIRC matt's patch is darn near trivial.
00:45 -!- JackH [~laptop@79-73-189-171.dynamic.dsl.as9105.com] has quit [Quit: Leaving]     
00:45 -!- JackH [~laptop@79-73-189-171.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
00:46 < BlueMatt> gmaxwell: yes, but given that its 873 not 1XX as I'd thought, probably not worth it
00:46 < BlueMatt> and libevent is actually sooner now
00:49 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
01:01 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-sczzggonijjticjv] has quit [Read error: Connection reset by peer]     
01:01 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-dhdgxiueqocbnxdt] has joined #bitcoin-core-dev     
01:03 -!- Guest13131 [~ChillazZ@194.97.152.20] has quit [Ping timeout: 258 seconds]     
01:07 -!- ChillazZ [~ChillazZ@194.97.152.20] has joined #bitcoin-core-dev     
01:07 -!- ChillazZ is now known as Guest15721     
01:13 < bitcoin-git> [bitcoin] kallewoof opened pull request #9281: Refactor: Removed using namespace <xxx> from bench/ & test/ sources (master...no-using-namespace-bench-test) https://github.com/bitcoin/bitcoin/pull/9281
01:18 -!- wvr [~wvr@189.red-83-33-12.dynamicip.rima-tde.net] has quit []     
01:27 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
01:28 -!- Guest15721 [~ChillazZ@194.97.152.20] has quit [Ping timeout: 258 seconds]     
01:28 -!- ChillazZ [~ChillazZ@194.97.152.20] has joined #bitcoin-core-dev     
01:29 -!- ChillazZ is now known as Guest62446     
01:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
01:36 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 250 seconds]     
01:55 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-dhdgxiueqocbnxdt] has quit [Ping timeout: 260 seconds]     
01:55 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-zwsxtmpbbswbtrok] has joined #bitcoin-core-dev     
01:56 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection]     
01:57 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
01:57 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection]     
01:57 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
01:57 -!- wvr [~wvr@189.red-83-33-12.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
01:58 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-zwsxtmpbbswbtrok] has quit [Read error: Connection reset by peer]     
01:59 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d04aebaec7bb...613bda418f83
01:59 < bitcoin-git> bitcoin/master 634ad51 Pieter Wuille: Squashed 'src/leveldb/' changes from 20ca81f..a31c8aa...
01:59 < bitcoin-git> bitcoin/master 605d701 Pieter Wuille: Merge in LevelDB 1.19 changes
01:59 < bitcoin-git> bitcoin/master 613bda4 Wladimir J. van der Laan: Merge #8613: LevelDB 1.19...
02:00 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-bxzfvspouzjktzth] has joined #bitcoin-core-dev     
02:02 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev     
02:02 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host]     
02:02 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:03 < sipa> wumpus: yeah, i didn't mean to say we should use reuse_logs, just that the feature over time may be interesting to us
02:03 < sipa> *roght now
02:05 < wumpus> sipa: right
02:09 -!- ClockCat [~CattieCat@75-109-228-219.stjocmtk01.res.dyn.suddenlink.net] has joined #bitcoin-core-dev     
02:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/613bda418f83...43e8150ef690
02:09 < bitcoin-git> bitcoin/master 2efc438 Pieter Wuille: Align struct COrphan definition
02:09 < bitcoin-git> bitcoin/master 43e8150 Wladimir J. van der Laan: Merge #9269: Align struct COrphan definition...
02:10 < bitcoin-git> [bitcoin] laanwj closed pull request #9269: Align struct COrphan definition (master...oneorphan) https://github.com/bitcoin/bitcoin/pull/9269
02:16 < bitcoin-git> [bitcoin] paveljanik opened pull request #9282: CMutableTransaction is defined as struct (master...20161205_CMutableTransaction_is_struct) https://github.com/bitcoin/bitcoin/pull/9282
02:29 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
02:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]     
02:34 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev     
02:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev     
02:36 < bitcoin-git> [bitcoin] sipa opened pull request #9283: A few more CTransactionRef optimizations (master...sharedblock2) https://github.com/bitcoin/bitcoin/pull/9283
02:55 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has quit [Quit: Coyote finally caught me]     
03:19 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has left #bitcoin-core-dev []     
03:47 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/43e8150ef690...c01f16aaa0ed
03:47 < bitcoin-git> bitcoin/master ea83d00 instagibbs: SendMoney: use already-calculated balance
03:47 < bitcoin-git> bitcoin/master c01f16a Wladimir J. van der Laan: Merge #9165: SendMoney: use already-calculated balance...
03:48 < bitcoin-git> [bitcoin] laanwj closed pull request #9165: SendMoney: use already-calculated balance (master...triv-curbal) https://github.com/bitcoin/bitcoin/pull/9165
03:53 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 248 seconds]     
03:55 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev     
03:55 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c01f16aaa0ed...7d5d44969b4a
03:55 < bitcoin-git> bitcoin/master c4b6fa8 Pavel Janík: CMutableTransaction is defined as struct.
03:55 < bitcoin-git> bitcoin/master 7d5d449 Wladimir J. van der Laan: Merge #9282: CMutableTransaction is defined as struct...
03:55 < bitcoin-git> [bitcoin] laanwj closed pull request #9282: CMutableTransaction is defined as struct (master...20161205_CMutableTransaction_is_struct) https://github.com/bitcoin/bitcoin/pull/9282
03:59 -!- _biO_ [~biO_@80.156.183.43] has joined #bitcoin-core-dev     
04:28 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
04:29 -!- Alina-malina_ is now known as Alina-malina     
04:29 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
04:30 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
04:32 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev     
05:02 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9284: Suppress some annoying deprecation warnings (OSX) (master...2016/12/osx_warnings) https://github.com/bitcoin/bitcoin/pull/9284
05:08 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
05:27 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:ed5c:b7f7:7c11:5b25] has quit [Quit: .]     
05:28 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
05:30 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 245 seconds]     
05:31 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 248 seconds]     
05:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
05:36 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 244 seconds]     
05:37 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 250 seconds]     
05:38 < jonasschnelli> And comments on our keypoolrefil RPC call behavior?
05:38 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/keypool.py#L45
05:39 < jonasschnelli> The tests proof, that nodes[0].keypoolrefill(3) result in 4 available keys.
05:39 < jonasschnelli> But reading the API docs, it should be 3.
05:39 < jonasschnelli> IMO the +1 is wrong here
05:39 < jonasschnelli> (I'd ask because I'd like to fix this with the HD split in ext/int chain)
05:46 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
05:56 < dcousens> hmm, CTransaction assignment was totally removed aye
06:00 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 248 seconds]     
06:00 < dcousens> sipa: was removing CTransaction& operator=(const CTransaction& tx); necessary, or just a safety precaution?
06:02 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev     
06:08 < dcousens> meh, I guess I can just CTransactionRef anyway
06:20 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds]     
06:21 < dcousens> eh, nvm, rebased all my local code, tl;dr was juts changing CTransaction to CTransactionRef, .vout to ->vout ... and thats it.
06:21 < dcousens> LGTM :)
06:25 < instagibbs> dcousens, I love happy endings 
06:32 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
06:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
06:37 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 265 seconds]     
06:49 < dcousens> instagibbs: not so happy yet ha
06:50 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection]     
06:51 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
06:52 < dcousens> trying a fresh-recompile,  but master seems to just lock up for me atm
06:54 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev     
07:03 -!- thib [~thib@wikimedia/Thibaut120094] has joined #bitcoin-core-dev     
07:08 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection]     
07:09 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
07:10 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev     
07:11 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds]     
07:13 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection]     
07:18 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev     
07:20 -!- laurentmt [~Thunderbi@80.215.138.113] has joined #bitcoin-core-dev     
07:21 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection]     
07:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:28 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev     
07:30 -!- bsm1175321 [~mcelrath@38.121.165.30] has quit [Client Quit]     
07:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Client Quit]     
07:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:32 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev     
07:33 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:ecc2:282c:91a5:1587] has joined #bitcoin-core-dev     
07:36 -!- laurentmt [~Thunderbi@80.215.138.113] has quit [Quit: laurentmt]     
07:37 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:ecc2:282c:91a5:1587] has quit [Ping timeout: 240 seconds]     
07:46 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection]     
07:48 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
07:49 -!- morcos [~morcos@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 250 seconds]     
07:49 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 265 seconds]     
07:51 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
07:51 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
07:56 -!- squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again]     
07:58 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev     
07:58 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host]     
07:58 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
08:30 -!- TomMc [~tom@gateway/vpn/privateinternetaccess/tommc] has joined #bitcoin-core-dev     
08:34 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
08:38 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]     
08:39 -!- laurentmt [~Thunderbi@80.215.138.113] has joined #bitcoin-core-dev     
08:47 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: This computer has gone to sleep]     
08:48 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:48 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev     
08:48 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host]     
08:48 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
08:55 -!- laurentmt [~Thunderbi@80.215.138.113] has quit [Quit: laurentmt]     
09:00 -!- laurentmt [~Thunderbi@80.215.138.113] has joined #bitcoin-core-dev     
09:04 -!- wvr [~wvr@189.red-83-33-12.dynamicip.rima-tde.net] has quit []     
09:10 -!- BCBot_ [~BCBot@46.101.246.115] has quit [Remote host closed the connection]     
09:10 -!- BCBot [~BCBot@46.101.246.115] has joined #bitcoin-core-dev     
09:29 < jl2012> in what situation, the "Warning: We do not appear to fully agree with our peers! You may need to upgrade, or other nodes may need to upgrade" will be shown?
09:34 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:ecc2:282c:91a5:1587] has joined #bitcoin-core-dev     
09:39 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:ecc2:282c:91a5:1587] has quit [Ping timeout: 258 seconds]     
09:40 < morcos> jonasschnelli: you around?
09:41 < morcos> re: #8501, I agree with not fixing the frequency..  But i'm unsure about the no duplicating the same value over and over again..  
09:41 < gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
09:42 < morcos> It might depend on the use case, but for instance it might be valuable to know that it stayed the same for a while and then incremented all at once, as opposed to not being able to tell that it just hadn't been simpled in between
09:43 < morcos> my thought was if we saved having to record the time stamp, we might be able to put up with lots of duplicate values..  especially if we're saving for instance only 1000 data points at second frequency, it just won't use all that much memory
09:43 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev     
09:43 < morcos> anywya, sorry, dont mean to redesign your whole PR months after you opened it
09:44 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]     
09:49 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has quit [Quit: leaving]     
10:15 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
10:16 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:19 -!- laurentmt [~Thunderbi@80.215.138.113] has quit [Quit: laurentmt]     
10:20 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 245 seconds]     
10:35 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
10:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:40 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 258 seconds]     
10:46 < Chris_Stewart_5> Does -txindex significantly impact performance of IBD? I tried to sync last night and only synced ~10K blocks, which seems slow. Is that reasonable? 
10:48 < sipa> that's totally unreasonable
10:49 < sipa> is it stuck?
10:49 < sipa> or just slow?
10:52 < Chris_Stewart_5> extremely slow it seems. I'm using out of box settings on 0.13.1 with -txindex. 
10:52 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
10:52 < sipa> does increasing dbcache help?
10:53 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Client Quit]     
10:53 < Chris_Stewart_5> I'll try it later and report back, default is 2GB? 
10:54 < sipa> default is 300MB
10:55 < Chris_Stewart_5> mmm that is probably why. I thought it was significantly higher. How long does IBD take other people with that setting as default?
10:59 < sipa> what height are you at now?
11:00 -!- pavel_ [~paveljani@79.98.72.176] has joined #bitcoin-core-dev     
11:01 -!- pavel_ [~paveljani@79.98.72.176] has quit [Client Quit]     
11:01 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 268 seconds]     
11:03 -!- aalex__ [~aalex@64.187.177.58] has quit [Read error: Connection reset by peer]     
11:03 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
11:04 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
11:05 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has joined #bitcoin-core-dev     
11:07 < Chris_Stewart_5> 403817
11:08 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds]     
11:08 -!- harrymm [~wayne@104.237.91.16] has quit [Ping timeout: 260 seconds]     
11:11 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds]     
11:12 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev     
11:12 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 260 seconds]     
--- Log closed Mon Dec 05 11:23:28 2016
--- Log opened Mon Dec 05 11:23:46 2016
11:23 -!- kanzure_ [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev     
11:23 -!- Irssi: #bitcoin-core-dev: Total of 157 nicks [0 ops, 0 halfops, 0 voices, 157 normal]     
11:24 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:24 -!- harrymm [~wayne@104.237.91.216] has joined #bitcoin-core-dev     
11:25 -!- bobbytux_ [~bobbytux@ARouen-653-1-4-84.w82-126.abo.wanadoo.fr] has quit [Quit: Ex-Chat]     
11:26 -!- jyap_ [~jyap@2604:180:1:7f5::b59a] has joined #bitcoin-core-dev     
11:27 -!- adam3us_ [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev     
11:27 -!- BlueMatt_ [~BlueMatt@mail.bluematt.me] has joined #bitcoin-core-dev     
11:28 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Disconnected by services]     
11:28 -!- BlueMatt_ is now known as BlueMatt     
11:28 -!- BlueMatt [~BlueMatt@mail.bluematt.me] has quit [Changing host]     
11:28 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev     
11:28 -!- Netsplit *.net <-> *.split quits: Atomicat, Bootvis, jyap, ville-, sdaftuar, kanzure, adam3us
11:28 -!- jyap_ is now known as jyap     
11:28 -!- jyap [~jyap@2604:180:1:7f5::b59a] has quit [Changing host]     
11:28 -!- jyap [~jyap@unaffiliated/jyap] has joined #bitcoin-core-dev     
11:28 -!- Atomicat_ is now known as Atomicat     
11:28 -!- ville-- [~ville@xollo.net] has joined #bitcoin-core-dev     
11:29 -!- Bootvis [~bob@baltar.lan.endoria.net] has joined #bitcoin-core-dev     
11:29 -!- harrymm [~wayne@104.237.91.216] has quit [Ping timeout: 268 seconds]     
11:34 -!- Irssi: Join to #bitcoin-core-dev was synced in 642 secs
11:37 -!- aalex_ [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
11:41 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds]     
11:49 -!- You're now known as kanzure     
12:00 -!- Madars [~null@unaffiliated/madars] has quit [Quit: Leaving.]     
12:03 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev     
12:08 -!- arubi_ is now known as arubi     
12:33 < Chris_Stewart_5> sipa: I should have been more clear, I have been trying to do IBD over the course of a few nights, with results like I said ~10k blocks a night. 
12:34 < Chris_Stewart_5> the first ~250k blocks went relatively fast (a couple hour period) but I think some might have already been on disk? Perhaps i'm using the term IBD a little too loosely 
12:34 < Chris_Stewart_5> but it is a major sync 
12:40 < instagibbs> sdaftuar_, why would you want to spend a coin from you wallet that has descendants(already spent)? I'm surely thinking of this wrong
12:41 < instagibbs> or are descendants calculated from a tx point of view, ie other output has been spent in a chain, therefore that adds to that count
12:42 < sdaftuar_> instagibbs: oh, yeah i meant in-mempool descendants
12:42 < sdaftuar_> say you have a tx that has 2 outputs, you send me money and give yourself change.
12:42 < sdaftuar_> then i chain 24 transactions off it
12:42 < sdaftuar_> you try to spend your change, but that'll fail
12:42 < instagibbs> ok, didnt think of the fact that outputs are linked re:descendants 
12:43 < sdaftuar_> that does seem to be a confusing property of the mempool limiting :)
12:43 -!- sdaftuar_ is now known as sdaftuar     
12:43 < instagibbs> but that is obv in hindsight. Ok, well one issue is you might have asymmetrical limits. 
12:43 < sdaftuar> yeah, i suggested using min()
12:43 < gmaxwell> it might have been better if that limit was split across outputs.
12:44 < sdaftuar> gmaxwell: that would then fail to capture the issue at hand, i think
12:44 < instagibbs> sdaftuar, hmm says max on my screen
12:44 < gmaxwell> e.g. A can have up to 24 decendants, it has two outputs, each can have 12 under it. 
12:44 < sdaftuar> sorry, max(tx->ancestor, tx->descendants()) should be less than min(ancestorlimit, descendantlimit)
12:44 < instagibbs> oh i see nvm
12:45 < sdaftuar> gmaxwell: oh, hm.
12:47 < gmaxwell> in the worst case though it reduces your maximum to a log_outputs(depth), which isn't awesome.
12:47 < sdaftuar> maybe doable, but kind of yuck to implement i think
12:48 < gmaxwell> but it would prevent other people from chewing up your limit. I think this hasn't actually been a problem, though I could imagine it being one in certian kinds of transaction protocols.
12:48 < sdaftuar> what kinds of protocols do you have in mind?
12:49 < gmaxwell> In the abstract, protocols where someone delaying your transaction can allow the party to cheat like atomic swaps. Not that big of a concern since unless the head transaction is confirmed those protocols are not secure against miners.
12:52 < sdaftuar> right, if someone comes up with a use case that does rely on the parent not necessarily being confirmed, then that should alter our thinking
12:53 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
12:59 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 260 seconds]     
13:19 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
13:23 -!- aalex_ [~aalex@64.187.177.58] has quit [Ping timeout: 250 seconds]     
13:53 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
13:58 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
14:13 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-bxzfvspouzjktzth] has quit [Quit: Connection closed for inactivity]     
14:15 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
14:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]     
14:28 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
14:31 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 258 seconds]     
14:44 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection]     
14:58 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 245 seconds]     
14:59 -!- JackH [~laptop@79-73-189-171.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]     
15:01 -!- tunafizz [tunafizz@c-71-207-55-31.hsd1.pa.comcast.net] has joined #bitcoin-core-dev     
15:12 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
15:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
15:31 -!- cryptapus is now known as cryptapus_afk     
15:33 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev     
15:39 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has quit [Quit: MarcoFalke]     
15:50 < dcousens> hmph
15:50 < dcousens> So I'm running master, no changes at all
15:50 < dcousens> And my bitcoind finishes up to verify, then just sits there on 100% CPU usage (probably forever, but who knows)
15:51 < gmaxwell> 'up to verify'? 
15:51 < dcousens> It fails to open up the RPC, or start synchronizing
15:51 < dcousens> checkblocks
15:51 < gmaxwell> what is the last log entry?
15:51 < gmaxwell> can you attach GDB?
15:51 < dcousens> It still keeps logging, but solely the tor control messages
15:52 < gmaxwell> that sounds like a deadlock then.
15:52 < dcousens> What do I need to do to attach GDB? Happy to do it
15:52 < gmaxwell> dcousens: what OS are you on?
15:53 < dcousens> just collecting info, sec
15:54 < gmaxwell> on *nix:   ps aux | grep bitcoin   to get the bitcoind pid    then gdb -p <pid> to attach.     then run thread apply all bt full   to get backtraces from every thread, and 0bin that to me,  and then you can type q<enter> to quit 
15:58 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
15:58 < dcousens> http://pastie.org/private/a40ppfohw2kxxxundn1iw - for the info, doing gdb now
16:04 < dcousens> gmaxwell: https://0bin.net/paste/GS3r5T8zbK5PWDmo#a97Ti6KI4ePCUa6tCJC0RWTDYa3oMxrM4dYJASGuga9 for gdb
16:05 < dcousens> let me know if you need anything else
16:05 < dcousens> I was considering compiling it without clang, just to see
16:08 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Ping timeout: 244 seconds]     
16:15 < dcousens> I forgot how much slower gcc builds :S
16:16 < gmaxwell> dcousens: build with O1. 
16:16 < gmaxwell> Clang default optimization levels are less effective than GCC's it compiles faster but for most code produces slower binaries.
16:17 < dcousens> gmaxwell: did you need me to build with O1 for debugging? Or just future reference
16:17 < sipa> i sometimes configure with -O1 to compile faster
16:17 < gmaxwell> no, just if the compile times bother you-- :)
16:17 < sipa> you could compile with "-Og -ggdb3"
16:18 < dcousens> brb, making breakfast ha
16:18 < gmaxwell> I see things waiting on cs_main in that backtrace... supports the locking theory but I don't see where.
16:26 < cfields> BlueMatt: around?
16:27 < cfields> BlueMatt: something I'm hacking on just started coming together nicely, but would like to make sure we're on the same page before I get in too deep
16:27 < dcousens> behaviour unchanged with gcc
16:27 < dcousens> wait no
16:28 < dcousens> no, RPC is responding now
16:28 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9286: Time-based expiration in LimitOrphanTxSize only when map is full. (master...defer_orphan_exp) https://github.com/bitcoin/bitcoin/pull/9286
16:28 < dcousens> though, only on requests not waiting CS_MAIN :P
16:29 < gmaxwell> hah     
16:29 < gmaxwell> dcousens: do you know how to compile with debug lockorder?
16:29 < cfields> dcousens: any chance it's sitting in an fread?
16:29 < gmaxwell> My WAG is that something about your configuration has revealed a lock inversion introduced -- likely by one of Matt's recent race condition fixes -- but other people aren't seeing it.
16:29 < dcousens> gmaxwell: no, a few commands away from doing it
16:29 < cfields> dcousens: if so, i get that on one of my machines when i use a certain combo of clang/libc and hardening enabled
16:30 < dcousens> gmaxwell: did you want me to start culling params?
16:30 < gmaxwell> dcousens: no, I'd like you to build with the lockorder debugging enabled.
16:30 < gmaxwell> if it is an inversion like I'm guessing it should immediately tell us exactly where.
16:31 < cfields> dcousens: oh, nm, i see the bt
16:31 < dcousens> gmaxwell: what do I need to do to enable it?
16:32 < gmaxwell> dcousens: run ./configure CXXFLAGS="-DDEBUG_LOCKORDER -g"  then build like normal
16:33 < dcousens> OK, interestingly this doesn't happen on a fresh .bitcoin (tried locally)
16:33 < dcousens> running the configure now
16:35 < dcousens> scratch that, still happens on a fresh .bitcoin :) (yay)
16:38 < BlueMatt> cfields: yea, I can take a look
16:39 < cfields> BlueMatt: well, not much to show yet, just an idea...
16:39 < BlueMatt> sure
16:40 < cfields> BlueMatt: using https://github.com/theuni/bitcoin/commit/3f598dbe7100c7c6c7bfb7e10210585327ed9d31 as a starting point
16:40 < BlueMatt> cfields: didnt you already show me this?
16:40 < cfields> with that, CConnman holds an instance of the message processor interface. Taking that a step further...
16:41 < cfields> BlueMatt: yea, just giving the context
16:41 < BlueMatt> ok     
16:41 < dcousens> while its compiling, i've binary searched the arguments to when it doesn't happen...
16:41 < dcousens> and, I have the argument that causes it :P
16:41 < dcousens> -minrelaytxfee=0.00000001
16:41 < cfields> BlueMatt: er, jump to pm?
16:42 < dcousens> remove that argf
16:42 < dcousens> everything works
16:42 < BlueMatt> cfields: ok
16:42 < dcousens> ping gmaxwell 
16:42 < gmaxwell> dcousens: sweet
16:43 < dcousens> and the lock order is compiled
16:43 < dcousens> want a full bt?
16:43 < gmaxwell> just run it.. is it spitting out any errors?
16:45 < dcousens> gmaxwell: no errors yet
16:45 < dcousens> nothing seen, would it be a hard crash or a debug log error?
16:45 < dcousens> in any case, neither
16:46 < gmaxwell> It logs with the normal logging process.
16:47 < dcousens> gmaxwell: for what its worth, you could probably check it out with just the above arg, a fresh compile off master causes that deadlock with that arg
16:47 < gmaxwell> yep. will be doing as soon as it compiles here.
16:47 < dcousens> like, fresh compile, fresh .bitcoin,  deadlocks on -minrelaytxfee=0.00000001
16:48 < gmaxwell> (takes like 15 minutes to comile bitcoin on my laptop)
16:48 < dcousens> haha, the joy
16:48 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has joined #bitcoin-core-dev     
16:48 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has quit [Changing host]     
16:48 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev     
16:49 < gmaxwell> (and all my other systems are busy with longer running expirements at the moment)
16:57 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Remote host closed the connection]     
17:01 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has joined #bitcoin-core-dev     
17:01 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has quit [Changing host]     
17:01 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev     
17:06 < gmaxwell> okay longer than 15 minutes.
17:09 < gmaxwell> dcousens: your misbehavior doesn't reproduce for me. :(
17:09 < dcousens> gmaxwell: :( - really?
17:09 < dcousens> Dumb question
17:10 < gmaxwell> dcousens: well it could require interaction with some other option, or some library/compiler version.
17:10 < dcousens> It definitely fixes my issue, I mean, all my nodes are back up haha
17:10 < dcousens> but, I'll retry local repro
17:14 < dcousens> rm -rf ~/.bitcoin, git clean -xdf, ./autogen.sh, ./configure --disable-bench --disable-tests --disable-wallet --without-miniupnpc, make -j4, ./src/bitcoind -minrelaytxfee=0.00000001 ---- that was my previous steps, I'm retrying them now
17:15 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
17:18 < dcousens> Otherwise, I guess I could maybe grab a list of some local package versions for you if you want, or try it out on a fresh ubuntu install
17:18 -!- TomMc [~tom@gateway/vpn/privateinternetaccess/tommc] has quit [Ping timeout: 246 seconds]     
17:18 < dcousens> but, I probably don't have that time atm :(
17:18 < dcousens> (for the fresh install etc)
17:18 < dcousens> gmaxwell: reproduced with the above commands
17:19 < gmaxwell> hm. disable wallet. I could try that.
17:19 < dcousens> commit 7d5d449
17:21 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
17:22 < dcousens> gmaxwell: interesting
17:22 < dcousens> -minrelaytxfee=0.1 does not deadlock
17:22 < dcousens> -minrelaytxfee=0.00000001 does
17:23 < dcousens> -minrelaytxfee=0.00000002 does not deadlock
17:23 < dcousens> lol     
17:24 < dcousens> for god sake, I reckon the binary just has it in for my configuration
17:25 < dcousens> rounding error I suppose?
17:26 < dcousens> Want me to bisect back to the source commit?
17:29 < gmaxwell> dcousens: would be useful, since only you can break it right now.
17:30 < dcousens> gmaxwell: must be platform related, since the hardware is completely different (EC2 instance, RPi, and my Laptop)
17:30 < dcousens> but they all run Arch
17:30 < dcousens> :P     
17:31 < dcousens> and yeah, only in the last... 1.5 weeks of dev, if that
17:32 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-jwrejxtznosozzqy] has quit [Quit: Connection closed for inactivity]     
17:36 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev     
17:42 < gmaxwell> dcousens: disable wallet didn't break it for me.
17:42 < dcousens> gmaxwell: awesome,  the fact this happens with me for both gcc+clang makes me think it must be some other dependency?
17:42 < dcousens> And cross-hardware
17:53 < dcousens> man, net_processing touches so many files haha
17:53 < dcousens> none the less, found the source of the bug so far, seems to be that static FeeFilterRounder
17:54 < dcousens> if I change that to a constant fee != 1, it doesnt deadlock
17:54 < dcousens> the investigation continues...
17:55 < sipa> dcousens: try with https://github.com/bitcoin/bitcoin/pull/9268/files
17:56 < dcousens> sipa: success
17:56 < dcousens> that fixes the issue
17:57 < sipa> dcousens: can you briefly comment on the PR?
17:57 < dcousens> sipa: did
17:57 < sipa> ah, i'm too late
17:58 < dcousens> gmaxwell: welp, should I investigate further into why it deadlocks for only me or?
18:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
18:00 < dcousens> I feel like this is probably a red-herring
18:01 < dcousens> Because nothing in that very small code block aludes to a deadlock issue, from what I can see
18:05 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has quit [Ping timeout: 268 seconds]     
18:10 < morcos> sipa: do you have any suspicion of what's going on?  that doesn't make much sense
18:10 < dcousens> morcos: not at this point, but, it repros quite solidly
18:10 < dcousens> -- on my machines, ha
18:13 < morcos> that first stack trace looks kind of crazy
18:14 < gmaxwell> I see the bug.
18:15 < dcousens> gmaxwell: oh?
18:15 -!- wasi0 [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
18:15 < gmaxwell> well one sec. might have spoke too soon.
18:15 < sipa> morcos: my guess would be something related to initialization order
18:15 < gmaxwell> yea, okay not what I thought.
18:15 < gmaxwell> FeeFilterRounder::FeeFilterRounder(const CFeeRate& minIncrementalFee)
18:15 < gmaxwell> { CAmount minFeeLimit = minIncrementalFee.GetFeePerK() / 2;
18:16 < gmaxwell> so his rate will go to zero there, and then I expect to find a loop immediately after it with that rate as an increment.
18:16 < gmaxwell> but it wasn't so. :)
18:16 < gmaxwell> oh wait, there it goes.
18:16 < dcousens> gmaxwell: still sounds plausible
18:16 -!- wasi0 [~wasi@gateway/tor-sasl/wasi] has quit [Client Quit]     
18:17 < gmaxwell>     for (double bucketBoundary = minFeeLimit; bucketBoundary <= MAX_FEERATE; bucketBoundary *= FEE_SPACING) {
18:17 -!- wasi0 [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
18:17 < gmaxwell> so there you go bucketBoundary = 0 ; bucketBoundary <= MAX_FEERATE; bucketBoundary *= FEE_SPACING.. infinite loop. 
18:17 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 245 seconds]     
18:17 < gmaxwell> though this doesn't explain why he's seeing it and I'm not.
18:18 < morcos> oops
18:18 < morcos> hmm     
18:18 < dcousens> gmaxwell: and now the fun starts haha
18:18 < morcos> that's backwrds then
18:18 < gmaxwell> oh perhaps some artifact of mempool saving, which I wasn't clearing?
18:19 < morcos> oh nm
18:19 < gmaxwell> hm. no we don't save the feerates.
18:19 < dcousens> gmaxwell: mine was loading mempools from previous builds
18:19 < dcousens> that wouldn't be it
18:19 < morcos> ok so right now it interprets the command line argument and 9268 makes it not
18:19 < morcos> ok     
18:19 < morcos> your explanation makes sense
18:19 < gmaxwell> right and apparently it used to not.  So the unexplained part is why is it not happening to everyone.
18:20 -!- wasi0 [~wasi@gateway/tor-sasl/wasi] has quit [Client Quit]     
18:20 < gmaxwell> dcousens: can you insert some instrumentation in that function to log the minFeeLimit before the loop and bucketBoundary inside the loop?
18:20 < gmaxwell> just to confirm its really infinitely looping there?
18:20 < dcousens> gmaxwell: sure
18:21 < dcousens> 304 or 490? 490 right
18:21 < dcousens> (line number0
18:21 < dcousens> )     
18:21 < morcos> yeah 490
18:22 < morcos> gmaxwell: yeah wait, why would it get rounded to 0
18:22 < morcos> oh, b/c its an integer number of satoshis?
18:23 < gmaxwell> 1/2 = 0  yes. CAmounts are integers. 
18:26 < dcousens> gmaxwell: thats the deadlock
18:26 < dcousens> bucketBou;w
18:26 < dcousens> ah, ignore that
18:27 < dcousens> anyway, yeah, that is the deadlock*, minFeeLimit == 0, bucketBoundary = 0.0000
18:27 < gmaxwell> dcousens: great, but now why you and not anyone else.
18:27  * gmaxwell checks my config.
18:28 < dcousens> gmaxwell: let me know if you need me to check anything,  have to return to a different task but happy to run anything
18:29 < gmaxwell> dcousens: thanks so much for all your help. I'm sure we've got it from here.
18:30 < morcos> dcousens: yes, thanks and sorry
18:31 < dcousens> morcos: all good, no need to be sorry, I run master for this exact reason :)
18:36 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
18:40 < morcos> gmaxwell: compiler isn't allowed to optimize that out is it?
18:41 < morcos> nm, stupid question, it can't get out of the loop...
18:41 < gmaxwell> morcos: if the compiler is able to prove a loop is infinite it can.
18:41 < gmaxwell> But it can't prove that loop is infinite, it depends on the argument.
18:41 < gmaxwell> but yea, actually you're probably right.
18:42 < gmaxwell> The loop uses floating point, god knows there is probably some way to rewrite that loop which is accurate except for 0.
18:42 < gmaxwell> but I've reproduced it.
18:42 < gmaxwell> so theres that.
18:42 < morcos> oh good
18:42 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 260 seconds]     
18:43 < gmaxwell> I yanked everything out of my configuration except txindex=1, and dcousens's setting.
18:43 < morcos> oh , so you sometimes don't get it still...  that is super weird
18:43 < gmaxwell> sipa: thoughts on merging https://github.com/bitcoin/bitcoin/pull/9268  to unbust master while the actual algorithim here gets fixed?
18:44 < gmaxwell> morcos: I think it might be a product of which peers I connect to.
18:44 < gmaxwell> e.g. doesn't get triggered until I send a fee filter.
18:44 < morcos> should we fix it by doing anything other than max(1,)
18:46 < gmaxwell> I don't see any reason to do anything but that. But thats not my code. :) I'd have to understand it to answer!
18:47 < morcos> yeah , i mean we could do something else entirely, its probably not the cleanest way to accomplish the goal, but i don't know that its worth doing anyting other than that, i'll pr
18:48 < gmaxwell> we could keep the behavior "this is what you get for setting you relayfee to 10 nanobitcoin and spamming other folks" :P
18:50 < morcos> Its an optimization itself, this is your nodes expected performance profile
18:52 < gmaxwell> "We've decided to save you the bandwidth and just give you a simulation of the expected cpu usage."
18:53 < bitcoin-git> [bitcoin] morcos opened pull request #9288: Fix a bug if the min fee is 0 for FeeFilterRounder (master...fixFFRbug) https://github.com/bitcoin/bitcoin/pull/9288
18:54 < morcos> How snarky would it be if that was just BlueMatt's way of pointing out the underlying bug
18:54 < gmaxwell> well true, that fact that your node is down makes you pretty distinguishable from other users.
18:55 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 248 seconds]     
18:57 < gmaxwell> I guess its good? news that we already had a PR open that would have covered this bug up...
18:57  * gmaxwell continues to curse configuration options for making software untestable.
19:02 < bitcoin-git> [bitcoin] theuni closed pull request #8631: Nuke boost::thread and boost::thread_group (master...no-interrupt-threads) https://github.com/bitcoin/bitcoin/pull/8631
19:02 < bitcoin-git> [bitcoin] theuni opened pull request #9289: net: drop boost::thread_group (master...connman-threads) https://github.com/bitcoin/bitcoin/pull/9289
19:05 < dcousens> gmaxwell: haha
19:05 < dcousens> good to know you repro'd it :)
19:05 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev     
19:06 < gmaxwell> really since the introduction of fee filter, low minrelay fees aren't so anti-social anymore at least.
19:07 < dcousens> gmaxwell: IMHO, all I really would want as policy is IsStandard, and a maximum in-memory size, sorted by fee descending (accounting for CPFP etc)
19:08 < dcousens> hence, the setting of 1 haha
19:10 < dcousens> gmaxwell: I wouldn't mind seeing double spends in the mempool too, but, I guess that would annoy too many people
19:11 < dcousens> and probably opens too many DOS vectors
19:14 < gmaxwell> well double spends in the mempool would break varrious assumptions in the code. :)
19:15 < gmaxwell> dcousens: thats not unreasonable since the advent of feefilter.
19:16 < dcousens> morcos: line 304 could probably be bounded too, just incase MIN_FEERATE was changed
19:41 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has joined #bitcoin-core-dev     
19:41 -!- abpa [~abpa@2602:306:b837:dbf0:7413:23eb:93f:5fe1] has joined #bitcoin-core-dev     
19:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
19:54 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]     
20:15 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.]     
21:15 -!- aalex [~aalex@64.187.177.58] has quit [Read error: Connection reset by peer]     
21:15 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
21:19 -!- owowo [ovovo@gateway/vpn/mullvad/x-pjjzrsyosvqkerfe] has quit [Ping timeout: 244 seconds]     
21:20 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 248 seconds]     
21:20 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
21:21 -!- owowo [ovovo@gateway/vpn/mullvad/x-fduzlgztlwgdgrhd] has joined #bitcoin-core-dev     
21:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]     
21:26 -!- owowo [ovovo@gateway/vpn/mullvad/x-fduzlgztlwgdgrhd] has quit [Ping timeout: 244 seconds]     
21:27 -!- owowo [ovovo@gateway/vpn/mullvad/x-eqvkpynznfxyeela] has joined #bitcoin-core-dev     
21:29 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Remote host closed the connection]     
21:30 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev     
21:42 -!- larrysalibra [~larry@058176109066.ctinets.com] has joined #bitcoin-core-dev     
22:02 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds]     
22:19 -!- larrysalibra [~larry@058176109066.ctinets.com] has quit [Quit: Textual IRC Client: www.textualapp.com]     
22:21 < wumpus> so did anyone compile bitcoin for risc-v yet? :)
22:23 -!- protomar [~protomar@91.214.169.69] has joined #bitcoin-core-dev     
22:45 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
22:46 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
22:49 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9290: Make RelayWalletTransaction attempt to AcceptToMemoryPool. (master...resend_retries_mempool) https://github.com/bitcoin/bitcoin/pull/9290
23:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
23:08 < bitcoin-git> [bitcoin] sipa opened pull request #9291: Remove mapOrphanTransactionsByPrev from DoS_tests (master...reallyoneorphan) https://github.com/bitcoin/bitcoin/pull/9291
23:09 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
23:10 < warren> wumpus: there's machines available for it?
23:11 < gmaxwell> Does anyone recall why we decided to not backport #9053 ? I was just thinking about maybe it should be backported, then saw it was tagged and untagged.
23:11 < gribble> https://github.com/bitcoin/bitcoin/issues/9053 | IBD using chainwork instead of height and not using header timestamps by gmaxwell · Pull Request #9053 · bitcoin/bitcoin · GitHub
23:11 < wumpus> warren: I just ordered a hifive board, but that's arduino-class, nothing that can handle bitcoind IIRC. There's a toolchain and qemu (also linux user) though so it'd be possible to compile and run it
23:11 < sipa> gmaxwell: i think we considered it for 0.13.1, but decided it wasn't important enough for that?
23:11 < wumpus> warren: maybe if you use a RiscV core on one of the high-end FPGAs
23:12 < gmaxwell> TD-Linux: was telling me recently he planned on having an actual RiscV chip soon... but not one that would be anywhere near powerful enough to run bitcoin core. :P
23:13 < wumpus> gmaxwell: yeah, if there's no discussion on the issue it probably means it was discussed in a meeting
23:13 < wumpus> nov 3's meeting I'd guess
23:14 < wumpus> gmaxwell: yep this one probably: https://www.sifive.com/products/hifive1/  ordered one as well
23:14 < jonasschnelli> <*highlight>	[18:40:09] <morcos:#bitcoin-core-dev> jonasschnelli: you around?
23:14 < jonasschnelli> Now. You?
23:14 < gmaxwell> 12:57 <@wumpus> I think personally I'd prefer to keep it for 0.14, so the new rule/logic can prove itself a while  
23:14 < jonasschnelli> ref: [18:40:09] <morcos:#bitcoin-core-dev> jonasschnelli: you around?
23:14 < gmaxwell> okay, yep. sorry, hamster brain here.
23:14 < wumpus> gmaxwell: well it has been a while in master now ...
23:15 < wumpus> gmaxwell: I think that was just last-minute before a release
23:16 < jonasschnelli> gmaxwell: I have a solution for the HD chain-split (95% complete). I think it could be backwards compatible. Means, if a 0.13 wallet will be loaded, only external (m/0'/0'/k) will be generated. Creating a new wallet will respect the 0'/|1'/ switch.
23:16 < jonasschnelli> https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2016/12/hd_split?expand=1
23:16 < gmaxwell> I don't have a really strong opinion, but I did just have a 0.13.1 testnet node act goofy today in a way that change fixes, so it came back to mind.
23:17 < jonasschnelli> Loading the 0.14 wallet in 0.13 will result in using only the external chain.. or we disable that.
23:17 < jonasschnelli> (probably better to disable)
23:17 < gmaxwell> jonasschnelli: but if you go back to an older version do funds silently disappear? or .. I guess we'll just not be backwards compatible? 
23:17 < wumpus> I do think we should only backport critical things, not things that 'would be nice' but are risky. Also if it *only* affected testnet it'd be a no-brainer.
23:17 < jonasschnelli> Once the keypool is filled, the keypath doesn't matter.
23:18 < jonasschnelli> I think we should probably disable loading 0.14 (hd splitI) wallets in 0.13. Becuase once you load them in 0.13, you take the risk of having chain outputs in the external chain.
23:18 < jonasschnelli> This can be confusing.
23:18 < wumpus> this also has an effect on mainnet, it'd be a pain if it introduced some regression, though that chance is lower than at Nov 3 which was two days after it was openened :)
23:19 < gmaxwell> wumpus: well it fixes bad behavior that is possible on mainnet too just really unlikely and not something we're currently observing.
23:19 < wumpus> it's been merged in master for more than a month and no one at least observed any wacky behavior due to it, so I'd trust it for backport now
23:22 < sipa> jonasschnelli: it's 2:22 am for morcos
23:22 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7d5d44969b4a...ed8d693c71b0
23:22 < bitcoin-git> bitcoin/master bc7ff8d Gregory Sanders: Add option to return non-segwit serialization via rpc
23:22 < bitcoin-git> bitcoin/master 412bab2 instagibbs: Adapt ZMQ/rest serialization to take rpcserialversion arg
23:22 < bitcoin-git> bitcoin/master ed8d693 Wladimir J. van der Laan: Merge #9194: Add option to return non-segwit serialization via rpc...
23:22 < bitcoin-git> [bitcoin] laanwj closed pull request #9194: 	Add option to return non-segwit serialization via rpc (master...nonswserialrpc) https://github.com/bitcoin/bitcoin/pull/9194
23:22 < wumpus> sipa: ugh, your comment on #9194 was just too late
23:22 < gribble> https://github.com/bitcoin/bitcoin/issues/9194 | Add option to return non-segwit serialization via rpc by instagibbs · Pull Request #9194 · bitcoin/bitcoin · GitHub
23:22 < sipa> wumpus: can easily be fixed later
23:23 < wumpus> had already hit enter then I saw it appear at the same time :p
23:23 < wumpus> yes luckily just a help message
23:23 -!- ClockCat [~CattieCat@75-109-228-219.stjocmtk01.res.dyn.suddenlink.net] has quit [Ping timeout: 250 seconds]     
23:23 < sipa> well the comment is more about showing an error when an unknown value is passed
23:24 < sipa> i'll PR my suggested change
23:25 < jonasschnelli> sipa: Oh. Yes.
23:25 -!- owowo [ovovo@gateway/vpn/mullvad/x-eqvkpynznfxyeela] has quit [Ping timeout: 244 seconds]     
23:27 < jonasschnelli> For the chain-split, what would be preferable, a keypool=100 results in 50 internal and 50 external keys or in 100/100?
23:28 < bitcoin-git> [bitcoin] sipa opened pull request #9292: Complain when unknown rpcserialversion is specified (master...nofutureserial) https://github.com/bitcoin/bitcoin/pull/9292
23:28 < sipa> jonasschnelli: internal keys need way fewer
23:28 < jonasschnelli> sipa: I guess its 2.30am you as well?
23:28 < sipa> jonasschnelli: no, i'm on the west coast, 23:28 here
23:28 < gmaxwell> no, the US is a big place.
23:28 < jonasschnelli> Ah. Right. He's NY.
23:28 < gmaxwell> US timezones span 7 hours IIRC. 
23:29 -!- owowo [ovovo@gateway/vpn/mullvad/x-jbiuuwqlgrfvarjv] has joined #bitcoin-core-dev     
23:29 < sipa> there's a tiny part of the US on the other side of the international date line
23:30 < jonasschnelli> sipa: But in general, should the keypool=<value> results in <value>=<internal>+<external> or <value>=<internalamout>, <value>=<externalamount>?
23:30 -!- murchandamus [~murchghos@ghostdub.de] has quit [Ping timeout: 244 seconds]     
23:30 < gmaxwell> yea, I wasn't counting guam.
23:30 < gmaxwell> in that case they span like 20 hours. :P
23:31 < sipa> gmaxwell: you don't need to count territories. there is a tiny part of alaska across the date line
23:32 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev     
23:32 < sipa> ah, but it still uses western time. ignore me
23:51 < sipa> https://github.com/bitcoin/bitcoin/pulse/monthly
23:51 < sipa> that's pretty cool
23:51 < sipa> Excluding merges, 33 authors have pushed 160 commits to master and 175 commits to all branches. On master, 288 files have changed and there have been 13,187 additions and 10,679 deletions. 
23:53 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
23:53 < wumpus> nice!
23:53 < wumpus> BlueMatt is clearly winning this month :)
23:54 < sipa> also the last week and the last 3 days
23:55 < sipa> but over a month... 112 PRs merged, and 50 PRs opened
23:55 < sipa> that's pretty good