--- Day changed Tue Dec 13 2016 00:17 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:30 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 00:34 -!- abpa [~abpa@2602:306:b837:dbf0:c4fd:4c1f:ab3:1735] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:32 -!- ryanofsky_ [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 250 seconds] 01:32 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds] 01:32 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds] 01:32 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 268 seconds] 01:33 -!- laurentmt [~Thunderbi@80.215.178.183] has joined #bitcoin-core-dev 01:34 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 01:34 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 01:34 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 01:34 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Changing host] 01:34 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 01:35 -!- laurentmt [~Thunderbi@80.215.178.183] has quit [Client Quit] 01:39 < bitcoin-git> [bitcoin] goku1997 opened pull request #9339: Revert segwit. Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9339 01:40 < rabidus_> :E 01:43 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9339: Revert segwit. Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9339 01:43 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 01:45 -!- ryanofsky_ [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 01:50 < luke-jr> sigh 01:58 -!- laurentmt [~Thunderbi@80.215.178.183] has joined #bitcoin-core-dev 02:00 < Lauda> You should listen ti maxwell's advice regarding that one. 02:08 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #9064: unify capitalization of "bitcoin address" (master...changeCaps) https://github.com/bitcoin/bitcoin/pull/9064 02:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/76fcd9d50341...e6ba5068f107 02:09 < bitcoin-git> bitcoin/master e49a252 Richard Kiss: Fix spelling. 02:09 < bitcoin-git> bitcoin/master e6ba506 MarcoFalke: Merge #9335: Fix typo in test/data/tx_valid.json... 02:09 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9335: Fix typo in test/data/tx_valid.json (master...feature/typo) https://github.com/bitcoin/bitcoin/pull/9335 02:18 -!- laurentmt [~Thunderbi@80.215.178.183] has quit [Quit: laurentmt] 02:27 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 02:29 -!- laurentmt [~Thunderbi@80.215.234.255] has joined #bitcoin-core-dev 02:33 < MarcoFalke> I think #9302 and #9290 are reviewed to death, ready for merge 02:33 < gribble> https://github.com/bitcoin/bitcoin/issues/9302 | Return txid even if ATMP fails for new transaction by sipa · Pull Request #9302 · bitcoin/bitcoin · GitHub 02:33 < gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub 02:36 < MarcoFalke> > wumpus 02:36 < MarcoFalke> can people please notify me if there is a pull which is clearly ready for merging? 02:38 -!- laurentmt [~Thunderbi@80.215.234.255] has quit [Quit: laurentmt] 02:44 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 02:48 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 02:50 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 246 seconds] 03:03 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 03:03 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 03:03 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:15 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6ba5068f107...b6abdc77d39c 03:15 < bitcoin-git> bitcoin/master b3a7410 Pieter Wuille: Return txid even if ATMP fails for new transaction 03:15 < bitcoin-git> bitcoin/master b6abdc7 Wladimir J. van der Laan: Merge #9302: Return txid even if ATMP fails for new transaction... 03:16 < bitcoin-git> [bitcoin] laanwj closed pull request #9302: Return txid even if ATMP fails for new transaction (master...failedtxid) https://github.com/bitcoin/bitcoin/pull/9302 03:17 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6abdc77d39c...cfd5e6b1dc32 03:17 < bitcoin-git> bitcoin/master 7b49f22 Pieter Wuille: Squashed 'src/secp256k1/' changes from 7a49cac..8225239... 03:17 < bitcoin-git> bitcoin/master 547a53d Pieter Wuille: Update libsecp256k1 to master 03:17 < bitcoin-git> bitcoin/master cfd5e6b Wladimir J. van der Laan: Merge #9334: Update to latest libsecp256k1... 03:17 < bitcoin-git> [bitcoin] laanwj closed pull request #9334: Update to latest libsecp256k1 (master...secp) https://github.com/bitcoin/bitcoin/pull/9334 03:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cfd5e6b1dc32...5233aefa3f52 03:21 < bitcoin-git> bitcoin/master 8c1dbc5 Karl-Johan Alm: Refactor: Removed begin/end_ptr functions. 03:21 < bitcoin-git> bitcoin/master 5233aef Wladimir J. van der Laan: Merge #9305: Refactor: Removed begin/end_ptr functions.... 03:21 < bitcoin-git> [bitcoin] laanwj closed pull request #9305: Refactor: Removed begin/end_ptr functions. (master...remove-begin-end_ptr-usage) https://github.com/bitcoin/bitcoin/pull/9305 03:22 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5233aefa3f52...26fe5c98ab6a 03:22 < bitcoin-git> bitcoin/master bae1eef Gregory Maxwell: Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API.... 03:22 < bitcoin-git> bitcoin/master b05b1af Gregory Maxwell: Fix qt/paymentrequestplus.cpp for OpenSSL 1.1 API.... 03:22 < bitcoin-git> bitcoin/master 26fe5c9 Wladimir J. van der Laan: Merge #9326: Update for OpenSSL 1.1 API.... 03:23 < bitcoin-git> [bitcoin] laanwj closed pull request #9326: Update for OpenSSL 1.1 API. (master...openssl_api11) https://github.com/bitcoin/bitcoin/pull/9326 03:25 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 260 seconds] 03:33 -!- MarcoFalke [~marco@host232-2.natpool.mwn.de] has joined #bitcoin-core-dev 03:34 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 03:34 < MarcoFalke> I am going to create a pull for the subtree update on 0.13, because it is not possible to jsut backport 03:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9340: [0.13] Update secp256k1 subtree (0.13...Mf1612-013subtree) https://github.com/bitcoin/bitcoin/pull/9340 03:46 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 03:50 -!- MarcoFalke [~marco@host232-2.natpool.mwn.de] has left #bitcoin-core-dev [] 04:00 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 258 seconds] 04:07 -!- laurentmt [~Thunderbi@80.215.234.255] has joined #bitcoin-core-dev 04:08 -!- laurentmt [~Thunderbi@80.215.234.255] has quit [Client Quit] 04:24 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 04:32 -!- chris200_ [~chris2000@p5DCB5736.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:44 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 258 seconds] 04:58 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 05:08 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-qiamnxvpqmwdkehg] has quit [Quit: Connection closed for inactivity] 05:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:10 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 264 seconds] 05:16 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 245 seconds] 05:24 -!- goregrind [~goregrind@unaffiliated/goregrind] has quit [Ping timeout: 240 seconds] 05:28 -!- goregrind [~goregrind@unaffiliated/goregrind] has joined #bitcoin-core-dev 05:49 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has quit [Ping timeout: 246 seconds] 05:53 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has joined #bitcoin-core-dev 05:54 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 05:57 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 245 seconds] 06:02 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 06:04 < jonasschnelli> luke-jr: the question is, if we really want to support commands like cmd(arg,,) resulting in `cmd arg "" ""` 06:04 < jonasschnelli> IMO the later is fine... but not sure about cmd(arg,,) 06:05 < jonasschnelli> Empty arguments in a bracket-like syntax looks strange to me. 06:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 06:07 -!- protomar [~protomar@91.214.169.69] has joined #bitcoin-core-dev 06:07 < luke-jr> jonasschnelli: IMO either it should be supported, or an error ;) 06:07 < jonasschnelli> luke-jr: Yes. Agree. IMO it should thrown an error... I'll fix that. 06:12 -!- laurentmt [~Thunderbi@80.215.234.255] has joined #bitcoin-core-dev 06:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:44 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 06:44 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 06:48 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev 06:50 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 06:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:56 < phantomcircuit> jonasschnelli, is this for nested calls? 07:23 -!- JackH [~laptop@79-73-185-145.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 07:24 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:45 < jtimon> sorry, can't access github now, but rebased https://github.com/bitcoin/bitcoin/pull/9279 and the windows builds keep failing in a way I cannot understand or reproduce, it says "int64_t does not name a type". Any help welcomed 07:59 -!- abpa [~abpa@2602:306:b837:dbf0:14af:1c50:710e:ed75] has joined #bitcoin-core-dev 08:00 -!- abpa [~abpa@2602:306:b837:dbf0:14af:1c50:710e:ed75] has quit [Client Quit] 08:03 < bitcoin-git> [bitcoin] richardkiss opened pull request #9342: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9342 08:30 < ryanofsky_> jtimon: maybe it needs an #include 08:32 < jtimon> ryanofsky_: it has an #include but it may be just that, thanks, I'll try that 08:34 -!- laurentmt [~Thunderbi@80.215.234.255] has quit [Read error: Connection reset by peer] 08:35 -!- laurentmt [~Thunderbi@80.215.234.255] has joined #bitcoin-core-dev 08:37 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yodmonhptjwiatto] has quit [Quit: Connection closed for inactivity] 08:45 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-yjrlycrvmqiwoflh] has joined #bitcoin-core-dev 08:49 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bvawpccyzsmvklfg] has joined #bitcoin-core-dev 09:25 -!- protomar [~protomar@91.214.169.69] has quit [Quit: Leaving] 09:26 -!- laurentmt [~Thunderbi@80.215.234.255] has quit [Quit: laurentmt] 09:46 -!- laurentmt [~Thunderbi@80.215.234.255] has joined #bitcoin-core-dev 09:47 -!- laurentmt [~Thunderbi@80.215.234.255] has quit [Client Quit] 09:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 10:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:08 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye] 10:09 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 10:13 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:25 -!- aalex_ [~aalex@64.187.177.58] has quit [Read error: Connection reset by peer] 10:53 < gmaxwell> wumpus: thanks for the merges! 11:03 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 11:17 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 256 seconds] 11:24 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Ping timeout: 258 seconds] 11:26 < morcos> I'm working on a PR to properly distinguish all the different uses of minRelayTxFee. It is my opinion that the dust threshold should not be arbitrarily changed by a desire to increase your minimum relay fee. Changing the definition of dust has a negative effect on the network by causing some txs to be non-standard, and potentially get stuck in your mempool. 11:26 < sipa> morcos: i'm working on a per-txout chainstate... this simplifies so much 11:27 < morcos> My question is, does it makes sense to be able to control the dust limit with a command line option... Or do we think it's only something that needs a hard-coded constant, that could be changed in a future release if we've had several releases that already use a higher value for tx creation 11:27 < morcos> sipa: ah, i had some ideas about maybe how to do that.. i'll be curious to see what you come up with! i agree. it'll be good 11:27 < sipa> morcos: doing it a very naive way, hoping that leveldb properly deduplicates the txids 11:28 < morcos> won't take long to figure that out.. ha 11:28 < sipa> but no need for CCoinsModifier etc anymore... just an AddCoins and SpendCoins function, which never need to call GetCoins on the lower-level, just HaveCoins to know whether to mark something as fresh 11:29 < gmaxwell> morcos: I think our practice has been to make things configurable, so thats what you should probably do. (though I think this is often a mistake and it's not really here) 11:30 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 11:30 < sipa> morcos: regarding dust... it's my opinion that a rational wallet should never create dust outputs by such a wide margin that the actual value of the dust threshold does not matter 11:30 < morcos> ok already adding -incrementalrelayfee and -blockmintxfee , was hoping to avoid so many new command line options that wumpus reached through my screen to choke me 11:30 < gmaxwell> (it's not really needed here, loast a word) 11:30 < gmaxwell> sipa: you could put down the eng work on that for a moment, and make a quick change to adjust how the records work in leveldb. to see if it's a non-starter. 11:31 < morcos> sipa: yes, thats goign to be among the changes i make.. we actually do an OK job of that now because of MIN_CHANGE, but we still have soem safety checks against IsDust which should be against a higher limit I think... 11:32 < morcos> Unfortunately.. you can't put too much of a safety margin, otherwise you start having non-trivial amounts , which is espeically a problem when you are subtracting fees from recipients.. (where if your change would have been dust, then you take more money from the recipients to make your change higher!) 11:41 -!- jtimon [~quassel@77.224.94.35] has quit [Read error: Connection reset by peer] 11:41 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 11:41 < morcos> sipa: so aside from change, it makes sense for our wallet to refuse to pay someone an amount between dust and safetyMargin*dust as well? 11:45 < sipa> morcos: i don't know about outputs... but for change, we shouldn't make anything between changeOutputWeight * effectiveRelayFee 11:45 < sipa> s/between/below/ 11:47 < morcos> sipa: my idea is that what is important is that the txs your wallet creates will likely be considered standard for sometime 11:48 < morcos> so minChange takes care of making a best-efforts basis to not produce anything uneconomical 11:48 < morcos> but it would makes sense to have some dustCreationTheshold = SafetyMargin * dustThreshold 11:48 < morcos> that applies to everything... 11:49 < morcos> then if ever need to change dustThreshold.. we're not causing old wallets to create unrelayable/unminable txs by accident 11:54 -!- shesek [~shesek@bzq-84-110-53-9.cablep.bezeqint.net] has quit [Ping timeout: 258 seconds] 11:59 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 12:05 -!- jtimon [~quassel@77.224.94.35] has quit [Read error: Connection reset by peer] 12:06 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 12:14 < morcos> Can we add one of those checkboxes that lets bitcoin-qt send back diagnostics to us about how it's actually used so we can improve it? :) 12:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 12:31 < jtimon> btw ryanofsky_ thanks was that 12:35 < jtimon> morcos: mhmm, of -incrementalrelayfee and -blockmintxfee which one is the one for the dust? I assume the second, what about calling it -dusttxfee ? 12:36 < morcos> jtimon: ha. neither! thats why i was hoping to avoid a third. 12:36 < jtimon> oh, mhmm, I lack the context on why you need 2 already 12:37 < morcos> will explain in the PR 12:37 < gmaxwell> morcos: be sure to include private keys. 12:37 < jtimon> sure, no hurry 12:37 -!- jtimon [~quassel@77.224.94.35] has quit [Read error: Connection reset by peer] 12:37 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 12:37 < gmaxwell> morcos: so long as what the wallet targets and what the network enforces are seperate settings, then we don't have any problem with changing it in the future... (wallet must be changed amply ahead of the network, if the network will become more restrictive) 12:38 < gmaxwell> I hope there is no reason to make the network more restrictive of dust in the future. 12:40 < paveljanik> gmaxwell, ;-) I expect it will be rbtced in 5, 4, 3, ... ;-) 12:40 < jtimon> btw, morcos, your change to the dust variable will probably less painful after https://github.com/bitcoin/bitcoin/pull/9279/commits/59ed6874612a0c4c410fc6016c21cdde68c42601 12:45 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 12:55 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Ping timeout: 258 seconds] 12:59 < morcos> jtimon: yes, certainly don't object to moving it out of consensus, but I think it's actually useful that you can pass in a feerate to use. For instance what we were talkign about with gmaxwell , you might want to use a higher threshold for creation than the policy dust limit. 13:02 < jtimon> mhmm, I hadn't though about that, maybe a reason to modify #9279 ... 13:02 < gribble> https://github.com/bitcoin/bitcoin/issues/9279 | Consensus: Move CFeeRate out of libconsensus by jtimon · Pull Request #9279 · bitcoin/bitcoin · GitHub 13:03 < jtimon> I was hoping to encapsulate the variable behind a policy class at some point... 13:06 < jtimon> I guess another option would be to have 2 functions/methods that call the same one internally 13:10 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 13:12 < morcos> jtimon: yeah i think that would be fine and an easy change: GDT(txout) { return GDT(txout, ::minRelayTxFee); } 13:13 < jtimon> I mean, if we plan to encapsulate the value later that's 2 rounds of disruption instead of one 13:13 < morcos> and could even just make that change later if you don't want to now.. maybe i will wait on my dust change until yours get merged, but i'd really like to have dust stop changing every time you change the minrelaytxfee 13:14 < jtimon> I mean, didn't mean to stop you 13:15 < morcos> well i like your change.. and i have to potentially change all the IsDust call sites too, so no reason to do it multiple times. I think the change you made to them makes sense, and then maybe some of them will later take an optional feerate argument if we want to use a higher dust creation threshold 13:16 < jtimon> my point about was we could have policy.IsDust(txOut) and policy.IsDustCreate(txOut) if we want ot have 2 dust rates, but I'm not sure I understand the purpose of the create one 13:17 < jtimon> or that 13:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:17 < jtimon> optionally taking another one if we maybe want to have more than 2 rates 13:18 < gmaxwell> jtimon: any time there is a limit on relay behavior there really should be two limits-- one used for relay and one equal or more conservative one for the wallet. 13:18 < gmaxwell> Otherwise it is impossible to change the limit without causing the creation of limit violating transactions. 13:19 < jtimon> I see 13:38 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 13:38 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 13:42 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 13:43 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 13:48 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 13:49 < bitcoin-git> [bitcoin] morcos opened pull request #9343: Don't create change at dust limit (master...noneconomicchange) https://github.com/bitcoin/bitcoin/pull/9343 13:51 < morcos> gmaxwell: ^ just a first step to avoid having to deal with a complicated edge case... but maybe it won't be acceptable to people. it seems odd to me that this would be a case that is hit very often, as i expect subtractFeeFromAmount is used when you want to send whole balances or coins. 13:51 < morcos> but i admit i don't know how its used.... 14:29 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has joined #bitcoin-core-dev 14:47 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 15:30 -!- JackH [~laptop@79-73-185-145.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 16:04 -!- chris__ [2f14ff56@gateway/web/freenode/ip.47.20.255.86] has joined #bitcoin-core-dev 16:13 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 16:15 -!- jtimon [~quassel@77.224.94.35] has quit [Remote host closed the connection] 16:18 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 245 seconds] 16:24 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 17:04 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:34 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 17:34 < gmaxwell> jonasschnelli: want to go comment on http://bitcoin.stackexchange.com/questions/50125/failing-to-build-bitcoin-core-v0-13-1-on-debian-stretch and point out its fixed in master? 17:36 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has quit [Ping timeout: 240 seconds] 17:37 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has joined #bitcoin-core-dev 17:38 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has quit [Remote host closed the connection] 17:51 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9344: Do not run functions with necessary side-effects in assert() (master...assert_no_sideeffects) https://github.com/bitcoin/bitcoin/pull/9344 17:53 < BlueMatt> again? :( 17:53 < gmaxwell> looks like we missed some. 17:54 < sipa> or 2. 17:54 < gmaxwell> or 4. 17:54 < BlueMatt> missed, or re-added? 17:54 < gmaxwell> the flush ones are from 2013, didn't check the others. 17:54 < gmaxwell> looking 17:56 < gmaxwell> BlueMatt: the other two you introduced in 9c837d54. 17:57 < gmaxwell> You have have the brownpaper bag when 2013-sipa is done with it. 17:57 < BlueMatt> lol, oops 17:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bvawpccyzsmvklfg] has quit [Quit: Connection closed for inactivity] 17:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 17:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:14 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:15 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 18:46 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 18:49 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 18:49 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev 18:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 18:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:07 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Remote host closed the connection] 19:27 -!- abpa [~abpa@2602:306:b837:dbf0:c11e:fa6f:3ff7:a193] has joined #bitcoin-core-dev 19:27 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has quit [Ping timeout: 245 seconds] 19:44 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 19:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:54 -!- NielsvG [~Necrathex@2001:982:aa8:1:76d4:35ff:fe12:58d6] has joined #bitcoin-core-dev 19:54 -!- NielsvG [~Necrathex@2001:982:aa8:1:76d4:35ff:fe12:58d6] has quit [Changing host] 19:54 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has joined #bitcoin-core-dev 19:55 -!- abpa [~abpa@2602:306:b837:dbf0:c11e:fa6f:3ff7:a193] has quit [Ping timeout: 258 seconds] 20:06 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 20:08 * luke-jr wonders if it would be useful to have a prune-to-slow-storage mode. 20:15 < adam3us> djb has a database called cdb (used in djbdns) that guarantees key->value lookup in 2 disk hits. cost is it is slow to update (batch job) 20:15 < luke-jr> I just mean for block data. Instead of deleting, move it to a USB drive or smth 20:15 < luke-jr> maybe even a location that can be offline when you don't need it 20:16 < luke-jr> so when you want to restore an old backup or whatever, you just plug it in 20:17 < adam3us> yes. i am talking about something only semi-related. that utxo access latency (with sig checking disabled) is increasing due to less spam creating lower cache hit rates, and larger utxo hitting disk more. 20:18 < adam3us> so then maybe a three tier strategy could be old stuff in cdb, more recent (eg last 2months?) in current disk layout, plus memory cache. once per month do the batch to move another 1month chunk to the cdb compact/efficient lookup format. 20:18 < adam3us> cdb has constant time lookup, where general lookup is log n. 20:34 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 245 seconds] 20:35 -!- GAit [~GAit@unaffiliated/gait] has quit [Ping timeout: 250 seconds] 20:35 -!- chris2000 [~chris2000@p5082ADE7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:36 < Lightsword> are there any known issues getting master to compile on the latest osx? 20:38 -!- chris200_ [~chris2000@p5DCB5736.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 20:43 -!- GAit [~GAit@unaffiliated/gait] has joined #bitcoin-core-dev 20:44 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 20:47 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has joined #bitcoin-core-dev 20:47 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has quit [Changing host] 20:47 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 20:52 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 268 seconds] 20:53 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 20:55 < Lightsword> nvm was protobuf version issue 21:08 < luke-jr> why is secp256k1.c +x now? 21:08 < luke-jr> main_impl.h also 21:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 21:54 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 245 seconds] 21:55 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 22:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:11 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 22:27 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:38 < phantomcircuit> instagibbs, are wallet transactions loaded into the mempool on restart? 22:38 < phantomcircuit> i didn't think they were 22:38 < phantomcircuit> wouldn't that break #9262 22:38 < gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub 22:38 < gmaxwell> phantomcircuit: yes, they are. 22:38 < phantomcircuit> gmaxwell, hmm 22:39 < gmaxwell> (assuming the mempool would take them). 22:39 < gmaxwell> they do you say it would break 9262? 22:39 < phantomcircuit> they're not rebroadcast though right? 22:39 < gmaxwell> they're rebroadcast if they get into the mempool. 22:39 < phantomcircuit> if they're not in the mempool then checking their ancestor depth will always fail of course 22:40 < gmaxwell> Yea, I see what you're saying-- they're put into the mempool. (and IIRC the wallet will not try to spend them if they're unconfirmed and not in the mempool) 22:40 < phantomcircuit> hmm 22:40 < gmaxwell> (but I could be wrong there and instead remembering the behavior it should have instead of does have... :) ) 22:50 -!- aalex [~aalex@64.187.177.58] has quit [Read error: Connection reset by peer] 22:50 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 22:51 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 245 seconds] 22:58 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 23:00 -!- dermoth [~thomas@dsl-66-36-158-238.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:01 -!- dermoth [~thomas@dsl-66-36-158-238.mtl.aei.ca] has joined #bitcoin-core-dev 23:05 -!- chris__ [2f14ff56@gateway/web/freenode/ip.47.20.255.86] has quit [Ping timeout: 260 seconds] 23:11 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 23:20 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 23:20 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 23:20 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 23:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 23:53 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:53 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 252 seconds]