--- Day changed Sat Jan 14 2017
00:02 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
00:03 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
00:03 -!- veleiro [~veleiro@fsf/member/veleiro] has quit [Remote host closed the connection]     
00:08 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 245 seconds]     
00:10 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
00:11 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xopygmmlmhwnapzh] has joined #bitcoin-core-dev     
00:38 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
00:53 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]     
01:17 < bitcoin-git> [bitcoin] jamesmacwhite opened pull request #9552: Add IPv6 support to qos.sh (master...qos-ipv6) https://github.com/bitcoin/bitcoin/pull/9552
01:27 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
01:32 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
01:32 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
01:35 -!- [Author] [~Author]@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev     
01:41 -!- jerryco [7d85e579@gateway/web/freenode/ip.125.133.229.121] has joined #bitcoin-core-dev     
01:41 < jerryco> hello
01:41 < jerryco> how to install bitcoin-core centos ?
01:43 < bitcoin-git> [bitcoin] practicalswift opened pull request #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; (master...std-max) https://github.com/bitcoin/bitcoin/pull/9553
01:52 < MarcoFalke> jerryco: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions-fedora
01:55 -!- jerryco [7d85e579@gateway/web/freenode/ip.125.133.229.121] has quit [Quit: Page closed]     
02:11 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
02:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e126d0c12ca6...8daf103fa138
02:25 < bitcoin-git> bitcoin/master 988d300 practicalswift: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)
02:25 < bitcoin-git> bitcoin/master 8daf103 MarcoFalke: Merge #9528: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)...
02:26 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9528: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64) (master...rename-formateNiceTimeOffset) https://github.com/bitcoin/bitcoin/pull/9528
02:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8daf103fa138...23281a4dc3af
02:31 < bitcoin-git> bitcoin/master b348287 Alex Morcos: Clarify that prioritisetransaction remains supported
02:31 < bitcoin-git> bitcoin/master 34ede12 Alex Morcos: Document fee estimation changes
02:31 < bitcoin-git> bitcoin/master 23281a4 MarcoFalke: Merge #9531: Release notes for estimation changes...
02:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9531: Release notes for estimation changes  (master...relnotes) https://github.com/bitcoin/bitcoin/pull/9531
03:10 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
03:31 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]     
03:55 -!- chjj [~chjj@c-50-152-196-52.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
04:06 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has joined #bitcoin-core-dev     
04:06 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has quit [Changing host]     
04:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:49 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
04:54 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
04:56 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
05:47 -!- Saucery [Saucery@c110-20-8-231.rivrw8.nsw.optusnet.com.au] has joined #bitcoin-core-dev     
06:02 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
06:29 -!- Saucery [Saucery@c110-20-8-231.rivrw8.nsw.optusnet.com.au] has quit []     
06:30 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
06:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
06:34 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
06:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:00 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 240 seconds]     
07:16 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
07:18 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
07:28 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
07:33 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 255 seconds]     
08:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]     
08:07 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
08:08 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
08:11 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
08:12 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
08:22 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
08:29 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
08:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
09:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]     
09:15 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
09:23 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
09:34 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
09:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
09:44 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
10:22 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
10:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]     
10:25 -!- justan0theruser is now known as justanotheruser     
10:29 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
10:51 < sipa> cfields: -fsanitize=thread "runs" with LDFLAGS="-no-pie"
10:52 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
10:52 < luke-jr> sipa: only with newer compilers.. neither Gentoo-stable compiler supports sanitize=thread without PIE
10:53 < luke-jr> and with PIE requires either a newer LLVM or older kernel
10:53 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
10:53 < luke-jr> (neither of which are available on Travis)
10:54 < luke-jr> the LLVM fix backports only so far as 3.8 FWIW (porting to 3.7 seemed difficult, at least)
10:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]     
10:54 < sipa> luke-jr: using gcc 6.2
10:55 < luke-jr> ok, just pointing out that isn't a reasonable min requirement ;)
10:55  * luke-jr peers at Gentoo have 6.3 masked, but no other 6.x at all
10:55 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
11:14 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev     
11:20 < bitcoin-git> [bitcoin] practicalswift opened pull request #9554: [test] Avoid potential NULL pointer dereference in addrman_tests.cpp (master...avoid-null-pointer-dereference-in-addrman_tests) https://github.com/bitcoin/bitcoin/pull/9554
11:24 -!- Netmage [~Netmage@p5B0A4FC6.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
11:39 -!- Cheeseo [~x@208.167.254.218] has joined #bitcoin-core-dev     
11:39 -!- Cheeseo [~x@208.167.254.218] has quit [Changing host]     
11:39 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
11:45 < bitcoin-git> [bitcoin] practicalswift opened pull request #9555: [test] Avoid triggering undefined behaviour in tx_invalid-test (transaction_tests.cpp) (master...avoid-ub-in-tx_invalid-test) https://github.com/bitcoin/bitcoin/pull/9555
11:52 < Netmage> Hi, I use bitcoint-qt. The size of the block chain is overall 113 GB large. Is this a normal value for the current block chain ?
11:52 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
11:53 < btcdrak> Netmage: sadly yes.
11:54 < Netmage> ok, is there a good way to decrease the size ?
11:55 < Netmage> Without having problems afterwards
11:55 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye]     
11:57 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
11:57 < BlueMatt> yes, luke-jr, Netcraft confirmed: gentoo is dead
11:57 < BlueMatt> Netmage: look at the docs for the -prune option
11:57 < luke-jr> Netmage: depends on if you need to restore old wallet backups etc
11:58 < BlueMatt> luke-jr: ok, sooooo utack for #9499?
11:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub
12:00 < luke-jr> BlueMatt: I did not complete review of all the code; I'm not sure it's worth doing as-is, but I don't object to it.
12:01 < BlueMatt> huh? folks have reported on the order of 10% fewer rtts!
12:01 < BlueMatt> how is that not worth doing?
12:01 < BlueMatt> (or more)
12:02 < luke-jr> it just seemed like a lot of complexity for what appeared to be random caching; maybe I'm wrong
12:02 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 252 seconds]     
12:02 < luke-jr> maybe in practice it happens to work out to be very effective
12:02 < BlueMatt> most of that pr's "complexity" is copying one block of code.....
12:02 < luke-jr> I did review that block
12:03 < BlueMatt> but, yes, three independant benchmarks posted on the pr suggested its a huge win
12:03 < luke-jr> ok, maybe it is! I'm not objecting
12:04 < luke-jr> if my review matters for the merge, I can go back and finish it
12:05 < BlueMatt> all reviews matter
12:05 < BlueMatt> :)     
12:05 < luke-jr> maybe I should be doing this one commit-by-commit
12:05 < BlueMatt> yes     
12:05 < BlueMatt> that tends to make most reviews easier :p
12:12 < luke-jr> I'd be a lot more comfortable that there isn't an implicit mask in rebasing code, if plTxnReplaced were at the end of the function signature
12:12 < luke-jr> s/mask/cast/
12:14 < BlueMatt> I believe gcc would complain in any way you fuck that up?
12:14 < luke-jr> checking..
12:14 < BlueMatt> it should complain if you try to pass a bool into that pointer?
12:15 < BlueMatt> i suppose unless, for some reason, you want to fOverrideMempoolLimit based on whether not a std::vector<CTransactionRef>* is non-null
12:15 < BlueMatt> but......
12:16 < luke-jr> yeah, probably safe
12:23 < luke-jr> BlueMatt: c73554042886fb63fb48edf29cf827951edde341 needs a #include "netprocessing.h" in init.cpp I think
12:24 < BlueMatt> init has an include net_processing?
12:28 < luke-jr> right, nm
12:29 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
12:36 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
12:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []     
12:47 < BlueMatt> cfields: is there a reason CConnman::ForNode calls the provided function with cs_vNodes still locked? that seems bad?
12:47 < bitcoin-git> [bitcoin] practicalswift opened pull request #9556: Remove redundant semicolons (master...remove-redundant-braces) https://github.com/bitcoin/bitcoin/pull/9556
12:55 < Chris_Stewart_5> If anyone is interested in #8469 and wants to get some internet points on SO: http://stackoverflow.com/questions/41539334/including-header-file-in-cpp-causes-nasty-error
12:55 < gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
13:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
13:16 < bitcoin-git> [bitcoin] practicalswift opened pull request #9557: Use static_cast<new_type>(...) instead of deprecated new_type(...) (functional cast) (master...avoid-functional-cast-expression) https://github.com/bitcoin/bitcoin/pull/9557
13:25 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds]     
13:33 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
13:42 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
13:42 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9558: Clarify assumptions made about when BlockCheck is called (master...2017-01-blockcheckeddocs) https://github.com/bitcoin/bitcoin/pull/9558
13:48 -!- Cheeseo [~x@c-174-59-204-158.hsd1.pa.comcast.net] has joined #bitcoin-core-dev     
13:48 -!- Cheeseo [~x@c-174-59-204-158.hsd1.pa.comcast.net] has quit [Changing host]     
13:48 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
14:08 < bitcoin-git> [bitcoin] 2HCHO closed pull request #9551: disable out of sync warnings for regtest network (master...ca4b90519c3c210f) https://github.com/bitcoin/bitcoin/pull/9551
14:20 -!- Saucery [31c3bdf0@gateway/web/freenode/ip.49.195.189.240] has joined #bitcoin-core-dev     
14:21 -!- Saucery [31c3bdf0@gateway/web/freenode/ip.49.195.189.240] has quit [Client Quit]     
14:22 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Ping timeout: 245 seconds]     
14:23 < bitcoin-git> [bitcoin] practicalswift opened pull request #9559: [net] Avoid possibility of NULL pointer dereference in ProcessMessage(...) (master...avoid-null-pointer-deref-in-processmessage) https://github.com/bitcoin/bitcoin/pull/9559
14:38 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
14:46 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
15:03 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
15:04 < bitcoin-git> [bitcoin] practicalswift opened pull request #9560: [rpc] Avoid possibility of NULL pointer dereference in getblocktemplate(...) (master...avoid-null-pointer-dereference-in-rpc-blockchain) https://github.com/bitcoin/bitcoin/pull/9560
15:04 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
15:09 -!- waxwing [~waxwing@110-170-176-164.static.asianet.co.th] has quit [Quit: Leaving]     
15:37 < BlueMatt> man practicalswift needs to calm down a bit with this....bad timing, yo
15:42 < sipa> release's on fire, yo
15:43 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
15:43 < BlueMatt> yea, as in a bunch of stuff is cruisin' to miss :(
15:43 < BlueMatt> sipa: how's mystery hung going?
15:43 < BlueMatt> t     
15:47 < sipa> BlueMatt: first team finished at 4am this morning, shortest hunt ever
15:47 < sipa> BlueMatt: our team finished early afternoon today
15:48 < BlueMatt> oh shit, wow
15:49 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
15:51 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9561: Wake message handling thread when we receive a new block (master...2017-01-wakeup-on-new-block) https://github.com/bitcoin/bitcoin/pull/9561
15:53 < BlueMatt> ^ one-line change provides 100ms improvement in block-relay latency for non-compact-block peers :p
15:58 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
16:05 < sipa> BlueMatt: probably less.. even 50ms on average, but if it happens while any other peer sends us anything, it's less also
16:05 < sipa> anyway... very simple change
16:07 < BlueMatt> sipa: yea, see comment on pr, its probably close to min(closest peer RTT, 100ms)
16:08 < BlueMatt> note that if another peer sends you a message during validation it may not be enough to get the loop to do a full go-around
16:09 < BlueMatt> oh, actually take that back, i suppose it is
16:09 < BlueMatt> anyway, whatever, its a super trivial change that will make a difference sometimes
16:09 < BlueMatt> IIRC morcos said something about having been testing +/- that change for a while, and i realized its not pr'ed anywhere
16:11 < BlueMatt> ofc we should, later, remove that and move the whole block-announce logic from SendMessages into the UpdatedBlockTip callback
16:11 < BlueMatt> but....for later
16:17 < morcos> BlueMatt: ha, thats exactly the same as what i did except my commits were in the opposite order.  :)
16:17 < BlueMatt> morcos: well github is sorting them in the wrong order :p
16:18 < morcos> no i know.. my point was i didn't realize i needed to make it public
16:18 < BlueMatt> oh, neither did I
16:18 < BlueMatt> thats why github is displaying them as "wake" then "make public"
16:18 < BlueMatt> :p     
16:18 < morcos> oh ha, and thats why they are sorted in that order
16:19 < morcos> what are you worried about missing 0.14
16:19 < BlueMatt> yea, date-based
16:19 < morcos> i thought we were doing pretty good
16:19 < morcos> i mean there are some bugs that still need fixing
16:19 < morcos> i mean maybe bumpfee will miss it i guess.  but i won't cry...
16:20 < BlueMatt> I'm not confident in the hd split one, and still feel like I need to do more review on bumpfee
16:20 < BlueMatt> yea, I'm concerned about bumpfee and hd split
16:20 < morcos> oh yeah..  the split one .. htat might be bad.. i keep thinking i'm going to review that, and then when i realize i have to read a BIP first i stop
16:21 < BlueMatt> heh, i skipped the concept ack stage...figure sipa will tell us if its the wrong way to do it :p
16:21 < BlueMatt> but I think I found some bugs in the implementation yesterday, so waiting on jonasschnelli to reappear :/
16:22 < sipa> i still haven't looked at the split :(
16:46 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
16:51 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev     
16:53 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
17:18 -!- Netmage [~Netmage@p5B0A4FC6.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]     
17:19 -!- Netmage [~Netmage@p5B0A5B39.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
17:27 < achow101> have we figured out what's wrong with mingw on ubuntu 16.04?
17:30 < BlueMatt> i thought i remembered wumpus saying something which sounded like he had debugged it back to a patch ubuntu applied to their gcc
17:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xopygmmlmhwnapzh] has quit [Quit: Connection closed for inactivity]     
17:49 -!- PRab_ [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev     
17:50 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
17:51 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Ping timeout: 240 seconds]     
17:51 -!- PRab_ is now known as PRab     
17:58 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
18:02 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
18:31 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
18:36 < gmaxwell> I really wish someone would encourage him to ditch the inflamitory titles.
18:37 < sipa> ?     
18:37 < gmaxwell> so far the ones I've looked at were not possible. Worth changing to make the code more robust in the face of future changes perhaps, but right now with the way our release notes work it's going to end up with a wall of things that sound serious but aren't and people are gonna wonder why we're not backporting them.
18:38 < gmaxwell> sipa: the "Avoid null dereference" "Avoid divide by zero" and so on.
18:43 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
18:52 < bitcoin-git> [bitcoin] practicalswift closed pull request #9560: [rpc] Avoid possibility of NULL pointer dereference in getblocktemplate(...) (master...avoid-null-pointer-dereference-in-rpc-blockchain) https://github.com/bitcoin/bitcoin/pull/9560
18:56 < luke-jr> gmaxwell: I'm not sure the average user considers them to be inflamitory at least
18:58 < gmaxwell> When 0.13.2 came out I had some journalist ask me for info about the release and I was going through the release notes and realizing how not-useful many of our short entries are.. (my own too!).  In this case, if I saw a bunch of those I'd be worried about vulnerabilities.
18:59 < gmaxwell> which isn't a correct worry at least for any of those PRs I've looked at so far.
18:59 < gmaxwell> at least for technically advanced average users who have heard what kinds of names vulnerablities come under.
19:01 < luke-jr> oh well, disarmed one that wasn't really even a bug
19:03 < sipa> FWIW, ubsan would detect all of these potential issues that practicalswift just opened PRs for
19:04 < sipa> so at least in none of the unit tests or rpc tests it gets triggered
19:10 < gmaxwell> I think for a lot they're just provably not reachable now, but maybe the code would change again.
19:21 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
19:22 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
19:25 < wumpus> BlueMatt: no, I never got to the bottom of it, latest known information is in https://github.com/bitcoin/bitcoin/issues/8732
19:27 < wumpus> BlueMatt: well there's two issues really: the posix/non-posix mutex issue (c++11 compatibliity mingw) and the fstack-protector-all one
19:32 < wumpus> gmaxwell: it's the pull request titles (not commit messages) that end up in the shortlog, if there's any PR titles that got merged for 0.14 that you find inflammatory please let me know, makes sense to change them before the list is generated
19:33 < gmaxwell> oh interesting! I didn't realize that. well makes it easier to change!
19:34 < luke-jr> ☺     
19:34 < gmaxwell> Useful to think about them from the perspective of someone upgrading and trying to decide if which impact them.
19:34 < gmaxwell> which isn't what I've historically thought about while setting PR titles/commit shortlogs.
19:35 < gmaxwell> maybe other people have, most are okay. Some not as much.
19:36 < wumpus> heh I tend to already edit issue titles that are absolute crap (like "update main.cpp")
19:37 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 248 seconds]     
19:39 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev     
19:40 < wumpus> also the list in the release notes is a subset: e.g. small typo fixes, straightforward move-only without user impact I tend to drop. The list is so long that some probably slip by though. If e.g. a technical writer could spend some time with the release notes that'd be awesome.
19:41 < wumpus> I think more important than the shortlist are the longer items though. We need to be doubly careful about those.
19:42 < gmaxwell> blockstream can supply someone to help, and I also think just asking for more assistance will get us some. (maybe?) seems like something where our extended community has some more people who would like to help with that sort of thing.
19:43 < wumpus> in the past that has never helped, at least :)
19:44 < luke-jr> I've already written some release notes when I added some of these things in Knots; could copy those over
19:44 < wumpus> yes that'd be useful luke-jr
19:45 < luke-jr> probably won't get a chance until after I time-out on reviews Monday, but I'll try to remember then
19:46 < wumpus> in any case I'll generate the first list and insert it into the release notes just before rc1 - otherwise there's too much diff noise and work to keep it up to date as a lot of merges still have to happen
19:46 < wumpus> yes, it's not something to worry about now
19:48 < wumpus> maybe using a collaborative editing site such as google docs would make sense for the release notes? It encourages more editing than having a document on the branch. Although we have to be careful who to give edit access then :)
19:49 < sipa> perhaps for a first draft - unsure
19:49 < wumpus> or a wiki page
19:49 < wumpus> yes     
19:49 < gmaxwell> yea, would be fine to just use a page on the bitcoin wiki.
19:50 < wumpus> it's a bit of a pity that mediawiki doesn't support markdown
19:50 < gmaxwell> well we don't need to see the markup there and I don't think anything in markdown will break mediawiki
19:51 < gmaxwell> in fact it would be fine to put it in <pre> tags.
19:51 < wumpus> everything is set up for markdown-formatted release notes. Not that it makes a lot of difference, it's not like we use a lot of markup in the text usually.
19:51 < wumpus> right, pre tags makes sense
19:51 -!- MarcoFalke_publi [8af602fa@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.250] has joined #bitcoin-core-dev     
19:52 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 240 seconds]     
19:52 < MarcoFalke_publi> What about the GitHub wiki?
19:52 < MarcoFalke_publi> I never tried it, though.
19:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
19:54 < wumpus> good point, that one does use markdown. Though github wiki has very restriced access control IIRC, only those withrepo write permission can edit it
19:54 < wumpus> (not 100% sure about that maybe it's a setting)
19:55 < MarcoFalke_publi> Luke seems to be using it for the bips repo.
19:55 < wumpus> but that would defeat the point if it is to get outside people involved
19:55 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 252 seconds]     
19:58 < MarcoFalke_publi> You can enable it for any GitHub user: https://help.github.com/articles/changing-access-permissions-for-wikis/
19:58 < sipa> wumpus: i think the issue to report things for release notes was a great idea
19:58 < MarcoFalke_publi> Agree
19:58 < sipa> there are so many things that seem to get forgotten when the notes have to be generated too quickly
19:59 < wumpus> though even that may still be useful for us, if we prefer editing in the wiki to committing to git on the branch
19:59 < wumpus> let's just try
19:59 < achow101> what kind of stuff needs to be done for the release notes? I may be able to help
19:59 < wumpus> MarcoFalke_publi: oh nice
20:00 < gmaxwell> well I think wiki may just be best for an initial pass.. I felt kinda bad about that windows update PR, since basically I knew people were going to rewrite it in the PR... but I thought it better to do something.
20:00 < wumpus> achow101: make sure it includes only user facing things, and that pull titles are not inflammatory/panic-arousing
20:00 < wumpus> achow101: (and of course general English spelling and structure related editing etc)
20:01 < wumpus> gmaxwell: yes the github format just isn't too great for editing documents
20:01 < achow101> ok. I think I can help with that
20:01 < gmaxwell> and also just generally informative...  focus should be on the impact/non-impact to users not the how. (often our commit messages and PR messages are very how oriented.)
20:01 < MarcoFalke_publi> Include a wiki page with how to write the release notes :)
20:03 < wumpus> shall I make a new repository for the wiki? that seems better for access control
20:05 < gmaxwell> sure. I don't think we should intend to retain the history/work there.. should just be a scratchpad.
20:06 < MarcoFalke_publi> https://github.com/bitcoin-core/bitcoin-devwiki/wiki
20:06 < wumpus> its' just an experiment for now, let's not worry about retaining history and such, may nuke the whole thing if it doesn't work out :)
20:07 < achow101> will it be open to everyone?
20:08 < wumpus> achow101: don't think it hurts to try. If it's abused, we can always lock it down more
20:09 < achow101> great. just don't tell reddit :)
20:11 < luke-jr> wumpus: Google Docs does have a nice "suggest" feature
20:12 < luke-jr> wumpus: github wiki for bips at least seems to be editable by all?
20:12 < luke-jr> but personally I think GDocs is the better solution but whatever
20:14 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
20:14 < wumpus> luke-jr: yes, gdocs has some nice features as well
20:15 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
20:16 -!- chris2000 [~chris2000@p5DCB56D7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
20:16 < achow101> are release notes written from the last major version or the last minor version
20:17 < wumpus> the last minor version of the last major version
20:17 < achow101> ok     
20:18 < wumpus> so relative to 0.13.2 int this case unless there's another release on the 0.13 branch inthe meantime
20:19 -!- chris200_ [~chris2000@p5DCB55BA.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
20:20 < luke-jr> hmm, maybe we should have non-devs write our release notes for us :P
20:21 < luke-jr> for reference: https://github.com/bitcoinknots/bitcoin/blob/v0.13.2.knots20170102/doc/release-notes.md https://github.com/bitcoinknots/bitcoin/blob/45f61ea047b08dc18a2cee7f6d946c94de8dafcd/doc/release-notes.md https://github.com/bitcoinknots/bitcoin/blob/c372395f0d8b8b7dde63f6489e98e03264abe2d7/doc/release-notes.md
20:21 < luke-jr> in case any non-dev wants to start working on it ;)
20:23 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
20:26 -!- MarcoFalke_publi [8af602fa@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.250] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]     
20:34 -!- shesek [~shesek@bzq-84-110-55-167.red.bezeqint.net] has joined #bitcoin-core-dev     
20:39 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
20:43 < fanquake> practicalswift Any chance your idling in here under a different handle?
20:51 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
20:57 < gmaxwell> fanquake: you could send an email I guess.
21:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/23281a4dc3af...4105cb6fd964
21:00 < bitcoin-git> bitcoin/master 7094bf7 Gregory Maxwell: Trim down the XP notice and say more about what we support....
21:00 < bitcoin-git> bitcoin/master 4105cb6 MarcoFalke: Merge #9550: Trim down the XP notice and say more about what we support....
21:01 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9550: Trim down the XP notice and say more about what we support. (master...we_got_it_already) https://github.com/bitcoin/bitcoin/pull/9550
21:01 < gmaxwell> that as merged fast. need to make more doc changes. :P
21:02 < fanquake> gmaxwell Yea I might do that. Was just going to comment on the stream of new PRs. Would be nice if there were grouped together a bit more, rather than seperate for every change.
21:03 < gmaxwell> fanquake: Yea, good to encourage the contribution but making manage similar changes before the first goes in might result in many that need to be adjusted.
21:05 < fanquake> gmaxwell yep. Definitely don't want to turn away what looks like an interested new contributor. Just going to point out that the repo is already somewhat overwhelmed with PRs, and review is the bottleneck. Opening many trivial PRs also generates a bit of noise.
21:05 < MarcoFalke> "trivial" :P
21:06 < bitcoin-git> [bitcoin] fanquake closed pull request #8889: Qt/ModalOverlay: Use theme tooltip colours (master...overlay_theme) https://github.com/bitcoin/bitcoin/pull/8889
21:07 < norotartagen> trivial!
21:08 < fanquake> Going to close 9263 now that 9531 has been merged. Any objections?
21:11 < sipa> #9263
21:11 < gribble> https://github.com/bitcoin/bitcoin/issues/9263 | release notes: Only free transactions are being removed, not priority. by luke-jr · Pull Request #9263 · bitcoin/bitcoin · GitHub
21:14 < luke-jr> fanquake: objection.
21:14 < luke-jr> 9263 should be merged
21:14 < luke-jr> there is no consensus to remove priority, and doing so would be inappropriate abuse of position to force a specific policy on miners.
21:15 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
21:15 < luke-jr> it's also a small amount of well-isolated and harmless code
21:15 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.]     
21:20 < gmaxwell> luke-jr: as far as I know you're the only person saying otherwise, and I think everyone else has expressed a lot of willingness to help improve the setpriority interface to make it unneeded. (including, in this release, saving the updates)
21:21 < gmaxwell> and I'm not aware of any current evidence suggesting that it plays a role in a non-trivial number of blocks getting mined today (or even any?)
21:22 < luke-jr> gmaxwell: the existence of objections is itself proof there is no consensus. the onus of evidence it is unused should be on those wishing to remove it (and there is in fact proof it is used on the PR comments).
21:24 < luke-jr> last time it came up, I went to the trouble to get proof it is used; doing so again would be at the very least difficult because the information to detect CPFP is not something available
21:25 < gmaxwell> luke-jr: you're trying to force people to continue to support and maintain functionality they don't care to support; it has a real cost. Alternatives have been provided, interest from actual users appears to be nearly zero.  And it is not a consensus feature at all.
21:25 < gmaxwell> If everyone acted like you do on this about things they care about very little would get done.
21:28 < luke-jr> it is 100 lines of isolated code that has virtually no maintenance cost. furthermore, I am a regular contributor and as such I'm not forcing anyone else to do the little work to maintain it. alternatives are overly and unnecessarily complex and create significantly more burden than simply leaving the code in as-is.
21:28 < gmaxwell> if you don't think maintaining it has a cost-- then I assume you'd just solve the disagreement by keeping it in knotts.
21:28 < gmaxwell> Every time someone else changes something in the system that possibly interacts with it, they have to consider it.
21:28 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
21:29 < gmaxwell> You can't deflect these costs except by doing all the work yourself.
21:29 < luke-jr> I'm not sure anyone but me is constantly nagged about removing things they support and people use..
21:29 < gmaxwell> also it hasn't been removed yet-- presumably once depricated it will get removed when it's actually in the way.
21:30 < gmaxwell> (we have things that have been marked depricated for years still not removed because there hasn't yet been good cause to do so.)
21:30 < luke-jr> I probably could just maintain it in Knots, though.
21:30 < gmaxwell> Good! certantly no one has any concern or objection with it being out there! its not at all incompatible.
21:30  * gmaxwell goes to bed
21:31 < luke-jr> gmaxwell: perhaps a reasonable compromise could be found by removing "[removed] in the next major version", and leave it alone until it actually creates an issue?
21:43 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/4105cb6fd964...01c4576a3914
21:43 < bitcoin-git> bitcoin/master 02fcb29 fanquake: [depends] Qt 5.7.1
21:43 < bitcoin-git> bitcoin/master 2b32dea Cory Fields: depends: use new variable layout for qt sdk
21:43 < bitcoin-git> bitcoin/master c37ea4d Cory Fields: depends: fix qt translations build...
21:43 < bitcoin-git> [bitcoin] laanwj closed pull request #9469: [depends] Qt 5.7.1 (master...depends-0-14-0-qt) https://github.com/bitcoin/bitcoin/pull/9469
21:45 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/01c4576a3914...f62bc10a607c
21:45 < bitcoin-git> bitcoin/master e6111b2 Matt Corallo: Make peer id logging consistent ("peer=%d" instead of "peer %d")
21:45 < bitcoin-git> bitcoin/master f62bc10 Wladimir J. van der Laan: Merge #9486: Make peer=%d log prints consistent...
21:45 < bitcoin-git> [bitcoin] laanwj closed pull request #9486: Make peer=%d log prints consistent (master...2017-01-peer-log-consistency) https://github.com/bitcoin/bitcoin/pull/9486
21:45 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
21:57 < luke-jr> sipa: BlueMatt: did you even look at the new PR changes? should I give up on a compromise and go back to the original?
21:59 < sipa> luke-jr: i did not notice you changed it; i'm fine with the text, can you also change the pr title?
21:59 < luke-jr> ok, updated
22:15 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection]     
22:33 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
22:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
22:46 < achow101> I went through the release notes todo and added most of it to the release notes in the wiki
22:47 < achow101> of course it can and should be improved, but at least most of it is now there so it won't be forgotten
23:00 -!- dermoth [~thomas@dsl-66-36-128-167.mtl.aei.ca] has quit [Read error: Connection reset by peer]     
23:01 -!- dermoth [~thomas@dsl-66-36-128-167.mtl.aei.ca] has joined #bitcoin-core-dev     
23:07 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
23:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
23:16 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev     
23:20 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds]     
23:26 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
23:27 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
23:34 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev