--- Day changed Tue Jan 17 2017 00:10 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:11 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 00:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:43 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [] 00:47 * jonasschnelli request a retest of: https://github.com/bitcoin/bitcoin/pull/9294 from BlueMatt luke-jr (thanks in advance!) 01:18 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 255 seconds] 01:21 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 01:24 < wumpus> I've extended the section on named arguments in the release notes a bit: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.14.0-Release-notes#support-for-json-rpc-named-arguments 01:25 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 01:25 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:54 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 02:18 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Read error: Connection reset by peer] 02:23 -!- waxwing__ [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 02:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 02:32 -!- wvr [~wvr@215.red-83-59-62.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 02:37 -!- waxwing__ is now known as waxwing 02:39 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 02:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:43 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 252 seconds] 02:46 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 02:47 < bitcoin-git> [bitcoin] jdust69 opened pull request #9568: 10.13 (master...0.13) https://github.com/bitcoin/bitcoin/pull/9568 02:48 < bitcoin-git> [bitcoin] fanquake closed pull request #9568: 10.13 (master...0.13) https://github.com/bitcoin/bitcoin/pull/9568 02:49 -!- aalex [~aalex@64.187.177.58] has quit [Read error: Connection reset by peer] 02:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 02:49 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 02:56 -!- waxwing [waxwing@gateway/vpn/mullvad/x-pxtccelltbhtzscd] has joined #bitcoin-core-dev 03:10 -!- waxwing [waxwing@gateway/vpn/mullvad/x-pxtccelltbhtzscd] has quit [Ping timeout: 260 seconds] 03:15 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 240 seconds] 03:21 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 03:21 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:23 -!- waxwing [~waxwing@185.65.132.137] has joined #bitcoin-core-dev 04:16 < bitcoin-git> [bitcoin] fanquake closed pull request #9263: release notes: Explicitly mention the removal of free transactions, and do not commit to removal of priority in any given release (master...relnotes_freetxn) https://github.com/bitcoin/bitcoin/pull/9263 04:31 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 04:34 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 04:35 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 258 seconds] 04:36 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 04:36 < morcos> luke-jr: what is the point of doing the release notes on a wiki, if you are going to just merge changes that were explicitly NACK'ed when those same changs were proposed in a PR 04:36 < morcos> all that is going to do is lead to a childish edit war and make it so none of us can use the wiki for release notes 04:37 < morcos> if you know you have a controversial change you want to make you shouldln't just make it and hope no one notices 04:37 < morcos> this is not a proper way of working with other people 04:59 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 05:14 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:15 -!- waxwing [~waxwing@185.65.132.137] has quit [Ping timeout: 240 seconds] 05:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 05:32 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 06:07 < BlueMatt> jonasschnelli: hey 06:07 < BlueMatt> how much longer will you be around? 06:07 < jonasschnelli> BlueMatt: 1-2h at least 06:07 < jonasschnelli> hi 06:07 < BlueMatt> ok, will circle back around after breakfast and hopefully we can finish this 06:08 < jonasschnelli> Yes. I guess and hope I fixed most/all of you points... tell me, if there is more 06:08 < BlueMatt> i think it should be good if you hit all the stuff i commented on, i gave it a pretty decent review the first go-around, but it needs another one when I'm awake post-breakfast 06:08 < jonasschnelli> Yes. I think your review was very valuable... 06:09 < jonasschnelli> We should not rush that change... but hurry up for 0.14. :)= 06:10 < BlueMatt> heh, yea, I recommended pushing back yesterday because I'm confident we can get this one in 06:10 < jonasschnelli> Yes. I mean if we find something after the freeze, there is time to fix it before the 0.14 release... 06:11 < BlueMatt> yup 06:19 < sipa> do we want to be a mentoring org for GSOC? 06:20 < BlueMatt> does anyone feel like they have time? 06:20 < BlueMatt> i mean in theory, maybe, but.... 06:20 < sipa> yeah... 06:21 < sipa> i feel like we should make time for such projects 06:21 < sipa> but easier said than done 06:22 < BlueMatt> yea 06:22 < BlueMatt> obviously agreed 06:25 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:29 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:44 < BlueMatt> jonasschnelli: any chance we can s/(used for change outputs, only appears if HD is enabled otherwise there is no need for internal keys)/(used for change outputs, only appears if HD split is enabled, otherwise external keys are used)/ 06:44 < BlueMatt> and make the corresponding change the the logic 06:44 < BlueMatt> should make the docs wayyy clearer 06:45 < jonasschnelli> BlueMatt: Okay. Makese sense I guess. 06:45 < jonasschnelli> I liked the idea form luke-jr... 06:45 < jonasschnelli> keypoolsize: {"internal": x, "external": y} 06:45 < jonasschnelli> But breaks the API 06:45 < BlueMatt> yea, agreed lets not break the api 06:45 < jonasschnelli> okay.. will update 06:46 < jonasschnelli> BlueMatt. one meh though... 06:46 < jonasschnelli> Do we want to expose "HD split is enabled" to the user? 06:46 < jonasschnelli> "HD split" as a label can be confusing... 06:47 < BlueMatt> hum, or maybe just "only appears if wallet is using this feature, otherwise external keys are used"? 06:47 < jonasschnelli> We could name it "HD internal keypool" or similar 06:47 < jonasschnelli> yes. Your text is good 06:47 < jonasschnelli> Let me take it 06:47 < BlueMatt> ok, cool 06:51 < jonasschnelli> BlueMatt: https://github.com/bitcoin/bitcoin/pull/9294/commits/eeeb52afc3b25836588b2b7c6b704a5a6498e1d1 06:51 < jonasschnelli> Added to #9294 06:51 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub 06:51 < BlueMatt> thanks 06:58 -!- jnewbery1 [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 07:01 < BlueMatt> jonasschnelli: do we normally bump wallet versions at release? I think we just set them based on next version pre-merge 07:01 < jonasschnelli> BlueMatt: in 0.13, we bumped to 130000 after the tag/version.bump was made 07:02 < BlueMatt> ehh, ok 07:02 < jonasschnelli> Otherwise you can't test it and all tests will fail 07:02 < BlueMatt> oh, ok, didnt realize that 07:02 < BlueMatt> can you not catch(...) in deserialize? 07:02 < BlueMatt> we always throw std::ios_base::failure when we read oob 07:02 < jonasschnelli> BlueMatt: the problem there is, that CKeyPool has no record version... 07:03 < jonasschnelli> maybe we could check is CDataStream has more bytes? 07:03 < BlueMatt> yes, catch(std::ios_base::failure&) 07:03 < jonasschnelli> ah.. okay. 07:03 < BlueMatt> otherwise you'll catch all kinds of fun garbage that should really reach top-of-thread and assert 07:03 < jonasschnelli> Yes. Indeed. 07:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:06 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 07:07 < jonasschnelli> BlueMatt: https://github.com/bitcoin/bitcoin/pull/9294/commits/a874b75a180a9e967a3d936cf46df11f8531b70a 07:07 < jonasschnelli> I wonder if a simple "are there more bytes?" check would be more appropriate at this place 07:08 -!- morph [~morph@r201-pw-caracol.ibys.com.br] has joined #bitcoin-core-dev 07:08 < jonasschnelli> On the other hand, a failed deserialization at this point shoud always flag the CKeyPool item fInternal=false 07:13 < BlueMatt> jonasschnelli: ok, the only remaining concern i have is performance - there are a bunch of loops over disk reads introduced for folks who upgrade 07:13 < jonasschnelli> Yes. This could be optimised... 07:13 < jonasschnelli> I expect BDB to be sort of fast... 07:14 < BlueMatt> I think you may be surprised 07:14 < BlueMatt> but if its an issue its an easy fix 07:14 < instagibbs> that can be fixed post-freeze, yeS? 07:14 < jonasschnelli> Yes. CKeyPool should have been fixed long time ago... 07:15 < BlueMatt> instagibbs: if it turns out to be a major regression, I'd say yes 07:15 < jonasschnelli> BlueMatt: I can test it with a 100k keypool wallet... and compare 07:16 < jonasschnelli> Oh.. lets better start with 50k... 07:17 < jonasschnelli> or with 5k,... CKey.Verify() is slow.. 07:17 < BlueMatt> heh 07:18 < sipa> CKey.Verify() can verify 10000 keys per second 07:18 < sipa> the slow part is the sync to bdb after every keypool change 07:22 < jonasschnelli> okay.. I see.. 07:37 < jonasschnelli> BlueMatt: With a 5k wallet, its slightly slower on my Core i7 2.9 GHZ.. 07:37 < jonasschnelli> getnewaddress: real 0m0.219s 07:39 < BlueMatt> vs? 07:40 < jonasschnelli> real 0m0.104s 07:40 < jonasschnelli> (0.13) 07:41 < jonasschnelli> BlueMatt: I think it's acceptable but we should work on a fix/better-memory map 07:41 < BlueMatt> I think its fine for now, I'll let phantomcircuit fix it when he complains 07:42 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #9419: Stop Using cs_main for CNodeState/State() (master...2016-12-nodestate) https://github.com/bitcoin/bitcoin/pull/9419 07:43 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #9488: Parallel ThreadMessageHandler (master...2017-01-parallel-processmessages) https://github.com/bitcoin/bitcoin/pull/9488 07:43 < jonasschnelli> BlueMatt: oh. Keep in mind, that 0.13er wallet has only 5k keys while the 0.14er wallet has 200% key (=10k) 07:43 < jonasschnelli> So.. then the number look even better 08:01 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:10 < morph> hi 08:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 255 seconds] 08:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:51 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:57 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 09:01 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:04 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:12 < luke-jr> morcos: YOUR changes were NACK'd. 09:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 09:16 < morcos> luke-jr: i didn't have any release note changes except 9531 which were merged with only ACK's. But I'm not going to waste everyone's time arguing with you about this. I find you very difficult to work with, and so I will just avoid it where possible. 09:16 < morcos> I've made my view point on the release notes clear.. If you want to go around changing things behind people's backs, I'm not going to take on the task of trying to stop you. But you should be aware your actions reflect poorly on all of us. 09:17 < luke-jr> morcos: trying to use Core as a vehicle for political agendas is what reflects poorly. 09:18 < sipa> luke-jr: stop it 09:18 < sipa> there have been more than enough arguments 09:18 < sipa> sorry, people disagree with you 09:18 < sipa> accept it 09:19 < luke-jr> disagreement means we should agree to disagree by having an option, not that you should just get your way and force your opinion on others 09:19 < luke-jr> this would all be over if you would just leave it be. 09:20 < BlueMatt> this may be true for some thing, but we dont generally support options that are used by +/- one person, especially if they have really big costs to doing so 09:20 < BlueMatt> s 09:20 < luke-jr> BlueMatt: the cost to leaving the code in place until it gets in someone's de facto way is literally zero. 09:21 < BlueMatt> no it is not, it has not been, and it will not be 09:22 < luke-jr> I already suggested a compromise that it can be removed at the first occasion of it being a burden to someone who wants to change something there. 09:22 < BlueMatt> we're waayyyyy past that point 09:22 < sipa> luke-jr: the discussion about it has dragged on for ages, and just the disagreement about it is draining people who want to work on the project 09:22 < sipa> it is clear that thid code is useless at this point 09:22 < BlueMatt> the compromise is that if you want to support it, you can add additional rpcs which give you access to the appropriate data so you can call prioritizetransaction (ie the fee-bumping command) 09:22 < luke-jr> then morcos went and made that inflammatory comment 09:23 < sipa> we're doing everyone a favor by just getting past it 09:23 < luke-jr> sipa: so stop creating disagreement for no reason 09:23 < sipa> luke-jr: i can say the same 09:23 < BlueMatt> the disagreement is that only you disagree, at this point 09:23 < BlueMatt> hell, even other miners disagree with you 09:23 < luke-jr> except I'm not the one who keeps bringing it up and forcing the issue. 09:24 < sipa> luke-jr: you're turning a piece of outdated logic from a mouse into an elephant, and i'm tired of having this discussion 09:24 < BlueMatt> because everyone wants to just remove the damn code already 09:24 < luke-jr> BlueMatt: some miners perhaps. others don't. 09:24 < BlueMatt> oh? who other than you? 09:24 < luke-jr> nobody is forcing the ones who don't want it to use it. 09:24 < BlueMatt> (and dont say wizkid) 09:24 < luke-jr> wizkid057 doesn't count now? 09:24 < BlueMatt> the amount of work that has gone into maintaining this feature just for eligius is insane 09:24 < BlueMatt> we maintain no other feature for one person/group 09:24 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:24 < BlueMatt> if that were our policy we'd still have tonal numbering in bitcoin core 09:25 < luke-jr> "still" implying we ever did 09:25 < BlueMatt> well, ok, we'd have 09:25 < BlueMatt> s/still// 09:25 < BlueMatt> same thin 09:25 < BlueMatt> g 09:28 < luke-jr> not to mention there's no evidence it's only used by one person. 09:31 < sipa> there is evidence that only a small percentage of the hash rate uses it (look at the feerate of blocks in transactions... it's clearly feerate sorted, except for a small percentage of txn at the beginning of a very occasional block) 09:32 < sipa> furthermore, it is completely useless as a spam prevention mechanism without wallets targetting it 09:32 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 09:32 < sipa> i'm done arguing about this 09:32 < sipa> we'll remove priority mining in 0.15, as far as i'm concerned 09:33 < luke-jr> that's simply not true at all. priority works without any targetting. 09:34 < sipa> come on 09:35 < sipa> a perfectly legitimate wallet's transaction would be treated completely arbitrarily under it 09:35 < sipa> all it would accomplish is favor a few people with very old coi s 09:36 < sipa> until they start spending recent change 09:38 < luke-jr> *any* age/value weighs more than unconfirmed TXOs. 09:38 < sipa> if you choose to keep arguing this, i will choose to ignore you 09:41 < luke-jr> fine, remove priority. be a jerk and do it before there's even a slightly useful purpose in doing so. but then it's time to stop pretending Core is a politically-neutral reference implementation, since it's de facto being used as a vehicle to force network policy. all you're doing is proving the haters right. 09:46 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 09:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:49 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:50 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 10:00 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 10:01 < BlueMatt> luke-jr: if there were no way to implement it in the supported apis, maybe you'd have a point...but right now it is /trivial/ to implement priority exactly how you like it in a little python script which loops over the mempool and does manual prioritization 10:02 < BlueMatt> luke-jr: if you can honestly tell me you've implemented that, and it wasnt performant enough or there was some other issue preventing it from being practical, maybe I'd have some sympathy, but until then.... 10:08 < luke-jr> BlueMatt: so just busyloop over RPC mempool listing, maintain an entire copy of the mempool state outside bitcoind, and act as a proxy for explicit miner prioritisation? I can't even imagine a way to do this effectively; it's certainly a heck of a lot more work, less reliable, and far less efficient. 10:08 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:08 < BlueMatt> less efficient? yes, lot more work? I dont believe so...go implement it and prove me wrong 10:09 < BlueMatt> i dont think it needs state, just iterate over and clear prioritization as you go 10:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 10:10 < BlueMatt> high_prio = stack(); for transaction in getrawmempool(): if calculate_priority(tx) is highest in stack: place in stack; for transaction not in stack but previously prioritzed: deprioritize; for transaction in stack: prioritize appropriately 10:10 < BlueMatt> if thats more than 100 lines of python I'd be surprised 10:10 < BlueMatt> and if its too ineffecient for you, please add an rpc which provides all the info needed for calculate_priority so that its super effecient 10:11 < BlueMatt> I'd be more than happy to review that 10:13 < luke-jr> to have such an RPC means having about half of the priority code stay in Core 10:13 < luke-jr> because it comes from the input txouts 10:13 < BlueMatt> dont think so? such an rpc could easily only provide things like foreach input: provide txout info 10:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:14 < BlueMatt> and that is way more general than priority 10:14 < BlueMatt> it allows folks to implement other crazy rules 10:14 < BlueMatt> like "spends from address x" 10:14 < BlueMatt> (well, admittedly you can kinda already do that by seeing the pubkey) 10:14 < luke-jr> but fetching txouts is where the inefficiency came from? 10:14 < BlueMatt> fetching txouts is the tightest loop in the above pseudocode 10:14 < BlueMatt> so I'd think so 10:15 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 10:15 < BlueMatt> wumpus: yo 10:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:15 < BlueMatt> you still around? 10:16 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:16 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 10:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 10:20 -!- isle2983 [~isle@162.216.46.102] has joined #bitcoin-core-dev 10:24 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 10:27 < luke-jr> BlueMatt: let's continue that topic (or not) post-freeze. either way, it will be easier to maintain priority in Knots than external. and in the meantime, if we haven't frozen yet, I should get back to reviewing stuff 10:28 < BlueMatt> its unclear to me if we've frozen or not :/ 10:28 < luke-jr> well, finishing up review certainly can't hurt either way 10:28 < BlueMatt> I mean either we froze, or we have 4 outstnding prs that either go in or dont (todayish, preferably) 10:28 < BlueMatt> yea, fair point 10:32 -!- isle2983 [~isle@162.216.46.102] has quit [Quit: Leaving] 10:40 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:40 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 10:47 -!- isle2983 [~isle@162.216.46.59] has joined #bitcoin-core-dev 10:51 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 10:55 -!- morph [~morph@r201-pw-caracol.ibys.com.br] has left #bitcoin-core-dev ["Leaving"] 10:55 < bitcoin-git> [bitcoin] jnewbery opened pull request #9569: Setting -blocksonly sets -maxmempool to zero. (master...blocksonlynomempoolsharing) https://github.com/bitcoin/bitcoin/pull/9569 10:59 -!- isle2983 [~isle@162.216.46.59] has quit [Ping timeout: 260 seconds] 11:09 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has joined #bitcoin-core-dev 11:11 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 258 seconds] 11:13 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 11:27 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has quit [Ping timeout: 240 seconds] 11:30 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 11:30 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 11:31 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has joined #bitcoin-core-dev 11:51 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:52 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 11:52 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 11:52 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 11:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 12:15 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:26 -!- celsosouza [~textual@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has joined #bitcoin-core-dev 12:36 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:37 < wumpus> BlueMatt: no, we've not frozen yet, that's when we split off the 0.14 branch 12:38 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye] 12:39 < BlueMatt> wumpus: oh, I'm confused now...the release schedule says feature freeze today, branch in feb 12:40 < wumpus> BlueMatt: I'm confused apaprently, yes branch is before first -rc, it has been the other way around but it means a lot of more backporting so this is okay 12:44 < wumpus> the only other freeze there is today is "translation string freeze", but that makes little sense without feature freeze 12:44 < wumpus> let's move the feature freeze (and translation freeze) to thursday 12:46 < BlueMatt> my pending list is #8456, #9294 # 9499 and #9535...of those I believe only 9499 has string changes 12:46 < gribble> https://github.com/bitcoin/bitcoin/issues/8456 | [RPC] Simplified bumpfee command. by mrbandrews · Pull Request #8456 · bitcoin/bitcoin · GitHub 12:46 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub 12:46 < gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub 12:47 < BlueMatt> I dont think anything else is reasonably gonna make a feature freeze 12:47 < BlueMatt> so we could also just call translation string freeze when #9499 is merged 12:47 < gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub 12:47 < BlueMatt> (rpc help text is not translated, correct?) 12:47 < wumpus> sounds good to me 12:47 < wumpus> no, rpc help is not translated 12:47 < BlueMatt> ok, good 12:48 < wumpus> 9535 isn't even tagged for 0.14.0?! 12:49 < BlueMatt> no, but is too trivial and big win for me to not include in my list :p 12:49 < BlueMatt> but if it slips thats ok 12:49 < wumpus> I think we should focus on the current list, there's still 6 things on there 12:49 < BlueMatt> as long as 9499 doesnt 12:49 < wumpus> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.14.0 12:49 < BlueMatt> half of the current list is bugfixes 12:49 < BlueMatt> of which there are several more coming (see issues tagged for 14) 12:50 * BlueMatt goes back to fixing #9148 12:50 < gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub 12:50 < BlueMatt> which is nontrivial :( 12:50 < wumpus> bumpfee, internal hd chain, fundrawtransaction, improve progress display are all features I'd say 12:50 < BlueMatt> oh fuck, how did i miss the display one 12:51 < BlueMatt> no, the fundraw one is def a bugfix 12:51 < wumpus> exclude RBF replacement and recent-rejects seem bugfixes 12:51 < BlueMatt> recent-rejects is more a feature 12:51 < wumpus> ok 12:51 < BlueMatt> without the fundarw one it re-uses change addresses 12:52 < BlueMatt> which is very not so good 12:52 < BlueMatt> fuck, jonasschnelli #9377 needs rebase 12:52 < wumpus> I slotted it as feature as it adds to the RPC API 12:52 < gribble> https://github.com/bitcoin/bitcoin/issues/9377 | fundrawtransaction: Keep change-output keys by default, make it optional by jonasschnelli · Pull Request #9377 · bitcoin/bitcoin · GitHub 12:52 < BlueMatt> oh it does add 12:52 < wumpus> anyhow it's important to get in that's for sure 12:52 < BlueMatt> hum, we could probably implement it more cleanly 12:52 < BlueMatt> well, cleanly meaning less diff 12:53 < BlueMatt> but, yea, needs to happen for 14 12:53 < wumpus> is there time for that and still review the stuff before 0.14? 12:53 < BlueMatt> my concern for 14 isnt the open stuff, its the bugs that need fixing that arent even pr'ed yet 12:53 < BlueMatt> eg #9148 is a serious issue and the fix is not tiny 12:53 < gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub 12:53 < wumpus> the diff for #9377 is not that large 12:53 < gribble> https://github.com/bitcoin/bitcoin/issues/9377 | fundrawtransaction: Keep change-output keys by default, make it optional by jonasschnelli · Pull Request #9377 · bitcoin/bitcoin · GitHub 12:54 < BlueMatt> yea, I'm not too worried about that one, will review soon 12:54 < BlueMatt> I also plan to do a helgrind run again this or next week, whenever we decide which net pulls will make it, which is gonna result in a nontrivial number of "Convert X to std::atomic" commits 12:55 < BlueMatt> the walletnotify one (#9479 / $9371) is also gonna take some work 12:55 < gribble> https://github.com/bitcoin/bitcoin/issues/9479 | An error has occurred and has been logged. Please contact this bot's administrator for more information. 12:56 -!- celsosouza [~textual@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has quit [Quit: Textual IRC Client: www.textualapp.com] 12:56 < BlueMatt> but i havent dug into that one as of yet 12:56 < BlueMatt> morcos and y'all seem on it 12:57 < BlueMatt> ok, so string freeze is whenever #9499 and #9461 make it, otherwise when feature freeze happens 12:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub 12:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub 12:58 -!- handlex [~handlex@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has joined #bitcoin-core-dev 12:58 < BlueMatt> jonasschnelli: can you fix the outstanding comments on #9461? 12:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub 13:05 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 256 seconds] 13:10 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 240 seconds] 13:25 < BlueMatt> 'tf 13:25 < BlueMatt> so I'm pretty sure, right now, if you receive a coinbase payout in a block, turn off your node, and then restart without checkblocks, your payout will not display 13:26 < BlueMatt> because no NotifyTransactionChanged will ever fire to the gui 13:27 < BlueMatt> i mean super edge-case-y but still 13:32 < sipa> is that a recent regression? 13:33 < BlueMatt> looks super old 13:33 < BlueMatt> but didnt check 13:33 < BlueMatt> restarting gui will fix it, though, afaict 14:12 -!- handlex [~handlex@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:13 -!- handlex [~handlex@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has joined #bitcoin-core-dev 14:29 -!- handlex [~handlex@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:39 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 15:08 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 252 seconds] 15:18 -!- handlex [~handlex@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has joined #bitcoin-core-dev 15:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:53 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9570: Block Wallet RPCs until wallet is synced to our current chain (master...2017-01-fix-wallet-rpc-stale) https://github.com/bitcoin/bitcoin/pull/9570 15:56 < gmaxwell> I thought the fundraw change change made it in already. darn. 15:59 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 16:09 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 245 seconds] 16:23 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:32 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 255 seconds] 16:46 -!- chjj [~chjj@unaffiliated/chjj] has quit [Quit: WeeChat 1.6] 16:46 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 17:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:16 -!- Netmage [~Netmage@p5B0A6EA5.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 17:16 -!- Netmage [~Netmage@p5B0A6AE4.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 17:21 -!- shesek [~shesek@bzq-84-110-55-167.red.bezeqint.net] has quit [Ping timeout: 240 seconds] 17:22 -!- stench [~stench@185.86.151.126] has quit [Read error: Connection reset by peer] 17:23 -!- stench [~stench@176.223.111.92] has joined #bitcoin-core-dev 17:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-biqbxepyceufmjcf] has quit [Quit: Connection closed for inactivity] 17:27 < bitcoin-git> [bitcoin] pinheadmz opened pull request #9571: RPC: getblockchaininfo returns BIP signaling statistics (master...master) https://github.com/bitcoin/bitcoin/pull/9571 17:27 -!- Netsplit *.net <-> *.split quits: BashCo, atroxes 17:29 -!- Netsplit over, joins: BashCo, atroxes 17:35 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 17:35 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 17:36 -!- Netsplit *.net <-> *.split quits: fengling, Magma, [Author] 17:38 -!- handlex [~handlex@2804:14c:658f:4dc7:387b:5daf:5613:9d5f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:12 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:25 -!- randy-waterhouse [~kiwigb@43.228.156.105] has joined #bitcoin-core-dev 18:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 18:25 -!- randy-waterhouse [~kiwigb@43.228.156.105] has quit [Changing host] 18:25 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 18:27 -!- Magma [~magma@magma.tokyo] has joined #bitcoin-core-dev 18:29 -!- [Author] [~Author]@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 18:36 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 240 seconds] 18:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:55 -!- randy-waterhouse [~kiwigb@150.242.128.85] has joined #bitcoin-core-dev 18:56 -!- randy-waterhouse [~kiwigb@150.242.128.85] has quit [Changing host] 18:56 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 18:57 -!- fengling [~fengling@223.223.187.142] has joined #bitcoin-core-dev 19:00 -!- cheese_ [~x@unaffiliated/cheeseo] has quit [Excess Flood] 19:00 -!- cheese_ [~x@208.167.254.78] has joined #bitcoin-core-dev 19:00 -!- cheese_ [~x@208.167.254.78] has quit [Changing host] 19:00 -!- cheese_ [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 19:20 -!- Squidicc [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again] 19:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 19:31 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:32 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:33 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 19:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:02 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 20:04 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 20:15 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:16 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:47 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 20:54 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 20:57 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 21:00 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has quit [Read error: Connection reset by peer] 21:00 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has joined #bitcoin-core-dev 21:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:24 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 21:24 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 21:34 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:12 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 22:19 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 245 seconds] 22:21 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 255 seconds] 22:35 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 22:45 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 22:45 -!- cheese_ [~x@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 22:47 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 252 seconds] 22:48 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 23:02 < jonasschnelli> BlueMatt: I'm working on the fixes for #9461 23:03 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub 23:36 -!- shesek [~shesek@bzq-84-110-53-229.cablep.bezeqint.net] has joined #bitcoin-core-dev 23:39 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rigunukqnxoybdbs] has joined #bitcoin-core-dev 23:45 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 23:55 < bitcoin-git> [bitcoin] jl2012 opened pull request #9572: Skip witness sighash cache for non-segwit transactions (master...nocache) https://github.com/bitcoin/bitcoin/pull/9572