--- Day changed Tue Jan 24 2017 00:09 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:10 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:11 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 256 seconds] 00:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 00:16 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 00:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 00:24 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 00:25 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71148b8947fe...50864529b6e7 00:25 < bitcoin-git> bitcoin/master fa4d478 MarcoFalke: qt: Use nPowTargetSpacing constant 00:25 < bitcoin-git> bitcoin/master 5086452 Jonas Schnelli: Merge #9588: qt: Use nPowTargetSpacing constant... 00:25 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9588: qt: Use nPowTargetSpacing constant (master...Mf1701-qtParams) https://github.com/bitcoin/bitcoin/pull/9588 00:30 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:36 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:55 -!- echonaut1 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 00:55 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 01:08 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/50864529b6e7...4a1dc35ca532 01:08 < bitcoin-git> bitcoin/master ff25c32 Wladimir J. van der Laan: mempool: add notification for added/removed entries... 01:08 < bitcoin-git> bitcoin/master 4afbde6 Alex Morcos: Introduce MemPoolConflictRemovalTracker... 01:08 < bitcoin-git> bitcoin/master 094e4b3 Alex Morcos: Better document usage of SyncTransaction 01:08 < bitcoin-git> [bitcoin] laanwj closed pull request #9371: Notify on removal (master...notifyOnRemoval) https://github.com/bitcoin/bitcoin/pull/9371 01:14 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:47 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 02:04 < gmaxwell> "systemd local root exploit" ... gentoo user not affected. 02:14 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 02:16 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Ping timeout: 240 seconds] 02:18 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Client Quit] 02:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:35 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 02:35 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 02:35 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 02:56 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:57 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 03:14 < morcos> wumpus: thanks for merging 9371! i think we're starting to get 0.14 in our sights 03:14 < wumpus> indeed! it's starting to look quit good 03:14 < morcos> gmaxwell: which importmulti fixes did you want to get in for 0.14, besides the watch only timestamp PR that is already tagged? 03:14 < wumpus> quitE 03:50 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Quit: Leaving] 04:17 -!- waxwing [~waxwing@14.165.235.227] has quit [Ping timeout: 240 seconds] 04:21 < bitcoin-git> [bitcoin] laanwj closed pull request #8549: zmq: mempool notifications (master...zmq_mempool) https://github.com/bitcoin/bitcoin/pull/8549 04:27 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4a1dc35ca532...1ac878ace623 04:27 < bitcoin-git> bitcoin/master be31a2b Lauda: [Trivial] Update license year range to 2017... 04:27 < bitcoin-git> bitcoin/master 1ac878a Wladimir J. van der Laan: Merge #9617: [Trivial] Update license year range to 2017... 04:27 < bitcoin-git> [bitcoin] laanwj closed pull request #9617: [Trivial] Update license year range to 2017 (master...master) https://github.com/bitcoin/bitcoin/pull/9617 04:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:38 -!- waxwing [~waxwing@14.165.235.227] has joined #bitcoin-core-dev 05:10 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9284: Suppress some annoying deprecation warnings (OSX) (master...2016/12/osx_warnings) https://github.com/bitcoin/bitcoin/pull/9284 05:11 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9076: [WIP][Experimental] Add Hybrid full block SPV mode (master...2016/10/spv) https://github.com/bitcoin/bitcoin/pull/9076 05:12 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #8745: [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" (master...2016/09/wallet-tool) https://github.com/bitcoin/bitcoin/pull/8745 05:13 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:22 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 05:26 < jonasschnelli> This little refactoring seems readyish: https://github.com/bitcoin/bitcoin/pull/9143 05:26 < jonasschnelli> Ahm... right. The freeze. 05:41 < wumpus> yeah I'm not sure whether it makes sense to do now - a pure refactor is not a bugfix but neither is it a feature - depends on the regression risk I suppose 05:48 < jonasschnelli> Better after we branch of 0.14 05:52 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 06:00 < bitcoin-git> [bitcoin] s-matthew-english opened pull request #9623: fixing typo in README (master...patch-14) https://github.com/bitcoin/bitcoin/pull/9623 06:01 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 06:11 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 06:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 06:45 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:46 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:51 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has quit [Quit: cryptapus] 07:21 < jonasschnelli> sf boost download issues in travis: https://travis-ci.org/bitcoin/bitcoin/jobs/194846204#L537 07:21 < jonasschnelli> hope it's temp. only 07:22 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 07:25 < BlueMatt> so it looks like the archlinux-arm bitcoin packages are being built using a PKGBUILD different from the one published and building a modified 0.13.2 source tree 07:25 < BlueMatt> over under on a backdoor? 07:37 < sipa> ugh 07:48 < BlueMatt> they're looking into it (the alarm guys) 07:48 < BlueMatt> (thats ArchLinux-ARM) 08:20 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:20 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:20 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:25 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 08:26 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 08:32 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:32 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:32 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:43 < cfields> jonasschnelli: crontab (to fetch sources on fallback server) wasn't running. should be fixed now, so fallback should work if sf.net 404's 08:45 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:48 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has quit [Client Quit] 08:52 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 08:52 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 08:57 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:08 < morcos> sipa: got any ideas on #9620? 09:08 < gribble> https://github.com/bitcoin/bitcoin/issues/9620 | Wallet lost track of funds · Issue #9620 · bitcoin/bitcoin · GitHub 09:14 < sipa> morcos: no :( 09:27 < sipa> morcos: "all i do is sendtoaddress" - "the manual CPFP transaction i created" 09:32 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 255 seconds] 09:32 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 09:32 < bitcoin-git> [bitcoin] jnewbery opened pull request #9624: [Trivial] fix logging typo in FlushStateToDisk() (master...TrivialTypo) https://github.com/bitcoin/bitcoin/pull/9624 09:35 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 09:44 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:45 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 09:45 < cfields> BlueMatt: holy crap, arch packages are built by hand and uploaded? 09:45 < BlueMatt> cfields: on regular arch, yes! 09:45 < BlueMatt> cfields: (as in, holy crap, dont trust arch packages) 09:46 < cfields> that's terrifying 09:46 < BlueMatt> cfields: archlinux-arm has a build farm, apparently 09:46 < BlueMatt> cfields: everything is, when you look closely 09:46 < cfields> i went looking for a build log, only to come to the depressing realization :( 09:47 < cfields> BlueMatt: looks like it's possible to me that their builder gets confused by the tag version, and doesn't end up checking out the tag 09:47 < BlueMatt> cfields: I dont think there is a single linux distro which I would trust almost in any way at all....even the ones with build farms end up accepting sigs from any one of a million people to update the source files :/ 09:47 < BlueMatt> cfields: the binary reports "v0.13.2.0-0d719145b-dirty" 09:47 < BlueMatt> that commit is v0.13.2 09:47 < BlueMatt> (though dunno where the ".0" came from - is that normal for git describe?) 09:47 < cfields> hmm 09:48 < BlueMatt> the non-arm archlinux binary properly reports "v0.13.2" 09:48 < BlueMatt> well, I didnt run it, just strings'd it 09:48 < cfields> yes, i'm looking at the same now 09:49 < cfields> ok good, well at least it's based on the right version 09:50 < bitcoin-git> [bitcoin] morcos opened pull request #9625: Increase minimum debug.log size to 9MB after shrink. (master...shrinkless) https://github.com/bitcoin/bitcoin/pull/9625 09:50 < BlueMatt> "based on" i mean the "-dirty" coul be anything 09:50 < cfields> right 09:50 -!- pavel_ [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 09:50 < BlueMatt> I went through what appears to be their build farm tool at https://github.com/archlinuxarm/plugbuild and noted changes it makes to the PKGBUILD file at https://github.com/archlinuxarm/plugbuild/blob/master/client.pl#L344 09:51 < BlueMatt> but was still unable to reproduce the PKGBUILD hash claimed in the .BUILDINFO file 09:53 < cfields> where's the .BUILDINFO coming from? 09:54 < BlueMatt> the .pkg.tar.xz thing that is the package itself has a .BUILDINFO file in it 09:54 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 252 seconds] 09:54 < cfields> ah, thanks. grabbing 09:55 < BlueMatt> (note that the pkgbuild_sha256sum in the non-arm archlinux packages also doesnt match, but I cant figure out what modifications might be happening before that hash is calculated) 09:55 -!- pavel_ [~paveljani@79.98.72.176] has quit [Quit: Leaving] 10:18 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 10:28 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 10:28 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 10:28 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:28 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 10:42 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 245 seconds] 10:46 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:04 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:05 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:06 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 11:10 < morcos> gmaxwell: that -shrinkdebugfile is only defaulted on if no debug options are present, you don't think 9MB is enough then? 11:12 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 11:13 < gmaxwell> morcos: I know-- my though is that I've troubleshoot people on nodes that went out of sync two weeks before, and their log was full of connect/disconnect messages. Maybe you're right that 9MB is enough. I do sort of wish critical errors went into a seperate very low volume log that was never rotated. 11:14 < morcos> yeah i certainly don't mind doing more, was just tryign to make the patch as unobjectionable as possible 11:14 < gmaxwell> yea, it's fine. 11:33 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 11:44 < jonasschnelli> morcos: The new CWallet::IsChange() function does not work after a zapwallettx, right? 11:52 < morcos> hmm, jonasschnelli i think your question confused me. Isn't that function old? And I'm not very familiar with zapwallettx, so not really sure what it would do? 11:53 < jonasschnelli> morcos: I though it's a new one... I'm doing my bumpfee review pretty late. I know.. but I just had the feeling that detecting the change output based on the address book is kinda-bad 11:54 < jonasschnelli> Though,... is change when it's _not_ in the address book. I guess bumpfee should still work after a zapwallettx 11:54 < morcos> well as far as i can tell it doesn't really matter... the failure modes are : 1) it can't find change (or finds more than 1) and can't bump the tx or 2) it reduces another output to you instead of change, doesn't seem so bad 11:55 < jonasschnelli> Yes. Right. 11:56 < jonasschnelli> Have you guys already started working on the case where bumping requires new input? 11:56 < jonasschnelli> Like when you use subtractfeefromamount 11:56 < ryanofsky> have not done work on that 11:57 < jonasschnelli> ryanofsky: thanks for the info. Maybe its not worth the effort.. 11:57 < gmaxwell> being able to spend bumped outputs is more important in that case... since the bumps will tie up more inputs. 11:57 < morcos> I don't think that makes sense for combination with subtract fee from amount 11:58 < morcos> well at least i think we should more narrowly define what we are trying to accomplish wiht subtractfeefromamount anyway.. 11:58 < jonasschnelli> morcos: If you have a single input, assume 25BTC, and you spend the 25BTC with subtract-fee-from-amount you endup with a tx without change. 11:58 < morcos> it causes a lot of complication in the code when as far as i can tell the main use case is just send all this money over there 11:59 < jonasschnelli> I think its a fantastic feature (subtract fee from amount). 11:59 < morcos> yeah so the way to bump that is reduce the output in my opinion 11:59 < jonasschnelli> From other wallet uses-cases, I know that people are trying to send-out the wallet funds with often leaving some coins behind. 11:59 < morcos> yes, i agree thats a use case worse supporting 12:00 < morcos> but we use it in a more general sense... which is annoying... like reducing the outputs even further to give ourselves dust change if we would have had sub-dust change... see #9343 12:00 < gribble> https://github.com/bitcoin/bitcoin/issues/9343 | An error has occurred and has been logged. Please contact this bot's administrator for more information. 12:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:09 < jonasschnelli> Another wild thought,... we should probably reject self created transactions with absurde high fee during signrawtransaction (additional to ATM over sendrawtx) 12:17 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1ac878ace623...b68f898efa09 12:17 < bitcoin-git> bitcoin/master ac9a846 John Newbery: [Trivial] fix logging typo in FlushStateToDisk() 12:17 < bitcoin-git> bitcoin/master b68f898 Jonas Schnelli: Merge #9624: [Trivial] fix logging typo in FlushStateToDisk()... 12:17 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9624: [Trivial] fix logging typo in FlushStateToDisk() (master...TrivialTypo) https://github.com/bitcoin/bitcoin/pull/9624 12:19 < gmaxwell> morcos: there are a bunch of small issues, I need to find the branch and pick them up. It mishandles locked wallets (it should reject trying to import a private key when the wallet is locked), if you ask it to import a key without a birthday it just assumes now and can cause funds loss, it's easy to cause it to rescan everything when you didn't think it would... node out of comission for hours 12:19 < gmaxwell> ... 12:20 < morcos> right.. well nudge nudge, 0.14 is in the car with the engine running.. 12:29 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 12:29 < BlueMatt> gmaxwell: please at least file issues for known issues and ask to have them marked 0.14.... 12:31 < gmaxwell> sorry for whining, but I already opened an issue for one of them where I _need_ feedback before doing anything, and only morcos commented a bit. #9491 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/9491 | Importmulti api is confusing in a way that could lead to funds loss. · Issue #9491 · bitcoin/bitcoin · GitHub 12:31 < gmaxwell> this is not convincing me of the utility of opening more issues. 12:35 < BlueMatt> behind on things, sorry :/ 12:35 < BlueMatt> gmaxwell: opening issues gives us all a view into how close we are to release, and also ensures we dont end up with stuff outstanding until a day before rc 12:35 < BlueMatt> gmaxwell: there are multiple reasons to open issues 12:49 < gmaxwell> I don't disagree with anything you are saying there. This doesn't change that if you want people opening issues, you need to respond to the issues they open. Asking if fine too, but it will be ultimately ineffective if people feel that they're wasting their time. 12:51 < BlueMatt> sorry, somehow I had #9491 marked in my mental list of "oh, that one has an open pr for it to fix it already" 12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/9491 | Importmulti api is confusing in a way that could lead to funds loss. · Issue #9491 · bitcoin/bitcoin · GitHub 12:51 < BlueMatt> not sure how it got there, but it did 12:52 < gmaxwell> s/if fine/is fine/ 12:56 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Quit: DeepSpace took me hostage.] 12:56 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 12:57 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye] 13:05 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds] 13:08 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-qkkakdlcgrwhfvnf] has quit [Quit: Connection closed for inactivity] 13:12 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 13:37 -!- shesek [~shesek@bzq-84-110-53-53.cablep.bezeqint.net] has joined #bitcoin-core-dev 13:44 -!- handlex [~handlex@2804:14c:658f:4dc7:a455:df0e:bd33:b844] has joined #bitcoin-core-dev 14:08 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 14:08 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 14:08 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:10 -!- cryptapus is now known as cryptapus_afk 14:12 -!- handlex [~handlex@2804:14c:658f:4dc7:a455:df0e:bd33:b844] has quit [Quit: handlex] 14:16 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Quit: Leaving.] 14:16 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 14:19 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9626: Clean up a few CConnman cs_vNodes/CNode things (master...2017-01-remove-broken-unused-funcs) https://github.com/bitcoin/bitcoin/pull/9626 14:33 -!- handlex [~handlex@2804:14c:658f:4dc7:a455:df0e:bd33:b844] has joined #bitcoin-core-dev 14:38 -!- handlex [~handlex@2804:14c:658f:4dc7:a455:df0e:bd33:b844] has quit [Quit: handlex] 15:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:22 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: jnewbery] 15:27 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 258 seconds] 15:28 < cfields> BlueMatt: thanks for remembering those 15:28 < BlueMatt> can we mark #9622 as 0.14 since its a pretty big bugfix and isnt too complicated? 15:28 < gribble> https://github.com/bitcoin/bitcoin/issues/9622 | An error has occurred and has been logged. Please contact this bot's administrator for more information. 15:30 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 15:36 < cfields> agree 15:39 -!- douglas [bb7a3383@gateway/web/freenode/ip.187.122.51.131] has joined #bitcoin-core-dev 15:41 -!- douglas [bb7a3383@gateway/web/freenode/ip.187.122.51.131] has quit [Client Quit] 16:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 16:06 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 16:16 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 16:18 < jtimon> periodical reminder that #8855 is rebase 16:18 * jtimon ducks 16:18 < gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub 16:23 -!- owowo [ovovo@gateway/vpn/mullvad/x-qalwkplctdseibij] has quit [Ping timeout: 256 seconds] 16:23 < gmaxwell> but does it use a factory factory singleton? 16:28 -!- owowo [ovovo@gateway/vpn/mullvad/x-mqyqccidmwfluqiy] has joined #bitcoin-core-dev 16:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 16:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:00 -!- waxwing [~waxwing@14.165.235.227] has quit [Ping timeout: 258 seconds] 17:04 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has quit [Ping timeout: 258 seconds] 17:06 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has left #bitcoin-core-dev [] 17:17 -!- waxwing [~waxwing@14.167.14.13] has joined #bitcoin-core-dev 17:20 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 17:24 -!- owowo [ovovo@gateway/vpn/mullvad/x-mqyqccidmwfluqiy] has quit [Ping timeout: 255 seconds] 17:35 -!- owowo [ovovo@gateway/vpn/mullvad/x-xekpaunhlnijbsgm] has joined #bitcoin-core-dev 17:52 -!- echonaut1 [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 17:52 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 17:53 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-vtyuqvxchxwfrido] has joined #bitcoin-core-dev 17:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yzaepgpyjbetievf] has quit [Quit: Connection closed for inactivity] 18:05 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 18:12 < Chris_Stewart_5> what exactly is DEFAULT_BLOCK_PRIORITY_SIZE? Does this nodes will not relay blocks with low fee txs inside of it? 18:13 < sipa> If nodes would choose to not relay valid blocks, they'd choose to be forked off. 18:13 < sipa> it's a setting for the mining code 18:14 < Chris_Stewart_5> sipa: Yeah I guess it seems bizarre, I figured logic with building blocks would just be some sort of greedy algo and that would implicitly be enforced 18:14 < Chris_Stewart_5> unless there were no high fee txs 18:14 < sipa> Chris_Stewart_5: that's what we're doing in practice 18:14 < Chris_Stewart_5> I guess why do we need the constant then? 18:15 < sipa> but there is a legacy mining algorithm that uses BTC_days_destroyed per byte (confusingly named priority) as sorting criteria instead of feerate 18:16 < sipa> the DEFAULT_BLOCK_PRIORITY_SIZE value gives the default setting for -blockprioritysize (which defaults to 0), which sets the bytes of blockspace assigned to that algorithm 18:17 < Chris_Stewart_5> Interesting, thanks. So before a fee market was around we would favor old coins being spent for block inclusion instead of new ones? 18:18 < sipa> yup 18:20 < Chris_Stewart_5> Cool. Thanks! Always interesting to learn historical contexts around decisions. 18:38 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 18:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Client Quit] 18:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:30 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has quit [Read error: Connection reset by peer] 19:32 -!- kadoban_ [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 19:33 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 264 seconds] 19:33 -!- kadoban_ is now known as kadoban 20:03 < bitcoin-git> [bitcoin] jtimon opened pull request #9627: Remove extra nonce reset logic in IncrementExtraNonce (master...upstream-elements-unused-extranonce) https://github.com/bitcoin/bitcoin/pull/9627 20:05 -!- chris200_ [~chris2000@p5082A9D9.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:07 -!- chris2000 [~chris2000@p5082AC5A.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20:08 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has joined #bitcoin-core-dev 20:14 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.] 20:15 < luke-jr> jl2012: I think anti-replay isn't something specifically needed for HFs. need it without a HF in some cases too 20:59 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 21:00 -!- dermoth [~thomas@dsl-199-102-159-125.mtl.aei.ca] has quit [Read error: Connection reset by peer] 21:01 -!- dermoth [~thomas@dsl-199-102-159-125.mtl.aei.ca] has joined #bitcoin-core-dev 21:15 < jl2012> luke-jr: for example? 21:19 < luke-jr> Tx A=UTXO 1 used to pay 1someaddress2 (no change); Tx B=UTXO 1 and UTXO 2 used to pay 1someaddress2 and 1someaddress3 (no change; double-spend of Tx A); Tx A is mined; 1someaddress3 still needs to be paid, but there is no way to guarantee Tx A won't reorg out. 21:33 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 21:33 < jl2012> Just use the output of TxA to pay 21:34 < jl2012> Oh, no change 21:36 < jl2012> Just use UTXO2 to pay someaddress3 21:44 -!- Satoshi_ [4e6d2401@gateway/web/freenode/ip.78.109.36.1] has joined #bitcoin-core-dev 21:46 -!- Satoshi_ [4e6d2401@gateway/web/freenode/ip.78.109.36.1] has quit [Client Quit] 21:48 < luke-jr> jl2012: ok, but I think there are rare cases where there isn't such a solution :p 21:54 < luke-jr> Chris_Stewart_5: btw, note that priority sorting is not strictly historical, and is still is use by some miners. 22:10 < gmaxwell> luke-jr: what miner? 22:13 -!- waxwing [~waxwing@14.167.14.13] has quit [Ping timeout: 255 seconds] 22:16 -!- owowo [ovovo@gateway/vpn/mullvad/x-xekpaunhlnijbsgm] has quit [Ping timeout: 256 seconds] 22:18 -!- owowo [ovovo@gateway/vpn/mullvad/x-cmodcqlcpoqkdxit] has joined #bitcoin-core-dev 22:19 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 22:28 -!- waxwing [~waxwing@113.189.78.210] has joined #bitcoin-core-dev 23:06 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 23:10 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vwdipsulsjchcngd] has joined #bitcoin-core-dev 23:36 -!- PaulCape_ [~PaulCapes@204.28.124.82] has joined #bitcoin-core-dev 23:37 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:91a3:3218:d37d:fa08] has quit [Ping timeout: 255 seconds]