--- Day changed Sun Feb 05 2017 00:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 00:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 00:08 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 00:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 00:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 00:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:31 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xhuydojnqmctzxxh] has joined #bitcoin-core-dev 00:32 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 00:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 00:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:50 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 00:51 -!- Soligor [~Soligor@unaffiliated/soligor] has joined #bitcoin-core-dev 00:51 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 01:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:22 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 248 seconds] 01:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:43 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 01:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:09 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds] 02:40 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 02:42 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 252 seconds] 02:43 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:c8a0:c7ef:a5be:2617] has joined #bitcoin-core-dev 02:43 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 02:43 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 240 seconds] 02:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:45 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 02:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 02:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 03:15 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 03:29 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:46 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Quit: Leaving] 03:56 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 04:18 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 04:33 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:c8a0:c7ef:a5be:2617] has quit [] 05:22 -!- handlex [~handlex@2804:14c:658f:4dc7:71d8:86d6:d53b:5699] has joined #bitcoin-core-dev 05:29 -!- handlex [~handlex@2804:14c:658f:4dc7:71d8:86d6:d53b:5699] has quit [Quit: handlex] 05:32 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 05:58 -!- Giszmo [~leo@pc-165-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 06:06 -!- dcousens1 [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 06:06 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 264 seconds] 06:19 < luke-jr> qt/test/paymentservertests.cpp:65:6: warning: stack protector not protecting local variables: variable length buffer [-Wstack-protector] 06:19 < luke-jr> ^ are we trying to change these? 06:21 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Ping timeout: 264 seconds] 06:22 < gmaxwell> thats a dumb warning. 06:23 < gmaxwell> otoh we probably should avoid vararrays. 06:24 < gmaxwell> why is our configure scritpt ignoring CXXFLAGS ? :( 06:24 < gmaxwell> ah nevermind because it's failing. 07:20 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 07:37 -!- Giszmo [~leo@pc-165-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 07:52 -!- dcousens1 [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 240 seconds] 07:59 -!- chris200_ [~chris2000@p5DCB5293.dip0.t-ipconnect.de] has quit [] 08:03 -!- wvr [~wvr@8.red-88-8-194.dynamicip.rima-tde.net] has quit [Quit: Leaving] 08:05 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds] 08:30 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 08:31 -!- bsm1175321 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 08:32 -!- bsm1175321 is now known as bsm117532 08:53 < sipa> my bitcoind crashed due to a buffer overflow 08:59 < paveljanik> sipa, what commit hash? 08:59 < paveljanik> and how? 09:00 -!- protomar [~protomar@109.232.227.133] has joined #bitcoin-core-dev 09:19 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 09:20 -!- str4d [~str4d@host86-138-16-68.range86-138.btcentralplus.com] has joined #bitcoin-core-dev 09:39 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9691: Init ECC context for test_bitcoin_fuzzy. (master...fuzzy_initecc) https://github.com/bitcoin/bitcoin/pull/9691 09:39 -!- ill [~ill@32.210.34.9] has quit [Ping timeout: 248 seconds] 10:10 < sipa> paveljanik: unclesr 10:36 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:51 < jl2012> with master, I find that all tests with setup_clean_chain = False failed on my MAC OS 10.12.2 10:52 < jl2012> same error: Error loading block database. 10:57 < sipa> hmm 11:15 -!- jamezz [jamezz@gateway/shell/panicbnc/x-wvukrwtqnvcravta] has joined #bitcoin-core-dev 11:17 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 11:18 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 11:20 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 11:23 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds] 11:31 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 11:44 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 11:46 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 11:55 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 11:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:57 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 12:02 -!- alpalp [~alpalp@cpe-24-27-58-209.austin.res.rr.com] has joined #bitcoin-core-dev 12:02 -!- alpalp [~alpalp@cpe-24-27-58-209.austin.res.rr.com] has quit [Changing host] 12:02 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 12:08 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7821db30e161...923dc447eaa8 12:08 < bitcoin-git> bitcoin/master 003cd60 Matt Corallo: Add missing mempool lock for CalculateMemPoolAncestors 12:08 < bitcoin-git> bitcoin/master 923dc44 Pieter Wuille: Merge #9578: Add missing mempool lock for CalculateMemPoolAncestors... 12:08 < bitcoin-git> [bitcoin] sipa closed pull request #9578: Add missing mempool lock for CalculateMemPoolAncestors (master...2017-01-fix-missing-wallet-mempool-lock) https://github.com/bitcoin/bitcoin/pull/9578 12:24 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 12:31 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 12:46 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 12:47 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 12:49 -!- F0sea [~F0sea@185.86.151.126] has quit [Read error: Connection reset by peer] 12:50 -!- F0sea [~F0sea@176.223.111.92] has joined #bitcoin-core-dev 13:05 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 13:22 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds] 13:29 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 264 seconds] 13:33 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 13:39 -!- MarcoFalke_ [8af602fa@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.250] has joined #bitcoin-core-dev 13:39 < MarcoFalke_> jl2012: Try deleting the qa cache dir 13:39 -!- MarcoFalke_ [8af602fa@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.250] has quit [Client Quit] 13:40 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 13:50 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 13:58 -!- e4xit_ [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 14:10 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 14:18 -!- rickygee [~rickygee@209-55-74-65.gci.net] has joined #bitcoin-core-dev 14:23 -!- rickygee [~rickygee@209-55-74-65.gci.net] has quit [Quit: im not really sleeping everyone!] 14:26 -!- rickygee [~rickygee@mobile-166-176-187-119.mycingular.net] has joined #bitcoin-core-dev 14:27 -!- rickygee [~rickygee@mobile-166-176-187-119.mycingular.net] has quit [Read error: Connection reset by peer] 14:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 14:42 -!- protomar [~protomar@109.232.227.133] has quit [Quit: Leaving] 14:43 -!- danD [8e862e46@gateway/web/freenode/ip.142.134.46.70] has joined #bitcoin-core-dev 14:43 -!- profall [sid29922@gateway/web/irccloud.com/x-fjkiyuprpviisomj] has quit [Ping timeout: 252 seconds] 14:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:51 -!- danD [8e862e46@gateway/web/freenode/ip.142.134.46.70] has quit [Quit: Page closed] 15:03 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 15:08 -!- str4d [~str4d@host86-138-16-68.range86-138.btcentralplus.com] has quit [Ping timeout: 260 seconds] 15:08 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 15:26 < luke-jr> shoot. 15:26 < luke-jr> wumpus: we should have taken advantage of the named arguments to switch amounts to satoshis.. 15:27 * luke-jr wonders if we can get broad agreement that this would be okay to throw in now, considering if we don't, we'll be stuck supporting BTC values longer.. 16:16 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 276 seconds] 16:17 -!- Alina-malina [~Alina-mal@37.157.216.187] has joined #bitcoin-core-dev 16:33 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 16:39 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Ping timeout: 252 seconds] 16:42 -!- profall [sid29922@gateway/web/irccloud.com/x-awwxbycprzllsbcg] has joined #bitcoin-core-dev 16:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:18 -!- Alina-malina [~Alina-mal@37.157.216.187] has quit [Ping timeout: 252 seconds] 17:20 -!- Alina-malina [~Alina-mal@37.157.216.187] has joined #bitcoin-core-dev 17:26 -!- Alina-malina [~Alina-mal@37.157.216.187] has quit [Ping timeout: 245 seconds] 17:26 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 17:27 -!- Alina-malina [~Alina-mal@37.157.216.181] has joined #bitcoin-core-dev 17:38 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 18:07 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 252 seconds] 18:07 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xhuydojnqmctzxxh] has quit [Quit: Connection closed for inactivity] 18:30 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 18:31 < ossifrage> FYI, the usage for 'dumpwallet' really should say that the filename is an output file not an input file. I thought it was an 'input file' and you can imagine what happened... 18:39 < sipa> where is it called 'input file' ? 18:44 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 18:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:47 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 18:55 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9693: Prevent integer overflow in ReadVarInt. (master...varint_maxsize) https://github.com/bitcoin/bitcoin/pull/9693 19:02 < gmaxwell> morcos: did you see https://github.com/bitcoin/bitcoin/issues/9645 ? sounds like a good point... and probably easy to do. 19:32 -!- jamezz [jamezz@gateway/shell/panicbnc/x-wvukrwtqnvcravta] has quit [Ping timeout: 258 seconds] 19:41 -!- Creeper [jamezz@gateway/shell/panicbnc/x-ngmnilxkflzricvn] has joined #bitcoin-core-dev 19:52 -!- Creeper is now known as jamezz 19:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds] 20:00 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:36 < jl2012> MarcoFalke_: it works. Thanks 21:39 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 21:41 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 22:02 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 255 seconds] 22:09 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 22:19 -!- Alina-malina [~Alina-mal@37.157.216.181] has quit [Changing host] 22:19 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 22:24 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 22:46 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-eseuxaskjltevxaw] has joined #bitcoin-core-dev 23:46 < wumpus> luke-jr: how would you propose to do that? allow, say, either an argument amount=1.23 or an argument amount_int=123000000? 23:48 < luke-jr> wumpus: I would propose that whenever named params are used, amounts are always satoshis. 23:48 < sipa> i suggest we at some point introduce a global amount_unit, which modifies the units all amounts are accepted and shown in 23:48 < sipa> which can be done at any time, in a backward compatible way 23:48 < wumpus> sipa: I had a pull open for that at some point 23:48 < sipa> ah! 23:49 < luke-jr> there should be no existing code using named params right now, so there's no need to be "compatible" with fractional numbers 23:49 < wumpus> there were even four options - satoshis as number, satoshis as string, BTC as number, BTC as string 23:49 < wumpus> it could be set using a configuration option, everything using AMountFrom* and *ToAmount would use this 23:50 < sipa> wumpus: well we already support both strings and numbers everywhere, no? 23:50 < wumpus> hardly any interest, though, so eventually rotted and closed. I think despite being a favourite discussion topic for developers, very people are actually concerned about these units on the RPC interface 23:51 < sipa> agre 23:51 < wumpus> arguably interoperability is best by just allowing one representation 23:51 < wumpus> and yes, strings are allowed as inputs 23:51 < wumpus> it would apply to both inputs and outputs though 23:51 < wumpus> in any case I think this is abit of a non-issue 23:52 < luke-jr> so NACK for 0.14? :x 23:52 < wumpus> heh :) 23:52 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 23:52 < sipa> i think it's way too late to change that for 0.14, and given that we already support strings as amount... i'm not sure it's necessary at all 23:53 < wumpus> agree 23:53 < luke-jr> sipa: only reason to push for it in 0.14 is to avoid having to ever support BTC amounts in named-params mode for backwards compat 23:53 < wumpus> let's please not conflate named-param with any other interface change 23:53 < sipa> luke-jr: well we'll always have to support it in non-named-params anyway 23:54 < luke-jr> wumpus: ok, then my idea is controversial and not worth spending more time on 23:54 < wumpus> I mean imagine it from the user point of view, you decide to change your RPC binding to use named arguments, and suddenly you have to use different units! 23:54 < luke-jr> seems logical to me ☺