--- Day changed Tue Feb 07 2017 00:00 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:00 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:01 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Ping timeout: 258 seconds] 00:05 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 00:06 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 00:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:08 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 252 seconds] 00:12 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 00:15 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 00:17 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds] 00:26 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 00:28 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 00:29 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:29 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 00:29 -!- Evel-Laptop [~Evel-Knie@195.76.173.123] has joined #bitcoin-core-dev 00:39 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 00:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 00:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:59 -!- cysm [cysm@gateway/shell/elitebnc/x-oagklofqleqrlebb] has quit [Ping timeout: 240 seconds] 01:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:02 -!- cysm [cysm@gateway/shell/elitebnc/x-ujjzqkgrohzzyppg] has joined #bitcoin-core-dev 01:03 -!- AaronvanW [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:03 -!- AaronvanW [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has quit [Changing host] 01:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:04 -!- Aaronvan_ [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 01:12 -!- veleiro [~veleiro@fsf/member/veleiro] has quit [Remote host closed the connection] 01:22 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:27 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:27 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 01:45 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 01:46 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:48 < bitcoin-git> [bitcoin] laanwj opened pull request #9705: build: Add options to override BDB location (master...2017_02_bdb_location) https://github.com/bitcoin/bitcoin/pull/9705 01:50 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 02:32 -!- Evel-Laptop [~Evel-Knie@195.76.173.123] has quit [] 02:51 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 245 seconds] 02:53 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:38 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 03:43 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 04:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/02464da5e4aa...729de15b6365 04:04 < bitcoin-git> bitcoin/master dd5b011 John Newbery: [Trivial] add comment about setting peer as HB peer.... 04:04 < bitcoin-git> bitcoin/master 729de15 Wladimir J. van der Laan: Merge #9604: [Trivial] add comment about setting peer as HB peer.... 04:04 < bitcoin-git> [bitcoin] laanwj closed pull request #9604: [Trivial] add comment about setting peer as HB peer. (master...HBpeercomment) https://github.com/bitcoin/bitcoin/pull/9604 04:44 -!- harrymm [~wayne@104.207.83.31] has quit [Ping timeout: 260 seconds] 05:03 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 05:04 -!- harrymm [~wayne@191.96.49.161] has joined #bitcoin-core-dev 05:38 -!- crescend1 [~mozart@173.203.100.20] has quit [Ping timeout: 258 seconds] 05:55 -!- sanada` [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Read error: Connection reset by peer] 05:55 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 06:01 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:04 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:04 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:21 -!- trotski2000_ [uid206086@gateway/web/irccloud.com/x-wqhhdloywvcxxvjs] has quit [Changing host] 06:21 -!- trotski2000_ [uid206086@unaffiliated/trotski2000] has joined #bitcoin-core-dev 06:21 -!- trotski2000_ [uid206086@unaffiliated/trotski2000] has quit [Changing host] 06:21 -!- trotski2000_ [uid206086@gateway/web/irccloud.com/x-wqhhdloywvcxxvjs] has joined #bitcoin-core-dev 06:21 -!- trotski2000_ is now known as trotski2000 06:21 < bitcoin-git> [bitcoin] jnewbery opened pull request #9706: Remove unicode characters from RPC user and password in QA tests (master...rpctestuser) https://github.com/bitcoin/bitcoin/pull/9706 06:29 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/729de15b6365...b709fe7ffc44 06:29 < bitcoin-git> bitcoin/master ac4a095 practicalswift: Remove unused Python variables 06:29 < bitcoin-git> bitcoin/master 90fd29b practicalswift: Remove unused int64_t nSinceLastSeen 06:29 < bitcoin-git> bitcoin/master b709fe7 Wladimir J. van der Laan: Merge #9532: Remove unused variables... 06:29 < bitcoin-git> [bitcoin] laanwj closed pull request #9532: Remove unused variables (master...remove-unused-variables) https://github.com/bitcoin/bitcoin/pull/9532 07:19 < bitcoin-git> [bitcoin] sdaftuar closed pull request #9700: Cache segwit signature hash components inside CTransaction to optimize validation performance (master...2017-02-segwit-hash-cache-2) https://github.com/bitcoin/bitcoin/pull/9700 07:22 < bitcoin-git> [bitcoin] jnewbery opened pull request #9707: Fix RPC failure testing (master...rpctestassert) https://github.com/bitcoin/bitcoin/pull/9707 07:26 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9708: Clean Up all known races/platform-specific UB (master...2017-02-fix-copystats-races) https://github.com/bitcoin/bitcoin/pull/9708 07:29 < bitcoin-git> [bitcoin] jnewbery closed pull request #9706: Remove unicode characters from RPC user and password in QA tests (master...rpctestuser) https://github.com/bitcoin/bitcoin/pull/9706 07:34 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds] 07:52 < bitcoin-git> [bitcoin] fanquake closed pull request #9699: Remove contrib/debian/patches subdirectory (master...removedebpatches) https://github.com/bitcoin/bitcoin/pull/9699 08:10 < bitcoin-git> [bitcoin] sdaftuar opened pull request #9709: [WIP] Cache segwit signature hash components inside CTransactionRef to optimize validation performance (master...2017-02-segwit-cache-3) https://github.com/bitcoin/bitcoin/pull/9709 08:22 < bitcoin-git> [bitcoin] jnewbery opened pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (master...gettxoutproofhelp) https://github.com/bitcoin/bitcoin/pull/9711 08:38 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:39 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 09:05 -!- tunafizz [tunafizz@c-71-207-55-31.hsd1.pa.comcast.net] has quit [Read error: Connection reset by peer] 09:17 < Chris_Stewart_5> Do we limit the amount of sigops that can be in a tx *besides* the limitations of 201 script ops and 80000 sigop cost? 09:18 < Chris_Stewart_5> sigop cost for a block* 09:21 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:22 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 09:33 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:34 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:34 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:36 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 09:39 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 09:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] laanwj opened pull request #9712: bench: Fix initialization order in registration (master...2017_02_fiasco) https://github.com/bitcoin/bitcoin/pull/9712 10:22 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 10:27 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev 10:27 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Quit: leaving] 10:28 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 10:29 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Client Quit] 10:31 < bitcoin-git> [bitcoin] jnewbery opened pull request #9713: Fix error causes and messages in rpc/net.cpp (master...fixsetbanerrormessages) https://github.com/bitcoin/bitcoin/pull/9713 10:32 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 10:38 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 10:38 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 10:38 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 11:04 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 11:11 < BlueMatt> sipa: whats the point of invlockorders in sync.cpp? it looks entirely untested/unused-aside-from-insert/erase 11:14 < sipa> BlueMatt: yes, it's in order to implement DeleteLock 11:15 < BlueMatt> oh, i missed that its using it to delete from lockorders, sorry 11:16 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds] 11:38 < bitcoin-git> [bitcoin] jnewbery opened pull request #9714: Return correct error codes from bumpfee() (master...bumpfeeerrormessages) https://github.com/bitcoin/bitcoin/pull/9714 11:39 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:49 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:53 -!- crescendo [~mozart@unaffiliated/crescendo] has joined #bitcoin-core-dev 12:40 < gmaxwell> moments from the front lines: 12:40 < gmaxwell> 12:36 < gmaxwell> Dorian_: Is your wallet still syncing? 12:40 < gmaxwell> 12:37 < Dorian_> gmaxwell - yes but it says is gonna do it for 4 years (!) 12:44 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 12:54 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 245 seconds] 13:00 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 13:12 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 13:22 < achow101> what's the style for brackets and if statements? Is it bracket on same line, next line? brackets with single line ifs? 13:23 < Chris_Stewart_5> I think adam3us had a good point about exploits and single line ifs awhile back 13:26 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 13:30 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 13:31 < BlueMatt> achow101: if (rainbows && unicorns) { 13:31 < BlueMatt> magic(); 13:31 < BlueMatt> } 13:32 < achow101> cool. 13:39 < gmaxwell> I believe this is also permitted: if (rainbows && unicorns) magic(); < braceless but only if one line. 13:40 < BlueMatt> does mininode not support multiple simultaneous connections???? 13:40 < BlueMatt> sdaftuar, maybe? 13:40 < gmaxwell> what is no loger prermitted is: 13:40 < gmaxwell> if (dragons) 13:40 < gmaxwell> slay() 13:40 < gmaxwell> else 13:41 < gmaxwell> party(); 13:41 < gmaxwell> and similar things that have more ;. 13:41 < adam3us> Chris_Stewart_5 it was just a personal rant. have seen other things fail when the magic turns out to be a macro that wasnt defended by do { foo(); bar(); } while (0) and being #define magic() foo(); bar() and then bad bad things happening when an if is added 13:42 < achow101> ok. good to know. 13:43 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 13:43 < achow101> I was just doing changes and I noticed that the style for if statements is all over the place 13:45 < gmaxwell> yea, recent change. 13:46 < gmaxwell> (thank god) 13:46 < Chris_Stewart_5> If anyone needs inspiration for bad things you can do in C this is always fun to look at: https://en.wikipedia.org/wiki/Underhanded_C_Contest 13:49 < BlueMatt> heh, python is garbage....like all random python shit, asyncore decided you wanted magic to happen in the background so dont bother exposing the socket connected-ness until you send data on the socket 13:49 < BlueMatt> making it impossible to test disconnect by not sending anything 13:57 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:07 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 258 seconds] 14:39 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: jnewbery] 14:40 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 14:45 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (master...2017-02-disconnect-no-verack) https://github.com/bitcoin/bitcoin/pull/9715 15:01 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 245 seconds] 15:14 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 15:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 15:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 15:34 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:53 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 16:19 -!- Giszmo [~leo@ip-176-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 17:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:10 -!- Aaronvan_ [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has quit [] 17:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:23 < jtimon> BlueMatt: I don't have much experience with python asynchronous stuff without zmq/nanomsg, wouldn't touch lower level sockets in python :p 17:24 < jtimon> unless you're running some weird high performance experiment on pypy or something 17:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fmiakoefzyvisfsb] has quit [Quit: Connection closed for inactivity] 18:44 -!- goksinen [~goksinen@2604:2000:c591:8400:616f:47a6:f19e:fdce] has joined #bitcoin-core-dev 18:49 < bitcoin-git> [bitcoin] pstratem opened pull request #9716: [Net] Clarity TIMEOUT_INTERVAL constant meaning. (master...2017-02-07-ping-timeout-interval) https://github.com/bitcoin/bitcoin/pull/9716 19:06 -!- Kexkey [~kexkey@68.168.114.170] has joined #bitcoin-core-dev 19:18 < bitcoin-git> [bitcoin] jtimon opened pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717 19:33 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 19:38 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has quit [Quit: ZNC - 1.6.0 - http://znc.in] 19:40 -!- truquini_ [ac624337@gateway/web/freenode/ip.172.98.67.55] has joined #bitcoin-core-dev 19:40 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev 19:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b709fe7ffc44...d304fef37460 19:44 < bitcoin-git> bitcoin/master 29c5328 Wladimir J. van der Laan: bench: Fix initialization order in registration... 19:44 < bitcoin-git> bitcoin/master d304fef MarcoFalke: Merge #9712: bench: Fix initialization order in registration... 19:44 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9712: bench: Fix initialization order in registration (master...2017_02_fiasco) https://github.com/bitcoin/bitcoin/pull/9712 19:44 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 20:02 -!- goksinen [~goksinen@2604:2000:c591:8400:616f:47a6:f19e:fdce] has quit [Remote host closed the connection] 20:05 -!- truquini___ [uid211829@gateway/web/irccloud.com/x-xcxdqnsqlofdhble] has joined #bitcoin-core-dev 20:08 -!- truquini_ [ac624337@gateway/web/freenode/ip.172.98.67.55] has quit [Quit: Page closed] 20:10 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 245 seconds] 20:14 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 20:18 -!- Giszmo [~leo@ip-176-233.219.201.nextelmovil.cl] has quit [Quit: Leaving.] 20:22 < bitcoin-git> [bitcoin] luke-jr opened pull request #9718: Qt/Intro: Various fixes (master...intro_fixes) https://github.com/bitcoin/bitcoin/pull/9718 21:06 -!- randy-waterhouse [~kiwigb@43.228.156.102] has joined #bitcoin-core-dev 21:06 -!- randy-waterhouse [~kiwigb@43.228.156.102] has quit [Changing host] 21:06 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 21:24 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 21:34 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 252 seconds] 21:44 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 22:19 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 22:25 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 22:28 < bitcoin-git> [bitcoin] rebroad opened pull request #9719: Allow abortion of ConnectBlock() when shutdown requested. (master...AbortConnectBlockAtShutdown) https://github.com/bitcoin/bitcoin/pull/9719 22:29 -!- PaulCape_ [~PaulCapes@2604:5500:17:2ea:280e:4d78:25b6:9bea] has quit [Quit: .] 22:29 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 248 seconds] 22:32 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:855:1ecf:e67e:e3b7] has joined #bitcoin-core-dev 22:37 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 22:46 < bitcoin-git> [bitcoin] theuni opened pull request #9720: net: fix banning and disallow sending messages before receiving verack (master...fix-ban) https://github.com/bitcoin/bitcoin/pull/9720 22:47 < bitcoin-git> [bitcoin] rebroad opened pull request #9721: Headers announcement for nodes that can do headers. (master...AnnounceUsingHeaders) https://github.com/bitcoin/bitcoin/pull/9721 22:48 < bitcoin-git> [bitcoin] CryptAxe opened pull request #9722: GUI: Display warning when attempting address reuse (master...reuse) https://github.com/bitcoin/bitcoin/pull/9722