--- Day changed Wed Feb 15 2017 00:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:02 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:06 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 00:09 -!- bakunin [d95e26df@gateway/web/freenode/ip.217.94.38.223] has joined #bitcoin-core-dev 00:13 < bakunin> hiho, just wanted to say thank you, bitcoin core developers, you are doing an outstanding job.-Thank you very much. 00:14 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 260 seconds] 00:16 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 00:22 -!- windsok [~windsok@45.63.59.8] has quit [Remote host closed the connection] 00:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:23 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 00:24 < wump> good to hear that bakunin 00:24 -!- wump is now known as wumpus 00:28 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a441db01b527...4c69d683f22a 00:28 < bitcoin-git> bitcoin/master a47da4b practicalswift: Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0; 00:28 < bitcoin-git> bitcoin/master 4c69d68 Wladimir J. van der Laan: Merge #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0;... 00:28 < bitcoin-git> [bitcoin] laanwj closed pull request #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; (master...std-max) https://github.com/bitcoin/bitcoin/pull/9553 00:46 -!- bakunin [d95e26df@gateway/web/freenode/ip.217.94.38.223] has quit [Quit: Page closed] 00:47 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 01:38 -!- whphhg [whphhg@gateway/vpn/mullvad/x-bgbcohrphgxofpyu] has quit [Quit: Leaving] 01:49 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 02:12 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 02:14 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4c69d683f22a...d8e8b06bd065 02:14 < bitcoin-git> bitcoin/master a58370e Russell Yanofsky: Dedup nTimeFirstKey update logic... 02:14 < bitcoin-git> bitcoin/master a80f98b Russell Yanofsky: Use importmulti timestamp when importing watch only keys... 02:14 < bitcoin-git> bitcoin/master d8e8b06 Wladimir J. van der Laan: Merge #9108: Use importmulti timestamp when importing watch only keys (on top of #9682)... 02:14 < bitcoin-git> [bitcoin] laanwj closed pull request #9108: Use importmulti timestamp when importing watch only keys (on top of #9682) (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108 02:16 < Victorsueca> ^ about that, is the function to remove watch-only addresses from your wallet coming in the near future? 02:35 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 02:38 < bitcoin-git> [bitcoin] laanwj opened pull request #9764: wallet: Prevent "overrides a member function but is not marked 'override'" warnings (master...2017_02_wallet_inconsistent_missing_override) https://github.com/bitcoin/bitcoin/pull/9764 02:46 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 02:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 02:58 < wumpus> Victorsueca: depends on whether someone picks up https://github.com/bitcoin/bitcoin/pull/5525 02:58 < wumpus> Victorsueca: it needs rebase and needs tests 03:24 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:24 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Ping timeout: 252 seconds] 03:24 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 03:27 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 03:30 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 03:54 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:58 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:01 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 04:20 -!- Kexkey [~kexkey@23.227.207.26] has joined #bitcoin-core-dev 04:35 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 04:39 < BlueMatt> morcos: ahh, so you're saying people will import with dates that dont match block time, yea, ok, that sucks 04:40 < BlueMatt> would be nice if we had been using some mtp-or-hours-back rule to generate the birthdays to begin with :/ 04:40 < BlueMatt> oh well 04:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:54 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 04:55 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:56 < morcos> BlueMatt: ryanofsky suggested changing the way the wallet generates the key birthday to be MTP... i couldn't immediately see why that would be a problem.., but regardless i think we need the buffer for now 04:56 < BlueMatt> yes, well if users are going to get key birthdays from generated birthdays from old wallets then we're gonna need a buffer as long as they do that 04:57 < wumpus> in retrospect we should have used birth block number instead of birthdate 04:57 < BlueMatt> yes 04:57 < BlueMatt> usability issues with that if you're not syned, but, yes 04:57 < wumpus> the drawback is that then it's no longer possible to generate keys on hardware that has no block chain access 04:58 < wumpus> well no big one in that case, it'd just make the birth block a bit earlier 04:58 < jonasschnelli> but keys have timestamps as birthdays 04:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 04:58 < wumpus> yes, it's no longer possible to do that, that's why I said in retrospect 04:59 < wumpus> keeping a safety margin of 2 hours seems prudent to me 04:59 < BlueMatt> indeed 04:59 < jonasschnelli> Yes. 04:59 < jonasschnelli> I also mentioned this in the initial importmulti PR IIRC 05:00 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 05:00 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/7551#discussion_r80929574 05:02 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 05:09 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 05:13 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 05:18 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 05:18 < bitcoin-git> [bitcoin] NicolasDorier closed pull request #8460: Parametrize buried soft fork in regtest and refactor (master...buriedsf) https://github.com/bitcoin/bitcoin/pull/8460 05:21 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 252 seconds] 05:23 < bitcoin-git> [bitcoin] sdaftuar opened pull request #9765: Harden against mistakes handling invalid blocks (master...fix-checkblock-call) https://github.com/bitcoin/bitcoin/pull/9765 05:33 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 05:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:52 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 06:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 06:07 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 06:09 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has quit [Read error: Connection reset by peer] 06:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d8e8b06bd065...476cc47da084 06:09 < bitcoin-git> bitcoin/master 4b6cccc Jonas Schnelli: Selectively suppress deprecation warnings 06:09 < bitcoin-git> bitcoin/master 476cc47 Wladimir J. van der Laan: Merge #9758: Selectively suppress deprecation warnings... 06:09 < bitcoin-git> [bitcoin] laanwj closed pull request #9758: Selectively suppress deprecation warnings (master...2017/02/deprac_warns) https://github.com/bitcoin/bitcoin/pull/9758 06:10 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:11 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has joined #bitcoin-core-dev 06:12 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 06:19 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 06:26 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:47 -!- Giszmo [~leo@pc-165-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 06:48 -!- eminogrande [5df41e0b@gateway/web/cgi-irc/kiwiirc.com/ip.93.244.30.11] has joined #bitcoin-core-dev 07:00 -!- Kexkey [~kexkey@23.227.207.26] has quit [Ping timeout: 260 seconds] 07:02 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:05 -!- eminogrande [5df41e0b@gateway/web/cgi-irc/kiwiirc.com/ip.93.244.30.11] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 07:05 -!- eminogrande [b913c487@gateway/web/cgi-irc/kiwiirc.com/ip.185.19.196.135] has joined #bitcoin-core-dev 07:06 < bitcoin-git> [bitcoin] jnewbery opened pull request #9766: Add --exclude option to rpc-tests.py (master...rpctestexclude) https://github.com/bitcoin/bitcoin/pull/9766 07:10 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 07:13 -!- lejit [~lejit@185.86.151.126] has quit [Quit: Leaving] 07:21 -!- emzy_ is now known as emzy 07:21 -!- emzy [~quassel@2a03:f80:ed15:158:ba27:ebff:fe5d:813c] has quit [Changing host] 07:21 -!- emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-dev 07:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:28 -!- laurentmt1 [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:29 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/476cc47da084...7a93af8340d9 07:29 < bitcoin-git> bitcoin/master 9acf25c Russell Yanofsky: Return error when importmulti called with invalid address.... 07:29 < bitcoin-git> bitcoin/master 7a93af8 Wladimir J. van der Laan: Merge #9756: Return error when importmulti called with invalid address.... 07:30 < bitcoin-git> [bitcoin] laanwj closed pull request #9756: Return error when importmulti called with invalid address. (master...pr/multiaddr) https://github.com/bitcoin/bitcoin/pull/9756 07:31 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Ping timeout: 258 seconds] 07:31 -!- laurentmt1 is now known as laurentmt 07:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:44 -!- tan1k [~tan1k@185.86.151.126] has joined #bitcoin-core-dev 07:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 07:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:53 -!- Guest74962 [~senior@213.59.130.219] has joined #bitcoin-core-dev 07:53 < Guest74962> hey 07:53 -!- Aaronvan_ [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has quit [] 07:55 -!- Guest74962 [~senior@213.59.130.219] has left #bitcoin-core-dev ["Leaving"] 07:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:59 -!- senior1 [~senior@213.59.130.219] has joined #bitcoin-core-dev 07:59 -!- senior1 [~senior@213.59.130.219] has quit [Client Quit] 07:59 -!- senior1 [~senior@213.59.130.219] has joined #bitcoin-core-dev 07:59 -!- senior2 [~senior@213.59.130.219] has joined #bitcoin-core-dev 07:59 -!- senior1 [~senior@213.59.130.219] has quit [Client Quit] 07:59 -!- senior2 [~senior@213.59.130.219] has quit [Client Quit] 08:00 -!- senior1 [~senior@213.59.130.219] has joined #bitcoin-core-dev 08:00 -!- senior1 [~senior@213.59.130.219] has left #bitcoin-core-dev [] 08:00 -!- senior1 [~senior@213.59.130.219] has joined #bitcoin-core-dev 08:00 -!- senior1 [~senior@213.59.130.219] has quit [Client Quit] 08:01 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 08:06 -!- laurentmt1 [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:08 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Ping timeout: 256 seconds] 08:08 -!- laurentmt1 is now known as laurentmt 08:08 -!- wasi_ [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds] 08:10 -!- senior1 [~senior@213.59.130.219] has joined #bitcoin-core-dev 08:17 < morcos> wumpus: can we powwow on what we want to do about importmulti and pruned nodes? 08:17 < morcos> you mentioned its the same issues as importwallet, but that is just disabled for pruned nodes, importmulti isn't 08:18 -!- senior1 [~senior@213.59.130.219] has left #bitcoin-core-dev ["Leaving"] 08:18 -!- senior1 [~senior@213.59.130.219] has joined #bitcoin-core-dev 08:18 < wumpus> importmulti should ideally work when using timestamps more recent than what is pruned 08:18 -!- wasi_ [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 08:18 < morcos> i think right now it'll mostly silently fail if you importmulti with a key timestamp before your earliest on disk block... (looks to me like ReadBlockFromDisk will fail and error to debug log, but rescan should keep chugging along until it finds blocks) 08:19 < morcos> right, agreed. 08:19 < wumpus> if that is broken then I'd say disable it for 0.14 and worry about it later 08:19 < morcos> but important enough to fix that for 0.14? 08:19 < morcos> ah ok, that was the question 08:19 < morcos> so just disable importmulti for pruned nodes altogether for 0.14, then fix properly later 08:19 -!- senior1 [~senior@213.59.130.219] has quit [Client Quit] 08:19 < morcos> that seems reasonable to me.. gmaxwell or sipa any serious objections? 08:20 < wumpus> my mention about the problem being the same as for importwallet was about the 2-hour grace period, we had that for importwallet and I think it should be the same for importmulti 08:21 < wumpus> no matter how that interacts with nodes that have just pruned those two hours, it should just be documented that the grace period is there and blocks should exist for its duration until now 08:21 < wumpus> but anyhow if importmulti doesn't even throw an error when there's not enough block data then disabling it would be better 08:21 < morcos> right.. it's a separate edge case to be solved later if your last non-pruned block falls in the grace period. 08:21 < wumpus> I'd assume the ReadBlockFromDisk error would not be ignored 08:22 < morcos> just from a quick read my guess is it does not error, but i have not tried anything... 08:22 < morcos> yeah i agree thats a problem, b/c you could think you have all the funds and not 08:24 -!- thestrin1puller is now known as thestringpuller 08:24 -!- thestringpuller [~stevie@ec2-52-3-128-9.compute-1.amazonaws.com] has quit [Changing host] 08:24 -!- thestringpuller [~stevie@unaffiliated/thestringpuller] has joined #bitcoin-core-dev 08:25 < wumpus> yes, silently missing blocks is a very bad 08:28 < wumpus> important disctinction: importprivkey is only disabled in pruning mode when a rescan is requested 08:28 < wumpus> probably should be the same for importmulti then, it should bark when any keys are not 'now', otherwise it'd lose functionality compared to importprivkey 08:34 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 240 seconds] 08:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 08:46 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:52 < bitcoin-git> [bitcoin] jaladin1222 opened pull request #9767: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/9767 08:58 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 09:03 -!- laurentmt1 [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:05 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Ping timeout: 240 seconds] 09:05 -!- laurentmt1 is now known as laurentmt 09:31 < bitcoin-git> [bitcoin] sipa closed pull request #9767: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/9767 09:48 < bitcoin-git> [bitcoin] jnewbery opened pull request #9768: [qa] [WIP] Add logging to test_framework.py (master...rpctestlogging) https://github.com/bitcoin/bitcoin/pull/9768 09:50 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 09:57 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 09:57 -!- Arvidt_ [~Arvidt@p5B2AB5DF.dip0.t-ipconnect.de] has left #bitcoin-core-dev [] 09:58 < gmaxwell> wumpus: it should only be disabled where the rescan would scan pruned blocks... that is really the only utility in having the timestamps at all. 09:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:00 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 10:00 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:05 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 10:19 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:24 -!- Kexkey [~kexkey@23.227.207.22] has joined #bitcoin-core-dev 10:31 -!- eminogrande [b913c487@gateway/web/cgi-irc/kiwiirc.com/ip.185.19.196.135] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 10:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 10:56 < ryanofsky> gmaxwell, are you talking about a preemptive check? would there be any problem with importing the keys then throwing an exception saying import succeeded, but some blocks were not present and some transactions might be missing? 10:58 < ryanofsky> also i don't understand what's wrong with the suggestion from wumpus to just forbid rescan=True on pruned nodes 10:59 < gmaxwell> Because it guts the utility of pruning, when you lose major functionality outright just because you were so foolish as to not waste 100GB of diskspace. 10:59 < gmaxwell> Esp because rescans of the whole chain take hours, so it's not like they were even all that usable (except in emergencies) in any case. 10:59 < gmaxwell> As far as after the fact, I think that would be way less bad than denying it completely. 11:00 < gmaxwell> it would be best to deny it first but the way importmulti is constructed makes that harder to implement. 11:00 < ryanofsky> oh ok, i got that part, i didn't understand what you were saying about the defeating the "utility of timestamps" 11:03 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 11:06 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:10 < gmaxwell> Bascially the only good timestamps do is that they let you import a key without reading all the blocks. (scanning extra blocks is something no one would care about.) If pruning is prevented then you do save some rescan time, but still take on the 100GB of cost, -- this is a major barrier for people doing their own payment processing on VPSes. 11:11 < gmaxwell> The workflow there is that they have a payment processing front end which generates keys using BIP32 public derrivation, and then imports the addresses. Because of contingencies around multiple nodes and restarts they may need to rescan a bit. The imported keys are used to watch for payments so they can display status to the user. 11:11 < gmaxwell> The actual private keys are not put onto the VPS systems, for obvious reasons. :) 11:13 < gmaxwell> The alternative to this setup is to use a third party payment processor. But this has the downside of introducing trust where it could be avoided, and all the major processors are known to capricious shut down merchants or block customers on the basis of flimsy risk (that they piss off banks or regulators) analysis. 11:13 < gmaxwell> (and, of course, the systemic risk created by those processors holding large amounts of customer funds). 11:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 11:17 < bitcoin-git> [bitcoin] jnewbery opened pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770 11:17 < bitcoin-git> [bitcoin] jnewbery closed pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770 11:18 < ryanofsky> ok this use both requires import timestamps and pruning, makes sense 11:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:19 < gmaxwell> the other somewhat related bug is that even when you don't import a private key, it requires that the wallet be unlocked. 11:20 < gmaxwell> the same design make it difficult to reject the rpc based on the arguments. 11:21 < bitcoin-git> [bitcoin] jnewbery reopened pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770 11:38 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 11:40 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:49 -!- wasi_ is now known as wasi 12:46 < cfields> gmaxwell: I'm going to add a little blurb about the net speedup in the changelog. I think i remember you mentioning you'd prefer to see some sort of "validation improvements" or "ibd speedups" section, which may be a more useful way to describe it? 13:14 < morcos> Should we be making it so POTENTIAL DEADLOCK DETECTED's are elimintated or is it impossible to eliminate them all 13:15 < morcos> I was just trackign down what caused one and I think its not an issue, but is there somehwere I should comment what caused it, or should we actually change the code to not lock incorrectly 13:15 < morcos> i'm just not very familar with DEBUG_LOCKORDER 13:16 < sipa> i think we can replace it with tsan soon 13:16 < sipa> and/or helgrind 13:16 < morcos> This particular case is the loading of a wallet can call Mark Conflicted, which causes cs_wallet then cs_main which is the opposite order it happens elsewhere 13:17 < sipa> what is the other case? 13:17 < morcos> we have tons of LOCK2(cs_main, cs_wallet)'s 13:18 < morcos> i was assuming this isn't a problem b/c the wallet loading is done before other threads are spun up, but maybe thats actually not right? 13:18 < sipa> well the only question is whether those 2 orders can occur simultaneously 13:19 < morcos> yes thats what i mean, can anything else happen while the wallet is still loading? 13:21 < morcos> dpesm 13:21 < morcos> oops 13:21 < morcos> doesn't look like it i suppose... 13:24 < sipa> regardless, i think we should have consistent lock orders everywhere 13:24 < sipa> i'd say all those LOCK2(cs_main, cs_wallet)s can be swapped 13:25 < morcos> yikes!! 13:25 < sipa> wallet should call main, not the other way around IMHO 13:25 < morcos> i bet several of them are reentrant 13:25 < morcos> main is already held before we get there 13:25 < sipa> well, that's the issue then 13:25 < sipa> main shouldn't be held while calling wallet code 13:26 < morcos> :) we're working on it! see #9725 13:26 < gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub 13:27 < sipa> great 13:29 < morcos> hmm 13:29 < morcos> it assert fails when you have a potential deadlock? 13:30 < morcos> so this must have been somehow recently introduced? 13:41 < cfields> mm, I'm going to go ahead and PR some mutex cleanups I've been waiting on for a while. I'm going to start moving the net code towards non-recursive locks. Would you guys prefer a generic LOCK(cs) that takes any mutex, or NON_RECURSIVE_LOCK(cs) as a form of self-documentation? 14:00 < morcos> so... what should i do about this stupid deadlock warnign for now? seems like it might annoy someone else.. but only obvious fix i could see would be holding cs_main for all of loadwallet. its not immediately apparent to me whether that is bad? 14:01 < morcos> eh.. i'll move on and make an issue.. if you have a clean wallet, i think the problem goes away 14:08 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9771: Add missing cs_wallet lock that triggers new lock held assertion (master...pr/loadlock) https://github.com/bitcoin/bitcoin/pull/9771 14:19 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9773: WIP: Return errors from importmulti if complete rescans are not successful (master...pr/multicheck) https://github.com/bitcoin/bitcoin/pull/9773 14:21 -!- chjj_ [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:24 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 14:31 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 14:45 < bitcoin-git> [bitcoin] pstratem closed pull request #9762: Add txdetails parameter to getblock. (master...2017-02-14-getblock-includetxs) https://github.com/bitcoin/bitcoin/pull/9762 15:14 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:17 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: jnewbery] 15:19 -!- chjj_ is now known as chjj 15:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 16:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:48 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:21 < bitcoin-git> [bitcoin] jmcorgan opened pull request #9774: Enable host lookups for -proxy and -onion parameters (master...hostname-lookups) https://github.com/bitcoin/bitcoin/pull/9774 17:27 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 17:41 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 17:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-txxyzrrphgfzfnlk] has quit [Quit: Connection closed for inactivity] 18:11 -!- chjj [~chjj@unaffiliated/chjj] has quit [Remote host closed the connection] 19:10 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 19:11 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 276 seconds] 19:57 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 19:58 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:03 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 20:07 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 20:16 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.93 [Firefox 51.0.1/20170125094131]] 20:19 -!- roasbeef_ is now known as roasbeef 20:53 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Read error: Connection reset by peer] 20:54 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 21:33 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 21:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:58 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 22:00 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:23 -!- Victor_sueca is now known as Victorsueca 22:31 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev 22:42 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mcwlvhhhzhjdxugw] has joined #bitcoin-core-dev 23:18 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Ping timeout: 260 seconds] 23:19 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 23:37 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]