--- Day changed Wed Feb 22 2017 00:00 < luke-jr> because LXC historically has required root 00:00 < wumpus> jonasschnelli: spinning up a fully featured LXC container requires root 00:00 < jonasschnelli> okay... I see. 00:00 < wumpus> this is because the user creating the LXC container will be root in the container (without capabilities), which can be somewhat dangerous if there are security bugs in the kernel 00:01 < luke-jr> (which there have been) 00:01 < wumpus> and indeed as luke-jr says it is possible on more recent kernels to create a user LXC, but these have a few restrictions which I'm fairly sure we can't cope with right now 00:01 < jonasschnelli> it's not just lxc-start and lxc-execute that requires root? 00:01 < wumpus> it's just those no 00:02 < wumpus> no->two 00:02 < wumpus> maybe only lxc-execute 00:02 < wumpus> not sure. I think there's an example of editing your sudoers file to allow this in gitian-building? 00:02 < jonasschnelli> Yes. I have set those... still got the sudo promot 00:03 < jonasschnelli> Ah! Wrong machine... damit 00:03 < jonasschnelli> Can we have different shell background colors per host?! 00:04 < wumpus> jonasschnelli: I have different prompt colors per host 00:04 < wumpus> (even a script to randomly generate them :-) 00:04 < jonasschnelli> wumpus: That is very clever... I need to do this as well... 00:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:05 < wumpus> https://gist.github.com/laanwj/3c8c116fc763a149842a07070ca4d6cd 00:06 < jonasschnelli> wumpus: thanks! 00:06 < wumpus> setting terminal background is more involved; you can set it with the same escape sequences, however many programs will reset the background 00:07 < jonasschnelli> I think the background switch should be done on the client side... but the prompt is good enought 00:08 < wumpus> fairly sure tmux and some terminal emulators such as gnome=terminal have the option of having different profiles, so you could e.g. launch a different profile before ssh'ing. But yeah too much hassle 00:08 < luke-jr> deterministic generation might be more useful 00:08 < wumpus> KDE term had/has a nice feature where you could set an icon for the tab too 00:09 < wumpus> luke-jr: but some combinations are ugly, so I determine them once when setting up the host then just write that into ~/.profile 00:09 < luke-jr> too bad there's not a nice way to have it colour differently for local vs remote 00:11 < wumpus> yes I started doing this consistently after shutting down the wrong host one time too many :-) 00:12 < luke-jr> I disabled the rm command for root, and alias'd it with -i for my normal user :p 00:12 < wumpus> that's a good idea. Some historical UNIXes had that as default IIRC 00:13 < wumpus> well the -i thing. Don't know about disabling rm completely 00:25 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 00:29 < Victorsueca> is there going to be a 0.14.0rc2 or is the rc1 definitive so far unless a critical issue appears in the wild? 00:29 < wumpus> there have already been some issues to warrant rc2 00:30 < wumpus> for example #9810 00:30 < gribble> https://github.com/bitcoin/bitcoin/issues/9810 | 0.14 not loading mempool.dat? · Issue #9810 · bitcoin/bitcoin · GitHub 00:32 < jonasschnelli> Gitian does by default avoid recompiling the dependencies on every build? Right? 00:32 < wumpus> and #9817 00:32 < gribble> https://github.com/bitcoin/bitcoin/issues/9817 | Fix segfault crash when shutdown the GUI in disablewallet mode by jonasschnelli · Pull Request #9817 · bitcoin/bitcoin · GitHub 00:32 < wumpus> jonasschnelli: yes, the dependency caching system should make sure of that 00:33 < Victorsueca> ahh how not, it had to be yet another thing windows copied and changed slightly to make it incompatible 00:33 < wumpus> it will recompile if either the dependency definitions changed, or the compilation environment changed 00:33 < Victorsueca> such CRLF 00:33 < jonasschnelli> I wonder why that crash (https://github.com/bitcoin/bitcoin/issues/9814) happens 00:33 < wumpus> Victorsueca: yep :/ the DOS legacy in this case 00:34 < wumpus> jonasschnelli: yes it's weird 00:35 < wumpus> jonasschnelli: it happens deep in the bowels of qt, in the X platform handling 00:35 < jonasschnelli> Yes. Looks like. 00:36 < jonasschnelli> I wonder if he would get the same crashed building 0.13.1 (I would say so). 00:36 < jonasschnelli> *crashes 00:36 < wumpus> jonasschnelli: weird. it looks like both Thread 1 and Thread 2 are in libqxcb.so 00:37 < wumpus> is some auxiliary thread trying to do rendering / change the GUI? 00:38 < wumpus> ok on the other hand this is just "xcb_wait_for_event" so probably this is just the event loop 00:38 < wumpus> no, doesn't seem worrying 00:40 < wumpus> the traceback of Thread 1 is completely Qt and upstream libraries - none of our own code 00:40 < jonasschnelli> wumpus: I can't find any link between the crash(es) and our code in both stack traces 00:40 < jonasschnelli> I think we should recommend to try to compile against a different Qt version 00:41 < wumpus> thread 1 is the GUI thread so should be the only one that matters here 00:41 < wumpus> so this is either a race with cleaning up objects (deleteLater or such), or something in Qt/X11 itself. I suspect the second as it happens in the X library not in Qt. 00:42 < wumpus> cfields: didn't we have some scary xcb compatibility issues before? 00:43 < cfields> wumpus: heh, i was just clicking the above link with the same thought 00:43 < cfields> wumpus: only applies to static qt builds 00:43 < cfields> (it's qt's internal x stubs that cause that issue) 00:44 < cfields> it's possible that qt manages to crash there in some ugly way if there's no display plugin available, though 00:46 < cfields> (i haven't read the logs yet, if bitcoin-qt launches at all obviously that's not the culprit) 00:46 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 00:48 < cfields> wumpus: there was a touchscreen bug like that that rings a bell, though 00:48 < cfields> wacom, iirc 00:51 -!- wvr [~wvr@35.red-79-152-21.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 00:53 < cfields> headed to bed, nnite 01:01 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 01:11 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 01:13 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wamzzgyaxfozzoym] has joined #bitcoin-core-dev 01:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9823: qa: Set correct path for binaries in rpc tests (master...Mf1702-qaPath) https://github.com/bitcoin/bitcoin/pull/9823 02:05 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 02:08 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 02:18 < jonasschnelli> wumpus: F.Y.I: "%sudo ALL=NOPASSWD: /usr/bin/lxc-execute" hasn't worked for me... I had to allow it per user "jonasschnelli ALL=NOPASSWD:/usr/bin/lxc-execute". 02:19 < wumpus> strange. It does seem to be the right syntax 02:20 < jonasschnelli> The goup or per user line? 02:20 < wumpus> oh, you're not in the sudo group? 02:20 < wumpus> both 02:20 < jonasschnelli> Ah... yes.. that could be the issue.. :) 02:22 < jonasschnelli> Do I need to assign the LXC container specific amount of ram? Or does it share it with the host? 02:22 < jonasschnelli> I try now -j5 02:22 * jonasschnelli needs to go afk 02:23 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9824: qa: Check return code when stopping nodes (master...Mf1702-qaRet) https://github.com/bitcoin/bitcoin/pull/9824 02:23 -!- city22 [~textual@210.13.244.130] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 02:26 < wumpus> jonasschnelli: LXC limits work in a different way, I've never set any at least 02:27 < MarcoFalke> wumpus: Can you add jnewbery_ to the list of members on github? 02:28 < MarcoFalke> Maybe also ryanofsky 02:28 < wumpus> yes, good idea 02:31 < wumpus> ok invited both to bitcoin and bitcoin-core 02:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:35 < wumpus> re: release notes, would it make sense to group the two qt debug console changes? 02:36 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 02:36 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:37 < wumpus> I mena "Nested RPC Commands in Debug Console" and "Sensitive Data Is No Longer Stored In Debug Console History" 02:37 < wumpus> we also have "GUI Changes" 02:37 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 02:38 < Victorsueca> that's a nice thing, I used to CTRL+L after typing sensitive data 02:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:42 < wumpus> yes, it's certainly a nice thing, it's just spread out a bit haphazardly 02:42 < wumpus> in the release notes 02:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5628c70f2a44...92dd6c8dfdd6 02:49 < bitcoin-git> bitcoin/master a87d02a Marko Bencun: use EXIT_ codes instead of magic numbers... 02:49 < bitcoin-git> bitcoin/master 92dd6c8 Wladimir J. van der Laan: Merge #9815: Trivial: use EXIT_ codes instead of magic numbers... 02:49 < bitcoin-git> [bitcoin] laanwj closed pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (master...exitcode) https://github.com/bitcoin/bitcoin/pull/9815 02:52 -!- chjj_ [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 03:09 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 03:12 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 03:13 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 03:14 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/92dd6c8dfdd6...5b583efaa721 03:14 < bitcoin-git> bitcoin/master 3b4dd2a Peter Todd: Add seed.btc.petertodd.org to mainnet DNS seeds 03:14 < bitcoin-git> bitcoin/master 5b583ef Wladimir J. van der Laan: Merge #9805: Add seed.btc.petertodd.org to mainnet DNS seeds... 03:15 < bitcoin-git> [bitcoin] laanwj closed pull request #9805: Add seed.btc.petertodd.org to mainnet DNS seeds (master...2017-02-add-pt-mainnet-seed) https://github.com/bitcoin/bitcoin/pull/9805 03:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b583efaa721...a8c575103815 03:18 < bitcoin-git> bitcoin/master eaea2bb gubatron: Removed redundant parameter from mempool.PrioritiseTransaction... 03:19 < bitcoin-git> bitcoin/master a8c5751 Wladimir J. van der Laan: Merge #9801: Removed redundant parameter from mempool.PrioritiseTransaction... 03:19 < bitcoin-git> [bitcoin] laanwj closed pull request #9801: Removed redundant parameter from mempool.PrioritiseTransaction (master...refactor-mempool-prioritisetx) https://github.com/bitcoin/bitcoin/pull/9801 03:43 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8c575103815...ba7220b5e82f 03:43 < bitcoin-git> bitcoin/master e2e2f4c Russell Yanofsky: Return errors from importmulti if complete rescans are not successful 03:43 < bitcoin-git> bitcoin/master ba7220b Wladimir J. van der Laan: Merge #9773: Return errors from importmulti if complete rescans are not successful... 03:43 < bitcoin-git> [bitcoin] laanwj closed pull request #9773: Return errors from importmulti if complete rescans are not successful (master...pr/multicheck) https://github.com/bitcoin/bitcoin/pull/9773 03:49 -!- dodomojo [~goksinen@2604:2000:c591:8400:2538:79aa:5ecc:b8de] has joined #bitcoin-core-dev 03:59 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/9072395e5fddb1f2590138a179ab0868646a38a0 03:59 < bitcoin-git> bitcoin/0.14 9072395 Russell Yanofsky: Return errors from importmulti if complete rescans are not successful... 03:59 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 04:02 -!- chjj_ [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 04:02 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ba7220b5e82f...1efc99c4dc4d 04:02 < bitcoin-git> bitcoin/master bc8fd12 Alex Morcos: Remove harmless read of unusued priority estimates 04:02 < bitcoin-git> bitcoin/master 1efc99c Wladimir J. van der Laan: Merge #9819: Remove harmless read of unusued priority estimates... 04:02 < bitcoin-git> [bitcoin] laanwj closed pull request #9819: Remove harmless read of unusued priority estimates (master...removeExtraRead) https://github.com/bitcoin/bitcoin/pull/9819 04:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1efc99c4dc4d...bed5b30a5622 04:04 < bitcoin-git> bitcoin/master 9949ebf John Newbery: [Trivial] Remove incorrect help message from gettxoutproof() 04:04 < bitcoin-git> bitcoin/master bed5b30 Wladimir J. van der Laan: Merge #9711: [Trivial] Remove incorrect help message from gettxoutproof()... 04:04 < bitcoin-git> [bitcoin] laanwj closed pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (master...gettxoutproofhelp) https://github.com/bitcoin/bitcoin/pull/9711 04:18 -!- vicenteH [~user@96.235.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:19 -!- dodomojo [~goksinen@2604:2000:c591:8400:2538:79aa:5ecc:b8de] has quit [Remote host closed the connection] 04:27 -!- wvr [~wvr@35.red-79-152-21.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 04:35 -!- marcoagner [~marcoagne@177.41.200.65] has joined #bitcoin-core-dev 04:37 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-djsfrrwehidyodxd] has quit [Ping timeout: 252 seconds] 04:37 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-oepctolwhwmgclmb] has quit [Ping timeout: 252 seconds] 04:38 -!- mariorz [sid490@gateway/web/irccloud.com/x-lpkbjmgluysqxhtf] has quit [Ping timeout: 252 seconds] 04:39 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-hhfmtunbajumomtq] has joined #bitcoin-core-dev 04:40 -!- marcoagner [~marcoagne@177.41.200.65] has quit [Ping timeout: 240 seconds] 04:40 -!- mariorz [sid490@gateway/web/irccloud.com/x-avstmdbtdmbvrdok] has joined #bitcoin-core-dev 05:04 -!- xHire [~xHire@kos.paskuli.cz] has quit [Quit: No Ping reply in 180 seconds.] 05:04 -!- Cory [~Cory@unaffiliated/cory] has quit [Remote host closed the connection] 05:05 -!- xHire [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 05:07 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 05:13 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-pjwuluufeiymcfea] has quit [Ping timeout: 252 seconds] 05:14 -!- Pasha is now known as Cory 05:14 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-iftxkrupbolzykki] has joined #bitcoin-core-dev 05:33 -!- aguycalled [~aguycalle@37.120.75.4] has joined #bitcoin-core-dev 05:35 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-hhfmtunbajumomtq] has quit [Ping timeout: 240 seconds] 05:35 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-zxnqqxtfcsgjdmgi] has joined #bitcoin-core-dev 05:40 -!- aguycalled [~aguycalle@37.120.75.4] has quit [Read error: Connection reset by peer] 05:40 -!- jnewbery_ [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 05:40 -!- aguycalled [~aguycalle@37.120.75.4] has joined #bitcoin-core-dev 05:41 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:41 -!- whphhg [whphhg@gateway/vpn/mullvad/x-jpgdxnhncnkcyckv] has joined #bitcoin-core-dev 05:58 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 05:59 -!- chjj_ [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 06:02 -!- Alina-malina_ [~Alina-mal@37.157.216.146] has joined #bitcoin-core-dev 06:05 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:05 -!- Alina-malina_ [~Alina-mal@37.157.216.146] has quit [Changing host] 06:05 -!- Alina-malina_ [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 06:05 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:06 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 260 seconds] 06:06 -!- Alina-malina_ is now known as Alina-malina 06:06 -!- Guest42592 [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds] 06:08 -!- chjj_ [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 06:09 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 06:09 -!- chjj_ [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 06:10 -!- aguycalled [~aguycalle@37.120.75.4] has quit [Read error: Connection reset by peer] 06:13 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds] 06:15 -!- aguycalled [~aguycalle@37.120.75.4] has joined #bitcoin-core-dev 06:15 -!- abhishekcs10_ [uid170963@gateway/web/irccloud.com/x-yhrakgkmywphblwr] has joined #bitcoin-core-dev 06:16 < abhishekcs10_> Hello everyone :) 06:16 < abhishekcs10_> I am new to bitcoin and eager to learn about it. 06:19 -!- lopp [ac7c6953@gateway/web/freenode/ip.172.124.105.83] has joined #bitcoin-core-dev 06:20 < lopp> I recently pulled down the changes for Bitcoin Core 0.14 into my Statoshi fork, but one of the metrics is no longer populating and I'm hoping someone can explain if this is by design or if I screwed up 06:21 < lopp> the specific metric is the "block" inv message (MSG_BLOCK) that I'm populating here: https://github.com/jlopp/statoshi/blob/master/src/net_processing.cpp#L1571 06:21 < lopp> the "MSG_TX" inv type metric is populating fine (several lines earlier) 06:21 -!- aguycalled [~aguycalle@37.120.75.4] has quit [] 06:22 < abhishekcs10_> I am having problem understanding following parameters in bitcoin/src/chainparams.cpp 06:22 < abhishekcs10_> https://www.irccloud.com/pastebin/vVGQDoUJ 06:34 -!- jlopp [ac7c6953@gateway/web/freenode/ip.172.124.105.83] has joined #bitcoin-core-dev 06:34 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-lkyavnkmpgqzfvpe] has joined #bitcoin-core-dev 06:36 -!- chjj_ [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 06:49 < abhishekcs10_> How can I edit interblock timing 06:50 < abhishekcs10_> Eg. Setting it to 1min retargetted every 5min 06:54 -!- city22 [~textual@221.220.183.38] has joined #bitcoin-core-dev 06:55 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 07:14 < sdaftuar> lopp: i'm guessing that is because your peers are using headers or cmpctblocks to announce new blocks, rather than inv's 07:15 < sdaftuar> lopp: if all your peers or 0.12 or later - i think? - then it's unlikely you'll get block invs, except in rare cases 07:15 < sdaftuar> maybe 0.11 or later 07:15 < jlopp> OK I figured it was likely due to protocol changes; my test node is behind a NAT that I don't port forward so it only has 8 peers 07:16 < jlopp> I'll double check the peer versions 07:16 < sdaftuar> oh yep that will do it then 07:16 < sdaftuar> we have preferential peering logic that will make it unlikely for you to connect outbound to older peers (in preparation for segwit) 07:16 < jlopp> ahhh 07:17 < sdaftuar> so most likely all your peers are 0.13.1 or later 07:19 < lopp> @sdaftuar confirmed; they're all 0.13.1+ 07:44 -!- chjj_ [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 07:49 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has joined #bitcoin-core-dev 08:00 -!- jlopp [ac7c6953@gateway/web/freenode/ip.172.124.105.83] has quit [Quit: Page closed] 08:02 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 08:12 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 08:22 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:38 -!- senior [~senior@213.59.130.219] has joined #bitcoin-core-dev 08:38 -!- senior is now known as Guest82394 08:38 -!- Guest82394 [~senior@213.59.130.219] has quit [Client Quit] 08:39 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:53 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:59 -!- udiWertheimer [~udiWerthe@bzq-82-81-94-166.red.bezeqint.net] has quit [Ping timeout: 240 seconds] 08:59 -!- city22 [~textual@221.220.183.38] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 09:36 -!- abhishekcs10_ [uid170963@gateway/web/irccloud.com/x-yhrakgkmywphblwr] has quit [Quit: Connection closed for inactivity] 09:40 -!- udiWertheimer [~udiWerthe@bzq-84-111-23-225.red.bezeqint.net] has joined #bitcoin-core-dev 09:47 * BlueMatt . Now providing RaaS 09:47 < BlueMatt> Review as a Service, that is 09:48 < BlueMatt> in exchange for review of #9725 09:48 < gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub 09:51 -!- lopp [ac7c6953@gateway/web/freenode/ip.172.124.105.83] has quit [Ping timeout: 260 seconds] 09:52 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 09:57 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:12 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 10:30 -!- jtimon [~quassel@199.116.72.155] has joined #bitcoin-core-dev 10:31 * luke-jr peers at https://testnet.smartbit.com.au/tx/ecb710d1cc86487dbdb3f24b893e7c1d3bb98290097f0f0600c32aaa13312e00 10:34 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9827: Improve ScanForWalletTransactions return value (master...pr/scanret) https://github.com/bitcoin/bitcoin/pull/9827 10:50 < luke-jr> fun, left my CTableView bitcoin tx log overnight and no substantial memory usage growth. :D 10:50 < luke-jr> (I haven't implemented a limit to the log yet, but set it up to use only weak_ptrs) 10:51 < luke-jr> thinking of making it use maybe 500 lines of non-weak ptrs, and up to 10000 lines of weak_ptrs, or something 11:17 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9828: Avoid -Wshadow warnings in wallet_tests (master...pr/multishadow) https://github.com/bitcoin/bitcoin/pull/9828 11:28 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:58 -!- moli_ [~molly@unaffiliated/molly] has quit [Quit: Leaving] 11:59 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:02 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 12:05 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9829: Fix importmulti returning rescan errors for wrong keys (master...pr/multiinc) https://github.com/bitcoin/bitcoin/pull/9829 12:21 -!- shesek [~shesek@bzq-84-110-60-48.red.bezeqint.net] has joined #bitcoin-core-dev 12:23 -!- GAit [~GAit@unaffiliated/gait] has quit [Ping timeout: 240 seconds] 12:23 -!- GAit [~GAit@unaffiliated/gait] has joined #bitcoin-core-dev 12:32 -!- jtimon [~quassel@199.116.72.155] has quit [Read error: Connection reset by peer] 12:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 13:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:14 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wamzzgyaxfozzoym] has quit [Quit: Connection closed for inactivity] 13:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 13:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:33 -!- jtimon [~quassel@199.116.72.155] has joined #bitcoin-core-dev 13:33 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 13:35 < jtimon> mhmm, in rpcwallet and rpcdump, ensure EnsureWalletIsAvailable( is called before showing the help. if the user selected help but the wallet is not available, the function will return NullUniValue instead of actually showing the help 13:35 < jtimon> is this the desired behaviour? 13:35 < jtimon> it seems not, and it's simple to fix 13:42 < warren> I used linearize-data.py to generate in-order *.blk files. I want to make the very deep historical blocks read-only at the filesystem level and hard-linked into the blocks/ directory to be used by multiple separate instances of bitcoind on the same machine. It seems that bitcoind currently requires opening all *.blk files as writable so it is incompatible with this use case. http://pastebin.com/DMUcTJuT debug.log and relevant parts of b 13:42 < warren> itcoind source. 13:42 < warren> I could make a temporary hack for myself, but is there any reason to not support this in the future? 13:46 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rqlzxfnqdjnlfwkz] has joined #bitcoin-core-dev 14:09 < luke-jr> jtimon: it's the intended behaviour, presumably so -wallet=0 behaves the same as if it was compiled without 14:09 < luke-jr> (I don't mind if someone changes it though) 14:18 < warren> oh, *.dat files 14:18 < warren> blk*.dat 14:33 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 260 seconds] 14:44 < jtimon> luke-jr: I see, the other 2 options would be to either throw the error even if fHelp is true, or show the help even if the wallet is not available 14:45 < luke-jr> wouldn't throwing an error break `help`? 14:56 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 15:01 -!- tussssss [53bbc255@gateway/web/freenode/ip.83.187.194.85] has joined #bitcoin-core-dev 15:02 < tussssss> Buy/Sell ( Bitcoin - Perfect money - webmoney - western union - moneygram - skrill - neteller ) & giftcards/prepaids ( llike amazon-ebay etc... ) Contact Skype : rodrige.amin ICQ : 690490649 15:02 -!- tussssss [53bbc255@gateway/web/freenode/ip.83.187.194.85] has quit [Client Quit] 15:19 < jtimon> luke-jr: help is already broken if the wallet is not available 15:19 < jtimon> why are all these functions declared as extern? https://github.com/bitcoin/bitcoin/blob/master/src/rpc/server.h#L188 15:20 < luke-jr> jtimon: is it? :/ 15:22 < jtimon> luke-jr: if the wallet is not available, the function returns NullUniValue before having the opportunity to check if (fHelp || params.size() < 2 || params.size() > 6) (well, of course the exact check depends on the function) 15:23 < luke-jr> jtimon: and `help` upon getting null just skips it, no? 15:23 < jtimon> my preferred behaviour would be to only check if the wallet is available after checking if it should show the help, and when doing so, if it's not available just throw the error as if fHelp was false 15:24 < jtimon> luke-jr: no, if fHelp=false, it returns false, EnsureWalletIsAvailable() returns false instead of throwing the error, thus the calling function returns NullUniValue before having the chance to check if the help should be shown 15:25 < jtimon> I guess I'll just write my prefferred fix and see what people think 15:25 < luke-jr> jtimon: … 15:25 < luke-jr> jtimon: foomethod() returns null to help(), which just skips foomethod 15:26 < jtimon> what help() function ? 15:26 < luke-jr> rpc/server.cpp 15:26 < luke-jr> std::string CRPCTable::help(const std::string& strCommand) const 15:27 < jtimon> oh, no I don't mean the general help, I mean the help for a specific rpc call (or when you have an invalid number of parameters for that call) 15:28 < jtimon> but let me read that method... 15:30 < jtimon> I see, yeah, that's the point of returning null instead of launching the error or giving it the opportunity to get the help first 15:30 < luke-jr> fHelp is only ever true via that method 15:38 < jtimon> mhmm, if I start the deamon with -wallet=0 and then with the client do sendtoaddress --help it shows the doc... 15:39 < jtimon> how can I make pwalletMain=NULL ? 15:41 < jtimon> btw, IIRC we talked before about moving the rpc wallet stuff from BTC to satoshis, but it breaks the interface. Are we decided to never do that? 15:42 < jtimon> would this be a good time? 15:42 < luke-jr> `sendtoaddress --help` is simply an invalid address 15:43 < jtimon> ?? then why it shows the help instead of "Invalid Bitcoin address" 15:43 < ryanofsky> i know "sendfrom" RPC is deprecated, but is it also broken? I don't see 'fromaccount' 15:44 < ryanofsky> argument actually used for coin selection 15:56 < jeremyrubin> no that's not broken 15:56 < jeremyrubin> As far as I understand, accounts were meant to be internal accounting 15:57 < jeremyrubin> meaning negative balances could be reported 15:57 < jeremyrubin> So if I spend 2 from account Y with real balance 1, Y's new balance should be -1 15:59 < jeremyrubin> so account info has no bearing on coin selection 15:59 < sipa> that ^ 15:59 < sipa> coins are independent from accounts 15:59 < sipa> accounts only have a balance 16:14 < jtimon> can we please just get rid of accounts for 0.15 ? 16:14 < luke-jr> ryanofsky: accounts don't have coins 16:15 < luke-jr> jtimon: IIRC there's still some things we lack substitutes for? dunno 16:15 < jtimon> not sure what the progress on that was, but I thought we were close 16:41 < jtimon> sorry for repeating the question, why are all these functions declared as extern? https://github.com/bitcoin/bitcoin/blob/master/src/rpc/server.h#L188 16:52 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:01 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Remote host closed the connection] 17:07 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 17:34 -!- vicenteH [~user@96.235.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 17:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 17:48 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 17:55 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 17:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:14 -!- jtimon [~quassel@199.116.72.155] has quit [Ping timeout: 268 seconds] 18:21 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rqlzxfnqdjnlfwkz] has quit [Quit: Connection closed for inactivity] 18:25 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 268 seconds] 18:25 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 18:26 -!- jtimon [~quassel@199.116.72.155] has joined #bitcoin-core-dev 18:43 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:46 < jtimon> luke-jr: ok, sorry, it was -disablewallet, not wallet=0, right now, with that option, and with either -help or invalid args it says: error code: -32601 error message: Method not found, it could instead 18:49 -!- jtimon [~quassel@199.116.72.155] has quit [Remote host closed the connection] 18:53 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 255 seconds] 19:07 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:08 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 19:13 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 19:19 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:23 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 19:36 -!- goksinen [~goksinen@2604:2000:c591:8400:3cd5:fc2d:8fb:9686] has joined #bitcoin-core-dev 19:37 -!- goksinen [~goksinen@2604:2000:c591:8400:3cd5:fc2d:8fb:9686] has quit [Remote host closed the connection] 19:43 -!- goksinen [~goksinen@2604:2000:c591:8400:bda5:981d:694e:9b4] has joined #bitcoin-core-dev 19:51 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:00 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 20:14 -!- goksinen [~goksinen@2604:2000:c591:8400:bda5:981d:694e:9b4] has quit [Remote host closed the connection] 20:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:46 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 20:51 -!- chris2000 [~chris2000@p5DCB4011.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:53 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 20:54 -!- chris200_ [~chris2000@p5DCB5159.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 20:55 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 20:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 21:00 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has quit [Read error: Connection reset by peer] 21:00 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has joined #bitcoin-core-dev 21:05 -!- chjj_ is now known as chjj 21:28 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 21:32 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 21:37 < luke-jr> https://github.com/iancoleman/bip39/issues/58 21:37 < luke-jr> not sure if it's a real problem or not yet, but some crypto experts may want to look (sipa, gmaxwell) 21:39 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 21:52 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 21:52 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Client Quit] 22:01 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #9830: Add trusted flag to listunspent result (master...listunspenttrusted) https://github.com/bitcoin/bitcoin/pull/9830 22:10 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:15 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 22:18 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:25 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 22:26 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 22:31 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 22:33 < bitcoin-git> [bitcoin] theuni opened pull request #9831: build: force a c++ standard to be specified (master...no-default-std) https://github.com/bitcoin/bitcoin/pull/9831 22:42 -!- ryankung [~ryankung@14.152.49.250] has joined #bitcoin-core-dev 22:46 < midnightmagic> That feeler-connections PR is a very nice read. 22:50 < gmaxwell> luke-jr: crazy js code treating binary data as strings. :( 22:52 < luke-jr> >_< 22:57 < gmaxwell> should be recoverable at least... better than prior bitcoinjs / bn.js bugs. 22:59 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 23:00 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev 23:04 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 23:05 < cannon-c> Does bitcoin core have bip39 for backing up wallet? Having trouble seeming to find it. 23:06 < cannon-c> If not, any objection to including bip39? 23:10 < gmaxwell> It is a terrible spec which shouldn't be implemented by anyone, in my opinion. 23:12 < gmaxwell> It forces the use of public derrivation which results in security issues when used with software that allows public key export. It has no versioning, so wallets cannot change the schemes without creating a potential for funds loss. The 'check values' for it are optional and can't really be enforced for general compatiblity, which then also means that most uses of it end up unintentioally promot 23:12 < gmaxwell> ing insecure brainwallet usage. 23:12 < gmaxwell> The authors of the sepcification were uninterested in resolving these and other shortcomings, resulting in one of the authors having their name pulled from it. 23:13 < luke-jr> I thought BIP 39 didn't dictate anything re derivation? 23:14 < cannon-c> what is "public derrivation"? 23:14 * luke-jr observes people are actually using https://github.com/bitcoin/bips/wiki/Comments:BIP-0039 23:15 < cannon-c> I thought bip39 was just using dictionary wordlist in 2048 length list to convert 256 bit entropy to human readable words (256bit being 24 words) 23:15 < gmaxwell> indeed you're right it's BIP 44 that does but it doesn't matter because the lack of versioning means that you're stuck with the defacto standard. 23:16 < cannon-c> I do like idea of words for backup, I can write down backup on paper using words instead of key that is prone to misspelling and funds lost. 23:17 < cannon-c> gmaxwell what do you prefer above word based mnemonic then? 23:18 < gmaxwell> words are fine, but should be a scheme that can encode versioning and bidirectionally convert. 23:19 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 23:20 * luke-jr wonders if Electrum's scheme is saner, considering they had similar criticism of BIP 39 23:20 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 23:20 < cannon-c> If I udnerstand correctly, Electrum's scheme even if dictionary is lost can still recover direct from words themselves? 23:21 < cannon-c> Just something I heard, not familiar with Electrum's scheme though. 23:23 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #9832: [qa] assert_start_raises_init_error (master...assert_start_raises_init_error) https://github.com/bitcoin/bitcoin/pull/9832 23:24 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 23:34 -!- city22 [~textual@221.220.183.38] has joined #bitcoin-core-dev 23:37 < wumpus> what's up with travis? https://github.com/bitcoin/bitcoin/issues/9825 How can there be a threading error *before* the tests of test_bitcoin even start? 23:38 < wumpus> errors such as "test_bitcoin: tpp.c:62: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= __sched_fifo_min_prio && new_prio <= __sched_fifo_max_prio)' failed." 23:38 < wumpus> and "../include/boost/thread/pthread/recursive_mutex.hpp:113: void boost::recursive_mutex::lock(): Assertion `!pthread_mutex_lock(&m)' failed." 23:40 < wumpus> sounds like locking is being done before locking is initialized, e.g. before we even get to main()? 23:40 < bitcoin-git> [bitcoin] benma opened pull request #9833: Trivial: fix comments referencing AppInit2 (master...stalecomments) https://github.com/bitcoin/bitcoin/pull/9833 23:45 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:50 < jonasschnelli> wumpus: you think this is a travis issue or did we break the context initialisation in some way? 23:51 < wumpus> I don't think it's a travis issue, but I can't (which is always terribly frustrating with these issues) reproduce it locally 23:51 < wumpus> but yes it's probably something we do differently in our code now 23:51 -!- udiWertheimer [~udiWerthe@bzq-84-111-23-225.red.bezeqint.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 23:52 -!- city22 [~textual@221.220.183.38] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 23:52 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 23:52 -!- chris2000 [~chris2000@p5DCB4011.dip0.t-ipconnect.de] has quit [] 23:52 < wumpus> current master simply passes https://travis-ci.org/bitcoin/bitcoin/builds/204167316 - so it's intermittent 23:53 < jonasschnelli> wumpus: we recently changes something close to that,,, 23:53 < jonasschnelli> the missing bitcoin-tx ECC_Start() 23:53 < jonasschnelli> Not sure if this is related 23:53 < wumpus> unknown location(0): fatal error: in "rpc_tests/rpc_rawsign": signal: illegal operand; address of failing instruction: 0x2b73cbf4cf3b 23:53 < wumpus> WAT?? 23:54 < jonasschnelli> :/ 23:55 < midnightmagic> I wonder if it would be worthwhile to include a "legal participation" flag of some sort.. so that people who use the services provided by your bitcoin node must agree to the EULA of your node, in order to use it. 23:55 < wumpus> jonasschnelli: yes, might be related, I don't know. Although I think the test setup happens after the "Running 228 test cases...", not before it 23:56 < wumpus> not sure tho 23:56 < wumpus> midnightmagic: you could include a url in your subversion 23:56 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 23:57 < wumpus> (though it's a bit challenging with all those characters sanitized out :-) 23:57 < midnightmagic> Then, technically, mass-sybil'ing could be prosecuted if the sybils didn't disconnect immediately and refuse to connect again. 23:58 < wumpus> depending on your country you can set any terms of use when you run a service