--- Day changed Mon Mar 13 2017 00:13 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 00:17 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Ping timeout: 258 seconds] 00:41 -!- dodomojo [~goksinen@2604:2000:c591:8400:d840:bd99:64a:762] has joined #bitcoin-core-dev 00:44 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:46 -!- dodomojo [~goksinen@2604:2000:c591:8400:d840:bd99:64a:762] has quit [Ping timeout: 246 seconds] 00:48 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 00:56 -!- harrymm1 [~wayne@104.222.140.56] has quit [Ping timeout: 260 seconds] 01:02 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 01:06 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Ping timeout: 264 seconds] 01:09 -!- harrymm [~wayne@104.222.140.120] has joined #bitcoin-core-dev 01:09 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 01:23 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 268 seconds] 01:24 -!- cbits [~cbits@47.148.176.74] has joined #bitcoin-core-dev 01:25 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 01:31 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 01:33 -!- cbits [~cbits@47.148.176.74] has quit [Quit: Leaving] 01:36 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Ping timeout: 258 seconds] 01:42 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Quit: leaving] 01:43 -!- JackH [~laptop@79-73-184-8.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 01:43 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 01:53 < bitcoin-git> [bitcoin] laanwj opened pull request #9983: tests: Convert selected tests to using named RPC arguments (master...2017_03_rpc_tests_named_arguments) https://github.com/bitcoin/bitcoin/pull/9983 02:01 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 02:01 -!- ChillazZ [~ChillazZ@195.30.94.129] has joined #bitcoin-core-dev 02:06 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Ping timeout: 264 seconds] 02:21 -!- harrymm [~wayne@104.222.140.120] has quit [Ping timeout: 240 seconds] 02:23 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:30 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 02:35 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 02:35 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Ping timeout: 268 seconds] 02:39 -!- harrymm [~wayne@104.222.140.85] has joined #bitcoin-core-dev 02:51 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 02:54 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Ping timeout: 240 seconds] 03:01 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Remote host closed the connection] 03:11 -!- Hubert2 [~Hubert@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 03:11 -!- Hubert2 [~Hubert@static.22.144.99.88.clients.your-server.de] has quit [Excess Flood] 03:12 -!- Hubert2 [~Hubert@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 03:12 -!- Hubert2 [~Hubert@static.22.144.99.88.clients.your-server.de] has quit [Excess Flood] 03:12 -!- Hubert2 [~Hubert@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 03:15 -!- Hubert2 [~Hubert@static.22.144.99.88.clients.your-server.de] has quit [Remote host closed the connection] 03:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 03:23 -!- dodomojo [~goksinen@2604:2000:c591:8400:d840:bd99:64a:762] has joined #bitcoin-core-dev 03:26 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 03:28 -!- dodomojo [~goksinen@2604:2000:c591:8400:d840:bd99:64a:762] has quit [Ping timeout: 246 seconds] 03:36 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 03:36 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 03:36 -!- LeMiner2 is now known as LeMiner 03:40 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:41 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 03:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer] 03:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:45 -!- Lyla [~Lyla@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 03:46 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 03:46 -!- Lyla [~Lyla@static.22.144.99.88.clients.your-server.de] has quit [Read error: Connection reset by peer] 03:51 -!- Merlin2 [~Merlin@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 03:54 -!- Merlin2 [~Merlin@static.22.144.99.88.clients.your-server.de] has quit [Remote host closed the connection] 03:59 -!- Javon [~Javon@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 04:02 -!- Javon [~Javon@static.22.144.99.88.clients.your-server.de] has quit [Remote host closed the connection] 04:05 -!- isle2983 [~isle2983@46.166.137.245] has quit [Ping timeout: 268 seconds] 04:05 -!- Hisham [29e91d70@gateway/web/freenode/ip.41.233.29.112] has quit [Quit: Page closed] 04:05 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 04:08 -!- Effie [~Effie@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 04:09 -!- Effie [~Effie@static.22.144.99.88.clients.your-server.de] has quit [Excess Flood] 04:09 -!- Christina [~Christina@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 04:09 -!- Christina [~Christina@static.22.144.99.88.clients.your-server.de] has quit [Excess Flood] 04:09 -!- Effie [~Effie@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 04:09 -!- Effie [~Effie@static.22.144.99.88.clients.your-server.de] has quit [Excess Flood] 04:13 -!- Mustafa2 [~Mustafa@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 04:18 -!- dodomojo [~goksinen@2604:2000:c591:8400:d840:bd99:64a:762] has joined #bitcoin-core-dev 04:22 -!- dodomojo [~goksinen@2604:2000:c591:8400:d840:bd99:64a:762] has quit [Ping timeout: 246 seconds] 04:23 -!- randy-waterhouse [~kiwigb@103.247.192.175] has joined #bitcoin-core-dev 04:24 -!- randy-waterhouse [~kiwigb@103.247.192.175] has quit [Changing host] 04:24 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 04:30 -!- Mustafa2 [~Mustafa@static.22.144.99.88.clients.your-server.de] has quit [Remote host closed the connection] 04:35 -!- nejon [uid38993@gateway/web/irccloud.com/x-yjcjnqefpsuraenc] has joined #bitcoin-core-dev 04:42 -!- Giovanny [~Giovanny@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 05:12 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 05:12 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 05:16 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 258 seconds] 05:16 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 05:22 -!- Alina-malina [~Alina-mal@37.157.223.84] has joined #bitcoin-core-dev 05:22 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 05:27 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 05:37 -!- Alina-malina [~Alina-mal@37.157.223.84] has quit [Changing host] 05:37 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 05:40 -!- crescendo [~mozart@unaffiliated/crescendo] has quit [Ping timeout: 252 seconds] 05:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 06:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:06 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has joined #bitcoin-core-dev 06:10 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has quit [Ping timeout: 246 seconds] 06:11 -!- isle2983 [~isle2983@162.216.46.58] has joined #bitcoin-core-dev 06:13 -!- Giovanny [~Giovanny@static.22.144.99.88.clients.your-server.de] has quit [Remote host closed the connection] 06:19 -!- kexkey [~kexkey@184.75.212.52] has joined #bitcoin-core-dev 06:21 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 06:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:22 -!- otium [~otium@2a01:e35:2eeb:c00:511:d4b6:a342:1935] has joined #bitcoin-core-dev 06:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 06:27 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 06:32 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:37 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 06:41 -!- kexkey [~kexkey@184.75.212.52] has quit [Quit: kexkey] 06:42 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:43 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa99663bec1d...8040ae6fc576 06:43 < bitcoin-git> bitcoin/master 3b092bd Wladimir J. van der Laan: util: Properly handle errors during log message formatting... 06:43 < bitcoin-git> bitcoin/master b651270 Wladimir J. van der Laan: util: Throw tinyformat::format_error on formatting error... 06:43 < bitcoin-git> bitcoin/master 8040ae6 Wladimir J. van der Laan: Merge #9963: util: Properly handle errors during log message formatting... 06:44 < bitcoin-git> [bitcoin] laanwj closed pull request #9963: util: Properly handle errors during log message formatting (master...2017_03_handle_exception_tinyformat) https://github.com/bitcoin/bitcoin/pull/9963 06:47 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 06:48 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 06:54 -!- otium [~otium@2a01:e35:2eeb:c00:511:d4b6:a342:1935] has quit [Quit: ...] 07:00 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has joined #bitcoin-core-dev 07:05 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has quit [Ping timeout: 246 seconds] 07:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:11 -!- MarcoFalke_lab [8af60274@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.116] has joined #bitcoin-core-dev 07:12 < MarcoFalke_lab> wumpus: I think you need to enable the verify commits pre push hook. 07:12 < MarcoFalke_lab> Alternatively, someone could fix the bug in github-merge 07:12 < wumpus> which bug? 07:13 < MarcoFalke_lab> It will calculate the hash of the files in the working directory, instead of the ones in git 07:14 < wumpus> right, that should be fixed 07:15 -!- kexkey_ [~kexkey@184.75.212.52] has joined #bitcoin-core-dev 07:16 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 07:16 < wumpus> without that it's kind of useless and we should disable the hashing completely 07:16 < wumpus> seems easy enough to do though, just request the data from git 07:17 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 07:17 < MarcoFalke_lab> Why not do the hard reset early? I mean at some point the script does the hard reset anyway, so the data is lost regardless 07:17 < wumpus> it shouldn't do any hard resets 07:17 -!- kexkey_ is now known as kexkey 07:18 < MarcoFalke_lab> https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/github-merge.py#L290 07:18 < wumpus> okay, yeah I don't really like that solution. It should hash what is in git, not what is in the current working directory 07:19 < MarcoFalke_lab> ok, fine. 07:19 < wumpus> otherwise there's always a window for races 07:20 < MarcoFalke_lab> jup, it is the cleaner solution. 07:21 < wumpus> working on it now - apparently ls-files gives the blob ids, that can be passed as-is to git cat-file 07:22 < BlueMatt> wumpus: yes, iirc that was annoying but i dont remember why now....verify-commits does cat-file $COMMIT_ID:$FILE_PATH 07:23 < wumpus> BlueMatt: ah, that likely works just as well 07:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:24 < BlueMatt> wumpus: if you can get it to work some other way, though, use that...I kinda liked how merge did the hashes via checkout and verify-commits used a different approach, but it really doesnt matter all that much 07:24 * BlueMatt doesnt have to deal with the merge script, so I get to argue for it to be harder to use all day long with no repurcussions, though :P 07:25 < wumpus> well how the sha is computed doesn't affect how hard it is to use, it does affect whether the output is correct, which is arguably very important 07:25 < BlueMatt> indeed 07:26 * BlueMatt is ok with the sha being less likely to match, if that also means its more likely to trip up if something strange happens (symlink detection gets broken, etc) 07:26 < BlueMatt> anyway, this is too inconsequential to nitpick over :P 07:27 < wumpus> I'm kind of annoyed at travis tripping up all the time though, if that keeps happening I'll hvae to disable the verify-commits check there. SO let's please just get it working 07:27 < BlueMatt> i think it should be good now 07:27 < BlueMatt> it failed a number of times just downloading the pubkeys because the sks pool was broken 07:27 < BlueMatt> but we changed to subset which appears to possibly be more stable 07:28 < BlueMatt> i do not believe we have otherwise failed in some time 07:28 < BlueMatt> hmmm, no, failed again this morning 07:28 < BlueMatt> I'll go take a look 07:28 < wumpus> according to MarcoFalke_lab it failed due to my merge script miscomputing the SHA 07:28 < MarcoFalke_lab> BlueMatt: It used the 'old' server url 07:29 < MarcoFalke_lab> The other failure was due to the wrong sha 07:29 < BlueMatt> that was once, looks like it also once failed to retreive pubkeys 07:29 < BlueMatt> wtf 07:29 < BlueMatt> how did it do that? it now points to subset??? 07:29 < MarcoFalke_lab> BlueMatt: IIRC the subset-patch was not merged at that time 07:30 < BlueMatt> yes it was, the very top commit failed and the second-to-top merge was the subset change 07:30 < wumpus> what subset patch? 07:30 < BlueMatt> im super confused 07:30 < BlueMatt> wumpus: part of #9940 was to change the server gpg fetches the keys from 07:30 < gribble> https://github.com/bitcoin/bitcoin/issues/9940 | Fix verify-commits on OSX, update for new bad Tree-SHA512, point travis to different keyservers by TheBlueMatt · Pull Request #9940 · bitcoin/bitcoin · GitHub 07:30 < wumpus> ok, confusing 07:30 < MarcoFalke_lab> Right 07:30 < MarcoFalke_lab> Probably just a travis network hickup 07:31 < petertodd> BlueMatt: why not have the merge script get the pubkeys from the repo itself? 07:31 < BlueMatt> MarcoFalke_lab: no, look at the build, it tried to fetch from pool., not subset.pool. 07:31 < BlueMatt> petertodd: yea, I think thats the next step, I was thinking subset might help, but... 07:31 < BlueMatt> still need to do a --refresh-keys 07:32 < BlueMatt> but need a backup 07:32 < petertodd> BlueMatt: better to make the whole thing deterministic; if verify commits doesn't run because a key is missing, fix that! 07:33 < BlueMatt> oh, no, I'm wrong, github is listing me commits out of order 07:33 < BlueMatt> wtf 07:33 < wumpus> yes it does that, it uses a stupid sort ordering for commits 07:34 < wumpus> by date instead of chronologically according to the repo 07:34 < BlueMatt> oh, ok, yes, the failure occurred before the subset merge, and then another afterwards due to bad sha512 07:34 < BlueMatt> wumpus: well i was only looking at merge commits, i think github actually just had a hiccup 07:35 < BlueMatt> anyway, I restarted the build on the >=8 -addnode fix merge, which should pass this time, if there are any non-sha512-related failures we'll switch to pulling keys from in-repo 07:38 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:41 -!- vFSgrcFGBJHg [~rYUtdcvYT@2a02:2f0a:b070:12e0:86a7:490c:4e70:650b] has joined #bitcoin-core-dev 07:43 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 07:45 -!- MarcoFalke_lab [8af60274@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.116] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 07:47 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 260 seconds] 07:49 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:50 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 07:50 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:52 < wumpus> argh, git cat-file blob is slow compared to the current script 07:54 < wumpus> oh it can work in batch mode, that's cool 07:54 -!- Blaise [~Blaise@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 07:54 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has joined #bitcoin-core-dev 07:54 < BlueMatt> wumpus: its hella slow 07:54 < BlueMatt> like, insanely slow 07:55 < wumpus> also in batch mode? I think the overhead right now is spawning a process for every file 07:55 < BlueMatt> hmm, not sure, didnt try, but you need to separate out different files for our current hash format 07:56 < wumpus> it prints a header per file 07:56 < wumpus> "84e7eb60d70d9fae3bdaae7f04f9f08fecaf2052 blob 150829" 07:56 < BlueMatt> ahh, ok 07:58 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has quit [Ping timeout: 246 seconds] 08:06 < wumpus> ooh it's fast in batch mode 08:07 < BlueMatt> argh, great, now i need to make verify-commits use batch mode 08:07 < BlueMatt> :P 08:15 < bitcoin-git> [bitcoin] laanwj opened pull request #9984: devtools: Make github-merge compute SHA512 from git, instead of worktree (master...2017_03_merge_hash_git) https://github.com/bitcoin/bitcoin/pull/9984 08:40 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 08:43 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Client Quit] 08:46 -!- kexkey [~kexkey@184.75.212.52] has quit [Quit: Quits] 08:48 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 08:48 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has joined #bitcoin-core-dev 08:50 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:53 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has quit [Ping timeout: 246 seconds] 09:15 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 09:16 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 09:16 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Client Quit] 09:17 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 09:17 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Client Quit] 09:18 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 09:18 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Client Quit] 09:29 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 09:45 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #9985: [QT] Show more descriptive label for pay to yourself entries (master...watchonlylabel) https://github.com/bitcoin/bitcoin/pull/9985 09:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [] 09:49 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:54 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 10:21 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 10:34 -!- nemgun [~nemgun@105.101.193.63] has joined #bitcoin-core-dev 10:36 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 10:36 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has joined #bitcoin-core-dev 10:39 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 10:41 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Client Quit] 10:41 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has quit [Ping timeout: 246 seconds] 10:43 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 10:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 10:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 11:00 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 11:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:24 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds] 11:31 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has joined #bitcoin-core-dev 11:35 -!- dodomojo [~goksinen@2604:2000:c591:8400:b550:7901:b079:fd9b] has quit [Ping timeout: 246 seconds] 11:56 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 11:56 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 12:16 -!- nsh- is now known as nsh 12:24 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 12:24 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 12:29 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 260 seconds] 12:34 -!- murchandamus11 [~murchghos@ghostdub.de] has quit [Remote host closed the connection] 12:36 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev 12:41 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 12:58 -!- vFSgrcFGBJHg [~rYUtdcvYT@2a02:2f0a:b070:12e0:86a7:490c:4e70:650b] has quit [Quit: Leaving] 13:19 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 13:29 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 13:34 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Ping timeout: 264 seconds] 13:35 < gmaxwell> Apparently IBD on 0.14 OOMs on 2GB (at least on an odroid c2, as expirenced by sipa and someone on reddit); due to the mempool loaning allowing it to achieve peak memory at IBD rather than sometime later. 13:35 < gmaxwell> I suppose it's better to crash during IBD rather than later... 13:39 < achow101> gmaxwell: someone has reported that in an issue and on bitcointalk too 13:40 < gmaxwell> achow101: well the answer for them right now is to lower their dbcache/maxmempool, I recommended 150/150. 13:41 < gmaxwell> It's not really a regression in 0.14, the same devices would eventually crash with 0.13.x, just later. 13:45 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 13:46 < sipa> well, not necessarily, but they would with -dbcache=600 13:46 < sipa> so we've effectively just raised the default dbcache during IBD 13:51 < gmaxwell> sipa: say dbcache is 300, and mempool is 300.. eventually dbcache will be full and mempool will be full.... sooo similar peak memory usage, no? 13:51 < gmaxwell> (or would you argue that because the leveldb batch can result in 2x memory, that we should be adding half the mempool to the dbcache?) 13:56 < sipa> gmaxwell: right, that's what i'm saying 13:56 < sipa> with 300 MB dbcache + 300 MB mempool, you can use up to 900 MB at flush time 13:56 < sipa> with 600 MB dbcache + 0 MB mempool, you can use up to 1200 MB at flush time 13:57 < gmaxwell> so perhaps a patch we should do quickly and backport is to add half the unused memory to the dbcache. Can you see if that would make your odroid c2 successfully sync? 13:57 < sipa> BUT, we should probably halve the -dbcache setting as well, because someone who configures 2300 MB of dbcache does not expect the application to suddenly use 4600 MB, regardless of mempool borrowing 13:57 < gmaxwell> hm. so perhaps half the units, double the default? 13:57 < gmaxwell> halve* 13:58 < sipa> or just fix leveldb to not require the whole batch to be stored in a single std::string. 13:58 < gmaxwell> yea, but would we backport that for 0.14.1? 13:58 < sipa> depends on how trivial it is, i think 13:59 < gmaxwell> (I think we need to do something for 0.14.1 but it could be something dumb like halving the mempool loan) 14:00 < sipa> yeah, that would fix the 'unexpectedness' of the memory loaning 14:00 < sipa> but not the incorrectness of the estimate 14:03 < luke-jr> is there a reason to use dbcache post-sync? 14:04 < sipa> yes, much faster block verification 14:04 < sipa> even with sigcache 14:06 < luke-jr> but why not commit it after each post-sync block immediately? 14:06 < luke-jr> it doesn't grow that much from just one block, does it? 14:06 < sipa> it can grow by 20 MB or so from one block 14:06 -!- afk11 [~afk11@176.61.69.103] has quit [Ping timeout: 260 seconds] 14:07 < sipa> and flushing slows down future blocks 14:07 < luke-jr> hmm 14:08 < sipa> with per-txout caching, the max (and typical) growth of the cache per block will be much less 14:08 < gmaxwell> much (most?) of dbcache's gains come from avoiding writes entirely for utxo that never need to make it to disk. 14:08 < sipa> indeed. 14:09 < sipa> though avoiding writes can always be moved out of the critical path of block validation 14:09 < sipa> in synced state, it still prevents recent utxos from needing to be read from disk 14:12 < nemgun> Hello guys, thank you for 0.14, i am resyncing, and it uses far less CPU 14:12 < luke-jr> sipa: aside from validation, that's probably useful for external tools accessing them via RPC? 14:13 < sipa> luke-jr: i believe gettxout will use the cache 14:13 -!- afk11 [~afk11@176.61.69.103] has joined #bitcoin-core-dev 14:14 < sipa> luke-jr: gettxoutsetinfo always flushes to disk, and then iterates over the leveldb state 14:16 < TD-Linux> I suppose it's better to crash during IBD rather than later... <- yeah though super annoying when pruning. 14:19 < gmaxwell> oh my we should probably only be pruning after sync flushes. 14:20 < jouke> w/win 24 14:21 < jouke> >_< 14:21 < sipa> gmaxwell: we do 14:21 < sipa> pruning always triggers a flush 14:25 < TD-Linux> sipa, were you pruning on your c2? if so did you hit https://github.com/bitcoin/bitcoin/issues/9001 14:25 < sipa> TD-Linux: i'm not pruning (yet) 14:25 < sipa> 128GB microsd card ftw 14:36 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:43 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:52 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 15:24 -!- nemgun [~nemgun@105.101.193.63] has quit [Quit: Leaving] 15:25 -!- nemgun [~nemgun@105.101.193.63] has joined #bitcoin-core-dev 15:25 -!- nemgun1 [~nemgun@105.101.193.63] has joined #bitcoin-core-dev 15:26 -!- nemgun1 [~nemgun@105.101.193.63] has quit [Client Quit] 15:26 -!- nemgun [~nemgun@105.101.193.63] has quit [Client Quit] 15:31 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 15:33 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:36 -!- chjj [~chjj@unaffiliated/chjj] has quit [Quit: WeeChat 1.7] 15:44 < luke-jr> I wonder if there's a safe way to catch bad_alloc, drop dbcache/mempool stuff, and resume cleanly? 15:50 -!- afk11 [~afk11@176.61.69.103] has quit [Ping timeout: 268 seconds] 15:56 -!- afk11 [~afk11@176.61.69.103] has joined #bitcoin-core-dev 15:58 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 16:01 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 16:06 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 260 seconds] 16:08 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 16:11 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:16 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 16:16 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 16:40 < bitcoin-git> [bitcoin] practicalswift opened pull request #9987: Remove unused code (master...remove-unused-code) https://github.com/bitcoin/bitcoin/pull/9987 16:55 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 16:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:59 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 260 seconds] 17:00 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 17:00 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 17:04 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has quit [Quit: ZNC - http://znc.in] 17:13 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 17:25 -!- marcoagner [~marcoagne@179.177.241.206] has joined #bitcoin-core-dev 17:30 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has joined #bitcoin-core-dev 17:45 -!- randy-waterhouse [~kiwigb@43.228.156.100] has joined #bitcoin-core-dev 17:45 -!- randy-waterhouse [~kiwigb@43.228.156.100] has quit [Changing host] 17:45 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 17:55 -!- marcoagner [~marcoagne@179.177.241.206] has quit [Ping timeout: 260 seconds] 18:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:32 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 260 seconds] 18:37 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 18:40 -!- Pasha is now known as Cory 18:43 -!- dodomojo [~goksinen@2604:2000:c591:8400:9179:d95:a063:19ed] has joined #bitcoin-core-dev 18:48 -!- dodomojo [~goksinen@2604:2000:c591:8400:9179:d95:a063:19ed] has quit [Ping timeout: 246 seconds] 18:58 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 18:58 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Remote host closed the connection] 18:58 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 18:58 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 18:59 -!- dodomojo [~goksinen@2604:2000:c591:8400:613d:1a76:d990:d26a] has joined #bitcoin-core-dev 19:09 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Quit: Leaving.] 19:10 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has joined #bitcoin-core-dev 19:10 -!- vogelito [~Adium@fixed-187-190-39-75.totalplay.com.mx] has quit [Client Quit] 19:14 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gbwztlkxqbxoxrtr] has quit [Quit: Connection closed for inactivity] 19:40 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Read error: Connection reset by peer] 19:41 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 20:07 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 21:14 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:18 -!- dodomojo [~goksinen@2604:2000:c591:8400:613d:1a76:d990:d26a] has quit [Remote host closed the connection] 21:19 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:29 -!- chris200_ [~chris2000@p5DCB59AB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 21:32 -!- chris2000 [~chris2000@p5DCB4D93.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 21:55 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 21:55 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 21:58 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Client Quit] 21:59 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 22:00 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 22:13 -!- windsok_ is now known as windsok 22:14 -!- windsok [~windsok@45.63.59.8] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 22:14 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 22:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 22:36 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Quit: Leaving.] 22:36 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has joined #bitcoin-core-dev 22:39 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 22:40 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:49 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 22:54 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 268 seconds] 23:05 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 23:27 < wumpus> luke-jr: that would be a great idea 23:28 < wumpus> luke-jr: jeremyrubin was also talking about that, it's pretty hard to do in practice, though 23:28 < wumpus> jonasschnelli: my mac just arrived, so I'll hopefully be able to help with macosx releases and development now, too 23:36 < warren> brg444: it just occurred to me that optimizations beyond validation performance have helped core deal with larger block sizes up to 1MB. Do you already have the few cases where the performance of `getblocktemplate` was dramatically improved in the context of a huge mempool? That became slow at some point, and fear of orphans from it being slow also contributed to centralization pressure. 23:38 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8040ae6fc576...cce056d72918 23:38 < bitcoin-git> bitcoin/master a327e8e Wladimir J. van der Laan: devtools: Make github-merge compute SHA512 from git, instead of worktree... 23:38 < bitcoin-git> bitcoin/master cce056d Wladimir J. van der Laan: Merge #9984: devtools: Make github-merge compute SHA512 from git, instead of worktree... 23:39 < bitcoin-git> [bitcoin] laanwj closed pull request #9984: devtools: Make github-merge compute SHA512 from git, instead of worktree (master...2017_03_merge_hash_git) https://github.com/bitcoin/bitcoin/pull/9984 23:43 < jeremyrubin> luke-jr: there are some nice ways to effectively recover, the key is to make the bad_alloc handler rentrant-safe (it's not right now) and then try to flush some caches, or even just wait a split second in hopes that another thread frees whatever large allocation it made. 23:43 -!- dodomojo [~goksinen@2604:2000:c591:8400:613d:1a76:d990:d26a] has joined #bitcoin-core-dev 23:44 < jeremyrubin> I have some notes somewhere on some of the various things that could be done. if you're interested, email me 23:44 < luke-jr> I suppose the bigger problem will be overcommitments 23:48 -!- dodomojo [~goksinen@2604:2000:c591:8400:613d:1a76:d990:d26a] has quit [Ping timeout: 246 seconds] 23:48 < gmaxwell> luke-jr: you can do virtually nothing without more allocations happening, you certantly can't flush the dbcache. 23:48 < gmaxwell> maybe you could drop the mempool completely. 23:48 < gmaxwell> but its unlikely that you caught the exception at a point you could continue from. 23:52 < jeremyrubin> so one idea i had 23:52 < jeremyrubin> is to have 10MB as a "break in case of emergency" memeory 23:52 < jeremyrubin> so when you OOM 23:52 < jeremyrubin> you free that 23:52 < jeremyrubin> and then try to flush 23:53 < midnightmagic> That seems to be a single entity, by the way, joining and leaving with all those usernames and IP addresses. 23:56 -!- vogelito [~Adium@fixed-187-190-149-151.totalplay.com.mx] has quit [Quit: Leaving.] 23:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-bhqyvbtvusdxgpmi] has joined #bitcoin-core-dev