--- Day changed Fri Mar 24 2017 00:04 -!- kexkey [~kexkey@184.75.212.51] has quit [Ping timeout: 260 seconds] 00:04 < NicolasDorier> https://www.irccloud.com/pastebin/uJAM5yEn/ 00:09 < NicolasDorier> realloc invalid pointer 00:09 < dcousens> NicolasDorier: aye, trying to figure it out myself 00:09 < NicolasDorier> the pointer not being null 00:12 < NicolasDorier> https://www.irccloud.com/pastebin/RG0eniJZ/ 00:12 < wumpus> BlueMatt: yes I'll create a project (if no one has done so yet) 00:14 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 00:14 < luke-jr> NicolasDorier: run it in valgrind if you can; random memory corruption can manifest in weird ways 00:14 < luke-jr> NicolasDorier: pastebin the patch? :p 00:17 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 00:17 < NicolasDorier> luke-jr: My code https://github.com/bitcoin/bitcoin/pull/10068 the innocent looking faulty line is https://github.com/bitcoin/bitcoin/pull/10068/files#diff-b2bb174788c7409b671c46ccc86034bdL2118 that you can hit by running sendtoaddress 00:18 < NicolasDorier> I don't know valgrind, better than gdb ? 00:20 < NicolasDorier> dcousens: might be some unrelated problem of memory corruption ? I will try to make an easy repro 00:20 < luke-jr> NicolasDorier: valgrind is for memory stuff 00:20 < NicolasDorier> it fails deterministicallly here though 00:20 < NicolasDorier> ha 00:20 < NicolasDorier> ok I'll try that 00:28 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 00:28 -!- go1111111 [~go1111111@c-24-56-251-23.customer.broadstripe.net] has joined #bitcoin-core-dev 00:31 < NicolasDorier> dcousens: seems the problem was my code. 00:31 < NicolasDorier> https://www.irccloud.com/pastebin/tmHUV2sU/ 00:31 < NicolasDorier> I was in the thought that 00:32 < NicolasDorier> the two fields 00:32 < NicolasDorier> would be initialized by their default ctor 00:32 < NicolasDorier> and thus set to Null 00:32 < NicolasDorier> I mean SetNull would be called on them 00:33 < NicolasDorier> luke-jr: awesome tool thanks. 00:49 < NicolasDorier> nop atcually was not the problem 00:51 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:53 < wumpus> created the project. Any proposed pulls from last meeting (or the one before that) that I missed? https://github.com/bitcoin/bitcoin/projects/8 01:07 < NicolasDorier> wumpus: proposed pulls for what ? 01:07 < wumpus> NicolasDorier: for priority review (some people were asking for this at the meeting) 01:08 < NicolasDorier> ah ok thought it was about proposals for 0.15 01:08 < wumpus> well, in a way it is, but 0.15 is still too far away to have a review crunch now 01:09 < wumpus> this is not about last minute merges to any release but about what is blocking people now 01:09 < NicolasDorier> wumpus: the merge of the leveldb fix to bitcoin 01:10 < NicolasDorier> well no actually it is not like it blocks me 01:10 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 01:14 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:15 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 246 seconds] 01:23 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 01:28 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tpnsyztujryaszlu] has joined #bitcoin-core-dev 01:31 -!- Turner [~Turner@188.226.139.184] has quit [Remote host closed the connection] 01:32 -!- Kendrick2 [~Kendrick@188.226.139.184] has joined #bitcoin-core-dev 01:43 < NicolasDorier> AH I found out my bug. Very interesting. My class was named CCoin, but there is another CCoin in rest.cpp 01:43 < NicolasDorier> strangely 01:44 < NicolasDorier> I had no compile error problem 01:44 < NicolasDorier> even if both CCoin had completely different methods and fields 01:44 < NicolasDorier> but on runtime 01:44 < NicolasDorier> the other CCoin was linked oO 01:45 < NicolasDorier> so basically what I compiled was not what was linked or some strange stuff like that 01:45 < NicolasDorier> changing the name of the class completely fixed the problem 01:49 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:49 < luke-jr> O.o 01:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 01:56 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 02:05 -!- dodomojo [~goksinen@2604:2000:c591:8400:d8b5:8851:e466:ccbb] has joined #bitcoin-core-dev 02:09 -!- dodomojo [~goksinen@2604:2000:c591:8400:d8b5:8851:e466:ccbb] has quit [Ping timeout: 246 seconds] 02:27 < dcousens> NicolasDorier: o.O 02:28 < NicolasDorier> yeah... what tip me off is when I was using gdb, but the debugger was going into the CCoin of rest.cpp 02:28 < NicolasDorier> no idea how it could compile since after I was calling methhods only from my new CCoin class 02:29 < dcousens> NicolasDorier: CCoin::operator= (this=0x7fffdb7fc9f0) at ./wallet/wallet.h:459 - is a blank line for me, guessing you had modifications there for sure 02:29 < dcousens> esp. since CCoin doesn't even have a operator= in that file 02:29 < NicolasDorier> operator= was not defined 02:29 < NicolasDorier> it was the default operator= which should just copy 02:29 < NicolasDorier> in C++ it exists by default 02:30 < sipa> NicolasDorier: if you'd have had the two CCoin class definitions included within one module, compilation would fail 02:30 < NicolasDorier> rest.h was not included into wallet.cpp where I was using my CCoin 02:30 < NicolasDorier> so there wwas no conflict as far as wallet.cpp was concerned 02:32 < sipa> and neither of these has virtual methods? 02:32 < sipa> i'm confused actually... if it compiled, i would expect it to work 02:32 < NicolasDorier> nop 02:33 < dcousens> NicolasDorier: are you certain that was the issue? not just some compilational coincidence? 02:33 < NicolasDorier> yes... well I was bit surprised as well 02:33 < sipa> the linker would have failed if there was a duplicate definition for some method that wasn't inlined 02:33 < sipa> and if they were inlined, the one you expect would be inlined 02:33 < NicolasDorier> dcousens: ah maybe a .o outdated or something like that ? 02:33 < NicolasDorier> I indeed did not made a make clean 02:33 < dcousens> NicolasDorier: indeed, it was going to be my first suggestion `make clean` haha 02:34 < NicolasDorier> mmh possible. But strange, it is not like I played with ./configure :/ 02:34 < NicolasDorier> my methods were inlined 02:35 -!- go1111111 [~go1111111@c-24-56-251-23.customer.broadstripe.net] has quit [Ping timeout: 264 seconds] 02:38 < luke-jr> sipa: would it? I would think the same signature would overwrite silently (and that this is relied on for templates)? 02:39 -!- laurentmt [~Thunderbi@LPuteaux-656-1-276-73.w80-12.abo.wanadoo.fr] has joined #bitcoin-core-dev 02:42 -!- laurentmt [~Thunderbi@LPuteaux-656-1-276-73.w80-12.abo.wanadoo.fr] has quit [Client Quit] 02:44 < luke-jr> otoh, I think I may have seen errors like that before 02:44 -!- Kendrick2 [~Kendrick@188.226.139.184] has quit [Remote host closed the connection] 02:45 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 02:53 -!- Colten [~Colten@188.226.139.184] has joined #bitcoin-core-dev 03:01 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has quit [Quit: Whatever] 03:06 < jouke> ~/win 24 03:06 < jouke> srsly 03:07 < jouke> I need to get an other irc client. 03:10 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [] 03:11 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #10069: [QA] Fix typo in fundrawtransaction test (master...patch-3) https://github.com/bitcoin/bitcoin/pull/10069 03:17 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:21 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 03:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:32 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 04:13 -!- _biO_ [~biO_@80.156.183.43] has joined #bitcoin-core-dev 04:19 -!- ChillazZ [~ChillazZ@195.30.94.129] has joined #bitcoin-core-dev 04:47 < bitcoin-git> [bitcoin] laanwj closed pull request #10051: adhere to `-whitelist` for outbound connection (master...whitelist-outbound) https://github.com/bitcoin/bitcoin/pull/10051 04:49 < bitcoin-git> [bitcoin] laanwj reopened pull request #10051: adhere to `-whitelist` for outbound connection (master...whitelist-outbound) https://github.com/bitcoin/bitcoin/pull/10051 04:49 < dcousens> NicolasDorier: beat me to saying it 04:49 < dcousens> `rawtx` and `rawTx` 04:49 < dcousens> lol 04:50 < NicolasDorier> took me an hour to understand wtf was going on 04:50 < dcousens> can they not be broken out into different scope? 04:50 < dcousens> i mean, different PR, but still 04:51 < NicolasDorier> what do you mean ? 04:51 < dcousens> NicolasDorier: save re-writing the whole thing, I wonder if you could do the equivalent of introducing a block scope 04:52 < NicolasDorier> rewriting the whole thing ? 04:52 < dcousens> NicolasDorier: dw, I just meant to avoid the error in future 04:52 < NicolasDorier> I don't follow you 04:53 < NicolasDorier> ah I did not knew block scope existed in python actually :p 04:53 < dcousens> `rawtx` ideally would have thrown "undefined" error if there was an actual typo 04:53 < dcousens> NicolasDorier: iirc they are function scoped anyway 04:54 < wumpus> block scope doesn't exist inpython just function scope 04:54 < NicolasDorier> ha it is possible if broken into functions yes. But I think just better to use rawtx or rawTx everywhere consistently 04:54 < wumpus> (although there are "with ..." constructs that can be used to do a kind of block scope, this is not what they're intended for :-) 04:54 < wumpus> yes just use a consistent name 04:55 < NicolasDorier> might do that in a separate PR 04:55 < dcousens> wumpus: indeed that was my second thought 05:12 < wumpus> I'd prefer to do it in the same PR, just fix the underlying issue that caused this typo in the same go 05:12 < wumpus> I much prefer that to just fixing a symptom :) 05:17 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has joined #bitcoin-core-dev 05:36 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:40 < jonasschnelli> NicolasDorier: can you write a description/motivation for #10068? 05:40 < gribble> https://github.com/bitcoin/bitcoin/issues/10068 | [Wallet] FundRawTransaction accepts preset non-wallet inputs by NicolasDorier · Pull Request #10068 · bitcoin/bitcoin · GitHub 05:41 < NicolasDorier> Yes I am doing right now 05:43 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:44 < bitcoin-git> [bitcoin] laanwj closed pull request #9983: tests: Convert selected tests to using named RPC arguments (master...2017_03_rpc_tests_named_arguments) https://github.com/bitcoin/bitcoin/pull/9983 05:45 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has quit [Client Quit] 05:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:49 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:52 < NicolasDorier> jonasschnelli: Just did 05:53 < jonasschnelli> NicolasDorier: I haven't really understand the use case so far.. but what's the reason for using fundraw if it's not your inputs? Why not directly add the inputs in createraw? 05:54 < jonasschnelli> IMO fundraw can topup a tx with some pre-filled inputs 05:54 < NicolasDorier> jonasschnelli: right now fundraw can't topup a tx with pre filled inputs 05:54 < NicolasDorier> if the pre filled inputs are not belonging to the wallet 05:54 < jonasschnelli> NicolasDorier: oh... I think my initial version did support that... 05:54 < jonasschnelli> Ah... that's a point 05:55 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [] 05:55 < NicolasDorier> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/10068/files#diff-b2bb174788c7409b671c46ccc86034bdL2213 05:55 < NicolasDorier> it was in a TODO 05:55 < jonasschnelli> Heh.. at least there was once a plan to do that... okay. I got your point. Thanks for explaining. 05:59 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 05:59 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 05:59 < NicolasDorier> I added "pre filled input" in my description 05:59 < NicolasDorier> it was indeed unclear 06:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a230b0588788...ca209230c8e7 06:00 < bitcoin-git> bitcoin/master 232b666 John Newbery: Allow test cases to be skipped... 06:00 < bitcoin-git> bitcoin/master 0c1ade6 John Newbery: Skip rpcbind_test if OS/network requirements are not met. 06:00 < bitcoin-git> bitcoin/master ca20923 MarcoFalke: Merge #10053: [test] Allow functional test cases to be skipped... 06:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10053: [test] Allow functional test cases to be skipped (master...skiptests) https://github.com/bitcoin/bitcoin/pull/10053 06:05 -!- talmai [~T@173.234.62.155] has joined #bitcoin-core-dev 06:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca209230c8e7...a0b1e57b20a1 06:05 < bitcoin-git> bitcoin/master 88e3aa0 John Newbery: Run extended tests once daily 06:05 < bitcoin-git> bitcoin/master a0b1e57 MarcoFalke: Merge #10052: [test] Run extended tests once daily in Travis... 06:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10052: [test] Run extended tests once daily in Travis (master...traviscronjobs) https://github.com/bitcoin/bitcoin/pull/10052 06:21 -!- talmai [~T@173.234.62.155] has quit [Quit: mining] 06:36 -!- slimeball [jamezz@gateway/shell/panicbnc/x-uaapuvueprcbehpj] has quit [Ping timeout: 258 seconds] 06:42 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds] 06:44 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 240 seconds] 06:45 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:50 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has quit [Ping timeout: 258 seconds] 06:50 -!- Creeper [jamezz@gateway/shell/panicbnc/x-oiillwrkynzqoeef] has joined #bitcoin-core-dev 06:59 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:15 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:15 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 07:30 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:43 -!- talmai [~T@216.200.123.162] has joined #bitcoin-core-dev 07:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 08:03 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 08:12 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 08:14 -!- dfe [~dfe@108.61.17.171] has quit [Quit: dfe] 08:23 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 08:23 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has joined #bitcoin-core-dev 08:28 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 246 seconds] 08:49 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:56 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 09:04 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:08 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 09:17 -!- dodomojo [~goksinen@2604:2000:c591:8400:d8b5:8851:e466:ccbb] has joined #bitcoin-core-dev 09:22 -!- dodomojo [~goksinen@2604:2000:c591:8400:d8b5:8851:e466:ccbb] has quit [Ping timeout: 246 seconds] 09:26 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 09:46 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:52 -!- n1ce [~n1ce@unaffiliated/n1ce] has joined #bitcoin-core-dev 09:57 -!- cryptapus [~Icedove@unaffiliated/cryptapus] has quit [Ping timeout: 256 seconds] 09:57 -!- talmai [~T@216.200.123.162] has quit [Ping timeout: 256 seconds] 10:05 -!- kexkey [~kexkey@184.75.212.51] has joined #bitcoin-core-dev 10:36 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 10:37 -!- talmai [~T@216.200.123.162] has joined #bitcoin-core-dev 10:38 -!- Mario_ [d329e249@gateway/web/freenode/ip.211.41.226.73] has joined #bitcoin-core-dev 10:47 -!- Mario_ [d329e249@gateway/web/freenode/ip.211.41.226.73] has quit [Quit: Page closed] 10:47 -!- makriath [d329e249@gateway/web/freenode/ip.211.41.226.73] has joined #bitcoin-core-dev 10:47 -!- makriath [d329e249@gateway/web/freenode/ip.211.41.226.73] has left #bitcoin-core-dev [] 10:50 -!- talmai [~T@216.200.123.162] has quit [Quit: mining] 10:50 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 10:56 -!- talmai [~T@216.200.123.162] has joined #bitcoin-core-dev 10:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:05 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:09 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:11 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:16 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 11:17 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:19 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 11:20 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 11:20 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:21 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 11:35 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:39 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:46 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 11:46 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 11:46 -!- juscamarena_ [~justin@47.148.176.74] has quit [Remote host closed the connection] 11:53 -!- talmai [~T@216.200.123.162] has quit [Quit: mining] 12:00 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 12:04 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 12:06 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 12:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 12:10 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 12:15 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 12:17 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 260 seconds] 12:18 -!- _biO_ [~biO_@80.156.183.43] has quit [Ping timeout: 240 seconds] 12:19 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 12:20 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:22 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 12:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 12:29 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 12:30 -!- sipa [~pw@2001:19f0:ac01:2fb:5400:ff:fe5b:c3ff] has quit [Changing host] 12:30 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev 12:35 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 12:39 -!- blacczenith [~manjaro-g@174.27.59.211] has joined #bitcoin-core-dev 12:42 -!- CubicEarthh [~cubiceart@50.159.126.21] has joined #bitcoin-core-dev 12:46 -!- _biO_ [~biO_@80.156.183.43] has joined #bitcoin-core-dev 12:49 -!- CubicEarthh [~cubiceart@50.159.126.21] has quit [] 12:54 -!- dodomojo [~goksinen@2604:2000:c591:8400:e91c:1061:aff9:9b6d] has joined #bitcoin-core-dev 12:58 -!- dodomojo [~goksinen@2604:2000:c591:8400:e91c:1061:aff9:9b6d] has quit [Ping timeout: 246 seconds] 13:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 13:07 -!- blacczenith [~manjaro-g@174.27.59.211] has quit [Remote host closed the connection] 13:09 -!- CubicEarthh [~cubiceart@50.159.126.21] has joined #bitcoin-core-dev 13:13 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 240 seconds] 13:15 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 13:28 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 13:29 < bitcoin-git> [bitcoin] jnewbery opened pull request #10072: Remove sources of unreliablility in extended functional tests (master...extended_test_unreliablility) https://github.com/bitcoin/bitcoin/pull/10072 13:29 -!- kvnn [~kvnn@cpe-76-175-103-167.socal.res.rr.com] has joined #bitcoin-core-dev 13:31 < cfields> BlueMatt: ping 13:31 < BlueMatt> yo 13:32 < cfields> BlueMatt: looks like #9605 is hitting the cpu hard 13:32 < gribble> https://github.com/bitcoin/bitcoin/issues/9605 | Use CScheduler for wallet flushing, remove ThreadFlushWalletDB by TheBlueMatt · Pull Request #9605 · bitcoin/bitcoin · GitHub 13:32 < cfields> not sure how i didn't notice pre-merge :( 13:32 < BlueMatt> thats...strange 13:32 < BlueMatt> wtf 13:32 < BlueMatt> grrr, if there's more bugs in cscheduler..... 13:33 < BlueMatt> I assume its in the scheduler thread? 13:33 < cfields> unsure where the overhead is, figured i'd poke you first for ideas 13:34 < cfields> i'm not managing to hit it while it's busy with gdb, so not sure yet 13:34 < BlueMatt> you should be able to see it with top H 13:34 < BlueMatt> (if its scheduler thread) 13:35 < cfields> cool! 13:35 < cfields> yep 13:35 < cfields> (how have i not known this?!) 13:36 < BlueMatt> i dont know 13:38 < sipa> what? top supports threads? 13:38 < BlueMatt> yes! 13:38 < sipa> TIL. 13:38 < BlueMatt> press H while its running to flip 13:38 < sipa> i always used htop for that 13:46 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 13:58 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 14:08 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 14:11 -!- CubicEarthh [~cubiceart@50.159.126.21] has quit [] 14:36 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:38 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:40 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 14:40 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:44 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 15:06 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:09 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:2549:8107:9bdd:4b2e] has joined #bitcoin-core-dev 15:12 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:16 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 256 seconds] 15:16 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 15:26 < bitcoin-git> [bitcoin] jnewbery opened pull request #10073: Actually run assumevalid.py (master...improveassumevalid) https://github.com/bitcoin/bitcoin/pull/10073 15:33 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:33 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 15:36 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 15:37 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 15:41 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 258 seconds] 15:41 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 15:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 16:03 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 16:07 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:2549:8107:9bdd:4b2e] has quit [Ping timeout: 260 seconds] 16:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:32 -!- kexkey [~kexkey@184.75.212.51] has quit [Quit: This computer has gone to sleep] 17:34 < gmaxwell> oh theo, trolling about the openssl license thing by targing unrelated parties: http://marc.info/?l=openbsd-tech&m=149032069130072&w=2 17:39 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 240 seconds] 17:40 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev 17:59 -!- CubicEar_ is now known as CubicEarth_ 18:18 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 18:23 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 18:54 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 19:00 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 264 seconds] 19:08 -!- tunafizz [~tuna@c-71-207-56-72.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 19:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 19:30 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 260 seconds] 19:30 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 19:42 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 19:52 -!- dodomojo [~goksinen@2604:2000:c591:8400:ac7d:5008:37f3:cbfe] has joined #bitcoin-core-dev 19:55 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 258 seconds] 20:00 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 20:03 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 20:08 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 20:32 -!- dodomojo [~goksinen@2604:2000:c591:8400:ac7d:5008:37f3:cbfe] has quit [Remote host closed the connection] 20:44 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tpnsyztujryaszlu] has quit [Quit: Connection closed for inactivity] 20:53 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 21:16 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 21:20 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 21:21 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:22 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:40 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 21:42 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 21:47 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 21:58 -!- chris2000 [~chris2000@p5DCB42FC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 22:01 -!- chris200_ [~chris2000@p5DCB45FA.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 22:03 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Remote host closed the connection] 22:09 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 22:16 < luke-jr> crap, sizefp is broken 22:17 < luke-jr> hm, or is it 22:18 < luke-jr> actually, I think it might be okay. it's possible to produce a fraud proof that lies about the tx count, but you'd never be able to make one that proves it's bigger than it really is I think 22:24 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 22:30 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds] 22:35 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 22:52 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 22:54 -!- cannon-c [ccc23f04@taskhive/supporter/liberland] has joined #bitcoin-core-dev 23:16 -!- harrymm [~wayne@104.222.140.50] has quit [Ping timeout: 260 seconds] 23:30 -!- harrymm [~wayne@104.222.140.117] has joined #bitcoin-core-dev 23:33 < da2ce7> luke-jr: what is the cost of just relaying the full oversized block. Or at least the first 1mb of the block? Most SPV wallets have enough bandwidth for 1mb 23:35 < luke-jr> da2ce7: up to 4 MB with segwit 23:36 < da2ce7> that doesn't sound unreasonable for my phone either. 23:38 < da2ce7> Is SVP fraud proof spam/dos a concern? 23:38 < gmaxwell> da2ce7: yes, because if you don't like your fraud being proven first you claim fraud falsely on every block to every client... all the time and they waste bandwidth. 23:39 < gmaxwell> and the users get pissed and change software or turn off the feature. 23:39 < gmaxwell> though you're right to say that 1mb isn't that burdensom... kinda sad that all these wallets totally screw user privacy to save a bandwidth amount the user probably doesn't care about. 23:44 < da2ce7> Banning the Peer that gives a false proof isn't sufficient? I suppose not, because the new peer that you could connect to could give a false fraud proof again. 23:45 < gmaxwell> well once you're convinced a given block was okay, you never need to fetch it. 23:45 < gmaxwell> er again. 23:45 < gmaxwell> but it can just happen for the next block. 23:46 < gmaxwell> luke-jr: a radically different approach would be able to have miners mergemine a message [Block 0x00023023423 is oversized.]... then you have some minimum difficulty for such messages such that dos is ineffectual. 23:46 < gmaxwell> and when you get one of those messages, you just go download the whole block to check for yourself. 23:47 < da2ce7> cool 23:47 < gmaxwell> hm. well I suppose the attacker can cheaply produce false proofs for all the good blocks, scratch that idea. 23:49 < da2ce7> Banning the offending peer isn't enough? A bad peer can only send 1 bad fraud proof... You would cycle through to 8 good peers quite quickly. 23:52 < da2ce7> You can also have a rate-limit, where if you get a new peer, you won't accept a fraud proof until they have been well behaved for a certain time, (such 1/2 * time connected to longest peer). 23:53 < da2ce7> This will severely rate-limit bad fraud proofs.