--- Day changed Mon Mar 27 2017 00:02 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 00:06 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 256 seconds] 00:06 -!- CubicEarthh [~cubiceart@50.159.126.21] has joined #bitcoin-core-dev 00:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:14 < wumpus> jonasschnelli: yes, I'd also say remove support for qt4. But apparently luke-jr and BlueMatt are still using that 00:15 < jonasschnelli> wumpus: Yes. I just re-read the Qt4 EOL issue... 00:15 < jonasschnelli> Maybe keep it for now... at least we should fix the compiling issue. 00:15 < wumpus> it's kind of annoying, but that's what you get with 'big step' API changes, the old version will virtually stay around forever 00:15 < wumpus> same with python2/3 00:15 < jonasschnelli> Yeah. 00:16 < wumpus> though qt4->qt5 is nowhere as much work as py2->3 00:16 < jonasschnelli> Adding qt4 compilation over travis seems to be not worth it... I guess? 00:16 < wumpus> I'd prefer not to 00:16 < jonasschnelli> Okay. Lets fix then the compilation issue whenever someone reports them. 00:16 < luke-jr> wumpus: and we don't need to support Py2 because Py3 is everywhere and works as well 00:17 < wumpus> I'd prefer some timeframe for dropping qt4, but should be announced upfront 00:17 < luke-jr> jonasschnelli: I already added Qt4 to Travis a while ago, and was under the impression we had a daily (not every PR) running it 00:18 < luke-jr> it's funny how Qt5 is more compatible with GTK2 than it is with Qt4 00:18 < wumpus> ironically qt3->qt4 was a bigger step, and people ported software over quicker 00:18 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 00:18 < luke-jr> they did? O.o 00:18 < luke-jr> IIRC KDE 4 took a looong time 00:18 < luke-jr> and even today, KMail isn't up to par with the Qt3 version 00:18 < wumpus> how I remember things they did, almost every project saw the need of supporting qt4 immediately, and it was very hard to support both 3 and 4 so 3 was pretty quickly dropped 00:19 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:19 < wumpus> qt5 on the other hand, maybe because it's releatiively easy to suport both 4 and 5, takes longer 00:19 < wumpus> but it's just anecdotal I don't have numbers to back it up 00:20 < wumpus> qt5 does have some nice new features the thing is we don't really need them, at least not for the essential features 00:20 < luke-jr> you mean dropping the old vs supporting the new, then? 00:20 < wumpus> I gues 00:21 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:21 < luke-jr> IMO old should only be dropped when it becomes a burden; so Qt4->Qt5 being minimal delays that because the burden is somewhat low 00:21 < wumpus> yes I mean qt3 was dead sooner than qt4 00:21 < wumpus> I'm fine with supporting qt4 as long as some of us compile with that and use it 00:22 < wumpus> if not it means it goes largely untested 00:22 < wumpus> in any case i'm not worried about a "doesn't compile with qt4" issue once in half a year which usually gets promptly fixed 00:23 < wumpus> I'm much more worried about the wshadow diff noise 00:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 00:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 00:24 < wumpus> that's more work to support than qt4 00:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 00:25 < jonasschnelli> wumpus: wshadow: you mean because of your statement: "There's a large chance that one of the 'fixes' for WShadow, which seem to trail any larger change in the source code, introduce a bug."? 00:25 < wumpus> jonasschnelli: yes 00:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/111849345bb5...c044f03f99ba 00:25 < bitcoin-git> bitcoin/master dd5be2c NicolasDorier: [QA] Renaming rawTx into rawtx 00:25 < bitcoin-git> bitcoin/master c044f03 Wladimir J. van der Laan: Merge #10083: [QA] Renaming rawTx into rawtx... 00:25 < wumpus> jonasschnelli: every single variable in the source code seems to be in progress of being renamed 00:25 < jonasschnelli> Can we disable WShadow for the QT part? 00:25 < bitcoin-git> [bitcoin] laanwj closed pull request #10083: [QA] Renaming rawTx into rawtx (master...fundrawtransactionfix) https://github.com/bitcoin/bitcoin/pull/10083 00:25 < wumpus> I think we should disable wsshadow, full stop 00:26 < wumpus> but I'm starting to sound like a broken record on that 00:26 < jonasschnelli> heh... I have no strong opinion on that. 00:26 < jonasschnelli> But the warnings are definitively annoying. 00:26 < wumpus> it was just a mistake to enable it, and that's only been confirmed 00:26 < jonasschnelli> Yes. It seems like. 00:27 < jonasschnelli> What's the benefits of enabling it? IMO compilers handle it pretty well,... right? 00:27 < wumpus> and yes, some of the annoyance may go away when disabling it for certain compilers, or parts of the code base 00:27 < wumpus> compilers handle it fine, it's people that sometimes do not. We had one bug that was hidden by shadowing 00:28 < wumpus> I don't think this whole operation has found any other 00:28 < jonasschnelli> I see... 00:28 < wumpus> #8102 is the bug that set it all in motion 00:28 < gribble> https://github.com/bitcoin/bitcoin/issues/8102 | Bugfix: use global ::fRelayTxes instead of CNode in version send by sipa · Pull Request #8102 · bitcoin/bitcoin · GitHub 00:32 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 240 seconds] 00:33 -!- CubicEarthh [~cubiceart@50.159.126.21] has quit [Ping timeout: 260 seconds] 00:35 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:28a1:88a6:559f:d1a8] has joined #bitcoin-core-dev 00:35 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c044f03f99ba...db1ae5470bab 00:35 < bitcoin-git> bitcoin/master d5690f1 Jameson Lopp: remove 'noconnect' option from documentation 00:35 < bitcoin-git> bitcoin/master db1ae54 Wladimir J. van der Laan: Merge #10085: Docs: remove 'noconnect' option... 00:35 < bitcoin-git> [bitcoin] laanwj closed pull request #10085: Docs: remove 'noconnect' option (master...noconnect) https://github.com/bitcoin/bitcoin/pull/10085 00:38 -!- Victor_sueca is now known as Victorsueca 00:42 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:85dd:3ee8:8c9a:5561] has joined #bitcoin-core-dev 00:43 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:28a1:88a6:559f:d1a8] has quit [Ping timeout: 258 seconds] 00:46 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 00:48 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:85dd:3ee8:8c9a:5561] has quit [Ping timeout: 258 seconds] 00:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/db1ae5470bab...b1a4f2757695 00:51 < bitcoin-git> bitcoin/master 717ad13 John Newbery: Actually run assumevalid.py.... 00:51 < bitcoin-git> bitcoin/master b1a4f27 Wladimir J. van der Laan: Merge #10073: Actually run assumevalid.py... 00:51 -!- bambum [~bumbuma@91.126.31.85] has joined #bitcoin-core-dev 00:51 < bitcoin-git> [bitcoin] laanwj closed pull request #10073: Actually run assumevalid.py (master...improveassumevalid) https://github.com/bitcoin/bitcoin/pull/10073 00:51 < bambum> hi 00:54 < bambum> last time I was told core dont want to decide about what people want to run, but some commits being closed and locked after 4 minutes about block site increase should be at least commented why they are closed and locked https://github.com/bitcoin/bitcoin/pull/10092 00:54 < bambum> otherwise ppl talking about it all over the place: https://bitcointalk.org/index.php?topic=1842146.220 00:55 < bambum> so someone awake might answer be that question, thanks 00:56 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b1a4f2757695...0ddea4430d62 00:56 < bitcoin-git> bitcoin/master 4df76e2 Andrew Chow: Ensure an item exists on the rpcconsole stack before adding... 00:56 < bitcoin-git> bitcoin/master 0ddea44 Jonas Schnelli: Merge #10060: [Qt] Ensure an item exists on the rpcconsole stack before adding... 00:56 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10060: [Qt] Ensure an item exists on the rpcconsole stack before adding (master...fix-rpcconsole-empty-stack) https://github.com/bitcoin/bitcoin/pull/10060 00:56 -!- dodomojo [~goksinen@2604:2000:c591:8400:3d11:9a97:a177:5dec] has joined #bitcoin-core-dev 00:56 -!- jouke [~jouke@5353D8FC.cm-6-4d.dynamic.ziggo.nl] has quit [Quit: leaving] 00:59 < gmaxwell> bambum: presumably because it was broken garbage-- would instantly break everything, didn't even pass the tests-- and submitted by someone who has made nasty comments in the past. No one is going to waste their time on trolling. 00:59 < wumpus> bambum: because it is trolling 01:00 < wumpus> he's not exactly the first to open a pull like that 01:00 < wumpus> it's not funny, it's not constructive 01:00 -!- jouke [~worst@unaffiliated/komkommer] has joined #bitcoin-core-dev 01:00 -!- dodomojo [~goksinen@2604:2000:c591:8400:3d11:9a97:a177:5dec] has quit [Ping timeout: 246 seconds] 01:00 < wumpus> the only sensible reply is to block it and ignore it and continue on as normal 01:01 < bambum> ok, but for better transparency it should be commented, just a copy past would be enough "trolling" is not specified. For someone like me it hard to know, I thought also it might not fit into some rules, but a clear comment why it is closed would be good 01:01 < wumpus> also this is not about 'deciding about what people want to run' but concerns our project 01:02 < wumpus> attacking our project with random PRs is only going to get you banned 01:02 < wumpus> that's the end of this discussion. Please try to keep drama out of this channel. 01:02 < bambum> there was nowhere drama in my questions, it was a fair question, you are over interpreting it 01:03 < bambum> I wish more transparency 01:03 < jonasschnelli> bambum: please... 01:04 < wumpus> we are not obliged to give any motivation for closing issues, or giving you any extra information. Most of the people involved here are volunteers and their time they can spend on this project is very limited and better directed to useful purposes 01:04 < jonasschnelli> You need to understand how tiresome such PRs are... it's like trowing a stones into gears. 01:04 < jonasschnelli> s/a// 01:04 < wumpus> jonasschnelli: yes, it's just tiring, drags on and on and on 01:04 < wumpus> at some point you get annoyed and just close things 01:04 < bambum> @jonasschnelli yes but how can I recognize it as someone not being involved in techs ? 01:04 < gmaxwell> Any any comment left is just trolled against. 01:05 < wumpus> bambum: again, this channel and github is for doing development 01:05 < bambum> so you saying you can recognize its trolling just by seeing the code ? 01:05 < bambum> @wumpus you dont understand the point 01:05 < jonasschnelli> bambum: It's like changing the default port number from 80 to 13735 in apache... It's not serious.. everyone at bitcoin github level must understand this... 01:05 < wumpus> bambum: maybe not, but you're starting to annoy me 01:05 < bambum> I am talking about transparency, everyone should now what is happening 01:05 < gmaxwell> bambum: sure, like the fact that it didn't even pass the selftests. it wasn't an actual proposal for anything. 01:06 < bambum> know 01:06 < jonasschnelli> bambum: It's clear what happend. Somebody started to throw a stone. It got rejected. Fullstop. 01:06 < wumpus> bambum: this is the second time in a few days that you're monopolizing this channel with discussion about non-development things 01:06 < jonasschnelli> Yes. Let's stop this here. 01:06 < jonasschnelli> Move this on to #bitcoin if you like 01:07 < wumpus> please mind the topic of this channel "This is the channel for developing Bitcoin Core. Feel free to watch, but please take commentary and usage questions to #bitcoin" 01:07 < bambum> wumpus this was something what happend on the github website, last time i was here in the channel I was told that core dont want to influent peoples what do to, so I had a question about 01:08 < wumpus> we don't influence 'peoples what to do' but we do influence our own project 01:08 < bambum> I appreciate having the option to talk about it 01:08 < bambum> and the only think i am requesting is more transparency 01:09 < gmaxwell> bambum: request heard. now please stop repeating it. 01:10 < gmaxwell> (and while you're at it, go look at the post history of the person making that PR, you'll find it quite informative) 01:10 < bambum> jonasschnelli yes for me it was not so easy to understand it 01:10 < bambum> I just had the idea that his code don´t fits into some rules 01:10 < bambum> but needs to be commented imo, especially nowatimes 01:11 < gmaxwell> K. 01:20 -!- chris2000 is now known as schnerchi 01:21 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:22 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 01:23 < wumpus> jonasschnelli: at least github deleted the fake jonasschneli account 01:23 < jonasschnelli> wumpus: heh. Yes. I reported it and ~48h later they deleted it. 01:23 < jonasschnelli> Not superfast but still okay. 01:24 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 01:25 -!- schnerchi is now known as chris20000 01:25 -!- chris20000 is now known as chris2000 01:25 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #10093: [Qt] Don't add arguments of sensitive command to console window (master...2017/03/qt_console) https://github.com/bitcoin/bitcoin/pull/10093 01:26 -!- chris2000 [~chris2000@p5DCB5523.dip0.t-ipconnect.de] has quit [] 01:26 -!- schnerchi [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:27 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:27 -!- schnerchi [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has quit [Client Quit] 01:28 -!- schnerchi [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:29 < jonasschnelli> wumpus: did you assigned yourself intentionally for this PR https://github.com/bitcoin/bitcoin/pull/8694 01:29 < wumpus> jonasschnelli: yes 01:29 < jonasschnelli> Okay. Good to know... 01:29 -!- schnerchi [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has quit [Client Quit] 01:30 -!- schnerchi [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:30 -!- schnerchi [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has quit [Client Quit] 01:34 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0ddea4430d62...e6156a0aa329 01:34 < bitcoin-git> bitcoin/master 5ba61f0 Karl-Johan Alm: [zmq] Call va_end() on va_start()ed args. 01:34 < bitcoin-git> bitcoin/master e6156a0 Wladimir J. van der Laan: Merge #10056: [zmq] Call va_end() on va_start()ed args.... 01:35 < bitcoin-git> [bitcoin] laanwj closed pull request #10056: [zmq] Call va_end() on va_start()ed args. (master...fix-zmqpublishnotifier-va-end) https://github.com/bitcoin/bitcoin/pull/10056 01:37 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6156a0aa329...5114f8113627 01:37 < bitcoin-git> bitcoin/master 81a3857 Thomas Snider: Deduplicated sigaction() boilerplate 01:37 < bitcoin-git> bitcoin/master 5114f81 Wladimir J. van der Laan: Merge #10057: [init] Deduplicated sigaction() boilerplate... 01:37 < bitcoin-git> [bitcoin] laanwj closed pull request #10057: [init] Deduplicated sigaction() boilerplate (master...tjps_dedupe_sigaction) https://github.com/bitcoin/bitcoin/pull/10057 01:38 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 258 seconds] 01:40 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:8827:3880:15c4:6e1c] has joined #bitcoin-core-dev 01:42 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 01:43 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 01:48 -!- vicenteH [~user@96.235.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:49 -!- schnerchi [~schnerchi@2a01:4f8:c0c:afe::2] has joined #bitcoin-core-dev 01:57 < schnerchi> . 01:57 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:6511:95a8:2306:df05] has joined #bitcoin-core-dev 01:57 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:8827:3880:15c4:6e1c] has quit [Ping timeout: 260 seconds] 02:03 -!- schnerchi123 [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:04 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 02:05 < bambum> @gmaxwell thanks for commenting the commit, imo it would be totally enough to list like "locked for -" or "banned for -" 1. Submitting broken code 2. Not passing self-tests 3. Breaking network .. next time. Even a bot can do this, if devs prefer to not comment themself the lock or the bann. Would save up some energy. 02:06 -!- schnerchi123 [~schnerchi@p5DCB5523.dip0.t-ipconnect.de] has quit [Quit: Leaving...] 02:12 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 02:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #10094: 0.14: Clear release notes (0.14...Mf1703-014docClear) https://github.com/bitcoin/bitcoin/pull/10094 02:21 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 02:21 -!- _biO_ [~biO_@80.156.183.43] has quit [Remote host closed the connection] 02:24 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds] 02:54 < bitcoin-git> [bitcoin] laanwj closed pull request #10094: 0.14: Clear release notes (0.14...Mf1703-014docClear) https://github.com/bitcoin/bitcoin/pull/10094 02:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/ccb47bf83036...37bf0d5b381f 02:54 < bitcoin-git> bitcoin/0.14 eeeeacd MarcoFalke: 0.14: Clear release notes 02:54 < bitcoin-git> bitcoin/0.14 37bf0d5 Wladimir J. van der Laan: Merge #10094: 0.14: Clear release notes... 03:04 -!- Colten [~Colten@188.226.139.184] has quit [Remote host closed the connection] 03:04 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 03:06 -!- harrymm [~wayne@104.237.91.156] has joined #bitcoin-core-dev 03:07 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:6511:95a8:2306:df05] has quit [Ping timeout: 260 seconds] 03:10 -!- cannon-c [ccc23f04@taskhive/supporter/liberland] has quit [Quit: Page closed] 03:14 -!- shesek [~shesek@bzq-84-110-235-123.red.bezeqint.net] has quit [Ping timeout: 240 seconds] 03:17 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has joined #bitcoin-core-dev 03:17 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 03:20 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has quit [Remote host closed the connection] 03:38 -!- idufohid [~Mutter@2a02:2f0a:b070:12e0:7137:4dc4:eaf1:1a8e] has joined #bitcoin-core-dev 03:39 -!- idufohid [~Mutter@2a02:2f0a:b070:12e0:7137:4dc4:eaf1:1a8e] has quit [Client Quit] 03:51 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:21 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:26 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 04:32 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 256 seconds] 04:37 -!- Naphex [~naphex@naphex.rocks] has quit [Ping timeout: 240 seconds] 04:37 -!- Naphex [~naphex@naphex.rocks] has joined #bitcoin-core-dev 04:47 -!- bambuma [~bumbuma@95.211.172.35.adsl.inet-telecom.org] has joined #bitcoin-core-dev 04:50 < jonasschnelli> wumpus: there is a travis issue with your #9902 (https://travis-ci.org/bitcoin/bitcoin/jobs/215449039#L2083) 04:50 < gribble> https://github.com/bitcoin/bitcoin/issues/9902 | Lightweight abstraction of boost::filesystem by laanwj · Pull Request #9902 · bitcoin/bitcoin · GitHub 04:51 -!- bambum [~bumbuma@91.126.31.85] has quit [Ping timeout: 268 seconds] 04:52 < wumpus> jonasschnelli: in the qt tests?! that's weird 04:53 < wumpus> undefined reference to `vtable for boost::unit_test::unit_test_log_t' 04:53 < wumpus> I don't get it 04:53 < jonasschnelli> Yes. Strage error indeed. Maybe rebase? 04:53 < wumpus> I just rebased it 04:56 -!- JackH [~laptop@79.73.184.8] has joined #bitcoin-core-dev 04:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 04:59 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 05:01 -!- harrymm [~wayne@104.237.91.156] has quit [Ping timeout: 268 seconds] 05:17 -!- harrymm [~wayne@104.237.91.105] has joined #bitcoin-core-dev 05:22 < jonasschnelli> wumpus: https://github.com/bitcoin/bitcoin/pull/9902#issuecomment-289437353 05:22 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:24 < wumpus> jonasschnelli: thanks, makes sense 05:25 < wumpus> seems unrelated to that pull though, I don't get why it starts failing there 05:25 < wumpus> or why it works now 05:25 < jonasschnelli> Yes. I wonder why it works now... 05:27 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 05:32 < bitcoin-git> [bitcoin] laanwj opened pull request #10095: refactor: Move GetDifficulty out of `rpc/server.h` (master...2017_03_getdifficulty_header) https://github.com/bitcoin/bitcoin/pull/10095 05:33 < wumpus> jonasschnelli: we didn't use to use boost test framework in the qt tests 05:34 < jonasschnelli> But your PR doesn't change that? Or does it? 05:34 < wumpus> no, it doesn't do anything with that 05:34 < wumpus> makes sense to PR that separately 05:35 < wumpus> uhm, we're still not using boost::test in the qt tests, I don't understand why we'd need that library 05:35 < jonasschnelli> Okay. I'll PR it. 05:36 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 246 seconds] 05:36 < wumpus> well let's try to find out why it's needed first, I'm not sure anymore, I thought we had a good reason, but there's no reference to boost test in the qt tests 05:37 < wumpus> so that change should not be necessary :/ 05:38 < jonasschnelli> It's seems to be for the logging.... 05:39 < wumpus> the only three occurences of 'boost' or 'BOOST' in src/qt/test are: #include boost::filesystem::remove_all boost::signals2::scoped_connection 05:40 < wumpus> boost is not used for logging nor evaluating test cases 05:40 * wumpus confused 05:43 < wumpus> argh 05:44 < wumpus> wallettests.cpp includes test/test_bitcoin.h 05:44 < wumpus> maybe that indirectly imports some boost test stuff? 05:46 < wumpus> ideally the qt tests would test with a mocked wallet model instead of importing all the core stuff 05:47 < jonasschnelli> hmm. Yes. That probably the issue. 05:48 < wumpus> oh it even links against test_bitcoin.cpp 05:49 < jonasschnelli> wumpus: but even after I remove the #include "test/test_bitcoin.h" (and remove the test code), I still get the linker issue 05:49 < wumpus> that one certainly uses boost::test 05:49 < jonasschnelli> ah... thats it! 05:49 < jonasschnelli> I don't think this can be fix easily. 05:49 < wumpus> bleh, the test utils should not themselves rely on any test framework 05:49 < wumpus> e.g. testutil.cpp is fine 05:50 < wumpus> I don't think so either, I think it was mistake to make the qt and normal tests interdependent like this 05:50 < wumpus> anyhow no big deal to make qt tests depend on boost::unittest 05:50 < wumpus> at least we know why, now 05:51 < jonasschnelli> But why does this work in current master?! 05:51 < wumpus> maybe we should go all the way and make the qt tests a boost test runner as well... but fixing it for now is easy just add the lib 05:51 < wumpus> I don't know 05:53 < jonasschnelli> wumpus: Yes. Let's fix the missing lib add, then let's see if ryanofsky is up for a clean split 05:54 < wumpus> well it needs to be one of either: either the qt tests go fully boost::unit_test, or the shared code between the two test suites should be independent on the test framework 05:54 < wumpus> either is fine with me, but using a few functions from boost::unit_test through linking in test_bitcoin.cpp *without* using the framework is asking for trouble 05:55 < wumpus> e.g. what happens if you do BOOST_ASSERT while not in a boost unit test 05:56 < jonasschnelli> Indeed 05:56 < wumpus> hm! but seems he took that into account 05:56 < wumpus> I don't see references to boost_test in test_bitcoin.cpp 05:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:56 < wumpus> it's no longer the test main file 05:58 < wumpus> what, I don't get it, I remember I added some BOOST_REQUIRE to TestingSetup at some point 05:59 < wumpus> I'm really, raelly confused now 05:59 < wumpus> that wasn't #9902 at least 05:59 < gribble> https://github.com/bitcoin/bitcoin/issues/9902 | Lightweight abstraction of boost::filesystem by laanwj · Pull Request #9902 · bitcoin/bitcoin · GitHub 06:01 < wumpus> oh 91e3035 removed those again 06:01 < wumpus> " Make test_bitcoin.cpp compatible with Qt Test framework" 06:02 < wumpus> then... what does 9902 change that re-introduces boost::unittest in either test_bitcoin.cpp or the qt tests? 06:03 < wumpus> OH I see! https://github.com/bitcoin/bitcoin/pull/9902/files#diff-d5ba361c5f8be78eb4cc0c787c1fc78eR28 06:03 < wumpus> accidentally re-adding the header 06:03 < jonasschnelli> ahh,... 06:03 < jonasschnelli> right. 06:04 < jonasschnelli> wumpus: so the non QT test_bitcoin is "boost/QT" free and can be included from both worlds.. right? 06:04 < wumpus> yep 06:05 < jonasschnelli> Okay. Got it... all good then. Then its just the accidentally added "include ". 06:05 < jonasschnelli> Great. At least we know now. :) 06:06 < wumpus> re-pushed with that line removed, let's see 06:14 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 06:20 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 260 seconds] 06:23 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has joined #bitcoin-core-dev 06:27 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 06:28 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has quit [Ping timeout: 256 seconds] 06:35 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:37 -!- bambuma [~bumbuma@95.211.172.35.adsl.inet-telecom.org] has quit [Quit: Leaving] 07:08 -!- Annabelle [~Annabelle@188.226.139.184] has joined #bitcoin-core-dev 07:08 -!- riemann [~riemann@ip-222-88.ists.pl] has joined #bitcoin-core-dev 07:08 -!- Annabelle is now known as Guest53386 07:24 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has joined #bitcoin-core-dev 07:24 -!- adiabat [~adiabat@45.63.20.152] has quit [Ping timeout: 246 seconds] 07:27 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 07:28 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has quit [Ping timeout: 258 seconds] 07:32 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 07:33 -!- harrymm [~wayne@104.237.91.105] has quit [Ping timeout: 260 seconds] 07:36 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 07:45 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:49 -!- harrymm [~wayne@45.56.152.52] has joined #bitcoin-core-dev 07:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:59 -!- n1ce [~n1ce@unaffiliated/n1ce] has joined #bitcoin-core-dev 08:03 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 08:08 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:10 -!- dodomojo [~goksinen@2604:2000:c591:8400:44d5:bbd4:9863:c489] has joined #bitcoin-core-dev 08:14 -!- dodomojo [~goksinen@2604:2000:c591:8400:44d5:bbd4:9863:c489] has quit [Ping timeout: 246 seconds] 08:23 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 08:24 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:29 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 08:30 -!- n1ce [~n1ce@unaffiliated/n1ce] has quit [Quit: bbl] 08:32 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 08:35 < bitcoin-git> [bitcoin] JeremyRubin closed pull request #9495: Fix CCheckQueue IsIdle (potential) race condition (master...checkqueue-control-lock) https://github.com/bitcoin/bitcoin/pull/9495 08:37 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:37 -!- harrymm [~wayne@45.56.152.52] has quit [Ping timeout: 240 seconds] 08:40 < bitcoin-git> [bitcoin] jnewbery opened pull request #10096: Check that all test scripts in test/functional are being run (master...check_all_tests_run) https://github.com/bitcoin/bitcoin/pull/10096 09:02 -!- shesek [~shesek@bzq-84-110-235-123.red.bezeqint.net] has joined #bitcoin-core-dev 09:09 < BlueMatt> jonasschnelli: as noteed in the issue qt4 -> qt5 introduces regressions 09:09 < BlueMatt> we need to fix those before we can turn it off 09:10 < BlueMatt> major regressions that break peoples' ability to use Bitcoin-Qt, that is 09:15 < bitcoin-git> [bitcoin] jnewbery opened pull request #10097: Move zmq test skipping logic into individual test case. (master...zmq_optional) https://github.com/bitcoin/bitcoin/pull/10097 09:22 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 09:26 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has joined #bitcoin-core-dev 09:30 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has quit [Ping timeout: 260 seconds] 09:30 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:34 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 246 seconds] 09:35 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 09:40 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 10:00 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 10:09 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has joined #bitcoin-core-dev 10:09 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:11 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 10:12 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:34 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 10:42 -!- riemann [~riemann@ip-222-88.ists.pl] has quit [Ping timeout: 256 seconds] 10:49 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev 11:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:24 -!- n1ce [~n1ce@unaffiliated/n1ce] has joined #bitcoin-core-dev 11:31 -!- riemann [~riemann@ip-222-88.ists.pl] has joined #bitcoin-core-dev 11:47 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10098: Make qt wallet test compatible with qt4 (master...pr/wqt4) https://github.com/bitcoin/bitcoin/pull/10098 11:50 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 11:51 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:54 -!- ovovo is now known as owowo 12:12 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 12:14 -!- talmai [~T@77.60.103.234] has joined #bitcoin-core-dev 12:17 -!- caracareddit [98f9022f@gateway/web/freenode/ip.152.249.2.47] has joined #bitcoin-core-dev 12:26 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 12:27 -!- mol is now known as moli 12:30 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:34 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:d987:74b6:62a0:2383] has quit [Ping timeout: 256 seconds] 12:35 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 12:35 -!- michagogo [uid14316@wikia/Michagogo] has quit [Ping timeout: 255 seconds] 12:37 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 12:37 < bitcoin-git> [bitcoin] kallewoof closed pull request #10062: [net] Clean up the CNode class in net.h (master...20170322-cleanup-net) https://github.com/bitcoin/bitcoin/pull/10062 12:39 -!- frabrunelle1 [frabrunell@gateway/shell/matrix.org/x-getsfljzwwmstjql] has joined #bitcoin-core-dev 12:39 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 12:40 -!- xhire_ [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 12:41 -!- abpa [~abpa@104.200.154.103] has joined #bitcoin-core-dev 12:41 -!- frabrunelle [frabrunell@safenetwork/frabrunelle] has quit [Ping timeout: 255 seconds] 12:41 -!- xHire [~xHire@kos.paskuli.cz] has quit [Ping timeout: 255 seconds] 12:42 -!- xhire_ is now known as xHire 12:44 -!- abpa_ [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:44 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #10099: Speedup & Slightly Improve Unit Tests for Checkqueue (master...speedup-checkqueue-tests) https://github.com/bitcoin/bitcoin/pull/10099 12:46 -!- abpa [~abpa@104.200.154.103] has quit [Ping timeout: 260 seconds] 12:49 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-irumhxejtzsqbyxp] has quit [Ping timeout: 255 seconds] 12:50 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-sjpvetdnmvpievwd] has joined #bitcoin-core-dev 12:50 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:51 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 12:56 -!- root-servers [~root-serv@112.208.12.243] has joined #bitcoin-core-dev 12:57 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 13:00 -!- root-servers [~root-serv@112.208.12.243] has quit [Remote host closed the connection] 13:05 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:52e:a890:4a02:b808] has joined #bitcoin-core-dev 13:10 -!- talmai [~T@77.60.103.234] has quit [Quit: mining] 13:21 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 13:24 < BlueMatt> jonasschnelli: ping 13:26 -!- caracareddit [98f9022f@gateway/web/freenode/ip.152.249.2.47] has quit [Quit: Page closed] 13:41 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 256 seconds] 13:41 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 13:46 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 13:50 -!- riemann [~riemann@ip-222-88.ists.pl] has quit [Quit: Leaving] 13:51 -!- ndriggs [80876469@gateway/web/freenode/ip.128.135.100.105] has joined #bitcoin-core-dev 13:56 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 13:59 -!- CubicEar_ [~cubiceart@97.41.128.86] has joined #bitcoin-core-dev 14:00 -!- ndriggs [80876469@gateway/web/freenode/ip.128.135.100.105] has left #bitcoin-core-dev [] 14:02 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:52e:a890:4a02:b808] has quit [Ping timeout: 258 seconds] 14:02 -!- talmai [~T@77.60.103.234] has joined #bitcoin-core-dev 14:02 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:06 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 14:07 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 14:07 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 14:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:14 -!- abpa_ [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:16 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:18 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:22 < bitcoin-git> [bitcoin] RHavar opened pull request #10100: Make ApproximateBestSubset optimize for amount of inputs (master...coinselection) https://github.com/bitcoin/bitcoin/pull/10100 14:24 -!- talmai [~T@77.60.103.234] has quit [Ping timeout: 256 seconds] 14:26 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:27 -!- CubicEar_ [~cubiceart@97.41.128.86] has quit [Read error: Connection reset by peer] 14:28 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 260 seconds] 14:35 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 14:38 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 14:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #10101: [0.14] backports (0.14...Mf1703-014backp) https://github.com/bitcoin/bitcoin/pull/10101 14:41 -!- bitcoinreminder_ [uid220256@gateway/web/irccloud.com/x-fvsncsoiejyamkkx] has left #bitcoin-core-dev [] 14:42 -!- bitcoinreminder_ [uid220256@gateway/web/irccloud.com/x-fvsncsoiejyamkkx] has joined #bitcoin-core-dev 14:46 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:47 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 14:48 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10102: bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP) (master...pr/ipc) https://github.com/bitcoin/bitcoin/pull/10102 14:54 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:54 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 14:59 < cfields> ryanofsky: cool! 15:04 -!- CubicEar_ [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 15:05 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:7d1e:f698:2bc2:1ad7] has joined #bitcoin-core-dev 15:10 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:7d1e:f698:2bc2:1ad7] has quit [Ping timeout: 260 seconds] 15:15 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:16 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 15:17 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:18 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:21 < achow101> does anyone know if the way that Core 0.14 broadcasts messages has changed from the way the 0.13.2 did? 15:22 < sipa> can you be more specific? 15:23 < achow101> I guess more specific would be how network packets are being sent 15:23 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 15:23 < sipa> there have been significant changes to that, yes 15:24 < sipa> not sure whether those should be observable, though 15:25 < achow101> I think I mentioned this several months ago when I first started looking into this issue. On Armory, I have noticed that it was receiving and processing message headers separately from the message payloads 15:25 -!- CubicEarthh [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 15:25 < achow101> it would appear that this behavior is caused by something in 0.14.0 since people have only been reporting the issue since 0.14.0's release 15:25 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:71cd:da2b:b5f1:7f7e] has joined #bitcoin-core-dev 15:25 < achow101> I only noticed because I always run a build of the master branch. 15:26 < sipa> define 'separate' ? 15:26 < achow101> it would interpret the message header as a message, and then interpret the message payload as a completely new message 15:26 < sipa> TCP does not have messages 15:26 < sipa> it is a byte stream 15:26 < achow101> message being the bitcoin p2p messages 15:27 < cfields> achow101: yes, that's possible now 15:27 < sipa> that makes no sense... a p2p message is defined as a header + payload 15:27 < sipa> you're asking whether a message can consist of a message and a message 15:27 < sipa> cfields: it was always possible 15:27 < achow101> cfields: how so? 15:27 < cfields> sipa: tcp fast-send + split message sends 15:27 < phantomcircuit> sipa, im guessing they screwed up and are assuming the entire message will be received in a single recv() 15:28 < cfields> sec for some grepping so i can use better terms 15:28 < sipa> phantomcircuit: yes, that's my assumption too, but that would have always been a bug 15:28 < achow101> phantomcircuit: well we never saw this issue before 0.14.0 15:28 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:28 < phantomcircuit> sipa, yeah but wouldn't have been easily triggered until recently 15:28 < BlueMatt> phantomcircuit: in that case you'd also see it for big messages 15:28 < BlueMatt> (>~1k) 15:28 < sipa> achow101: yes, it's now done as separate send calls 15:28 < cfields> TCP_NODELAY + separate sends 15:28 < phantomcircuit> BlueMatt, not if they have a huge recv buffer and are on localhost always 15:28 < phantomcircuit> which they are 15:28 < achow101> we fixed the issue on our end, but I just wanted to figure out why that happened since it only appeared when people used 0.14.0 15:28 < cfields> make it likely that you'll receive the header in the first chunk 15:29 < BlueMatt> phantomcircuit: you still usually see it for things >>1k 15:29 < BlueMatt> eg 1MB you'd def see it 15:29 < phantomcircuit> uh 15:29 < phantomcircuit> hmm let me see 15:29 < phantomcircuit> i dont think that's right 15:29 < BlueMatt> localhost can be surprisingly slow somteimts 15:29 < BlueMatt> sometimes 15:30 < sipa> achow101: so, yes, there has been a change where header and payload are now sent through separate kernel calls, which makes it much more likely you'll see them in separate recv() calls 15:30 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 15:30 < achow101> ok. thanks 15:30 < achow101> we fixed the problem, I just wanted to know why it was a problem in the first place 15:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 15:31 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 240 seconds] 15:31 < sipa> it should always have been possible to see this; TCP does not guarantee that message boundares are preserved 15:31 < gmaxwell> it's easy in tcp applications to write bugs where you assume your reads will always contain a complete message... when the remote end used a single write (or nagle merged them)... then something changes and the reads are short. 15:31 < sipa> but on localhost i guess it would be unlikely 15:32 < achow101> well I don't know how it was originally implemented in Armory nor how it was fixed. I just know that one day it magically started giving me errors for something that had never happened in a previous version of core 15:32 < achow101> anyways, thanks for the info 15:33 < cfields> well also if you're receiving a few messages in one read, it'd be very likely that a header would span 2 chunks 15:33 < cfields> so seems strange that that would've ever worked :) 15:33 < phantomcircuit> BlueMatt, why do i get two sendcmpt messages for every connection? 15:33 < BlueMatt> phantomcircuit: thats how the version negotiation works 15:34 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 15:39 -!- CubicEarthh [~cubiceart@2002:329f:7e15:0:71cd:da2b:b5f1:7f7e] has quit [Ping timeout: 260 seconds] 15:47 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 15:48 -!- vicenteH [~user@96.235.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 15:57 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 15:57 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has left #bitcoin-core-dev ["Leaving"] 15:57 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 16:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection] 16:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 16:09 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 264 seconds] 16:16 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:21 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 16:24 -!- whphhg [whphhg@gateway/vpn/mullvad/x-wsqkihdtdwgzlvbs] has joined #bitcoin-core-dev 16:33 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.] 16:50 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 17:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:01 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 17:06 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 17:12 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 17:13 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 17:15 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 17:17 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 17:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wiasoimxtzuzwkqm] has quit [Quit: Connection closed for inactivity] 18:03 -!- abpa [~abpa@2602:306:b837:dbf0:8093:4a95:713:71d7] has joined #bitcoin-core-dev 18:03 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 18:07 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 18:11 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 246 seconds] 18:25 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 240 seconds] 18:26 -!- nejon [uid38993@gateway/web/irccloud.com/x-vxjlpgfjwrdbortd] has quit [Ping timeout: 240 seconds] 18:26 -!- sipa [~pw@unaffiliated/sipa1024] has quit [Ping timeout: 240 seconds] 18:28 -!- sipa [~pw@2001:19f0:ac01:2fb:5400:ff:fe5b:c3ff] has joined #bitcoin-core-dev 18:28 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Remote host closed the connection] 18:28 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 18:28 -!- jrayhawk_ [~jrayhawk@nursie.omgwallhack.org] has quit [Remote host closed the connection] 18:28 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev 18:41 -!- abpa [~abpa@2602:306:b837:dbf0:8093:4a95:713:71d7] has quit [Quit: Textual IRC Client: www.textualapp.com] 18:42 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 18:45 < jcorgan> does anyone know if the digital garage presentation will be live streamed? 19:00 < phantomcircuit> jcorgan, you mean the bitcoin dev meetup happening nowish? 19:01 < jcorgan> yes. i had planned to attend but had something come up at the last minute. 19:02 < jcorgan> well, i'm sure it will be recorded in any case 19:07 < phantomcircuit> jcorgan, they're usually not 19:07 < phantomcircuit> i doubt this will be 19:08 < jcorgan> ah well. 19:09 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 19:09 < jcorgan> i'll just have to do what they did in the pre-Interet age and use my *imagination* when reading sipa's documentation 19:10 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:12 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 19:13 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:25 < sipa> jcorgan: or you could ask questions here :) 19:25 < sipa> it will be recorded, yes 19:25 < sipa> not streamed i believe 19:29 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 19:32 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:47 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 19:54 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:56 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 19:58 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 20:05 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:07 -!- mo [adb16dd3@gateway/web/freenode/ip.173.177.109.211] has joined #bitcoin-core-dev 20:07 -!- mo is now known as Guest50891 20:08 -!- Guest50891 [adb16dd3@gateway/web/freenode/ip.173.177.109.211] has quit [Client Quit] 20:09 -!- AdrianG [~User@unaffiliated/amphetamine] has quit [Ping timeout: 268 seconds] 20:11 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 20:12 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 20:12 -!- dodomojo [~goksinen@2604:2000:c591:8400:658c:116e:7f29:883c] has joined #bitcoin-core-dev 20:13 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:14 -!- dodomojo [~goksinen@2604:2000:c591:8400:658c:116e:7f29:883c] has quit [Client Quit] 20:17 -!- AdrianG [~User@unaffiliated/amphetamine] has joined #bitcoin-core-dev 20:18 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds] 20:25 -!- nejon [uid38993@gateway/web/irccloud.com/x-obouwqnkyzxkhneq] has joined #bitcoin-core-dev 20:28 -!- goksinen [~goksinen@2604:2000:c591:8400:717d:96d4:c258:1d8e] has joined #bitcoin-core-dev 20:29 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:33 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 21:00 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 21:03 -!- JackH [~laptop@79.73.184.8] has quit [Ping timeout: 260 seconds] 21:04 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 21:09 < achow101> I'm attempting to run the linearize scripts but it keeps timing out? anyone have any ideas? 21:15 < achow101> nvm. it magically resolved itself 21:21 < bitcoin-git> [bitcoin] achow101 opened pull request #10104: linearize script: Option to use RPC cookie (master...linearize-use-cookie) https://github.com/bitcoin/bitcoin/pull/10104 21:29 -!- testando [98f9022f@gateway/web/freenode/ip.152.249.2.47] has joined #bitcoin-core-dev 21:30 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 21:35 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 21:46 < testando> test 21:46 -!- testando [98f9022f@gateway/web/freenode/ip.152.249.2.47] has quit [Quit: Page closed] 21:53 -!- waxwing [~waxwing@213.184.122.35] has quit [Ping timeout: 258 seconds] 22:07 -!- waxwing [waxwing@gateway/vpn/mullvad/x-kyfvxmgekqkztusj] has joined #bitcoin-core-dev 22:16 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:21 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 22:47 -!- go1111111 [~go1111111@104.200.154.79] has joined #bitcoin-core-dev 22:47 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:51 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 22:51 -!- go1111111 [~go1111111@104.200.154.79] has quit [Excess Flood] 22:52 -!- go1111111 [~go1111111@104.200.154.79] has joined #bitcoin-core-dev 23:02 -!- go1111111 [~go1111111@104.200.154.79] has quit [Ping timeout: 258 seconds] 23:13 -!- go1111111 [~go1111111@c-67-183-119-188.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 23:18 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 23:20 -!- goksinen [~goksinen@2604:2000:c591:8400:717d:96d4:c258:1d8e] has quit [Remote host closed the connection] 23:22 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 23:30 < kallewoof> There were cameras pointed at sipa so presumably there are recordings 23:42 -!- go1111111 [~go1111111@c-67-183-119-188.hsd1.wa.comcast.net] has quit [Ping timeout: 268 seconds] 23:46 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 23:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:47 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 260 seconds] 23:48 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 23:48 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 23:48 -!- LeMiner2 is now known as LeMiner 23:49 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 23:51 -!- JackH [~laptop@79-73-184-8.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 23:53 -!- magicwund [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 23:53 -!- go1111111 [~go1111111@c-67-183-119-188.hsd1.wa.comcast.net] has joined #bitcoin-core-dev