--- Day changed Sun Apr 09 2017 00:03 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 252 seconds] 00:04 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 00:05 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:07 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection] 00:08 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 00:46 < wumpus> luke-jr: ok, feel free to change that 00:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gtaweqotxaoahiys] has joined #bitcoin-core-dev 00:48 -!- CubicEarth [~cubiceart@c-67-168-4-85.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 00:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 01:06 -!- CubicEarth [~cubiceart@c-67-168-4-85.hsd1.wa.comcast.net] has quit [] 01:11 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:26 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection] 01:31 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 01:47 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 240 seconds] 02:01 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:67:1b24:2b90:69f9] has quit [Quit: .] 02:18 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:b828:df98:5578:2a31] has joined #bitcoin-core-dev 02:41 -!- vicenteH [~user@96.235.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:43 -!- RCasatta [~rcasatta@93-35-161-194.ip55.fastwebnet.it] has joined #bitcoin-core-dev 03:50 -!- RCasatta [~rcasatta@93-35-161-194.ip55.fastwebnet.it] has quit [Remote host closed the connection] 03:50 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 03:50 -!- ^arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer] 03:50 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Read error: Connection reset by peer] 03:51 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 03:56 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 03:58 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 04:31 < stevenroose> I haven't looked into Core's code too much, but I feel like there is quite a lack of code documentation.. 04:31 < stevenroose> F.e. https://github.com/bitcoin/bitcoin/blob/f93f9b92969b4a3f77d3f1c2a30ba3bf558e0cac/src/txmempool.cpp#L759 04:31 < stevenroose> It says "compare" and returns a bool. 04:31 < stevenroose> Compare methods commonly return an int that is negative for <, 0 for == and positive for > 04:32 < stevenroose> Also, it might be useful to document what it is basing the comparison on 04:32 < stevenroose> Even thought the method name says depth and score, it doesn;t say if a higher depth and higher score mean higher ranking (which is then either true or false) 04:32 -!- alpalp [~alpalp@cpe-24-27-58-209.austin.res.rr.com] has joined #bitcoin-core-dev 04:32 -!- alpalp [~alpalp@cpe-24-27-58-209.austin.res.rr.com] has quit [Changing host] 04:32 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 04:33 -!- JackH_ is now known as JackH 04:38 -!- Guest85725 [~schoumi@cpe-97-99-84-135.tx.res.rr.com] has joined #bitcoin-core-dev 04:45 -!- Guest85725 [~schoumi@cpe-97-99-84-135.tx.res.rr.com] has quit [Remote host closed the connection] 05:03 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 05:03 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 05:09 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 05:28 -!- felco [~felco@unaffiliated/felco] has quit [Ping timeout: 246 seconds] 05:29 < sipa> stevenroose: in C++ a comparator is a function that acts like (a < b) 05:35 < gmaxwell> s/C++/stl/ 05:41 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 05:45 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds] 05:46 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 05:49 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Changing host] 05:49 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 05:58 -!- jouke [~worst@unaffiliated/komkommer] has quit [Remote host closed the connection] 05:58 < sipa> gmaxwell: which is part of the C++ standard, but ok, other libraries can do things differently 06:00 -!- jouke [~worst@unaffiliated/komkommer] has joined #bitcoin-core-dev 06:06 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:26 -!- Ruben [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 06:30 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 06:47 < sipa> gmaxwell: i guess i should have said "in c++ it is common practice to use comparators which compute the less-than relation" 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 06:58 < gmaxwell> it just sounded weird to say "in C++" 07:04 -!- Samdney [~Samdney@178.162.209.139] has joined #bitcoin-core-dev 07:16 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 07:18 -!- Ruben [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 07:18 -!- moctos [~moctos@108.61.228.103] has joined #bitcoin-core-dev 07:18 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 07:19 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 07:22 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:23 -!- moli_ [~molly@unaffiliated/molly] has quit [Remote host closed the connection] 07:23 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:43 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 07:43 < bitcoin-git> [bitcoin] sipa closed pull request #8087: Introduce CBlockchain and move CheckBlockHeader (master...2016-05-22-cblockchain) https://github.com/bitcoin/bitcoin/pull/8087 07:44 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:36 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:55 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 09:01 < bitcoin-git> [bitcoin] sipa closed pull request #9599: [WIP] Perform validation in a separate thread to message handling. (master...ValidationThread) https://github.com/bitcoin/bitcoin/pull/9599 09:11 -!- moctos [~moctos@108.61.228.103] has quit [Ping timeout: 252 seconds] 09:11 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 09:23 -!- RubenSomsen [~RubenSoms@1.225.103.108] has joined #bitcoin-core-dev 09:38 -!- Ruben [~RubenSoms@1.225.103.75] has joined #bitcoin-core-dev 09:42 -!- RubenSomsen [~RubenSoms@1.225.103.108] has quit [Ping timeout: 240 seconds] 09:46 -!- RubenSomsen [~RubenSoms@1.225.103.108] has joined #bitcoin-core-dev 09:49 -!- Ruben [~RubenSoms@1.225.103.75] has quit [Ping timeout: 240 seconds] 09:55 -!- bitcoinreminder_ [uid220256@gateway/web/irccloud.com/x-gfzyhltbvzzcvace] has joined #bitcoin-core-dev 09:59 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has joined #bitcoin-core-dev 10:00 -!- Ruben [~RubenSoms@1.225.103.75] has joined #bitcoin-core-dev 10:04 -!- RubenSomsen [~RubenSoms@1.225.103.108] has quit [Ping timeout: 240 seconds] 10:10 -!- RubenSomsen [~RubenSoms@1.225.103.108] has joined #bitcoin-core-dev 10:13 -!- Ruben [~RubenSoms@1.225.103.75] has quit [Ping timeout: 240 seconds] 10:26 -!- Ruben [~RubenSoms@1.225.103.108] has joined #bitcoin-core-dev 10:28 -!- RubenSomsen [~RubenSoms@1.225.103.108] has quit [Ping timeout: 240 seconds] 10:31 -!- aantonop [~aantonop@99-189-168-153.lightspeed.snjsca.sbcglobal.net] has joined #bitcoin-core-dev 10:45 -!- Ruben [~RubenSoms@1.225.103.108] has quit [Ping timeout: 240 seconds] 10:46 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 10:56 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Ping timeout: 255 seconds] 11:18 -!- aantonop [~aantonop@99-189-168-153.lightspeed.snjsca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 11:19 -!- aantonop [~aantonop@99-189-168-153.lightspeed.snjsca.sbcglobal.net] has joined #bitcoin-core-dev 11:20 -!- aantonop [~aantonop@99-189-168-153.lightspeed.snjsca.sbcglobal.net] has quit [Client Quit] 11:22 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:25 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 11:29 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 11:30 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 11:39 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:54 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 12:04 -!- dermoth [~thomas@dsl-66-36-129-165.mtl.aei.ca] has quit [Ping timeout: 240 seconds] 12:05 -!- dermoth_ [~thomas@dsl-66-36-140-131.mtl.aei.ca] has joined #bitcoin-core-dev 12:05 -!- dermoth_ is now known as dermoth 12:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 12:14 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 255 seconds] 12:19 -!- dermoth [~thomas@dsl-66-36-140-131.mtl.aei.ca] has quit [Ping timeout: 268 seconds] 12:29 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 12:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:32 -!- dermoth [~thomas@dsl-66-36-132-82.mtl.aei.ca] has joined #bitcoin-core-dev 12:36 -!- aantonop [~aantonop@104.156.228.188] has quit [Quit: leaving] 12:37 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 12:37 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:43 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 12:44 -!- aantonop [~aantonop@104.156.228.188] has quit [Client Quit] 12:44 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 12:48 -!- dacox [b8471b7a@gateway/web/freenode/ip.184.71.27.122] has quit [Quit: Page closed] 12:50 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:50 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds] 12:53 -!- aantonop [~aantonop@104.156.228.188] has quit [Quit: leaving] 12:53 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 12:55 -!- aantonop [~aantonop@104.156.228.188] has quit [Client Quit] 12:56 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 13:20 < stevenroose> well, fwiw, Go's sort.Interface.Less() method does the same thing, so I figured as much. but still "Less()" is more explanatory than "operator()". but thanks, I'm making sense of the code 13:24 -!- aantonop [~aantonop@104.156.228.188] has quit [Quit: Lost terminal] 13:24 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 13:26 -!- aantonop [~aantonop@104.156.228.188] has quit [Client Quit] 13:27 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 13:34 -!- aantonop [~aantonop@104.156.228.188] has quit [Quit: leaving] 13:34 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 13:44 -!- aantonop [~aantonop@104.156.228.188] has quit [Quit: Lost terminal] 13:54 -!- aantonop [~aantonop@104.156.228.188] has joined #bitcoin-core-dev 13:54 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:22 -!- felco [~felco@unaffiliated/felco] has joined #bitcoin-core-dev 15:01 -!- marcoagner [~marcoagne@187.113.142.41] has joined #bitcoin-core-dev 15:02 < sipa> stevenroose: and comments are always welcome :) 15:26 -!- aantonop [~aantonop@104.156.228.188] has quit [Ping timeout: 252 seconds] 15:33 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 15:34 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 15:36 -!- marcoagner [~marcoagne@187.113.142.41] has quit [Ping timeout: 240 seconds] 15:42 -!- aantonop [~aantonop@104.156.228.142] has joined #bitcoin-core-dev 15:46 -!- netsin [~netsin@gateway/vpn/privateinternetaccess/netsin] has joined #bitcoin-core-dev 15:48 -!- netsin [~netsin@gateway/vpn/privateinternetaccess/netsin] has quit [Client Quit] 16:09 -!- bsm1175321 [~mcelrath@static-108-21-236-13.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 16:09 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 16:10 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 16:53 -!- moctos [~moctos@108.61.228.103] has joined #bitcoin-core-dev 16:53 -!- moctos_ [~moctos@108.61.228.103] has joined #bitcoin-core-dev 16:54 -!- moctos [~moctos@108.61.228.103] has quit [Read error: Connection reset by peer] 16:54 -!- moctos_ [~moctos@108.61.228.103] has quit [Read error: Connection reset by peer] 16:57 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 16:58 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 17:27 -!- Samdney [~Samdney@178.162.209.139] has quit [Quit: Verlassend] 17:40 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:c092:439b:71e3:67d1] has quit [Ping timeout: 256 seconds] 18:03 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 252 seconds] 18:05 -!- fremenWalking [~fremenWal@c-73-171-2-81.hsd1.va.comcast.net] has quit [Ping timeout: 252 seconds] 18:22 -!- bitcoinreminder_ [uid220256@gateway/web/irccloud.com/x-gfzyhltbvzzcvace] has quit [Quit: Connection closed for inactivity] 18:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gtaweqotxaoahiys] has quit [Quit: Connection closed for inactivity] 18:33 -!- aantonop [~aantonop@104.156.228.142] has quit [Ping timeout: 252 seconds] 18:34 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 18:41 -!- NewLiberty [~NewLibert@107-142-8-22.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 18:51 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 18:52 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 19:08 -!- kadobanana [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 19:09 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 19:22 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 19:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 19:33 -!- moctos [~moctos@108.61.228.119] has joined #bitcoin-core-dev 19:33 -!- moctos_ [~moctos@108.61.228.119] has joined #bitcoin-core-dev 19:33 -!- moctos [~moctos@108.61.228.119] has quit [Read error: Connection reset by peer] 19:33 -!- moctos_ [~moctos@108.61.228.119] has quit [Read error: Connection reset by peer] 19:47 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:47 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has quit [Quit: Whatever] 19:47 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 260 seconds] 19:51 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 19:57 -!- kadobanana is now known as kadoban 19:59 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 255 seconds] 19:59 -!- condomitti [~condomitt@179.34.133.122] has quit [Ping timeout: 246 seconds] 19:59 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 20:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:15 -!- moctos [~moctos@108.61.228.119] has joined #bitcoin-core-dev 20:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 20:55 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 20:56 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 21:12 -!- aantonop [~aantonop@99-189-168-153.lightspeed.snjsca.sbcglobal.net] has joined #bitcoin-core-dev 21:40 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 245 seconds] 22:04 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 22:19 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 22:22 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 22:41 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 255 seconds] 23:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 23:30 -!- aantonop [~aantonop@99-189-168-153.lightspeed.snjsca.sbcglobal.net] has quit [Quit: Lost terminal] 23:35 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 23:35 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 23:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88799ea1b1c0...703202180bde 23:39 < bitcoin-git> bitcoin/master dd7e43e John Newbery: Fix build warning from #error text 23:39 < bitcoin-git> bitcoin/master 7032021 Wladimir J. van der Laan: Merge #10168: Fix build warning from #error text... 23:39 < bitcoin-git> [bitcoin] laanwj closed pull request #10168: Fix build warning from #error text (master...fixbuildwarning) https://github.com/bitcoin/bitcoin/pull/10168 23:41 < sipa> oh great, i just wanted to create a PR for that 23:46 < wumpus> always check which PRs already exist :) 23:48 < sipa> this is good advice 23:49 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:49 < gmaxwell> I wish there were like a local ncurses interface to this stuff... so slow to check via the browser. :P 23:50 < midnightmagic> It's all available via the github API isn't it? 23:52 < paveljanik> git interface to the issues and PRs would be nice. And git grep over it ;-)