--- Day changed Tue Apr 11 2017 00:00 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:03 < jcorgan> I'm mostly interested in authenticated addnode and connect over Tor, after which encryption is icing on the cake 00:04 < jcorgan> but willing to spend cycles on 151 if it helps advance the cause 00:04 -!- kexkey [~kexkey@68.168.119.228] has quit [Ping timeout: 240 seconds] 00:06 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 00:06 < gmaxwell> jcorgan: our encryption is message auth + encryption, and auth needs message auth. the encryption is just gravy. 00:08 < wumpus> yes tor authenticates the hidden service you connect to, it can't be used to authenticate the incoming connection 00:08 < wumpus> so would still need something there 00:10 < jcorgan> got it 00:11 < jcorgan> let me know how i can fit in to your plans. time of course is always limited but this seems an area i can both help out in and is important to me personally. 00:11 < wumpus> encryption over tor hidden services is unnecessary, though I believe some sites do use e.g. https over tor to be able to have the tor endpoint communicate with the https endpoint "last mile" on an internal LAN encrypted 00:12 < wumpus> (this way, the tor endpoint cannot sniff the connection, it could mitm though) 00:12 < jcorgan> i always worry about exit nodes but they are really no different from any other chokepoint like an ISP 00:12 < gmaxwell> the HS encryption/auth is kind of weak, the HS-NG stuff is much stronger (and I believe even includes a post-quantum perfect forward secrecy, unless that didn't make it in). 00:13 < wumpus> yes I also avoid exit nodes as much as possible, a lot of services are available as onion nowadays 00:16 < bitcoin-git> [bitcoin] tjps opened pull request #10182: [scheduler] Switched CScheduler to C++11 threading primitives (master...tjps_scheduler) https://github.com/bitcoin/bitcoin/pull/10182 00:16 < wumpus> though I think it's mainly exit nodes that helped tor gain adoption, it's hard to get critical mass for an isolated network, as cjdns, i2p etc have found out 00:17 < wumpus> yes the new HS stuff sounds interesting, haven't looked at it in detail yet 00:18 < jcorgan> exit nodes are indeed crucial, but subject to both legal coercion and operation by less than friendly entities 00:18 < jcorgan> so as usual being able to do end-to-end authentication oneself is the only way to mitigate. 00:19 < jcorgan> as well as encryption using a key one can control, but with bitcoin traffic that seems less than essential 00:19 < wumpus> indeed; also exit node use is free, so what is the incentive. Seems lots of security researchers etc run them just to be able to sample traffic 00:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:21 < jcorgan> anyway, jonasschnelli, when you get the time clue me in on how best to help your efforts and i'll let you know what i can commit to 00:21 < wumpus> well at least with HSes there are no exit nodes involved 00:33 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 00:37 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 00:57 < gmaxwell> petertodd: if you get a chance, please timestamp e2337a7e94f62658180b763e9c1afb70577e32cdad2b06dfce839558912a123f 01:27 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 01:45 -!- DigiByteDev [~JT2@42-2-125-244.static.netvigator.com] has quit [Quit: DigiByteDev] 01:55 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 240 seconds] 01:58 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 02:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 02:07 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:14 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 02:42 < bitcoin-git> [bitcoin] KibbledJiveElkZoo opened pull request #10183: Don't default rescan on private/public key imports. (master...rpc_rescan_fixes) https://github.com/bitcoin/bitcoin/pull/10183 03:16 -!- JackH [~laptop@79-73-191-98.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 03:29 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 03:30 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 03:33 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Quit: Leaving] 03:59 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 04:22 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has quit [Quit: Whatever] 04:32 < jonasschnelli> hmm... getaddrinfo on OSX seems not to respect the TTL... I get the same results as 1h ago from a seed. 04:32 < jonasschnelli> No problem on linux (get fresh addresses every time I call getaddrinfo) 04:36 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #10184: [Wallet] Worst case performance improvement on KeyPool filtering (master...hdinternalperf) https://github.com/bitcoin/bitcoin/pull/10184 05:38 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:43 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:46 -!- Samdney [~Samdney@178.162.209.142] has joined #bitcoin-core-dev 06:12 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 06:29 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 06:32 < bitcoin-git> [bitcoin] sdaftuar opened pull request #10185: [0.14] Mention dbcache memory changes in release notes (0.14...2017-04-relnotes-0.14.1) https://github.com/bitcoin/bitcoin/pull/10185 06:33 < BlueMatt> cfields: do you have a take on #10182? 06:33 < gribble> https://github.com/bitcoin/bitcoin/issues/10182 | [scheduler] Switched CScheduler to C++11 threading primitives by tjps · Pull Request #10182 · bitcoin/bitcoin · GitHub 06:41 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 06:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 06:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:11 < cfields> BlueMatt: sure 07:30 -!- Joseph__ [~NewLibert@107-142-8-22.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 07:32 -!- NewLiberty [~NewLibert@107-142-8-22.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 07:33 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:f930:391b:df99:81b6] has quit [Ping timeout: 255 seconds] 07:33 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:49ba:a81c:6602:9558] has joined #bitcoin-core-dev 07:34 < petertodd> gmaxwell: done. BTW there's a javascript timestamper on https://opentimestamps.org now, although it doesn't seem to work on my local version of firefox :( 07:37 < bitcoin-git> [bitcoin] jnewbery opened pull request #10186: Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number (master...remove_SYNC_TRANSACTION_NOT_IN_BLOCK_magic_number) https://github.com/bitcoin/bitcoin/pull/10186 07:45 < cfields> petertodd: neat! 07:47 < cfields> petertodd: why not allow a hash to be specified though? It's a shame I'd have to read the javascript to be sure I'm not actually revealing my file. 07:52 < jannes> petertodd: nit: "Company using OpenTimeStamps" should be "Companies...", I guess. 07:53 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 08:07 -!- Irssi: #bitcoin-core-dev: Total of 186 nicks [0 ops, 0 halfops, 0 voices, 186 normal] 08:19 -!- belcher [~user@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 08:28 -!- kexkey [~kexkey@68.168.119.228] has joined #bitcoin-core-dev 08:33 -!- belcher [~user@2a02:c7d:b93f:2300:9aa:1138:257d:9daf] has joined #bitcoin-core-dev 08:33 -!- belcher is now known as Guest80844 08:37 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has joined #bitcoin-core-dev 08:44 -!- kexkey_ [~kexkey@68.168.119.228] has joined #bitcoin-core-dev 08:44 -!- kexkey [~kexkey@68.168.119.228] has quit [Ping timeout: 255 seconds] 08:46 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:27 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 09:33 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 09:33 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 09:33 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 09:39 < jcorgan> what are the various version numbers (0.2, 0.3, etc.) seen in the uasf trackers? my google-fu has deserted me today 09:41 < instagibbs> jcorgan, some other repo's numbering of bip148 09:42 -!- annanay25 [~csbtech@geekon.tech] has quit [Remote host closed the connection] 09:42 < bincap> jcorgan: there were some proposals, and they used various versions. activation date was other in old one afair 09:42 -!- annanay25 [~csbtech@geekon.tech] has joined #bitcoin-core-dev 09:42 < jcorgan> ah, got it 09:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 10:06 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 10:10 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 10:12 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Quit: mining] 10:14 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 10:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 10:15 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:17 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 10:20 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 10:37 < wumpus> I don't understand what's wrong with travis on master 10:37 < wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/220971234 shows as a failed build, but the build, the unit tests and the functional tests seem to pass 10:38 < wumpus> same for https://travis-ci.org/bitcoin/bitcoin/jobs/220971232 10:38 < wumpus> did something mess up the return codes? 10:39 < BlueMatt> yes 10:39 < BlueMatt> "The command "if [ "$RUN_TESTS" = "true" ]; then test/functional/test_runner.py --coverage --quiet ${extended}; fi" exited with 1. 10:39 < BlueMatt> " 10:39 < BlueMatt> jnewbery: 10:40 < wumpus> oh I see, apparently it sees a skipped tests as a failure, in the final check 10:40 < BlueMatt> ahh, cool 10:41 < jnewbery> yes - my fault. Here: https://github.com/bitcoin/bitcoin/commit/63062bda1ac0b57cb92e663596650a6e42508f15#diff-a5b9b84e3a3387476629e74ddb227a7eL271 10:41 < jnewbery> it'll only cause travis to fail for cron jobs 10:42 < jnewbery> sorry. I'll PR a fix 10:42 < wumpus> already working on it 10:44 < jnewbery> s/test_result.status == "Passed"/test_result.status != "Failed"/ 10:45 < wumpus> yes, well, I'm adding a was_succesful property to TestResult and putting the string check there 10:47 < jnewbery> ok, let me know the PR number and I'm happy to review 10:52 < bitcoin-git> [bitcoin] laanwj opened pull request #10187: tests: Fix test_runner return value in case of skipped test (master...2017_04_fix_tracis) https://github.com/bitcoin/bitcoin/pull/10187 10:53 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:54 -!- bsm1175321 [~mcelrath@157.130.6.242] has joined #bitcoin-core-dev 10:55 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:02 < wumpus> hrm the wallet_dump.py test seems to fail locally here 11:02 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:07 < jnewbery> try clearing the cache 11:07 < jnewbery> hd split causes a couple of tests to fail if the cache isn't cleared 11:08 < wumpus> gah.. yes, afraid it is the cache again 11:09 < BlueMatt> sipa: yo 11:09 -!- EZVPyrTvgJYiEpQZ [~EZVPyrTvg@192-228-145-85.ftth.glasoperator.nl] has joined #bitcoin-core-dev 11:10 < instagibbs> I have "rm -r cache/" on hotkey by now 11:10 < jnewbery> I'm tempted to PR removing the cache at the start of each test_runner run 11:11 < wumpus> jnewbery: yes please 11:12 < BlueMatt> sipa: I'm super confused on #10148: did you get hashUpto and hashBest confused in ReplayBlocks? The way I read BatchWrite hashBest is the block which has been fully flushed, upto is the possible-partially-flushed tip. But ReplayBlocks seems to use them the other way 11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub 11:12 < wumpus> adds a few seconds to the test run in worst-case, but saves a lot of seconds in thinking/troubleshooting time when the tests fail for inexplcable reasons again 11:13 < jnewbery> wumpus: agreed 11:14 < wumpus> and for travis it won't even make a difference 11:29 < sipa> BlueMatt: yes, you read it correctly 11:31 < sipa> you first update upto, so that if you crash in the middle, Best is still the old best, and Upto is the new one 11:31 < sipa> then at startup you process the blocks between Best and Upto, in that order 11:31 -!- EZVPyrTvgJYiEpQZ [~EZVPyrTvg@192-228-145-85.ftth.glasoperator.nl] has quit [Quit: -a- Android IRC 2.1.17] 11:32 < BlueMatt> ohoh, yes, i confused myself 11:56 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Read error: Connection reset by peer] 11:57 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 12:08 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 12:17 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 12:21 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 12:23 < petertodd> cfields: I think that's a good idea! though the guys who did the website might prefer that functionality be an "advanced" option 12:24 < petertodd> cfields: also, there's actually a hex operator in the opentimestamps standard, so if you timestamp a file containing a hex-encoded digest, you can later convert that into a timestamp directly on the file itself 12:30 < petertodd> jannes: thanks! filed a pull-req for that 12:42 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 13:09 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 255 seconds] 13:10 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 13:12 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Changing host] 13:12 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 13:15 < cfields> petertodd: ah, sha256d finally explained :p 13:16 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Ping timeout: 255 seconds] 13:30 -!- moctos [~moctos@108.61.228.119] has quit [Quit: Leaving] 13:35 < bitcoin-git> [bitcoin] theuni opened pull request #10189: devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. (master...private-nodeid) https://github.com/bitcoin/bitcoin/pull/10189 13:38 -!- Guest80844 [~user@2a02:c7d:b93f:2300:9aa:1138:257d:9daf] has quit [Ping timeout: 252 seconds] 13:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [] 13:52 < bitcoin-git> [bitcoin] jnewbery opened pull request #10190: Mining functional tests (including regression test for submitblock) (master...mining_functional_test) https://github.com/bitcoin/bitcoin/pull/10190 13:59 < jtimon> cfields: #10189 is awesome! independently of it being validated by travis (which is awesome), if I had used scripts instead of emacs and kept them in the commit messages like here some disruptive would have been so simple to rebase and review (I mean, not that that kind of change is hard to review, but even simpler with this). Now it seems so obvious that I feel kind of stupid for not having thought about it before 13:59 < gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub 14:00 < cfields> jtimon: hehe, glad you like it. I was going to poke you to check it out, but you beat me to it :) 14:02 < cfields> jtimon: and now we have some incentive to write a few simple scripts to move chunks of code around. Combining those two things, that should make reviewing move-only changes much simpler 14:03 < cfields> ofc they still have to be reviewed for correctness (and correctness of the script), but at least it's easy to see where the changes come from. 14:04 < jtimon> right, and again trivial to rebase (just run the script again to rewrite the commit, trivial) 14:04 < cfields> jtimon: yep 14:04 < jtimon> I just saw it by accident but it is very exciting to me 14:06 < jtimon> cfields: how stable is it? I saw you force pushed recently 14:06 < jtimon> I assume a simple last minute fix 14:06 < cfields> jtimon: i need to force probably one more time. Travis' environment is kinda weird, they build from a detached head 14:09 < jtimon> cfields: let me know when you're finished, I want to test it by writting something else using it 14:10 < cfields> jtimon: ok. Pushed. Finished if Travis is happy with that last one. 14:11 < jtimon> btw, maybe we could add something to the dev notes about using a specific prefix to identiy this kind of commit, maybe "scripted-diff: net: Use accessor rather than node's id directly" or "net: scripted-diff: Use accessor rather than node's id directly" 14:15 < cfields> sure, that makes sense 14:16 < jtimon> it's a way to make it more explicit that those are easier to review thanks to the scripts 14:16 < cfields> jtimon: be careful if you're using it locally. It uses your live repo/workdir. It attempts to put everything back the way it found it, but I certainly wouldn't trust that for now. 14:17 < cfields> (it works by detaching HEAD, reverting the commit in question, running the script, and comparing the result to HEAD^) 14:17 < cfields> yep, agreed 14:17 < jtimon> thanks for the heads up, I will copy the workdir just in case before using it 14:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:29 < bitcoin-git> [bitcoin] jnewbery opened pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191 14:43 < bitcoin-git> [bitcoin] jnewbery closed pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191 14:45 -!- bsm1175321 [~mcelrath@157.130.6.242] has quit [Ping timeout: 260 seconds] 14:57 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10192: Cache full script execution results in addition to signatures (master...2017-04-cache-scriptchecks) https://github.com/bitcoin/bitcoin/pull/10192 14:58 < BlueMatt> ^ 1.7x faster in naive braindead benchmark, yay 14:58 -!- Halo [49d0c6e2@gateway/web/freenode/ip.73.208.198.226] has joined #bitcoin-core-dev 14:59 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:00 -!- belcher [~user@2a02:c7d:b93f:2300:c9e8:2a8d:960f:740b] has joined #bitcoin-core-dev 15:00 -!- belcher is now known as Guest61146 15:03 -!- Halo [49d0c6e2@gateway/web/freenode/ip.73.208.198.226] has quit [Ping timeout: 260 seconds] 15:09 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 15:10 * cfields suppresses his initial reaction and reads the PR in full 15:11 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 15:11 < gmaxwell> It's logically the same as the ecdsa cache but more efficient most of the time. 15:11 < gmaxwell> (except in the case of certian dos attacks, which is part of why we didn't change the signature cache to work that way. 15:11 < gmaxwell> ) 15:13 < BlueMatt> indeed, that is pointed out in the PR text 15:13 < BlueMatt> the win I measured is just overhead of spinning up the sigcache stuff 15:13 < BlueMatt> s/sigcache/sigcheck threads/ 15:13 < BlueMatt> and looping over the scripts, even with sigcache set to always return true 15:13 < gmaxwell> well it's also just a lot less work, doesn't have to run the signature hashing, doesn't have to hash the message hash to look up in the cash, does a lot less lookup. 15:13 < BlueMatt> (hence why i stopped at 284k - thats the first block which has a tx which checks that a signature is NOT valid) 15:14 < BlueMatt> yup 15:18 < cfields> huh. 15:20 < gmaxwell> BlueMatt: when you made the sigcache return true, where did you do that? pre or post its internal hashing? 15:20 < BlueMatt> s/return false/return true/ 15:20 < BlueMatt> so post 15:21 < BlueMatt> but compiler may have optimized it all out 15:21 < BlueMatt> its internal hashing is cheap, though 15:21 < BlueMatt> its just getting bytes out of the uint256 15:22 < gmaxwell> not that internal hashing, the signature cache SHA256(message|pubkey|flags) and uses the result as the key. 15:22 < BlueMatt> ohoh, very much post that 15:22 < BlueMatt> sipa: did you misread the ")" in the patch? 15:22 < BlueMatt> it is outside of getarg? 15:27 -!- Guest61146 is now known as belcher 15:27 -!- belcher [~user@2a02:c7d:b93f:2300:c9e8:2a8d:960f:740b] has quit [Changing host] 15:27 -!- belcher [~user@unaffiliated/belcher] has joined #bitcoin-core-dev 15:32 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-ptfogadtddtqhjnp] has quit [Quit: Connection closed for inactivity] 15:35 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 15:39 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10125: Exit bitcoind immediately on shutdown instead of 200ms later (master...2017-03-faster-shutdown) https://github.com/bitcoin/bitcoin/pull/10125 15:46 < cfields> jtimon: pushed one last version. Sorry. Really done now. 15:58 < jtimon> cfields: awesome, no worries, was doing something else 15:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67023e9004ba...b44adf92342a 15:59 < bitcoin-git> bitcoin/master e96462f Wladimir J. van der Laan: tests: Fix test_runner return value in case of skipped test... 15:59 < bitcoin-git> bitcoin/master b44adf9 MarcoFalke: Merge #10187: tests: Fix test_runner return value in case of skipped test... 16:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10187: tests: Fix test_runner return value in case of skipped test (master...2017_04_fix_tracis) https://github.com/bitcoin/bitcoin/pull/10187 16:01 < jtimon> but yeah, I plan to give a "tested ack by opening this other pr, making it fail on purpose as you can see in this travis link and then fixing it by squashing the part that was left out on purpuse" to #10189 16:01 < gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub 16:05 < jtimon> now I'm mostly worried about GITHUB_MAX_OPENED_PRS_PER_PROJECT if everyone reviews 10189 like that :p 16:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 16:36 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-ubbvotplumdwnfvw] has joined #bitcoin-core-dev 16:57 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:00 < cfields> heh 17:14 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-iisceshhzaqwmxtk] has quit [Quit: Connection closed for inactivity] 17:19 -!- dermoth [~thomas@dsl-66-36-132-82.mtl.aei.ca] has quit [Read error: Connection reset by peer] 17:20 -!- dermoth [~thomas@dsl-66-36-132-82.mtl.aei.ca] has joined #bitcoin-core-dev 17:32 -!- Samdney [~Samdney@178.162.209.142] has quit [Quit: Verlassend] 17:42 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:55 < jtimon> cfields: at the same time, I'm a sed newbie, there were no '\' in my teacher's blackboard or my "reduded-c" interpreter implemented in c++, please, don't laught to loud when you tell me what my mistake is in: https://0bin.net/paste/mHKVu6pkl2XopjAb#3S9s6vUOBTnlmnDMWRKH6Te6-oJAjdE3lBD0LtS45/s 18:55 < gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub 18:57 * jtimon https://www.gnu.org/software/sed/manual/sed.html#sed-regular-expressions 19:10 < cfields> jtimon: i think you want something like: sed -i 's/BOOST_FOREACH(\(.*\),\(.*\))/for(\1 :\2)/' net_processing.cpp 19:10 < cfields> ? 19:11 < jtimon> oh, yeah, the dot, thank you very much 19:12 -!- dodomojo [~goksinen@2604:2000:c591:8400:f438:4b12:11b:17f3] has joined #bitcoin-core-dev 19:12 < cfields> np 19:13 < cfields> jtimon: you'll need to filter some things out of that. iirc pairs are handled differently, at least. 19:15 < jtimon> I shouldn't even need a pair I think, now I'm trying sed -i "s/BOOST_FOREACH(\(.*\), /for (${\1} :" src/net_processing.cpp 19:16 < jtimon> bash: s/BOOST_FOREACH(\(.*\), /for (${\1} :: bad substitution 19:17 < jtimon> it feels like it's something embarrasingly obvious 19:18 -!- Joseph__ [~NewLibert@107-142-8-22.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 19:18 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:49ba:a81c:6602:9558] has quit [Ping timeout: 255 seconds] 19:39 -!- dodomojo [~goksinen@2604:2000:c591:8400:f438:4b12:11b:17f3] has quit [Remote host closed the connection] 19:47 < jtimon> ok, "git checkout -- ." was the first thing I was missing before trying again with something different 19:47 -!- goksinen [~goksinen@2604:2000:c591:8400:c582:133b:122e:9e0b] has joined #bitcoin-core-dev 19:48 -!- dodomojo [~goksinen@2604:2000:c591:8400:d171:1328:c528:8b88] has joined #bitcoin-core-dev 19:52 -!- goksinen [~goksinen@2604:2000:c591:8400:c582:133b:122e:9e0b] has quit [Ping timeout: 255 seconds] 19:52 -!- dodomojo [~goksinen@2604:2000:c591:8400:d171:1328:c528:8b88] has quit [Remote host closed the connection] 19:53 < jtimon> alright, I think 'git checkout -- . ; sed -i 's/BOOST_FOREACH(\(.*\),/for (\1 :/' ./src/qt/*.cpp ./src/wallet/*.cpp' is enough to test your PR on travis 19:56 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:57 < cfields> jtimon: does that actually build? 19:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 20:02 < jtimon> cfields: sed does what I expect, and only with ./src/qt/*.cpp , it passes unittests 20:03 < cfields> mm, neat 20:05 < jtimon> now it's time to make it "fail" on purpose and open a PR, then add a fixup commit to be squashed once your pr is merged 20:06 < jtimon> neat indeed, I expect this to be revolution in refactors, thanks again 20:09 < cfields> :) happy to help 20:10 < cfields> I've had this one (the cnode change) done on a ton of branches, but never felt like dealing with the process of pushing it through. So yea, I can see how it could be helpful for lots of similar changes. 20:11 < jtimon> at the very least, it revolutionized the way I think about refactors, maybe it was obvious to use sed for rebase and review for everyone else but certainly not for me 20:12 < jtimon> yeah, not only painful simple changes will stop to be painful 20:12 < jtimon> which is the fisrt use case 20:15 < jtimon> but also some painful changes that authors don't even open as PR because they're too disruptive will be open now 20:15 < cfields> awesome 20:15 < jtimon> and more importantly, reviewed too 20:15 < cfields> jtimon: you might look at pairing it with "git rebase -i --exec