--- Day changed Wed Apr 26 2017
00:02 -!- tw2006 [~tw2006@2601:187:8480:2770:95db:bb85:bf1:854f] has joined #bitcoin-core-dev     
00:06 -!- tw2006 [~tw2006@2601:187:8480:2770:95db:bb85:bf1:854f] has quit [Ping timeout: 240 seconds]     
00:12 -!- fao1 [~fao@106.120.101.38] has quit [Ping timeout: 255 seconds]     
00:13 -!- fao1 [~fao@106.120.101.38] has joined #bitcoin-core-dev     
00:13 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
00:17 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:17 -!- fao1 [~fao@106.120.101.38] has quit [Ping timeout: 240 seconds]     
00:27 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds]     
00:27 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
00:31 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
00:32 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
00:35 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c94fb6c3257...8254a8ae213b
00:35 < bitcoin-git> bitcoin/master 1b14449 Jimmy Song: [test] Add Unit Test for GetListenPort...
00:35 -!- Ruben [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
00:35 < bitcoin-git> bitcoin/master 8254a8a Wladimir J. van der Laan: Merge #10278: [test] Add Unit Test for GetListenPort...
00:35 < bitcoin-git> [bitcoin] laanwj closed pull request #10278: [test] Add Unit Test for GetListenPort (master...test_listenport) https://github.com/bitcoin/bitcoin/pull/10278
00:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
00:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
00:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
00:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]     
01:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
01:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:13 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
01:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
01:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:21 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:22 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
01:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
01:27 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8254a8ae213b...8979f4569e0e
01:27 < bitcoin-git> bitcoin/master 4f3ac7d Chris Gavin: Remove unused variable from `macdeployqtplus` script.
01:27 < bitcoin-git> bitcoin/master e8babc4 Chris Gavin: Use `with` in `macdeployqtplus` script.
01:28 < bitcoin-git> bitcoin/master 8979f45 Wladimir J. van der Laan: Merge #10273: [scripts] Minor improvements to `macdeployqtplus` script....
01:28 < bitcoin-git> [bitcoin] laanwj closed pull request #10273: [scripts] Minor improvements to `macdeployqtplus` script. (master...macdeployqtplus) https://github.com/bitcoin/bitcoin/pull/10273
01:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
01:40 -!- crudel [crudel@gateway/shell/fnordserver.eu/x-yzkzqncxfxaxtqss] has joined #bitcoin-core-dev     
01:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:46 < MarcoFalke> wumpus: I am not convinced that we need to implement every function twice. (Once in the code and a second time in the unit tests; Then check for equality) 
01:46 < MarcoFalke> (re 10278)
01:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]     
01:46 < MarcoFalke> Also, the SoftSetArg has effect on all test that run after it
01:46 <@wumpus> MarcoFalke: this is just a very simple function to test
01:47 <@wumpus> the test fully checks the behavior of GetListenPort, though
01:47 <@wumpus> feel free to suggest other ways to test GetListenPort, or do you mean no unit test should exist for it at all?
01:48 < MarcoFalke> I mean it is a 1:1 copy of the implementation
01:48 <@wumpus> yes, it doesn't reset the argument afterward, probaly should
01:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:48 < MarcoFalke> I more think of unit test to cover corner cases
01:48 <@wumpus> it is, but I wouldn't know how to test this otherwise
01:48 <@wumpus> it's just a silly little function that only does one thing
01:49 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hutnbquzrejowvyg] has joined #bitcoin-core-dev     
01:49 <@wumpus> so the only way to test it is to do that silly little thing too
01:49 <@wumpus> you could argue it is useless, I don't know, maybe it'll catch an error if someone changes the GetListenPort implementation
01:50 < MarcoFalke> Hmm, I suspect pretty much everything else breaks if the implementation is changed.
01:50 -!- tw2006 [~tw2006@c-73-38-126-159.hsd1.nh.comcast.net] has joined #bitcoin-core-dev     
01:52 < MarcoFalke> I don't care too much about this very function, but I am worried there will be pulls coming up for literally any function.
01:52 <@wumpus> possibly. But the point of the unit test is to check that function, and it does that.
01:53 <@wumpus> yes, feel free to nudge him in the direction of writing more useful tests
01:54 <@wumpus> just trying to encourage him a bit, it's good to have a new contributor that cares about testing
01:54 < MarcoFalke> Yes, getting that merged was probably a good way to motivate more contributions
01:55 -!- tw2006 [~tw2006@c-73-38-126-159.hsd1.nh.comcast.net] has quit [Ping timeout: 240 seconds]     
01:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]     
01:57  * MarcoFalke off
01:57 <@wumpus> right, he has admitted this is part of his learning process
01:58 <@wumpus> later
02:07 <@wumpus> oh wow TIL github has a "reviews -> awaiting review from you" selection for PRs
02:07 <@wumpus> that could be useful, at least if someone had tagged me as reviewr for anything :)
02:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:18 -!- fao1 [~fao@106.120.101.38] has joined #bitcoin-core-dev     
02:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]     
02:30 -!- Ruben [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 246 seconds]     
02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]     
02:38 -!- AaronvanW [~AaronvanW@84.red-81-44-90.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
02:38 -!- AaronvanW [~AaronvanW@84.red-81-44-90.dynamicip.rima-tde.net] has quit [Changing host]     
02:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:44 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8979f4569e0e...bd9ec0ef1ea7
02:44 < bitcoin-git> bitcoin/master b508424 Wladimir J. van der Laan: contrib: github-merge improvements...
02:44 < bitcoin-git> bitcoin/master bd9ec0e Wladimir J. van der Laan: Merge #9670: contrib: github-merge improvements...
02:44 < bitcoin-git> [bitcoin] laanwj closed pull request #9670: contrib: github-merge improvements (master...2017_01_ghmerge_update) https://github.com/bitcoin/bitcoin/pull/9670
02:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]     
02:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
03:00 -!- JackH [~laptop@79-73-191-98.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
03:04 -!- mryandao [~mryandao@unaffiliated/mryandao] has joined #bitcoin-core-dev     
03:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
03:22 < mryandao> hi, i'm looking at core's source and just wondering if I've got this right.
03:23 < mryandao> when a block is accepted, individual transactions that come with the blocks dont get verified?
03:24 < kallewoof> They do get verified
03:24 < sipa> correct, with the footnote that acceptance does not imply it's valid
03:25 < sipa> tx validation happens when a chain of blocks becomes the new longest chain, and we try to "activate" it
03:25 < kallewoof> Isn't the CheckTransaction for loop in CheckBlock verifying them?
03:25 < kallewoof> Ahh, ok.
03:26 < sipa> ok, yes, but that's isn't what most people would call verifying transactions
03:26 < sipa> CheckTransaction only does some basic sanity checking
03:26 < mryandao> yeah CheckTransaction is just checking is a transaction is malformed
03:26 < mryandao> so signature validation is only done for transactions that are to be accepted into mempool?
03:27 < sipa> also when a chain is activated
03:27 < sipa> via ConnectBlock
03:28 < mryandao> cool, thanks.
03:29 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd9ec0ef1ea7...6fdb31916589
03:29 < bitcoin-git> bitcoin/master 321bbc2 Pieter Wuille: fix ubsan: bitcoin-tx: not initialize context before IsFullyValid
03:29 < bitcoin-git> bitcoin/master 1d31093 Pieter Wuille: fix tsan: utiltime race on nMockTime
03:29 < bitcoin-git> bitcoin/master 6fdb319 Wladimir J. van der Laan: Merge #9743: Fix several potential issues found by sanitizers...
03:29 < bitcoin-git> [bitcoin] laanwj closed pull request #9743: Fix several potential issues found by sanitizers (master...fsanitize) https://github.com/bitcoin/bitcoin/pull/9743
03:39 -!- tw2006 [~tw2006@2601:187:8480:2770:499f:2542:f3e7:7909] has joined #bitcoin-core-dev     
03:44 -!- tw2006 [~tw2006@2601:187:8480:2770:499f:2542:f3e7:7909] has quit [Ping timeout: 260 seconds]     
03:44 -!- tw2006 [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has joined #bitcoin-core-dev     
03:45 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
03:50 < bitcoin-git> [bitcoin] fanquake closed pull request #9363: Reduce fingerprinting attacks (master...MinChainWorkBlocktxns) https://github.com/bitcoin/bitcoin/pull/9363
03:50 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 260 seconds]     
03:51 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
04:04 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 260 seconds]     
04:06 < bitcoin-git> [bitcoin] practicalswift closed pull request #9545: Add final where appropriate (master...add-overrides-where-appropriate) https://github.com/bitcoin/bitcoin/pull/9545
04:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
04:11 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6fdb31916589...cf5782508a3f
04:11 < bitcoin-git> bitcoin/master 82b7dc3 Russell Yanofsky: [wallet] Add GetLegacyBalance method to simplify getbalance RPC...
04:11 < bitcoin-git> bitcoin/master 02d9f50 Russell Yanofsky: [wallet] Remove unneeded legacy getbalance code
04:11 < bitcoin-git> bitcoin/master cf57825 Wladimir J. van der Laan: Merge #9614: [wallet] [refactor] Simplify getbalance implementation...
04:12 < bitcoin-git> [bitcoin] laanwj closed pull request #9614: [wallet] [refactor] Simplify getbalance implementation (master...pr/getbalance-cleanup) https://github.com/bitcoin/bitcoin/pull/9614
04:19 -!- nejon [uid38993@gateway/web/irccloud.com/x-pxqxutjgsocqmsxb] has quit [Quit: Connection closed for inactivity]     
04:28 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
04:30 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
04:50 -!- tw2006 [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has quit [Read error: Connection reset by peer]     
04:50 -!- tw2006 [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has joined #bitcoin-core-dev     
05:21 -!- nejon [uid38993@gateway/web/irccloud.com/x-erkbptjtxgfiacrs] has joined #bitcoin-core-dev     
05:31 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
05:35 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
05:36 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
05:39 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds]     
05:49 -!- crudel [crudel@gateway/shell/fnordserver.eu/x-yzkzqncxfxaxtqss] has quit [Quit: https://fnordserver.eu]     
05:49 -!- jtimon [~quassel@9.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
05:54 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer]     
05:56 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
06:17 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
06:20 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hutnbquzrejowvyg] has quit [Quit: Connection closed for inactivity]     
06:33 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
06:36 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds]     
06:47 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
06:49 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev     
06:54 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds]     
06:59 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
07:02 -!- fao1 [~fao@106.120.101.38] has quit [Ping timeout: 246 seconds]     
07:02 -!- fao1 [~fao@106.120.101.38] has joined #bitcoin-core-dev     
07:04 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 258 seconds]     
07:12 < bitcoin-git> [bitcoin] luke-jr opened pull request #10282: Expire bitcoind & bitcoin-qt 7-8 years after its last change (master...timebomb) https://github.com/bitcoin/bitcoin/pull/10282
07:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
07:27 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
07:29 -!- bsm1175321 [~mcelrath@static-108-21-236-13.nycmny.fios.verizon.net] has quit [Remote host closed the connection]     
07:31 -!- marcoagner [~user@187.113.133.247] has quit [Quit: WeeChat 1.0.1]     
07:33 -!- marcoagner [~user@187.113.133.247] has joined #bitcoin-core-dev     
07:49 -!- kexkey [~kexkey@modemcable085.67-23-96.mc.videotron.ca] has joined #bitcoin-core-dev     
07:50 -!- kexkey_ [~kexkey@68.168.119.229] has joined #bitcoin-core-dev     
07:52 -!- kexkey_ [~kexkey@68.168.119.229] has quit [Client Quit]     
07:54 -!- kexkey [~kexkey@modemcable085.67-23-96.mc.videotron.ca] has quit [Ping timeout: 240 seconds]     
07:54 -!- goksinen [~goksinen@2604:2000:c591:8400:e00f:35ae:cec4:c6d] has joined #bitcoin-core-dev     
07:58 -!- goksinen [~goksinen@2604:2000:c591:8400:e00f:35ae:cec4:c6d] has quit [Ping timeout: 240 seconds]     
08:01 -!- lesderid_ [~lesderid@anna.lesderid.net] has quit [Quit: bai]     
08:01 -!- lesderid [~lesderid@2a03:b0c0:1:d0::2a5:4002] has joined #bitcoin-core-dev     
08:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 260 seconds]     
08:13 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds]     
08:16 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
08:16 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
08:36 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
08:45 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]     
08:45 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
08:45 -!- tw2006 [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has quit [Read error: Connection reset by peer]     
08:46 -!- tw2006 [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has joined #bitcoin-core-dev     
08:47 -!- tw2006 [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has quit [Read error: Connection reset by peer]     
08:48 -!- tw2006 [~tw2006@c-73-38-126-159.hsd1.nh.comcast.net] has joined #bitcoin-core-dev     
08:51 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
09:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
09:12 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
09:43 -!- kexkey [~kexkey@162.219.176.21] has joined #bitcoin-core-dev     
09:53 -!- tw2006_ [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has joined #bitcoin-core-dev     
09:56 -!- tw2006 [~tw2006@c-73-38-126-159.hsd1.nh.comcast.net] has quit [Ping timeout: 260 seconds]     
09:58 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection]     
10:04 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 264 seconds]     
10:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
10:10 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
10:24 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
10:28 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
10:36 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
10:40 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 255 seconds]     
10:54 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
11:22 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
11:22 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
11:30 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
11:34 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
11:35 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]     
11:35 -!- talmai [~T@216.200.123.162] has joined #bitcoin-core-dev     
11:35 -!- talmai [~T@216.200.123.162] has quit [Read error: Connection reset by peer]     
11:44 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds]     
11:52 -!- Char0n [~Charon@46.232.227.244] has quit [Ping timeout: 240 seconds]     
11:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]     
11:58 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
12:01 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
12:02 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
12:03 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
12:04 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection]     
12:04 < achow101> gmaxwell: any update on publishing the alert key?
12:05 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
12:09 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Ping timeout: 255 seconds]     
12:15 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 245 seconds]     
12:33 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
12:46 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
12:48 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
12:54 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
12:54 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
13:05 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
13:09 -!- tw2006_ [~tw2006@2601:187:8480:2770:7142:b7b6:3f6f:add6] has quit [Remote host closed the connection]     
13:09 -!- Char0n [~Charon@46.232.227.244] has joined #bitcoin-core-dev     
13:09 < bitcoin-git> [bitcoin] morcos opened pull request #10283: Cleanup: reduce to one GetMinimumFee call signature (master...oneGetMinimumFee) https://github.com/bitcoin/bitcoin/pull/10283
13:15 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection]     
13:31 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
13:37 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
13:38 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
13:50 < bitcoin-git> [bitcoin] morcos opened pull request #10284: Always log debug information for fee calculation in CreateTransaction (master...debugEstimates) https://github.com/bitcoin/bitcoin/pull/10284
14:32 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds]     
14:34 -!- Dyaheon [~Dya@91.156.192.24] has joined #bitcoin-core-dev     
14:39 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection]     
14:49 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev     
14:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf5782508a3f...47535d7c3ec7
14:52 < bitcoin-git> bitcoin/master dcb69fd Jimmy Song: [test] Unit test amount.h/amount.cpp...
14:52 < bitcoin-git> bitcoin/master 47535d7 MarcoFalke: Merge #10280: [test] Unit test amount.h/amount.cpp...
14:52 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10280: [test] Unit test amount.h/amount.cpp (master...test_amount) https://github.com/bitcoin/bitcoin/pull/10280
14:58 -!- tw2006 [~tw2006@2601:187:8480:2770:f5b9:b84f:485b:9ed9] has joined #bitcoin-core-dev     
15:02 -!- tw2006 [~tw2006@2601:187:8480:2770:f5b9:b84f:485b:9ed9] has quit [Ping timeout: 240 seconds]     
15:06 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving]     
15:11 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:503c:2191:dbc2:e85d] has quit [Quit: .]     
15:12 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:2ddf:e713:3a8:1fb8] has joined #bitcoin-core-dev     
15:36 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
15:52 < sipa> great, our CCoinsCaching benchmark converts a CMutableTransaction to a CTransaction in its inner loop...
15:53 < sipa> i expect that's the majority of the time it measures
16:09 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection]     
16:13 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
16:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
16:21 < BlueMatt> lol     
16:21 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
16:21 < BlueMatt> thanks C++ magic type conversion
16:42 -!- TheV01d is now known as TheV01D     
16:47 -!- tw2006 [~tw2006@2601:187:8480:2770:e9a7:30f0:fda8:a4f0] has joined #bitcoin-core-dev     
16:51 -!- tw2006 [~tw2006@2601:187:8480:2770:e9a7:30f0:fda8:a4f0] has quit [Ping timeout: 260 seconds]     
16:54 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
16:55 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:00 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 260 seconds]     
17:23 < cfields> well since we're all doing PRs for lots-of-changes-but-the-reason-isn't-obvious-until-the-next-PR, I suppose I'll do mine too.
17:24 -!- marcoagner [~user@187.113.133.247] has quit [Read error: Connection reset by peer]     
17:24 -!- marcoagner [~user@187.113.133.247] has joined #bitcoin-core-dev     
17:24 < bitcoin-git> [bitcoin] theuni opened pull request #10285: net: refactor the connection process. moving towards async connections. (master...connman-events6) https://github.com/bitcoin/bitcoin/pull/10285
17:29 < fanquake> cfields Now just open two more, each with another 5 commits, all building on top of each other.
17:30 < cfields> fanquake: haha
17:31 < BlueMatt> cfields: to be fair, sipa objected to mine and so I'm gonna open the reason to get concept acks before merge of the dependant
17:32 < cfields> BlueMatt: sorry, that wasn't meant to be an insult. I've just been staring at this code for a week trying to figure out how to PR it. Just funny timing.
17:33 < BlueMatt> nor was mine, i was just pointing to the vague policy understanding i took from sipa's understanding of my own comments and figured I'd mention it as a possible suggestion
17:35 < sipa> as it seems to be a developing practice the past minutes in the vicinity of this communication channel to speak in relatively length sentences, i shall participate
17:35 < fanquake> cfields If you'd rather stare at some different code for a while; I've been tracking down a Windows issue that's blocking us from moving to latest ZMQ #9254
17:35 < gribble> https://github.com/bitcoin/bitcoin/issues/9254 | [depends] ZeroMQ 4.2.2 by fanquake · Pull Request #9254 · bitcoin/bitcoin · GitHub
17:36 < cfields> greg was here.
17:36 < cfields> (probably)
17:36 < cfields> fanquake: looking
17:36 < BlueMatt> sipa: is your understanding of the developing practice of relatively lengthy sentences that it shall eventually move towards policy, or is it only a temporal disturbance in the sentence length requirement understanding of the participants of the vicinity of this channel?
17:37 < fanquake> Also, noticed that libzmq is being relicensed.
17:38 < fanquake> https://github.com/zeromq/libzmq/issues/2376
17:38 < BlueMatt> would that effect us?
17:38 < BlueMatt> ahh, if anything positively
17:38 < cfields> neat
17:39 < BlueMatt> man i do not envy them in having to collect license grants from /everyone/
17:39 < cfields> BlueMatt: they usually take the route of /everyone with a significant contribution/
17:39 < BlueMatt> even still
17:40 < cfields> yea: "from each individual contributor who wrote a major piece of code in the development process of libzmq"
17:40 < cfields> no fun
17:41 < cfields> but on the bright side, hooray for github centralization! Must make this much easier.
17:41 < BlueMatt> f$cking internet...isp has peering presence but only uses it for IPv6...time to go annoy some noc operators
17:41 < BlueMatt> s/peering/ix peering/
17:41 < cfields> heh     
17:41 < cfields> fanquake: that error is very confusing. seems to be in a system header
17:42 < cfields> my best guess is there's some define magic going on somewhere?
17:44 < sipa> BlueMatt: i for one am of the opinion - which i shall hold until presented with sufficient evidence of the contrary - that this is merely a temporary phase, which will soon be considered inconvenient and unnecessary
17:46 < fanquake> cfields Yea I'll have to look into it further.
17:46 < gmaxwell> sipa: are you trying to match my length of lines on IRC?  It will take you an awful long time to catch up to my average.
17:46 -!- marcoagner [~user@187.113.133.247] has quit [Ping timeout: 268 seconds]     
17:47 < fanquake> cfields While you're here, any significant plans depends wise for 0.15.0 ? I had a bunch of updates lined up, but haven't PR'd anything because I wanted to know what you were doing.
17:47 < cfields> fanquake: go for it! the qt overhaul is the big one
17:48 < cfields> fanquake: an osx toolchain bump
17:48 < cfields> fanquake: I'll be doing the toolchain builder as well, but that should just plug in to current depends without too much interruption
17:49 < sipa> gmaxwell: that is an impossible task, i might venture to state, and surely one should not let mere statistics in the history of an ephemeral communication channel like this guide one's actions
17:49 < gmaxwell> sipa: You are currently at an average length of 54 in this channel... compared to my 103.
17:50 < fanquake> cfields qt overhaul in regard to 5.8? I think they have some new "lite" build system. Will we see any benefit from that, I would have thought we were already pretty optimised?
17:50 < achow101> gmaxwell: while you're here, any update on the alert key stuff?
17:50 < BlueMatt> lol     
17:50 < cfields> fanquake: split builds for host/target.
17:50 < BlueMatt> saw that one coming
17:51 < cfields> fanquake: and yea, we'll benefit from the lite thing. We just need to crank up a long list of -no-feature-X
17:51 < cfields> (they're supposed to actually work now, rather than just breaking stuff)
17:51 < sipa> perhaps i shall go construct a plugin module for my Internet Relay Chat client to implement nagle's algorithm for outgoing messages and make it combine multiple successive lines into one?
17:51 < fanquake> cfields No worries, I'll have a look at that as well.
17:53 < cfields> fanquake: have you tried to bisect the zmq change? There are a bunch of versions in between :(
17:54 < gmaxwell> achow101: not yet. personally I'm hoping for more old stuff to age off the network, since the key is explotable against that old stuff. (A fact we didn't really know until I did the final homework before releasing the key)
17:55 -!- vicenteH` [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
17:55 < fanquake> Somewhat, I originally opened that PR with 4.2.0, then moved to 4.2.1, then 4.2.2, all seemed to have the same issue. So I'm assuming it's something that might have happened between 4.1.6 -> 4.2.0 . Which I wouldn't have tested yet. I'll post in that PR if I find anything.
17:56 < achow101> gmaxwell: will those vulnerabilities be disclosed or not until old nodes drop off the network?
17:56 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]     
17:57 < cfields> fanquake: so 4.1.6 works?
17:57 < gmaxwell> achow101: well I'd rather not post a howto then later post the key. :)
17:58 < gmaxwell> achow101: if you want to amuse yourself, why not go find the issues yourself. Make a write up. though I'd ask you to keep ir private for now, though ultimately that would be up to you.
17:58 < achow101> but I can't know if I actually found something without the key
17:59 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10286: Call wallet notify callbacks in scheduler thread (without cs_main) (master...2017-01-wallet-cache-inmempool-4) https://github.com/bitcoin/bitcoin/pull/10286
18:00 < gmaxwell> achow101: well if you wanted to try it, you can change the key or rig the signature validation to return true for it.
18:01 < fanquake> cfields I can't remember if I tested it or just jumped straight to 4.2.0. I'll go back and take a look.
18:01 < cfields> fanquake: maybe try disabling the precompiled stuff? 
18:02 < fanquake> The main windows related change from 4.1.6 seems to be https://github.com/zeromq/libzmq/issues/2091
18:03 < cfields> fanquake: aha! that could definitely be it. we may need to force the WINNT version
18:03 < achow101> gmaxwell: heh. social engineering failed :(. I will amuse myself and find those vulns
18:04 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection]     
18:04 < sipa> achow101: hahaha
18:05 < gmaxwell> hehe.
18:32 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
18:34 < bitcoin-git> [bitcoin] jimmysong opened pull request #10287: [tests] Update Unit Test for addrman.h/addrman.cpp (master...test_addrman) https://github.com/bitcoin/bitcoin/pull/10287
18:36 -!- tw2006 [~tw2006@2601:187:8480:2770:a11a:6245:e0ea:e17d] has joined #bitcoin-core-dev     
18:40 -!- tw2006 [~tw2006@2601:187:8480:2770:a11a:6245:e0ea:e17d] has quit [Ping timeout: 240 seconds]     
18:43 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
18:47 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds]     
18:49 -!- annanay25 [~csbtech@geekon.tech] has quit [Remote host closed the connection]     
18:49 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
18:49 -!- annanay25 [~csbtech@geekon.tech] has joined #bitcoin-core-dev     
18:52 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 255 seconds]     
19:04 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
19:24 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection]     
19:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []     
20:03 -!- Don_John [~Don@2600:8800:548f:1500:dd71:3c3f:ed83:657e] has joined #bitcoin-core-dev     
20:24 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
20:24 -!- tw2006 [~tw2006@2601:187:8480:2770:cc3d:5a79:f246:9cfb] has joined #bitcoin-core-dev     
20:29 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Ping timeout: 240 seconds]     
20:29 -!- tw2006 [~tw2006@2601:187:8480:2770:cc3d:5a79:f246:9cfb] has quit [Ping timeout: 260 seconds]     
20:35 -!- Azur [~Charon@46.232.227.244] has joined #bitcoin-core-dev     
20:35 -!- Azur [~Charon@46.232.227.244] has left #bitcoin-core-dev []     
20:39 < jl2012> on testnet I made a script to repeatedly send the same coin to myself every 15 second. When the tx chain becomes long enough, however, it stops working until confirmed. So there is a limit? Is it possible to bypass it?
20:40 < achow101> jl2012: the limit is 25 unconfirmed transactions in a chain
20:40 < achow101> you can raise it for your own node but not anyone else
20:41 < jl2012> so other miners won't mine beyond 25 txs by default?
20:41 < achow101> yes     
20:42 < jl2012> thanks
20:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
21:01 -!- goksinen [~goksinen@2604:2000:c591:8400:6c5d:5722:3cae:8a2d] has joined #bitcoin-core-dev     
21:04 -!- dodomojo [~goksinen@2604:2000:c591:8400:c5c6:4b02:e535:18e2] has joined #bitcoin-core-dev     
21:06 < sipa> jl2012: there is also an option to make the wallet refuse to create transactions with coins in too long chains (though it avoids using them by default)
21:07 -!- goksinen [~goksinen@2604:2000:c591:8400:6c5d:5722:3cae:8a2d] has quit [Ping timeout: 240 seconds]     
21:12 -!- goksinen [~goksinen@2604:2000:c591:8400:a485:d0a4:c8f:be1a] has joined #bitcoin-core-dev     
21:14 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]     
21:14 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
21:15 -!- dodomojo [~goksinen@2604:2000:c591:8400:c5c6:4b02:e535:18e2] has quit [Ping timeout: 258 seconds]     
21:26 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
21:48 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Ping timeout: 252 seconds]     
21:53 -!- jtimon [~quassel@9.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]     
22:13 -!- goksinen [~goksinen@2604:2000:c591:8400:a485:d0a4:c8f:be1a] has quit [Remote host closed the connection]     
22:13 -!- tw2006 [~tw2006@2601:187:8480:2770:d59f:819f:a694:88a4] has joined #bitcoin-core-dev     
22:18 -!- tw2006 [~tw2006@2601:187:8480:2770:d59f:819f:a694:88a4] has quit [Ping timeout: 240 seconds]     
22:45 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev     
22:46 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev     
22:46 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev     
22:47 -!- juscamarena is now known as Guest87345     
23:00 -!- dermoth [~thomas@dsl-66-36-130-50.mtl.aei.ca] has quit [Read error: Connection reset by peer]     
23:01 -!- dermoth [~thomas@dsl-66-36-130-50.mtl.aei.ca] has joined #bitcoin-core-dev     
23:06 -!- Guest87345 [~justin@47.148.176.74] has quit [Quit: Leaving]     
23:06 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Ping timeout: 260 seconds]     
23:44 -!- vicenteH` is now known as vicenteH