--- Day changed Mon May 01 2017 00:11 -!- goksinen [~goksinen@2604:2000:c591:8400:5908:ad9a:1281:2967] has joined #bitcoin-core-dev 00:15 -!- goksinen [~goksinen@2604:2000:c591:8400:5908:ad9a:1281:2967] has quit [Ping timeout: 246 seconds] 00:17 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/80c3a734298e...8d6d43e9338a 00:17 < bitcoin-git> bitcoin/master b297426 Pieter Wuille: Add -stopatheight for benchmarking 00:17 < bitcoin-git> bitcoin/master 8d6d43e Wladimir J. van der Laan: Merge #10290: Add -stopatheight for benchmarking... 00:18 < bitcoin-git> [bitcoin] laanwj closed pull request #10290: Add -stopatheight for benchmarking (master...shutdown_at_height) https://github.com/bitcoin/bitcoin/pull/10290 00:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8d6d43e9338a...9c33ffd38764 00:25 < bitcoin-git> bitcoin/master 0ff9320 jonnynewbs: refactor TxToJSON() and ScriptPubKeyToJSON() 00:25 < bitcoin-git> bitcoin/master 9c33ffd Wladimir J. van der Laan: Merge #8824: Refactor TxToJSON() and ScriptPubKeyToJSON()... 00:51 <@wumpus> gmaxwell: sipa: I'm just worried that taking up the concern of doing proper seeding in bitcoin core itself, without anyone else looking at it or using it, will result in a worse outcome for us. Allthe platform specific stuff is a hell to maintain, and it forces us to stay up to date in developments in that area 00:52 <@wumpus> a person can't be a specialist in everything, and neither can a project, I think 00:53 -!- mode/#bitcoin-core-dev [-o wumpus] by ChanServ 00:54 < gmaxwell> someone else writing it doesn't magically make it good however, it can just be a way to launder bad code. 00:54 < wumpus> yes, that is true too 00:56 < gmaxwell> the openssl code smells pretty bad. (in particular, IIRC if it's unable to open any strong random device it keeps on going)-- but it does at least have the benefit of being widely used. I too am not keep on platform specfifc code, we don't want to have a case where someone runs on BeOS and doesn't get randomness at all because /dev/urandom is symlinked ot /dev/zero and how were we so stupid as t 00:56 < gmaxwell> o not know this and account for it. :P 00:56 < wumpus> but someone else cooporating on it outside the context of bitcoin core (which is pretty narrow) isn't necessarily bad 00:58 < gmaxwell> The challenge we have for doing a general RNG library which you suggested before (we tried) is that our needs are pretty different and addressing it in the general case is really really hard. In particular, other applications have strong performance requirements that necessitates lockfree state management, while at the same time handling forced RNG reseeding across forks. The approaches people 00:58 < gmaxwell> have come up with for this are ugly and pretty platform specific. And these are both properties that we don't need. 00:59 < wumpus> yes, defending openssl in that regard is pretty pointless 00:59 < gmaxwell> (they're handling the fork transisition stuff using things like special page flags that cause tagged pages to get zeroed on fork ... and other similar functionality that is different on every OS that implements something like it) 00:59 < wumpus> "In particular, other applications have strong performance requirements that necessitates lockfree state management" then we explicitly exclude those 01:00 < wumpus> the kind of thing I'm thinking of it other wallets 01:00 < gmaxwell> ('there' in this case referring to other people attempting general RNG code.) 01:00 < wumpus> usually need low-frequency, but very good entropy 01:00 < gmaxwell> okay we could do something that would perhaps mostly only be used by other bitcoin things. 01:00 < gmaxwell> (or cryptocurrency rather) 01:01 < wumpus> yup other cryptocurrency and things that need strong keys 01:01 < wumpus> it's a growing space at least 01:01 < wumpus> indeed I don't care the least about satisfying any need for randomness for any project in existence 01:02 < wumpus> but improving wallets in general would already be a nice aim 01:02 < gmaxwell> well one thing that was suggested was just doing initial seed generation as a library, which is basically all you need for most wallet keygen things, and has the least concern. 01:02 < wumpus> yup 01:03 < wumpus> then we agree I guess :) 01:03 < gmaxwell> okay, thats a fine scope. 01:08 < wumpus> I sometimes wonder what gpg's key generation does 01:09 < wumpus> this is the only non-wallet example of a long term key, not easy to replace, potential disaster if compromised, that I can think of right now 01:10 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 01:28 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sgsxayjpqpxpokwg] has joined #bitcoin-core-dev 01:54 < kallewoof> Maybe bitcoin could use libgcrypt (GnuPG uses it for keys, I think; it has a bunch of random things) instead of OpenSSL. Though it seems to be LGPL. Some parts of it are dual MPL-compat though, like random-drbg.c 01:54 < kallewoof> "a bunch of random things" = "a bunch of things related to RNG" 01:55 < kallewoof> Uh, meant MIT, not MPL 01:58 -!- JackH [~laptop@79-73-191-98.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 02:04 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 02:23 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 02:32 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has joined #bitcoin-core-dev 02:33 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 02:53 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 02:58 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 255 seconds] 03:02 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 268 seconds] 03:02 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 03:05 < bitcoin-git> [bitcoin] kallewoof opened pull request #10304: [rpc] Allow a txid param in getrawmempool (master...getrawmempool-include-txid) https://github.com/bitcoin/bitcoin/pull/10304 03:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c33ffd38764...492d22f92919 03:17 < bitcoin-git> bitcoin/master 85f950a Jimmy Song: [test] Add tests for getconnectioncount, getnettotals and ping... 03:17 < bitcoin-git> bitcoin/master 492d22f MarcoFalke: Merge #10264: [test] Add tests for getconnectioncount, getnettotals and ping... 03:17 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10264: [test] Add tests for getconnectioncount, getnettotals and ping (master...test_netrpccalls) https://github.com/bitcoin/bitcoin/pull/10264 03:39 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 03:41 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 04:09 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 04:12 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 04:40 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 04:47 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 05:11 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:13 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 05:15 -!- nu11p7r [~nu11p7r@dfaefce4-1ec2-41ac-b8f9-6bd816c36ded.node.sporestack.com] has quit [Ping timeout: 240 seconds] 05:19 -!- dermoth [~thomas@dsl-66-36-140-214.mtl.aei.ca] has quit [Ping timeout: 246 seconds] 05:20 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 05:37 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 05:37 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 06:05 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:09 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 06:19 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/492d22f92919...e2b99b13131b 06:21 < bitcoin-git> bitcoin/master 7c58863 Gregory Sanders: [Wallet] unset change position when there is no change on exact match 06:21 < bitcoin-git> bitcoin/master e2b99b1 Wladimir J. van der Laan: Merge #10294: [Wallet] unset change position when there is no change... 06:21 < bitcoin-git> [bitcoin] laanwj closed pull request #10294: [Wallet] unset change position when there is no change (master...fixchangepos) https://github.com/bitcoin/bitcoin/pull/10294 06:23 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 06:25 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 268 seconds] 06:26 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has joined #bitcoin-core-dev 06:28 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 268 seconds] 06:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 06:36 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 06:46 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 245 seconds] 06:47 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 07:08 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:11 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:27 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 07:28 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 07:39 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 07:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:48 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 07:57 -!- harrymm [~wayne@104.237.91.137] has quit [Remote host closed the connection] 08:05 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:05 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:05 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:05 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 08:11 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 08:15 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 08:25 -!- bsm117532 [~mcelrath@135.84.167.210] has quit [Quit: Leaving.] 08:29 -!- harrymm [~wayne@104.237.91.120] has joined #bitcoin-core-dev 08:29 -!- harrymm [~wayne@104.237.91.120] has quit [Max SendQ exceeded] 08:29 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:30 -!- harrymm [~wayne@104.237.91.120] has joined #bitcoin-core-dev 08:35 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 258 seconds] 08:36 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 08:45 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 08:45 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 08:52 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10305: Fix potential NPD introduced in b297426c (master...2017-05-fix-10290-npd) https://github.com/bitcoin/bitcoin/pull/10305 08:52 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 260 seconds] 09:04 -!- GAit [~GAit@unaffiliated/gait] has quit [Quit: WeeChat 1.0.1] 09:05 -!- GAit [~GAit@unaffiliated/gait] has joined #bitcoin-core-dev 09:05 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 09:09 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 09:10 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 09:12 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 09:13 < BlueMatt> should #10294 not get backported? 09:13 < gribble> https://github.com/bitcoin/bitcoin/issues/10294 | [Wallet] unset change position when there is no change by instagibbs · Pull Request #10294 · bitcoin/bitcoin · GitHub 09:13 < BlueMatt> (are we backporting for a theoretical 0.14.2?) 09:14 < instagibbs> definitely should be if there is a 0.14.2 09:14 < instagibbs> imo 09:20 < sipa> agree 09:41 -!- Netsplit *.net <-> *.split quits: Naphex, lightningbot, jannes, thestringpuller, array, fronti 09:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 09:44 -!- bsm117532 [~mcelrath@135.84.167.210] has joined #bitcoin-core-dev 09:46 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 255 seconds] 09:47 -!- Netsplit over, joins: jannes 09:51 -!- jcliff42 [~jcliff42@c-50-168-87-98.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:54 -!- tw2006 [~tw2006@2601:187:8480:2770:f889:ece6:ed60:6c8b] has quit [Read error: Connection reset by peer] 09:54 -!- tw2006 [~tw2006@2601:187:8480:2770:f889:ece6:ed60:6c8b] has joined #bitcoin-core-dev 09:55 -!- jcliff42 [~jcliff42@c-50-168-87-98.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 09:58 -!- jcliff42 [~jcliff42@73.93.140.135] has joined #bitcoin-core-dev 10:01 -!- sipa [~pw@2001:19f0:ac01:2fb:5400:ff:fe5b:c3ff] has quit [Changing host] 10:01 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev 10:02 -!- jcliff42 [~jcliff42@73.93.140.135] has quit [Ping timeout: 240 seconds] 10:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:11 -!- tw2006 [~tw2006@2601:187:8480:2770:f889:ece6:ed60:6c8b] has quit [Read error: Connection reset by peer] 10:11 -!- tw2006 [~tw2006@2601:187:8480:2770:f889:ece6:ed60:6c8b] has joined #bitcoin-core-dev 10:21 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 10:24 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 10:24 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 10:29 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 10:30 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 10:31 -!- tw2006 [~tw2006@2601:187:8480:2770:f889:ece6:ed60:6c8b] has quit [Remote host closed the connection] 10:33 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 10:35 -!- edcba [~edcba@78.193.195.38] has left #bitcoin-core-dev [] 10:40 -!- bsm117532 [~mcelrath@135.84.167.210] has quit [Killed (barjavel.freenode.net (Nickname regained by services))] 10:50 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 10:55 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:57 -!- tw2006 [~tw2006@2601:187:8480:2770:218c:ce34:da55:e5d8] has joined #bitcoin-core-dev 11:05 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 11:06 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 11:07 -!- array [dsa@array.pm] has joined #bitcoin-core-dev 11:07 -!- array is now known as Guest47977 11:08 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 11:10 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 11:14 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:17 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:18 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:18 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds] 11:19 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 11:22 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 11:26 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 11:26 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 11:27 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 11:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:32 -!- fronti [~fronti@irc.fh-biergarten.de] has joined #bitcoin-core-dev 11:32 -!- Naphex [~naphex@naphex.rocks] has joined #bitcoin-core-dev 11:35 -!- JackH [~laptop@79-73-191-98.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 11:47 < jl2012> is the blockchain database of 0.9 compatible with 0.13? 11:47 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 11:47 < sipa> yes 11:48 < sipa> 0.8.0 through 0.14.1 should have compatible chainstates 11:48 < sipa> (forward and backward) 11:52 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 11:58 < jl2012> thanks 11:58 < sipa> actually, op_return pruning was added in between somewhere, if you downgrade, the startup check may complain 11:58 < gmaxwell> uh, no. 11:59 < gmaxwell> chainstate obfscuation was introduced around 0.11.x 11:59 < sipa> oh! 11:59 < gmaxwell> (maybe in 0.12.0?) 12:00 < sipa> indeed, 0.12.0 12:00 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 12:01 < jl2012> ok. So my case is: I have a working 0.9 node, and I want to minimize the time to IBD a 0.13 node . Should I just copy the blocks folder? 12:01 < sipa> copy the blocks folder and the chainstate 12:01 < sipa> copy the chainstate first, while the node is offline 12:02 < sipa> the blocks dir can be copied later (and the node can have run in between) 12:02 < jl2012> but I have to keep it online 12:02 < jl2012> so it will corrupt? 12:02 < luke-jr> could try lsyncd I guess 12:02 < bitcoin-git> [bitcoin] tjps closed pull request #10182: [scheduler] Switched CScheduler to C++11 threading primitives (master...tjps_scheduler) https://github.com/bitcoin/bitcoin/pull/10182 12:12 < SopaXorzTaker> sipa, what's this bounty? http://permalink.gmane.org/gmane.comp.bitcoin.devel/3089 12:12 < BlueMatt> cfields: lol, so I've now got a long branch with a bunch of scripted diffs that make CBlockIndexes outside of validation (and mostly outside of CChainState) all const :p 12:12 < BlueMatt> guess that stuff /is/ useful :p 12:12 < SopaXorzTaker> (on-topic to core dev) 12:13 < cfields> :) 12:14 < BlueMatt> also, yay, const access to validation outside of validation! 12:14 < sipa> SopaXorzTaker: why do you ask me? 12:14 < BlueMatt> crazy, yo 12:14 < sipa> SopaXorzTaker: ask the person who sent that mail 12:14 < bitcoin-git> [bitcoin] jnewbery opened pull request #10307: [tests] allow zmq test to be run in out-of-tree builds (master...fix_zmq_test_out_of_tree) https://github.com/bitcoin/bitcoin/pull/10307 12:16 < BlueMatt> cfields: re: 10189: instead of TRAVIS_COMMIT_RANGE might it make sense to go back until the nearest merge commit? 12:17 < cfields> BlueMatt: why? I believe TRAVIS_COMMIT_RANGE includes the merge commit it creates 12:17 < BlueMatt> well i meant eg for private repo runs 12:17 < BlueMatt> it'd be nice, but i guess doesn't matter /that/ much 12:17 < BlueMatt> it just feels weird that it would only be tested on prs 12:18 < cfields> BlueMatt: ah, I hadn't even considered non-PRs. Yes. 12:19 < cfields> BlueMatt: can probably diff to branch point 12:19 < SopaXorzTaker> the addresses belong to gmaxwell and jgarzik, and one more 12:19 < SopaXorzTaker> let's extort them, muhahah 12:19 < SopaXorzTaker> (offtoipic end) 12:19 < BlueMatt> cfields: i guess doesnt matter for first version in pr 12:22 < BlueMatt> cfields: hmmm, I cant run the script locally 12:22 < cfields> BlueMatt: Well, actually, it may break for simple pushes (not sure, I have those disabled). I assume TRAVIS_COMMIT_RANGE is empty for those. 12:22 < BlueMatt> I get "bash: !b}: event not found" 12:23 < SopaXorzTaker> ROLL, ROT, SWAP 12:23 < cfields> BlueMatt: got a branch I can look at? 12:23 < BlueMatt> cfields: I'm literally just running the command manually 12:23 < SopaXorzTaker> that's a lifetime of a TX script in a nutshell 12:23 < BlueMatt> https://github.com/bitcoin/bitcoin/pull/10189/files#diff-6f65a3cbb40a72a97be8d4930d214685R25 12:23 < BlueMatt> that line fails 12:24 < BlueMatt> SopaXorzTaker: thanks, but lets keep this on-topic :) people often read scrollback and its very rude when there is a bunch of chatter that is off-topic in the scrollback that people have to spend time reading later 12:26 < SopaXorzTaker> + 12:26 < cfields> BlueMatt: hmm, unsure. Does it object to the sed syntax? 12:27 < BlueMatt> cfields: yes, I assume its the last part of the sed line (that is the only place with a !b) 12:27 < BlueMatt> but its bash complaining, not sed 12:30 < cfields> BlueMatt: i'm not sure why it would matter in a script, but it sounds like history expansion's kicking in. Does using ' ' instead fix it? 12:31 < BlueMatt> using ' ' where? 12:31 * BlueMatt is not fluent in sed 12:31 < cfields> BlueMatt: sec 12:33 < cfields> yea, i can reproduce when running the sed script by hand. Must be some interactive/non-interactive difference 12:33 < BlueMatt> oh strange 12:33 < cfields> BlueMatt: https://pastebin.com/raw/q9N6NE4b 12:34 < BlueMatt> ah, heh 12:34 < BlueMatt> s'pose i should have tried that 12:38 < cfields> I'll fix that and add a quick change to make it only run on PRs 12:38 < BlueMatt> thanks 12:38 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 12:39 < bitcoin-git> [bitcoin] tjps opened pull request #10308: [wallet] Securely erase potentially sensitive keys/values (master...tjps_secure_erase) https://github.com/bitcoin/bitcoin/pull/10308 12:40 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:42 -!- dodomojo [~goksinen@2604:2000:c591:8400:5908:ad9a:1281:2967] has joined #bitcoin-core-dev 12:42 -!- Dyaheon [~Dya@91.156.192.24] has joined #bitcoin-core-dev 12:46 < cfields> pushed (we'll see if travis likes those) 12:46 -!- dodomojo [~goksinen@2604:2000:c591:8400:5908:ad9a:1281:2967] has quit [Ping timeout: 260 seconds] 12:54 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:56 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 12:57 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 13:00 -!- jnewbery_ [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: leaving] 13:00 -!- jnewbery_ [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:05 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 13:13 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 13:20 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 13:28 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 13:32 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 13:37 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 276 seconds] 13:45 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 13:46 -!- tw2006 [~tw2006@2601:187:8480:2770:218c:ce34:da55:e5d8] has quit [Remote host closed the connection] 13:54 -!- harding [~harding@mail.dtrt.org] has joined #bitcoin-core-dev 14:04 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 14:06 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:22 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:23 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:23 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 14:25 < bitcoin-git> [bitcoin] CryptAxe opened pull request #10309: Trivial: remove extra character from comment (master...typoquestion) https://github.com/bitcoin/bitcoin/pull/10309 14:32 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:38 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 14:39 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:43 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:58 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2b99b13131b...ab1f1d324691 14:58 < bitcoin-git> bitcoin/master 3503716 CryptAxe: Trivial: remove extra character from comment 14:58 < bitcoin-git> bitcoin/master ab1f1d3 Pieter Wuille: Merge #10309: Trivial: remove extra character from comment... 14:59 < bitcoin-git> [bitcoin] sipa closed pull request #10309: Trivial: remove extra character from comment (master...typoquestion) https://github.com/bitcoin/bitcoin/pull/10309 15:00 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 15:01 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 15:01 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ab1f1d324691...c45da32047ca 15:01 < bitcoin-git> bitcoin/master 70d3945 Matt Corallo: Fix potential NPD introduced in b297426c... 15:01 < bitcoin-git> bitcoin/master c45da32 Pieter Wuille: Merge #10305: Fix potential NPD introduced in b297426c... 15:02 < bitcoin-git> [bitcoin] sipa closed pull request #10305: Fix potential NPD introduced in b297426c (master...2017-05-fix-10290-npd) https://github.com/bitcoin/bitcoin/pull/10305 15:03 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 15:24 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 15:29 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 276 seconds] 15:35 -!- tw2006 [~tw2006@2601:187:8480:2770:cc7e:ce6b:46b9:8edb] has joined #bitcoin-core-dev 15:40 -!- tw2006 [~tw2006@2601:187:8480:2770:cc7e:ce6b:46b9:8edb] has quit [Ping timeout: 258 seconds] 15:47 -!- [Author] [~Author]@2401:a400:3200:5600:bad:d09:15:90d] has quit [Ping timeout: 252 seconds] 15:49 -!- [Author] [~Author]@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 15:56 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 15:59 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 16:18 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 16:19 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 16:22 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 16:23 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 16:29 -!- yeferson [~canaima@186-93-106-94.genericrev.cantv.net] has joined #bitcoin-core-dev 16:29 -!- yeferson [~canaima@186-93-106-94.genericrev.cantv.net] has quit [Read error: Connection reset by peer] 16:41 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c45da32047ca...e4bbd3d230f2 16:41 < bitcoin-git> bitcoin/master 4fbae77 Marcos Mayorga: Improved efficiency in COutPoint constructors 16:41 < bitcoin-git> bitcoin/master e4bbd3d Pieter Wuille: Merge #10292: Improved efficiency in COutPoint constructors... 16:41 < bitcoin-git> [bitcoin] sipa closed pull request #10292: Improved efficiency in COutPoint constructors (master...master) https://github.com/bitcoin/bitcoin/pull/10292 16:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 16:45 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 16:48 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:52 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 16:56 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 16:59 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:07 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 17:17 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 17:21 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sgsxayjpqpxpokwg] has quit [Quit: Connection closed for inactivity] 17:22 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 17:22 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 17:24 -!- tw2006 [~tw2006@2601:187:8480:2770:740b:6a0e:ec7d:e3c0] has joined #bitcoin-core-dev 17:29 -!- tw2006 [~tw2006@2601:187:8480:2770:740b:6a0e:ec7d:e3c0] has quit [Ping timeout: 260 seconds] 17:31 < bitcoin-git> [bitcoin] kallewoof closed pull request #10304: [rpc] Allow a txid param in getrawmempool (master...getrawmempool-include-txid) https://github.com/bitcoin/bitcoin/pull/10304 17:34 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 17:34 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 17:34 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 17:37 -!- dclxvi [~DCLXVI@95-44-201-135-dynamic.agg1.whi.bdt-fng.eircom.net] has joined #bitcoin-core-dev 17:42 -!- DCLXVI` [~DCLXVI@95-44-201-135-dynamic.agg1.whi.bdt-fng.eircom.net] has quit [Ping timeout: 258 seconds] 17:43 < bitcoin-git> [bitcoin] kallewoof opened pull request #10310: [doc] Add hint about getmempoolentry to getrawmempool help. (master...doc-getrawmempool-getmempoolentry) https://github.com/bitcoin/bitcoin/pull/10310 18:08 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 18:09 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 18:20 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 18:24 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 18:41 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 18:46 -!- altoz_ [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has joined #bitcoin-core-dev 18:46 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has quit [Read error: Connection reset by peer] 18:51 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 19:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 19:09 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 19:13 -!- tw2006 [~tw2006@2601:187:8480:2770:78f7:2a3b:fdb1:c081] has joined #bitcoin-core-dev 19:18 -!- tw2006 [~tw2006@2601:187:8480:2770:78f7:2a3b:fdb1:c081] has quit [Ping timeout: 246 seconds] 19:30 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 19:30 -!- goksinen [~goksinen@2604:2000:c591:8400:5908:ad9a:1281:2967] has joined #bitcoin-core-dev 19:44 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 19:45 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 19:52 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 20:08 -!- goksinen [~goksinen@2604:2000:c591:8400:5908:ad9a:1281:2967] has quit [Remote host closed the connection] 21:02 -!- tw2006 [~tw2006@2601:187:8480:2770:989:88b3:3143:309f] has joined #bitcoin-core-dev 21:07 -!- tw2006 [~tw2006@2601:187:8480:2770:989:88b3:3143:309f] has quit [Ping timeout: 260 seconds] 22:12 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 22:14 < fanquake> cfields Can you take a look another the zeromq changes when you get a chance. I've played around with defining D_WIN32_WINNT=0x0600, but obviously I'm not doing something quite right. Will PR other depends changes today as well. 22:44 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 22:48 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-trzussrkrbjgmoot] has joined #bitcoin-core-dev 22:51 -!- tw2006 [~tw2006@2601:187:8480:2770:4053:80:81fb:3270] has joined #bitcoin-core-dev 22:53 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4bbd3d230f2...0e8499c53f9e 22:53 < bitcoin-git> bitcoin/master c26655e Wladimir J. van der Laan: doc: Add RPC interface guidelines 22:53 < bitcoin-git> bitcoin/master 0e8499c Wladimir J. van der Laan: Merge #10281: doc: Add RPC interface guidelines... 22:54 < bitcoin-git> [bitcoin] laanwj closed pull request #10281: doc: Add RPC interface guidelines (master...2017_04_rpc_if_guidelines) https://github.com/bitcoin/bitcoin/pull/10281 22:56 -!- tw2006 [~tw2006@2601:187:8480:2770:4053:80:81fb:3270] has quit [Ping timeout: 255 seconds] 23:02 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 23:02 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 23:02 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 23:03 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 23:09 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 23:20 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 23:43 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 23:47 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection]