--- Day changed Tue May 02 2017 00:25 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 00:25 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 00:25 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 00:31 -!- EagleTM [~hab@x5ce7dbc5.dyn.telefonica.de] has joined #bitcoin-core-dev 00:40 -!- tw2006 [~tw2006@2601:187:8480:2770:6cee:6272:49b6:8751] has joined #bitcoin-core-dev 00:44 < bitcoin-git> [bitcoin] btcdrak opened pull request #10311: Remove unused args from GetFetchFlags() (master...getflags) https://github.com/bitcoin/bitcoin/pull/10311 00:45 -!- tw2006 [~tw2006@2601:187:8480:2770:6cee:6272:49b6:8751] has quit [Ping timeout: 246 seconds] 01:01 -!- Eliel_ [~jojkaart@104-250-47-212.rev.cloud.scaleway.com] has joined #bitcoin-core-dev 01:01 -!- Eliel [~jojkaart@104-250-47-212.rev.cloud.scaleway.com] has quit [Ping timeout: 264 seconds] 01:04 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 260 seconds] 01:06 -!- wumpus [~quassel@pdpc/supporter/professional/wumpus] has quit [Remote host closed the connection] 01:08 -!- wumpus [~quassel@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 01:11 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:15 -!- Guest47977 is now known as array 02:29 -!- tw2006 [~tw2006@2601:187:8480:2770:2d23:6eb2:3304:ddaf] has joined #bitcoin-core-dev 02:32 -!- decoy [~decoy__3@5.79.86.129] has quit [Ping timeout: 240 seconds] 02:34 -!- tw2006 [~tw2006@2601:187:8480:2770:2d23:6eb2:3304:ddaf] has quit [Ping timeout: 255 seconds] 02:43 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-lwmjvnbyyvjtsygj] has quit [Remote host closed the connection] 02:43 -!- mariorz [sid490@gateway/web/irccloud.com/x-dyuweljyfdppxtml] has quit [Remote host closed the connection] 02:43 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-blvfwxywsxitdfkp] has quit [Remote host closed the connection] 02:43 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-imwdbglqmznierqr] has quit [Remote host closed the connection] 02:43 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-gzgcsrssreyejcty] has quit [Remote host closed the connection] 02:43 -!- wbnns [sid105317@21/bitcoin/binns] has quit [Remote host closed the connection] 02:45 -!- mariorz [sid490@gateway/web/irccloud.com/x-hbugshyudcnaflng] has joined #bitcoin-core-dev 02:49 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 02:50 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-yqwrgegsnovwwqas] has joined #bitcoin-core-dev 02:50 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 260 seconds] 02:50 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 02:55 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has quit [Ping timeout: 240 seconds] 03:15 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-viiyprgiyalonkdk] has joined #bitcoin-core-dev 03:16 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-aegvkbyqgcokurwh] has joined #bitcoin-core-dev 03:17 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-pmzbwilcqkijeakd] has joined #bitcoin-core-dev 03:20 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 03:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-trzussrkrbjgmoot] has quit [Quit: Connection closed for inactivity] 03:27 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:44 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 04:07 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 04:08 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:17 -!- chartractegg [~chartract@gateway/vpn/privateinternetaccess/chartractegg] has joined #bitcoin-core-dev 04:18 -!- tw2006 [~tw2006@2601:187:8480:2770:b116:47:3a01:813c] has joined #bitcoin-core-dev 04:19 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has joined #bitcoin-core-dev 04:23 -!- tw2006 [~tw2006@2601:187:8480:2770:b116:47:3a01:813c] has quit [Ping timeout: 260 seconds] 04:24 -!- tw2006 [~tw2006@2601:187:8480:2770:602d:1a48:4144:d039] has joined #bitcoin-core-dev 04:29 -!- chartractegg [~chartract@gateway/vpn/privateinternetaccess/chartractegg] has quit [Quit: Textual IRC Client: www.textualapp.com] 04:31 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 04:33 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 04:34 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 04:36 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 04:50 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 04:54 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Ping timeout: 240 seconds] 05:38 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ivqhdvznlnbuvwvw] has joined #bitcoin-core-dev 05:49 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 248 seconds] 05:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e8499c53f9e...e7b90f78f554 05:49 < bitcoin-git> bitcoin/master 66082e0 practicalswift: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) 05:49 < bitcoin-git> bitcoin/master e7b90f7 Wladimir J. van der Laan: Merge #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)... 05:49 < bitcoin-git> [bitcoin] laanwj closed pull request #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) (master...inadvertantly-and-tempoarily) https://github.com/bitcoin/bitcoin/pull/10180 05:50 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7b90f78f554...f4a6180607a8 05:50 < bitcoin-git> bitcoin/master 9a763d4 practicalswift: Remove excess logic. 05:50 < bitcoin-git> bitcoin/master f4a6180 Wladimir J. van der Laan: Merge #10175: Remove excess logic.... 05:51 < bitcoin-git> [bitcoin] laanwj closed pull request #10175: Remove excess logic. (master...excess-logic) https://github.com/bitcoin/bitcoin/pull/10175 05:52 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 05:55 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 05:57 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f4a6180607a8...a3e756b7d610 05:57 < bitcoin-git> bitcoin/master 7278537 Jonas Schnelli: [Qt] Don't add arguments of sensitive command to console window 05:57 < bitcoin-git> bitcoin/master a3e756b Jonas Schnelli: Merge #10093: [Qt] Don't add arguments of sensitive command to console window... 05:58 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10093: [Qt] Don't add arguments of sensitive command to console window (master...2017/03/qt_console) https://github.com/bitcoin/bitcoin/pull/10093 06:14 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 06:24 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 06:35 < jonasschnelli> For the HD restore keypool topup during SyncTransaction: I can I can't block the thread in the middle of SyncTransaction. But halting after the block has been stream through SyncTransaction may results in missing funds. 06:36 -!- shockoo [~shockoo@ip-94-112-163-197.net.upcbroadband.cz] has joined #bitcoin-core-dev 06:42 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 06:43 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:50 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:52 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 06:55 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 246 seconds] 06:56 < jonasschnelli> Should the wallet really freeze the validation/net process because we can't extend the keypool? 06:56 < jonasschnelli> What if the wallet just refuses to sync/write best block if it can't topup the keypool and wait until the wallet is unlocked, then topup and call ScanForWalletTransactions? 06:57 < wumpus> I think only in case of pruning, when there is the risk the blocks will be lost 06:57 < jonasschnelli> wumpus: Good point. 06:58 < jonasschnelli> Should the BlockConnected() (it's now the main signal that calls SyncTransaction) allows to halt the validation process? Or do we need another signal into the other direction? 06:59 < jonasschnelli> I think setting a validation flag directly from wallet is not ideal 07:08 -!- OfficialJustan [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 07:43 -!- goksinen [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Remote host closed the connection] 07:43 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 240 seconds] 07:43 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 264 seconds] 07:43 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-aegvkbyqgcokurwh] has quit [Ping timeout: 276 seconds] 07:43 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-yqwrgegsnovwwqas] has quit [Ping timeout: 276 seconds] 07:43 -!- thrasher` [~thrasher@unaffiliated/thrasher/x-7291870] has quit [Ping timeout: 255 seconds] 07:44 -!- mariorz [sid490@gateway/web/irccloud.com/x-hbugshyudcnaflng] has quit [Ping timeout: 276 seconds] 07:44 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 07:44 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 240 seconds] 07:44 -!- helo [~helo@unaffiliated/helo] has quit [Ping timeout: 264 seconds] 07:44 -!- adiabat [~adiabat@45.63.20.152] has quit [Ping timeout: 255 seconds] 07:44 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-jvqeitduwaewyool] has quit [Ping timeout: 255 seconds] 07:45 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-oxpgupfjlcdcbczu] has joined #bitcoin-core-dev 07:45 -!- lejitz [uid205154@gateway/web/irccloud.com/x-vngznefiwamxcacw] has quit [Ping timeout: 264 seconds] 07:45 -!- profall [sid29922@gateway/web/irccloud.com/x-jtdslbsdvgunpqei] has quit [Ping timeout: 264 seconds] 07:45 -!- aceat64 [~aceat64@47.184.60.245] has quit [Ping timeout: 255 seconds] 07:45 -!- [b__b] [~b__b]@54.85.45.223] has quit [Ping timeout: 240 seconds] 07:45 -!- baldur [~baldur@pool-100-2-139-91.nycmny.fios.verizon.net] has quit [Ping timeout: 255 seconds] 07:46 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-zivhqszzhoqahfkl] has joined #bitcoin-core-dev 07:46 -!- mariorz [sid490@gateway/web/irccloud.com/x-npwioqbcdyduwfha] has joined #bitcoin-core-dev 07:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 07:47 -!- twistedline_ [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 07:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:48 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 255 seconds] 07:48 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-pmzbwilcqkijeakd] has quit [Ping timeout: 240 seconds] 07:49 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 07:49 -!- thrasher` [~thrasher@unaffiliated/thrasher/x-7291870] has joined #bitcoin-core-dev 07:50 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-xudlkclrgrirdmpd] has joined #bitcoin-core-dev 07:50 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-wvyfdydexvduepmt] has joined #bitcoin-core-dev 07:51 -!- grubles [~grubles@45.76.177.92] has joined #bitcoin-core-dev 07:51 -!- grubles [~grubles@45.76.177.92] has quit [Changing host] 07:51 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 07:52 -!- bad_duck [~arthur@2001:bc8:c087:1001::1] has quit [Ping timeout: 246 seconds] 07:52 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 07:53 -!- helo [~helo@unaffiliated/helo] has joined #bitcoin-core-dev 07:54 -!- QBcrusher_ [~QBcrusher@cpe-173-88-70-206.columbus.res.rr.com] has joined #bitcoin-core-dev 07:55 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 07:56 -!- bad_duck [~arthur@area51.powaaa.com] has joined #bitcoin-core-dev 07:56 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev 07:56 -!- aceat64 [~aceat64@47.184.60.245] has joined #bitcoin-core-dev 07:56 -!- baldur [~baldur@pool-100-2-139-91.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 07:56 -!- QBcrusher [~QBcrusher@cpe-173-88-70-206.columbus.res.rr.com] has quit [Ping timeout: 260 seconds] 08:00 < bitcoin-git> [bitcoin] instagibbs opened pull request #10313: [Consensus] Add constant for maximum stack size (master...stackconst) https://github.com/bitcoin/bitcoin/pull/10313 08:13 -!- [b__b] [~b__b]@54.85.45.223] has joined #bitcoin-core-dev 08:19 < bitcoin-git> [bitcoin] practicalswift opened pull request #10314: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...) (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/10314 08:44 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 08:53 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:42 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a3e756b7d610...faf2dea5ea81 09:42 < bitcoin-git> bitcoin/master 77c54b2 John Newbery: [net] listbanned RPC and QT should show correct banned subnets 09:42 < bitcoin-git> bitcoin/master d6732d8 John Newbery: [tests] update disconnect_ban.py test case to work with listbanned 09:42 < bitcoin-git> bitcoin/master faf2dea Wladimir J. van der Laan: Merge #10234: [net] listbanned RPC and QT should show correct banned subnets... 09:43 < bitcoin-git> [bitcoin] laanwj closed pull request #10234: [net] listbanned RPC and QT should show correct banned subnets (master...list_banned_correctly) https://github.com/bitcoin/bitcoin/pull/10234 09:43 -!- lejitz [uid205154@gateway/web/irccloud.com/x-xdcftartjlcaprft] has joined #bitcoin-core-dev 09:47 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 09:47 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 09:47 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/faf2dea5ea81...1d75597ba6e8 09:49 < bitcoin-git> bitcoin/master 661caf8 fanquake: [doc] Minor corrections to osx dependencies 09:49 < bitcoin-git> bitcoin/master 1d75597 Wladimir J. van der Laan: Merge #10260: [doc] Minor corrections to osx dependencies... 09:50 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Remote host closed the connection] 09:50 < bitcoin-git> [bitcoin] laanwj closed pull request #10260: [doc] Minor corrections to osx dependencies (master...osx-doc-update) https://github.com/bitcoin/bitcoin/pull/10260 09:54 -!- profall [sid29922@gateway/web/irccloud.com/x-ilsbtzzjaortnhop] has joined #bitcoin-core-dev 09:57 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 10:00 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d75597ba6e8...2580ff81f442 10:00 < bitcoin-git> bitcoin/master 3fe8a83 practicalswift: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...) 10:00 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:00 < bitcoin-git> bitcoin/master 2580ff8 Wladimir J. van der Laan: Merge #10314: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)... 10:01 < bitcoin-git> [bitcoin] laanwj closed pull request #10314: Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...) (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/10314 10:02 -!- fronti [~fronti@irc.fh-biergarten.de] has left #bitcoin-core-dev [] 10:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:04 -!- iroot-servers [~iroot-ser@112.208.7.197] has joined #bitcoin-core-dev 10:12 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2580ff81f442...8f3e38477e30 10:12 < bitcoin-git> bitcoin/master 52e15aa John Newbery: Adds helper functions to NodeConnCB... 10:12 < bitcoin-git> bitcoin/master 2a52ae6 John Newbery: Remove duplicate method definitions in NodeConnCB subclasses... 10:12 < bitcoin-git> bitcoin/master 8f3e384 Wladimir J. van der Laan: Merge #10169: [tests] Remove func test code duplication... 10:15 -!- altoz_ is now known as altoz 10:20 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 10:25 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Read error: Connection reset by peer] 10:38 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:39 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 276 seconds] 10:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:47 -!- goksinen [~goksinen@2604:2000:c591:8400:216e:192:dc51:ca89] has joined #bitcoin-core-dev 10:48 -!- goksinen [~goksinen@2604:2000:c591:8400:216e:192:dc51:ca89] has quit [Remote host closed the connection] 10:57 -!- hashmynonce [~linuxman@142.244.196.246] has joined #bitcoin-core-dev 10:59 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8f3e38477e30...dc8fc0c73beb 11:07 < bitcoin-git> bitcoin/master c9cc76d John Newbery: [tests] Remove is_network_split from funtional test cases 11:07 < bitcoin-git> bitcoin/master dc8fc0c MarcoFalke: Merge #10198: [tests] Remove is_network_split from functional test framework... 11:07 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10198: [tests] Remove is_network_split from functional test framework (master...remove_is_network_split) https://github.com/bitcoin/bitcoin/pull/10198 11:15 < bitcoin-git> [bitcoin] parazyd opened pull request #10316: fix contrib/debian builds; prefer qt5 (master...debian-packaging) https://github.com/bitcoin/bitcoin/pull/10316 11:15 -!- iroot-servers [~iroot-ser@112.208.7.197] has quit [Remote host closed the connection] 11:20 -!- hashmynonce [~linuxman@142.244.196.246] has quit [Quit: Leaving] 11:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc8fc0c73beb...3c5e6c94caf4 11:21 < bitcoin-git> bitcoin/master dadfee3 Jimmy Song: [test] Add test for listaddressgroupings... 11:21 < bitcoin-git> bitcoin/master 3c5e6c9 MarcoFalke: Merge #10255: [test] Add test for listaddressgroupings... 11:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10255: [test] Add test for listaddressgroupings (master...test_listaddressgroupings) https://github.com/bitcoin/bitcoin/pull/10255 11:23 -!- bsm1175321 [~mcelrath@135.84.167.210] has joined #bitcoin-core-dev 11:25 < BlueMatt> cfields: yo 11:35 -!- EagleTM [~hab@x5ce7dbc5.dyn.telefonica.de] has left #bitcoin-core-dev [] 11:40 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:44 < cfields> BlueMatt: pong 11:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c5e6c94caf4...75171f099e82 11:53 < bitcoin-git> bitcoin/master b8d9a86 practicalswift: Remove unused import 11:53 < bitcoin-git> bitcoin/master 73b3721 practicalswift: Remove accidental trailing semicolons 11:53 < bitcoin-git> bitcoin/master 75171f0 MarcoFalke: Merge #10137: Remove unused import. Remove accidental trailing semicolons.... 11:54 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10137: Remove unused import. Remove accidental trailing semicolons. (master...python-20170402) https://github.com/bitcoin/bitcoin/pull/10137 11:54 -!- [Author] [~Author]@2401:a400:3200:5600:bad:d09:15:90d] has quit [Ping timeout: 252 seconds] 11:58 -!- [Author] [~Author]@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 11:59 -!- tw2006 [~tw2006@2601:187:8480:2770:602d:1a48:4144:d039] has quit [Remote host closed the connection] 12:23 < bitcoin-git> [bitcoin] practicalswift opened pull request #10317: Remove unused Python imports (master...remove-unused-python-imports-ii) https://github.com/bitcoin/bitcoin/pull/10317 12:25 -!- shockoo [~shockoo@ip-94-112-163-197.net.upcbroadband.cz] has quit [Read error: Connection reset by peer] 12:26 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 12:26 -!- nemgun [~nemgun@105.101.33.53] has joined #bitcoin-core-dev 12:32 -!- tw2006 [~tw2006@2601:187:8480:2770:81cd:e7ff:57d5:425a] has joined #bitcoin-core-dev 12:33 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has quit [Ping timeout: 260 seconds] 12:43 -!- nemgun [~nemgun@105.101.33.53] has quit [Quit: Leaving] 12:54 < BlueMatt> cfields: nvm, see review on #10285 12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/10285 | net: refactor the connection process. moving towards async connections. by theuni · Pull Request #10285 · bitcoin/bitcoin · GitHub 13:07 -!- anthonyjd [~Anthony@2001:470:daef:e1e1:27a3:b8c8:9db:79f6] has joined #bitcoin-core-dev 13:14 < BlueMatt> cfields: yea, #10285 is super annoying because it seems to be a step in the wrong direction by itself 13:14 < BlueMatt> :/ 13:14 < gribble> https://github.com/bitcoin/bitcoin/issues/10285 | net: refactor the connection process. moving towards async connections. by theuni · Pull Request #10285 · bitcoin/bitcoin · GitHub 13:15 < cfields> BlueMatt: yea, understood. I kinda expected that type of feedback :( 13:15 < cfields> BlueMatt: the next commits make things happen in callbacks, so the flow needs to be broken up. But I'm afraid that's just too much for one PR. 13:15 < BlueMatt> yea, i mean im not gonna nack it because i know you're going somewhere, but maybe open the next pr to get concept acks before this one gets merged? 13:15 < BlueMatt> (which is apparently what we're all doing now) 13:16 < cfields> heh, yea 13:16 < cfields> ok, I can do that. 13:18 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye] 13:37 < bitcoin-git> [bitcoin] jnewbery opened pull request #10318: [tests] fix wait_for_inv() (master...fix_wait_for_inv) https://github.com/bitcoin/bitcoin/pull/10318 13:43 -!- marcoagner [~user@177.41.195.11] has quit [Ping timeout: 240 seconds] 13:57 -!- marcoagner [~user@177.41.192.53] has joined #bitcoin-core-dev 13:58 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Quit: No Ping reply in 180 seconds.] 13:59 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] practicalswift opened pull request #10319: Remove unused argument from MarkBlockAsInFlight(...) (master...remove-unused-argument) https://github.com/bitcoin/bitcoin/pull/10319 14:09 -!- instagibbs [~instagibb@pool-100-15-117-236.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds] 14:17 -!- instagibbs [~instagibb@pool-100-15-117-236.washdc.fios.verizon.net] has joined #bitcoin-core-dev 14:40 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 14:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:52 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 14:52 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 14:52 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:53 -!- cryptapus is now known as cryptapus_afk 14:53 -!- questioner2 [02daf310@gateway/web/freenode/ip.2.218.243.16] has joined #bitcoin-core-dev 14:53 < questioner2> ok guys. imagine its december 2017. segwit has activated. blocks are being made to segwit specification. all the major nodes are relaying and accepting to the consensus and policy of 0.13.2+.. now then. we have a legacy user making a legacy transaction. is the network and pool nodes only allowing 4k sigops (20k/5) or 16k (80k/5) for the legacy tx. can someone show me where the (20k/5) still exists as a rule 14:55 < luke-jr> questioner2: sigops in legacy scripts count 4x toward the 80k limit 14:56 < luke-jr> this is in validation.cpp:GetTransactionSigOpCost 14:56 < questioner2> so a legacy tx can make 4 tx of 20k each 15:01 -!- Naphex [~naphex@naphex.rocks] has quit [Ping timeout: 276 seconds] 15:01 -!- Naphex [~naphex@naphex.rocks] has joined #bitcoin-core-dev 15:10 < questioner2> ok after trying to read what you say. the consensus/policy is 80k/5 for tx sigops = 16k. but legacy tx has 4x of the 16k = 4k 15:11 < questioner2> so just 20 tx of 4k legacy can use up all the blocks sigops 15:11 < sipa> questioner2: the easiest way to see it is that from the point of view of an old wallet, nothing changed 15:11 < sipa> 20k legacy sigops were allowed before, 20k legacy sigops are allowed after 15:12 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has quit [Ping timeout: 268 seconds] 15:14 < questioner2> is using up all 20k legacy treated as using up all 80k block sigops. or treated as legacy tx only use 25% of blocksigop limits allowing segwit transactions to still have 60x sigops spare to use in the base block 15:14 < questioner2> 60k* 15:14 < sipa> a legacy sigop counts as 4 segwit sigops 15:15 < sipa> so 20k legacy sigops would fill a block 15:15 < questioner2> so 5 legacy tx of 4k sigops would fill the block not allowing segwit txdata to sit in base block 15:16 < questioner2> 4k sigops each* (=20k legacy) 15:17 < sipa> just as 1M of non-segwit transactions would fill the whole block, not leaving space for segwit transactions 15:17 < sipa> *1M bytes 15:17 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 15:20 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has joined #bitcoin-core-dev 15:20 < questioner2> i understand data spam of 1m ;egacy in base block can stop segwit tx's as one spam attack vector. i am just looking at other attack vectors using sigops where it doesnt need 1m of data, just a certain number of sigops to hold up possible capcity utility 15:33 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 15:35 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 15:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:39 -!- cryptapus is now known as cryptapus_afk 15:48 -!- marcoagner [~user@177.41.192.53] has quit [Ping timeout: 260 seconds] 15:51 -!- _anthony_ [~Anthony@2001:470:daef:e1e1:27a3:b8c8:9db:79f6] has joined #bitcoin-core-dev 15:51 -!- anthonyjd [~Anthony@2001:470:daef:e1e1:27a3:b8c8:9db:79f6] has quit [Remote host closed the connection] 15:55 -!- marcoagner [~user@177.41.192.53] has joined #bitcoin-core-dev 16:01 < bitcoin-git> [bitcoin] sipa closed pull request #10299: Remove OpenSSL (master...simplerandom) https://github.com/bitcoin/bitcoin/pull/10299 16:03 < bitcoin-git> [bitcoin] sipa opened pull request #10321: Use FastRandomContext for all tests (master...fast_rand_tests) https://github.com/bitcoin/bitcoin/pull/10321 16:35 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]] 16:45 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 16:51 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:58 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 17:03 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 17:29 -!- Dyaheon [~Dya@91.156.192.24] has quit [Ping timeout: 240 seconds] 17:30 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 17:37 -!- harrymm [~wayne@104.237.91.120] has quit [Read error: Connection reset by peer] 17:39 -!- harrymm [~wayne@104.237.91.147] has joined #bitcoin-core-dev 17:43 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 17:44 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ivqhdvznlnbuvwvw] has quit [Quit: Connection closed for inactivity] 17:48 < Chris_Stewart_5> Has anyone had to deal with using bitcoind as a dependency with travis ci? Is there a way to get them to whitelist it's use in -regtest mode? 17:50 < sipa> ? 17:50 < sipa> why would it need a whitelist? 17:52 < Chris_Stewart_5> It looks like travis-ci bans people that use bitcoin as a dependency in .travis.yml 17:52 < Chris_Stewart_5> https://travis-ci.org/bitcoin-s/bitcoin-s-rpc-client/requests 17:52 < Chris_Stewart_5> claiming I am mining 17:52 < sipa> ah, i see 17:53 < sipa> perhaps if you built bitcoind inside the VM? 17:53 < Chris_Stewart_5> and now I am a repeat offender :o. I emailed the travis ci people to hopefully get off of the list 17:53 < sipa> rather than using it as a dependency 17:53 < sipa> yeah, contact them to explain first 17:53 < Chris_Stewart_5> I asked if they could whitelist 'bitcoind -regtest' 17:53 < Chris_Stewart_5> We will see what the response is :/ 17:55 < sipa> bitcoind doesn't even contain a miner anymore 17:55 < luke-jr> sipa: they banned us too 17:55 < luke-jr> had to get whitelisted :/ 17:55 < Chris_Stewart_5> luke-jr: How long ago was that? 17:55 < luke-jr> not sure, a Looooooong time ago 17:57 < gmaxwell> great so even we're using a service that bans people for running our software. :( 17:58 < Chris_Stewart_5> yeah, I didn't even just get banned on that repo, it looks like I am banned on all repos :S 18:22 < bitcoin-git> [bitcoin] sipa opened pull request #10322: Use hardware timestamps in RNG seeding (master...rdtsc) https://github.com/bitcoin/bitcoin/pull/10322 18:43 < sipa> gmaxwell: std::random_device in libstdc++ from modern G++ uses rdrand when available, so we could just include that into the seeding 18:44 < sipa> and /dev/urandom otherwise 18:44 < sipa> ... however, the mingw-64 version just uses a mersenne twister with a constant(!) seed 18:49 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 18:57 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has quit [Ping timeout: 240 seconds] 18:59 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 19:00 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has quit [Read error: Connection reset by peer] 19:00 -!- moli_ [~molly@unaffiliated/molly] has quit [Remote host closed the connection] 19:00 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 19:01 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 19:18 -!- fao2 [~fao@unknown-3-103.windriver.com] has joined #bitcoin-core-dev 19:21 -!- fao1 [~fao@106.120.101.38] has quit [Ping timeout: 260 seconds] 19:21 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 240 seconds] 19:27 < bitcoin-git> [bitcoin] sipa opened pull request #10323: Update to latest libsecp256k1 master (master...secp_up) https://github.com/bitcoin/bitcoin/pull/10323 19:27 -!- arowser [~quassel@unknown-3-103.windriver.com] has joined #bitcoin-core-dev 19:57 -!- arowser_ [~quassel@106.120.101.38] has joined #bitcoin-core-dev 19:57 -!- fao3 [~fao@106.120.101.38] has joined #bitcoin-core-dev 19:59 -!- arowser [~quassel@unknown-3-103.windriver.com] has quit [Read error: Connection reset by peer] 20:00 -!- fao2 [~fao@unknown-3-103.windriver.com] has quit [Ping timeout: 240 seconds] 20:00 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 20:00 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 20:09 -!- logsys [3a22775b@gateway/web/freenode/ip.58.34.119.91] has joined #bitcoin-core-dev 20:10 -!- _anthony_ [~Anthony@2001:470:daef:e1e1:27a3:b8c8:9db:79f6] has quit [Quit: Leaving] 20:29 < sipa> TIL: C++ template parameters can be (uninstantiated) templates themselves 20:42 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75171f099e82...431a548faaf5 20:42 < bitcoin-git> bitcoin/master db994b2 Pieter Wuille: Simplify DisconnectBlock arguments/return value... 20:42 < bitcoin-git> bitcoin/master 431a548 Pieter Wuille: Merge #10297: Simplify DisconnectBlock arguments/return value... 20:43 < bitcoin-git> [bitcoin] sipa closed pull request #10297: Simplify DisconnectBlock arguments/return value (master...disconnect_enum) https://github.com/bitcoin/bitcoin/pull/10297 20:53 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has joined #bitcoin-core-dev 21:12 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 276 seconds] 21:13 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 21:34 -!- arowser_ [~quassel@106.120.101.38] has quit [Ping timeout: 264 seconds] 21:34 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 22:07 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has quit [Ping timeout: 255 seconds] 22:12 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has joined #bitcoin-core-dev 22:55 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 23:00 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:00 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 23:11 -!- logsys [3a22775b@gateway/web/freenode/ip.58.34.119.91] has quit [Ping timeout: 260 seconds] 23:11 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rpxxzbwhqkexbflo] has joined #bitcoin-core-dev 23:15 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/431a548faaf5...d4732f3232c3 23:15 < bitcoin-git> bitcoin/master bd1f138 Pieter Wuille: Add getchaintxstats RPC 23:15 < bitcoin-git> bitcoin/master d4732f3 Wladimir J. van der Laan: Merge #9733: Add getchaintxstats RPC... 23:17 < bitcoin-git> [bitcoin] laanwj closed pull request #9733: Add getchaintxstats RPC (master...chaintxstats) https://github.com/bitcoin/bitcoin/pull/9733 23:26 -!- mryandao [~mryandao@unaffiliated/mryandao] has quit [Quit: do not disturb. look busy...] 23:47 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4732f3232c3...83073de4bdd8 23:47 < bitcoin-git> bitcoin/master b8251f6 John Newbery: [tests] allow zmq test to be run in out-of-tree builds 23:47 < bitcoin-git> bitcoin/master 83073de Wladimir J. van der Laan: Merge #10307: [tests] allow zmq test to be run in out-of-tree builds... 23:48 < bitcoin-git> [bitcoin] laanwj closed pull request #10307: [tests] allow zmq test to be run in out-of-tree builds (master...fix_zmq_test_out_of_tree) https://github.com/bitcoin/bitcoin/pull/10307 23:52 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds]