--- Day changed Fri Jun 02 2017 00:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:25 -!- emzy_ is now known as emzy 00:26 -!- emzy [~quassel@raspberry.emzy.de] has quit [Changing host] 00:26 -!- emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-dev 00:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:35 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:3803:b740:7f63:d725] has joined #bitcoin-core-dev 00:35 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 00:39 < midnightmagic> ô/w 4 01:20 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD] 01:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:32 -!- mkarrer [~mkarrer@158.red-83-53-16.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD] 01:39 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:40 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 01:41 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 01:43 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:59 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cc2c670e3d7...00d369239612 01:59 < bitcoin-git> bitcoin/master e7c1b44 Pieter Wuille: Squashed 'src/secp256k1/' changes from 8225239..84973d3... 01:59 < bitcoin-git> bitcoin/master 5252827 Pieter Wuille: Update to latest libsecp256k1 01:59 < bitcoin-git> bitcoin/master 00d3692 Wladimir J. van der Laan: Merge #10323: Update to latest libsecp256k1 master... 02:00 < bitcoin-git> [bitcoin] laanwj closed pull request #10323: Update to latest libsecp256k1 master (master...secp_up) https://github.com/bitcoin/bitcoin/pull/10323 02:03 -!- cysm_ [cysm@gateway/shell/elitebnc/x-gtpdfltrjgahapaz] has quit [Ping timeout: 240 seconds] 02:07 -!- cysm_ [cysm@gateway/shell/elitebnc/x-fffsqqnhtkmjkcvk] has joined #bitcoin-core-dev 02:23 -!- Yogaqueef [~textual@dsl-hkibrasgw3-58c3d4-235.dhcp.inet.fi] has joined #bitcoin-core-dev 02:26 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 02:33 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:c9a5:9228:db23:2f62] has joined #bitcoin-core-dev 02:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00d369239612...1aefc94dd78d 02:36 < bitcoin-git> bitcoin/master 930deb9 John Newbery: [tests] skipped tests should clean up after themselves 02:36 < bitcoin-git> bitcoin/master 1aefc94 MarcoFalke: Merge #10423: [tests] skipped tests should clean up after themselves... 02:36 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10423: [tests] skipped tests should clean up after themselves (master...cleanup_skipped) https://github.com/bitcoin/bitcoin/pull/10423 02:36 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:3803:b740:7f63:d725] has quit [Ping timeout: 240 seconds] 02:41 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:52 -!- tunafizz [~tuna@c-71-207-56-72.hsd1.pa.comcast.net] has quit [Ping timeout: 240 seconds] 02:52 -!- tunafizz [~tuna@c-71-207-56-72.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 03:02 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1aefc94dd78d...329fc1dce7a1 03:13 < bitcoin-git> bitcoin/master d8c218f John Newbery: [tests] Functional tests call self.start_node(s) and self.stop_node(s)... 03:13 < bitcoin-git> bitcoin/master a433d8a John Newbery: [tests] Update start/stop node functions to be private module functions... 03:13 < bitcoin-git> bitcoin/master 53f6775 John Newbery: fixup: fix nits 03:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods (master...test_framework_start_stop_nodes) https://github.com/bitcoin/bitcoin/pull/10359 03:16 -!- Aaronvan_ is now known as AaronvanW 03:19 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-bgdhwubmdwfqydzl] has quit [Quit: Connection closed for inactivity] 03:49 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-vdzqkxjftyfpozpg] has joined #bitcoin-core-dev 04:00 -!- john [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 04:01 -!- john is now known as Guest26727 04:01 -!- Guest60910 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 255 seconds] 04:02 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:4453:69a4:e550:d8bc] has joined #bitcoin-core-dev 04:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 04:05 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:c9a5:9228:db23:2f62] has quit [Ping timeout: 240 seconds] 04:06 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:d81b:6442:1d69:7ebf] has quit [Ping timeout: 246 seconds] 04:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:15 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:94e9:1e09:fd3f:a206] has joined #bitcoin-core-dev 04:18 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:4453:69a4:e550:d8bc] has quit [Ping timeout: 255 seconds] 04:34 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:e039:b4c9:ec24:ffd0] has joined #bitcoin-core-dev 04:38 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:94e9:1e09:fd3f:a206] has quit [Ping timeout: 240 seconds] 04:49 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:4c43:9dc4:1074:61c4] has joined #bitcoin-core-dev 04:51 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:5d12:bc9f:a82b:6b10] has joined #bitcoin-core-dev 04:53 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:e039:b4c9:ec24:ffd0] has quit [Ping timeout: 245 seconds] 04:53 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:a994:61f2:bed3:85c4] has joined #bitcoin-core-dev 04:54 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:4c43:9dc4:1074:61c4] has quit [Ping timeout: 255 seconds] 04:55 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:5d12:bc9f:a82b:6b10] has quit [Ping timeout: 255 seconds] 05:08 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:c86:7145:1554:7e45] has joined #bitcoin-core-dev 05:12 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 05:12 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:a994:61f2:bed3:85c4] has quit [Ping timeout: 255 seconds] 05:13 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:15d9:4633:f7df:370d] has joined #bitcoin-core-dev 05:17 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:bcd1:5ad7:40e7:e6fd] has joined #bitcoin-core-dev 05:17 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:c86:7145:1554:7e45] has quit [Ping timeout: 260 seconds] 05:20 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:15d9:4633:f7df:370d] has quit [Ping timeout: 272 seconds] 05:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 05:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:53 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Excess Flood] 05:54 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 05:55 -!- Gnof [~Gnof@CPE00fc8d7da303-CM00fc8d7da300.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 05:56 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Changing host] 05:56 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 05:59 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-vdzqkxjftyfpozpg] has quit [Quit: Connection closed for inactivity] 06:06 -!- str4d [~str4d@27.110.123.92] has quit [Ping timeout: 268 seconds] 06:07 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:11 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:49d0:a749:a1f1:4a7b] has joined #bitcoin-core-dev 06:11 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:11 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:c5f5:8814:f9aa:11f0] has joined #bitcoin-core-dev 06:15 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:bcd1:5ad7:40e7:e6fd] has quit [Ping timeout: 272 seconds] 06:15 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:49d0:a749:a1f1:4a7b] has quit [Ping timeout: 255 seconds] 06:16 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:23 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-dugyweebxfwgvhgj] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508 06:35 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509 06:37 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:d81b:6442:1d69:7ebf] has joined #bitcoin-core-dev 06:38 < Anduck> https://twitter.com/movrcx/status/870527842789892096 06:41 < instagibbs> Anduck, I can do the same offer, but only require 499BTC :) 06:41 < Anduck> apparently this guy is "vouched" by some earlier found 0days. could be bullshit though 06:42 < Apocalyptic> instagibbs, DoS is a broad term 06:42 < Lauda> create 300k TXs per day 06:42 < Lauda> now pay me 498 BTC 06:44 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:117d:e2c:93e8:731] has joined #bitcoin-core-dev 06:48 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:c5f5:8814:f9aa:11f0] has quit [Ping timeout: 255 seconds] 07:00 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:f082:3e85:2810:1fd] has joined #bitcoin-core-dev 07:04 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:117d:e2c:93e8:731] has quit [Ping timeout: 260 seconds] 07:09 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 07:20 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 255 seconds] 07:22 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 07:24 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 07:27 -!- Taek42 is now known as Taek 07:41 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:50 < kinlo> mja, ge moest u inschrijven, ik ben aant hore of ik wel kan 07:50 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 07:50 < kinlo> wrong channel :/ 07:50 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 07:56 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has quit [Ping timeout: 268 seconds] 07:56 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 08:03 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 08:20 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:f520:a0e2:c219:be5] has joined #bitcoin-core-dev 08:24 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:f082:3e85:2810:1fd] has quit [Ping timeout: 258 seconds] 08:26 < jonasschnelli> wumpus: do you intend to directly bump to rc2 or does it make sense to gitian build rc1? 08:26 < wumpus> I'd prefer to just go on with it 08:27 < wumpus> I'll just add in the announcement that the version isn't bumped and we'll do that for next rc 08:28 < jonasschnelli> okay.. fine by me 08:30 < wumpus> I'd expect something to come up for rc1, and if not, well then we'll do a very short rc2 just to see if the version bump worked 08:49 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:57 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:1cdb:c08d:afcc:7eab] has joined #bitcoin-core-dev 08:58 -!- goatturner [~Beatrootg@2.126.80.59] has joined #bitcoin-core-dev 09:01 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:f520:a0e2:c219:be5] has quit [Ping timeout: 272 seconds] 09:01 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:1cdb:c08d:afcc:7eab] has quit [Ping timeout: 255 seconds] 09:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 09:18 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Killed (Sigyn (Spam is off topic on freenode.))] 09:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:40 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 09:54 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 255 seconds] 09:55 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:d81b:6442:1d69:7ebf] has quit [Ping timeout: 245 seconds] 09:55 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 10:05 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 10:25 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 258 seconds] 10:34 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 240 seconds] 10:47 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:07 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 11:07 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 11:09 -!- spudowiar [~spudowiar@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 11:11 < spudowiar> What's the protocol for adding new strings to Bitcoin Core? Do I have to worry about translation or will that be sorted by others? 11:14 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 255 seconds] 11:15 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 11:15 < sipa> spudowiar: don't worry about it 11:16 < sipa> in the 0.15 release notes there is a string freeze 11:16 < sipa> eh, release schedule 11:16 < sipa> after that time, no changes to strings can be made anymore, to give time for translators 11:17 < spudowiar> Thanks :) 11:20 -!- Gnof_ [~Gnof@CPE00fc8d7da303-CM00fc8d7da300.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 11:24 -!- Gnof [~Gnof@CPE00fc8d7da303-CM00fc8d7da300.cpe.net.cable.rogers.com] has quit [Ping timeout: 240 seconds] 11:29 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 11:33 -!- Gnof_ [~Gnof@CPE00fc8d7da303-CM00fc8d7da300.cpe.net.cable.rogers.com] has quit [Quit: ---] 11:40 < jnewbery> wumpus: please remove #10044 from high priority for review - I'm not actively working on it for now 11:40 < gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub 11:40 < sipa> jnewbery: :( 11:41 < sipa> jnewbery: done 11:41 < jnewbery> sipa: do you particularly want it? I didn't sense there was all that much enthusiasm for it 11:43 < spudowiar> Can I use C++11 std::map::at()? 11:43 < sipa> spudowiar: yes, but i would advise against relying on exceptions 11:44 < spudowiar> Why? 11:45 < sipa> especially in the case of at; you can just use auto it = map.find(key); if (it != map.end()) { ... } else { ... } instead 11:45 < spudowiar> Ah, I'll do that instead then 11:45 < spudowiar> Thanks! 11:46 < sipa> jnewbery: i conceptually like i very much... i think make check should do ~all reasonable checking 11:46 < sipa> but i understand there are concerns that make the choice of what to run where and when hard 11:47 < jnewbery> yeah - I couldn't seem to converge with others on what's a sensible choice of what to run 11:47 < jnewbery> I'll probably pick it up again at some point, but it shouldn't really be in the review priority bucket since there's nothing to review at this point 11:47 < sipa> perhaps something to bring up as a meeting topic 11:48 < sipa> agree with removing it from priority review list 11:49 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 11:49 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:53 -!- Guest26727 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 268 seconds] 11:55 -!- Guest80280 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 11:56 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 255 seconds] 11:59 < spudowiar> Do you have any qualms with executing a command and piping data into it? 11:59 < spudowiar> Also, are there any examples of this in the Bitcoin Core code? 12:04 < spudowiar> Before, I was using popen but now I want to clean up this patch in order to submit it 12:10 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 12:17 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .] 12:19 < spudowiar> Should I be adding more code using boost? Because I could use boost::process for this 12:20 < spudowiar> I mean, should I be avoiding using boost? 12:20 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 12:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 12:38 -!- spudowiar [~spudowiar@unaffiliated/saleemrashid] has quit [Quit: WeeChat 1.8] 12:41 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 13:01 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 13:02 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 13:10 -!- Yogaqueef [~textual@dsl-hkibrasgw3-58c3d4-235.dhcp.inet.fi] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 13:11 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Quit: mining] 13:15 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 13:25 -!- elkalamar [~elkalamar@90.174.4.14] has joined #bitcoin-core-dev 13:39 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 255 seconds] 13:44 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Quit: mining] 13:49 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 14:09 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:12 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has quit [Ping timeout: 240 seconds] 14:19 < bitcoin-git> [bitcoin] achow101 opened pull request #10511: [Tests] Include branch coverage info in coverage test (master...lcov) https://github.com/bitcoin/bitcoin/pull/10511 14:25 -!- dermoth [~thomas@2002:4224:87a5:dead:5604:a6ff:feef:66a1] has joined #bitcoin-core-dev 14:30 -!- elkalamar [~elkalamar@90.174.4.14] has quit [Ping timeout: 240 seconds] 14:35 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Quit: mining] 14:37 -!- talmai [~T@76.24.28.74] has joined #bitcoin-core-dev 14:42 -!- tiagotrs_ [~tiago@dhcp-215-149.vpn.tu-berlin.de] has joined #bitcoin-core-dev 14:43 -!- talmai [~T@76.24.28.74] has quit [Quit: mining] 15:04 -!- harrymm [~wayne@104.237.91.72] has joined #bitcoin-core-dev 15:05 < bitcoin-git> [bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512 15:11 -!- tiagotrs_ [~tiago@dhcp-215-149.vpn.tu-berlin.de] has quit [Ping timeout: 260 seconds] 15:12 -!- tiagotrs1 [~tiago@p5DC47106.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 15:15 < bitcoin-git> [bitcoin] ABISprotocol opened pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513 15:24 -!- elkalamar [~elkalamar@140.188.133.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 15:27 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has quit [Remote host closed the connection] 15:28 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has joined #bitcoin-core-dev 15:29 -!- spudowiar [~android@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 15:31 -!- jrayhawk_ [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev 15:32 < spudowiar> gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization 15:36 < gmaxwell> spudowiar: almost certantly not, needing megabytes of ram to buffer such a thing require several extra dollars in parts. 15:36 < spudowiar> No, not on the actual hardware wallet 15:37 < spudowiar> For the vendor specific tools 15:37 < gmaxwell> spudowiar: existing hardware wallets go through serious work to avoid even having to buffer a single transaction, much less a json encoded one. 15:37 < gmaxwell> uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it. 15:37 < spudowiar> No, because most hardware wallets serialize it themselves 15:38 < spudowiar> Although I have a very complete understanding of Trezor and a very limited ones of others 15:39 < spudowiar> Btw, didn't jonasschnelli's hardware wallet used to use JSON :) 15:39 < spudowiar> Anyway, I was using Protocol Buffers in my PoC but I knew I couldn't submit that because you'd probably kill me ;) 15:40 -!- Lightsword_ [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev 15:40 -!- Lightsword [~Lightswor@107.170.253.193] has quit [Excess Flood] 15:40 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Remote host closed the connection] 15:40 -!- thermoman [~thermoman@wtf.foobar0815.de] has quit [Remote host closed the connection] 15:40 -!- thermoman [~thermoman@wtf.foobar0815.de] has joined #bitcoin-core-dev 15:41 < spudowiar> Basically my patch takes an argument -hardwarewallet= 15:41 -!- Lightsword_ is now known as Lightsword 15:41 < spudowiar> When you spend with the wallet, it executes the command, pipes in the transaction (in Protocol Buffers at the moment) and the command returns the serialized transaction 15:41 < spudowiar> Then Bitcoin Core verifies that 15:42 < spudowiar> If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core 15:42 -!- tiagotrs1 [~tiago@p5DC47106.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 15:43 * luke-jr idly ponders if there's a way to do that such that bitcoind is itself a valid -hardwarewallet 15:44 < gmaxwell> I don't see why you wouldn't use the ordinary serialization plus metadata, _any_ hardware wallet needs to be able to handle the serialization of transactions. Plus how would you proprose to handle things like coinjoins and partially signed multsigs? 15:44 < spudowiar> I don't have bitcoind as one, but I have a script that talks to a bitcoind over RPC 15:44 < spudowiar> gmaxwell: Hardware wallets don't deserialize the transactions, they always accept it in a different format 15:45 < spudowiar> JSON is so much easier because, otherwise, each tool has to deserialize the transaction 15:45 < spudowiar> Partially signed multisig, on a TREZOR, is done totally differently to a P2PKH 15:47 < spudowiar> luke-jr: ln -s bitcoind bitcoind-hardwarewallet and do an argv check :) 15:47 < gmaxwell> spudowiar: of course they do, e.g. to pass them the inputs for value checking you must pass them the input transactions exactly. 15:48 < spudowiar> Oh, yeah. But they don't deserialize the to-be-signed transaction 15:50 < sipa> then how do they compute the sighash? 15:51 < spudowiar> They serialize it from their own format 15:51 < spudowiar> e.g. TREZOR uses Protocol Buffers 15:52 < luke-jr> spudowiar: i was thinking more of using JSON-RPC over stdio 15:52 < spudowiar> That's an interesting idea 15:53 < spudowiar> Because a hardware wallet could ask for transactions when it needs them, etc. 15:54 < spudowiar> Anyway, should I be adding more uses of boost? Was thinking of using boost::process 15:54 < spudowiar> In my PoC I used popen and pclose but that's not very C++-esque 15:56 < gmaxwell> it just seems like a total waste of time and effort to define a whole new seralization which has to be completely compatible and able to encode everything a transaction can encode. 15:56 < gmaxwell> Whats the purpose? 15:56 < luke-jr> gmaxwell: HW wallet vendor provides a plugin for Core 15:56 < spudowiar> But then each script has to deserialize the transaction which seems like a total waste of time ;) 15:59 < gmaxwell> spudowiar: that isn't escape by using a _different_ seralization. 16:00 < spudowiar> Python, for example, has built-in JSON support 16:02 < spudowiar> JSON-RPC over stdio seems like a neat idea though 16:06 < spudowiar> gmaxwell: What about using the format for decoderawtransaction (possibly with a bit more metadata, if needed) 16:07 < sipa> whatever you do, please don't try to represent multisig as multiple addresses :) 16:11 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/329fc1dce7a1...098b01dc58ff 16:11 < bitcoin-git> bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings 16:11 < bitcoin-git> bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings... 16:11 < bitcoin-git> [bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500 16:11 -!- Guest80280 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 245 seconds] 16:11 -!- tiagotrs [~tiago@p5DC47106.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 16:11 < luke-jr> hm, 0.14.2 seems to have missed some fixes still :x 16:12 < gmaxwell> spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints. 16:13 < luke-jr> gmaxwell: the other end would translate the JSON into some hardware interface; the hardware wallet itself does the serialisation 16:13 < luke-jr> ie, there's a middle-man who has no need to understand ser/des 16:14 < spudowiar> ^^ 16:15 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:16 < aj> gmaxwell: (post-segwit you don't want the serialised input tx, you just want the txid, value and some signing key id, no?) 16:17 < sipa> yes 16:17 < luke-jr> spudowiar: note that using JSON-RPC means bitcoind will call signrawtransaction, and you'll have to deserialise (or pass as-is?) 16:18 < spudowiar> What do you mean? I was thinking of sending the current transaction then the hardware wallet could ask for input transactions (and the script would use JSON RPC to grab them) 16:20 < gmaxwell> aj: not for the inputs, but you still want the whole transaction itself. 16:20 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:21 < gmaxwell> aj: I think it would be fairly hard and at least wasteful to define a whole new serialization that is a guarenteed superset of the transaction format. I think spudowiar is thinking that you can just say {pay inputs x,y,z to destination a,b,c} but that doesn't work if the hw wallet isn't the author of the whole transaction. 16:22 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Client Quit] 16:23 < spudowiar> gmaxwell: that is literally what all hardware wallets do right now 16:23 < spudowiar> Even for multisig, they don't accept a serialized transaction 16:24 < arubi> (this is why I was requesting raw sighash support :) ) 16:24 < aj> gmaxwell: yeah, i think i agree; i think you just want to send the serialised partially-filled out tx you want to create/sign, and extra info needed to do the signature (txids, tx values, pre-segwit-serialised-input-txes, SIGHASH params, etc)? 16:24 < gmaxwell> spudowiar: that isn't true; ledger takes seralized transactions. 16:24 < gmaxwell> aj: yes, thats my thinking. 16:24 < spudowiar> Oh, does it? I didn't know 16:26 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 16:41 < bitcoin-git> [bitcoin] sipa opened pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514 16:42 < spudowiar> I wonder if it's a good to switch from Google's Protocol Buffers implementation to nanopb 16:42 < spudowiar> Google's Protocol Buffers code generator generates an utter mess 16:42 < spudowiar> But nanopb generates some nice code (it's used in TREZOR) 16:43 < spudowiar> s/a good/a good idea/ 16:46 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 16:53 -!- tiagotrs [~tiago@p5DC47106.dip0.t-ipconnect.de] has quit [Quit: leaving] 16:55 -!- spudowiar [~android@unaffiliated/saleemrashid] has quit [Remote host closed the connection] 17:05 < luke-jr> spudI think you'll get arguments for using pb at all 17:15 -!- elkalamar [~elkalamar@140.188.133.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 17:22 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 17:33 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 17:45 -!- nemgun1 [~nemgun@105.101.30.158] has quit [Quit: Leaving] 18:03 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ckwnnylkknbfwuxe] has quit [Quit: Connection closed for inactivity] 18:11 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has joined #bitcoin-core-dev 18:23 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 18:39 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 19:24 < cfields> wumpus: considering there's already an 0.14.1rc1, I'd prefer not to sign the binaries with incorrect version 19:24 < cfields> i'd say just go ahead with release without signature 19:26 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 255 seconds] 19:30 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:43 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .] 19:47 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 19:47 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 19:47 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection] 20:09 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 20:10 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 20:14 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 20:51 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 21:16 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 21:24 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 21:27 -!- Squidicc [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 21:29 -!- Squidicuz [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 21:40 -!- Squidicuz [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 21:41 -!- Squidicc [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 21:50 < bitcoin-git> [bitcoin] jimmysong opened pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515 21:51 -!- goatturner [~Beatrootg@2.126.80.59] has quit [Ping timeout: 268 seconds] 21:52 < achow101> does anyone know if the waitforblock/waitfornewblock RPCs are used or will be used sometime in the future? 21:52 < achow101> The PR that adds them says that they are for testing and travis, but I don't see anything which actually uses those commands. 21:52 < achow101> cfields: ^^^ (you're the one who added them) 21:55 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 21:55 -!- cryptapus is now known as cryptapus_afk 22:04 -!- Guest80280 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 22:06 < bitcoin-git> [bitcoin] luke-jr opened pull request #10516: Backports for 0.14.2 (0.14...0.14.2_fixes) https://github.com/bitcoin/bitcoin/pull/10516 22:09 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 22:16 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 22:16 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 22:16 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 22:36 -!- Yogaqueef [~textual@dsl-hkibrasgw3-58c3d4-235.dhcp.inet.fi] has joined #bitcoin-core-dev 22:37 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:d1fb:397:85af:aa47] has joined #bitcoin-core-dev 22:47 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 272 seconds] 22:51 -!- sahl [67104611@gateway/web/freenode/ip.103.16.70.17] has joined #bitcoin-core-dev 22:52 -!- sahl [67104611@gateway/web/freenode/ip.103.16.70.17] has quit [Client Quit] 22:57 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 23:00 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:571:6ccc:8eb2:4cfa] has joined #bitcoin-core-dev 23:01 -!- Guest80280 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 255 seconds] 23:06 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:d1fb:397:85af:aa47] has quit [Ping timeout: 260 seconds] --- Log closed Fri Jun 02 23:09:02 2017 --- Log opened Fri Jun 02 23:09:14 2017 23:09 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 23:09 -!- Irssi: #bitcoin-core-dev: Total of 190 nicks [0 ops, 0 halfops, 0 voices, 190 normal] 23:10 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 255 seconds] 23:12 -!- zeusa1mighty [~zeusalmig@ip98-163-21-107.rn.hr.cox.net] has joined #bitcoin-core-dev 23:13 -!- zeusalmighty [~zeusalmig@ip98-163-21-107.rn.hr.cox.net] has quit [Ping timeout: 255 seconds] 23:15 -!- grubles [~grubles@45.76.177.92] has joined #bitcoin-core-dev 23:15 -!- grubles [~grubles@45.76.177.92] has quit [Changing host] 23:15 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 23:19 -!- Irssi: Join to #bitcoin-core-dev was synced in 643 secs 23:22 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 245 seconds] 23:28 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 23:30 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:7135:9940:3358:5e4c] has joined #bitcoin-core-dev 23:33 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:6c36:f949:a917:973a] has joined #bitcoin-core-dev 23:33 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:571:6ccc:8eb2:4cfa] has quit [Ping timeout: 260 seconds] 23:37 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:7135:9940:3358:5e4c] has quit [Ping timeout: 255 seconds]