--- Day changed Sat Jun 17 2017 00:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:14 -!- arthcp [~arthcp@49.205.124.189] has joined #bitcoin-core-dev 00:15 < jonasschnelli> luke-jr: the source for DigitalBitbox is my wiki diff. 00:16 < jonasschnelli> :-) 00:21 < luke-jr> jonasschnelli: I noticed another company did a simple PGP signed message on a pastebin ;) 01:02 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 01:04 < jonasschnelli> luke-jr: good idea. Though my bitcoin.it account looks authentic and it's public available that I am a co-founder of DigitalBitbox... though a tweet or pgp signed pastebin is a good idea.. will do 01:09 < luke-jr> jonasschnelli: yes, but having to inspect history is a pain 01:09 < jonasschnelli> Yeah 01:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:11 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-flavcejhaqglmovr] has joined #bitcoin-core-dev 02:11 -!- arthcp [~arthcp@49.205.124.189] has quit [Read error: Connection reset by peer] 02:14 -!- goofie_ [~goofie@104-7-174-119.lightspeed.hstntx.sbcglobal.net] has joined #bitcoin-core-dev 02:19 -!- arthcp [~arthcp@49.205.124.189] has joined #bitcoin-core-dev 02:58 -!- arthcp [~arthcp@49.205.124.189] has quit [Ping timeout: 240 seconds] 03:15 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:19 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 03:21 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:22 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 03:33 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 03:44 -!- unholymachine [~quassel@2601:8c:c003:9f16:402e:f0a5:4f68:2826] has joined #bitcoin-core-dev 04:01 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 04:02 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 04:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 04:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 04:23 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 04:28 < bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10619: Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (master...fix01) https://github.com/bitcoin/bitcoin/pull/10619 04:37 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 04:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 05:29 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 05:42 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 05:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 06:30 -!- sbp [~sbp@tea.infomesh.net] has left #bitcoin-core-dev [] 06:56 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:22 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 07:34 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 08:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 08:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 08:16 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 255 seconds] 08:21 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:35 -!- helo [~helo@unaffiliated/helo] has quit [Ping timeout: 240 seconds] 08:37 -!- helo [~helo@unaffiliated/helo] has joined #bitcoin-core-dev 09:00 < instagibbs> what is vchDefaultKey for? 09:02 < instagibbs> checking if the wallet is fFirstRun only? 09:06 < sipa> it used to mean much more 09:06 < sipa> but now i guess that's pretty much it 09:06 < instagibbs> we're burning m/0'/0'/0', which makes naive importing of hd wallets impossible if the first address is used 09:07 < instagibbs> work around is obviously to manually import first address 09:07 < instagibbs> (looking at #9728) 09:07 < gribble> https://github.com/bitcoin/bitcoin/issues/9728 | Can create Watch Only HD wallet with -hdwatchonly by NicolasDorier · Pull Request #9728 · bitcoin/bitcoin · GitHub 09:08 < instagibbs> Can we just fill it with some valid constant key instead, for backwards compatibility? 09:17 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 258 seconds] 09:19 < instagibbs> oh I'm mistaken, it's silently used and added to the wallet. I think that's slightly surprising. 09:22 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 09:26 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 09:28 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 09:45 < jonasschnelli> instagibbs: getting rid of vchDefaultKey would be good... though its currently used to find out if its the wallet first run... 09:45 < instagibbs> jonasschnelli, right, but any valid pubkey works 09:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 09:45 < instagibbs> just have new wallets put in a static pubkey, profit? 09:46 < jonasschnelli> yes. that works 09:47 < instagibbs> k sounds good 09:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 10:39 -!- dermoth_ [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 10:39 -!- dermoth_ is now known as dermoth 10:58 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:7dc5:3fce:924b:f752] has joined #bitcoin-core-dev 10:59 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:7dc5:3fce:924b:f752] has quit [Remote host closed the connection] 10:59 -!- juscamarena_ [~justin@47.148.176.74] has quit [Remote host closed the connection] 10:59 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 10:59 -!- juscamarena is now known as Guest60098 11:07 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 11:10 -!- NewBTCDev [4ca7f92b@gateway/web/freenode/ip.76.167.249.43] has joined #bitcoin-core-dev 11:22 < NewBTCDev> Hello, new dev trying to build on windows. Getting a make error that I don't understand... Could someone please take a peek and point me in the right direction? Thanks. https://pastebin.com/nNHh1B0h 11:35 < jonasschnelli> NewBTCDev: Building on Windows itself is heavy and not supported out-of-the-box (AFAIK)... try cross compile via Linux? 11:35 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md#cross-compilation 11:35 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 11:39 < NewBTCDev> Thanks Jonass, Those are the steps I'm taking. I'm also setting up a linux VM right now.... Will my life be a lot easier building on linux? I'm new to C++ projects 11:40 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 11:44 < jonasschnelli> NewBTCDev: A lot easier (if you ask me) 11:44 < jonasschnelli> Windows cross compile via mingw/depends is supereasy 11:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:48 -!- Netsplit *.net <-> *.split quits: lesderid, BobBarker, sugarpuff, Taek, NicolasDorier, kayamm, ryan-c, gijensen, ibrightly, nanotube, (+1 more, use /NETSPLIT to show all of them) 11:48 -!- Netsplit over, joins: BobBarker 11:49 -!- k4y4mm [~km@pastasuta.pro] has joined #bitcoin-core-dev 11:49 -!- Netsplit over, joins: gijensen 11:49 -!- lesderid [~lesderid@anna.lesderid.net] has joined #bitcoin-core-dev 11:49 -!- Netsplit over, joins: thrasher` 11:49 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-ulrtemsioceuwhlk] has joined #bitcoin-core-dev 11:49 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-jajqdhlresyvlkgg] has joined #bitcoin-core-dev 11:49 -!- Netsplit over, joins: Taek 11:50 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-ganyseewjnasymnf] has joined #bitcoin-core-dev 11:51 -!- Netsplit over, joins: ryan-c 11:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 11:53 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 11:55 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 11:56 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 11:58 -!- NewBTCDev [4ca7f92b@gateway/web/freenode/ip.76.167.249.43] has quit [Ping timeout: 260 seconds] 11:58 < bitcoin-git> [bitcoin] instagibbs opened pull request #10621: Use fixed pubkey during wallet init for default key (master...staticdefault) https://github.com/bitcoin/bitcoin/pull/10621 12:01 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 12:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-flavcejhaqglmovr] has quit [Quit: Connection closed for inactivity] 12:14 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 12:15 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 12:20 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 12:39 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 12:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 12:51 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 12:56 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:01 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 13:04 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 13:19 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 13:22 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 13:26 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 13:32 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 13:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:51 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 268 seconds] 13:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 13:54 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 14:09 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 14:21 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 14:25 -!- gaf_ [~fag@12.smos-linux.org] has quit [Ping timeout: 268 seconds] 14:35 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 14:46 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 14:47 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 15:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1] 15:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 15:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:30 -!- marcoagner [~user@191.249.241.221] has quit [Ping timeout: 240 seconds] 15:35 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rscfhimozlzokvhe] has joined #bitcoin-core-dev 15:36 -!- gaf_ [~fag@12.smos-linux.org] has joined #bitcoin-core-dev 15:41 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 15:42 -!- marcoagner [~user@191.249.242.198] has joined #bitcoin-core-dev 15:48 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 15:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:50 < Lightsword> what’s the function that serializes BIP34 height in core? 15:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 15:58 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 15:59 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 16:01 < sipa> Lightsword: ContextualCheckBlock 16:03 < Lightsword> sipa, that’s only checking it right? I mean the function that does the length prefixed height serialization when mining a block 16:08 -!- gaf_ [~fag@12.smos-linux.org] has quit [Ping timeout: 260 seconds] 16:09 < Lightsword> trying to fix this height length serialization function in pool software https://bitbucket.org/ckolivas/ckpool/src/4718cea30af47963aa55dcc4c452b9b2f9768ff8/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1757:1774 doesn’t work at some lower block numbers it seems 16:21 < sipa> BlockAssembler::CreateNewBlock 16:43 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 16:44 < luke-jr> kallewoof: ping 16:44 < luke-jr> Lightsword: probably it's missing the sign bit 16:44 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 16:45 < luke-jr> Lightsword: the len2/len3 ought to be 32768 and 8388608 16:46 < luke-jr> 0x8000 and 0x800000 16:48 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 16:50 < Lightsword> luke-jr, ah, I recall having trouble with it at block heights even below 10 as well 16:50 -!- phantomcircuit_ is now known as phantomcircuit 16:50 < Lightsword> luke-jr, if it was a sign bit issue wouldn’t it not work at all? 16:51 < phantomcircuit> Lightsword, iirc thre isn't any code in bitcoin to do the actual serialization 16:51 < phantomcircuit> just to check that it's right 16:51 < phantomcircuit> ? 16:51 < phantomcircuit> i could be wrong 16:51 < luke-jr> Lightsword: it would work on and off, but it's not 16:51 < phantomcircuit> wait there has to be 16:51 < luke-jr> phantomcircuit: it checks by serialising and comparing 16:57 < Lightsword> luke-jr, see any other potential issues there? 17:00 < luke-jr> no 17:01 < luke-jr> unless a buffer overflow or smth 17:01 < phantomcircuit> CScript expect = CScript() << nHeight; 17:01 < phantomcircuit> for values less than 10 CScript can encode them using the constant opcodes 17:02 < luke-jr> phantomcircuit: btw, add yourself to https://en.bitcoin.it/wiki/Segwit_support 17:02 < phantomcircuit> 1-75 i guess 17:02 < phantomcircuit> are probably wrong in every pools implementation of this 17:02 < phantomcircuit> er 17:03 < phantomcircuit> 1-17 that is 17:03 < luke-jr> oh, lol 17:03 < phantomcircuit> yeah i doubt anybody has that one right 17:03 < phantomcircuit> i certainly dont 17:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:06 < phantomcircuit> Lightsword, ^ 17:07 < Lightsword> phantomcircuit, oh…yeah I had an issue at around that I recall 17:08 < phantomcircuit> Lightsword, why though? 17:08 < phantomcircuit> nothing new should be using that commitment 17:08 < phantomcircuit> just change it to use the locktime or whatever it is 17:08 < Lightsword> for testnets which immediately enforce BIP34 17:09 < Lightsword> “for values less than 10 CScript can encode them using the constant opcodes” how would that work? 17:11 < sipa> use OP_5 rather than 0x01 0x05 17:11 -!- goofie_ [~goofie@104-7-174-119.lightspeed.hstntx.sbcglobal.net] has quit [Ping timeout: 268 seconds] 17:13 < sipa> Lightsword: is that from the BIP? 17:13 < sipa> that's not implemented in the consensus rules... 17:13 < luke-jr> ? 17:14 < sipa> using OP_n for the height in BIP34 17:14 < sipa> oh, he was quoting phantomcircuit 17:14 < sipa> no, the << operator on CScript always does a data push, never an OP_n 17:16 < Lightsword> so block heights 1-17 are encoded differently? 17:17 < phantomcircuit> sipa, really? 17:18 < phantomcircuit> sipa, push_int64 seems to implement the 1-17 encoding thing 17:20 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 17:21 < phantomcircuit> sipa, yeah no it only does data pushes if it's data you're pushing 17:21 < phantomcircuit> does use constants if it's an integer though 17:23 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 17:25 -!- goofie_ [~goofie@104-7-174-119.lightspeed.hstntx.sbcglobal.net] has joined #bitcoin-core-dev 17:27 < sipa> phantomcircuit: i once tried to "fix" that, and ended up almost created a consensus bug 17:28 < sipa> Lightsword: no, they're all encoded the same 17:30 < Lightsword> sipa, same as each other or same as block 18-127? 17:31 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 255 seconds] 17:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 17:46 < phantomcircuit> sipa, it seems like the push int things have always handled the shorter encodings 17:47 < phantomcircuit> sipa, wait how would fixing that cause a consensus bug 17:49 < luke-jr> phantomcircuit: encoding must be identical for height 17:50 < luke-jr> although I guess BIP34 was never enforced at those heights for mainnet 17:50 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 17:52 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 18:25 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:26 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 18:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 18:37 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 18:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rscfhimozlzokvhe] has quit [Quit: Connection closed for inactivity] 18:49 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 19:30 -!- goatpig [5a5c653a@gateway/web/freenode/ip.90.92.101.58] has quit [Quit: Page closed] 19:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 19:48 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 19:50 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 20:04 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 20:06 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 20:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:13 -!- goofie_ [~goofie@104-7-174-119.lightspeed.hstntx.sbcglobal.net] has quit [Ping timeout: 255 seconds] 20:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 20:27 -!- goofie_ [~goofie@104-7-174-119.lightspeed.hstntx.sbcglobal.net] has joined #bitcoin-core-dev 20:27 < phantomcircuit> sipa, yeah it's exactly what i thought 20:27 < phantomcircuit> height 1-75 are all single byte encodings 20:30 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 20:30 -!- bigboog [~jodie@blk-215-123-241.eastlink.ca] has quit [Quit: WeeChat 1.0.1] 20:32 < sipa> phantomcircuit: sure 20:32 < sipa> single byte lengths 20:32 < sipa> phantomcircuit: but << will never cause an OP_n 20:34 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 20:35 < phantomcircuit> sipa, no it does 20:36 < phantomcircuit> try changing regtest to requite bip34 at height 2 20:36 < phantomcircuit> you'll see 20:39 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 20:40 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 20:40 < Lightsword> so how exactly do you do BIP34 single byte encodings? 20:42 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 20:52 < sipa> Lightsword: it's always the same! 20:53 < sipa> push the number as bytes 20:53 < sipa> heights 0 through 255 or 0x01 + 1 byte 20:53 < sipa> 256 through 65535 are 0x02 + 2 bytes 20:53 < sipa> 65536 through 16777215 are 0x03 + 3 bytes 20:53 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 20:54 < Lightsword> uh, luke said the “len2/len3 ought to be 32768 and 8388608” 20:54 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 20:54 < sipa> oh, right, signed 20:54 < sipa> ignore what is aid 20:54 < sipa> but there is nothing special about low heights 20:56 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 21:04 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 21:17 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 21:24 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 21:25 -!- instagibbs [~instagibb@pool-100-15-117-236.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds] 21:37 -!- instagibbs [~instagibb@pool-72-83-36-237.washdc.fios.verizon.net] has joined #bitcoin-core-dev 21:46 < phantomcircuit> sipa, im quite certain you are wrong there 21:52 < NicolasDorier> I am having issues to build: 21:52 < NicolasDorier> https://www.irccloud.com/pastebin/AMQqyjfy/ 21:53 < NicolasDorier> I tried git clean -dfx and everything I could 21:53 < NicolasDorier> it just explode here 22:01 < NicolasDorier> posted issue on https://github.com/bitcoin/bitcoin/issues/10622 22:09 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 22:13 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 22:14 < sipa> phantomcircuit: look at the code 22:17 < sipa> phantomcircuit: hmm, seems i'm wrong! 22:17 < sipa> wut 22:18 < sipa> very confused about history now 22:37 -!- sipa [~pw@unaffiliated/sipa1024] has quit [Ping timeout: 255 seconds] 22:39 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 22:43 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 22:57 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 23:01 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 23:02 < Lightsword> hmm, so this is a block at height 1 that’s getting “ERROR: AcceptBlock: bad-cb-height, block height mismatch in coinbase (code 16)” any idea what’s wrong with it? https://0bin.net/paste/BzoPFsAofSo1zeSM#KF5e3O9H-+/txOlckwy13c6w0NKRpwek5OKgoToalA/ 23:09 < phantomcircuit> Lightsword, can you just paste the coinbase scriptsig? 23:10 < Lightsword> should be 0101000493164659045433cd380c9916465985184659b22100000a636b706f6f6c162f426974636f696e2d496e6469612f4249503134382f I think 23:15 < phantomcircuit> should be 52 at the front 23:23 < Lightsword> phantomcircuit, hmm, any idea how I would get that using this serialization code? https://0bin.net/paste/AP402Ma-yujCRW8H#WBhmhyL1i5L0BJhLqKjMH39sQdmBMRgapFrXJkp4sD3 23:24 < luke-jr> phantomcircuit: why 52? 23:25 < phantomcircuit> luke-jr, OP_1 is 52 23:25 < phantomcircuit> 0x51 23:25 < phantomcircuit> ok im off by 1 23:25 < luke-jr> Lightsword: if (val < 17) { s[0] = 0x50 + val; return 1; } 23:25 < luke-jr> then your remaining bug is if you were to mine a genesis block, but that'd be dumb 23:28 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 23:31 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 23:31 < Lightsword> luke-jr, yep that worked 23:32 < luke-jr> Lightsword: what are you even doing? <.< 23:32 < Lightsword> screwing around with local testnets 23:33 < phantomcircuit> is that the only place where the encoding rules for CScript is a consensus rule? 23:33 < phantomcircuit> i think it is 23:37 < Lightsword> so how did this abomination happen? :P 23:45 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 23:48 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:4060:35a4:9bee:e997] has joined #bitcoin-core-dev 23:48 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 23:51 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:7dc5:3fce:924b:f752] has quit [Ping timeout: 240 seconds] 23:55 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 23:56 < luke-jr> Lightsword: which part? :P 23:57 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 23:57 < Lightsword> luke-jr CScript encoding rules being consensus critical 23:59 < luke-jr> Lightsword: I don't know that it's a bad thing. 23:59 < luke-jr> BIP 62 was going to do the same