--- Day changed Fri Jul 14 2017 00:24 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7666250ffb4e...db825d293be8 00:24 < bitcoin-git> bitcoin/master d34d77a Cory Fields: build: verify that the assembler can handle crc32 functions... 00:24 < bitcoin-git> bitcoin/master db825d2 Wladimir J. van der Laan: Merge #10806: build: verify that the assembler can handle crc32 functions... 00:25 < bitcoin-git> [bitcoin] laanwj closed pull request #10806: build: verify that the assembler can handle crc32 functions (master...configure-check-asm) https://github.com/bitcoin/bitcoin/pull/10806 00:34 -!- coredump_ [~quassel@vpn-qld171.vpnsolutions.com.au] has quit [Ping timeout: 246 seconds] 00:35 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 268 seconds] 00:38 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 00:43 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 00:43 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 00:44 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:49 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 01:00 < bitcoin-git> [bitcoin] jtimon opened pull request #10822: TOTEST: Also server txo from gettxout (not just utxo and mempool) (master...b15-rpc-txo) https://github.com/bitcoin/bitcoin/pull/10822 01:04 < jonasschnelli> Is there no RPC call (chain) to get a rawtx if I know height and txid? 01:05 < wumpus> jonasschnelli: #10275? 01:05 < gribble> https://github.com/bitcoin/bitcoin/issues/10275 | [rpc] Allow fetching tx directly from specified block in getrawtransaction by kallewoof · Pull Request #10275 · bitcoin/bitcoin · GitHub 01:06 < jonasschnelli> Oh! Nice... I missed that 01:06 < jonasschnelli> I even commented... :/ 01:07 < jonasschnelli> Would allowing a range of blocks (defined by height) make sense as addition? 01:07 < wumpus> not sure... 01:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:08 < wumpus> when does that use case happen? you know a transaction is in a certain block range? 01:09 < jonasschnelli> Use case, I know a txid but don't know if it is confirmed or not... maybe you can say "check the last X blocks for txid Y" 01:09 < jonasschnelli> But yeah.. meh. 01:09 < jonasschnelli> 10275 is really nice 01:13 -!- henrik_ [~Hen@62-243-108-58-static.dk.customer.tdc.net] has joined #bitcoin-core-dev 01:15 -!- henrik_ [~Hen@62-243-108-58-static.dk.customer.tdc.net] has quit [Client Quit] 01:25 < sipa> wumpus: i actually said to gmaxwell earlier today about 01:26 < sipa> wumpus: i actually said to gmaxwell earlier today about 10820 "in about 3 years someone will try to compile with OpenBSD, and notice that it doesn't work... and then we'll add some #ifdefs around it" 01:28 -!- alan_baker [~alan_bake@li1180-203.members.linode.com] has quit [Quit: Textual IRC Client: www.textualapp.com] 01:39 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:39 -!- promag [~joao@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:39 -!- promag [~joao@bl6-24-70.dsl.telepac.pt] has quit [Client Quit] 01:47 < jonasschnelli> I tried to compile Core on a openBSD VM. But I could not even install python3. The package manager idled endless at the point of decompression... 01:52 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 01:53 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 01:56 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 01:58 < wumpus> sipa: hah, no need to wait for that, I compile bitcoin core on openbsd quite a lot 01:58 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 01:58 < wumpus> jonasschnelli: strange 02:04 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 02:07 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:17 -!- treebeardd [~treebeard@70-36-147-41.dsl.static.fusionbroadband.com] has joined #bitcoin-core-dev 02:22 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:23 -!- treebeardd [~treebeard@70-36-147-41.dsl.static.fusionbroadband.com] has quit [Remote host closed the connection] 02:26 -!- promag [~joao@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:26 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 02:26 -!- Guyver2_ is now known as Guyver2 02:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:44 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 03:03 -!- mmgen [~pb@178-175-130-19.ip.as43289.net] has joined #bitcoin-core-dev 03:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 03:05 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:07 < mmgen> signrawtransaction is adding the redeem script but not the witness data to transaction. Can anyone help? 03:07 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:08 < mmgen> (I'm adding segwit support to my wallet) 03:12 < mmgen> And the "signed" transaction with no witness relays OK on testnet and is included in mined block. Strange. 03:14 < mmgen> What am I missing? 03:23 -!- mmgen [~pb@178-175-130-19.ip.as43289.net] has quit [Ping timeout: 255 seconds] 03:30 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has joined #bitcoin-core-dev 03:33 < jonasschnelli> mmgen: can you maken an example and file an issue on github? 03:33 < jonasschnelli> Ideally show your process and in-/output 03:35 < mmgen> I don't think this warrants an issue. I'm clearly doing something wrong. signrawtransaction can sign segwit ps2h TXs if you supply the redeem script and keys, right? 03:36 < mmgen> The sign operation returns OK. TX broadcasts OK. TX is mined. But there's no signature. 03:42 -!- ProfMac [43c671dc@gateway/web/freenode/ip.67.198.113.220] has quit [Ping timeout: 260 seconds] 03:51 -!- promag [~joao@bl6-24-70.dsl.telepac.pt] has quit [Quit: Leaving.] 03:53 < mmgen> jonasschnelli: testnet tx d207ffb90c4ceee2ce242990f69b91f67639f25a7b2be76c13b853a0a376b1b5 03:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dymtqawotmkmcsiq] has joined #bitcoin-core-dev 03:57 < mmgen> jonasschnelli: just mined 03:58 < mmgen> jonasschnelli: but has no signature 04:11 < arubi> mmgen, you're redeeming a p2sh of 0x17 0x160014b7bddbc682c9d41dda1e40c9e5bffcfca385af78 04:12 < arubi> you want to redeem a p2sh of "0x00 0x14 0xb7bddbc682c9d41dda1e40c9e5bffcfca385af78" where the length of that script is 0x16 04:16 < mmgen> arubi: ok 04:16 < mmgen> arubi: thanks, will check it out 04:17 < arubi> np mmgen, at least it looks like it. I don't know what you signed 04:18 < mmgen> arubi: Busy now, I'll get back to you in about 30 min 04:20 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:20 < arubi> ok, anyway the hash160 is of 160014B7BDDBC682C9D41DDA1E40C9E5BFFCFCA385AF78 instead of 0014B7BDDBC682C9D41DDA1E40C9E5BFFCFCA385AF78 04:22 < mmgen> arubi: I just need to remove the leading 0x16 i think 04:23 < mmgen> thought the 0x16 was needed for data push 04:23 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 04:26 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 04:28 < mmgen> arubi: I was creating the redeem script like this: '160014' + hash160(pubhex) 04:32 < mmgen> Strange that signrawtransaction didn't complain though 04:33 < mmgen> despite my malformed script 04:33 < arubi> it's just redeeming a p2sh of a single push of what you hash160'ed 04:34 < arubi> it's not a segwit scriptpubkey, so no sig is needed 04:36 < mmgen> but without the key it wouldn't sign for some reason 04:40 < arubi> try with a different key :) 04:41 < mmgen> arubi: will try. Thanks much for your help 04:53 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.] 04:55 < mmgen> arubi: so any p2sh script consisting of a single data push is redeemable. OP_EQUAL returns True, the stack is empty, so it's valid. 04:55 < mmgen> arubi: wonder if some sort of sanity check should be added to prevent goofups like this? 04:56 < arubi> the stack isn't empty, it has a final 0x01 on it from the TRUE executing 04:56 < mmgen> ok, True's on the stack, so it's valid 04:57 < arubi> er, from the EQUAL 04:57 < mmgen> so now if I spend to that address again, anyone who's seen the script can steal the coins 04:58 < arubi> anyway, we're getting off topic here :) 04:58 < arubi> right 04:59 < mmgen> so maybe the client should reject p2sh scripts consisting of a single data push then? 04:59 < bitcoin-git> [bitcoin] janstary closed pull request #10805: have proper manpages for bitcoin*(1) (master...master) https://github.com/bitcoin/bitcoin/pull/10805 05:00 < arubi> reject how? it can't tell what the script is when you fund the address 05:00 < mmgen> oh, right 05:01 < mmgen> just when you sign, and by then it's too late 05:02 < arubi> note you'd still be pushing a single value for redeeming a p2sh(segwit), the segwit spk itself serialized 05:02 < mmgen> so there's no real point in checking at the signing stage 05:04 < mmgen> arubi: ok 05:33 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds] 05:47 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 05:58 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:4c19:b26a:1b01:2340] has quit [Ping timeout: 246 seconds] 06:06 -!- marcoagn1 [~user@187.113.150.230] has joined #bitcoin-core-dev 06:07 -!- marcoagner [~user@177.99.121.244] has quit [Ping timeout: 248 seconds] 06:09 -!- harrymm [~wayne@118-163-176-125.HINET-IP.hinet.net] has quit [Ping timeout: 260 seconds] 06:22 < cfields> sipa: I believe I know the problem with #10821. Testing a fix. 06:22 < gribble> https://github.com/bitcoin/bitcoin/issues/10821 | Add SSE 4.2 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub 06:25 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:29 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds] 06:32 -!- Squidicc [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again] 06:36 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 240 seconds] 06:42 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 06:45 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:47 < bitcoin-git> [bitcoin] greenaddress opened pull request #10823: Allow all mempool txs to be replaced after a configurable timeout (default 6h) (master...replace-by-fee-old-transactions) https://github.com/bitcoin/bitcoin/pull/10823 06:49 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 06:53 < cfields> sipa: interesting. clang doesn't enable -fomit-frame-pointer at any optim level 06:54 < cfields> adding that in fixes compilation 06:58 < luke-jr> doesn't it break debugging? 06:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 260 seconds] 07:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 07:03 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:05 < bitcoin-git> [bitcoin] promag opened pull request #10824: Avoid unnecessary work in SetNetworkActive (master...2017-07-set-network-active) https://github.com/bitcoin/bitcoin/pull/10824 07:08 < cfields> luke-jr: it's on by default for x86_64 07:08 < cfields> er, for gcc 07:14 < mmgen> arubi: now redeem script is correctly formed, signrawtransaction is including the witness data, but txsend fails with 64: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation) (code -26) 07:17 < mmgen> input in question is output 0 of testnet tx dd2117779039b6abd20529c9c9ce67b4c18c0a0223129759ae01deebaa037151 07:20 < mmgen> wif: cVGLmgcfnq2jvdhNFn9UJQWe6NUCr71GMHePKZC8eXc6fNdJsRuM 07:20 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:4c19:b26a:1b01:2340] has joined #bitcoin-core-dev 07:20 < mmgen> addr: 2N3wYVH1n51ucjnGR2fjcqb6GPeUmDxQH3h 07:25 < arubi> mmgen, then your sig is not valid. it's too off topic here. we can move to #bitcoin-dev if you want 07:27 < mmgen> arubi: agreed, this is offtop, but #bitcoin-dev requires registration doesn't it? 07:28 < arubi> oh I don't know.. 07:29 < mmgen> think it does. How do I go about that? 07:30 < arubi> that's something done through nickserv 07:32 < Chris_Stewart_5> it does 07:32 < Chris_Stewart_5> and I have no idea why it does :/ 07:33 < arubi> yea it's an overkill 07:35 < mmgen> yet #bitcoin-core-dev doesn't 07:35 < mmgen> I'm working on registration now 07:39 < mmgen> sent the request 07:45 < morcos> promag: Your question before about the buggy output. That isn't buggy as far as I can tell. What did you not like? The -1's? 07:45 < promag> nan 07:46 < morcos> oh i think we covered that before and determined it was fine to divide by 0 (it's only for outputing text) and in this case there are no txs in the denominator 07:47 < promag> for reference the output is: Fee Calculation: Fee:4520 Bytes:226 Tgt:6 (requested 6) Reason:"Fallback fee" Decay 0.00000: Estimation: (-1 - -1) -nan% 0.0/(0.0 0 mem 0.0 out) Fail: (-1 - -1) -nan% 0.0/(0.0 0 mem 0.0 out) 07:48 < morcos> yeah so that tells me there were no data points in your fee estimation 07:48 < promag> right, but in the UI it says: "Warning: Fee estimation is currently not possible" 07:49 < morcos> promag: yes exactly.. and the debug log is telling you exactly why it is not possible. no data points. it could have also indicated some smaller number of data points, or enough data points but no fee rate high enough that meets the passing threshold for your target 07:50 < morcos> that debug log output is just for help determining exactly why a particular fee is put on a transaction. 07:51 < morcos> gmaxwell: speaking of which we'd recently discussed making the fallback fee higher than 20 sat/b. I think we discussed 50 or 75. The thinking at the time is 20 is often not high enough to ever get confirmed. 07:51 < morcos> But perhaps we were over influenced by a short period of congestion? 07:51 < promag> ok then morcos, thanks 07:51 < morcos> In any case, I'd still be ok with 50 or 75 as the default for fallback.. I don't think its so unreasonably high that people would complain if they paid that if fee estimation wasn't working 07:52 < morcos> The downside is if fees drop substantially over some period of time, lets say BTC goes up 10x, and then paying 75 sat/B is actually kind of a lot. I suppose it's a no win situation for getting the right number here. 07:53 < morcos> Maybe the answer is to not touch the default but give advice in release notes about setting that number appropriately? 07:56 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 07:57 -!- mmoya [sid208131@gateway/web/irccloud.com/x-wsnkyicowglrfhal] has joined #bitcoin-core-dev 07:58 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 07:58 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 07:59 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 08:08 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] fametrano opened pull request #10825: Net set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 (master...fametrano-regtestport) https://github.com/bitcoin/bitcoin/pull/10825 08:21 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 08:23 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 248 seconds] 08:25 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 08:25 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 08:34 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 08:39 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 240 seconds] 08:40 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 248 seconds] 08:46 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 08:46 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds] 08:47 -!- To7 [~theo@2604:2000:1382:b7:f090:fb65:368b:565] has joined #bitcoin-core-dev 08:49 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:4c19:b26a:1b01:2340] has quit [Ping timeout: 246 seconds] 08:52 < To7> Core dev, time to protect Bitcoin differently. 08:52 < To7> I need help spreading the word on this: https://medium.com/bitcoinfoundation/the-foul-smell-of-federal-cryptocurrency-legislation-bd0a58995b60 08:52 < To7> Instructions are here: https://www.reddit.com/r/Bitcoin/comments/6n9lah/anyone_knows_how_to_get_hold_of_the_other_cryptos 08:54 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:57 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 09:11 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.] 09:11 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:12 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 09:12 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds] 09:14 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has left #bitcoin-core-dev [] 09:16 -!- treebeardd [~treebeard@70-36-147-41.dsl.static.fusionbroadband.com] has joined #bitcoin-core-dev 09:24 < instagibbs> is there reasoning for sendrawtransaction bypassing free relay limit? 09:26 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has left #bitcoin-core-dev [] 09:43 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:4c19:b26a:1b01:2340] has joined #bitcoin-core-dev 09:46 -!- riemann [~riemann@ip-222-88.ists.pl] has joined #bitcoin-core-dev 09:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 09:50 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 09:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:02 -!- treebeardd [~treebeard@70-36-147-41.dsl.static.fusionbroadband.com] has quit [Remote host closed the connection] 10:34 < instagibbs> oh im hallucinating, it doesn't 10:34 -!- riemann [~riemann@ip-222-88.ists.pl] has quit [Ping timeout: 240 seconds] 10:36 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds] 10:37 < instagibbs> (anymore) 10:38 < sipa> cfields: adding -fomit-frame-pointer sounds like it may in general improve performance then... 10:39 < cfields> sipa: I'm not sure if clang/ld64 add necessary debug sections, though 10:40 < bitcoin-git> [bitcoin] Thecave3 opened pull request #10827: fixed grammar error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10827 10:41 < BlueMatt> who uses listsinceblock? 10:41 < BlueMatt> anyone? 10:41 < cfields> sipa: i'll experiment 10:42 < instagibbs> BlueMatt, there exists users... why 10:42 < BlueMatt> without looking at the code (just the docs), can folks tell me what they think the "target_confirmations" parameter means in listsinceblock? 10:42 < BlueMatt> "2. target_confirmations: (numeric, optional) The confirmations required, must be 1 or more\n" 10:42 < BlueMatt> https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcwallet.cpp#L1734 10:44 < Murch> Is anyone aware of best case practices regarding path derivation of segwit addresses? 10:44 < instagibbs> BlueMatt, https://github.com/bitcoin/bitcoin/pull/10655 10:44 < Murch> We currently have two paths for receive and change addresses, and we're considering to adding another two paths for segwit receive and change addresses. 10:44 < instagibbs> Murch, there are none right now AFAIK. BIP49 I think is the only proposed one for Mycelium or something 10:44 < BlueMatt> instagibbs: ahh, ok, that still leaves me wondering what in the fuck the purpose of that argument is 10:45 < Murch> instagibbs: Thanks, I'll take a look. 10:45 < instagibbs> Murch, I'd suggest asking various wallet authors, don't think there's consensus on that at all 10:46 < Murch> What would be a good way to reach them? Would that perhaps be worth a mail to the bitcoin-dev list? 10:46 < BlueMatt> instagibbs: care to ack that? I find that astoundingly poor docs, should fix for 15 if possible 10:47 < instagibbs> BlueMatt, asking the author, I have actually no clue 10:47 < BlueMatt> the docs on 10655 make it a bit more clear, ie if you care about when things hit 6 confs, you calling listsinceblock with old blocks each time so that you keep getting reminded of things with 6 confs 10:47 < BlueMatt> and then you filter for txn with 6 confs yourself 10:48 -!- treebeardd [~treebeard@70-36-147-41.dsl.static.fusionbroadband.com] has joined #bitcoin-core-dev 10:48 < BlueMatt> still seems a super strange api to me, but i can see why it would be useful 10:48 < instagibbs> Murch, yeah I think so. Also bug bigger players individually maybe 10:48 < Murch> instagibbs: Thanks for the consult. ;) 10:50 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:52 -!- nakaluna [~nakaluna@gateway/vpn/privateinternetaccess/nakaluna] has joined #bitcoin-core-dev 10:57 -!- treebeardd [~treebeard@70-36-147-41.dsl.static.fusionbroadband.com] has quit [Quit: Leaving...] 11:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 11:03 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:03 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:04 < cfields> sipa: heh, not a good sign: Assertion failed: (consensus.hashGenesisBlock == uint256S("0x000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943")), 11:05 < cfields> makes for a good backtrace example, though: https://pastebin.com/raw/kA3bavgA 11:05 < sipa> cfields: bah, i could make it manually save and restore the frame.pointer during the duration of the asm blocm 11:05 < cfields> sipa: that's with 10821 and -fomit-frame-pointer 11:06 < cfields> no clue if that's the cause of the failure, or something else busted 11:19 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:19 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:28 -!- ivan [~ivan@unaffiliated/ivan/x-000001] has joined #bitcoin-core-dev 11:46 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 11:49 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 11:55 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:55 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/db825d293be8...66270a416edb 11:55 < bitcoin-git> bitcoin/master 18bacec Alex Morcos: Make check to distinguish between orphan txs and old txs more efficient.... 11:55 < bitcoin-git> bitcoin/master 66270a4 Pieter Wuille: Merge #10557: Make check to distinguish between orphan txs and old txs more efficient.... 11:55 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds] 11:55 < bitcoin-git> [bitcoin] sipa closed pull request #10557: Make check to distinguish between orphan txs and old txs more efficient. (master...dontcheckoutputs) https://github.com/bitcoin/bitcoin/pull/10557 11:57 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 11:59 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 11:59 -!- Guyver2_ is now known as Guyver2 11:59 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds] 12:00 -!- marcoagn1 [~user@187.113.150.230] has quit [Quit: WeeChat 1.0.1] 12:00 -!- marcoagner [~user@187.113.150.230] has joined #bitcoin-core-dev 12:01 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 12:03 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 12:03 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 12:03 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 12:05 -!- harrymm [~wayne@60-249-12-114.HINET-IP.hinet.net] has joined #bitcoin-core-dev 12:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 12:05 < bitcoin-git> [bitcoin] Thecave3 closed pull request #10827: fixed grammar error (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10827 12:09 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds] 12:13 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 260 seconds] 12:16 -!- getsko [25e55525@gateway/web/freenode/ip.37.229.85.37] has joined #bitcoin-core-dev 12:18 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 12:19 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 12:20 < jonasschnelli> hmm.. we should add bench to the gitian build/exported binaries 12:24 -!- getsko [25e55525@gateway/web/freenode/ip.37.229.85.37] has quit [Quit: Page closed] 12:32 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 12:34 < sipa> cfields: could you send me a disassembled version of that function? 12:36 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 246 seconds] 12:36 -!- Gabo_ [~Gabo@84.78.21.97] has joined #bitcoin-core-dev 12:39 -!- Gabo_ [~Gabo@84.78.21.97] has quit [Remote host closed the connection] 12:42 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 12:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 12:50 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 248 seconds] 12:55 < cfields> sipa: sure, give me just a few min 12:55 < cfields> i managed to get it working when built from yasm 12:57 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 12:59 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10829: Simple, backwards compatible RPC multiwallet support. (master...pr/multiparam) https://github.com/bitcoin/bitcoin/pull/10829 13:00 < sipa> cfields: the code here was an attempt to actually translate it to extended asm, where the compiler still manages the stack and register allocation 13:01 < sipa> cfields: i can go for the more straightforward way of just making it produce literally the same bytecode as yasm, where the asm is responsible for saving/restoring registers etc 13:01 < cfields> sipa: understood, i just wanted to get a working asm dump to compare to 13:05 < cfields> heh, no clue what all this padding is about 13:07 -!- lilmarco [~Adium@199.19.94.16] has joined #bitcoin-core-dev 13:07 < cfields> sipa: https://pastebin.com/raw/G4nHr9F5 13:08 < cfields> i snipped the padding 13:10 < cfields> for comparison, yasm's output: https://pastebin.com/raw/Sk3BfXyW 13:11 < cfields> note that I had to -DLINUX with yasm, otherwise I'd get the same crash 13:12 < BlueMatt> sipa: can you mark 10807 as 0.15 (or merge it) since easy bugfix 13:14 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 13:28 -!- nakaluna [~nakaluna@gateway/vpn/privateinternetaccess/nakaluna] has quit [Ping timeout: 240 seconds] 13:29 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 260 seconds] 13:30 < bitcoin-git> [bitcoin] jnewbery opened pull request #10830: [WIP] [wallet] keypool restore (master...pr10240) https://github.com/bitcoin/bitcoin/pull/10830 13:32 < jnewbery> #10830 is #10240 rebased on master. Please mark it as high priority & 0.15 13:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub 13:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10240 | Add HD wallet auto-restore functionality by jonasschnelli · Pull Request #10240 · bitcoin/bitcoin · GitHub 13:32 < cfields> sipa: may also be helpful to know that the resulting hash is: 19cde05babd9831f8c68059b7f520e513af54fa572f36e3c85ae67bb67e6096a 13:32 < cfields> (initial sha2 state) 13:41 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:45 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 13:47 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 13:51 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 260 seconds] 13:57 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:01 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 14:01 -!- nakaluna [~nakaluna@gateway/vpn/privateinternetaccess/nakaluna] has joined #bitcoin-core-dev 14:07 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:14 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 14:14 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:20 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:23 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10240: Add HD wallet auto-restore functionality (master...2017/04/hd_rescan) https://github.com/bitcoin/bitcoin/pull/10240 14:36 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 14:44 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 14:49 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 14:50 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:54 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:54 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66270a416edb...b7d6623c76e1 14:54 < bitcoin-git> bitcoin/master 4652791 João Barbosa: Fix uninitialized atomic variables 14:54 < bitcoin-git> bitcoin/master b7d6623 Pieter Wuille: Merge #10819: Fix uninitialized atomic variables... 14:55 < bitcoin-git> [bitcoin] sipa closed pull request #10819: Fix uninitialized atomic variables (master...2017-07-fix-unitialized-atomic) https://github.com/bitcoin/bitcoin/pull/10819 14:55 < sipa> cfields: i can make the code use one less register 14:55 < cfields> sipa: i've been trying to figure it out :) 14:56 < cfields> sipa: i think you can shortcut the end address calculation? 14:56 < sipa> cfields: if you look at the yasm source, NUM_BLOCKS and e use the same register 14:56 < sipa> one uses it in 32-bit mode (edx) and one in 64-bit mode (rdx) 14:56 < sipa> which my search/replacing treated as two different things 14:57 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 14:57 < cfields> ah 14:59 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 15:02 -!- Guest38607 [~justin@47.148.176.74] has quit [Ping timeout: 268 seconds] 15:03 < cfields> ok i see, that makes sense. That's the one I was trying to save as well. But so far I'd just managed to piss off the assembler in a bunch of different ways. 15:03 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 15:03 < sipa> cfields: so s/%7/%k2/ 15:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 15:04 < sipa> %k2 means "the same as %2, but in 32-bit mode" 15:04 < sipa> and then more shuffling to get rid of the e variable... 15:04 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 15:05 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 15:05 < cfields> roger 15:07 < cfields> sipa: i'm confused as to why inp_end can't be pre-calculated and passed as an input, skipping %2 altogether? 15:08 < sipa> cfields: we could move that out to the C code, yes 15:09 < sipa> the asm code really uses a begin_ptr and end_ptr 15:09 < sipa> and the first 3 instructions convert the (begin_ptr, num_blocks) to that 15:09 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 15:10 < cfields> sipa: right ok, thanks. no need to do that rather than your approach ofc, but it helps to know that would've worked 15:11 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 15:11 < gmaxwell> sipa was in the process of changing everything to use explicit registers and then he was going to manually save bp on the stack so he could use it and restore it at the end. 15:12 < sipa> this approach now should be faster 15:12 < sipa> as it only saves/restores exactly what is needed 15:14 < cfields> testing now 15:18 < sipa> cfields: thanks! 15:19 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 15:20 -!- nakaluna [~nakaluna@gateway/vpn/privateinternetaccess/nakaluna] has quit [Quit: -] 15:20 < cfields> sipa: builds now, but still produces a busted hash :( 15:21 < sipa> :'( 15:21 < sipa> cfields: with or without -fomit-frame-pointer ? 15:21 < cfields> without now 15:22 < cfields> i'll try without the stack protector 15:23 < cfields> same thing 15:23 < sipa> cfields: i can try force assigning variables to registers, to make the code comparable to the yasm code? 15:23 < sipa> to make sure the same assignment is used 15:24 < cfields> sure 15:24 < cfields> sipa: from what i can see, the input is no longer necessarily 32bit aligned 15:25 < cfields> is that a possible issue? 15:25 < sipa> cfields: oh! 15:25 < sipa> how do you mean? 15:25 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 15:25 < cfields> let me double-check, i might've reversed something in testing 15:29 < cfields> sipa: yea, the ReadBE32 on the chunk guaranteed alignment before, without that, is something else handling it? 15:30 < sipa> cfields: the asm code can deal with unaligned input data 15:31 < cfields> ok 15:32 < sipa> cfields: i think that the xfer array may need stronger alignment than the compiler is giving it 15:34 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 255 seconds] 15:36 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 15:37 < sipa> cfields: care to try again? 15:38 < cfields> sure, i'll take a break from fighting this thing. 15:39 -!- henrik_ [~Hen@62-243-108-58-static.dk.customer.tdc.net] has joined #bitcoin-core-dev 15:40 < cfields> heh, i was trying the same thing, but i pissed it off trying to make it 32bit aligned 15:40 < cfields> no go :( 15:41 < sipa> same error? 15:41 -!- henrik_ [~Hen@62-243-108-58-static.dk.customer.tdc.net] has quit [Client Quit] 15:41 < cfields> yea. you just added the attribute, right? 15:41 < sipa> yes 15:42 < cfields> btw, that can be alignas(16) with c++11 15:45 < cfields> generated asm now: https://pastebin.com/raw/SRe0gzUf 15:46 < cfields> any clue what the huge chunk of padding is? 15:47 < sipa> the nopws? 15:47 < sipa> cfields: can you try changing the movdqa instructions to movdqu ? 15:47 < sipa> (a = aligned, u = unaligned) 15:48 < cfields> yea, 0x91 through 0x10000 15:48 < cfields> ok 15:48 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 15:50 < cfields> nope :( 15:50 < sipa> cfields: my guess is that to the OSX assembler ".align 16" means "align to a 2^16-byte boundary" 15:50 < sipa> instead of "align to 16-byte boundary" 15:50 < cfields> ah 15:54 < sipa> cfields: pushed again, try again pretty please? 15:54 < cfields> heh, sure 15:54 < sipa> added some more alignas'es 15:54 < sipa> i think there are instructions beyond movdqa that require aligned input 15:56 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 15:57 < cfields> still no go 15:57 < cfields> you saw me mention that the result is always the sha2 init values, right? 15:58 < sipa> oh, no 15:58 < cfields> hash is "19cde05babd9831f8c68059b7f520e513af54fa572f36e3c85ae67bb67e6096a" 16:03 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 16:03 < sipa> cfields: you're aware the yasm function takes its parameters in a different order? 16:03 < cfields> yes, i had to reverse them to make it work 16:05 < sipa> grrr 16:05 < sipa> i really don't see how the state can be untouched with your disasm code... unless blocks=0 16:07 -!- juscamarena_ [~justin@47.148.176.74] has quit [Ping timeout: 240 seconds] 16:09 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 16:15 < cfields> i'm stumped too. It gets in there sometimes with blocks=0, but even if I early-return, same result 16:15 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 16:15 < sipa> can you give a latest disasm? 16:16 < sipa> can you step through it with a debugger, to see if it's actually doing anything? 16:16 < sipa> (stepi in gdb will execute 1 instruction) 16:16 < cfields> i've tried to get in with no luck 16:16 < cfields> i can try again 16:17 < cfields> (it's lldb, and i'm not at all familiar with it) 16:23 < sipa> cfields: just some thing i'm noticing from the latest disasm you posted: the stack pointer isn't being updated, but is addressed with negative offsets (which is legal, but different from other platforms) 16:24 < sipa> it also saves and restores the frame pointer, but does not actually use it 16:25 < cfields> sipa: i noticed the negative offsets too. how can that be the case? 16:25 < sipa> cfields: it's legal to use some stack space below the stack pointer (google for red zone) 16:26 < sipa> if you want to set a breakpoint, set it to the loop2 label 16:26 < cfields> interesting 16:26 < sipa> if loop2 is reached, it should always update the context 16:26 < cfields> that's a rabbit hole for a different day though :) 16:26 < sipa> (the updating happens in the addq/movq sequence right before done_loop) 16:27 < sipa> eh, addl/movl 16:27 < sipa> can you just post a latest disasm? :) 16:27 < cfields> haha, 1 sec 16:31 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 16:35 < cfields> sipa: https://pastebin.com/raw/rqNABs3S 16:36 < cfields> uh, I switched to -O0 for better debugging, let me know if you want an -O2 to match the others 16:36 < cfields> i assume it doesn't matter much here 16:36 < cfields> i was just trying to get it un-inlined 16:37 < cfields> (it wasn't anyway. oops) 16:37 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 16:38 < sipa> cfields: my latest code just doesn't compile with clang 4.0 16:38 < sipa> are you sure you're testing the right thing? 16:38 < cfields> i moved the alignas's around 16:38 < cfields> if that's what you mean 16:38 < sipa> ok 16:38 < sipa> yes 16:39 < sipa> trying to reproduce on linux 16:39 < cfields> i tried dumping the dispatcher and hard-coding the call instead 16:39 < cfields> thought there might be some static init race. no help though. 16:40 < sipa> what clang version are you using? 16:40 < cfields> stupid apple... 16:40 < cfields> Apple LLVM version 7.3.0 (clang-703.0.29) 16:41 < cfields> no clue what ^^ is 16:41 < cfields> let me see if a cross build works, then we'll have an upstream clang for data point 16:42 < sipa> works fine with clang-4.0 16:42 < sipa> trying 3.7 now 16:43 < sipa> eh, 3.7 fails on some c++11 stuff 16:43 < cfields> for reference, i'm building with 3.7.1 now for cross 16:43 < cfields> eh? 16:43 < sipa> In file included from ./httpserver.h:10: 16:43 < sipa> /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1370:11: error: no matching constructor for initialization of 'std::tuple, event_base *, evhttp *>' 16:43 < cfields> c++ lib issues? 16:43 < sipa> : _M_bound(std::forward<_Tp>(__f), std::forward<_Up>(__args)...) 16:43 < sipa> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 16:44 < sipa> why is it using gcc-6.3's include dir? 16:44 < cfields> give it -stdlib=libc++ 16:46 < cfields> (you might need LD_LIBRARY_PATH set to run) 16:47 < cfields> ok, cross with 3.7.1 dies the same way 16:49 < sipa> ok, compiling with 3.7.0 16:52 < sipa> /home/pw/git/bitcoin-shasse/src/util.cpp:861: undefined reference to `boost::filesystem::path::imbue(std::__1::locale const&)' 16:53 < cfields> heh, your boost was built against libstdc++ 16:53 < sipa> can i do a depends build on linux with clang? 16:53 < sipa> on/for lnux 16:54 -!- lilmarco [~Adium@199.19.94.16] has quit [Quit: Leaving.] 16:54 < cfields> you can probably just do up a tiny stub app using CSHA256 directly, no? 16:56 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 17:02 < promag> off topic, but I see lots of different conventions for commit messages, branch names and PR titles. should there be such conventions in developer notes for instance? 17:02 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 17:04 < sipa> cfields: works fine here 17:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 17:06 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.] 17:06 < cfields> :( 17:07 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 268 seconds] 17:10 < sipa> cfields: in other news, your compiler is retarded 17:10 < sipa> 0000000000000011 movq %rsi, -0x38(%rbp) 17:10 < sipa> 000000000000001d movq -0x38(%rbp), %rsi 17:12 < cfields> erm, that just moves and moves back? 17:12 < sipa> yes 17:12 < cfields> heh 17:12 < cfields> fulfilling a constraint, maybe? 17:13 < sipa> nope 17:13 < sipa> it could leave everything in the original order even 17:13 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 17:15 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 17:24 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 17:28 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 17:30 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 17:35 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 17:40 < cfields> sipa: weird. based on my dinky little test app, it seems to be working 17:42 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 17:43 < sipa> cfields: eh 17:43 < cfields> sipa: not sure yet. confused. 17:44 < cfields> i wrote a little sha256sum clone that just reads stdin and spits out a hash. matches sha256sum so far. 17:44 < sipa> cfields: does it use the sse code? 17:46 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 17:46 < cfields> Assertion failed: (0), function Transform, file crypto/sha256_sse42.cpp, line 16. 17:46 < cfields> yep. just threw ^^ assert in to verify. 17:50 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b7d6623c76e1...f90603ac6d24 17:50 < bitcoin-git> bitcoin/master 3babbcb Gregory Maxwell: Remove confusing MAX_BLOCK_BASE_SIZE.... 17:50 < bitcoin-git> bitcoin/master f90603a Pieter Wuille: Merge #10618: Remove confusing MAX_BLOCK_BASE_SIZE.... 17:50 < bitcoin-git> [bitcoin] sipa closed pull request #10618: Remove confusing MAX_BLOCK_BASE_SIZE. (master...size_b_gone) https://github.com/bitcoin/bitcoin/pull/10618 17:51 < sipa> BlueMatt: can you fix the typo in the commit title of #10808? 17:51 < gribble> https://github.com/bitcoin/bitcoin/issues/10808 | Avoid some new gcc warnings in 15 by TheBlueMatt · Pull Request #10808 · bitcoin/bitcoin · GitHub 17:52 < BlueMatt> heh, oops 17:52 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 17:52 < BlueMatt> fixed, sipa 17:55 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 17:59 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 18:00 < sipa> cfields: so it seems that the SSE PR compiles fine on travis, but no tests get run... 18:00 < cfields> sipa: right. we'll need to find some other osx sucker 18:02 < sipa> cfields: you're just doing a straightforward clean build of the PR? 18:02 < cfields> sipa: yep 18:02 < cfields> sipa: did a cross build via depends too with the same result 18:02 < sipa> :( 18:06 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 260 seconds] 18:06 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 18:08 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f90603ac6d24...ec8a50b8d786 18:08 < bitcoin-git> bitcoin/master 1016dac Matt Corallo: Fix signed/unsigned comparison warning introduced in c8e29d7ff0. 18:08 < bitcoin-git> bitcoin/master c73b8be Matt Corallo: Explicitly initialize prevector::_union to avoid new warning... 18:08 < bitcoin-git> bitcoin/master ec8a50b Pieter Wuille: Merge #10808: Avoid some new gcc warnings in 15... 18:08 < bitcoin-git> [bitcoin] sipa closed pull request #10808: Avoid some new gcc warnings in 15 (master...2017-07-15-new-warnings) https://github.com/bitcoin/bitcoin/pull/10808 18:18 < bitcoin-git> [bitcoin] gmaxwell opened pull request #10831: Batch flushing operations to the walletdb during top up and increase keypool size. (master...topup_batch_flush) https://github.com/bitcoin/bitcoin/pull/10831 18:20 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 18:22 < sipa> BlueMatt: i am confused by the change in #10235 18:22 < gribble> https://github.com/bitcoin/bitcoin/issues/10235 | Track keypool entries as internal vs external in memory by TheBlueMatt · Pull Request #10235 · bitcoin/bitcoin · GitHub 18:22 < sipa> LogPrintf("keypool added key %d, size=%u (%u internal), internal=%d\n", nEnd, setInternalKeyPool.size() + setExternalKeyPool.size(), setInternalKeyPool.size(), internal); 18:22 < sipa> 2x internal? 18:23 < sipa> oh, one is a bool 18:23 < BlueMatt> oh ffs, ok, i'll fix, sec 18:23 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 18:25 < BlueMatt> fixed 18:35 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 18:36 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 18:43 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 18:45 -!- promag [~AndChat66@83.223.248.3] has joined #bitcoin-core-dev 18:46 < promag> What about a wip tag in GitHub? 18:47 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 18:50 -!- AndChat-663936 [~AndChat66@2001:8a0:fe30:de01:6466:ffc9:eb73:9c8e] has joined #bitcoin-core-dev 18:50 -!- promag [~AndChat66@83.223.248.3] has quit [Read error: Connection reset by peer] 18:52 -!- AndChat-663936 [~AndChat66@2001:8a0:fe30:de01:6466:ffc9:eb73:9c8e] has quit [Read error: No route to host] 18:53 -!- promag [~AndChat66@2001:8a0:fe30:de01:6466:ffc9:eb73:9c8e] has joined #bitcoin-core-dev 18:53 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:53 -!- promag [~AndChat66@2001:8a0:fe30:de01:6466:ffc9:eb73:9c8e] has quit [Read error: Connection reset by peer] 18:54 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 18:54 < BlueMatt> ;;later tell promag problem with github tags is you cant have regular folks adding tags (ie you cant limit tag-edits to people who own the issue/pr) 18:54 < gribble> The operation succeeded. 19:06 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dymtqawotmkmcsiq] has quit [Quit: Connection closed for inactivity] 19:08 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec8a50b8d786...1c011ff43010 19:08 < bitcoin-git> bitcoin/master dd97a52 Alex Morcos: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. 19:08 < bitcoin-git> bitcoin/master 1c011ff Pieter Wuille: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet.... 19:08 < bitcoin-git> [bitcoin] sipa closed pull request #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. (master...multiwallet_parameters) https://github.com/bitcoin/bitcoin/pull/10816 19:10 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 19:11 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 19:13 < gmaxwell> Is there anyone who uses OSX around? #10821 needs testing for sipa. 19:13 < gribble> https://github.com/bitcoin/bitcoin/issues/10821 | [WIP] Add SSE 4.2 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub 19:24 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1c011ff43010...8fdd23a224ba 19:24 < bitcoin-git> bitcoin/master bc1be90 Jonas Schnelli: [Qt] replace fee slider with a Dropdown, extend conf. targets 19:24 < bitcoin-git> bitcoin/master 2aef1f1 Jonas Schnelli: [Qt] migrate old fee slider value to new dropbown... 19:24 < bitcoin-git> bitcoin/master 8fdd23a Pieter Wuille: Merge #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets... 19:25 < bitcoin-git> [bitcoin] sipa closed pull request #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets (master...2017/07/qt_fee_slider) https://github.com/bitcoin/bitcoin/pull/10769 19:26 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 19:37 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood] 19:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 19:38 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 19:54 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has joined #bitcoin-core-dev 19:56 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 19:58 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 20:00 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 240 seconds] 20:25 -!- Guest2_ [~textual@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has joined #bitcoin-core-dev 20:32 -!- Guest2_ is now known as discreteunit 20:36 -!- discreteunit [~textual@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has quit [Quit: Textual IRC Client: www.textualapp.com] 20:37 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has joined #bitcoin-core-dev 20:37 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has quit [Client Quit] 20:37 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has joined #bitcoin-core-dev 20:37 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has joined #bitcoin-core-dev 20:39 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has quit [Client Quit] 20:40 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has joined #bitcoin-core-dev 20:48 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:89f4:6e47:e0f4:6a7] has left #bitcoin-core-dev ["Textual IRC Client: www.textualapp.com"] 20:50 -!- fengling [~fengling@2400:8901::f03c:91ff:fe61:b65c] has quit [Ping timeout: 276 seconds] 21:01 -!- fengling [~fengling@2400:8901::f03c:91ff:fe61:b65c] has joined #bitcoin-core-dev 21:51 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 240 seconds] 22:05 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has joined #bitcoin-core-dev 22:29 -!- shadders [~git@169.118.148.122.sta.dodo.net.au] has quit [Quit: Leaving] 22:49 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 260 seconds] 23:03 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 23:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:04 -!- Giszmo [~leo@ip-115-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 23:10 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 248 seconds] 23:20 < cfields> sipa: still around? I managed to piss clang off on linux 23:20 < cfields> not sure if it's the same issue or if I forced another 23:22 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 23:23 < fanquake> gmaxwell cfields what do you want tested? Merging 10821 now. 23:23 < cfields> fanquake: "./bitcoind" is enough :) 23:24 < cfields> for me it segfaults on the genesis block check 23:26 < fanquake> cfields Indeed Assertion failed: (consensus.hashGenesisBlock etc 23:26 < cfields> fanquake: ok, so i'm not alone. great. also, shit. 23:27 < cfields> fanquake: thanks for testing! 23:28 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 23:29 < fanquake> cfields no worries. Ping me if you want anything looked at. Should be around for the rest of the afternoon. 23:29 < sipa> cfields: how did you make clang piss off in linux? 23:29 < sipa> can you create and a send me a static binary? 23:30 < cfields> sipa: still fiddling with it. I'm having troubles with boost as well. 23:30 < sipa> cfields: let's have a look at it in tokyo 23:30 < sipa> i can try a static register allocation first too, and see if that works 23:31 < sipa> why am i talking here? i'm getting drunk 23:31 < cfields> haha. are you irc'ing at a bar? 23:32 < sipa> yes 23:32 < cfields> sipa: using clang with -fintegrated-as caused a new crash in linux 23:32 < cfields> my assumption is that it uses gnu as on linux, and llvm's as for apple 23:33 < cfields> but i'll come up with something solid and ping you then. forget about assembly for the night :) 23:36 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 23:41 < cfields> heh, confirmed 23:41 < cfields> unfortunately, it crashes gdb too :(