--- Day changed Sat Jul 15 2017 00:15 -!- Giszmo [~leo@ip-115-233.219.201.nextelmovil.cl] has quit [Quit: Leaving.] 01:19 -!- Giszmo [~leo@ip-9-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 01:21 -!- coredump_ [~quassel@101.165.147.38] has joined #bitcoin-core-dev 01:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:49 < bitcoin-git> [bitcoin] laanwj opened pull request #10832: init: Factor out AppInitLockDataDirectory (master...2017_07_appinitlockdatadirectory) https://github.com/bitcoin/bitcoin/pull/10832 01:49 < bitcoin-git> [bitcoin] laanwj closed pull request #10818: init: Keep track of whether data directory locked, don't cleanup if not (master...2017_05_locked_datadir) https://github.com/bitcoin/bitcoin/pull/10818 01:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 01:59 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 02:07 -!- coredump_ [~quassel@101.165.147.38] has quit [Ping timeout: 246 seconds] 02:08 -!- coredump_ [~quassel@101.165.147.38] has joined #bitcoin-core-dev 02:09 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 02:10 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 02:19 -!- Squidicc [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 02:20 -!- Squidicuz [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 02:21 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 02:25 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 02:40 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 02:46 < wumpus> might be some calling convention difference 02:46 < wumpus> or at least platform ABI 02:47 < wumpus> gdb is not very robust against such things (accidental or to step reverse-engineering) gets easily confused if certain registers are not set up as they should 02:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:52 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 02:56 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dgrkmccavucxvgqw] has joined #bitcoin-core-dev 03:00 -!- coredump_ [~quassel@101.165.147.38] has quit [Ping timeout: 260 seconds] 03:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 03:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:19 -!- Ricky2 [~Ricky@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 03:32 < fanquake> what is with this spam 03:53 < fanquake> wumpus Any chance you've tested Boost 1.64.0 on openbsd? 03:57 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:03 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 04:05 -!- Giszmo [~leo@ip-9-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 04:14 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:20 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 04:23 -!- Giszmo [~leo@ip-9-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 04:54 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 04:55 -!- aantonop [~aantonop@61.6.4.30] has joined #bitcoin-core-dev 05:32 < bitcoin-git> [bitcoin] practicalswift opened pull request #10833: Fix typos (master...typos-201707) https://github.com/bitcoin/bitcoin/pull/10833 06:03 -!- Victorsueca is now known as Victorsueca[m] 06:04 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:4c19:b26a:1b01:2340] has quit [Ping timeout: 246 seconds] 06:04 -!- Victorsueca[m] is now known as Victorsueca 06:04 -!- aantonop [~aantonop@61.6.4.30] has quit [Quit: leaving] 06:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 06:21 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:24 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:40 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 06:54 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:59 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 07:04 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:1d1b:964a:7ee2:3f] has joined #bitcoin-core-dev 07:05 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:09 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 07:18 < wumpus> fanquake: only 1.63 07:43 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 08:02 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:08 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 08:09 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 08:09 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has quit [Max SendQ exceeded] 08:09 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 08:18 -!- marcoagner [~user@187.113.150.230] has quit [Ping timeout: 246 seconds] 08:19 -!- marcoagner [~user@187.113.150.230] has joined #bitcoin-core-dev 08:21 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:23 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:23 < morcos> wumpus: I assume you knew if you give multiple named arguments for the same argument it's the last one that matters? 08:23 < morcos> I'm not sure how much of an issue that is, but seems like it could cause problems with wallet 08:26 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 08:27 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:1d1b:964a:7ee2:3f] has quit [Ping timeout: 246 seconds] 08:29 -!- marcoagner [~user@187.113.150.230] has quit [Ping timeout: 240 seconds] 08:32 < jamesob> If I wanted to do some kind of analysis on the UTXO set, is my best bet forking and making use of CCoinsView somehow? is https://github.com/bitcoin/bitcoin/pull/7759 worth resurrecting? 08:36 -!- marcoagner [~user@187.113.150.230] has joined #bitcoin-core-dev 08:37 -!- jamesob_ [~AndChat20@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:38 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 08:41 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 08:46 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 08:50 -!- jamesob [~AndChat20@2607:fb90:4af:9e9:b6a0:433d:f9fd:6719] has joined #bitcoin-core-dev 08:52 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:53 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:54 -!- jamesob_ [~AndChat20@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 08:56 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has joined #bitcoin-core-dev 09:05 -!- jamesob [~AndChat20@2607:fb90:4af:9e9:b6a0:433d:f9fd:6719] has quit [Ping timeout: 246 seconds] 09:06 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds] 09:08 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 09:09 -!- str4d_ [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has joined #bitcoin-core-dev 09:10 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 260 seconds] 09:10 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has quit [Ping timeout: 240 seconds] 09:13 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 09:22 -!- nemgun [~nemgun@105.99.40.146] has joined #bitcoin-core-dev 09:27 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 09:36 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 09:36 -!- roidster is now known as Guest51828 09:37 -!- Guest51828 is now known as roidster 09:46 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:31 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has quit [Ping timeout: 255 seconds] 10:33 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 10:36 -!- nemgun1 [~nemgun@105.101.112.106] has joined #bitcoin-core-dev 10:39 -!- nemgun [~nemgun@105.99.40.146] has quit [Ping timeout: 255 seconds] 10:40 -!- CubicEarth [~cubiceart@c-67-168-4-85.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:48 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dgrkmccavucxvgqw] has quit [Quit: Connection closed for inactivity] 10:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 11:00 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8fdd23a224ba...505955052e60 11:02 < bitcoin-git> bitcoin/master 0189d8e practicalswift: Fix typos 11:02 < bitcoin-git> bitcoin/master 5059550 Pieter Wuille: Merge #10833: Fix typos... 11:02 < bitcoin-git> [bitcoin] sipa closed pull request #10833: Fix typos (master...typos-201707) https://github.com/bitcoin/bitcoin/pull/10833 11:04 -!- Giszmo [~leo@ip-9-233.219.201.nextelmovil.cl] has quit [Ping timeout: 276 seconds] 11:05 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 11:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:08 < bitcoin-git> [bitcoin] practicalswift opened pull request #10834: Remove declaration of unused function: void UpdatedTransaction(const uint256 &) (master...remove-UpdatedTransaction) https://github.com/bitcoin/bitcoin/pull/10834 11:12 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/505955052e60...afd2fca911c4 11:12 < bitcoin-git> bitcoin/master 228987d Gregory Sanders: getbalance example covers at least 6 confirms 11:12 < bitcoin-git> bitcoin/master afd2fca Pieter Wuille: Merge #10807: getbalance example covers at least 6 confirms... 11:13 < bitcoin-git> [bitcoin] sipa closed pull request #10807: getbalance example covers at least 6 confirms (master...getbalexample) https://github.com/bitcoin/bitcoin/pull/10807 11:19 -!- Giszmo [~leo@ip-4-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 11:25 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:44 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 258 seconds] 11:46 -!- CubicEarth [~cubiceart@c-67-168-4-85.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 11:48 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 11:52 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:53 -!- owowo [ovovo@gateway/vpn/mullvad/x-anpelghusyfvwjrl] has joined #bitcoin-core-dev 12:08 < bitcoin-git> [bitcoin] paveljanik opened pull request #10835: Do not shadow a field of 'reverse_range' (master...20170715_Wshadow_reverseiterator) https://github.com/bitcoin/bitcoin/pull/10835 12:12 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Read error: Connection reset by peer] 12:17 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 12:23 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afd2fca911c4...10b22e3141a6 12:23 < bitcoin-git> bitcoin/master 0aadc11 Pieter Wuille: Avoid dereference-of-casted-pointer 12:23 < bitcoin-git> bitcoin/master 10b22e3 Pieter Wuille: Merge #10760: Avoid dereference-of-casted-pointer... 12:23 < bitcoin-git> [bitcoin] sipa closed pull request #10760: Avoid dereference-of-casted-pointer (master...20170707_avoidcastptr) https://github.com/bitcoin/bitcoin/pull/10760 12:31 -!- zzyzx [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 12:33 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has quit [Killed (barjavel.freenode.net (Nickname regained by services))] 12:33 -!- zzyzx is now known as roidster 12:38 < bitcoin-git> [bitcoin] corebob opened pull request #10837: Fix resource leak (master...20170715-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10837 12:57 -!- jtimon [~quassel@102.30.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 13:05 -!- str4d_ [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 268 seconds] 13:06 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 13:27 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/10b22e3141a6...c5904e871479 13:27 < bitcoin-git> bitcoin/master fe4faba John Newbery: [refactor] move SplitHostPort() into utilstrencodings... 13:27 < bitcoin-git> bitcoin/master 5c64324 John Newbery: [utils] allow square brackets for ipv6 addresses in bitcoin-cli... 13:27 < bitcoin-git> bitcoin/master c5904e8 Pieter Wuille: Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets... 13:27 < bitcoin-git> [bitcoin] sipa closed pull request #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets (master...bitcoin_cli_ipv6) https://github.com/bitcoin/bitcoin/pull/10812 13:30 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 13:37 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has quit [Ping timeout: 240 seconds] 13:41 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hckkdydwovpuljqb] has joined #bitcoin-core-dev 13:53 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:54 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 13:56 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 13:57 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 14:00 -!- CubicEarth [~cubiceart@c-67-168-4-85.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5904e871479...5cfdda2503c9 14:02 < bitcoin-git> bitcoin/master 4a3fc35 Matt Corallo: Track keypool entries as internal vs external in memory... 14:02 < bitcoin-git> bitcoin/master 28301b9 Matt Corallo: Meet code style on lines changed in the previous commit 14:02 < bitcoin-git> bitcoin/master d40a72c Matt Corallo: Clarify *(--.end()) iterator semantics in CWallet::TopUpKeyPool 14:02 < bitcoin-git> [bitcoin] sipa closed pull request #10235: Track keypool entries as internal vs external in memory (master...2017-04-wallet-more-keypool-cache) https://github.com/bitcoin/bitcoin/pull/10235 14:08 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 14:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:49 -!- protomar [~protomar@109.232.227.133] has joined #bitcoin-core-dev 15:00 -!- protomar [~protomar@109.232.227.133] has quit [Quit: Leaving] 15:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 15:05 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 15:06 -!- CubicEarth [~cubiceart@c-67-168-4-85.hsd1.wa.comcast.net] has quit [] 15:44 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has quit [Ping timeout: 240 seconds] 15:45 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 15:50 -!- JackH [~laptop@host86-187-161-95.range86-187.btcentralplus.com] has quit [Ping timeout: 240 seconds] 15:56 -!- Giszmo [~leo@ip-4-233.219.201.nextelmovil.cl] has quit [Ping timeout: 260 seconds] 16:01 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 248 seconds] 16:01 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 16:15 -!- Giszmo [~leo@pc-249-180-45-190.cm.vtr.net] has joined #bitcoin-core-dev 16:19 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 255 seconds] 16:19 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:32 < sipa> cfields, fanquake: feel like testing #10821 again? 16:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10821 | [WIP] Add SSE 4.2 optimized SHA256 by sipa · Pull Request #10821 · bitcoin/bitcoin · GitHub 16:33 < sipa> i've added a commit that makes all register choices explicit, but still lets the compiler manage the stack 16:38 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 16:45 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 16:46 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 16:47 < BlueMatt> can we remove getinfo for 0.15? 16:49 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838 16:54 < BlueMatt> uhhh, sipa, are you sure https://github.com/bitcoin/bitcoin/pull/10770#issuecomment-315558931 is specific to that PR? 16:56 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 17:00 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 17:00 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 248 seconds] 17:06 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 17:11 < sipa> BlueMatt: i'm not 17:12 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 17:13 < bitcoin-git> [bitcoin] practicalswift opened pull request #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.). (master...dont-pass-by-reference-for-cheaply-copied-types) https://github.com/bitcoin/bitcoin/pull/10839 17:13 -!- nemgun1 [~nemgun@105.101.112.106] has quit [Read error: Connection reset by peer] 17:21 < fanquake> sipa same issue as before. Assertion failed: (consensus.hashGenesisBlock etc 17:22 < sipa> fanquake: ok, thank you 17:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 17:27 < bitcoin-git> [bitcoin] practicalswift opened pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840 17:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 17:46 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 17:49 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 18:07 -!- AsadSalman [~AsadSalma@39.50.101.72] has joined #bitcoin-core-dev 18:08 < AsadSalman> Hi 18:08 < AsadSalman> I'm working in the bitcoin core, trying to get the amount of a transaction sent into the mempool 18:08 < AsadSalman> I'm logging all entries (working on regtestnet, btw) 18:09 < AsadSalman> http://imgur.com/a/olCNk 18:10 < AsadSalman> I am able to get a value out (as you can see in the screenshot) 18:10 < AsadSalman> but that is a sum of both CTxOut 18:10 < AsadSalman> I only want the amount I spent (which was 10BTC, i.e. 1,000,000,000 satoshi) 18:11 < AsadSalman> I don't know what the other CTxOut that is getting summed in is, and how do I get rid of it in the final sum? 18:11 < sipa> it's change 18:11 < AsadSalman> change? I'm not sure what you mean, could you elaborate? 18:12 < sipa> not here, try bitcoin.stackexchange.com 18:12 < sipa> or #bitcoin 18:12 < AsadSalman> okay! (sorry, I thought this would be an appropriate place to ask about core) 18:13 < sipa> your question is about how bitcoin transactions work 18:27 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:30 -!- Murchone [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:31 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer] 18:35 -!- Murchone [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 18:37 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 18:38 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:39 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds] 18:50 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hckkdydwovpuljqb] has quit [Quit: Connection closed for inactivity] 18:59 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 19:04 -!- sanada [sanada@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 19:07 -!- AsadSalman [~AsadSalma@39.50.101.72] has quit [Remote host closed the connection] 19:08 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:09 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 19:16 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 19:21 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 19:36 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer] 19:37 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:41 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:42 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has joined #bitcoin-core-dev 19:43 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 19:47 < gmaxwell> BlueMatt: on 10831 please review the rebase carefully, I'm sick and wouldn't even have done the rebase today but for merge window urgency. 19:59 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:04 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 20:16 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:19 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 20:31 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 20:46 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1] 20:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:49 -!- blzin2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has joined #bitcoin-core-dev 20:51 -!- handlex [~handlex@2804:14c:658f:4ac1:75eb:b4fe:ce53:5a4f] has joined #bitcoin-core-dev 20:56 -!- blzin2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has quit [Quit: Leaving] 20:58 < cfields> sipa: still crashes :( 20:58 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-jlhztpeehcjzodpx] has quit [Ping timeout: 255 seconds] 20:58 -!- robby938 [sid238281@gateway/web/irccloud.com/x-muonovsjkwywiglx] has quit [Ping timeout: 255 seconds] 20:59 < cfields> sipa: i managed to get lldb to step into the asm, but it doesn't show me where I am when i single-step instructions, only that I'm in the asm block. So i have to step 1 instruction at a time and dump registers 21:00 < cfields> the explicit assignments will help though, since now I'll know where I'm looking 21:01 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-unertslopoepriam] has quit [Quit: X_X] 21:03 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 21:03 < sipa> cfields: so you do reach the asm block? 21:03 < sipa> can you count how many instructions inside you execute? 21:03 < cfields> sipa: yea, and past the zero-size check 21:04 < cfields> sipa: yea, i can do that. the recent changes should make it much easier, i'll poke some more 21:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 21:10 < sipa> cfields: thanks for all the time you're spending on thid 21:11 < cfields> sipa: np. it's a big boost. 21:12 < sipa> cfields: for IBD it seems a 200-300 second reduction to block 450k 21:12 < sipa> at the tip the impact is probably larger, but harder to benchmark 21:14 < cfields> wow 21:14 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 21:14 -!- blznblzn2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has joined #bitcoin-core-dev 21:15 < cfields> net-side will benefit at the tip too, though probably not enough to be relevant 21:15 < cfields> sipa: gcc docs says the value of inputs isn't allowed to change. i suppose values of pointers passed in are ok though? 21:16 < sipa> cfields: the only inputs are constants 21:16 < sipa> everything else is marked as an output 21:16 -!- str4d [~str4d@107-130-248-176.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 248 seconds] 21:17 < cfields> oh right, nm 21:18 < gmaxwell> sha-ni is a bigger boost. 21:18 < sipa> yes, far larger 21:18 < sipa> close to 1000s reduction 21:18 < sipa> more like 800s 21:18 < sipa> (compared to master) 21:19 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-sfzlexmbjqshqnpr] has joined #bitcoin-core-dev 21:20 < gmaxwell> cfields: I expect even just sse4 to make a very measurable improvement in compact block relay... that is mostly bottlenecked on sha2... 21:20 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 21:21 < cfields> whoa 21:22 < cfields> have you benchmarked any benefit to adding a dedicated sha2d? 21:25 < sipa> cfields: can you show another disasm? 21:25 < gmaxwell> haven't though if we want further benefit I think what we really want is a hash tree that hashes multiple things at once, parallel sse4 sha2 is significantly faster than one at a time... and it even looks like for sha-ni for max throughput you want to do at least two at a time. 21:27 < cfields> gmaxwell: yea, i was reading that paper (one of many?) yesterday 21:27 < cfields> sipa: https://pastebin.com/raw/jY0EGwDB 21:27 < cfields> stepping through it now 21:28 < cfields> sipa: note that i haven't hand-modified any flags for that one, so the stack protector is in place where it hasn't been in other dumps 21:29 < sipa> i can see 21:30 < sipa> that 21:32 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 21:34 < sipa> cfields: during the entire execution, the rdi register should contain a pointer to the SHA256 state 21:34 < sipa> and it should never change 21:35 < sipa> there is not a single instruction in your disasm that modifies that register, so far so good 21:36 < sipa> so the question is... is rdi actually pointing to the state? 21:36 < gmaxwell> sipa: you could try taking cfields disasm and monkey patching it into a binary to try to reproduce he failure. 21:36 < sipa> gmaxwell: nontrivial... linking information would be lost 21:36 < cfields> sipa: actually, hold on. linker stuck a bunch of nops in the final binary... 21:37 < cfields> let met give you a dump of that rather than a dump of just the object 21:37 < sipa> cfields: ah, yes! 21:37 < gmaxwell> linker replaced the object with foldgers crystals, turns out we noticed. 21:38 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 21:38 < cfields> uhmm, wtf 21:39 < sipa> the linker replaced the object with foldgers crystals? 21:39 < cfields> ok, i don't trust myself enough here to be a proxy debugger... 21:39 < cfields> sec 21:41 < cfields> I'm just going to send you the whole dasm. Got anywhere convenient for a 58mb text dump? 21:42 < sipa> sure 21:42 < sipa> mail? 21:46 -!- handlex [~handlex@2804:14c:658f:4ac1:75eb:b4fe:ce53:5a4f] has quit [Quit: handlex] 21:47 < midnightmagic> lol 21:49 -!- corebob [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has joined #bitcoin-core-dev 21:55 -!- blznblzn2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has quit [Quit: Leaving] 21:56 -!- blznblzn2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has joined #bitcoin-core-dev 22:06 < sipa> gmaxwell: your foldgers crystals guess is surprisingly accurate 22:09 < cfields> bingo! 22:09 < cfields> got it. 22:10 < sipa> oh? 22:11 < cfields> now to figure out why :) 22:11 < cfields> -Wl,-dead_strip 22:11 < cfields> it's weird that if it's going to strip it, it doesn't strip the whole thing though 22:12 < cfields> (to be clear, we use -Wl,-dead_strip by default. With that removed, it runs as expected) 22:15 < sipa> cfields: give local labels a name that starts with L 22:15 < sipa> that way the linker treats them as local labels rather than separate functions 22:18 < cfields> sipa: works! 22:19 < sipa> http://www.galloway.me.uk/2011/03/assembly-beware-local-label-names-with-dead_strip-option/ 22:19 < sipa> i found thst 22:20 < cfields> hah! well that was some easy googling for once :) 22:24 < cfields> sipa: do you see that documented anywhere? 22:24 < sipa> nope 22:27 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has quit [Quit: ChatZilla 0.9.92 [SeaMonkey 2.40/20160120202951]] 22:28 < bitcoin-git> [bitcoin] jnewbery opened pull request #10841: [rpc] Give users one final warning before depracating getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841 22:30 < cfields> sipa: https://sourceware.org/binutils/docs/as/Symbol-Names.html#Symbol-Names 22:33 < sipa> ah 22:36 < cfields> sipa: maybe safer to use digits instead, then? Reading the docs like a pedant, I assume some future linker could break win32 the same way. 22:40 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:8561:dbbb:7e34:dab8] has joined #bitcoin-core-dev 22:44 < cfields> nope, that's crashy too 23:22 < sipa> cfields: so, latest PR version works? 23:24 < cfields> sipa: i don't think so, i think that matches what i tried 23:24 < sipa> ? 23:24 < cfields> sipa: i misread the docs, look at their example 23:25 < cfields> "So for example, the first 1: may be named .L1C-B1, and the 44th 3: may be named .L3C-B44." 23:25 < sipa> A local symbol is any symbol beginning with certain local label prefixes. By default, the local label prefix is `.L' for ELF systems or `L' for traditional a.out systems, but each target may have its own set of local label prefixes. 23:25 < cfields> apparently the numbers aren't a replacement for the L prefix 23:25 < sipa> you're looking at automatically generated names 23:26 -!- Squidicc [~squid@pool-72-74-34-138.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 23:26 < sipa> we don't need that; the asm syntax's %= guaranrees uniqueness already 23:28 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 23:28 < cfields> sipa: sorry, misread the diff 23:29 < sipa> it won't work, i forgot to rename the jumps 23:29 < cfields> yep, with those renamed, all good 23:29 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 23:39 < phantomcircuit> gmaxwell, btw when i did the walletdb stuff i was doing CWalletDB *pwalletdb=NULL and then initializing pwalletdb only if it was null instead of creating a new function