--- Day changed Wed Jul 26 2017 00:09 -!- Deadhand [~deadhand@CPEf0f249a14e43-CMf0f249a14e40.cpe.net.cable.rogers.com] has quit [Ping timeout: 240 seconds] 00:10 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: Connection reset by peer] 00:11 -!- coredump_ [~quassel@vpn-qld171.vpnsolutions.com.au] has joined #bitcoin-core-dev 00:11 -!- Deadhand [~deadhand@CPEf0f249a14e43-CMf0f249a14e40.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 00:13 < jnewbery> Redone #10882 with stderr capture/checking done within the individual test. Ready for review. (sipa, gmaxwell) 00:13 < gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub 00:14 < jnewbery> MarcoFalke: Not urgent for 0.15, but I'd love some review of #10711 00:14 < gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub 00:19 < sipa> jnewbery: thanks! 00:32 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 00:33 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 00:34 < luke-jr> FWIW, master upgraded my testnet3 UTXO set and then crashed syncing due to LevelDB giving $6 = "Corruption: not an sstable (bad magic number)" 00:34 < luke-jr> leveldb LOG file hasn't changed in a month 00:43 -!- coredump_ [~quassel@vpn-qld171.vpnsolutions.com.au] has quit [Ping timeout: 246 seconds] 00:44 < luke-jr> https://github.com/bitcoin/bitcoin/pull/10457#pullrequestreview-52270582 wumpus: what do you mean? 00:46 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 260 seconds] 00:46 -!- jamesob [~james@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 258 seconds] 00:49 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 00:53 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 255 seconds] 00:57 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 00:57 -!- a_meteor_ [~a_meteori@gateway/vpn/privateinternetaccess/ameteorite/x-60327747] has joined #bitcoin-core-dev 00:59 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:02 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 01:05 < luke-jr> jonasschnelli: btw, I think prune-to might be a good novice contributor thing, so might make sense to let it sit as an issue :p 01:06 < luke-jr> (eg, manual pruning and chainstate obfuscation seemed to work out nicely) 01:21 < wumpus> luke-jr: I mean: bring back the typedef instead of declaring a function type in a function argument 01:22 < wumpus> I dont' understand why the typedef is being removed 01:22 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:25 < wumpus> or am I alone in finding "CDBEnv::VerifyResult CDBEnv::Verify(const std::string& strFile, bool (*recoverFunc)(const std::string& strFile))" terribly hard to read? 01:26 < sipa> no. 01:29 < wumpus> and as for not being sure what the state of that PR is, I read the other discussion and people don't seem to agree wheter it's considered an improvement or not 01:29 < wumpus> in which case it'd be better to close it instead of review it further 01:30 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10931: Fix misleading "Method not found" multiwallet errors (master...pr/multierr) https://github.com/bitcoin/bitcoin/pull/10931 01:33 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:35 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:37 < wumpus> jnewbery: yes, testnode is nice 01:39 * midnightmagic stabs 01:39 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 01:40 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has joined #bitcoin-core-dev 01:41 < midnightmagic> argh, sorry, was behind on scrollback and that had nothing to do with anything current. 01:41 < wumpus> I already wondered who and why you were stabbing :) 01:42 < wumpus> jnewbery: thanks for adding explicit check for stderr, I think this is much cleaner 02:01 < luke-jr> wumpus: ah, got the before/after reversed 02:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:06 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/04d395e8327d...5c003cb1afcb 02:06 < bitcoin-git> bitcoin/master 4a7a4ff Marko Bencun: developer-notes: add reference to snake_case and PascalCase... 02:06 < bitcoin-git> bitcoin/master 5c003cb Wladimir J. van der Laan: Merge #10917: developer-notes: add reference to snake_case and PascalCase... 02:06 < bitcoin-git> [bitcoin] laanwj closed pull request #10917: developer-notes: add reference to snake_case and PascalCase (master...pascalcase) https://github.com/bitcoin/bitcoin/pull/10917 02:07 * luke-jr suggests merging https://github.com/bitcoin/bitcoin/pull/10824 02:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:08 < bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10932: Create models.js (master...patch-5) https://github.com/bitcoin/bitcoin/pull/10932 02:08 < bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10933: Create web3.js (master...patch-4) https://github.com/bitcoin/bitcoin/pull/10933 02:08 < bitcoin-git> [bitcoin] fanquake closed pull request #10933: Create web3.js (master...patch-4) https://github.com/bitcoin/bitcoin/pull/10933 02:09 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 02:09 < bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10934: Create transaction.js (master...patch-6) https://github.com/bitcoin/bitcoin/pull/10934 02:10 < bitcoin-git> [bitcoin] fanquake closed pull request #10934: Create transaction.js (master...patch-6) https://github.com/bitcoin/bitcoin/pull/10934 02:10 < bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10935: Create index.js (master...patch-7) https://github.com/bitcoin/bitcoin/pull/10935 02:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 02:11 < bitcoin-git> [bitcoin] fanquake closed pull request #10935: Create index.js (master...patch-7) https://github.com/bitcoin/bitcoin/pull/10935 02:11 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:11 < wumpus> luke-jr: agree 02:12 < bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10936: Create balance.js (master...patch-8) https://github.com/bitcoin/bitcoin/pull/10936 02:12 < bitcoin-git> [bitcoin] fanquake closed pull request #10936: Create balance.js (master...patch-8) https://github.com/bitcoin/bitcoin/pull/10936 02:12 < bitcoin-git> [bitcoin] laanwj closed pull request #10824: Avoid unnecessary work in SetNetworkActive (master...2017-07-set-network-active) https://github.com/bitcoin/bitcoin/pull/10824 02:13 < fanquake> sipa / wumpus want to block @https://github.com/Cr4shOv3rrid3 02:13 < wumpus> fanquake: good idea 02:13 < bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10937: Create web3.js (master...patch-9) https://github.com/bitcoin/bitcoin/pull/10937 02:13 < sipa> i was about to, if he opens one more 02:13 < sipa> Done. 02:13 < bitcoin-git> [bitcoin] fanquake closed pull request #10937: Create web3.js (master...patch-9) https://github.com/bitcoin/bitcoin/pull/10937 02:13 < wumpus> done at the same time lol 02:14 < fanquake> /race 02:14 < wumpus> oh we blocked a different one actually 02:14 < luke-jr> hopefully it's not a toggle 02:14 < wumpus> Cr4sh0verr1d3 versus Cr4shOv3rrid3 02:14 < sipa> wumpus: you got the right one 02:22 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-xleptcrytlxbyoxz] has quit [Ping timeout: 276 seconds] 02:22 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Ping timeout: 255 seconds] 02:22 -!- str4d [~str4d@nova-153-092-136-128.cpe.nova.is] has joined #bitcoin-core-dev 02:23 -!- Guest75836 [~socrates1@li175-104.members.linode.com] has quit [Ping timeout: 240 seconds] 02:26 -!- Guest71980 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev 02:27 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:43 -!- unholymachine [~quassel@2601:8c:c003:9f16:5524:e1a:7af4:87f0] has quit [Ping timeout: 276 seconds] 02:45 -!- unholymachine [~quassel@c-69-248-123-139.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 02:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Read error: Connection reset by peer] 03:02 -!- aj_ is now known as aj 03:06 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dd6a2be4188...5c8eb7916de7 03:06 < bitcoin-git> bitcoin/master 065039d practicalswift: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp... 03:06 < bitcoin-git> bitcoin/master 5c8eb79 Wladimir J. van der Laan: Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp... 03:07 < bitcoin-git> [bitcoin] laanwj closed pull request #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp (master...arrays-are-not-pointers) https://github.com/bitcoin/bitcoin/pull/10912 03:19 -!- Joseph__ [~NewLibert@2602:306:b8e0:8160:617d:1ca5:fc8c:2fc4] has joined #bitcoin-core-dev 03:19 -!- Joseph__ is now known as NewLiberty 03:22 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:5812:64d:837a:66c3] has quit [Ping timeout: 246 seconds] 03:34 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has quit [Ping timeout: 246 seconds] 03:41 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 03:43 -!- str4d [~str4d@nova-153-092-136-128.cpe.nova.is] has quit [Ping timeout: 276 seconds] 03:43 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:4106:769d:ea02:d400] has joined #bitcoin-core-dev 03:47 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 03:47 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:617d:1ca5:fc8c:2fc4] has quit [Ping timeout: 246 seconds] 04:11 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-eheggqfguhohzmsj] has joined #bitcoin-core-dev 04:20 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 04:21 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 04:24 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has quit [Ping timeout: 255 seconds] 04:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wzjstymtsyoqkyrp] has joined #bitcoin-core-dev 04:32 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 04:42 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:4106:769d:ea02:d400] has quit [Read error: Connection reset by peer] 04:43 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:4106:769d:ea02:d400] has joined #bitcoin-core-dev 04:58 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 268 seconds] 05:01 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 05:03 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 255 seconds] 05:03 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev 05:10 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 248 seconds] 05:17 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 05:19 -!- jeep-ss [~chatzilla@78.31.64.4] has joined #bitcoin-core-dev 05:23 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev 05:27 -!- Magicking_ [~anonymous@unaffiliated/magicking] has left #bitcoin-core-dev ["."] 05:28 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.] 05:29 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 248 seconds] 05:38 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 248 seconds] 05:44 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 05:44 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 05:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 05:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:56 -!- Aaronvan_ is now known as AaronvanW 06:05 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 06:07 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 06:09 -!- J-wolf [~J-wolf@188.225.171.82] has joined #bitcoin-core-dev 06:10 -!- Mac2 [~Mac@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 06:10 -!- Mac2 [~Mac@ns334669.ip-5-196-64.eu] has quit [Read error: Connection reset by peer] 06:11 -!- marcoagner [~user@187.113.157.206] has quit [Ping timeout: 255 seconds] 06:12 -!- J-wolf [~J-wolf@188.225.171.82] has quit [Remote host closed the connection] 06:14 -!- jeep-ss [~chatzilla@78.31.64.4] has quit [Ping timeout: 255 seconds] 06:19 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:24 -!- marcoagner [~user@187.113.148.71] has joined #bitcoin-core-dev 06:26 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:29 -!- Aron [~Aron@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 06:41 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 06:47 -!- Aron [~Aron@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 06:55 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has quit [Ping timeout: 240 seconds] 06:57 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has joined #bitcoin-core-dev 07:02 -!- a_meteor_ [~a_meteori@gateway/vpn/privateinternetaccess/ameteorite/x-60327747] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:05 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 07:05 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 07:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 07:06 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 07:17 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 07:22 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds] 07:23 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 07:30 -!- Susan2 [~Susan@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 07:38 -!- Susan2 [~Susan@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 07:41 -!- JackH [~laptop@host86-187-170-222.range86-187.btcentralplus.com] has quit [Ping timeout: 255 seconds] 07:46 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:49 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 248 seconds] 07:56 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has joined #bitcoin-core-dev 07:58 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 08:00 < BlueMatt> wumpus: I was referring to https://github.com/bitcoin/bitcoin/pull/10619#issuecomment-310257582 08:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 08:01 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev 08:03 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has quit [Ping timeout: 260 seconds] 08:07 -!- Giszmo [~leo@2001:4c50:33e:9700:e195:30cf:b156:742d] has quit [Ping timeout: 246 seconds] 08:08 < gmaxwell> wumpus: I'm glad you commented on the alarmist titles. 08:09 < gmaxwell> wumpus: someone should also point out to practicalswift that these titles will confuse further troubleshooting, e.g. someone encounters a real crash, then sees commits with titles like "avoid null dereference" they may think "oh thats been fixed" and not report it. 08:09 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has joined #bitcoin-core-dev 08:09 < gmaxwell> "Appease static analysis tool by adding an assert in X" is a fine title. 08:14 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has quit [Ping timeout: 248 seconds] 08:18 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 08:22 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:23 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Ping timeout: 260 seconds] 08:23 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has joined #bitcoin-core-dev 08:26 < morcos> If the next PR literally says "X" in the title, you are responsible 08:29 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 08:31 < gmaxwell> hahah 08:32 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 08:33 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 08:57 -!- a_meteorite [~a_meteori@gateway/vpn/privateinternetaccess/ameteorite/x-60327747] has joined #bitcoin-core-dev 09:01 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has quit [Ping timeout: 255 seconds] 09:03 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 09:05 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has joined #bitcoin-core-dev 09:08 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:10 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 09:13 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 09:19 -!- a_meteorite [~a_meteori@gateway/vpn/privateinternetaccess/ameteorite/x-60327747] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:19 -!- jtimon [~quassel@14.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:21 -!- a_meteorite [~a_meteori@gateway/vpn/privateinternetaccess/ameteorite/x-60327747] has joined #bitcoin-core-dev 09:22 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:25 < jtimon> can I build bitcoind but only bitcoind without bitcoin-cli, bitcoin-tx, libbitcoinconsensus.la, test/test_bitcoin_fuzzy, bench/bench_bitcoin and test/test_bitcoin ? 09:26 < gmaxwell> make bitcoind 09:26 < gmaxwell> (or make src/bitcoind ) 09:28 < jtimon> oops, right, I forgot the src/, thanks 09:31 -!- jamesob [~james@tempo-automation.static.monkeybrains.net] has joined #bitcoin-core-dev 10:05 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 10:08 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 10:09 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Client Quit] 10:10 -!- J-wolf [~J-wolf@82.102.252.13] has joined #bitcoin-core-dev 10:17 -!- J-wolf [~J-wolf@82.102.252.13] has quit [Remote host closed the connection] 10:19 -!- snq [~random@185.32.222.18] has joined #bitcoin-core-dev 10:25 -!- a_meteorite [~a_meteori@gateway/vpn/privateinternetaccess/ameteorite/x-60327747] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:31 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has joined #bitcoin-core-dev 10:33 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 10:35 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 240 seconds] 10:37 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has quit [Ping timeout: 255 seconds] 10:39 -!- J-wolf [~J-wolf@82.102.252.13] has joined #bitcoin-core-dev 10:40 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has joined #bitcoin-core-dev 10:43 < bitcoin-git> [bitcoin] laanwj reopened pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301 10:44 -!- J-wolf [~J-wolf@82.102.252.13] has quit [Remote host closed the connection] 10:46 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has quit [Ping timeout: 260 seconds] 10:49 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:4106:769d:ea02:d400] has quit [Ping timeout: 276 seconds] 10:50 -!- J-wolf [~J-wolf@82.102.252.13] has joined #bitcoin-core-dev 10:57 -!- J-wolf [~J-wolf@82.102.252.13] has quit [Remote host closed the connection] 10:58 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:59 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has joined #bitcoin-core-dev 11:02 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 11:04 -!- JackH [~laptop@host-80-43-142-175.as13285.net] has quit [Ping timeout: 240 seconds] 11:04 -!- JackH [~laptop@host-80-43-140-108.as13285.net] has joined #bitcoin-core-dev 11:08 -!- JackH_ [~laptop@host-80-43-140-111.as13285.net] has joined #bitcoin-core-dev 11:09 -!- JackH [~laptop@host-80-43-140-108.as13285.net] has quit [Ping timeout: 240 seconds] 11:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 11:14 -!- elias19r [~elias19r@179.234.188.139] has joined #bitcoin-core-dev 11:16 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:18 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 276 seconds] 11:19 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:25 -!- NewLiberty [~NewLibert@47.51.53.34] has joined #bitcoin-core-dev 11:34 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.] 11:45 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Quit: moctos_] 12:01 -!- NewLiberty_ [~NewLibert@47.51.53.34] has joined #bitcoin-core-dev 12:04 -!- NewLiberty [~NewLibert@47.51.53.34] has quit [Ping timeout: 248 seconds] 12:17 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:18 < gmaxwell> Interesting observation from the now-public infomation about the mtgox thefts. Non-HD walletness of MTGOX partially protected it from losses. 12:20 < gmaxwell> They had a wallet.dat stolen in 2011... and the theif was limited to steal coins that landed on the addresses in it and the 100 after it. 12:21 < morcos> Did you mean to say not having a bag of 10,000 keys protected them from losses 12:21 * morcos runs for cover 12:22 < gmaxwell> morcos: Yes. (though the keypool size is irrelevant for this now, because they're all determinstically derrived now) 12:22 < gmaxwell> Not using HD protected them, though -- it's pretty remarkable how little it protected them. 12:22 < achow101> gmaxwell: where is this info? 12:22 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 268 seconds] 12:23 -!- jtimon [~quassel@14.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 12:23 < gmaxwell> http://blog.wizsec.jp/2017/07/breaking-open-mtgox-1.html 12:24 < kakobrekla> hd was not a thing back then 12:24 < kakobrekla> maybe wallets werent even encrypted 12:25 < kakobrekla> i forgot when that came to be. 12:25 < gmaxwell> ... 12:27 < eck> wallet.dat file was stolen sept 2011, the same month encryption was added to bitcoin core (0.4.0 released sep 23, 2011) 12:29 < grubles> https://bitcoin.org/en/release/v0.4.0 12:29 < gmaxwell> kakobrekla: you've missed my point. 12:29 < kakobrekla> i miss all the points :( 12:31 < grubles> the point was they only had access to the keys generated in that copy of the wallet.dat, and none generated afterwards 12:31 -!- Joseph__ [~NewLibert@47.51.53.34] has joined #bitcoin-core-dev 12:32 < kakobrekla> aha, if only the keypool size would be smaller... 12:33 < gmaxwell> kakobrekla: it no longer has anything to do with the keypool. Use of hdwallets means that there is no more leakage resistance. 12:33 < kakobrekla> sure 12:33 < gmaxwell> There has been a long discussion since 2011 if the 'unstealing' property is meaningfully protective or not. There have been some other examples where leakage resistance was useful, but this would be the largest yet. 12:34 < kakobrekla> so you stance on this is that hd wallets are bad for your health? 12:34 < kakobrekla> your* 12:34 < gmaxwell> No, but there is a tradeoff. 12:34 < kakobrekla> aha 12:34 < gmaxwell> also, I introduced these things fwiw. 12:34 -!- NewLiberty_ [~NewLibert@47.51.53.34] has quit [Ping timeout: 240 seconds] 12:35 < gmaxwell> personally I think the ideal functionality would be to rotate HD master keys on a timed basis, e.g. once a year, and only switch to a new one after a backup has happened. 12:36 < gmaxwell> though I think patterns like mtgox show that lazy rotation might not have been much more protective than no rotation at all... they still lost most of their coins even with the 100 key keypool. 12:37 < phantomcircuit> gmaxwell, exchange users insist on reusing very old addresses 12:37 < phantomcircuit> even i they're not displayed anywhere on the site 12:37 < phantomcircuit> it's quite a problem actually 12:38 < gmaxwell> phantomcircuit: yea.... I wondered if we should have added an expiration time to bech32 addresses; to make that a bit harder. 12:38 < gmaxwell> but it's such a mess. 12:39 < phantomcircuit> gmaxwell, the easiest is for exchanges to charge a fee that increases overtime or older addresses 12:40 < phantomcircuit> or at least make a big deal out of retiring addresses and then making it annoying to use old ones 12:47 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 12:55 < kakobrekla> i just checked my db, 4.6% of deposits were made to previously used address 12:59 < phantomcircuit> kakobrekla, by volume or number 13:01 < kakobrekla> just count of deposits 13:02 -!- J-wolf [~J-wolf@82.102.252.13] has joined #bitcoin-core-dev 13:02 -!- str4d [~str4d@nova-153-092-136-128.cpe.nova.is] has joined #bitcoin-core-dev 13:02 -!- NewLiberty_ [~NewLibert@47.51.53.34] has joined #bitcoin-core-dev 13:05 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 13:06 -!- Joseph__ [~NewLibert@47.51.53.34] has quit [Ping timeout: 246 seconds] 13:13 -!- J-wolf [~J-wolf@82.102.252.13] has quit [Remote host closed the connection] 13:14 -!- J-wolf [~J-wolf@82.102.252.13] has joined #bitcoin-core-dev 13:15 -!- NewLiberty_ [~NewLibert@47.51.53.34] has quit [Ping timeout: 258 seconds] 13:15 -!- volure [434d6871@gateway/web/freenode/ip.67.77.104.113] has joined #bitcoin-core-dev 13:17 -!- J-wolf_ [~J-wolf@82.102.252.13] has joined #bitcoin-core-dev 13:17 -!- J-wolf [~J-wolf@82.102.252.13] has quit [Read error: Connection reset by peer] 13:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 13:23 -!- J-wolf_ [~J-wolf@82.102.252.13] has quit [Remote host closed the connection] 13:26 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 13:27 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:42 -!- jamesob__ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:44 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 13:48 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:33 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 14:35 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:541f:9bce:574d:7425] has joined #bitcoin-core-dev 14:36 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds] 14:37 -!- JackH_ [~laptop@host-80-43-140-111.as13285.net] has quit [Ping timeout: 260 seconds] 14:42 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 14:43 -!- elias19r [~elias19r@179.234.188.139] has left #bitcoin-core-dev [] 14:49 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:59 -!- JackH [~laptop@host-80-43-140-111.as13285.net] has joined #bitcoin-core-dev 15:03 -!- jeep-ss [~chatzilla@78.31.64.4] has joined #bitcoin-core-dev 15:06 -!- felco [~felco@unaffiliated/felco] has quit [Quit: All your IRC are belong to ZNC] 15:06 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:541f:9bce:574d:7425] has quit [Ping timeout: 255 seconds] 15:06 -!- felco [~felco@unaffiliated/felco] has joined #bitcoin-core-dev 15:07 -!- felco [~felco@unaffiliated/felco] has quit [Client Quit] 15:08 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 15:08 -!- felco [~felco@unaffiliated/felco] has joined #bitcoin-core-dev 15:09 -!- praxeology [~praxeolog@unaffiliated/praxeology] has joined #bitcoin-core-dev 15:10 -!- felco [~felco@unaffiliated/felco] has quit [Client Quit] 15:12 -!- felco [~felco@unaffiliated/felco] has joined #bitcoin-core-dev 15:28 -!- altoz [~Jimmy@2605:6000:1017:40c6:54bb:2fc6:541a:2537] has quit [Remote host closed the connection] 15:28 -!- altoz [~Jimmy@2605:6000:1017:40c6:54bb:2fc6:541a:2537] has joined #bitcoin-core-dev 15:30 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 15:31 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 15:37 -!- floog [~ubuntu@ec2-34-228-53-65.compute-1.amazonaws.com] has quit [Quit: leaving] 15:38 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Quit: Leaving] 15:39 -!- Asquire [Asquire@pool-96-228-46-144.rcmdva.fios.verizon.net] has joined #bitcoin-core-dev 15:39 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 15:44 -!- JackH [~laptop@host-80-43-140-111.as13285.net] has quit [Quit: Leaving] 15:52 -!- volure [434d6871@gateway/web/freenode/ip.67.77.104.113] has quit [Ping timeout: 260 seconds] 15:54 -!- promag [~joao@2001:8a0:fe30:de01:f535:c97d:6328:34cd] has joined #bitcoin-core-dev 15:56 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 15:57 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 16:02 -!- coredump_ [~quassel@vpn-qld171.vpnsolutions.com.au] has joined #bitcoin-core-dev 16:09 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:10 < sipa> hi, what did i miss? 16:13 < Murch> sipa: BTCe blew up, BCC implemented mandatory two-way replay protection 16:14 < Murch> apparently BTCe owner was involved at least in laundering Mt.Gox heist loot, or perhaps even the culprit 16:14 < Murch> were you in Tokyo after all? 16:14 < sipa> i'm in tokyo now 16:14 < bitcoin-git> [bitcoin] practicalswift opened pull request #10939: Check that -blocknotify command is non-empty before executing (master...blocknotify-consistentcy) https://github.com/bitcoin/bitcoin/pull/10939 16:15 < Murch> ah, I see. 16:15 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 16:28 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:37 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 16:52 -!- jtimon [~quassel@14.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 17:01 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 17:10 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:12 -!- jamesob__ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 17:15 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 17:46 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 17:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wzjstymtsyoqkyrp] has quit [Quit: Connection closed for inactivity] 17:48 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 18:02 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 18:03 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:10 -!- jamesob [~james@tempo-automation.static.monkeybrains.net] has quit [Ping timeout: 246 seconds] 18:15 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 18:23 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:26 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 18:32 -!- promag [~joao@2001:8a0:fe30:de01:f535:c97d:6328:34cd] has quit [Quit: Leaving.] 18:41 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 240 seconds] 18:41 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:56 -!- Squidicuz [~squid@pool-173-48-113-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 19:18 -!- murchandamus [~murchghos@ghostdub.de] has quit [Ping timeout: 276 seconds] 19:19 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-guhwirafpxbxiuxz] has quit [Ping timeout: 276 seconds] 19:23 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 19:25 -!- str4d [~str4d@nova-153-092-136-128.cpe.nova.is] has quit [Ping timeout: 260 seconds] 19:30 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev 19:31 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-bbseqwcjwepgwseq] has joined #bitcoin-core-dev 19:40 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:58 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 20:00 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 20:03 -!- KevinPan [~kevinpan@static-ip-25-116-90-219.rev.dyxnet.com] has joined #bitcoin-core-dev 20:24 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 20:27 -!- Eagle[TM] [~EagleTM@x4db47f1f.dyn.telefonica.de] has joined #bitcoin-core-dev 20:28 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20:36 -!- miknotauro [~miknotaur@201.141.107.91] has joined #bitcoin-core-dev 20:54 -!- jeep-ss [~chatzilla@78.31.64.4] has quit [Ping timeout: 240 seconds] 20:55 -!- KevinPan [~kevinpan@static-ip-25-116-90-219.rev.dyxnet.com] has quit [Ping timeout: 255 seconds] 20:57 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has joined #bitcoin-core-dev 21:26 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 21:36 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 22:11 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has quit [] 22:22 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 255 seconds] 23:25 < gmaxwell> ::sigh:: https://www.reddit.com/r/Bitcoin/comments/6pu13q/whats_up_with_bitcoin_core/ so github seems to be distributing tar files for our tags that have nothing to do with our distribution, and it sounds like netbsd's stuff was using them and is not happy that the checksums change (presumably because file order or compressor changed) 23:33 < sipa> they've complained about that before 23:33 < sipa> there was an issue about that years ago 23:34 < jonasschnelli> Can we disable tar download via github? I guess no... 23:36 < sipa> #2476 23:36 < gribble> https://github.com/bitcoin/bitcoin/issues/2476 | no separate source code tarball download available · Issue #2476 · bitcoin/bitcoin · GitHub 23:39 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-syysxujgxlmyybpu] has joined #bitcoin-core-dev 23:39 < wumpus> we've been creating stable tarballs for years now, for distributions and such, what's wrong with them? 23:40 < wumpus> more than two years, seeing that comment 23:43 < gmaxwell> yea, just read. For some reason it seems that after nagging the crap out of us, they didn't switch to using the tarballs they asked us to provide. 23:43 < sipa> almost 4 years ago 23:44 < wumpus> well if there's something wrong with the tarballs from their pov we'd like to hear, but wtf post it to reddit 23:45 < gmaxwell> well the person posting is probably an enduser, I guess 23:51 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev