--- Day changed Fri Aug 11 2017 00:14 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds] 00:33 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev 00:35 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:40 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 00:40 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 260 seconds] 00:44 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 276 seconds] 00:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 01:04 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Quit: Leaving] 01:06 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has joined #bitcoin-core-dev 01:07 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has quit [Client Quit] 01:13 -!- alreadylate [~textual@37-247-1-218.customers.ownit.se] has joined #bitcoin-core-dev 01:38 -!- Anduck_ is now known as Anduck 01:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 01:43 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 01:44 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:46 -!- vicenteH` [~user@195.235.96.150] has joined #bitcoin-core-dev 01:49 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 260 seconds] 01:51 -!- vicenteH` is now known as vicenteH 01:56 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev 01:59 -!- vicenteH [~user@195.235.96.150] has quit [Read error: Connection reset by peer] 01:59 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 02:13 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:16 -!- jimmysong [~jimmysong@216-111-14-66.dia.static.qwest.net] has joined #bitcoin-core-dev 02:21 -!- jimmysong [~jimmysong@216-111-14-66.dia.static.qwest.net] has quit [Ping timeout: 240 seconds] 02:34 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has quit [Quit: leaving] 02:34 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has joined #bitcoin-core-dev 02:47 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection] 02:47 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 02:54 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection] 02:54 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 03:01 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has quit [Quit: Leaving.] 03:22 -!- randy-waterhouse [~kiwigb@43.228.156.195] has joined #bitcoin-core-dev 03:23 -!- randy-waterhouse [~kiwigb@43.228.156.195] has quit [Changing host] 03:23 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 03:37 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-ruisgxytstqgzsel] has quit [Quit: Connection closed for inactivity] 03:49 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 03:51 -!- harrymm [~wayne@61-216-163-33.HINET-IP.hinet.net] has joined #bitcoin-core-dev 03:59 -!- cryptapus is now known as cryptapus_afk 04:10 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 04:12 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 04:14 -!- jimmysong [~jimmysong@216-111-14-66.dia.static.qwest.net] has joined #bitcoin-core-dev 04:15 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev 04:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 255 seconds] 04:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:22 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 04:31 -!- Netsplit over, joins: eenoch 04:36 -!- Netsplit over, joins: marcoagner 04:51 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 05:19 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-gwxtboorvbvxdxuv] has joined #bitcoin-core-dev 05:19 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-mvsvivgijxndkhjb] has joined #bitcoin-core-dev 05:19 -!- aspect_ [sid151486@gateway/web/irccloud.com/x-euknljsolwpabxqn] has joined #bitcoin-core-dev 05:20 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-gtcfogaedbnjbjyn] has joined #bitcoin-core-dev 05:22 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 240 seconds] 05:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 05:40 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 05:46 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 05:52 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:53 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:54 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:57 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has quit [Quit: Leaving.] 06:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 06:27 < luke-jr> so what's with "0.15.SW"? Is the plan for the next release to branch off 0.15 rather than master? 06:31 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 06:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e526ca6284b9...96a63a3e0cef 06:33 < bitcoin-git> bitcoin/master 8627946 Felix Weis: [RPC] trivial: gettxout no longer shows version of tx... 06:33 < bitcoin-git> bitcoin/master 96a63a3 MarcoFalke: Merge #11029: [RPC] trivial: gettxout no longer shows version of tx... 06:34 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11029: [RPC] trivial: gettxout no longer shows version of tx (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11029 06:42 -!- goldstar [~chatzilla@78.31.64.4] has joined #bitcoin-core-dev 06:44 -!- jimmysong [~jimmysong@216-111-14-66.dia.static.qwest.net] has quit [Remote host closed the connection] 06:57 -!- clarkmoody_ [~clarkmood@47-218-249-135.bcstcmta04.res.dyn.suddenlink.net] has quit [Quit: Leaving] 06:57 -!- jimmysong [~jimmysong@172.85.35.242] has joined #bitcoin-core-dev 06:57 -!- clarkmoody [~clarkmood@47-218-249-135.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 06:59 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has joined #bitcoin-core-dev 07:10 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has quit [Ping timeout: 240 seconds] 07:12 < jonasschnelli> I don't entirely understand that check: 07:12 < jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L1655 07:12 < jonasschnelli> Why do we check 'pindex->nHeight <= chainActive.Tip()->nHeight - nPrunedBlocksLikelyToHave' during pruning when responsing to GETBLOCKS 07:13 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has joined #bitcoin-core-dev 07:13 < jonasschnelli> I mean we check for BLOCK_HAVE_DATA, I don't see why we need to check for 'tip - nPrunedBlocksLikelyToHave' 07:14 < luke-jr> maybe to prevent fingerprinting? 07:25 < jonasschnelli> Yes. Maybe. 07:34 -!- JackH [~laptop@46.231.18.66] has quit [Quit: Leaving] 07:49 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 07:50 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96a63a3e0cef...e5d26e47c7a4 08:02 < bitcoin-git> bitcoin/master faa76d1 MarcoFalke: qa: Fix inv race in example_test 08:02 < bitcoin-git> bitcoin/master e5d26e4 MarcoFalke: Merge #11025: qa: Fix inv race in example_test... 08:02 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11025: qa: Fix inv race in example_test (master...Mf1708-qaInvExampleTest) https://github.com/bitcoin/bitcoin/pull/11025 08:15 < sdaftuar> jonasschnelli: i think the comment explains it -- the idea is that we don't want to respond with block hashes that we may be likely to prune in the near future 08:15 < sdaftuar> jonasschnelli: because otherwise the peer might request those blocks from us and we'll stall their block download by ignoring the request 08:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 08:33 < bitcoin-git> [bitcoin] jnewbery opened pull request #11031: [rpc] deprecate estimatefee (master...deprecate_estimatefee) https://github.com/bitcoin/bitcoin/pull/11031 08:36 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:38 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:41 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 08:44 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 255 seconds] 08:48 < jonasschnelli> sdaftuar: but the check to break the response is: 'pindex->nHeight <= chainActive.Tip()->nHeight - nPrunedBlocksLikelyToHave' 08:48 < jonasschnelli> Isn't that that blocks "older@ the 288+6 can then never be relaxed regardless of the prune target? 08:49 < jonasschnelli> s/@/" 08:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e5d26e47c7a4...2c811e08db65 08:49 < bitcoin-git> bitcoin/master c5ebddd René Nyffenegger: Tests: address placement should be deterministic by default 08:49 < jonasschnelli> *relayed (dry phone typing) 08:49 < bitcoin-git> bitcoin/master 2c811e0 MarcoFalke: Merge #10765: Tests: address placement should be deterministic by default... 08:49 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10765: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10765 08:50 < bitcoin-git> [bitcoin] sdaftuar opened pull request #11032: [qa] Fix block message processing error in sendheaders.py (master...2017-08-sendheaders) https://github.com/bitcoin/bitcoin/pull/11032 08:51 < gmaxwell> jonasschnelli: no-- if we offer a block we need to be willing to provide it or we will dos attack our peers. 08:51 < gmaxwell> doesn't matter if its 300 blocks deep or 30000 blocks deep. 08:52 < sdaftuar> also keep in mind that the line of code you're looking at is the getblocks handler, which is no longer really used to sync the chain by anyone (i hope!) 08:54 < jonasschnelli> Hmm... seems harder then I thought to add by-prune-height-fingerprinting protection for NODE_NETWORK_LIMITED 08:55 < sdaftuar> you're concerned about fingerprinting protection for nodes using manual pruning? 08:56 < sdaftuar> i would think that if you support NODE_NETWORK_LIMITED (and not NODE_NETWORK), you just always advertise exactly the last 1008 blocks or whatever that target value is 08:56 < jonasschnelli> I'm concerned introducing a fingerprinting possibility by NODE_NETWORK_LIMITED 08:57 < jonasschnelli> Yes. That is what I want. But older messages like getblock must also be covered via that protection 08:58 < sdaftuar> still don't see the fingerprinting issue -- can't all NODE_NETWORK_LIMITED nodes answer the getblocks issue the same way, with only up to the last 1008 block hashes? 09:00 < sdaftuar> nPrunedBlocksLikelyToHave can be calculated differently if you're pruning to a 1-week target versus a 2-day target 09:00 < sdaftuar> which correspond to LIMITED_HIGH and LIMITED_LOW 09:01 < jonasschnelli> Yes. The check we discussed above is kind of a fingerprinting protection. 09:01 < jonasschnelli> (Need to check it in detail when im back on my desk) 09:02 < sdaftuar> i guess! but that's just a coincidence i think, i believe that getblocks handler predates the manual pruning by a lot. 09:02 < sdaftuar> so the concern was taht we might return an inv for blocks that we currently have, but are about to prune 09:02 < sdaftuar> the idea is that pruning only (largely-) guarantees the last 288 blocks, so we're conservative and never advertise more than that 09:03 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 09:03 < sdaftuar> and that happens to also give fingerprinting protection for manual pruners, too. though really it's just a consequence of manual pruners not having any additional guarantees of what they might keep. 09:04 < sdaftuar> eg you could manually prune down to 288 right after you send someone a getblocks response, and then cause problems. 09:05 -!- dcousens_ [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 255 seconds] 09:05 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev 09:06 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:07 < sdaftuar> separately i could imagine we could schedule getblocks for deprecation 09:07 < gmaxwell> we should probably just change to only advertise things releated to the last 288 or 1008 (however configured) blocks, whatever is our minimum. 09:07 < jonasschnelli> I see. I guess then increasing that protection up to 8 days of blocks in HIGH mode makes sense 09:07 < gmaxwell> I don't see why. 09:08 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-tmuryralfjxlkxar] has joined #bitcoin-core-dev 09:08 < gmaxwell> What we signal should become the minimum we'll prune to, even with manual pruning. 09:08 < gmaxwell> And then we can getblock advertise out to that minimum. 09:12 < jonasschnelli> gmaxwell, sdaftuar: advertise, yes. I see. But I guess we need a protection here: https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L977 09:13 < jonasschnelli> Otherwise one can getdata blocks to fingerprint the prune depth? 09:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c811e08db65...bf74d377fb8e 09:14 < bitcoin-git> bitcoin/master cc5d38f John Newbery: Add option to attach a python debugger if test fails 09:14 < bitcoin-git> bitcoin/master bf74d37 MarcoFalke: Merge #11023: [tests] Add option to attach a python debugger if functional test fails... 09:14 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11023: [tests] Add option to attach a python debugger if functional test fails (master...func_test_pdb) https://github.com/bitcoin/bitcoin/pull/11023 09:14 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:17 < gmaxwell> Yes, but it should allow whitelisted peers. 09:21 < sdaftuar> agreed 09:21 < jonasschnelli> ok 09:24 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:26 -!- smill [~stevenmil@50-243-139-186-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:31 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has quit [Quit: Leaving.] 09:32 -!- Austindoggie [~austindog@2601:647:ca80:1f82:2dee:27a1:75af:71e] has joined #bitcoin-core-dev 09:33 -!- Austindoggie [~austindog@2601:647:ca80:1f82:2dee:27a1:75af:71e] has left #bitcoin-core-dev [] 09:41 -!- Aaronvan_ is now known as AaronvanW 10:00 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:02 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Remote host closed the connection] 10:03 -!- amosbird [~amosbird@123.206.66.49] has quit [Quit: ZNC 1.6.5 - http://znc.in] 10:03 -!- amosbird [~amosbird@123.206.66.49] has joined #bitcoin-core-dev 10:11 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 10:31 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 246 seconds] 10:35 -!- Austindoggie_ [~austindog@2600:380:c06d:315e:1dfb:3978:8236:ebe0] has joined #bitcoin-core-dev 10:35 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 10:39 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 255 seconds] 10:49 -!- Austindoggie_ [~austindog@2600:380:c06d:315e:1dfb:3978:8236:ebe0] has quit [Ping timeout: 246 seconds] 10:51 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 10:54 -!- cluelessperson [~cluelessp@cpe-76-85-20-142.tx.res.rr.com] has joined #bitcoin-core-dev 10:55 -!- cluelessperson is now known as Guest54492 10:56 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uwouhrtxjlfxnsce] has joined #bitcoin-core-dev 10:57 -!- Guest54492 [~cluelessp@cpe-76-85-20-142.tx.res.rr.com] has quit [Client Quit] 10:58 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev 11:00 -!- Austindoggie [~austindog@96-64-238-65-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:01 -!- Austindoggie [~austindog@96-64-238-65-static.hfc.comcastbusiness.net] has quit [Client Quit] 11:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:08 -!- alreadylate [~textual@37-247-1-218.customers.ownit.se] has quit [] 11:12 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:15 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 246 seconds] 11:16 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 11:17 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 11:18 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 11:22 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 240 seconds] 11:23 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving] 11:23 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-olaljqqkhyuwiskl] has quit [Write error: Connection reset by peer] 11:23 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-puewywzcwutkuqbk] has quit [Read error: Connection reset by peer] 11:24 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 11:28 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-xvmrznapipembhhf] has joined #bitcoin-core-dev 11:31 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 11:31 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev 11:32 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has quit [Client Quit] 11:32 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev 11:34 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-oibalnjxersvrpdw] has joined #bitcoin-core-dev 11:35 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev 11:47 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 11:52 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 240 seconds] 12:03 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 12:11 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 246 seconds] 12:16 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has quit [Ping timeout: 240 seconds] 12:16 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has joined #bitcoin-core-dev 12:44 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 12:48 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 12:56 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has quit [Quit: Leaving.] 12:57 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 246 seconds] 13:01 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-oibalnjxersvrpdw] has quit [Ping timeout: 255 seconds] 13:01 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-xvmrznapipembhhf] has quit [Read error: Connection reset by peer] 13:03 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-jgmboegnbzhwrrcp] has joined #bitcoin-core-dev 13:05 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-uwouhrtxjlfxnsce] has quit [Quit: Connection closed for inactivity] 13:09 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-zizggkzakifgfvlk] has joined #bitcoin-core-dev 13:14 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 13:16 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 246 seconds] 13:19 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has quit [Ping timeout: 240 seconds] 13:20 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has joined #bitcoin-core-dev 13:24 < jnewbery> (not for v0.15) I was thinking of adding 'bestblock' to the output from 'getwalletinfo', so if we implement something where the wallet stops advancing because of keypool deplation, at least there's an indication that your wallet is falling behind 13:26 < jnewbery> But bestblock is only updated when the block index is written to disk (usually once an hour), so I think without description, that might be very confusing for users (bestblock showing as some blocks behind, but transactions from recent blocks shown in wallet) 13:26 < jnewbery> any thoughts/suggestions? 13:28 < luke-jr> can we show the more up-to-date bestblock, but only store the block index as currently done? 13:30 < jnewbery> the wallet doesn't currently store its best block in memory. It only writes bestblock to disk when the node sends it SetBestChain (shutdown and block index flush) 13:31 < jnewbery> I suppose the wallet could store the most recent block connected when it gets BlockConnected. Is that safe? 13:36 < sipa> jnewbery: i think that's what needs to happen anyway, allow the wallet at any time to run behind the node, and make it catch up in the background 13:36 < sipa> so ack on adding bestblock to walletinfo output 13:36 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 248 seconds] 13:37 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 13:40 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 13:42 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:45 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 13:45 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:47 < ryanofsky> #10286 adds CWallet::m_last_block_processed, which is a better name than bestblock imo 13:47 < gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub 13:47 < jnewbery> sipa : does storing the hash of the most recent BlockConnected seem like the right thing to do? 13:48 < jnewbery> ryanofsky oh great. Thanks 13:49 < ryanofsky> 10286 stores it as a cblockindex pointer, but #10973 turns that into a hash, so either way seems fine 13:49 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | WIP: Add IPC layer between node and wallet by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub 13:49 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 13:59 -!- elkalamar_ is now known as elkalamar 14:02 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 14:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:08 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 14:16 -!- Victor_sueca is now known as Victorsueca 14:31 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:33 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 255 seconds] 14:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 14:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:55 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 14:57 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 15:04 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 15:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds] 15:11 -!- jimmysong [~jimmysong@172.85.35.242] has quit [Remote host closed the connection] 15:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:12 -!- jimmysong [~jimmysong@172.85.35.242] has joined #bitcoin-core-dev 15:16 -!- jimmysong [~jimmysong@172.85.35.242] has quit [Ping timeout: 240 seconds] 15:37 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 240 seconds] 15:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 15:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:49 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 15:49 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 15:55 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev 16:15 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 246 seconds] 16:18 -!- smill [~stevenmil@50-243-139-186-static.hfc.comcastbusiness.net] has quit [Quit: smill] 16:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 16:24 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has quit [Ping timeout: 246 seconds] 16:24 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has joined #bitcoin-core-dev 16:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:45 -!- alreadylate [~textual@37-247-1-218.customers.ownit.se] has joined #bitcoin-core-dev 16:47 -!- jimpo [~jimpo@4.16.87.162] has joined #bitcoin-core-dev 16:56 -!- alreadylate [~textual@37-247-1-218.customers.ownit.se] has quit [] 16:58 -!- jimpo [~jimpo@4.16.87.162] has quit [Ping timeout: 240 seconds] 16:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 17:06 -!- promag [~Adium@118.68.166.178.rev.vodafone.pt] has quit [Ping timeout: 240 seconds] 17:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:15 -!- promag [~Adium@153.21.43.5.rev.vodafone.pt] has joined #bitcoin-core-dev 17:19 -!- diteli [~diteli@cpe-74-74-233-71.rochester.res.rr.com] has joined #bitcoin-core-dev 17:19 -!- diteli_ [~diteli@cpe-74-74-233-71.rochester.res.rr.com] has joined #bitcoin-core-dev 17:20 -!- diteli_ [~diteli@cpe-74-74-233-71.rochester.res.rr.com] has quit [Client Quit] 17:23 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:26 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 17:28 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 255 seconds] 17:30 -!- diteli [~diteli@cpe-74-74-233-71.rochester.res.rr.com] has quit [Quit: Leaving] 17:31 -!- un1c0d3r [~nico@190.191.244.11] has joined #bitcoin-core-dev 17:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 17:38 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has quit [Ping timeout: 240 seconds] 17:43 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has joined #bitcoin-core-dev 17:44 -!- jimmysong [~jimmysong@64.25.27.224] has joined #bitcoin-core-dev 17:50 -!- Giszmo [~leo@net-188-153-234-97.cust.vodafonedsl.it] has quit [Quit: Leaving.] 18:00 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Remote host closed the connection] 18:01 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has joined #bitcoin-core-dev 18:01 -!- kexkey [~kexkey@68.168.119.230] has joined #bitcoin-core-dev 18:03 -!- jimmysong [~jimmysong@64.25.27.224] has quit [Ping timeout: 260 seconds] 18:04 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 255 seconds] 18:15 -!- kexkey [~kexkey@68.168.119.230] has quit [Ping timeout: 240 seconds] 18:39 -!- promag [~Adium@153.21.43.5.rev.vodafone.pt] has quit [Quit: Leaving.] 18:40 -!- kexkey [~kexkey@173.209.53.190] has joined #bitcoin-core-dev 18:40 -!- kexkey [~kexkey@173.209.53.190] has quit [Client Quit] 18:47 -!- promag [~Adium@153.21.43.5.rev.vodafone.pt] has joined #bitcoin-core-dev 18:48 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 18:58 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 19:01 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 240 seconds] 19:40 -!- Austindoggie [~austindog@2600:380:4451:864b:a869:7b8d:4148:6f4d] has joined #bitcoin-core-dev 19:48 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 19:49 -!- Austindoggie [~austindog@2600:380:4451:864b:a869:7b8d:4148:6f4d] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 20:16 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 240 seconds] 20:36 -!- ekerstein [~ekerstein@ip-64-134-217-40.public.wayport.net] has joined #bitcoin-core-dev 20:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 20:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:52 -!- promag [~Adium@153.21.43.5.rev.vodafone.pt] has quit [Quit: Leaving.] 21:02 -!- remote [~remote@portemanteau.ca] has quit [Remote host closed the connection] 21:04 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 21:21 -!- cryptapus_afk is now known as cryptapus 21:22 -!- goldstar [~chatzilla@78.31.64.4] has quit [Ping timeout: 260 seconds] 21:34 -!- jimmysong [~jimmysong@75.104.64.160] has joined #bitcoin-core-dev 21:44 -!- cryptapus is now known as cryptapus_afk 21:44 -!- jimmysong [~jimmysong@75.104.64.160] has quit [Remote host closed the connection] 22:57 -!- Austindoggie [~austindog@2602:306:8343:1cc0:4d4b:8523:f1c:8f4] has joined #bitcoin-core-dev 22:58 -!- Austindoggie [~austindog@2602:306:8343:1cc0:4d4b:8523:f1c:8f4] has quit [Client Quit] 22:59 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 276 seconds] 23:02 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 23:02 -!- corebob [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has joined #bitcoin-core-dev 23:03 -!- ekerstein [~ekerstein@ip-64-134-217-40.public.wayport.net] has quit [Read error: Connection reset by peer] 23:05 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 23:05 -!- corebob is now known as bytting 23:08 -!- bytting [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has quit [Quit: WeeChat 1.9] 23:09 -!- ekerstein [~ekerstein@ip-64-134-217-40.public.wayport.net] has joined #bitcoin-core-dev 23:10 -!- bytting [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has joined #bitcoin-core-dev