--- Day changed Wed Sep 06 2017
00:02 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
00:04 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
00:12 < bitcoin-git> [bitcoin] JeremyRubin closed pull request #11253: Add != to Base58 class (master...add_neq_ctxdest) https://github.com/bitcoin/bitcoin/pull/11253
00:13 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
00:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
00:25 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
00:28 < promag> sipa: isn´t this https://github.com/bitcoin/bitcoin/pull/11117/files#r137145517 worth the change?
00:33 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
00:34 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
00:38 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev     
00:39 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Client Quit]     
00:40 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
00:46 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
00:52 -!- hxz [~hxz@218.29.102.107] has joined #bitcoin-core-dev     
00:56 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
00:57 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 248 seconds]     
00:59 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
01:04 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
01:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]     
01:33 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev     
01:42 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
01:52 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev     
01:53 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Client Quit]     
01:55 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
01:59 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Ping timeout: 264 seconds]     
02:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:12 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]     
02:19 -!- ula [~kvirc@b2b-78-94-9-226.unitymedia.biz] has joined #bitcoin-core-dev     
02:31 -!- hxz [~hxz@218.29.102.107] has quit [Ping timeout: 252 seconds]     
02:45 -!- Jey [~je2p@5.119.166.91] has quit [Quit: Leaving]     
02:54 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…]     
03:08 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
03:17 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
03:23 -!- Ankush [0e8dad92@gateway/web/freenode/ip.14.141.173.146] has joined #bitcoin-core-dev     
03:30 -!- Ankush [0e8dad92@gateway/web/freenode/ip.14.141.173.146] has quit [Quit: Page closed]     
03:31 < bitcoin-git> [bitcoin] ysangkok opened pull request #11255: Release Notes: Fix SHA256-with-SSE4 PR link (0.15...patch-1) https://github.com/bitcoin/bitcoin/pull/11255
03:36 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev     
03:58 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Read error: No route to host]     
03:59 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
04:03 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Client Quit]     
04:03 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
04:04 -!- marcus-doodley [~marcus_do@103.254.153.113] has joined #bitcoin-core-dev     
04:07 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Ping timeout: 246 seconds]     
04:09 < bitcoin-git> [bitcoin] esotericnonsense opened pull request #11256: RPC: add weight to mempool entry output (master...2017-09-add-weight-to-mempool-entry) https://github.com/bitcoin/bitcoin/pull/11256
04:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
04:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:18 -!- marcus-doodley is now known as halform     
04:18 -!- halform [~marcus_do@103.254.153.113] has quit []     
04:19 -!- halform [~halform@103.254.153.113] has joined #bitcoin-core-dev     
04:23 -!- halform [~halform@103.254.153.113] has quit [Client Quit]     
04:23 -!- halform [~halform@103.254.153.113] has joined #bitcoin-core-dev     
04:37 -!- halform [~halform@103.254.153.113] has quit [Remote host closed the connection]     
04:46 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
04:46 -!- wxxs [~chatzilla@134.19.176.48] has joined #bitcoin-core-dev     
04:48 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 248 seconds]     
04:49 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt]     
04:52 -!- LampTreadStone07 [~androirc@172.56.11.148] has joined #bitcoin-core-dev     
04:54 -!- LampTreadStone07 [~androirc@172.56.11.148] has quit [Read error: Connection reset by peer]     
04:55 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
04:58 -!- LampTreadStone07 [~androirc@198.208.72.28] has joined #bitcoin-core-dev     
05:07 -!- Gunnie [~kamk@mail.martinstransky.cz] has joined #bitcoin-core-dev     
05:13 -!- LampTreadStone07 [~androirc@198.208.72.28] has quit [Remote host closed the connection]     
05:18 -!- halform [~halform@49.230.177.180] has joined #bitcoin-core-dev     
05:20 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Ping timeout: 255 seconds]     
05:21 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
05:22 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev     
05:29 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
05:38 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
05:55 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
05:55 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
06:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]     
06:19 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds]     
06:19 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:28 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
06:35 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
06:49 -!- shesek [~shesek@bzq-84-110-55-2.red.bezeqint.net] has joined #bitcoin-core-dev     
06:49 -!- shesek [~shesek@bzq-84-110-55-2.red.bezeqint.net] has quit [Changing host]     
06:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
06:51 -!- ChickenMustNotDi [a9006312@gateway/web/freenode/ip.169.0.99.18] has joined #bitcoin-core-dev     
06:53 -!- ChickenMustNotDi [a9006312@gateway/web/freenode/ip.169.0.99.18] has quit [Client Quit]     
07:00 -!- halform [~halform@49.230.177.180] has quit [Remote host closed the connection]     
07:05 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
07:06 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds]     
07:13 -!- Gunnie [~kamk@mail.martinstransky.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…]     
07:15 -!- ensign [~ensign@2001:41d0:8:d711::1] has quit [Ping timeout: 255 seconds]     
07:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 248 seconds]     
07:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev     
07:22 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
07:23 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]     
07:25 -!- ensign [~ensign@2001:41d0:8:d711::1] has joined #bitcoin-core-dev     
07:51 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 248 seconds]     
07:58 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 252 seconds]     
08:02 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rtxajgewoohckkaw] has joined #bitcoin-core-dev     
08:11 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-molxevfhfctqcvyr] has quit [Quit: Connection closed for inactivity]     
08:13 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
08:16 -!- halform [~halform@49.230.177.180] has joined #bitcoin-core-dev     
08:34 -!- halform_ [~halform@103.57.72.31] has joined #bitcoin-core-dev     
08:36 -!- halform [~halform@49.230.177.180] has quit [Ping timeout: 240 seconds]     
08:37 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
08:38 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
08:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds]     
09:00 < promag> MarcoFalke: done https://github.com/bitcoin/bitcoin/pull/11125
09:01 -!- Gunnie [~kamk@37-48-48-56.tmcz.cz] has joined #bitcoin-core-dev     
09:01 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
09:04 -!- halform_ [~halform@103.57.72.31] has quit [Ping timeout: 260 seconds]     
09:05 -!- Gunnie [~kamk@37-48-48-56.tmcz.cz] has quit [Client Quit]     
09:08 < MarcoFalke> promag: Great. Going to take a look today
09:12 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev     
09:13 < promag> MarcoFalke: review commit by commit, I think it's the best. I'll be around if you need to discuss it.
09:18 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
09:22 -!- halform [~halform@49.230.186.252] has joined #bitcoin-core-dev     
09:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
09:35 -!- halform [~halform@49.230.186.252] has quit [Remote host closed the connection]     
09:38 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
09:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/48790e0efaf4...134d824193a0
09:39 < bitcoin-git> bitcoin/0.15 58f1e54 Janus Troelsen: Release Notes: Fix SHA256-with-SSE4 PR link
09:39 < bitcoin-git> bitcoin/0.15 134d824 Wladimir J. van der Laan: Merge #11255: Release Notes: Fix SHA256-with-SSE4 PR link...
09:43 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Ping timeout: 246 seconds]     
09:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
09:54 -!- halform [~halform@49.230.186.252] has joined #bitcoin-core-dev     
10:01 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6866b4912b80...815fe62421cb
10:01 < bitcoin-git> bitcoin/master 0311836 Suhas Daftuar: Allow setting nMinimumChainWork on command line
10:01 < bitcoin-git> bitcoin/master eac64bb Suhas Daftuar: [qa] Test nMinimumChainWork...
10:01 < bitcoin-git> bitcoin/master 815fe62 Wladimir J. van der Laan: Merge #10357: Allow setting nMinimumChainWork on command line...
10:02 < bitcoin-git> [bitcoin] laanwj closed pull request #10357: Allow setting nMinimumChainWork on command line (master...2017-05-chainwork-commandline) https://github.com/bitcoin/bitcoin/pull/10357
10:07 -!- halform [~halform@49.230.186.252] has quit [Remote host closed the connection]     
10:08 -!- Gunnie [~kamk@37-48-45-78.tmcz.cz] has joined #bitcoin-core-dev     
10:09 -!- Gunnie [~kamk@37-48-45-78.tmcz.cz] has quit [Client Quit]     
10:09 -!- halform [~halform@49.230.186.252] has joined #bitcoin-core-dev     
10:12 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rtxajgewoohckkaw] has quit [Quit: Connection closed for inactivity]     
10:19 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/815fe62421cb...5368614aa106
10:19 < bitcoin-git> bitcoin/master dea086f MeshCollider: Stop test_bitcoin-qt touching ~/.bitcoin
10:19 < bitcoin-git> bitcoin/master 5368614 Wladimir J. van der Laan: Merge #11210: Stop test_bitcoin-qt touching ~/.bitcoin...
10:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
10:20 < bitcoin-git> [bitcoin] laanwj closed pull request #11210: Stop test_bitcoin-qt touching ~/.bitcoin (master...201708_qt_test_dir) https://github.com/bitcoin/bitcoin/pull/11210
10:21 -!- Provoostenator [~textual@54693D0F.cm-12-2a.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
10:25 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
10:26 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has joined #bitcoin-core-dev     
10:33 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…]     
10:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5368614aa106...21e2f2f79961
10:39 < bitcoin-git> bitcoin/master 62ecce7 João Barbosa: [doc] Add RPC response notes
10:39 < bitcoin-git> bitcoin/master 21e2f2f Wladimir J. van der Laan: Merge #11135: Update developer notes with RPC response guidelines...
10:40 < bitcoin-git> [bitcoin] laanwj closed pull request #11135: Update developer notes with RPC response guidelines (master...2017-08-rpc-response-notes) https://github.com/bitcoin/bitcoin/pull/11135
10:40 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
10:43 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Quit: leaving]     
10:45 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Ping timeout: 246 seconds]     
10:45 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev     
10:46 -!- halform [~halform@49.230.186.252] has quit [Remote host closed the connection]     
10:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
10:58 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
11:04 -!- Provoostenator [~textual@54693D0F.cm-12-2a.dynamic.ziggo.nl] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
11:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/21e2f2f79961...31809d6f8514
11:05 < bitcoin-git> bitcoin/master faa8d95 MarcoFalke: [qa] TestNode: Add wait_until_stopped helper method
11:05 < bitcoin-git> bitcoin/master 31809d6 MarcoFalke: Merge #11067: [qa] TestNode: Add wait_until_stopped helper method...
11:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
11:06 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11067: [qa] TestNode: Add wait_until_stopped helper method (master...Mf1708-qaTestnodeWaitStopHelper) https://github.com/bitcoin/bitcoin/pull/11067
11:14 < bitcoin-git> [bitcoin] jnewbery opened pull request #11258: [WIP] [rpc] Add initialblockdownload to getblockchaininfo (master...expose_ibd) https://github.com/bitcoin/bitcoin/pull/11258
11:15 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/31809d6f8514...59e17899a762
11:15 < bitcoin-git> bitcoin/master 37495e0 Jeremy Rubin: Reorder C{,Mutable}Transaction for better packing
11:15 < bitcoin-git> bitcoin/master 59e1789 Wladimir J. van der Laan: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction...
11:17 -!- bitsegwit [~seggggwit@c-217-115-42-58.cust.bredband2.com] has quit [Ping timeout: 248 seconds]     
11:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
11:22 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
11:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
11:54 < GAit> is github user promag in IRC?
11:54 < GAit> oh he usually is just not now, fair enough
11:54 < sipa> sometimes
11:55 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has joined #bitcoin-core-dev     
11:55 < sipa> he's here now :p
11:55 < promag> :)     
11:55 < promag> ´     
11:55 < promag> sup?
11:55 < promag> GAit: need something?
11:57 < GAit> oh I just wanted to say I am not ignoring your suggestion re: 11099 with the multiple failure modes of DumpMempool, i.e. the test doesn't exercise the "return false" within the exception handler but i think that's much harder to cause and i wanted to minimize changes to DumpMempool or how it affects other callers
11:57 < GAit> and also i wanted to thank you for all the feedback, very valuable
11:58 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/59e17899a762...d745b4cf7b09
11:58 < bitcoin-git> bitcoin/master 7e5d596 Suhas Daftuar: RPC: add wtxid to mempool entry output
11:58 < bitcoin-git> bitcoin/master 617c459 Suhas Daftuar: qa: rpc test for wtxid in mempool entry
11:58 < bitcoin-git> bitcoin/master d745b4c Wladimir J. van der Laan: Merge #11203: rpc: add wtxid to mempool entry output...
11:58 -!- Dizzle [~dizzle@108.171.182.16] has quit [Remote host closed the connection]     
11:58 < promag> there's also "Also, RenameOver() doesn't throw, and IMO we should fail if the mempool.dat can't be updated"
11:59 < promag> maybe in a follow up patch add handling for that
11:59 < GAit> right but that's IMHO for a different PR
11:59 < bitcoin-git> [bitcoin] laanwj closed pull request #11203: rpc: add wtxid to mempool entry output (master...2017-08-add-wtxid-to-mempool-entry) https://github.com/bitcoin/bitcoin/pull/11203
11:59 < promag> voila
11:59 < promag> I can create that, it's on the todo list
11:59 < GAit> i'll be happy to review
12:00 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
12:17 -!- wxxs_ [~chatzilla@185.145.66.248] has joined #bitcoin-core-dev     
12:19 -!- wxxs [~chatzilla@134.19.176.48] has quit [Ping timeout: 240 seconds]     
12:19 -!- wxxs_ is now known as wxxs     
12:20 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has quit [Quit: Snoozing.]     
12:27 -!- wxxs [~chatzilla@185.145.66.248] has quit [Ping timeout: 240 seconds]     
12:35 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
12:38 -!- promag [~promag@2001:8a0:fe30:de01:4cdb:d964:a079:6bd7] has quit [Remote host closed the connection]     
12:40 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
12:41 < bitcoin-git> [bitcoin] laanwj closed pull request #10872: Docs: Syntax highlight shell commands in the building notes (master...hilite) https://github.com/bitcoin/bitcoin/pull/10872
12:43 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds]     
12:45 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d745b4cf7b09...39ae41389a86
12:45 < bitcoin-git> bitcoin/master 41bf159 practicalswift: Remove unreachable code
12:45 < bitcoin-git> bitcoin/master 39ae413 Wladimir J. van der Laan: Merge #10845: Remove unreachable code...
12:45 < bitcoin-git> [bitcoin] laanwj closed pull request #10845: Remove unreachable code (master...remove-unreachable-code) https://github.com/bitcoin/bitcoin/pull/10845
12:46 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
12:48 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer]     
12:48 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
12:52 -!- madness [779885a0@gateway/web/freenode/ip.119.152.133.160] has joined #bitcoin-core-dev     
12:52 -!- madness is now known as Guest72310     
12:53 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .]     
12:56 < promag> jnewbery: in portuguese, xpto it's like foo :)
12:56 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev     
12:58 -!- Guest72310 [779885a0@gateway/web/freenode/ip.119.152.133.160] has quit [Quit: Page closed]     
13:01 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds]     
13:01 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev     
13:02 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
13:17 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds]     
13:20 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
13:22 -!- eenoch [~eenoch@unaffiliated/eenoch] has quit [Quit: leaving]     
13:32 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/39ae41389a86...961901f77e55
13:32 < bitcoin-git> bitcoin/master 5c8ff0d Pieter Wuille: Introduce wrappers around CBitcoinAddress...
13:32 < bitcoin-git> bitcoin/master 864cd27 Pieter Wuille: Move CBitcoinAddress to base58.cpp
13:32 < bitcoin-git> bitcoin/master 961901f Wladimir J. van der Laan: Merge #11117: Prepare for non-Base58 addresses...
13:32 < bitcoin-git> [bitcoin] laanwj closed pull request #11117: Prepare for non-Base58 addresses (master...201708_nocbitcoinaddress) https://github.com/bitcoin/bitcoin/pull/11117
13:41 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has joined #bitcoin-core-dev     
13:49 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds]     
13:51 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
13:52 < bitcoin-git> [bitcoin] promag opened pull request #11259: Remove duplicate destination decoding (master...2017-09-remove-duplicate-destination-decoding) https://github.com/bitcoin/bitcoin/pull/11259
13:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/961901f77e55...bc561b4b7d6a
13:52 < bitcoin-git> bitcoin/master 467cbbc Lawrence Nahum: Add return value to DumpMempool
13:52 < bitcoin-git> bitcoin/master 1aa97ee Lawrence Nahum: Add savemempool RPC
13:52 < bitcoin-git> bitcoin/master bc561b4 MarcoFalke: Merge #11099: [RPC][mempool]: Add savemempool RPC...
13:53 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11099: [RPC][mempool]: Add savemempool RPC (master...dump_mempool_rpc) https://github.com/bitcoin/bitcoin/pull/11099
13:59 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection]     
14:10 -!- eenoch [~eenoch@unaffiliated/eenoch] has joined #bitcoin-core-dev     
14:12 -!- Ruben [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds]     
14:17 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-twkfwsqhwptfeeji] has joined #bitcoin-core-dev     
14:34 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has quit [Read error: Connection reset by peer]     
14:34 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Remote host closed the connection]     
14:41 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
14:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc561b4b7d6a...6acdb1fab770
14:54 < bitcoin-git> bitcoin/master c001992 MeshCollider: Fix potential null dereferences
14:54 < bitcoin-git> bitcoin/master 6acdb1f Wladimir J. van der Laan: Merge #11238: Add assertions before potential null deferences...
14:55 < bitcoin-git> [bitcoin] laanwj closed pull request #11238: Add assertions before potential null deferences (master...201708_fbinfer_fixes) https://github.com/bitcoin/bitcoin/pull/11238
15:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
15:05 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has quit [Quit: Snoozing.]     
15:05 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
15:08 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 248 seconds]     
15:11 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]     
15:11 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
15:16 -!- Timber_ [acfa42c8@gateway/web/freenode/ip.172.250.66.200] has joined #bitcoin-core-dev     
15:17 < jnewbery> promag : obrigado :)
15:18 < promag> jnewbery: np
15:19 < bitcoin-git> [bitcoin] laanwj closed pull request #10889: Docs: Run windows build in a clean path (master...docswin) https://github.com/bitcoin/bitcoin/pull/10889
15:19 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]     
15:19 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
15:23 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...]     
15:24 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev     
15:28 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #11260: travis: Check that default datadir is never created, Check SHAs only once (master...Mf1708-travisYaml) https://github.com/bitcoin/bitcoin/pull/11260
15:28 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
15:33 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
15:41 < wumpus> looks like we have a few new warnings:
15:41 < wumpus> base58.cpp:308:6: warning: ‘bool {anonymous}::CBitcoinAddress::IsScript() const’ defined but not used [-Wunused-function]
15:41 < wumpus> base58.cpp:298:6: warning: ‘bool {anonymous}::CBitcoinAddress::GetKeyID(CKeyID&) const’ defined but not used [-Wunused-function]
15:43 < wumpus> promag: mind to addresss ^^ in #11259?
15:43 < promag> np     
15:43 < wumpus> at least, if it's not result of a bug or something, haven't looked in detail yet
15:43 < promag> I'll take a look
15:45 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6acdb1fab770...bcc8a620eae9
15:45 < bitcoin-git> bitcoin/master 478d4fb Sjors Provoost: [docs] explain how to recompile only what bitcoind tests need...
15:45 < bitcoin-git> bitcoin/master bcc8a62 Wladimir J. van der Laan: Merge #11219: [docs] explain how to recompile a modified unit test...
15:45 < bitcoin-git> [bitcoin] laanwj closed pull request #11219: [docs] explain how to recompile a modified unit test (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11219
15:46 < wumpus> so the compiler can identify unused *methods* now? that's interesting - i guess because it's local to the file
15:48 < wumpus> that was with gcc 6.3.0, btw
15:48 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
15:49 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
15:49 < promag> wumpus: rebased, new commit
15:50 < promag> wumpus: I think so too
15:53 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]     
15:57 < wumpus> promag: thanks, will rebuild to check
16:00 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has quit [Quit: Snoozing.]     
16:01 < bitcoin-git> [bitcoin] practicalswift opened pull request #11261: scripted-diff: Use <cxxx> instead of deprecated <xxx.h> when including C compatibility headers (master...cinclude) https://github.com/bitcoin/bitcoin/pull/11261
16:03 < promag> is it me or github mail notifications are lagging?
16:05 < wumpus> yes, it seems slow
16:09 -!- vicenteH is now known as Zenton     
16:23 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bcc8a620eae9...089b742a210b
16:23 < bitcoin-git> bitcoin/master 8d0041e João Barbosa: Remove unused GetKeyID and IsScript methods from CBitcoinAddress
16:23 < bitcoin-git> bitcoin/master 86e6dd4 João Barbosa: Remove duplicate destination decoding
16:23 < bitcoin-git> bitcoin/master 089b742 Wladimir J. van der Laan: Merge #11259: Remove duplicate destination decoding...
16:23 < bitcoin-git> [bitcoin] laanwj closed pull request #11259: Remove duplicate destination decoding (master...2017-09-remove-duplicate-destination-decoding) https://github.com/bitcoin/bitcoin/pull/11259
16:24 -!- Timber_ [acfa42c8@gateway/web/freenode/ip.172.250.66.200] has quit [Ping timeout: 260 seconds]     
16:26 < MarcoFalke> wumpus: 10838
16:29 < wumpus> MarcoFalke: hmm?
16:29 < MarcoFalke> ready for merge ;)
16:29 < promag> MarcoFalke: 11125
16:29 < wumpus> even without your release notes change? ok
16:30 < wumpus> yes 11125 is ready
16:30 < MarcoFalke> The release notes change will force another pull to be rebased
16:30 < MarcoFalke> , which already has some utACKs
16:30 < wumpus> true
16:31 < wumpus> right, I missed that there was a reasoning behind skipping it
16:31 < promag> sipa: care to rebase 11167?
16:31 < promag> I don't mind adding the release notes..
16:32 < MarcoFalke> wumpus: I never shared the reasoning. Either BlueMatt missed it or did it on purpose. Either way is fine, heh
16:32 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/089b742a210b...66a5b419eff5
16:32 < bitcoin-git> bitcoin/master aece8a4 Matt Corallo: (finally) remove getinfo in favor of more module-specific infos
16:32 < bitcoin-git> bitcoin/master 66a5b41 Wladimir J. van der Laan: Merge #10838: (finally) remove getinfo...
16:33 < bitcoin-git> [bitcoin] laanwj closed pull request #10838: (finally) remove getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
16:33 < wumpus> argh 11125 needs rebase too, now @promag
16:33 < BlueMatt> hmmm, what'd i do?
16:34 < wumpus> conflict: test/functional/bitcoin_cli.py
16:34 < promag> great branch name 2017-07-seriously-fuck-getinfo
16:34 < wumpus> nothing that could be avoided anyhwo
16:34 < promag> wumpus: 1 sec
16:34 < wumpus> lol nice
16:39 < promag> wumpus: rebased 11125
16:40 < wumpus> thanks
16:41 < promag> renamed cli_get_info to cli_response and rpc_get_info to rpc_response, I can revert thou
16:41 < promag> I was going to inline like assert_equal(self.nodes[0].cli.getblockchaininfo(), self.nodes[0].getblockchaininfo())
16:44 < meshcollider> how is fanquake able to add and remove labels, etc if hes not a member?
16:44 < meshcollider> or is he a member but just hasn't set it to display
16:45 < wumpus> he is a member
16:47 < bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/66a5b419eff5...645a7ecc0b8d
16:47 < bitcoin-git> bitcoin/master 7696841 João Barbosa: Fix style in -stdin and -stdinrpcpass handling
16:47 < bitcoin-git> bitcoin/master e127494 João Barbosa: [test] Improve assert_raises_jsonrpc docstring
16:47 < bitcoin-git> bitcoin/master 5c18a84 João Barbosa: [test] Add support for custom arguments to TestNodeCLI
16:47 < bitcoin-git> [bitcoin] laanwj closed pull request #11125: Add bitcoin-cli -stdin and -stdinrpcpass functional tests (master...2017-08-stdinrpcpass-functional-test) https://github.com/bitcoin/bitcoin/pull/11125
16:47 < meshcollider> things have been moving so fast these last couple of days, its awesome 
16:48 < meshcollider> so many merges
16:49 < wumpus> yes we've caught up a little bit on the PR backlog :)
16:50 < MarcoFalke> Like 12 new pulls and 14 merged/closed. Delta is like two or something
16:50 < wumpus> yeah...
16:51 < promag> still, merge fest!
16:52 < sipa> ya     
16:52 < MarcoFalke> ja, who's not ready for bed by now?
16:52 < meshcollider> its only midday over here in NZ ;) 
16:53 < promag> 1am here, must take kids to school by 8am, I can troll a bit more
17:01 < wumpus> getting quite tired too
17:03 < meshcollider> wumpus: re https://github.com/bitcoin/bitcoin/pull/10793#discussion_r137361636 did you want me to change it?
17:04 < meshcollider> or was that just a reply to dcousens
17:04 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 246 seconds]     
17:05 < wumpus> meshcollider: I'd prefer that - I think it'd make sense to restrict that PR what it says in the title;  generally changing &vec[i] to vec.data() + i does nothing to avoid UB
17:05 < wumpus> which was the idea behind &var[0] to var.data()
17:06 < sipa> wumpus: &var[0] is inherently invalid for empty vectorz
17:06 < sipa> while var.data() is allowed for empty vectors
17:07 < sipa> you're still not allowed to dereference the result of var.data()
17:07 < sipa> but with &var[0] it's already invalid, whether you use it not
17:07 < wumpus> yes, I know that
17:08 < wumpus> that was my point, &var[0] to .data() makes sense, but e.g. &var[42] to var.data()+42 does not
17:08 < wumpus> which is what meshcollider has extended to scope to in some places in that PR
17:08 < sipa> oh, i see
17:08 < meshcollider> yeah I'll revert that
17:09 < sipa> well, &var[42] is also invalid for a var of length 42 or less
17:09 < sipa> while var.data() + 42 is always valid, as long as you don't use it
17:10 < wumpus> still, it's getting used in all those cases
17:10 < sipa> okay!
17:10 < wumpus> which is UB in any case
17:10 < meshcollider> yeah its usually used with memcpy()'s 
17:13 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev     
17:16 < meshcollider> fixed
17:16 < meshcollider> poor Travis will be having a hard time with all these commits recently lol
17:17 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
17:19 < promag> speaking of that, wumpus any idea when you'll check #11006?
17:20 < promag> It can save some travis resources
17:21 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev     
17:25 < wumpus> I'm really confused about that one
17:28 < wumpus> can't reproduce any problems with it locally, but I'm afraid of bringing back random travis failures. I much prefer it taking somewhat longer to random failures that make people lose trust in the tests
17:29 < wumpus> I'm not sure what the problem was back then and if you can remove that workaround now, what made it go away
17:30 < promag> I would say merge as it get a couple more ACK, revert later if needed
17:31 < promag> I can't figure out if you did that, pass nullptr to timeout
17:32 < wumpus> no, I never did that, because it means that bitcoind will never terminate if there are open rpc connectinos
17:32 < wumpus> AFAIK
17:34 < promag> that is correct, but if the connections are closed then it quits immediately, if not then it will break as it is now
17:34 < wumpus> so the timeout is there to force any existing RPC connections to terminate
17:35 < promag> right, for instance, some dumb tests, whatever
17:36 < wumpus> yes, could be for various reasons, our examples pretty much encourage keeping connections open between commands
17:36 < promag> in the best scenario, there are no active events and the loop can exit right away
17:36 < wumpus> (which is more efficient than opening a new connection for every commmand, but we don't want this to hold up the shutdown process, people will get confused)
17:36 < wumpus> stop means that the process must exit, despite open connections
17:37 < wumpus> yes, I agree ideally it should exit immediately if there are no active eventw
17:37 < wumpus> and in say, 3 seconds if there are active events
17:37 < wumpus> that's why the code is so complicated
17:39 < promag> so, on my side I did test with different libevent versions, run test suite multiple times.. no issue so far
17:40 < wumpus> yes, but did you try keeping connections open to the daemon after sending stop?
17:40 < wumpus> e.g. trying to prevent it from exiting
17:40 < promag> yes, I did this https://github.com/bitcoin/bitcoin/pull/11006#issuecomment-321954764
17:40 < wumpus> you've checked that it doesn't quit prematurely, which is great, but only part of the functionality
17:41 < wumpus> what if you change the sleep(3) to sleep(1000)
17:41 < wumpus> does it wait 1000 seconds to actually exit?
17:41 < wumpus> or does it give up after a while
17:41 < promag> 1001sec please
17:42 < wumpus> lol     
17:42 < promag> but I guess it will break, because of the current code
17:42 < promag> I mean, it's not graceful quit
17:43 < promag> err, rebuild, removed worktree
17:50 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/645a7ecc0b8d...f65614726de2
17:50 < bitcoin-git> bitcoin/master e91b961 flack: Create dependencies.md, and link dependencies file from README & build docs
17:50 < bitcoin-git> bitcoin/master f656147 Wladimir J. van der Laan: Merge #10779: Create dependencies.md...
17:50 < bitcoin-git> [bitcoin] laanwj closed pull request #10779: Create dependencies.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10779
17:55 -!- halform [~halform@49.230.184.152] has joined #bitcoin-core-dev     
17:56 < meshcollider> also wumpus, re #11237, do you want me to fix the weird commit split or leave it as-is
17:59 -!- halform [~halform@49.230.184.152] has quit [Read error: Connection reset by peer]     
17:59 -!- halform [~halform@49.230.184.152] has joined #bitcoin-core-dev     
18:04 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
18:07 -!- halform [~halform@49.230.184.152] has quit []     
18:12 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Remote host closed the connection]     
18:12 < esotericnonsense> hm. promag: i'm looking at adding tests for the weight field in mempool now. can get it to work for txid2 and txid3 but not txid1. sdaftuar's 'add wtxid to mempool entry output'
18:13 < esotericnonsense> also fails on txid1 if I reuse his test.
18:13 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds]     
18:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f65614726de2...2a56baf395bf
18:16 < bitcoin-git> bitcoin/master ca67ddf esneider: Move the AreInputsStandard documentation next to its implementation
18:16 < bitcoin-git> bitcoin/master 2a56baf MarcoFalke: Merge #10682: Trivial: Move the AreInputsStandard documentation next to its implementation...
18:16 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10682: Trivial: Move the AreInputsStandard documentation next to its implementation (master...move-doc) https://github.com/bitcoin/bitcoin/pull/10682
18:19 -!- hxz [~hxz@1.198.6.186] has joined #bitcoin-core-dev     
18:20 < esotericnonsense> i've amended the PR and pointed out the test that fails. my knowledge here is lacking unfortunately.
18:27 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
18:28 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev     
18:41 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Remote host closed the connection]     
18:41 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds]     
18:43 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev     
18:54 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
18:58 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 252 seconds]     
19:05 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
19:11 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev     
19:15 -!- dabura667 [~dabura667@KD111103034253.ppp-bb.dion.ne.jp] has joined #bitcoin-core-dev     
19:17 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
19:18 -!- dabura667 [~dabura667@KD111103034253.ppp-bb.dion.ne.jp] has quit [Remote host closed the connection]     
19:22 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 246 seconds]     
19:28 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Ping timeout: 258 seconds]     
19:30 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Ping timeout: 240 seconds]     
19:33 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev     
19:40 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev     
19:46 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Ping timeout: 260 seconds]     
19:47 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev     
19:54 < meshcollider> esotericnonsense: isn't it failing because txid1 has no witness
19:58 < meshcollider> hmm idk
19:59 < esotericnonsense> meshcollider: it might be that i'm getting lost in the python framework's definitions
19:59 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
20:00 -!- alxlu [~alxlu@138.68.58.104] has quit [Quit: ZNC 1.6.5 - http://znc.in]     
20:02 < esotericnonsense> from BIP141 i interpret 'base tx size' as tx.serialize() (because it is equivalent to tx.serialize_without_witness()), and tx.serialize_with_witness() as being total transaction size BIP141
20:03 < meshcollider> yeah that sounds right
20:04 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 246 seconds]     
20:04 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
20:05 < esotericnonsense> 'size' in the mempool rpc is virtual tx size (weight/4)
20:06 < esotericnonsense> argh. doh. this makes the entire thing pointless. brain fart.
20:07 < meshcollider> hmm not quite, virtual size is rounded up to the nearest integer so they're not entirely the same
20:07 < esotericnonsense> ah yes that's true.
20:09 < sipa> it's (3*size_without_witness + size + 3)/4
20:11 < esotericnonsense> size == math.ceil(weight/4) checks out for all three tx in segwit.py. it's just this one for which tx.serialize()*3 + tx.serialize_with_witness() != weight.
20:11 < esotericnonsense> hm.     
20:11 < meshcollider> sipa: where does the extra +3 come from?
20:12 < esotericnonsense> meshcollider: it just accomplishes the ceiling function
20:13 < esotericnonsense> e.g. (3*nowitness + size + 3)/4 == ceil((3*nowitness+size)/4)
20:13 < esotericnonsense> (where the former uses integer division)
20:15 < sipa> meshcollider: to round up
20:16 < sipa> esotericnonsense: right
20:16 < meshcollider> ok yeah so it relies on integer division, that's where I was confused
20:16 < meshcollider> Was thinking there might be some reason it was always exactly an integer lol
20:16 < esotericnonsense> the problem is that i misinterpreted the original rpc call, so knowing size and weight is not useful for my particular case, which means that my PR is probably pointless :)
20:16 < esotericnonsense> (the intention was to know 'is this a segwit tx')
20:17 < meshcollider> also kinda relevant is issue #11218, sipa suggested renaming size to vsize
20:18 < esotericnonsense> the other PR accomplishes what I need, (just check wtxid against txid)
20:20 < esotericnonsense> if it were base size and not vsize, then my check of bsize*4 != weight would work
20:29 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
20:34 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
20:38 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has joined #bitcoin-core-dev     
20:41 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
20:45 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 246 seconds]     
21:03 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
21:12 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
21:12 -!- lynx [45b58e17@gateway/web/freenode/ip.69.181.142.23] has joined #bitcoin-core-dev     
21:13 -!- lynx is now known as Guest59971     
21:14 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
21:18 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev     
21:18 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer]     
21:18 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
21:19 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:19 -!- Guest59971 [45b58e17@gateway/web/freenode/ip.69.181.142.23] has quit [Ping timeout: 260 seconds]     
21:19 -!- PRab_ [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has joined #bitcoin-core-dev     
21:19 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
21:19 -!- praxeology1 [~praxeolog@cpe-173-172-191-20.tx.res.rr.com] has joined #bitcoin-core-dev     
21:19 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 248 seconds]     
21:19 -!- Evel-Knievel [~Evel-Knie@178-119-237-211.access.telenet.be] has quit [Ping timeout: 248 seconds]     
21:19 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Ping timeout: 248 seconds]     
21:20 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev     
21:20 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has quit [Ping timeout: 248 seconds]     
21:20 -!- kayamm [~km@unaffiliated/kayamm] has quit [Ping timeout: 248 seconds]     
21:20 -!- Evel-Knievel [~Evel-Knie@178-119-237-211.access.telenet.be] has joined #bitcoin-core-dev     
21:20 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev     
21:20 -!- adiabat [~adiabat@45.63.20.152] has quit [Ping timeout: 246 seconds]     
21:20 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 248 seconds]     
21:20 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Ping timeout: 248 seconds]     
21:20 -!- Lightsword [~Lightswor@107.170.253.193] has quit [Ping timeout: 248 seconds]     
21:21 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 248 seconds]     
21:21 -!- praxeology [~praxeolog@cpe-173-172-191-20.tx.res.rr.com] has quit [Ping timeout: 248 seconds]     
21:21 -!- LeMiner is now known as LeMiner2     
21:21 -!- spinza [~spin@196.212.164.26] has quit [Excess Flood]     
21:21 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has quit [Ping timeout: 248 seconds]     
21:21 -!- Ruben [~RubenSoms@1.217.138.142] has quit [Ping timeout: 248 seconds]     
21:21 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 248 seconds]     
21:21 -!- PRab_ is now known as PRab     
21:22 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:22 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev     
21:22 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
21:23 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
21:24 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev     
21:24 -!- jonasschnelli [~jonasschn@bitcoinsrv.jonasschnelli.ch] has joined #bitcoin-core-dev     
21:24 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
21:25 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev     
21:25 -!- kayamm [~km@pastasuta.pro] has joined #bitcoin-core-dev     
21:25 -!- kayamm [~km@pastasuta.pro] has quit [Changing host]     
21:25 -!- kayamm [~km@unaffiliated/kayamm] has joined #bitcoin-core-dev     
21:27 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Ping timeout: 248 seconds]     
21:27 -!- esotericnonsens_ [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev     
21:27 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 240 seconds]     
21:27 -!- rjak [~rjak@gateway/vpn/privateinternetaccess/rjak] has quit [Ping timeout: 240 seconds]     
21:27 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 252 seconds]     
21:28 -!- ryan-c [~ryan@znc.rya.nc] has quit [Ping timeout: 248 seconds]     
21:29 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 248 seconds]     
21:29 -!- esotericnonsens_ is now known as esotericnonsense     
21:29 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev     
21:29 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev     
21:30 < jtimon> jnewbery: does BitcoinTestFramework.add_nodes() need to get num_nodes as param, isn't that internal now?
21:31 < jtimon> never mind, let me read more...
21:32 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
21:39 -!- rjak [~rjak@gateway/vpn/privateinternetaccess/rjak] has joined #bitcoin-core-dev     
21:44 -!- ryan-c [~ryan@znc.rya.nc] has joined #bitcoin-core-dev     
21:57 -!- go1111111 [~go1111111@199.231.240.157] has joined #bitcoin-core-dev     
22:02 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 240 seconds]     
22:03 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev     
22:04 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has joined #bitcoin-core-dev     
22:05 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
22:05 < meshcollider> can someone with travis powers restart the failed one here, should be unrelated: https://travis-ci.org/bitcoin/bitcoin/jobs/272710677
22:07 < meshcollider> can only members with write access restart travis? Seems like that should be a weaker permission, but not really sure how githubs permission model works
22:09 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 255 seconds]     
22:10 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has quit [Quit: Leaving]     
22:10 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has joined #bitcoin-core-dev     
22:13 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has quit [Client Quit]     
22:13 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has joined #bitcoin-core-dev     
22:15 < kallewoof> meshcollider: restarted
22:29 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has joined #bitcoin-core-dev     
22:38 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds]     
22:39 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
22:46 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
22:51 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has quit [Quit: Leaving]     
22:51 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 255 seconds]     
23:00 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 252 seconds]     
23:28 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
23:32 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 246 seconds]     
23:53 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev     
23:54 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
23:54 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Remote host closed the connection]