--- Day changed Thu Sep 14 2017
00:01 < mryandao> heya, while running bitcoind in docker, i tried to symlink debug.log to /dev/stderr and bitcoind crashed when a boost function tried to read the path, is that expected behaviour?
00:02 < NicolasDorier> Running bitcoin-core-0.15.0/test.rc3 on one of my server, getting "2017-09-14 06:55:48 socket send error The operation completed successfully.  (0)"  in logs _without_ debug=net. Then the connection drop to the peer. My peer is a NBitcoin peer, and I could not reproduce the error on the same 0.15.0/test.rc3 running on my machine.
00:03 < NicolasDorier> "socket send error The operation completed successfully. (0)", interesting message at least...
00:19 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
00:23 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Ping timeout: 246 seconds]     
00:25 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
00:26 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Remote host closed the connection]     
00:29 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
00:38 < promag> Can I have some feedback here #11316?
00:38 < gribble> https://github.com/bitcoin/bitcoin/issues/11316 | [qt] Add use available balance in send coins dialog by promag · Pull Request #11316 · bitcoin/bitcoin · GitHub
00:39 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Remote host closed the connection]     
00:41 -!- CubicEarth [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit []     
00:43 < NicolasDorier> mmh I doubt the bug comes from bitcoin core actually
00:56 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
01:00 -!- cryptorob [605254e1@gateway/web/freenode/ip.96.82.84.225] has joined #bitcoin-core-dev     
01:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
01:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
01:07 -!- cryptorob [605254e1@gateway/web/freenode/ip.96.82.84.225] has quit [Quit: Page closed]     
01:10 < bitcoin-git> [bitcoin] MeshCollider opened pull request #11326: Fix crash on shutdown with invalid wallet (master...201709_shutdown_crash) https://github.com/bitcoin/bitcoin/pull/11326
01:10 < meshcollider> thats such a small fix it doesn't even feel right to make a whole PR lol
01:24 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving]     
01:29 < earlz> How exactly do you debug the bitcoin-qt on 64bit windows? I know the gitian builds produce both the binaries and debug symbols, but not sure what the best way to debug a crash is
01:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-qtxiwadfdlgxxgsm] has quit [Quit: Connection closed for inactivity]     
01:31 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
01:52 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:54 -!- timothy [tredaelli@redhat/timothy] has quit [Read error: Connection reset by peer]     
01:55 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
01:55 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
01:58 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
02:04 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev     
02:11 < wumpus> earlz: the debug symbols can be used in combination with the stack trace and a memory map to find out what symbol was involved. I don't know of any way to do debugging *on* windows sanely, there's a mingw gdb but I don't think it works very well
02:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
02:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
02:14 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
02:26 < promag> wdyt return txid in signrawtransaction? (at least if complete)
02:28 < promag> there is this pattern decoderaw(signraw().hex).txid 
02:28 < promag> could be simplified to signraw().txid
02:30 < wumpus> could be, though I always run decoderaw after signraw anyhow, to check the transaction one last time before broadcasting it
02:31 < wumpus> so it wouldn't help me at least - but if you think many would be helped by having txid on signrawtransaction output object why not open a PR
02:32 -!- victorSN [~victorSN@ec2-52-14-222-162.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev     
02:33 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
02:33 < wumpus> also, sendrawtransaction(hex) returns the txid - so you really need the txid before broadcasting the transaction? 
02:34 < wumpus> or is this useful if you use an alternative way to broadcast transactions
02:34 < promag> ah, so in https://github.com/bitcoin/bitcoin/pull/11167/files#diff-e239d66ea758103213db73bf934d0918R601
02:34 < promag> there is no need to decoderawtransaction
02:35 < wumpus> indeed, it could take the result from sendrawtransaction instead
02:36 < wumpus> this way of working makes sense though if it's testing decoderawtransaction
02:37 < promag> don't think so, if it's testing decoderawtransaction then it's incomplete
02:37 < wumpus> in any case, I don't think we should fix test inconsistencies by changing the API :)
02:39 < promag> no, that's why I asked before opening the PR
02:40 < promag> but having the txid back and forward doesn't sound too bad
02:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7fcd61b2613c...f4ed44ab4a8f
02:42 < bitcoin-git> bitcoin/master dd36561 Evan Klitzke: Add a lint check for trailing whitespace....
02:42 < bitcoin-git> bitcoin/master 1f379b1 MeshCollider: Add tab char lint check and exclude imported dependencies
02:42 < bitcoin-git> bitcoin/master f4ed44a MarcoFalke: Merge #11300: Tests: Add a lint check for trailing whitespace...
02:43 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11300: Tests: Add a lint check for trailing whitespace (master...201709_whitespace_lint) https://github.com/bitcoin/bitcoin/pull/11300
02:47 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Remote host closed the connection]     
03:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
03:14 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
03:17 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev     
03:21 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev     
03:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
03:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
03:34 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
03:34 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
03:36 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
03:37 -!- wxxs [~chatzilla@xsx891.stwserver.net] has joined #bitcoin-core-dev     
03:37 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
03:40 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Ping timeout: 246 seconds]     
03:43 -!- wxxs [~chatzilla@xsx891.stwserver.net] has quit [Ping timeout: 260 seconds]     
04:04 -!- wxxs [~chatzilla@89.238.183.133] has joined #bitcoin-core-dev     
04:06 -!- StopAndDecrypt_ [~StopAndDe@142.75.255.199] has joined #bitcoin-core-dev     
04:12 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
04:14 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
04:18 -!- wxxs [~chatzilla@89.238.183.133] has quit [Ping timeout: 248 seconds]     
04:26 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
04:28 -!- nelruk [~dax_the_c@181.122.72.30] has joined #bitcoin-core-dev     
04:30 -!- eck_ [~eck@fsf/member/eck] has joined #bitcoin-core-dev     
04:30 -!- eck_ [~eck@fsf/member/eck] has quit [Client Quit]     
04:31 -!- eck [~tGysJVzRq@151.56.197.35.bc.googleusercontent.com] has quit [Quit: ZNC 1.6.5+deb1 - http://znc.in]     
04:31 -!- eck [~eck@fsf/member/eck] has joined #bitcoin-core-dev     
04:34 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Remote host closed the connection]     
04:54 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
04:56 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Remote host closed the connection]     
04:56 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
05:01 -!- victorSN [~victorSN@ec2-52-14-222-162.us-east-2.compute.amazonaws.com] has quit [Remote host closed the connection]     
05:03 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection]     
05:04 -!- rockhouse [~rockhouse@h54110.upc-h.chello.nl] has joined #bitcoin-core-dev     
05:04 -!- rockhouse [~rockhouse@h54110.upc-h.chello.nl] has quit [Changing host]     
05:04 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev     
05:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer]     
05:05 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Read error: Connection reset by peer]     
05:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer]     
05:05 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Connection reset by peer]     
05:06 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev     
05:07 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
05:07 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
05:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
05:10 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has quit [Ping timeout: 248 seconds]     
05:13 -!- victorSN [~victorSN@ec2-52-14-222-162.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev     
05:14 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev     
05:15 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Remote host closed the connection]     
05:19 -!- parazyd [~parazyd@unaffiliated/parazyd] has quit [Ping timeout: 276 seconds]     
05:33 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
05:36 -!- victorSN [~victorSN@ec2-52-14-222-162.us-east-2.compute.amazonaws.com] has quit [Remote host closed the connection]     
05:36 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has joined #bitcoin-core-dev     
05:36 -!- victorSN [~victorSN@ec2-52-14-222-162.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev     
05:40 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving]     
05:40 -!- pbase [~pbase@122.168.159.107] has joined #bitcoin-core-dev     
05:40 -!- promag [~promag@2001:8a0:fe30:de01:58c:1047:7535:c5e6] has quit [Ping timeout: 246 seconds]     
05:41 -!- pbase [~pbase@122.168.159.107] has quit [Changing host]     
05:41 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
05:45 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
05:47 -!- wxxs [~chatzilla@89.238.183.133] has joined #bitcoin-core-dev     
05:48 -!- wxxs_ [~chatzilla@89.238.183.133] has joined #bitcoin-core-dev     
05:49 -!- wxxs__ [~chatzilla@89.238.183.133] has joined #bitcoin-core-dev     
05:51 -!- wxxs___ [~chatzilla@89.238.183.133] has joined #bitcoin-core-dev     
05:52 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving]     
05:52 -!- wxxs [~chatzilla@89.238.183.133] has quit [Ping timeout: 252 seconds]     
05:52 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
05:52 -!- wxxs___ is now known as wxxs     
05:53 -!- wxxs_ [~chatzilla@89.238.183.133] has quit [Ping timeout: 252 seconds]     
05:53 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/86700d3d056caf54b091a6673dd6dabb65fac1f2
05:53 < bitcoin-git> bitcoin/master 86700d3 Wladimir J. van der Laan: doc: add release-notes for 0.15.0 to master...
05:54 -!- wxxs__ [~chatzilla@89.238.183.133] has quit [Ping timeout: 252 seconds]     
05:54 -!- pbase [~pbase@unaffiliated/pbase] has quit [Client Quit]     
05:55 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
05:57 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Ping timeout: 248 seconds]     
05:58 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev     
05:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:02 < bitcoin-git> [bitcoin] laanwj closed pull request #11280: [0.15] Final to-do's for 0.15.0 release notes (0.15...201709_release_note_015_todo) https://github.com/bitcoin/bitcoin/pull/11280
06:03 -!- parazyd [~parazyd@chat.dyne.org] has joined #bitcoin-core-dev     
06:03 -!- parazyd [~parazyd@chat.dyne.org] has quit [Changing host]     
06:03 -!- parazyd [~parazyd@unaffiliated/parazyd] has joined #bitcoin-core-dev     
06:08 -!- wxxs [~chatzilla@89.238.183.133] has quit [Ping timeout: 252 seconds]     
06:08 -!- wxxs_ [~chatzilla@89.238.178.90] has joined #bitcoin-core-dev     
06:08 -!- wxxs_ is now known as wxxs     
06:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 1.4]     
06:18 < NicolasDorier> https://www.irccloud.com/pastebin/hIAM1dLB/
06:18 < NicolasDorier> using 0.15rc3
06:20 < NicolasDorier> my node can't even start again after restarting it
06:20 < NicolasDorier> it is doing that every time it starts
06:25 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:28 < wumpus> afaik that one (if it's during init) is fixed on master
06:28 < NicolasDorier> yep during init
06:29 < wumpus> https://github.com/bitcoin/bitcoin/pull/11126
06:29 < NicolasDorier> cool
06:29 < NicolasDorier> thanks I try that now
06:29 < wumpus> doesn't affect the release executables as they're not built with DEBUG_LOCKORDER
06:30 < wumpus> (and it's not an actual possible deadlock - will be backported to 0.15.1 though)
06:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
06:34 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
06:47 < NicolasDorier> wumpus: no luck, this is unrelated to this PR
06:47 < wumpus> ok     
06:47 < NicolasDorier> this is indeed not a real deadlock though
06:47 < NicolasDorier> will just deactivate debug for now and find out what happen
06:48 -!- GAit [~GAit@unaffiliated/gait] has quit [Quit: WeeChat 1.0.1]     
06:49 -!- GAit [~GAit@unaffiliated/gait] has joined #bitcoin-core-dev     
06:51 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]     
06:53 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has quit [Ping timeout: 248 seconds]     
06:57 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev     
07:04 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
07:16 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 248 seconds]     
07:18 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/7c53587101eaf206a6a6a11a9398d43f139eadcf
07:18 < bitcoin-git> bitcoin/0.15 7c53587 Wladimir J. van der Laan: doc: Clean out release notes on 0.15 branch...
07:18 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
07:18 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev     
07:19 -!- nelruk [~dax_the_c@181.122.72.30] has quit [Quit: Leaving]     
07:22 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/96d91b79bdfe1c0a58bd645f0f1d657caba16deb
07:22 < bitcoin-git> bitcoin/master 96d91b7 Wladimir J. van der Laan: contrib: Ignore historical release notes for whitespace check...
07:23 < NicolasDorier> how to remove DEBUG_LOCKORDER ? I tried to compile withount --enable-debug, but no luck it see;s
07:24 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
07:27 < NicolasDorier> meh I must have screwed up somewhere... will redeploy
07:29 < wumpus> it's --enable-debug that adds it, so rebuilding without it (you'd need to 'make clean' too) will get rid of it
07:38 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
07:38 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving]     
07:41 < NicolasDorier> yeah sorry, I messed up by replacing the wrong bitcoind on my server :/
07:41 < NicolasDorier> so actually I did not tried https://github.com/bitcoin/bitcoin/pull/11126 yet. But the path of the locks is different from the PR so I guess this is different error.
07:41 < NicolasDorier> filed an issue
07:48 < MarcoFalke> 15000 commits. This thing explodes 🎉
07:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96d91b79bdfe...0f399a9ff227
07:48 < bitcoin-git> bitcoin/master 77939f2 MeshCollider: Fix uninitialized g_connman crash in Shutdown()
07:48 < bitcoin-git> bitcoin/master 0f399a9 MarcoFalke: Merge #11326: Fix crash on shutdown with invalid wallet...
07:49 -!- Dtime [181c0a94@gateway/web/freenode/ip.24.28.10.148] has joined #bitcoin-core-dev     
07:49 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11326: Fix crash on shutdown with invalid wallet (master...201709_shutdown_crash) https://github.com/bitcoin/bitcoin/pull/11326
07:54 -!- Dtime [181c0a94@gateway/web/freenode/ip.24.28.10.148] has quit [Ping timeout: 260 seconds]     
07:57 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:00 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jgzmidgavahfpzen] has quit [Quit: Connection closed for inactivity]     
08:01 < bitcoin-git> [bitcoin] danra opened pull request #11328: Move comment about transaction/block weight calculation (master...fix/weight-comment) https://github.com/bitcoin/bitcoin/pull/11328
08:02 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has left #bitcoin-core-dev []     
08:03 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev     
08:03 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
08:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]     
08:09 < bitcoin-git> [bitcoin] jnewbery closed pull request #10044: [tests] [build] Run functional tests in `make check` (master...reorg_makefiles) https://github.com/bitcoin/bitcoin/pull/10044
08:13 -!- brianhoffman__ [~brianhoff@pool-96-231-163-68.washdc.fios.verizon.net] has quit [Quit: brianhoffman__]     
08:17 -!- Aaronva__ is now known as AaronvanW     
08:18 -!- brianhoffman_ [~brianhoff@pool-96-231-163-68.washdc.fios.verizon.net] has joined #bitcoin-core-dev     
08:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
08:31 < mryandao> has anyone here using tmux experience extreme lag when they `git clone` the bitcoin repo for the first time?
08:32 < wumpus> never noticed - though i guess git does a lot of terminal updates during the progress update so maybe that is slowed by running in tmux?
08:33 < wumpus> MarcoFalke: heh yes also noticed, 15000, wow that's a milestone in itself I guess
08:33 < mryandao> it was particularly bad after i did a git pull on my fork that was 1000+ commits behind. 
08:33 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]     
08:33 < mryandao> i had to remove the whole repo and clone with depth=1
08:33 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev     
08:33 < wumpus> well better to run git outside tmux then?
08:33 < wumpus> at least initial clones
08:34 < wumpus> if you think cloning bitcoin is bad, try cloning the linux kernel
08:35 < mryandao> heh     
08:36 < mryandao> ah actually, it might be tmux-airline that was tracking the 1000+ commit that's pending
08:36 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
08:38 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Read error: Connection reset by peer]     
08:43 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
08:52 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds]     
08:54 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
08:56 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds]     
08:59 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
09:03 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
09:05 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
09:05 < wumpus> ok     
09:08 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]     
09:15 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
09:25 < luke-jr> wumpus: mryandao: interesting, usually GNU Screen (similar to tmux) reduces screen update lag O.o
09:25 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
09:28 < bitcoin-git> [bitcoin] mess110 opened pull request #11329: [test] Test abortrescan command (master...kallewoof/test-abort-rescan-2) https://github.com/bitcoin/bitcoin/pull/11329
09:30 < wumpus> interesting, it probably does some update coalescing on the background. I've personally never noticed tmux making things slower, but I don't have any fancy plugins iether
09:34 < luke-jr> right
09:45 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]     
09:47 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev     
09:51 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
09:58 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
10:05 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has quit [Ping timeout: 248 seconds]     
10:08 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev     
10:09 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:16 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
10:23 < bitcoin-git> [bitcoin] danra opened pull request #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY (master...patch-10) https://github.com/bitcoin/bitcoin/pull/11330
10:28 < achow101> if anyone sees any issue remotely like #11171, please get the GUI settings (from windows registry or from ~/.config/Bitcoin/Bitcoin-Qt.conf) before doing -resetguisettings
10:28 < gribble> https://github.com/bitcoin/bitcoin/issues/11171 | RC2 Exits After Initialization · Issue #11171 · bitcoin/bitcoin · GitHub
10:28 < achow101> I would like to see what the gui settings are before they are reset as that should give a clue as to how that crash is happening
10:30 < wumpus> yes that would be very useful to know
10:30 < wumpus> will you ask in the issue too?
10:31 < achow101> yep, asked
10:31 < achow101> I didn't realize someone else was experiencing the same problem. otherwise I would have asked them for their gui settings earlier, but they already reset them
10:32 < gmaxwell> Has anyone encountered this on Linux?
10:33 < achow101> gmaxwell: I don't think so
10:34 < ryanofsky> BlueMatt got a report from someone yesterday using linux
10:36 < wumpus> so from achow101's analysis it looks like something to do with the proxy configuration? that could be the case ,proxy can be set from the gui settings
10:36 < BlueMatt> yea, someone complaining that 0.15 on the ppa was busted
10:36 < BlueMatt> his response to me claimed he assumed it was proxy
10:36 < BlueMatt> i asked for more details but havent heard back yet (to try to confirm it if possible)
10:36 < achow101> I think it has to do with the proxy setting although I couldn't think of a proxy string that would replicate the problem
10:36 < wumpus> if that is true, though, it should be possible to trigger it from the command line too, as the proxy simply gets passed in in a similar way 
10:38 < wumpus> yes exactly then it will be some string that crashes it
10:39 < wumpus> apparently starting with 0.15 branch
10:39 < achow101> well I tried a lot of weird strings and couldn't get anything to crash it :/
10:39 < achow101> I got it to crash after it all loaded and I tried to modify the settings though. There's an open issue for that
10:39 < wumpus> I don't remember if there were any proxy handling changes for 0.15
10:42 < gmaxwell> thats it's a crash limits the number of possibiltty.
10:42 < gmaxwell> er possibilities.
10:43 < gmaxwell>     Merge #9774: Enable host lookups for -proxy and -onion parameters
10:43 < gribble> https://github.com/bitcoin/bitcoin/issues/9774 | Enable host lookups for -proxy and -onion parameters by jmcorgan · Pull Request #9774 · bitcoin/bitcoin · GitHub
10:43 < gmaxwell> looks like it was in 0.15
10:44 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
10:44 < wumpus> yes, that one would certainly be a possibility
10:48 < bitcoin-git> [bitcoin] jnewbery closed pull request #10748: [config] Help text cleanup (master...helptextcleanup) https://github.com/bitcoin/bitcoin/pull/10748
10:48 < wumpus> I don't see how though
10:50 < wumpus> if it's something in paymentserver crashing, it's not the lookup itself that crashes it, but something in the transfer of the proxy address to a qt structure
10:51 < gmaxwell> well for example, I wonder if Lookup would crash with a e.g. 0xff input. otherwise I don't see how the lookup change could be it
10:52 < gmaxwell> (or maybe a truncated multibyte character)
10:53 < wumpus> it happens after the argument parsing though
10:54 < wumpus> in the log in 11171 it's even handling peers already
10:54 < gmaxwell> the obvious way to try to repro is to get these things set in the registry, then edit the registry manually to set the keys to empty strings.
10:55 < achow101> gmaxwell: been there done that. A lot of invalid things are caught that makes it fail to start entirely (throws initerror)
10:56 < wumpus> yes, it help so much to have an example of a failing config
10:59 < harrymm> i got matt's ppa to my ubuntu 17.04 system when it was available. i had the gui crash you're talking about and got it working with -resetguisettings. 
11:00 < harrymm> i still have the processed core dump if that helps ya.
11:01 < gmaxwell> you have a core dump!
11:01 < achow101> harding: it would be better to have your gui config
11:01 < harrymm> it actually said the seg was SIGSEGV at QAbstractButton:setChecked(bool) from libQtGui.so.4.
11:01 < gmaxwell> achow101: not harding, harrymm
11:01 < bitcoin-git> [bitcoin] danra opened pull request #11331: Trivial: Update outdated comment in validation.h (master...patch-11) https://github.com/bitcoin/bitcoin/pull/11331
11:01 < achow101> oops
11:02 < harrymm> yep. i'm not sure how to analyse it. it's a whoopsie thing.
11:02 < harrymm> gdb doesn't do the job. sorry i'm not too skillful at this :)
11:03 < harrymm> it was produced when i allowed it to send the bug info to launchpad trackers (I thought)
11:04 < BlueMatt> harrymm: I mean what settings do you recall having? custom datadir, encrypted wallet, selected different buttons for fees in the send tab.....?
11:05 < BlueMatt> minimize to tray?
11:06 < harrymm> yes to all of those iirc
11:06 < harrymm> i had a backup i made during this process but cleaned it out today when the thing finally worked. :(
11:07 < gmaxwell> harrymm: can you get a backtrace from it?    gdb -c corefile ./path-to/bitcoin-qt    then "thread apply all bt full"
11:08 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has joined #bitcoin-core-dev     
11:08 < harrymm> i'll have a shot...
11:10 < harrymm> no. that gives me the same result i got before. it doesn't recognize the apport/whoopsie processed file
11:10 < gmaxwell> okay I don't know what that does it it.
11:11 < wumpus> it's possible to extract a gdb core dump from the processed file, don't remember the steps though
11:11 < harrymm> i couldn't find out how to load it locally either. but the file info was sent off to a bug tracker at the time (severl times in fact). launchpad should have it.
11:11 < harrymm> tho. this file is 100MB. i'm sure not that much was in the bug report :)
11:11 < wumpus> apport-unpack apparently https://wiki.ubuntu.com/Apport#I.27m_a_developer._How_do_I_use_these_crash_reports.3F
11:12 < wumpus> yes, these are steps for examining it locally, not sure what parts are uploaded
11:13 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has quit [Ping timeout: 255 seconds]     
11:14 < BlueMatt> i see no bugs anywhere...no idea what reporting it did
11:14 < BlueMatt> unless you're the "john" who emailed previously
11:17 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has joined #bitcoin-core-dev     
11:17 < harrymm> not me. tho i did see a comment with this same fault. someone suggested a new report be opened but afaik it was not done.
11:17 < BlueMatt> a comment? where?
11:17 < harrymm> that was in github iirc
11:17 < BlueMatt> ohoh, yea, github
11:18 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:18 < BlueMatt> i dont know what blackhole the launchpad reports went into
11:18 < harrymm> i tried to find it too .. failed
11:18 < harrymm> so shall i try to unpack this thing?
11:18 < BlueMatt> yes, please
11:18 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has quit [Remote host closed the connection]     
11:19 < harrymm> k. i didn't have much luck with apport options yesterday but i didn't try this particular one. 
11:20 < wumpus> yes, the core dump inside it can hopefully give us a useful backtrace
11:20 < harrymm> wow. that worked and it was quick. i now have a whole bunch of separate files
11:21 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has joined #bitcoin-core-dev     
11:21 < harrymm> the segvanalysis file says: Segfault happened at: 0x7fd6466e033d <_ZN15QAbstractButton10setCheckedEb+13>:   mov    0x8(%rdi),%rbx
11:21 < harrymm> PC (0x7fd6466e033d) ok
11:21 < harrymm> source "0x8(%rdi)" (0x00000008) not located in a known VMA region (needed readable region)!
11:21 < harrymm> destination "%rbx" ok
11:22 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev     
11:22 < wumpus> can you pastebin the output of: <gmaxwell> harrymm: can you get a backtrace from it?    gdb -c corefile ./path-to/bitcoin-qt    then "thread apply all bt full"
11:22 < harrymm> segvreason: reading NULL VMA
11:23 < harrymm> i can't make gdb process this thing
11:23 < wumpus> I guess something called setChecked on a NULL pointer
11:23 < wumpus> there should be a corefile between those unpacked files, that works with gdb in that way
11:23 < harrymm> oh. wait..
11:25 < harrymm> haha. i missed that CoreDump file. Ok. I've got gdb opened. 
11:26 < wumpus> these are all uses of setChecked in the code base: https://0bin.net/paste/CMyf3KukY-4bWwpS#MpZG+6rLJIl-1gwTfsKUe4baTOHnCmPDtVpJcLMpos2
11:27 < BlueMatt> wumpus: where do you think my list of possible settings in use came from :p
11:27 < harrymm> how do i get a file out containg the backtrace?
11:28 < BlueMatt> just copy/paste the output of the above command into a site like 0bin or pastebin
11:28 < harrymm> no symbols of course, but i can prolly get it up to pastebin
11:28 < wumpus> to make gdb log, "set logging file <filename>" "set logging on"
11:28 < BlueMatt> or that
11:28 < wumpus> no symbols in the ppa?
11:29 < wumpus> we don't have separate debug info for that one either :/
11:29 < BlueMatt> you can get symbols from ppa
11:29 < BlueMatt> but you have to manually download that
11:29 < BlueMatt> sec     
11:29 < BlueMatt> what ubuntu version?
11:30 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving]     
11:30 < harrymm> 17.04
11:31 < harrymm> i got a log file. i'll wait to see oif i can get symbols tho
11:31 < BlueMatt> https://launchpad.net/~bitcoin/+archive/ubuntu/bitcoin/+build/13367431/+files/bitcoind-dbgsym_0.15.0-zesty6_amd64.ddeb
11:31 < BlueMatt> from https://launchpad.net/~bitcoin/+archive/ubuntu/bitcoin/+build/13367431
11:31 < BlueMatt> i assume you ended up with 0.15.0-zesty6
11:31 < harrymm> sounds right. 
11:32 < harrymm> not sure about that 6 but iirc it was :)
11:32 < BlueMatt> i dont actually know how to turn that into debugsyms in gdb, but I believe dpkg -i will let you install the ddeb file
11:35 < BlueMatt> harrymm: I think it might magic....if you download the ddeb file there, dpkg -i it (or otherwise install it like a normal package) and then re-open gdb, it may know to search usr/lib/debug
11:38 < harrymm> double-click worked. lol. gdb is showing symbols now.
11:42 < achow101> harrymm: got the gdb output yet?
11:43 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
11:46 < harrymm> https://pastebin.com/XDzaeFrS
11:47 < harrymm> but it frustratingly seems to not have the symbols dammit. it loaded them ok ...
11:47 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds]     
11:50 -!- Dtime [181c0a94@gateway/web/freenode/ip.24.28.10.148] has joined #bitcoin-core-dev     
11:53 < harrymm> aww. should i have told gdb to load symbols from the symbols downloaded? it says it's reading them from bitcoin-qt (which doesn't have them)
11:53 < achow101> harrymm: I believe so. I don't remember the gdb commands/params for that though
11:54 < harrymm> i see a -s <file> but dunno what file i got
11:54 < harrymm> i apologize for my naivety :)
11:54 -!- Dtime [181c0a94@gateway/web/freenode/ip.24.28.10.148] has quit [Ping timeout: 260 seconds]     
11:55 -!- clarkmoody [~clarkmood@47-218-249-135.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev     
11:57 < BlueMatt> your file is /usr/lib/debug/usr/bin/bitcoind
11:57 < harrymm> ahh     
11:57 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4]     
11:58 < harrymm> wait. bitcoind or bitcoin-qt?
11:58 < BlueMatt> oh, no, bitcoin-qt, sorry
11:58 < BlueMatt> oh, wait, lol wrong file
11:58 < BlueMatt> sec     
11:58 < harrymm> ok     
11:58 < BlueMatt> yea, obviously you want the -qt dbgsym ddeb instead
11:59 < BlueMatt> https://launchpad.net/~bitcoin/+archive/ubuntu/bitcoin/+build/13367431/+files/bitcoin-qt-dbgsym_0.15.0-zesty6_amd64.ddeb
11:59 < gmaxwell> 30 seconds till meeting.
11:59 < harrymm> lol. i see it now too. 
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Sep 14 19:00:07 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < sipa> present
12:00 < instagibbs> hi     
12:00 < gmaxwell> sipa: you're late
12:00 < jonasschnelli> Hy     
12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
12:00 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
12:00 < cfields_> hi     
12:01 < sipa> short topic: congrats for 0.15.0!
12:01 < Chris_Stewart_5> yay!
12:01 < cfields_> woohoo
12:01 < wumpus> congrats and thanks everyone
12:01 < instagibbs> \o/     
12:01 < jonasschnelli> !     
12:01 < harrymm> :)     
12:01 < wumpus> #topic high priority for review
12:01 < instagibbs> beatings will continue until 0.15.1 is out the door
12:02 < wumpus> we managed to merge quite a lot during the coredev meet, so there's some place for new things in https://github.com/bitcoin/bitcoin/projects/8
12:03 < wumpus> so any suggestions?
12:03 < achow101> hi     
12:03  * BlueMatt is keeping hi
12:03 < BlueMatt> s     
12:03  * sipa also
12:04 < BlueMatt> sipa: you dont have one
12:04 < wumpus> anything for 0.15.1 maybe?
12:04 < sipa> #11167 then
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11167 | Full BIP173 (Bech32) support by sipa · Pull Request #11167 · bitcoin/bitcoin · GitHub
12:04 < instagibbs> #11089 
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11089 | Enable various p2sh-p2wpkh functionality by luke-jr · Pull Request #11089 · bitcoin/bitcoin · GitHub
12:04 < wumpus> added 11167
12:04 < BlueMatt> where are we on 0.15.1?
12:05 < cfields_> i have a pretty long stream of stuff to prep for libevent, but i don't want to burn everyone out by nagging too much. would you all prefer a few prs, all of which build on each-other, and a final one that incorporates everything?
12:05 < sipa> i'll work on the segwit-by-default stuff for 0.15.1
12:05 < wumpus> added 11089
12:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
12:06 < cfields_> (#10663 is the first of those. It's by no means high priority, other than it's necessary for the rest)
12:06 < wumpus> cfields_: that depends; if some part stands on itself, it might make sense to PR it first then give it as a blocker
12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/10663 | net: split resolve out of connect by theuni · Pull Request #10663 · bitcoin/bitcoin · GitHub
12:06 < wumpus> that says enough, added 10663
12:06 < jonasschnelli> cfields_ I Prefer a single one to get the overall pictures
12:07 < cfields_> wumpus: thanks
12:07 < wumpus> but if it's a single one there's just so damn much to review
12:07 < instagibbs> jonasschnelli, or all of them, chained, with backpointers to first one to review
12:07 < gmaxwell> this gui crash issues should be considered a 0.15.1 blocker, but we still aren't sure of the precise cause.
12:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]     
12:07 < BlueMatt> jonasschnelli: sure, but you cant merge that...opening one which will be final eventually and then breaking it into chunks is also ok
12:07 < wumpus> gmaxwell: agree
12:07 < BlueMatt> gmaxwell: yup :(
12:07 < cfields_> jonasschnelli: ok, i can break them up into nice chunks, and have a tracking PR with them all rebased on top of eachother
12:07 < gmaxwell> considering the flood of reports I am really no longer able to believe we didn't recently introduce it.
12:07 < cfields_> i think that's pretty common these days
12:08 < wumpus> cfields_: sounds good to me
12:08 < gmaxwell> (maybe via a dep upgrade)
12:08 < michagogo> o/     
12:08 -!- fpgaminer [~fpgaminer@cpe-172-90-105-203.socal.res.rr.com] has joined #bitcoin-core-dev     
12:08 < jonasschnelli> one for conceptual overview and multiple for real merge
12:08 < wumpus> gmaxwell: agreed
12:08 < cfields_> gmaxwell: possible that other clients are dinking with config files?
12:09 < jonasschnelli> (sorry phone typping)
12:09 < gmaxwell> that was a theory I had too but have seen no evidence of it.
12:09 < gmaxwell> harrymm: have you run bitcoin unlimited or bitcoin cash or likewise on that system you crashed on?
12:09 < morcos> Wouldn't we see 0.14 reports in that case
12:09 < wumpus> we really need a config or regtest dump from someone that has the issue
12:09 < BlueMatt> harrymm: how are those -qt debug symbols coming?
12:09 < wumpus> before they run -resetguisettings
12:09 < wumpus> in retrospect we should have made resetguisettings dump the settings to a backup file
12:10 < jonasschnelli> cfields_ : perfect
12:10 < cfields_> gmaxwell: iirc we didn't bump qt for 0.15. so deps seem unlikely
12:10 < achow101> wumpus: we should start doing that now
12:10 < wumpus> I mean you only run it when something is wrong
12:10 < wumpus> achow101: yes
12:11 < wumpus> #action Make -resetguisettings dump settings to troubleshooting file in datadir
12:11 < gmaxwell> cfields_: well I'm not completely sure that the issue is 0.15.x specific based on report load it could have been, say, 0.14.2 too ... and just a lot of people are upgrading.
12:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
12:11 < sipa> "oh, it's faster, i'll try running a full node again"
12:12 < cfields_> gmaxwell: what's the OS diversity?
12:12 < wumpus> but it was *never* reported for 0.14.x
12:12 < sipa> wumpus: fair point...
12:12 < wumpus> it would explain more reports, sure
12:12 < gmaxwell> we have a linux report now. so far mostly windows reports.
12:12 < achow101> gmaxwell: I suspect that's because more people use windows than linux
12:12 < gmaxwell> I don't think we've had a mac report. maybe there are just no mac users. :P 
12:13 < cfields_> ah damn, i was thinking it could be a windows update
12:13 < sipa> did we update qt in between 0.14.2 and 0.15.0?
12:13 < harrymm> gmaxwell: not those you mentioned. i did try some other bitcoin python stuff at various times tho
12:13 < cfields_> hmm. I can run on osx and plug/unplug monitors like a madman.
12:13 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
12:13 < gmaxwell> harrymm: thanks.
12:13 < achow101> cfields_: it's not a monitor problem
12:13 < gmaxwell> So thats counter evidence to the theory that bch or bu is corrupting it.
12:13 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]     
12:14 < wumpus> the monitor problem just disappears the window
12:14 < wumpus> I think this is unrelated
12:14 < achow101> This is definitely unrelated
12:14 < cfields_> ok     
12:14 < jonasschnelli> is that still the offscreen issue?
12:14 < gmaxwell> There may be two issues fixed with the same thing or two manifestiations of the same issue.
12:14 < harrymm> BlueMatt: i got the right symbols down and loaded into gdb, but there's still many symbols i don't have. i was checking if the relevant ones were there but not sure i have the right skills anyway so i will pastebin what i have
12:15 < achow101> jonasschnelli: it's the #11171 issue
12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/11171 | RC2 Exits After Initialization · Issue #11171 · bitcoin/bitcoin · GitHub
12:15 < achow101> which is not an offscreen issue although we initially thought it was
12:15 < jonasschnelli> again:  GUI: TransactionTablePriv::refreshWallet
12:15 < wumpus> jonasschnelli: was that the same problem?
12:15  * BlueMatt gets the impression there are at least 2 distinct issues here (+ the offscreen one which is not a segfault, right?)
12:16 < wumpus> jonasschnelli: I don'tremember that one was fixed by clearing gui settings
12:16 < wumpus> the offscreen issue is not a segfault, ever
12:16 < jonasschnelli> no... not possible IMO
12:16 < jonasschnelli> 11171 seems totally unrelated to the offscreen issue
12:16 < wumpus> the refreshWallet crash was intermittent, very hard to reproduce
12:16  * BlueMatt also doesnt believe this exists on 0.14.2...so far 2 reports from ppa folks, and they tend to be a rather well-upgraded bunch
12:16 < wumpus> this one is 100% reproducible
12:16 < wumpus> unless you clear the settings
12:16 < jonasschnelli> Okay. I'll track down 11171
12:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
12:17 < BlueMatt> harrymm: yea, pastebin what you have would be great
12:17 < achow101> jonasschnelli: that's what we're doing now with harrymm :)
12:17 < jonasschnelli> xyzzy099 == harrymm?
12:17 < gmaxwell> BlueMatt: offscreen gets the same report from users though:  window doesn't appear, resetting the gui settings fixes it.
12:17 < jonasschnelli> gmaxwell: I have tracked this down and it's no longer present in 0.15
12:17 < achow101> jonasschnelli: no, different people, same symptoms, possibly same problem
12:17 < jonasschnelli> (official builds)
12:18 < jonasschnelli> It may happen if you self compile with <Qt5.6
12:18 < achow101> (symptoms being crash after splash screen)
12:18 -!- pbase [~pbase@unaffiliated/pbase] has quit [Ping timeout: 240 seconds]     
12:18 < wumpus> yes the offscreen one has unclear status on the release binaries, jonasschnelli's testing points at it being fixed
12:18 < BlueMatt> jonasschnelli: which issue is that?
12:18 < BlueMatt> ah, offscreen
12:18 < achow101> wumpus: I believe the offscreen issue should be fixed in 0.15
12:19 < wumpus> achow101: yes
12:19 < BlueMatt> it'd be nice to fix the qt5 issues so that ppa can upgrade to it instead of being stuck on qt4......
12:19 < jonasschnelli> It's fixed in 0.15.0 (I have tested with Win7,8.1/10)
12:19 < wumpus> BlueMatt: just wait for unity to die
12:19 < gmaxwell> jonasschnelli: how does <Qt5.6 come into it?
12:19 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has quit [Remote host closed the connection]     
12:19 < wumpus> wasn't the most serious qt5 problem on ubuntu the tray icon thing? no such issue on GNOME
12:20 < jonasschnelli> gmaxwell: I'm not sure if Qt is related. I could not find if the bug was fixed upstream (I think we had a Qt depdendency upgrade from 0.14 to 0.15) or if its fixed in out sources.
12:20 < BlueMatt> wumpus: heh, I mean there was discussion of killing the tray icon
12:20 < BlueMatt> wumpus: yes, I believe the tray icon was ~the only blocker
12:20 < gmaxwell> jonasschnelli: the problem is that we've had users reporting all through the rcs something that sounds like that, and now in releases. So just saying its fixed isn't helpful, since there is clearly something that isn't fixed.
12:20 < wumpus> anyhow that's yet another different issue
12:20 < BlueMatt> wumpus: there was some minimize issue that was also there, but I believe it was related...just kill the tray icon and its fixed, I think
12:20 < achow101> gmaxwell: jonasschnelli: I think you're talking about different issues
12:20 < jonasschnelli> gmaxwell: IMO its an upstream bug.
12:20 < harrymm> BlueMatt: best backtrace I have: https://pastebin.com/ZEZUhEDW
12:20 < wumpus> it's almost as if we have a lot of GUI issues and not many people working on the GUI :)
12:21 < sipa> jonasschnelli: i don't understand
12:21 < sipa> jonasschnelli: is it fixed, or is it an upstream bug?
12:21 < wumpus> both - upstream bug that is fixed
12:21 < jonasschnelli> the offscreen issue was present in our official 0.14.x bninaries while it's gone in our 0.15.0 binary
12:21 < gmaxwell> or "is it fixed" or "can't reproduce"?
12:21 < sipa> we're not talking about the offscreen issue...
12:21 < wumpus> let's discuss one issue at a time
12:21 < jonasschnelli> sipa: it is fixed,.. very likely in an upstream fix (could not track down the commit)
12:21 < wumpus> this is getting crazy
12:22 < sipa> jonasschnelli: then why are we getting reports?
12:22 < gmaxwell> jonasschnelli: what patch fixed it in 0.15?
12:22 < jonasschnelli> sipa: offscreen bug: could be because people compile with an Qt version below qt5.6?
12:22 < wumpus> we really need a test for the offscreen issue, right now we have *no* way to evaluate any fix
12:22 < wumpus> we could merge another PR that claims to fix it
12:22 < wumpus> but I'm kind of sick of that
12:22 < sipa> wait, i thought we were talking about the crash-at-startup issue?
12:22 < BlueMatt> https://github.com/bitcoin/bitcoin/blob/0.15/src/qt/sendcoinsdialog.cpp#L131 <-- the bug
12:22 < jonasschnelli> gmaxwell: I need to track it down. I just tested 0.14.1 and 0.15.0 on win7,8.1,10 and verfied that it is fixed in 0.15
12:23 < BlueMatt> ok, but lets be clear there are multiple bugs here
12:23 < achow101> BlueMatt: yay!
12:23 < jonasschnelli> sipa: sorry,... we slipped to the offscreen issue.
12:23 < sipa> okay, ignore me
12:23 < BlueMatt> the offscreen issue, which jonasschnelli believes to be fixed
12:23 < gmaxwell> jonasschnelli: what does verified that it's fixed in 0.15 mean?  Does that just mean you were unable to reproduce it at all? 
12:23 < BlueMatt> also the settings issue, which is L131 as above based on harrymm's backtrace
12:23 < wumpus> gmaxwell: yes, that means it
12:23 < jonasschnelli> gmaxwell: I set the window position by RegEdit to 3000,3000, 0.14 has the issue, 0.15 doens't
12:24 < achow101> BlueMatt: I don't see how there's a bug there
12:24 < wumpus> jonasschnelli: thanks for doing a sane, reproducible test :)
12:25 < jonasschnelli> 11171 is far more important
12:25 < gmaxwell> jonasschnelli: okay, but if the issue users are hitting is that the use positions the window in the bottom left of the screen (below task bar) then they'd still be hitting it... since the reproduction was synthetic.
12:25 < wumpus> I agree
12:25 < wumpus> crash bugs are more important, and this happens for a lot more users
12:25 < gmaxwell> I know that at least one of the users I helped during the RCs wasn't crashing (Because they had to kill bitcoin-qt in their task manager)
12:25 < jtimon> oops, I'm late
12:25 < jonasschnelli> gmaxwell: I can investigate again and report
12:25 < jtimon> yay 0.15!
12:26 < sipa> gmaxwell: sure, but there's only so much we can do
12:26 < gmaxwell> sipa: we could stop saving the position.
12:26 < wumpus> yes, ideally we should test all 8 areas outside the screen, something for an automated test
12:26 < wumpus> or just nuke the remember-position functionality
12:27 < jonasschnelli> my observation is that Qt handles offscreen situation pretty well... if a certain area of the window is offscreen, it re-centers.
12:27 < wumpus> the longer this remains an issue the more I'm tempted to the latter
12:27 < sipa> does -resetguisettings change anything but the remembered window coordinates?
12:27 < gmaxwell> jonasschnelli: QT5 but perhaps not QT4? (which, for example, the ppa uses, I believe)
12:27 < wumpus> sipa: yes, it clears all settings set through the gui optioins dialog
12:27 < jonasschnelli> It may kill your dbcache / proxy settings
12:27 < sipa> oh!     
12:27 < jonasschnelli> Oh. PPA / QT4
12:28 < achow101> Oh, I think I found harrymm's bug
12:28 < jonasschnelli> Yes. The issue is very likely present there...
12:28 < wumpus> as well as all other things the GUI remembers (there might be something in the send dialog with fee, I vaguely remember)
12:28 < gmaxwell> sipa: you missed earlier discussion, based on debuglog traffic achow has suggested its actually the proxy that is implicated in the crash.,
12:28 < jonasschnelli> I don't see a reason to do the PPA with Qt4?
12:28 < BlueMatt> achow101: yea, there's only one button in that group
12:28 < gmaxwell> sipa: I pointed out that 0.15 did change proxy handling (name lookup) but a cause of a crash isn't obvious there.
12:28 < sipa> gmaxwell: ah
12:28 < achow101> BlueMatt: I mean how different settings for nCustomFeeRadio cause a segfault
12:28 < jonasschnelli> Maybe we just add a failsafe: if offscreen then re-center... (but sounds simpler then it is)
12:28 < gmaxwell> the user in here with the crash on linux knows the function where the segfault happens for him (inside a qt button setting function)
12:29 < wumpus> achow101: interesting, so it might be the custom fee setting?
12:29 < BlueMatt> achow101: yes
12:29 < wumpus> achow101: I forgot about that one completely as it's not in the options dialog
12:29 < BlueMatt> wumpus: it appears to be a what-button-had-you-clicked-on-in-14.2 issue
12:29 < achow101> wumpus: yes
12:29 < achow101> I set nCustomFeeRadio=1 and that causes a segfault
12:29 < gmaxwell> oh we also changed the options for fees at some point in recent memory, could people have settings that made sense in 0.14 but not now?
12:29 < wumpus> gmaxwell: ouch
12:29 < sipa> achow101: nice catch
12:29 < gmaxwell> sounds like it.
12:29 < BlueMatt> we deleted a button
12:30 < jonasschnelli> could it happend by https://github.com/bitcoin/bitcoin/pull/10769?
12:30 < BlueMatt> there is only one button in that group
12:30 < gmaxwell> consistent with the segfault location that harrymm reported too
12:30 < BlueMatt> so it obviously segfaults
12:30 < morcos> well that was a productive first half of the meeting
12:31 < wumpus> so nCustomFeeRadio should be removed completely? or are there other settitngs?
12:31 < harrymm> good work :)
12:31 < gmaxwell> 0.15.1 next week? :P
12:31 < wumpus> debugging an issue during the meeting is kinda cool
12:31 < jonasschnelli> heh...
12:32 < sipa> bughunting-by-committee
12:32 < dgenr8> my money was on sinister alt clients
12:32 < gmaxwell> oh had nothing to do with sinister, just incompatible.
12:32 < sipa> where everyone forgets it's really achow101 who found it
12:32 < wumpus> sinister alt clients could have more custom fee settings, we should be robust against corrupt configuration in any case :)
12:32 < gmaxwell> thats the advantages of committess, one guy does all the work and everyone gets the credit! 
12:33 < achow101> lol     
12:33 < wumpus> haha good old USSR-style
12:33 < achow101> I found a way to reliably reproduce it
12:33 < gmaxwell> committees*
12:33 < achow101> which is the ncustomefeeradio thing, but I'm not sure what to do going forward
12:33 < sipa> achow101: i'm pretty sure that's the root cause
12:33 < wumpus> so how do we solve it?
12:33 < sipa> do we have to figure that out now?
12:34 < sipa> if there are no other topics, why not, i guess
12:34 < gmaxwell> achow101 will figure it out. our work here is done.
12:34 < wumpus> no, not really, I just wonder what is the use of a radio button with one option
12:34 < jonasschnelli> I'll can tackle the groupCustomFee segfault today
12:34 < wumpus> anyhow, any other topics?
12:34 < gmaxwell> wumpus: so you have the freedom to choose the Correct option, of course.
12:34 < instagibbs> any color car as long as it is black
12:34 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
12:35 < wumpus> gmaxwell: lol!
12:35 < gmaxwell> time to ford ahead.
12:35 < BlueMatt> ok, fix is easy, I'll get it fixed right after meeting
12:35 < achow101> jonasschnelli: great!
12:35 < wumpus> anything to discuss for 0.15.1?
12:35 < BlueMatt> https://github.com/bitcoin/bitcoin/commit/6ba2214e0fe57ecb9271819d2422ec44a9020a8d fixes it for now
12:35 < sipa> if there's nothing else; i have some open questions about segwit-by-default support in 0.15.1
12:35 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 240 seconds]     
12:35 < wumpus> #topic segwit-by-default support in 0.15.1
12:35 < BlueMatt> oh, wait, hmm
12:36 < sipa> my idea was to have a cmdline option to select a default address style, which could be p2pkh, p2sh-p2wpkh, or p2wpkh
12:36 < BlueMatt> or jonasschnelli can do it
12:36 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev     
12:36 < sipa> (where the middle one is default)
12:36 < sipa> and have an optional argument to getnewaddress to override it
12:36 < BlueMatt> sipa: seems reasonable?
12:36 < sipa> open question: separate option for change?
12:37 < instagibbs> imo yes
12:37 < BlueMatt> imo yes
12:37 < achow101> sipa: yes
12:37 < sipa> open question: do we want to return both p2wpkh and p2sh-p2wpkh (for now), as there is an efficiency gain when you want to give both to a peer
12:37 < sipa> downside: may not want we want to support longer term with split chains
12:37 < achow101> no, I think that will confuse people
12:37 < sipa> upside: more efficient to rescan
12:37 < instagibbs> I'd say no
12:37 < jonasschnelli> may confuse
12:38 < instagibbs> users who care will crank the option surely
12:38 < gmaxwell> we can't do that by default, interface breaking change.  If you want to call getnewaddress with style=gangnam and it returns both, that would be fine.
12:38 < achow101> style=gangnam <-- lol
12:38 < morcos> yep, i tested, running 0.14, setting the at least button, 0.15 crashes
12:39 < sipa> but style=gangnam would be pre-deprecated, and scheduled for removal in a future version
12:39 < morcos> oops was backlogged
12:39 < achow101> morcos: good to know that
12:39 < wumpus> hahahahaa
12:39 < BlueMatt> achow101: morcos also tested the 6ba2...fix from above, which fixed it, though the real fix isnt something that stupidly hacky
12:40 < sipa> ok, end of my topic
12:40 < cfields_> let's just let users decide with a 1-option combo-box :p
12:40 < gmaxwell> I'd say we could make the GUI show both too, except the URI/qr code can't really do that.
12:40 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has joined #bitcoin-core-dev     
12:40 < cfields_> er, radio
12:40 < sipa> cfields_: unary encoding, i like it
12:40 < morcos> wait, i'm confused
12:40 < morcos> are you serious about giving both addresses
12:40 < morcos> no, why would we do that
12:40 < BlueMatt> lets not do that
12:40 < BlueMatt> you could also just call getnewaddress twice
12:40 < BlueMatt> who cares
12:41 < gmaxwell> morcos: as an option. The reason is so you can say "here is the bech32 one if you can pay to it, otherwise use X"
12:41 < morcos> you should have a way of selecting which type of address you want for change or for getnewaddress
12:41 < morcos> then give them 2 different keys
12:41 < morcos> that's how it'll work in 0.16
12:41 < morcos> lets not try to be cheap and save a couple of keys and start teaching people that you can use one or the other
12:41 < sipa> BlueMatt: my wallet.dat barely fits on a 3.5" floppy disk anymore...
12:42 < cfields_> morcos: +1
12:42 < instagibbs> will there be an argument to getnewaddress to override?
12:42 < instagibbs> id hope so
12:42 < morcos> i agree that's a downside, but its more important to set the precedent that these thigns are NOT interoperable
12:42 < morcos> yes     
12:42 < sipa> instagibbs: i hope so, yes
12:42 < instagibbs> ok, then that's fine
12:42 < gmaxwell> okay... when I talked to sipa about it my objection was that we couldn't support it in the future. his counter was that we don't have to offer it in the future.
12:42 < instagibbs> i prefer
12:42 < BlueMatt> somehow I doubt bdb is useable on floppy-latency disks anyway :p
12:42 < gmaxwell> instagibbs: yes, there would be an option, setting would just set the default.
12:43 < instagibbs> then I see no reason to return both
12:43 < wumpus> yes,we need to make it very clear they're not interoperable, that you can't, in general just convert the one to the othe and have it work
12:43 < BlueMatt> then require two getnewaddress calls
12:43 < sipa> sounds good, you need to call getnewaddress twice
12:43 < sipa> ack     
12:43 < achow101> +1     
12:43 < sipa> no gangnam
12:44 < morcos> also in the scheme of things, each 0.15.1 wallet is wasting 2000 + N * (# getnewaddress calls) + (# changes) keys.... where N is 2 if you do what I want (only in the cases where you give out both) or 1 if you do what you want
12:44 < morcos> it makes no difference relatively speaking for almost all users
12:44 -!- promag [~promag@2001:8a0:fe30:de01:908f:a1d4:1d5e:9414] has quit [Ping timeout: 255 seconds]     
12:45 < jtimon> wumpus: ack on removing remember position functionality until we can test it automatically
12:45 < gmaxwell> jtimon has the gribble disease.
12:45 < wumpus> jtimon: that'd make sense, I guess
12:46 < gmaxwell> (20 minutes behind. :) )
12:46 < wumpus> seems the segwit-by-default topic is conclded, anything else?
12:47 < gmaxwell> I think we need to announce a workaround for this issue we all collectively figured out through our joint effort where no one person did all the work during the meeting.
12:47 < wumpus> haha yes gribble's behavior seemed very curious and random, before I realized it was just backlogged (or rather, github was?)
12:47 < BlueMatt> yes, do we have a mechanism for release errata?
12:47 < wumpus> or make a 0.15.0.1
12:48 < BlueMatt> given the ppa is still not up (cause arm qt...) I'll probably ship that with the hacky workaround patch posted above
12:48 < BlueMatt> unless there are objections
12:48 < wumpus> did you manage to debug the ARM qt issue? I'm curious
12:48 < wumpus> no objections, if you can patch it in your distro, do so
12:48 < wumpus> it's zero risk...
12:48 < BlueMatt> there appear to now be at least two separate issues, a miscompile, and I now have a stacktrace for another test_bitcoin-qt fail that I'm looking at now
12:48 < achow101> BlueMatt: I believe (not tested yet) that you can just remove L131 entirely
12:48 < sipa> let's fix the things at least in the 0.15 branch
12:49 < gmaxwell> I won't ack 0.15.0.1 because I do none of the required work for it but it might be nice.
12:49 < sipa> then depending on progress we can see whether it goes in 0.15.1, or if a 0.15.0.1 may be needed (at release manager's discretion...)
12:49 < wumpus> achow101: possibly, but BlueMatt's fix is obviosuly correct, a better fix is to just remove the setting completely
12:49 < BlueMatt> achow101: well the commit linked above works, so whatever
12:49 < wumpus> achow101: and the single-choice radio button
12:49 < gmaxwell> what sipa said
12:49 < wumpus> but for a quick hack that change is good
12:49 < morcos> in master can we please fix properly, remove the whole group
12:49 < wumpus> yes     
12:50 < sipa> yes     
12:50 < achow101> yes     
12:50 < gmaxwell> yes     
12:50 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 252 seconds]     
12:50 < gmaxwell> someone will need to contemplate how to prevent this kind of issue in the future.
12:50 < wumpus> well yes let's fix it on the branch then decide whether to do 0.15.0.1
12:51 < wumpus> better testing of the gui is the only answer
12:51 < achow101> gmaxwell: fuzz the qsettings options :)
12:51 < instagibbs> remove all features until qt is a single button
12:51 < jonasschnelli> Better GUI tests... but more important, "upgrade tests"
12:51 < gmaxwell> "moon"
12:51 < wumpus> hah     
12:51 < jonasschnelli> Non of our test do cover upgrade of wallets, etc.
12:51 < gmaxwell> (responding to instagibbs)
12:52 < instagibbs> jonasschnelli, hmm good point
12:52 < jonasschnelli> Upgrade tests would probably require static data files from older versions.... 
12:52 < wumpus> well at least the reduced one radio buttons group to one button, that's a start...
12:52 < morcos> was fuzz qsettings a joke?   i did that with the fee estimation changes manually, i think thats a good idea
12:52 -!- fpgaminer [~fpgaminer@cpe-172-90-105-203.socal.res.rr.com] has quit [Quit: Leaving]     
12:52 < wumpus> s/the/we/
12:52 < achow101> morcos: not really
12:52 < wumpus> no, it's not a joke, it'd help with robustness against corrupt configs a lot
12:53 < morcos> ok, the smiley threw me
12:53 < wumpus> but as we're not even fuzzing bitcoin.conf settings yet
12:53 < achow101> but it would mean a lot more changes since weird shit in qsettings totally screws up qt
12:53 < morcos> ha ha, fuzzing bitcoin.conf DEFINITELY breaks things
12:53 < achow101> we would need better bad-setting rejection
12:53 < wumpus> gui testing is always at least 3 times as much work
12:53 < jtimon> sipa: yeah, both formats seems like un ugly optimization. Doesn't look like it's worth it
12:54 < gmaxwell> sipa: I think he's still 20min behind.
12:54 < jonasschnelli> Not sure if fuzzing qt-settings (QSettings) make sense. It's not a file edited by users
12:54 < morcos> is jtimon working on-site on the blockstream Mars project
12:54 < BlueMatt> jtimon: is stuck on moon
12:54 < jtimon> gmaxwell: well, I arrived 30 mins late
12:54 < jonasschnelli> Fuzzing peers.dat or similar would also make little sense I guess
12:54 < wumpus> jonasschnelli: but it can get corrupt, like anything
12:54 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev     
12:54 < wumpus> though I agree there's a limit
12:54 < instagibbs> that would at least test it handles corrupted files right
12:55 < instagibbs> recently ran into a case where we werent
12:55 < jonasschnelli> Corrupt files should be handled by Qt IMO
12:55 < morcos> usually with bitcoin.conf we don't change the meaning of the options (cough cough sipa)
12:55 < jonasschnelli> The file itself is hidden on our application layer
12:55 < jonasschnelli> We just deal with QSettings
12:55 < morcos> we could be better about making sure we rename options in QT if we are goign to change their meaning
12:55 < wumpus> yes     
12:56 < wumpus> much, much better to lose the setting than crash
12:56 < jonasschnelli> morcos: yes!
12:56 < wumpus> unless it's soomething like the proxy
12:56 < wumpus> but a nicety like remembering the fee setting? nah
12:56 < jtimon> 0.15.0.1 ? why not 15.0.1 directly and we stop writing the 0. prefix now? /me hides
12:56 < jonasschnelli> I don't understand why the crash does not happen on OSX (could only reproduce on Linux)
12:57 < wumpus> likely the implementation of radio button group is different there
12:57 < wumpus> making it return e.g. a dummy object instead of corruption or null when reading out of range
12:57 < wumpus> macosx users just got lucky
12:58 < sipa> wumpus: we have occasionally had x.x.x.1 released for bugfixes that affect just some platforms
12:58 < sipa> *releases
12:58 < instagibbs> 2 minutes
12:58 < morcos> one could argue they were silently forced to lose their at least setting which made them erroneously pay the wrong fees
12:58 < wumpus> sipa: yes, I wouldn't like to burn 0.15.1 on this mainly
12:58 < sipa> wumpus: agreed
12:58 < jtimon> finally catched up...to late to suggest a topic, but perhaps we can talk about it after the meeting
12:59 < jtimon> is about an index for scriptPubKeys
12:59 < wumpus> yes, we're done for today
12:59 < wumpus> #endmeeting
12:59 < lightningbot> Meeting ended Thu Sep 14 19:59:45 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:59 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-09-14-19.00.html
12:59 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-09-14-19.00.txt
12:59 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-09-14-19.00.log.html
12:59 < achow101> ok bye. laptop is about to die
12:59 < jtimon> https://github.com/bitcoin/bitcoin/pull/9806 seems abandoned
13:00 < wumpus> jtimon: you mean of the utxo set?
13:00 < jtimon> how acceptable would be to maintain a scriptPubKey -> [list of outpoints using it] index ?
13:01 < jtimon> wumpus: well, spent outputs could be removed from the index or not
13:01 < wumpus> nack on a global index, concept ack on such an index over the UTXO set, would make it so easy to query any balance
13:01 < jtimon> perhaps with an option, or perhaps it's only acceptable for the utxo
13:02 < sipa> yeah, please no indexes that require the full chain
13:02 < wumpus> exactly
13:03 < adiabat> address index over utxo would be fun, I'd enable & use that
13:03 < jonasschnelli> ui->groupCustomFee->button((int)std::max(0, std::min(1, settings.value("nCustomFeeRadio").toInt())))->setChecked(true); <--- pretty fragile
13:03 < jonasschnelli> button() can return a nullptr
13:03 < adiabat> probably not too huge either
13:03 < jtimon> well, my thought was give an option -deletespent or something of the short, if you start using the index, it starts with an utxo at a given height, if you select the option, it conserves spent outputs but won't go to the past: if you want it full you need to reorg
13:03 < jonasschnelli> calling setChecked() on a nullptr won't crash OSX but does segfault (correctly) on linux
13:04 < BlueMatt> jonasschnelli: uhhhhhhh
13:04 < BlueMatt> I hope not?
13:04 < jtimon> but perhaps that's not acceptable either, anyway, thanks wumpus sipa that's useful to know
13:04 < jonasschnelli> Yeah.. seems strage... maybe a local issue.. it should crash
13:04 < wumpus> does it really return null when out of range though on osx?
13:05 < wumpus> or some softly padded dummy object
13:06 < cfields_> jonasschnelli: huh, i just saw something related to that in a recent qt changelog
13:08 < cfields_> jonasschnelli: no clue if related. not as relevant as i was thinking: https://bugreports.qt.io/browse/QTBUG-59391
13:08 < jonasschnelli> cfields_: thanks... will check later (on the run)
13:09 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (master...2017/09/qsettings_1) https://github.com/bitcoin/bitcoin/pull/11332
13:11 < BlueMatt> jonasschnelli: I really dont think thats the right fix...groupCustomFee literally only contains one button now
13:11 < BlueMatt> jonasschnelli: better to just literally remove groupCustomFee and the button wholesale
13:11 < BlueMatt> as well as delete the nCustomFeeRadio setting
13:11 < gmaxwell> there are a half dozen places in the code where we ->button()->foo
13:11 < gmaxwell> fwiw
13:13 < achow101> Report of possibly same bug on osx: https://bitcointalk.org/index.php?topic=2132893.msg21842556#msg21842556 from droark
13:15 < jonasschnelli> BlueMatt: yes. Agree. I just created the minimal possble fix (for backports).
13:15 < BlueMatt> jonasschnelli: see my above patch which I think is maybe cleaner if we're looking at backports
13:15 < BlueMatt> s/maybe//
13:15 < BlueMatt> but whats the harm in fixing it right for 0.15.1?
13:17 < jonasschnelli> BlueMatt: sorry,... where is your patch?
13:17 < BlueMatt> <BlueMatt> https://github.com/bitcoin/bitcoin/commit/6ba2214e0fe57ecb9271819d2422ec44a9020a8d fixes it for now
13:17 < wumpus> bluematt's is the minimum possible - just make it always use button(0)
13:18 < jonasschnelli> BlueMatt: wumpus: okay. Makes more sense!... BlueMatt: do you pr?
13:18 < jonasschnelli> Or should I update my PR?
13:18 < sipa> minimal patch is "std::min(1, " -> "std::min(0, "
13:18 < sipa> :p     
13:18 < jonasschnelli> heh     
13:19 < wumpus> hah... yes, good point
13:20 < wumpus> that would have been the obvious correct fix too if the number of buttons was reduced to something else than 1
13:21 < BlueMatt> jonasschnelli: can we please just delete the buttons?
13:21 < BlueMatt> jonasschnelli: I see absolutely no harm in simply removing the group/button for 0.15.1
13:22 < achow101> I think removing the group is the right way to go here
13:22 < BlueMatt> (this is why i did not open my pr)
13:24 < wumpus> removing the whole group is a riskier change, though, it could potenitally introduce new issues
13:24 < wumpus> which is the right thing for master
13:24 < wumpus> but maybe not for 0.15.0.1 or w/e
13:24 < BlueMatt> hmm, alright up to you
13:24 < BlueMatt> i can pr mine against 15 if you like
13:26 < jonasschnelli> BlueMatt: remove for 0.16 is okay... but for a backport?
13:26 < BlueMatt> i figured it was fine, but...up to y'all
13:27 < achow101> Removing it could be backported to 0.15.1. for 0.15.0.1, BlueMatt's hack should be fine
13:27 < BlueMatt> wait, are we doing an 0.15.0.1?
13:27 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rkvowqyvcztbilar] has joined #bitcoin-core-dev     
13:29 < achow101> Are we?
13:32 < jonasschnelli> okay,... overhauled #11332
13:32 < gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
13:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
13:33 < jonasschnelli> BlueMatt: I'm trying to cherry-pick your https://github.com/bitcoin/bitcoin/commit/6ba2214e0fe57ecb9271819d2422ec44a9020a8d to keep you as author
13:33 < sipa> jonasschnelli: you can use git commit --author="..."
13:33 < sipa> if cherry picking is too hard, but you still want to retain author
13:33 < jonasschnelli> sipa: Oh... didn't knew you can.
13:34 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hzwfofpvoxikyzma] has joined #bitcoin-core-dev     
13:34 < jonasschnelli> I guess the signature does not matter
13:34 < sipa> if you're cherry picking, the gpg signature is removed anyway
13:34 < sipa> (as it would be invalid)
13:34 < jonasschnelli> Oh. Right
13:34 < jonasschnelli> hash will change
13:35 < MarcoFalke> You can still sign the cherry-pick with your key, if you prefer that
13:35 < BlueMatt> heh, for that fix I dont really care
13:35 < BlueMatt> we all figured out the bug live during meeting anyway
13:35 < BlueMatt> group effort :)
13:35 < jonasschnelli> Okay. Retained authorship: https://github.com/bitcoin/bitcoin/pull/11332/commits
13:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
13:45 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 255 seconds]     
13:46 < achow101> I'm not sure if that solves 11171. The op tells me that he doesn't remember having that option set
13:50 < meshcollider> 11171 was a segfault in QTableView::setSortingEnabled
13:50 < meshcollider> This sounds unrelated to that?
13:51 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Ping timeout: 260 seconds]     
13:52 < meshcollider> #11262 has 2 separate issues in it, one in the OP and one in the comments, I think they're different
13:52 < gribble> https://github.com/bitcoin/bitcoin/issues/11262 | bitcoin-qt segmentation fault · Issue #11262 · bitcoin/bitcoin · GitHub
13:53 < meshcollider> Or at least probably a separate issue to 9683 and 9883
13:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
14:02 < achow101> Meshcollder: I think you are talking about 11262
14:02 < achow101> Not 11171
14:02 < luke-jr> setSortingEnabled is a distraction: the crash is "free(): invalid next size (fast)" which indicates corrupt memory before it got there
14:02 < luke-jr> it could very well be 11332-related
14:03 < luke-jr> the only way to confirm is valgrind
14:03 < luke-jr> (on an affected system)
14:05 < jnewbery> jonasschnelli: (slightly delayed) you can also `get commit -C <hash>` if you want to retain the entire commit message including author - and there's no risk of mistyping the author's name
14:05 < jnewbery> s/get/git
14:06  * luke-jr learns uppercase -C skips the editor.
14:06 -!- ShaunR [~ShaunR@freenode/sponsor/NDChost.com] has joined #bitcoin-core-dev     
14:06 < achow101> Git has a lot of fun options that most people don't know about
14:07 < luke-jr> I'm probably the only one in the world who uses git write-tree <.<
14:07 < achow101> What's that?
14:07 < luke-jr>        git-write-tree - Create a tree object from the current index
14:08 < luke-jr> typically followed by git commit-tree
14:08 < luke-jr> in my case, I do this sequence to produce commits with more than 2 parents
14:08 < ShaunR> Has anybody ever proposed making bitcoind's blocknotify and walletnotify options support a URL?  So you could set -blocknotify="https://domain.com/bitcoind/notify/block.php" and have it POST %s?  I'm thinking about attempting to write that functionallity into bitcoind but unsure if anyone else would find it useful or if the devs would even consider adding it.
14:09 < luke-jr> ShaunR: -blocknotify='curl https://domain.com/bitcoind/notify/block.php?hash=%s'
14:09 < luke-jr> probably a trivial way to make it POST too
14:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
14:09 < ShaunR> luke-jr: thats true, you could do something like that i guess.
14:09 < ShaunR> I was thinking about making it a bit more elaborate, like if the POST failed to queue the notification or something.
14:10 < luke-jr> could make blocknotify retry if the exit code is non-zero?
14:10 < ShaunR> but your solution may be the simplist right now.
14:10 < luke-jr> but tbh, retry logic could be outside too
14:11 < ShaunR> I wanted to avoid the requirement of a outside script/binary too
14:12 < esotericnonsense> yes, you could create an external script that queues notifications to do stuff with
14:12 < luke-jr> ShaunR: avoiding that requirement, is not a design goal IMO
14:12 < esotericnonsense> it'd probably be easier to use the zmq notification for that, just listen on it, add new entries to a queue, periodically try and flush the queue into this post mechanism
14:12 -!- riemann [~riemann@ip-222-88.ists.pl] has joined #bitcoin-core-dev     
14:13 < luke-jr> ShaunR: better to run as little code in the security-critical process as possible
14:13 < esotericnonsense> indeed, it's not really bitcoind's responsibility
14:13 < luke-jr> esotericnonsense: ZMQ is good at losing notifications
14:14 < esotericnonsense> luke-jr: using IPC? tcp over seperate machines, perhaps
14:15 -!- riemann [~riemann@ip-222-88.ists.pl] has quit [Client Quit]     
14:15 < esotericnonsense> regardless of whether you use zmq or not it's similarly easy though :)
14:16 < achow101> harrymm: do you have a debug.log file from the time of the crash?
14:17 < esotericnonsense> from #bitcoin:  dingus | TYPO at the very top of https://bitcoin.org/en/release/v0.15.0 "14 October 2017" <- It's not October, yet, I hope
14:17 < luke-jr> ‎[21:11:33] ‎<‎dingus‎>‎ TYPO at the very top of https://bitcoin.org/en/release/v0.15.0 "14 October 2017" <- It's not October, yet, I hope
14:17 < luke-jr> yeah
14:17 < achow101> Lol     
14:20 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
14:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
14:27 < kakobrekla> does `addwitnessaddress` work with watch-only addresses?
14:27 < sipa> yes     
14:28 < kakobrekla> cool!
14:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
14:28 < sipa> kakobrekla: however, if it isn't, you can still use importaddress on the result
14:28 < sdaftuar> sipa: only if its solvable, right?  isn't it possible to have a watch-only address that is not solvable?
14:29 -!- molz [~molly@unaffiliated/molly] has quit [Quit: ZNC 1.6.5 - http://znc.in]     
14:30 < sipa> right
14:30 < BlueMatt> 11326 likely needs 0.15 backport, no?
14:30 < wbnns> @esotericnonsense @lukejr Submitted #1803 to fix the typo.
14:30 < gribble> https://github.com/bitcoin/bitcoin/issues/1803 | Apply MIT license to md2k7 art by luke-jr · Pull Request #1803 · bitcoin/bitcoin · GitHub
14:31 < esotericnonsense> actual url (wrong repo): https://github.com/bitcoin-dot-org/bitcoin.org/pull/1803
14:31 < wbnns> @esotericnonsense Thanks.
14:32 < esotericnonsense> you too :)
14:32 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
14:32 < wbnns> :)     
14:48 < bitcoin-git> [bitcoin] danra opened pull request #11333: Use `std::nth_element` instead of `std::sort` to calculate median time past (master...improve/median-time-past) https://github.com/bitcoin/bitcoin/pull/11333
15:01 -!- wxxs [~chatzilla@89.238.178.90] has quit [Ping timeout: 255 seconds]     
15:07 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
15:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
15:54 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
15:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer]     
15:55 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 240 seconds]     
15:55 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
15:55 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev     
16:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
16:07 -!- tloriato [bb6c2f72@gateway/web/freenode/ip.187.108.47.114] has joined #bitcoin-core-dev     
16:09 < tloriato> Hello! I was looking for how I could import a BIP32 Extended Key into the Bitcoin Core wallet? I've tried the RPC Documentation but got no luck there.
16:09 < sipa> you can't
16:09 < tloriato> So I have to derive each desired path using another lib and import it with WIF? 
16:10 < sipa> for now, yes
16:11 < tloriato> thank you, sipa
16:12 < tloriato> oh, one more thing, sorry! bitcoin core uses m/0'/0'/k' for derivation path
16:12 < tloriato> is there a way I could request a new address from an arbitrary path from the rpc?
16:13 < tloriato> or at least associate one i ( m/0'/i'/k' ) for one account?
16:13 < sipa> no, new addresses come from the keypool, which is preloaded with keys from one chain
16:13 < sipa> in 0.15, there are two chains (one for normal addresses, one for change)
16:13 < sipa> and no, you can't configure the path - especially not for accounts, which are deprecated
16:14 < tloriato> Well, I think I have the information that I need now.
16:14 < tloriato> Thanks sipa, it was really helpful
16:14 < sipa> yw     
16:15 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds]     
16:19 < tloriato> sipa in which cases does the bitcoin wallet changes the i from the path?
16:20 < tloriato> ( for reference m/0'/i'/k' )
16:20 < sipa> i=0 for normal addresses, i=1 for change
16:21 < tloriato> oh, ok! thanks
16:24 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]     
16:28 -!- tloriato [bb6c2f72@gateway/web/freenode/ip.187.108.47.114] has quit [Ping timeout: 260 seconds]     
16:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
16:34 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
16:48 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev     
16:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:57 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 255 seconds]     
16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:18 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again]     
17:19 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
17:20 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
17:27 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds]     
17:28 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]     
17:28 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev     
17:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
17:58 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
18:01 -!- harrymm [~wayne@85.203.47.64] has quit [Ping timeout: 260 seconds]     
18:05 -!- harrymm [~wayne@85.203.47.53] has joined #bitcoin-core-dev     
18:12 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 240 seconds]     
18:14 -!- clarkmoody [~clarkmood@47-218-249-135.bcstcmta04.res.dyn.suddenlink.net] has quit [Read error: Connection reset by peer]     
18:14 -!- clarkmoody [~clarkmood@47-218-249-135.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev     
18:16 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
18:19 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hzwfofpvoxikyzma] has quit [Quit: Connection closed for inactivity]     
18:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
18:51 -!- alxlu [~alxlu@138.68.58.104] has joined #bitcoin-core-dev     
18:52 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
18:55 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
19:04 -!- fluidjax [~fluidjax@host86-146-140-3.range86-146.btcentralplus.com] has quit [Ping timeout: 264 seconds]     
19:05 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
19:06 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 240 seconds]     
19:25 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
19:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]     
19:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
20:09 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds]     
20:14 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]     
20:31 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
20:36 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
20:38 -!- bane5000 [~bane@c-71-57-140-3.hsd1.fl.comcast.net] has joined #bitcoin-core-dev     
20:54 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Changing host]     
20:54 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev     
20:57 < achow101> was there any agreement on whether there would be a 0.15.0.1 with BlueMatt's fix for the customfeeradio thing?
20:58 < gmaxwell> No soap radio.
20:59  * luke-jr thinks it'd be better to do 0.15.1 with a few more fixes
20:59 < gmaxwell> achow101: I think the plan right now is that we will fix things and get them into the 0.15 branch ASAP, then wladimir will decide to do a release or not.
21:00 < achow101> ok     
21:00 < achow101> I'm working on the permanent fix right now
21:01 < luke-jr> ie removing the radio entirely?
21:01 < gmaxwell> luke-jr: what other moderately important things are there that we know of now
21:01 < achow101> luke-jr: yes
21:02 < luke-jr> gmaxwell: if it was important, it'd have blocked 0.15.0; is there a reason *not* to backport the GUI positioning fix & similar stuff, if we're doing another RC cycle?
21:03  * luke-jr wonders what changed with PPA stuff to break the build there.
21:03 < gmaxwell> oh did we make a post 0.15 positioning fix too
21:03 < achow101> I don't think so
21:03 < luke-jr> #11208 ?
21:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11208 | Fixing offscreen GUI issue by MeshCollider · Pull Request #11208 · bitcoin/bitcoin · GitHub
21:03 < achow101> I thought that was determined to not be a problem by jonasschnelli 
21:04 < achow101> I believe the problem was I was testing on either an old version or with custom something that gave me the error
21:04 < achow101> s/error/issue
21:04 < jonasschnelli> achow101: it may be a problem for the PPA.
21:04 < jonasschnelli> From what I knew so far was that the offscreen issue only affected windows
21:05 < luke-jr> gitian binaries are not the only supported (or even preferred) deployment..
21:05 < gmaxwell> I believe there are still problems. Go position the window as far down and left as you can, then restart... But perhaps for 0.15.0.1 we would just disable remembered position rather than twiddling around with it.
21:05 < jonasschnelli> Offscreen situations are usually handled by the OS
21:06 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving]     
21:06 < jonasschnelli> stop remembering position would be reducing a feature for a few having problem with it.
21:06 < gmaxwell> Yes, but the feature is minor (the software already takes a very long time to start) and the issue is very severe.
21:07 < gmaxwell> I'm not saying that I think it should go away forever.
21:07 < jonasschnelli> Some users arrange windows pixel by pixel.. :)
21:08 < gmaxwell> But if we want to make a quick release it would be an easy way to prevent it from being a problem for sure.
21:09 < meshcollider> 11208 checks for full window inclusion on the screen, and uses available screen geometry not full screen so that whatever taskbars or things dont get in the way either
21:09 < meshcollider> so I think its still an improvement even if the original issue is gone
21:10 < gmaxwell> meshcollider: that sounds like the right thing to do.  But also sounds like it deserves non-trivial testing with weird setups.
21:10 < bitcoin-git> [bitcoin] achow101 opened pull request #11334: Remove custom fee radio group and remove nCustomFeeRadio setting (master...rm-nCustomFeeRadio) https://github.com/bitcoin/bitcoin/pull/11334
21:10 < jonasschnelli> gmaxwell: I just moved the windows as far down as possible and it reopened there... is that a problem?
21:10 < jonasschnelli> Same happends to notepad.exe
21:10 < jonasschnelli> *happens
21:11 < jonasschnelli> (Windows 8.1)
21:12 < gmaxwell> can you get it back out of that position again
21:13 < jonasschnelli> Yes.
21:13 < jonasschnelli> (Testing 0.15)
21:13 < luke-jr> what if you use the keyboard to move it such that the titlebar isn't visible?
21:13 < bane5000> so i've enabled pruning on my core wallet (by creating bitcoin.conf in ~/.bitcoin/) and adding pruning=10000
21:14 < bane5000> i've restarted the bitcoin-qt, however, the old blocks do not seem to be disappearing, as my harddrive space has not been reduced
21:14 < luke-jr> bane5000: you mean prune=10000 ? note that user issues should be in #bitcoin though
21:14 < gmaxwell> e.g. if your screen is 1920x1080, what happens if the location is 1919,1079
21:14 < bane5000> luke-jr: Whoopsy :)
21:15 < bane5000> luke-jr: Would you recommend keeping a certain amount of blocks? Perhaps 20 gigs? 
21:15 < luke-jr> bane5000: #bitcoin please
21:15 < bane5000> ugh :( 
21:15 < bane5000> You probably give a better opinion though, but fine
21:16 < luke-jr> I'm there too
21:16 < jonasschnelli> gmaxwell: I guess you can only position to right-bottom -1,-1 with rededit.exe
21:16 < bane5000> okay :)
21:16 < jonasschnelli> IMO it reacts as expected and identical to any other window based windows application
21:17 < gmaxwell> jonasschnelli: I think you could do so pretty easily like this: increase your resolution, position it to the right bottom of your lower resolution, decrease resolution.
21:17 < gmaxwell> Though there may be other ways to end up there.
21:17 < meshcollider> but its not practical if it appears mostly offscreen, having to manually move it, even if thats what other windows do
21:18 < jonasschnelli> gmaxwell: I did change the screen size and it relocates to center at a certain point.
21:18 < jonasschnelli> Maybe (like in a flexible screen size vm like I test in) you can end up by only showing a single pixel of the window... but I guess the OS makes sure you always see the left-top icon
21:19 < jonasschnelli> However, I think this is not a problem anymore in 0.15 gitian binaries...
21:19 < gmaxwell> if the OS does then thats probably sufficient, but then I don't understand how we ended up completely off the screen.
21:19 < jonasschnelli> I'm unsure about compiling it manually ... though I'm not sure how you would do this on windows
21:19 < gmaxwell> jonasschnelli: we still support QT4 and earlier QT5 too.. it's not fixed unless we have a workaround or refuse to build with incompatible versions.
21:20 < jonasschnelli> gmaxwell: completely off the screen with 0.15 gitian binaries on Windows seems very unlikely (I could not reproduce it and I tried for 1-2 h)
21:20 < jonasschnelli> gmaxwell: I agree about Qt4. But I don't think anyone builds a Windows binary without our depends system. It would be a nightmare
21:20 < gmaxwell> maybe for windows you could argue to ignore anything but gitian but we could end up off screen on linux too.. can't we
21:21 < achow101> is qt4 supported only for the ppa?
21:21 < jonasschnelli> I have testes offscreen on Ubuntu 14, 16 and could also not reproduce it (by fiddling with the QSettings to set if offscreen). But possible for Qt5.
21:21 < jonasschnelli> Qt4, I meant
21:22 < jonasschnelli> achow101: I think BlueMatt has a reason to build it against Qt4... some KDE or something
21:22 < luke-jr> jonasschnelli: testing merely Ubuntu is not meaningful.. there are many WMs, and Ubuntu only uses one or two
21:23 < jonasschnelli> luke-jr: Yes. I agree. But IMO this is why we use Qt. Offscreen is either a OS thing or a QT thing.
21:23 < luke-jr> I suppose testing without a WM (X11 and Wayland?) might be a good approach
21:23 < jonasschnelli> If we are going to add patch for every WM, we will have a horrific cross-platform source code base 
21:23 < jonasschnelli> *add patches
21:24 < luke-jr> I don't see why that'd be necessary
21:24 < luke-jr> fixing it for the dumb-WM-with-no-protection should fix it for all
21:24 < jonasschnelli> Offscreen seems very upstreamish... we (or someone else) need to fix it there (if its really an issue)
21:24 < luke-jr> that assumes we're using upstream correctly
21:24 < gmaxwell> saving location _at all_ seems upstreamish, but we have an implementation of that-- it seems to me that if we're implementing it, we're probably stuck implementing it completely.
21:25 < jonasschnelli> I'm happy to review a patch... but quick-cross-platform fixed did turn out to be much more complicated then often initially intended
21:25 < luke-jr> gmaxwell: +1
21:25 < jonasschnelli> gmaxwell: Indeed
21:26 < jonasschnelli> related: http://doc.qt.io/qt-4.8/restoring-geometry.html
21:27 < jonasschnelli> Document still available in the Qt5.9 docs: http://doc.qt.io/qt-5/restoring-geometry.html
21:27 < achow101> jonasschnelli: can we not just do that then to support the fix for qt4 and 5?
21:27 < jonasschnelli> achow101: do what?
21:28 < meshcollider> Should I modify 11208 to just call restoreGeometry 
21:28 < luke-jr> we should investigate if Qt actually implements it sanely
21:28 < achow101> jonasschnelli: whatever those pages say to restore geometry
21:29 < meshcollider> Those pages suggest either using restoreGeometry OR doing it how 11208 does it I believe
21:29 < luke-jr> "The restore function also checks if the restored geometry is outside the available screen geometry, and modifies it as appropriate if it is:" sounds hopeful
21:29 < jonasschnelli> achow101: Yes. We should update to restoreGeometry... maybe this does internally check the bounds.
21:29 < jonasschnelli> Seems the much better approach then fiddling with the position (which is what Qt is supposed to do)
21:30 < jonasschnelli> luke-jr: +1
21:31 < jonasschnelli> Yes should replace our own saveWindowGeometry/restoreWindowGeometry with the Qt ones (not directly possible for the save)
21:32 < gmaxwell> I wonder how this stuff interacts with -geometry
21:32 < achow101> jonasschnelli: I tried with gmaxwell's suggestion of 1919,1079 and the window is definitely not visible on screen
21:33 < jonasschnelli> achow101: via regedit.exe?
21:33 < achow101> yeah
21:33 < jonasschnelli> 0.15.0 gitian binaries?
21:33 < achow101> yes, from bitcoin.org
21:33 < jonasschnelli> What happens if you place then +2 px?
21:35 < jonasschnelli> achow101: Maybe this is the expected behavior: if you place the window in screen (manually with RedEdit.exe), you want to reopen there? To hit this by accident seems very unlikely
21:35 < gmaxwell> jonasschnelli: I explained before. If you increase your resolution, position there. Shut down bitcoin. Reduce resolution.  You will be in this state.
21:35 < jonasschnelli> gmaxwell: That's a different issue.. that is solved.
21:35 < luke-jr> …     
21:35 < gmaxwell> It's a hard state to get into, but then "my bitcoins are gone!"   -- a typical user will not be able to recover without a tech guru friend at least.
21:35 < jonasschnelli> achow101: placed it in-screen (-1,-1)
21:36 < luke-jr> jonasschnelli: you can get (1919,1079) the way gmaxwell describes
21:36 -!- harrymm [~wayne@85.203.47.53] has quit [Ping timeout: 248 seconds]     
21:36 < jonasschnelli> luke-jr: how?
21:36 < luke-jr> jonasschnelli: try to position it on the second monitor without snapping
21:36 < achow101> jonasschnelli: anything that is technically on screen like 1919,1079 will not be fixed. but the user can't get to it
21:37 < jonasschnelli> luke-jr: Thats indeed a viable argument
21:37 < jonasschnelli> But wait...
21:37 < gmaxwell> jonasschnelli: with a higher resolution you can easily drag to 1919,1079 (for example). 
21:37 < achow101> jonasschnelli: I increased the position so that I could see it. most of the window is off screen, but the corner that matters is
21:37 < achow101> it can easily be covered up by the taskbar too so users can't get to it
21:37 < jonasschnelli> I wonder how other applicationes (test Notepad.exe) would react in this case
21:38 < luke-jr> stupidly IIRC
21:38 < gmaxwell> (and there is probably a few pixel radius which is totally inaccessible but technically on the screen where the current behavior is not sufficient. But meshcollider's or hopefully QT's would be.
21:38 < gmaxwell> Even if notepad is wrong (would be interesting to find out!) that still doesn't excuse bitcoin-- losing notepad is less serious then your wallet. :)
21:38 < achow101> jonasschnelli: it does exactly the same thing; so long as the top left corner is technically on screen, it stays there
21:39 < luke-jr> we can actually continue saving as we do now, but after restoring, call restoreWindowGeometry(saveWindowGeometry())…
21:39 < luke-jr> gmaxwell: but my metadata!
21:39 < meshcollider> Somethign like this: https://github.com/MeshCollider/bitcoin/commit/e70a784486fdda12a8a949dbb3f5fe5ea1054511
21:39 < jonasschnelli> I think we should update our codebase to use the Qt designated functions for restoring geometry (also available on Qt4) and see if this is better,.. then decide to patch this edge-case explicit in our codebase
21:39 < meshcollider> havent tested yet though
21:39 < jonasschnelli> achow101: you mean with Notepad.exe?
21:39 < gmaxwell> yea, well I think we have a target edge case to test now. Hopefully QT does the right thing.
21:40 < achow101> jonasschnelli: yes
21:40 < jonasschnelli> I'm still convinced that this issue needs to be fixed in the cross-platform layer (Qt) rather then in the application GUI logic
21:41 < jonasschnelli> I saw many cross-platform projects struggle after adding to much cross-platform UI patches and glitch-foixes
21:41 < jonasschnelli> *fixes
21:41 < achow101> jonasschnelli: it shouldn't be a problem if we use the Qt sanctioned method, no?
21:42 < jonasschnelli> achow101: you mean http://doc.qt.io/qt-5/qwidget.html#restoreGeometry?
21:42 < bitcoin-git> [bitcoin] MeshCollider opened pull request #11335: [WIP] Replace save|restoreWindowGeometry with Qt functions (master...201709_fix_offscreen_2) https://github.com/bitcoin/bitcoin/pull/11335
21:42 < achow101> yes     
21:42 < jonasschnelli> I'm not sure if this would fix it... haven't tested it. Haven't checked the upstream by-platform code for restoreGeometry
21:43 < jonasschnelli> But we should def. use it
21:43 -!- GypsyScotty [~yellow@67-61-101-34.cpe.cableone.net] has quit []     
21:43 < jonasschnelli> Rather then implementing it in our layer
21:43 < meshcollider> Agreed
21:43 < luke-jr> https://gist.github.com/5c7afe24d6d4cb512c9d0940c91d5ac4
21:43 < achow101> well then lets try and see what it does
21:44 < jonasschnelli> meshcollider: Oh. Great, ... you already PRed #11335
21:44 < gribble> https://github.com/bitcoin/bitcoin/issues/11335 | [WIP] Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
21:44 < jonasschnelli> I'll go a gitian build
21:44 < jonasschnelli> *do     
21:45 < meshcollider> Oh that looks a lot better if it also checks for maximised and minimised right?
21:45 < meshcollider> luke-jr: is that from Qt 4
21:45 < gmaxwell> this code looks like it'll handle it.
21:45 < meshcollider> or 5
21:45 < luke-jr> meshcollider: 5.7
21:46 < gmaxwell> might want to take a quick look at 4.x just to see if it still looks sufficient there.
21:46 < luke-jr> so long as the current version works, IMO it's not our problem if older ones are broken
21:46 < achow101> luke-jr: well qt4 is still used and supported, so we want to make sure that works too
21:46 < luke-jr> (so long as we're outsourcing to Qt)
21:46 < gmaxwell> luke-jr: meh, if we build with it, it should work. at least against serious issues (and I think the program being totally inoperable is serious)
21:47 < meshcollider> speaking of Qt issues, does 5.9 fix any of the segfault crashes like #9683? (cf 10505)
21:47 < gribble> https://github.com/bitcoin/bitcoin/issues/9683 | random abort running master/HEAD · Issue #9683 · bitcoin/bitcoin · GitHub
21:47 < jonasschnelli> https://bitcoin.jonasschnelli.ch/build/305
21:47 < luke-jr> gmaxwell: disable restoring position on Qt4? :p
21:47 < achow101> luke-jr: qt4 has the same functions, we should check their behavior
21:47 < gmaxwell> luke-jr: maybe you could argue that it was sufficient if the latest QT4 had it, in any case I expect it does have similar code.  This stuff seems like GUI101.
21:48 < meshcollider> I'd imagine 4 would still have decent restoring function anyway lol
21:48 < luke-jr> achow101: sure
21:48 < jonasschnelli> Qt4 support doesn't need to support everything: https://github.com/bitcoin/bitcoin/blob/f65614726de21e116966366d6abdf025dfeb6db2/doc/build-osx.md#L27
21:48 < luke-jr> gmaxwell: the Qt5 code there suggests it changed around 5.3
21:48 < gmaxwell> thou shall not restore the window to a location which is completely inaccessible to the user.
21:49 < jonasschnelli> Can we just get rid of Qt4 support? Qt 4.8 seems unmaintaned since a couple of years... very bad for a cross-platform layer
21:51 < luke-jr> no objection from me anymore
21:51 < luke-jr> fwiw
21:51 < gmaxwell> I dont even understand why this is coming up here.
21:51 < gmaxwell> Roughly the same code is in QT4. so it should be fine too. 
21:52 < jonasschnelli> Unrelated to the offscreen bug, yes.
21:53 < jonasschnelli> Switching to Qt5 would allow to remove legacy code and use Qt5 features like lambdas, etc.
21:53 < jonasschnelli> Simpler signal bindings
21:53 < gmaxwell> Well, on all my machines Qt4 is the only version installed I think. I think it's still the default even in debian testing (though QT5 is available there).
21:57 < luke-jr> oh :/
21:57 < luke-jr> Now that you mention it, I do recall seeing Qt4 on Devuan
21:59 < gmaxwell> I'm no expert and perhaps a fresh install would change some default.  And maybe we could just address by providing more install instructions.
21:59 < achow101> gmaxwell: perhaps you need a new laptop :p
22:03 < gmaxwell> your inside jokes might confuse people. :P  fwiw, on an up to date debian testing system, which was QT4 only, you can parallel install QT5, but it seems bitcoin-qt still builds using QT4 even with QT5 'installed'.
22:10 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
22:18 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Remote host closed the connection]     
22:18 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
22:18 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev     
22:23 -!- tErik_mc [~tErik@unaffiliated/terik] has joined #bitcoin-core-dev     
22:29 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds]     
22:34 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-eymzzvwlnncbxacb] has joined #bitcoin-core-dev     
22:49 < meshcollider> hmmm it seems that its working, but if you move it right to the very very edge of the screen you literally cant see it, you can grab it again with the mouse but theres no way you'd be able to find it again lol
22:49 < meshcollider> that'd be a rare case though I'd imaging
22:49 < meshcollider> s/imaging/imagine/
22:52 < achow101> meshcollider: that's exactly the case that gmaxwell and I were testing earlier
22:53 < achow101> and that case is kind of the worst case scenario, not off screen, but not on screen enough to be usable
22:56 -!- chriswakare [~cnwakare@203.187.213.41] has joined #bitcoin-core-dev     
22:59 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]     
23:06 -!- Guest65485 is now known as ndrst     
23:07 -!- ndrst [~ndrst@an-ti.eu] has quit [Changing host]     
23:07 -!- ndrst [~ndrst@unaffiliated/ndrst] has joined #bitcoin-core-dev     
23:07 -!- chriswakare [~cnwakare@203.187.213.41] has left #bitcoin-core-dev ["Leaving..."]     
23:10 < meshcollider> mhm but if we rely on Qt restore and save, its not really fixable by us. I'd say its a non-issue if its exactly how other OS programs behave like notepad?
23:10 < meshcollider> As long as its possible to get it back on screen with just the mouse, which it is, as long as you can find it lol
23:21 -!- Dummbatz [~dummy@89.126.196.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev     
23:21 < gmaxwell> bleh, I suppose. why do other things find that behavior tolerable.
23:22 < sipa> there is some key shortcut to move a window
23:23 < cfields_> ctrl+space gives you the min/max/move context-menu
23:23 < cfields_> er, alt+space
23:23 < meshcollider> yeah or you can shift+rightclick on the icon in the taskbar
23:23  * cfields_ just can't seem to leave his windows days behind him
23:24 < cfields_> and fwiw, i only know that because programs would end up out-of-view now and then
23:27 < gmaxwell> things really can get out of view and then save and restore it across restarts... how the heck have they not fixed that.
23:31 < meshcollider> huh I figured out an even easier way to get it back on screen, windows key + arrow
23:31 < cfields_> gmaxwell: well i haven't messed with it since xp, I assume they've made some progress :)
23:33 < midnightmagic> meh. it's qt. they only fix stuff for corps that have an upper-tier support contract.
23:34 < cfields_> midnightmagic: regardless of qt, the window manager is ultimately in charge of positioning
23:34 < cfields_> which i assume was gmaxwell's point
23:37 < meshcollider> ^ use a tiling window manager and all your problems disappear ;) 
23:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
23:45 < midnightmagic> cfields_: no, memory of a window position is not something dwm does, and I use dwm-- "we" had issues with qt windows doing stupid things, fixing it was a pointless chore.
23:46 < midnightmagic> xterm positioning for a new window is similar-- you pass in X geometry, and/or dwm guesses a top-left position for it, that's pretty much it
23:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]     
23:49 < midnightmagic> eh, I might be misremembering. we had a lot of qt problems. a lot. lotta lot.. 
23:56 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 248 seconds]     
23:56 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev