--- Day changed Tue Sep 26 2017 00:01 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-pabbdxyrkocrswli] has joined #bitcoin-core-dev 00:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 00:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 00:10 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:14 -!- bigcheap [67582ec4@gateway/web/freenode/ip.103.88.46.196] has joined #bitcoin-core-dev 00:22 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 00:22 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 00:34 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:7d47:be5d:35fe:5bd9] has joined #bitcoin-core-dev 00:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 00:58 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:59 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 248 seconds] 01:00 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 01:02 -!- EVM [71cbe97d@gateway/web/freenode/ip.113.203.233.125] has quit [Ping timeout: 260 seconds] 01:02 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev 01:12 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 01:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:27 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Quit: Page closed] 01:55 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 01:56 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving] 02:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 02:31 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:48 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has joined #bitcoin-core-dev 02:50 -!- bigcheap [67582ec4@gateway/web/freenode/ip.103.88.46.196] has quit [Ping timeout: 260 seconds] 03:01 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:28 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8cf88b4aaeaf...67879b7c4431 03:28 < bitcoin-git> bitcoin/master 28d4542 Matt Corallo: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds 03:28 < bitcoin-git> bitcoin/master 67879b7 Wladimir J. van der Laan: Merge #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds... 03:28 < bitcoin-git> [bitcoin] laanwj closed pull request #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds (master...2017-09-bitcoin-tx-uncompressed-segwit) https://github.com/bitcoin/bitcoin/pull/11377 03:29 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:7d47:be5d:35fe:5bd9] has quit [Remote host closed the connection] 03:29 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:7d47:be5d:35fe:5bd9] has joined #bitcoin-core-dev 04:08 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:7d47:be5d:35fe:5bd9] has quit [Ping timeout: 246 seconds] 04:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 04:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 04:56 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:7d47:be5d:35fe:5bd9] has joined #bitcoin-core-dev 05:08 -!- PatBoy [xyz@192.99.249.194] has joined #bitcoin-core-dev 05:08 -!- PatBoy [xyz@192.99.249.194] has quit [Excess Flood] 05:09 -!- PatBoy [xyz@192.99.249.194] has joined #bitcoin-core-dev 05:25 -!- Geoffy [~Geo@178-119-187-213.access.telenet.be] has joined #bitcoin-core-dev 05:29 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:7d47:be5d:35fe:5bd9] has quit [Ping timeout: 255 seconds] 05:29 -!- wittysense [~wittysens@c-73-232-144-188.hsd1.tx.comcast.net] has joined #bitcoin-core-dev 05:36 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:47 -!- LeMiner2 [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 05:49 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Ping timeout: 248 seconds] 05:49 -!- LeMiner2 is now known as LeMiner 05:53 -!- Victor_sueca is now known as Victorsueca 05:54 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 06:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 06:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1] 06:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 06:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:28 -!- Evel-Knievel [~Evel-Knie@178-119-237-211.access.telenet.be] has quit [] 06:32 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 06:37 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 240 seconds] 06:38 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 06:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:48 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:50 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 06:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 06:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 07:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:11 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-pabbdxyrkocrswli] has quit [Quit: Connection closed for inactivity] 07:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 07:15 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 07:15 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 07:17 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67879b7c4431...0f8e09599db6 07:17 < bitcoin-git> bitcoin/master df10edf MeshCollider: More user-friendly error message when partially signing 07:17 < bitcoin-git> bitcoin/master 0f8e095 Wladimir J. van der Laan: Merge #11288: More user-friendly error message when partially signing... 07:17 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 07:18 < bitcoin-git> [bitcoin] laanwj closed pull request #11288: More user-friendly error message when partially signing (master...201709_partial_sign_error) https://github.com/bitcoin/bitcoin/pull/11288 07:21 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 07:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:24 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f8e09599db6...dc597bb895ef 07:24 < bitcoin-git> bitcoin/master d01a968 Suhas Daftuar: wallet: update stored witness in AddToWallet... 07:24 < bitcoin-git> bitcoin/master dc597bb Wladimir J. van der Laan: Merge #11225: wallet: update stored witness in AddToWallet... 07:25 < bitcoin-git> [bitcoin] laanwj closed pull request #11225: wallet: update stored witness in AddToWallet (master...2017-09-update-tx-witness) https://github.com/bitcoin/bitcoin/pull/11225 07:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:34 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 07:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:49 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:56 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 264 seconds] 08:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:43 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has quit [Quit: This computer has gone to sleep] 08:44 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has joined #bitcoin-core-dev 08:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 08:54 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:57 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 08:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:03 < promag> jnewbery: https://github.com/bitcoin/bitcoin/pull/11031/commits/a6919d9a6908efaf0c913cccda21d63ed1517b3c s/enablerpcmethod/deprecatedrpc 09:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:06 -!- benma [~benma@52.10.104.92.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 09:09 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has quit [Quit: This computer has gone to sleep] 09:11 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has joined #bitcoin-core-dev 09:19 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:27 < jnewbery> promag: thanks, fixed 09:43 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kfcchdsrzijnkufz] has joined #bitcoin-core-dev 09:52 < maaku> I'm considering removing the 200 non-push opcode limit and SIGOP counting for my tail-call proposal. I would be interested in feedback as to why this would be a terrible idea. 09:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:05 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Quit: Page closed] 10:06 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 10:11 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:28 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:28 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev 10:30 -!- benma [~benma@52.10.104.92.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 10:30 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 252 seconds] 10:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:36 < bitcoin-git> [bitcoin] jtimon closed pull request #11404: RPC: Chainparams: Simplify -rpcport and CBaseMainParams (master...b16-chainparams-rpcport) https://github.com/bitcoin/bitcoin/pull/11404 10:36 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:43 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 10:44 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 240 seconds] 10:49 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 10:51 < instagibbs> what interval if any does travis run extended functional tests? 10:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:11 -!- analiser [~analiser@190.75.100.35] has quit [Ping timeout: 248 seconds] 11:18 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again] 11:22 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 11:24 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Client Quit] 11:31 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 11:32 < jtimon> sipa: what's the reasoning for the bias for nodes using the default port? that seems weird 11:33 < sipa> jtimon: otherwise you can spam the network with addr messages for services you don't like, and get the whole bitcoin network to try connecting to them 11:33 < jtimon> how is that affected by the port, I don't follow... 11:33 < sipa> with the bias, that can pretty much only happen for P2P default port, which is very unlikely to have any interesting services running, other than bitcoin :) 11:34 < jtimon> oh, I see 11:34 < jtimon> I think I get it... 11:34 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 11:35 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Client Quit] 11:35 < jtimon> in any case, as said seems unrelated to #11404 11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/11404 | RPC: Chainparams: Simplify -rpcport and CBaseMainParams by jtimon · Pull Request #11404 · bitcoin/bitcoin · GitHub 11:35 < sipa> well you're giving all networks the same default port 11:36 < sipa> meaning that if you want to run more than one network on the same machine, one of them will need a non-default port 11:36 < jtimon> the same defaul rpc port 11:36 < esotericnonsense> yes, it's the rpc port only in the PR, was a bit confused by your comment sipa 11:37 < sipa> oh! 11:37 < sipa> this is about the RPC port 11:37 < esotericnonsense> i still dislike the behaviour of having to specify a different rpcport for testnet/regtest though 11:37 < esotericnonsense> though that's just a quality-of-life annoyance 11:37 < sipa> yes, agree - though that's much less bad than having the same P2P port 11:37 < sipa> sorry, i misunderstood! 11:38 < esotericnonsense> while we're on the subject is there any preference for connecting to nodes with a different IP (perhaps based on this standard port bias)? e.g. if I run 50000 nodes from one IP and spam addr messages 11:38 < gmaxwell> it just makes them unusable by default, I cannot fathom why we would do that. 11:39 < sipa> esotericnonsense: we never make more than 1 outgoing connection to the same 'network group' (whose definition is dependent on the network, but for IPv4 it's a /16 i think) 11:40 < esotericnonsense> aha. 11:40 < sipa> and without -addnode we'll never connect to an unroutable address (so not to 192.168.x, not 127.0.0.1, not 10.x, etc) 11:41 < sipa> i think we should at some point have local network discovery and try to connect within your own network, but not using the same external connection slots) 11:42 < gmaxwell> sipa: I started working on that and didn't have a good way to eliminate the duplicate connections. 11:42 < gmaxwell> E.g. hosts A and B on the local network, both connect to each other. 11:43 < gmaxwell> I thought perhaps just a stupid hurestic, "if you listen, connect only to lower sort-order addresses than yours". 11:44 < sipa> or just test for duplicate IP pairs? within a local network you can probably assume that both parties will see each other's by their actual IP (not NAT etc0 11:45 < sipa> so don't connect out to any IP you're seeing an incoming connection from 11:46 < gmaxwell> Good point. What about the race when two connect at the same time 11:46 < jtimon> esotericnonsense: for bitcoin-cli, specifying -testnet does the same as -rpcport=18332, if you specify rpcport, specifying -testnet is completely meaningless 11:47 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:47 < jtimon> gmaxwell: what is made unusable by default? I don't follow 11:48 < sipa> gmaxwell: if you have a duplicate pair among actual connections, and your IP is the lexicographically lower of the two, disconnect? 11:48 < Sentineo> gmaxwell: sipa it sounds like split horizont in routing protocols what discuss ... 11:49 < Sentineo> what you discuss 11:49 < gmaxwell> jtimon: Making everything use the same rpc port means you cannot run testnet and bitcoin at the same time anymore except through manually configuring them. 11:50 < Sentineo> btw sipa why is a node keeping 8 connetions outside ? I have a node with 123 connection, 8 of them always go outside. I would assume my node should prefer inbound connections. 11:50 < jtimon> oh, that. yeah. if you want to use both in the same machine you have to specify a different rpc port in one of the, 11:50 < jtimon> them 11:51 < sipa> Sentineo: we always make 8 outgoing connections - regardless of how many incoming connections you have 11:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:51 < sipa> outgoing connections are far more sybil resistant, as their endpoints are under your own control 11:52 < jtimon> I don't think that unusable, but ok 11:52 < gmaxwell> Sentineo: "prefer inbound" ?!?! ... the inbound could all be a single badguy. We consider inbounds irrelevant for security because of that. 11:52 < Sentineo> yeah, did not thing of that. Was lookng at it the "i serve the network" point of view, which is stupid from security standpoing ... 11:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:57 -!- cdecker [~cdecker@mail.snyke.net] has quit [Quit: ZNC - http://znc.in] 12:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:03 -!- harrymm [~harrymm@85.203.47.79] has quit [Ping timeout: 248 seconds] 12:08 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 12:10 < maaku> sipa: Bonjour/Zeroconf would make initial sync of new devices without blowing data caps much more idiot proof 12:11 < maaku> it would also make sense to combine that with preferring making block requests to local peers during IBD 12:12 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 12:13 < sipa> the IBD sync will already prefer faster peers, and will disconnect peers that prevent it from going faster - so i hope no special logic for that is needed 12:14 < sipa> i haven't looked at any of those local connection services 12:16 < gmaxwell> they are awful zeroday magnets. 12:16 < gmaxwell> of course. 12:16 -!- harrymm [~harrymm@85.203.47.38] has joined #bitcoin-core-dev 12:17 < maaku> sipa: the disconnect actually sounds somewhat dangerous. could I used fast connectivity and network attacks to partition someone off during IBD? 12:18 < sipa> maaku: there is certainly an increased attack vector, but you'd at least need to combine it with other strategies to control the new connections being made (eclipse attacks etc) 12:19 < sipa> maaku: in general i do think that partitioning during IBD is less of an issue - you know you're not caught up 12:23 < TD-Linux> bonjour is a pretty sensible protocol for that 12:23 < gmaxwell> you're still making progress and you already have your headers. There is an argument, however, that 'after' IBD we should dump most of our outbound peers. 12:24 < gmaxwell> but that is complicated by there not being a clear 'after'. 12:27 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 12:36 < maaku> right 12:38 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 12:40 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 12:44 < gmaxwell> TD-Linux: things like bonjour don't help doing things like having connections inside amazon regions for hosts on aws, which have radically less expensive bandwidth than bandwidth to the internet. 12:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 12:51 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 12:53 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 12:57 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 12:59 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has quit [Quit: This computer has gone to sleep] 13:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:02 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 13:04 < TD-Linux> gmaxwell, nope. I guess you could ship lists of these 13:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 13:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:25 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11406: Add state message print to AcceptBlock failure message. (master...2017-09-checkblock-fail-print) https://github.com/bitcoin/bitcoin/pull/11406 13:29 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fvudeywilecpczie] has joined #bitcoin-core-dev 13:34 < jtimon> does anybody use -mempoolreplacement=0 ? would it make sense to do https://github.com/ElementsProject/elements/pull/248 in bitcoin ? 13:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:44 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 13:45 < luke-jr> jtimon: yes, people use it, and removing it would likely make a ruckus. There's also zero harm in leaving it. 13:45 < jtimon> yeah, if people use it, no point in removing it 13:47 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 252 seconds] 13:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:49 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 13:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:56 < promag> achow101: in https://github.com/bitcoin/bitcoin/pull/10583/commits/8d5d4cf4c3077e8f3269fab3b98da7413e100081 commit message there is a double space. Also, Validateaddress should always be lowercase? 13:59 < promag> jnewbery: so -deprecatedrpc can be used to enable some deprecated params? I thought is to enable the full (deprecated) rpc 14:05 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 255 seconds] 14:07 < achow101> promag: who cares 14:08 < achow101> promag: super nitty things like that don't really matter and are not particularly conducive to development 14:10 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 14:11 < promag> that's ok, I was reading your code and figured you want to know about that if by any change you happen to fix something else 14:11 < promag> *chance 14:13 -!- Pasha is now known as Cory 14:14 < promag> talking about nitty things https://github.com/bitcoin/bitcoin/pull/11395#issuecomment-332308834 14:15 < promag> luke-jr: if you run clang-format as per developer notes you will see those details 14:16 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 14:17 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 260 seconds] 14:18 < promag> if there is such guide, which took some community effort to write why not follow it? I would say top core developers should be the first to comply? It's not that it takes a lot of time doing so. 14:20 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 14:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 14:24 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 14:25 < bitcoin-git> [bitcoin] instagibbs opened pull request #11407: add functional test for mempoolreplacement command line arg (master...testmempoolreplacearg) https://github.com/bitcoin/bitcoin/pull/11407 14:27 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 14:34 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 14:34 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 14:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:37 < sipa> promag: there is balance between costs and benefits of enforcing style 14:38 < sipa> it adds overhead to both people who write patches and those who reviee 14:41 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 240 seconds] 14:42 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:44 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 14:46 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:48 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 14:51 < jnewbery> promag: I personally think it's fine to use -deprecatedrpc to signal that you want to receive an RPC return object in the old format 14:55 < promag> sipa: the problem is to find the sweet spot for everyone. Running clang-format-diff.py is not that big overhead is it? Anyway, I'll stop nitpicking. 14:55 < promag> jnewbery: I guess so, and should tests all deprecated keys or one is enough? 14:59 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc597bb895ef...2505c5c0a9f8 14:59 < bitcoin-git> bitcoin/master 7b137ac Lucas Betschart: [Qt] Add delay before filtering transactions... 14:59 < bitcoin-git> bitcoin/master 2505c5c Jonas Schnelli: Merge #11015: [Qt] Add delay before filtering transactions... 15:00 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #11015: [Qt] Add delay before filtering transactions (master...searchDelay) https://github.com/bitcoin/bitcoin/pull/11015 15:01 < sipa> promag: i'm personally in favor of more strict style conventions, and would very much like the project to force one style... but that's just not feasible. nitpicking everything kills people's motivation to work 15:06 < CryptAxe> Is it possible for nodes that don't understand the extended transaction serialization format for segwit to still validate blocks with those transactions inside of them? 15:06 < goatpig> they cant check the scriptsigs 15:07 < goatpig> but otherwise pre SW nodes can verify SW transactions 15:08 < sipa> CryptAxe: sure, they just won't see the witnesses 15:08 < sipa> (as peers will strip the witness before relaying to a non-segwit peer) 15:08 < bitcoin-git> [bitcoin] PierreRochard opened pull request #11408: Trivial: Fix parameter name typo in ErasePurpose walletdb method (master...walletdb-typo) https://github.com/bitcoin/bitcoin/pull/11408 15:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:09 < CryptAxe> So they can still deserialize the transaction? Cool, I think this part: https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L204-L212 made me think that they would have an empty vin and it would be invalid 15:09 -!- maaku [~mark@173.234.25.100] has left #bitcoin-core-dev [] 15:10 < CryptAxe> Ahhh so the transactions are relayed in a different format to old nodes 15:10 < CryptAxe> I didn't see that part 15:10 < sipa> CryptAxe: if they see the witness, the serialization will very deliberately fail 15:10 < sipa> CryptAxe: the reason segwit is a softfork is the fact that it is possible to strip out the witness without invalidating the transaction (from the perspective of old nodes) 15:11 < CryptAxe> goatpig and sipa thank you, I have more reading to do now :) 15:11 < sipa> it's probably better to think of the witness as not actually part of the transaction - it's just some auxilliary data - which _only for relay_ is relayed in a weird interspersed way inside the normal tx data 15:12 < CryptAxe> sipa so the stripped format has some kind of dummy vin or something? 15:12 < sipa> no 15:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:12 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:12 < sipa> the stripped format is just the old transaction format 15:12 < sipa> it has inputs and outputs, and no witnesses 15:12 < sipa> ah, i see what you mean 15:12 < sipa> yes, the scriptSigs are empty 15:12 < sipa> but the rest of the inputs is intact 15:13 < CryptAxe> Thank you, a bit confused about all that 15:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:15 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 15:17 < CryptAxe> sipa without the scriptSigs why aren't the transactions invalid to the older nodes? 15:17 < sipa> CryptAxe: because their scriptPubKeys don't require a scriptSig 15:17 < CryptAxe> Ah! 15:17 < sipa> (they have the form OP_0 <20-byte hash>) 15:18 < CryptAxe> genius 15:18 < sipa> if segwit is used in P2SH-wrapped form, the scriptPubKey is a P2SH output with Hash(OP_0 <20-byte hash>), and the scriptSig contains _only_ the redeemscript (which is equal to the actual OP_0 <20 byte hash>) 15:19 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has joined #bitcoin-core-dev 15:21 < CryptAxe> Cool, thanks again guys! 15:25 -!- wittysense [~wittysens@c-73-232-144-188.hsd1.tx.comcast.net] has quit [Quit: Lost terminal] 15:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 15:36 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 240 seconds] 15:38 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 15:53 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 240 seconds] 15:57 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 16:04 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:19 -!- laurentmt [~Thunderbi@185.200.145.118] has joined #bitcoin-core-dev 16:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 16:25 -!- vicenteH [~user@93.104.135.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 16:29 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 240 seconds] 16:30 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 16:39 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:291f:7f10:1fa4:4931] has joined #bitcoin-core-dev 16:43 -!- circ-user-2HbxE [~circuser-@2604:2000:e8c5:1700:291f:7f10:1fa4:4931] has quit [Remote host closed the connection] 16:57 -!- laurentmt1 [~Thunderbi@149.86.177.158] has joined #bitcoin-core-dev 16:59 -!- laurentmt [~Thunderbi@185.200.145.118] has quit [Ping timeout: 248 seconds] 16:59 -!- laurentmt1 is now known as laurentmt 17:04 -!- wittysense [~wittysens@c-73-232-144-188.hsd1.tx.comcast.net] has joined #bitcoin-core-dev 17:08 -!- laurentmt1 [~Thunderbi@185.200.145.118] has joined #bitcoin-core-dev 17:10 -!- laurentmt [~Thunderbi@149.86.177.158] has quit [Ping timeout: 248 seconds] 17:10 -!- laurentmt1 is now known as laurentmt 17:18 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kfcchdsrzijnkufz] has quit [Quit: Connection closed for inactivity] 17:26 -!- laurentmt1 [~Thunderbi@149.86.177.158] has joined #bitcoin-core-dev 17:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:29 -!- laurentmt [~Thunderbi@185.200.145.118] has quit [Ping timeout: 248 seconds] 17:29 -!- laurentmt1 is now known as laurentmt 17:32 -!- laurentmt1 [~Thunderbi@185.200.145.118] has joined #bitcoin-core-dev 17:33 -!- laurentmt [~Thunderbi@149.86.177.158] has quit [Ping timeout: 248 seconds] 17:33 -!- laurentmt1 is now known as laurentmt 17:37 -!- laurentmt1 [~Thunderbi@149.86.177.158] has joined #bitcoin-core-dev 17:37 -!- Geoffy [~Geo@178-119-187-213.access.telenet.be] has quit [] 17:39 -!- laurentmt [~Thunderbi@185.200.145.118] has quit [Ping timeout: 248 seconds] 17:40 -!- laurentmt1 is now known as laurentmt 17:44 -!- laurentmt1 [~Thunderbi@185.200.145.118] has joined #bitcoin-core-dev 17:44 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:46 -!- laurentmt [~Thunderbi@149.86.177.158] has quit [Ping timeout: 248 seconds] 17:48 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: Connection reset by peer] 17:48 -!- laurentmt1 [~Thunderbi@185.200.145.118] has quit [Ping timeout: 248 seconds] 17:49 -!- laurentmt [~Thunderbi@149.86.177.158] has joined #bitcoin-core-dev 17:49 -!- laurentmt [~Thunderbi@149.86.177.158] has quit [Client Quit] 17:52 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 248 seconds] 17:52 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:54 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 18:00 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 18:03 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 18:03 -!- roidster is now known as Guest96312 18:04 -!- Guest96312 is now known as roidster 18:32 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:54 < jnewbery> promag: I think one key is enough, but I'm happy to review follow-up PRs if you feel strongly that more coverage is required. 19:04 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Read error: Connection reset by peer] 19:41 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 19:41 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 19:58 -!- analiser [~analiser@190.75.100.35] has joined #bitcoin-core-dev 20:46 -!- analiser [~analiser@190.75.100.35] has quit [Ping timeout: 252 seconds] 20:50 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 240 seconds] 20:51 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 21:09 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fvudeywilecpczie] has quit [Quit: Connection closed for inactivity] 21:22 -!- adam3us_ [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev 21:23 -!- MarcoFalke_ [~none@198.12.116.246] has joined #bitcoin-core-dev 21:23 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 21:24 -!- trippysa1mon [~trippysal@cyberdynesys.org] has joined #bitcoin-core-dev 21:24 -!- c40d9b0753a91f40 [~2c232c25c@unaffiliated/c40d9b0743a91f40] has joined #bitcoin-core-dev 21:25 -!- aj_ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 21:25 -!- zxzzt_ [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:26 -!- jtimon_ [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 21:27 -!- wump [~quassel@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 21:29 -!- newbold_ [~adam@23.95.228.154] has joined #bitcoin-core-dev 21:29 -!- MarcoFalke_ is now known as MarcoFalke 21:31 -!- CryptAxe [~CryptAxe@2400:8902::f03c:91ff:fe92:b2bd] has joined #bitcoin-core-dev 21:31 -!- Netsplit over, joins: [b__b] 21:32 -!- cysm [cysm@gateway/shell/elitebnc/x-bgnbhrpeousothdz] has joined #bitcoin-core-dev 21:32 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Ping timeout: 240 seconds] 21:32 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 260 seconds] 21:33 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 21:34 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 21:34 -!- TheLive1 [~TheLive1@45.76.39.44] has joined #bitcoin-core-dev 21:34 -!- TheLive1 [~TheLive1@45.76.39.44] has quit [Changing host] 21:34 -!- TheLive1 [~TheLive1@unaffiliated/thelive1] has joined #bitcoin-core-dev 21:36 -!- ossifrage [~ossifrage@pool-98-114-91-222.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 21:36 -!- ossifrage [~ossifrage@pool-98-114-91-222.phlapa.fios.verizon.net] has quit [Changing host] 21:36 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 21:37 -!- Netsplit over, joins: murr4y 21:41 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 252 seconds] 21:52 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Changing host] 21:52 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 21:55 -!- tknp [~tknp@unaffiliated/tknp] has joined #bitcoin-core-dev 22:07 -!- roidster [~chatzilla@71-92-221-248.static.mtpk.ca.charter.com] has quit [Ping timeout: 240 seconds] 22:07 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 22:07 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 22:10 -!- Miezel [~Miezel@64-83-208-26.static.stcd.mn.charter.com] has quit [Quit: This computer has gone to sleep] 22:20 -!- jtimon_ [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 22:31 -!- analiser [~analiser@190.75.100.35] has joined #bitcoin-core-dev 22:31 < esotericnonsense> whee. https://github.com/esotericnonsense/bitcoind-ncurses2 22:31 < esotericnonsense> doesn't really do much yet but should be less buggy than the old gevent based thing. :) 22:33 < Sentineo> ah! 22:33 < Sentineo> will try esotericnonsense 22:34 < esotericnonsense> Sentineo: it has like 15% of the features of the other one. i just got tired of trying to figure out how to maintain the mess with this global state and all sorts of nonsense like that. :P 22:35 < Sentineo> to be honest i did not try the other one 22:35 < Sentineo> so wkll not be biased ;) 22:36 < Sentineo> today is my dev day, so will work on mine, too. finishing the workqueue to not kill bitcoind jn the process of fetching fee ;) 22:56 -!- tknp [~tknp@unaffiliated/tknp] has quit [Quit: tknp] 23:10 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mutsheiltyhjixwt] has joined #bitcoin-core-dev 23:20 -!- geezas [uid253218@gateway/web/irccloud.com/x-jafliyelygyoqval] has quit [Quit: Connection closed for inactivity] 23:21 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 23:23 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 23:41 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 23:44 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:44 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:46 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 23:46 < fanquake> achow101 is #10579 the first time you 23:46 < fanquake> 've seen the whitespace linter masking another error? 23:46 < gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub 23:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 23:53 -!- JackH [~laptop@46.231.18.66] has quit [Ping timeout: 240 seconds] 23:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]