--- Day changed Tue Oct 10 2017 00:00 -!- go1111111 [~go1111111@199.231.240.157] has quit [Remote host closed the connection] 00:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e022463a4b23...5a9da37fb3f4 00:01 < bitcoin-git> bitcoin/master f902e40 Johannes Kanig: fix typo in comment of chain.cpp 00:01 < bitcoin-git> bitcoin/master 5a9da37 Wladimir J. van der Laan: Merge #11469: fix typo in comment of chain.cpp... 00:02 < bitcoin-git> [bitcoin] laanwj closed pull request #11469: fix typo in comment of chain.cpp (master...typo-fix-in-comment) https://github.com/bitcoin/bitcoin/pull/11469 00:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:11 -!- Netsplit over, joins: intcat 00:12 -!- Netsplit over, joins: ghost43, arubi 00:21 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 00:24 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:26 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Remote host closed the connection] 00:30 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 00:35 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 00:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:41 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-lappgjqcayfjjczc] has quit [Quit: Connection closed for inactivity] 00:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 01:03 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 01:16 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:17 -!- Victor_sueca is now known as VIctorsueca 01:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:19 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:21 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:22 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 01:24 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:24 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 01:32 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Remote host closed the connection] 01:32 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 01:33 -!- JackH [~laptop@2a02:a210:2e00:300:655a:7cbf:d627:81fb] has quit [Ping timeout: 255 seconds] 01:43 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 01:45 < fanquake> wumpus are you able to merge #7 on the univalue repo. The same change had ACKs from sipa and gmaxwell in #6 if your waiting for more reviewers. 01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/7 | Block-header-only, faster startup client · Issue #7 · bitcoin/bitcoin · GitHub 01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/6 | Treat wallet as a generic keystore · Issue #6 · bitcoin/bitcoin · GitHub 01:45 < fanquake> Then we can review and merge #11420 on the main repo. 01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/11420 | Bump univalue subtree and fix json formatting in tests by MarcoFalke · Pull Request #11420 · bitcoin/bitcoin · GitHub 01:46 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev 01:48 < sipa> fanquake: will do tomorrow 01:50 < fanquake> sipa cheers 01:53 -!- harry_ [c56531c7@gateway/web/freenode/ip.197.101.49.199] has quit [Ping timeout: 260 seconds] 02:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:27 -!- thermoman [~thermoman@wtf.foobar0815.de] has joined #bitcoin-core-dev 02:28 < thermoman> the contents of https://bitcoin.org/bin/bitcoin-core-0.15.0.1/bitcoin-0.15.0.1.tar.gz is in a subdirectory named "bitcoin-0.15.0". 02:28 < thermoman> that's bad since the version in the extracted directory is not exacly the version of the archive file 02:29 < thermoman> this adds confusion, especially if you had extracted bitcoin-0.15.0.tar.gz earlier 02:29 < thermoman> % tar tf bitcoin-0.15.0.1.tar.gz | head -n 1 02:29 < thermoman> bitcoin-0.15.0/ 02:30 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mbeqcysaxapgmbqo] has joined #bitcoin-core-dev 03:00 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:16 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 03:18 -!- Freddie [44bd09d5@gateway/web/freenode/ip.68.189.9.213] has joined #bitcoin-core-dev 03:19 -!- Freddie is now known as Guest81526 03:21 < Guest81526> Chico then? 03:26 -!- W4RL0RD [~W4RL0RD@173.209.61.59] has joined #bitcoin-core-dev 03:43 -!- wxss [~chatzilla@91.210.105.101] has joined #bitcoin-core-dev 03:49 -!- ProfMac_2 [43c671dc@gateway/web/freenode/ip.67.198.113.220] has quit [Ping timeout: 260 seconds] 03:50 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 03:50 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has quit [Ping timeout: 255 seconds] 03:56 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev 03:59 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 04:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 248 seconds] 04:02 -!- Guest81526 [44bd09d5@gateway/web/freenode/ip.68.189.9.213] has quit [Ping timeout: 260 seconds] 04:02 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 04:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 04:11 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:35 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 04:35 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 240 seconds] 04:38 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 04:39 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 04:40 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mbeqcysaxapgmbqo] has quit [Quit: Connection closed for inactivity] 04:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 04:50 -!- Chris_St1 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:54 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-qvzvzvxngyrcmsaf] has quit [Read error: Connection reset by peer] 04:54 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-iogksqwefqypewmj] has joined #bitcoin-core-dev 04:54 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:58 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:02 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 05:03 -!- Chris_St1 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 1.4] 05:09 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 05:10 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:10 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:12 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 05:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:58 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 06:01 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 258 seconds] 06:05 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 06:06 -!- Garrick [~Garrick@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 06:07 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-degglkmhpxbqkrbm] has joined #bitcoin-core-dev 06:10 -!- Aaronvan_ is now known as AaronvanW 06:10 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 06:12 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 06:15 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:26 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 06:28 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 06:38 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 06:48 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 248 seconds] 06:48 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 06:54 -!- hardik_ [7449cabb@gateway/web/freenode/ip.116.73.202.187] has joined #bitcoin-core-dev 06:54 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds] 06:55 < hardik_> hi 06:56 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 06:57 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 06:58 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:59 -!- thermoman [~thermoman@wtf.foobar0815.de] has left #bitcoin-core-dev [""Wenn der Rechner versteckt ist, kann er von Hackern auch nicht gefunden werden." Antje Weber, Symantec"] 06:59 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has joined #bitcoin-core-dev 07:02 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [Ping timeout: 255 seconds] 07:05 -!- hardik_ [7449cabb@gateway/web/freenode/ip.116.73.202.187] has quit [Quit: Page closed] 07:08 -!- ijee07 [ca432a2a@gateway/web/freenode/ip.202.67.42.42] has joined #bitcoin-core-dev 07:11 -!- ijee07 [ca432a2a@gateway/web/freenode/ip.202.67.42.42] has left #bitcoin-core-dev [] 07:22 < jnewbery> #7061 should be merged soon. It's been reviewed to death. Perhaps reACKs from ryanofsky kallewoof if they're still interested. 07:22 < gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub 07:27 < GAit> wumpus: just noticed an error in the release notes for 0.15.0/0.15.0.1 not sure if already reported: "maximumCount - a number specifying the minimum number of UTXOs" - minimum vs maximum 07:37 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:40 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4] 07:41 < promag> GAit: IIRC that was already detected 07:41 -!- adiabat [~adiabat@45.63.20.152] has quit [Quit: WeeChat 1.4] 07:41 < instagibbs> yes there's already a PR for a fix 07:48 < promag> jnewbery: regarding #7061, at the moment the RPC can block a lot of time 07:48 < gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub 07:49 < promag> do you think this can be avoided in followups? 08:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:02 -!- nelruk [~dax_the_c@host-233.58.217.201.copaco.com.py] has joined #bitcoin-core-dev 08:12 -!- JackH [~laptop@46.231.18.66] has quit [Ping timeout: 240 seconds] 08:13 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 08:17 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 08:21 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 08:26 -!- JackH [~laptop@2a02:a210:2e00:300:655a:7cbf:d627:81fb] has joined #bitcoin-core-dev 08:31 -!- W4RL0RD [~W4RL0RD@173.209.61.59] has quit [Ping timeout: 255 seconds] 08:38 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 255 seconds] 08:40 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:42 -!- nelruk [~dax_the_c@host-233.58.217.201.copaco.com.py] has quit [Quit: Leaving] 08:47 -!- Aaronvan_ is now known as AaronvanW 09:08 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:27 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has quit [Ping timeout: 255 seconds] 09:31 < bitcoin-git> [bitcoin] thomasstep opened pull request #11474: Fixing pointer asterisk (master...TypoFix) https://github.com/bitcoin/bitcoin/pull/11474 09:31 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has joined #bitcoin-core-dev 09:34 < bitcoin-git> [bitcoin] mess110 closed pull request #11455: CTxMemPool::GetMinFee should not return CFeeRate(0) (master...fix_mempool_GetMinFee_bug_returning_below_minRelayTxFee) https://github.com/bitcoin/bitcoin/pull/11455 09:34 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has quit [Client Quit] 09:35 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has joined #bitcoin-core-dev 09:36 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 09:46 < bitcoin-git> [bitcoin] mess110 opened pull request #11475: [rpc] mempoolinfo should take ::minRelayTxFee into account (master...include_minRelayTxFee_in_getmempoolinfo_rpc) https://github.com/bitcoin/bitcoin/pull/11475 09:49 -!- jan386 [93210a9c@gateway/web/freenode/ip.147.33.10.156] has joined #bitcoin-core-dev 09:55 -!- jan386 [93210a9c@gateway/web/freenode/ip.147.33.10.156] has quit [Quit: Page closed] 09:58 < jnewbery> promag: I don't think that's a showstopper, but others may feel differently. Perhaps it can be addressed in a follow-up PR 10:01 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:01 < jonasschnelli> promag: Yes. 7061 is blocking...Its not directly related to this PR. See #11281 for an possible improvement of the rescan locking 10:01 < gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid pemanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub 10:05 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #11474: Fixing pointer asterisk (master...TypoFix) https://github.com/bitcoin/bitcoin/pull/11474 10:20 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-untnctzvnebazgnk] has joined #bitcoin-core-dev 10:25 -!- ekrion [~ff@adsl201-232-238-252.epm.net.co] has joined #bitcoin-core-dev 10:25 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:30 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:30 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 10:56 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 10:57 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 11:15 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gprzapkcmrrdfhgv] has joined #bitcoin-core-dev 11:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 11:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:50 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:57 -!- Mandla [9a452f07@gateway/web/freenode/ip.154.69.47.7] has joined #bitcoin-core-dev 11:58 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 11:59 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 12:07 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 12:10 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 12:14 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has quit [Ping timeout: 255 seconds] 12:16 -!- Mandla [9a452f07@gateway/web/freenode/ip.154.69.47.7] has quit [Quit: Page closed] 12:21 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has joined #bitcoin-core-dev 12:50 < bitcoin-git> [bitcoin] ryanofsky opened pull request #11476: Avoid opening copied wallet databases simultaneously (master...pr/wid) https://github.com/bitcoin/bitcoin/pull/11476 12:54 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev 12:59 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 13:13 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 13:17 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 13:20 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 13:20 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 13:26 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 13:45 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gprzapkcmrrdfhgv] has quit [Quit: Connection closed for inactivity] 14:19 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 14:20 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:21 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Client Quit] 14:22 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 14:33 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-uxylvxueblwkdxnq] has joined #bitcoin-core-dev 14:43 < meshcollider> jnewbery: do you have time to discuss some of your points in #11466? Re: moving GetWalletDir() out of utils.cpp, is there already a wallet util file you'd suggest moving it too, or I should create one? 14:43 < gribble> https://github.com/bitcoin/bitcoin/issues/11466 | [WIP] Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub 14:44 < meshcollider> I still haven't fully thought through where to put the initial directory creation stuff, to move it out of the GetDataDir function and allow the path caching to be removed 14:46 < meshcollider> So if I made a InitDataDir() function to call just once on initialization, which would check for datadir existence and make default one if it doesn't exist, that should store the data directory path and just return it on GetDataDir() 14:47 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 258 seconds] 14:48 < meshcollider> But we want to create the wallet dir on first run, so should a wallets/ directory always be created when the datadir is? Or is that still too much mixing of server + wallet stuff? 14:48 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 14:48 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 255 seconds] 14:48 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 14:49 < esotericnonsense> meshcollider: I haven't looked at the code; when/where is wallet.dat opened and written for the first time? that seems like a natural point? 14:49 < esotericnonsense> (you don't need a wallets folder until you actually have something to put in it) 14:50 < esotericnonsense> argh I missed a line above gribble's. ignore 14:50 < meshcollider> esotericnonsense: the problem is that you only want to create a wallets/ folder if this is the first run, because otherwise you'll already have a wallet.dat in the datadir root which would get ignored from that point on 14:51 < meshcollider> And from what I can think, the best way to know if this is a first-run is if we are creating the datadir too 14:59 < meshcollider> Hmm perhaps it should go in wallet/init.cpp? 15:17 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:19 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:21 -!- Cogito_Ergo_Sum [~Myself@80.107.149.120] has quit [] 15:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:30 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 258 seconds] 15:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 15:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:41 < meshcollider> Also wanted to discuss how best to list `available` wallets without relying on .dat extension 15:41 < meshcollider> Relying* 15:43 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:52 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:56 -!- vicenteH [~user@93.104.135.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 15:56 < promag> meshcollider: I would like some feedback here https://github.com/bitcoin/bitcoin/pull/11466#discussion_r143733780 16:00 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 258 seconds] 16:07 < meshcollider> I'm personally unsure on motivation, it was just suggested by John in the comment he linked 16:08 < meshcollider> Because of the point wumpus made in the OP 16:09 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 16:16 < promag> let me check 16:18 < promag> wumpus point on backups? 16:20 < promag> I still don't see the point. It's not possible to create new wallets via RPC. I really think it's noise for your PR. cc @jnewbery 16:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:38 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-untnctzvnebazgnk] has quit [Quit: Connection closed for inactivity] 16:40 < meshcollider> Could be yeah, I'll see what they say 👍 16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:09 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 255 seconds] 17:10 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 264 seconds] 17:11 -!- VIctorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:15 -!- owowo [ovovo@gateway/vpn/mullvad/x-wgiadzmmuhyusuqv] has joined #bitcoin-core-dev 17:17 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d9d2:328c:f213:81e8] has quit [Ping timeout: 258 seconds] 17:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:33 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 17:35 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 17:43 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 18:00 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:04 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 240 seconds] 18:05 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:16 -!- wxss [~chatzilla@91.210.105.101] has quit [Remote host closed the connection] 18:26 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 18:36 -!- ProfMac [~ProfMac@2001:470:b8ac:0:3c7c:8ede:b5a3:7fab] has joined #bitcoin-core-dev 19:01 -!- sager [~sager@c-73-29-2-227.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 19:21 -!- kayamm [~km@unaffiliated/kayamm] has quit [Ping timeout: 240 seconds] 19:24 -!- kayamm [~km@pastasuta.pro] has joined #bitcoin-core-dev 19:24 -!- kayamm [~km@pastasuta.pro] has quit [Changing host] 19:24 -!- kayamm [~km@unaffiliated/kayamm] has joined #bitcoin-core-dev 19:25 -!- merehap__ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 19:25 -!- merehap__ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 19:27 -!- merehap_ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 19:27 -!- merehap__ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 19:30 -!- merehap_ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has quit [Read error: No route to host] 19:30 -!- merehap_ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 19:32 < bitcoin-git> [bitcoin] PierreRochard opened pull request #11478: ODB Integration (master...odb) https://github.com/bitcoin/bitcoin/pull/11478 19:35 < bitcoin-git> [bitcoin] PierreRochard closed pull request #11478: ODB Integration (master...odb) https://github.com/bitcoin/bitcoin/pull/11478 19:35 -!- rty [71c8322a@gateway/web/freenode/ip.113.200.50.42] has joined #bitcoin-core-dev 19:42 -!- sager [~sager@c-73-29-2-227.hsd1.nj.comcast.net] has quit [Quit: Leaving] 19:43 -!- bbt [71c8322a@gateway/web/freenode/ip.113.200.50.42] has joined #bitcoin-core-dev 19:44 -!- bbt is now known as Guest34123 19:45 -!- Guest34123 [71c8322a@gateway/web/freenode/ip.113.200.50.42] has quit [Client Quit] 19:51 < bitcoin-git> [bitcoin] kswapd opened pull request #11479: [Docs] Update README.md to add Freenode links (master...master) https://github.com/bitcoin/bitcoin/pull/11479 19:53 -!- rty [71c8322a@gateway/web/freenode/ip.113.200.50.42] has quit [Quit: Page closed] 20:02 -!- harding [~harding@mail.dtrt.org] has quit [Remote host closed the connection] 21:03 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev 21:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 21:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 21:37 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 22:02 < bitcoin-git> [bitcoin] tjps opened pull request #11480: [ui] Add toggle for unblinding password fields (master...tjps_wallet_dialog) https://github.com/bitcoin/bitcoin/pull/11480 22:48 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 248 seconds] 22:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 22:58 -!- ananteris [~user@unaffiliated/ananteris] has quit [Remote host closed the connection] 23:16 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 23:23 -!- finapteka [d9429eb0@gateway/web/freenode/ip.217.66.158.176] has joined #bitcoin-core-dev 23:24 -!- finapteka [d9429eb0@gateway/web/freenode/ip.217.66.158.176] has quit [Client Quit] 23:34 -!- PatBoy [xyz@192.99.249.194] has quit [Ping timeout: 248 seconds] 23:35 -!- PatBoy [xyz@192.99.249.194] has joined #bitcoin-core-dev 23:37 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 240 seconds] 23:50 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev