--- Day changed Fri Oct 13 2017
00:12 < bitcoin-git> [bitcoin] ajtowns opened pull request #11494: Clarify BIP9 behaviour when nTimeout <= 0 (master...vb_0_timeout) https://github.com/bitcoin/bitcoin/pull/11494
00:13 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
00:16 -!- esotericnonsense [~esotericn@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 255 seconds]     
00:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
00:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
00:20 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 240 seconds]     
00:21 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev     
00:27 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
00:27 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rgzbdxsdborexnjh] has joined #bitcoin-core-dev     
00:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
00:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
00:54 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev     
01:01 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
01:21 -!- merehap_ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
01:23 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
01:33 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds]     
01:35 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
01:39 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
01:46 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
01:55 < meshcollider> are any of the travis builds  big endian 
02:00 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
02:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-zetwxoogfbwpjmvr] has quit [Quit: Connection closed for inactivity]     
02:13 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
02:19 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
02:29 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11493: ultra trivial typo fix in docs (master...master) https://github.com/bitcoin/bitcoin/pull/11493
02:52 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]     
03:01 -!- wxss [~chatzilla@125.212.220.154] has joined #bitcoin-core-dev     
03:08 -!- esotericnonsense [~esotericn@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev     
03:11 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
03:43 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev     
03:48 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
03:51 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
03:52 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
04:33 -!- Ofelia [~Ofelia@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection]     
04:37 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds]     
04:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
04:39 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
04:45 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev     
04:57 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
04:59 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit []     
05:01 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 248 seconds]     
05:09 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
05:13 -!- Aaronvan_ is now known as AaronvanW     
05:32 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev     
05:34 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
06:13 < pbase>  hi i am currently syncing the core wallet which is pruned. Can i copy paste the entire downloaded data for a second wallet on a different computer (local). basically what i want to do is to save time in syncing the data on the second computer
06:22 -!- ducdung [6884e408@gateway/web/freenode/ip.104.132.228.8] has joined #bitcoin-core-dev     
06:24 -!- ducdung [6884e408@gateway/web/freenode/ip.104.132.228.8] has left #bitcoin-core-dev []     
06:33 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rgzbdxsdborexnjh] has quit [Quit: Connection closed for inactivity]     
06:49 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:55 < sdaftuar> ;;diff
06:55 < gribble> 1.123863285132E12
06:58 < timothy> pbase: yes
06:58 < pbase> timothy, just delete the wallet.dat on the new computer?
06:59 < pbase> second computer*
07:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
07:10 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
07:16 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Quit: Leaving]     
07:31 -!- Jessyca [~Jessyca@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
07:32 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit []     
07:33 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving]     
07:34 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
07:36 -!- promag [~promag@89.214.26.1] has joined #bitcoin-core-dev     
07:54 -!- Cogito_Ergo_Sum [~Myself@80.107.149.120] has quit [Changing host]     
07:54 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
07:57 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
08:04 -!- harrymm [~harrymm@85.203.47.23] has quit [Ping timeout: 248 seconds]     
08:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
08:14 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
08:17 -!- harrymm [~harrymm@85.203.47.134] has joined #bitcoin-core-dev     
08:23 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 248 seconds]     
08:32 -!- Jessyca [~Jessyca@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection]     
08:33 < promag> ryanofsky: care to review? ty!
08:33 -!- promag [~promag@89.214.26.1] has quit [Remote host closed the connection]     
08:35 -!- dc0de [~herpdader@p4FEB6AAF.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
08:35 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
08:54 -!- CubicEarth [~cubiceart@c-73-68-232-79.hsd1.ma.comcast.net] has joined #bitcoin-core-dev     
08:56 < CubicEarth> jonasschnelli: You here?
09:09 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer]     
09:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
09:13 < jnewbery> sipa: what do you think of https://github.com/jnewbery/bitcoin/tree/pr11389.2 ? It's your original approach for #11389 rebased on a commit to pin P2SH to a block height. That seems more palatable than pretending P2SH is a VB deployment.
09:13 < gribble> https://github.com/bitcoin/bitcoin/issues/11389 | Support having SegWit always active in regtest by sipa · Pull Request #11389 · bitcoin/bitcoin · GitHub
09:20 < sipa> jnewbery: hmm, that's all that is needed?
09:21 < sdaftuar> jnewbery's branch looks correct to me (and simpler)
09:22 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Read error: Connection reset by peer]     
09:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
09:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
09:27 < jnewbery> sipa: I believe so - I think the behaviour is equivalent to your change that uses version bits
09:28 < jnewbery> obviously needs thorough review though
09:28 < sipa> jnewbery: but not configurable
09:28 < sipa> i needed to at least modify one unit test
09:28 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev     
09:29 < jnewbery> sipa: ah yes, you're right
09:37 < jnewbery> the failing test in miner_tests.cpp is testing that template creation fails when including a P2SH output. I think we can just remove it
09:38 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 248 seconds]     
09:49 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-vtobnjipglvtrjni] has quit [Quit: Connection closed for inactivity]     
09:50 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
09:51 < sipa> jnewbery: fair 
10:03 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:22 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dukzourzcdhmadga] has joined #bitcoin-core-dev     
10:31 -!- Rafael_ [b109c8d5@gateway/web/freenode/ip.177.9.200.213] has joined #bitcoin-core-dev     
10:32 -!- Rafael_ [b109c8d5@gateway/web/freenode/ip.177.9.200.213] has quit [Client Quit]     
10:39 < sdaftuar> is there a reason we should not set fAddnode=true for -connect peers?
10:40 < sdaftuar> (asking because i am treating addnode peers specially for things like #11490, and it seems like -connect peers should get the same treatment)
10:40 < gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub
10:44 < sipa> sdaftuar: when using -connect, the normal connection-creation loop doesm't even run, so i guess that for most things it doesn't matter
10:45 < sipa> but if it does for 11490, it should probably be changed
10:46 < gmaxwell> sdaftuar:  think it would be fine to addnode.
10:46 < sdaftuar> ok i'll throw a commit in that sets fAddnode, and if someone comes up with a reason to use a new bool I can switch
10:46 < sdaftuar> gmaxwell: thanks
11:04 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt]     
11:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
11:15 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
11:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
11:38 < jnewbery> sipa: it was a bit more complicated than I thought. The miner_test was testing that having an invalid P2SH tx in the mempool would cause template creation to fail. Currently, P2SH is always enabled in the unit tests (because it's activated using system time). Pinning the activation height of P2SH means that P2SH is not active so the test was failing.
11:39 < jnewbery> Rearranging the ordering of the tests so that the P2SH test only happens after height 210,000 appears to be sufficient to fix it
11:41 < sipa> cool!
11:41 < sipa> have a branch?
11:41 < jnewbery> same branch. Final commit fixes the test
11:50 -!- vicenteH` [~user@93.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
11:51 -!- vicenteH [~user@93.104.135.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds]     
12:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
12:23 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev     
12:25 < cfields> sdaftuar: fyi #11456 adds that
12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/11456 | Replace relevant services logic with a function suite. by TheBlueMatt · Pull Request #11456 · bitcoin/bitcoin · GitHub
12:26 < sdaftuar> ah, haven't reviewed it yet, thanks
12:26 < cfields> np     
12:27 < BlueMatt> sdaftuar: oh, i thought i mentioned to you i had a pr that changed the definition of fAddnode - I'd recommend you just pull that commit into your pr
12:27 < sdaftuar> i thought i remember you saying that we should treat connect peers the same as addnode peers, but didn't remember exactly what that entailed.  cool, will do
12:34 < cfields> make sure to take the next one that renames too, to avoid colliding when rebasing
12:35 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 248 seconds]     
12:39 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Ping timeout: 260 seconds]     
12:45 < gmaxwell> sdaftuar: re your excemption of addnoded peers, I think thats right for now but perhaps not what we want long term.. consider the case where you've configured 20 addnode peers... 8 are connected (per the limits).  Two of the eight are forked nodes... you'd probably prefer to drop them and try to replace them with some of your additional configured options.
12:46 < gmaxwell> so I think the longer term test should be "are my outbound connections of this type full, if not, don't disconnect anything from that type"
12:46 < sdaftuar> gmaxwell: i thought addnode peers are in addition to our 8 outbound peers nowadays, did i misunderstand?
12:47 < gmaxwell> yes, there are 8 additional addnode peers.
12:47 < sdaftuar> oh i see
12:47 < gmaxwell> (keeps people out of ignorance from addnoding the whole network to their detriment)
12:48 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev     
12:48 < gmaxwell> and in the above the definition of full also means "more to try are available"
12:48 < gmaxwell> if you have 8 or fewer addnodes configured you should never disconnect one.
12:48 < gmaxwell> in any case, I don't think we need to be smarter now.
12:49 < sdaftuar> i'm struggling a little to come up with an outbound peer evicter that kicks in when we haven't advanced our tip in a long time
12:49 < sdaftuar> it seems like that logic wants to live in net.cpp
12:49 < sipa> sdaftuar: net shouldn't know about a 'tip'
12:50 < sdaftuar> yeah i know... i think net_processing would fill in information, but net is the best place to look at your set of peers, i think?
12:50 < sdaftuar> like we do for inbound peer eviction
12:50 < sipa> right, it's a bit fuzzy for now
12:51 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mebabzgqfaiwpkvd] has joined #bitcoin-core-dev     
12:53 < cfields> sdaftuar: that set of peers is moving out, but it's not clear how we're going to accomplish that
12:54 < sipa> sdaftuar: i think eventually all the information that we'd use to determine who to evict will live in net_processing, apart perhaps from connection uptime (which it could easily query net for)
12:55 < cfields> sdaftuar: ideally, PeerLogicValidation (needs rename) holds a vector of CNodeState. But there are lots of locking issues to get through before we get there :(
12:55 < cfields> (the idea being that if you want to do something for each peer, you look there, rather than the CNodes in net)
12:56 < cfields> yes, what sipa said too
12:56 < sdaftuar> the thing i'm trying to do now is look at my set of outbound peers, pick the worst of them under some metric, and disconnect it -- but only if i'm full and am using up all my outbound slots
12:56 < sdaftuar> it doesn't seem easy to determine the last thing from net_processing
12:56 < sdaftuar> but the metric uses data that only net_processing knows
12:57 < cfields> sdaftuar: you can use a ForEachNode. That was kinda meant to be a stop-gap for stuff like this until it's all moved out.
12:57 < BlueMatt> sdaftuar: I think in that case you should prefer to add new state to CNodeState/net_processing.cpp static
12:58 < BlueMatt> (net_processing.cpp static will probably all eventually move into PeerLogicValidation as it gets renamed)
12:58 < sdaftuar> i think i need to expose ConnMan's nMaxOutbound in order to do this outside of net -- does that seem ok?
12:59 < BlueMatt> why is that not a #define anymore :(
13:00 < cfields> so that we can test changes exactly like this one :)
13:15 < cfields> sdaftuar: how about testing each node and marking exactly 1 at a time as preferred for eviction? Then the connection loop can check for !outgoing_full || outgoing_full-1 && have_evictable ?
13:16 < cfields> er, that logic's all busted but you get the point :)
13:16 < sdaftuar> ah, i think i like that
13:16 < sdaftuar> thanks, i'll give that a try!
13:16 < cfields> np     
13:24 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 240 seconds]     
13:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
13:32 -!- wxss_ [~chatzilla@184.75.213.133] has joined #bitcoin-core-dev     
13:32 -!- maaku [~mark@173.234.25.100] has left #bitcoin-core-dev []     
13:33 -!- mess110 [~kiki@78.97.218.2] has joined #bitcoin-core-dev     
13:34 -!- wxss [~chatzilla@125.212.220.154] has quit [Ping timeout: 260 seconds]     
13:35 -!- wxss_ is now known as wxss     
13:46 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer]     
13:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
13:59 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
14:00 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
14:04 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 258 seconds]     
14:12 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev     
14:29 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
14:29 -!- thierry [~thierry@pra13-1-82-66-186-37.fbx.proxad.net] has joined #bitcoin-core-dev     
14:30 < bitcoin-git> [bitcoin] jnewbery opened pull request #11495: [trivial] Make namespace explicit for is_regular_file (master...explicit_is_regular_file) https://github.com/bitcoin/bitcoin/pull/11495
14:31 -!- thierry [~thierry@pra13-1-82-66-186-37.fbx.proxad.net] has quit [Quit: thierry]     
14:49 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 260 seconds]     
15:01 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev     
15:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
15:23 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/424be0330514...8c2de827e988
15:23 < bitcoin-git> bitcoin/master c77170f Jonas Schnelli: [Wallet] add rescanblockchain <start_height> <stop_height> RPC command
15:23 < bitcoin-git> bitcoin/master 7a91ceb Jonas Schnelli: [QA] Add RPC based rescan test
15:23 < bitcoin-git> bitcoin/master 8c2de82 Jonas Schnelli: Merge #7061: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"...
15:25 < meshcollider> \o?     
15:25 < meshcollider> \o/ * lol
15:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
15:27 < promag> \o/     
15:28 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
15:30 < jonasschnelli> [15:25:33]  <meshcollider>	\o?   <--- do you have a pirate hook arm?
15:31 < sipa> jonasschnelli: lol
15:31 < sipa> \orrrrrr
15:31 < bitcoin-git> [bitcoin] sipa pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c2de827e988...326a5652e0d2
15:31 < bitcoin-git> bitcoin/master 4440710 Matt Corallo: Replace relevant services logic with a function suite....
15:31 < bitcoin-git> bitcoin/master 57edc0b Matt Corallo: Rename fAddnode to a more-descriptive "manual_connection"
15:31 < bitcoin-git> bitcoin/master 5ee88b4 Matt Corallo: Clarify docs for requirements/handling of addnode/connect nodes
15:32 < bitcoin-git> [bitcoin] sipa closed pull request #11456: Replace relevant services logic with a function suite. (master...2017-09-service-flags-cleanups) https://github.com/bitcoin/bitcoin/pull/11456
15:32 < BlueMatt>  \o/
15:33 -!- ula [~kvirc@b2b-78-94-9-226.unitymedia.biz] has joined #bitcoin-core-dev     
15:33 < meshcollider> jonasschnelli: lol yep that's it ;)
15:34 < jonasschnelli> Great,... 11456 is also merged.. time to review it. :)
15:35 < jonasschnelli> BlueMatt: I guess https://github.com/TheBlueMatt/bitcoin/commit/2017-09-service-flags-cleanups is now outdated for the NODE_NETWORK_LIMITED PR?
15:36 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
15:37 < BlueMatt> hmm?
15:37 < promag> mergefest? there you go #11006
15:37 < gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
15:38 < jonasschnelli> BlueMatt: is your comment (https://github.com/bitcoin/bitcoin/pull/10387#issuecomment-334490761) still relevant after a rebase with #v
15:38 < jonasschnelli> #11456
15:38 < gribble> https://github.com/bitcoin/bitcoin/issues/11456 | Replace relevant services logic with a function suite. by TheBlueMatt · Pull Request #11456 · bitcoin/bitcoin · GitHub
15:39 < jonasschnelli> promag, 11006 needs some acks first
15:39 < promag> oh :(
15:40 < BlueMatt> jonasschnelli: no?
15:40 < BlueMatt> thats the same branch that made the pr and got merged
15:40 < BlueMatt> so...I mean yes, but equally valid if you rebase on master?
15:41 < jonasschnelli> Okay... haven't checked... just arrived back in civilisation. Will take a closer look
15:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
15:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
16:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:07 -!- dc0de [~herpdader@p4FEB6AAF.dip0.t-ipconnect.de] has quit [Quit: Lost terminal]     
16:23 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
16:25 -!- comboy [~quassel@tesuji.pl] has quit [Quit: No Ping reply in 180 seconds.]     
16:29 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds]     
16:31 -!- comboy [~quassel@tesuji.pl] has joined #bitcoin-core-dev     
16:38 < bitcoin-git> [bitcoin] MeshCollider opened pull request #11496: [Trivial] Add missing comma from rescanblockchain example (master...201710_missing_comma) https://github.com/bitcoin/bitcoin/pull/11496
16:38 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 248 seconds]     
16:39 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev     
16:40 -!- wxss [~chatzilla@184.75.213.133] has quit [Remote host closed the connection]     
16:41 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
16:44 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you]     
17:00 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:10 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds]     
17:12 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
17:16 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds]     
17:27 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 240 seconds]     
17:52 -!- mess110 [~kiki@78.97.218.2] has quit [Remote host closed the connection]     
17:55 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 240 seconds]     
17:56 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
17:56 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
18:03 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 258 seconds]     
18:04 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev     
18:34 -!- vicenteH` [~user@93.104.135.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]     
18:34 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving]     
18:48 -!- adiabat [~adiabat@45.63.20.152] has quit [Quit: WeeChat 1.4]     
18:48 < bitcoin-git> [bitcoin] achow101 opened pull request #11497: Hide accounts system behind deprecation switch (master...deprecate-account-rpcs) https://github.com/bitcoin/bitcoin/pull/11497
18:49 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev     
19:06 < kanzure> would be nice to have an importaddress which would start from a configurable blockhash/blockheight (e.g. i know the key should have been created no earlier than x)
19:06 < sipa> kanzure: importmulti
19:10 < kanzure> thank you
19:30 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
19:35 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dukzourzcdhmadga] has quit [Quit: Connection closed for inactivity]     
20:00 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds]     
20:27 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
20:31 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mebabzgqfaiwpkvd] has quit [Quit: Connection closed for inactivity]     
20:50 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
21:11 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-jjbdwbwkdnexzczn] has joined #bitcoin-core-dev     
21:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
21:40 -!- Trujk [42579162@gateway/web/freenode/ip.66.87.145.98] has joined #bitcoin-core-dev     
21:42 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds]     
21:44 -!- Trujk [42579162@gateway/web/freenode/ip.66.87.145.98] has quit [Ping timeout: 260 seconds]     
22:12 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds]     
22:16 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
22:23 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev     
22:25 < jonasschnelli> cfields can you verify your comment (and my follow up) here: https://github.com/bitcoin/bitcoin/pull/11281#discussion_r139829712
22:25 < jonasschnelli> Or maybe someone else can weight in
22:26 < jonasschnelli> The permanent rescan blocking holds back #11200 (and should be lock-reduced anyways)
22:26 < gribble> https://github.com/bitcoin/bitcoin/issues/11200 | Allow for aborting rescans and canceling showProgress dialogs by achow101 · Pull Request #11200 · bitcoin/bitcoin · GitHub
22:32 < jonasschnelli> BlueMatt: final review: https://github.com/bitcoin/bitcoin/pull/11272
22:32 < jonasschnelli> (due to the requested changes from you)
22:36 -!- thierry [~thierry@pra13-1-82-66-186-37.fbx.proxad.net] has joined #bitcoin-core-dev     
22:39 -!- thierry [~thierry@pra13-1-82-66-186-37.fbx.proxad.net] has quit [Client Quit]     
22:46 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds]     
23:26 -!- ProfMac [~ProfMac@2001:470:b8ac:0:3c7c:8ede:b5a3:7fab] has quit [Ping timeout: 240 seconds]     
23:32 -!- CubicEarth [~cubiceart@c-73-68-232-79.hsd1.ma.comcast.net] has quit []     
23:36 -!- ProfMac [~ProfMac@2001:470:b8ac:0:7822:e20a:a4dc:6dbe] has joined #bitcoin-core-dev     
23:54 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
23:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev