--- Day changed Tue Oct 17 2017 00:05 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 00:14 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 240 seconds] 00:15 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 00:16 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:18 -!- harrymm_ [~harrymm@85.203.47.28] has quit [Ping timeout: 248 seconds] 00:20 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 248 seconds] 00:20 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 00:20 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 00:20 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 00:21 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 00:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 00:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 00:28 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 00:28 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 00:29 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:32 -!- harrymm_ [~harrymm@85.203.47.148] has joined #bitcoin-core-dev 00:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 00:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:44 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev 00:44 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 00:47 -!- sybarite [~sybarite@122.15.111.165] has joined #bitcoin-core-dev 00:52 -!- ula [~kvirc@b2b-78-94-9-226.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 00:54 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has quit [Ping timeout: 240 seconds] 01:03 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:03 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-ntyrhiddxalnmnon] has quit [Quit: Connection closed for inactivity] 01:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:09 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 01:09 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 01:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 01:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:34 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:38 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 01:38 -!- Deckard [b96a2c2e@gateway/web/freenode/ip.185.106.44.46] has joined #bitcoin-core-dev 01:39 -!- Deckard [b96a2c2e@gateway/web/freenode/ip.185.106.44.46] has left #bitcoin-core-dev [] 01:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 252 seconds] 01:45 -!- TheLive1 [~TheLive1@unaffiliated/thelive1] has left #bitcoin-core-dev ["WeeChat 1.9.1"] 01:55 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vbtkvbdrfsnjteoj] has quit [Quit: Connection closed for inactivity] 01:55 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 02:39 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 02:40 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [Client Quit] 02:41 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 02:44 -!- oakley91 [~oakley91@206.75-31-62.static.virginmediabusiness.co.uk] has quit [Ping timeout: 260 seconds] 02:57 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 02:58 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 03:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 03:25 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has quit [Ping timeout: 246 seconds] 03:27 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:35 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 03:45 -!- jtimon [~quassel@89.202.135.61] has joined #bitcoin-core-dev 03:50 -!- jtimon [~quassel@89.202.135.61] has quit [Ping timeout: 252 seconds] 04:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:05 -!- jtimon [~quassel@89.202.135.61] has joined #bitcoin-core-dev 04:06 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 04:10 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 04:11 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 04:24 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has joined #bitcoin-core-dev 04:24 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has quit [Changing host] 04:24 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 04:32 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 04:37 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:40 -!- jtimon [~quassel@89.202.135.61] has quit [Ping timeout: 240 seconds] 05:04 -!- jtimon [~quassel@89.202.135.61] has joined #bitcoin-core-dev 05:15 -!- reds-stripe [6c3e0597@gateway/web/freenode/ip.108.62.5.151] has joined #bitcoin-core-dev 05:17 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 05:17 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 05:21 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 05:21 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 05:24 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:26 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 05:26 < aj> jtimon: re: getblockstats rpc tests, aren't tx sizes non-deterministic due to the signatures sometimes being a byte short due to a leading \x00 getting skipped due to DER encoding? 05:30 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 05:31 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 05:32 < jtimon> aj: oh, right, that must be it... 05:33 < jtimon> isn't there a way to solve that? 05:34 -!- Banzai10 [b19b400f@gateway/web/cgi-irc/kiwiirc.com/ip.177.155.64.15] has joined #bitcoin-core-dev 05:39 < sipa> aj: how does thatmake them nondeterministic? 05:39 < sipa> DER is deterministic 05:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 05:52 < sipa> or you mean the low-S malleability? 05:57 -!- wxss [~chatzilla@185.145.38.239] has joined #bitcoin-core-dev 06:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:11 < gmaxwell> sipa: I think he thinks the signature is non-determinstic? 06:17 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 06:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:22 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 06:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:29 < aj> sipa: running the same test case repeatedly doesn't generate the same R each time does it? 06:30 < gmaxwell> it will if the transaction is the same. 06:30 < gmaxwell> (and key) 06:32 < aj> context is https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-337212106 fwiw 06:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:34 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 06:37 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has quit [Ping timeout: 248 seconds] 06:37 < sipa> aj: you can always choose to create a tx with a larger or smaller sig 06:38 < sipa> by grinding 06:38 -!- jtimon [~quassel@89.202.135.61] has quit [Ping timeout: 258 seconds] 06:38 < sipa> but if you have an actual tx, the serialization of that sig is fixed 06:39 -!- jtimon [~quassel@172.56.6.224] has joined #bitcoin-core-dev 06:41 < aj> sipa: ack. but the test suite doesn't ensure it produces a deterministic chain, so txes will vary between test suite runs, yes/no? 06:42 < sipa> no, our own signing is deterministic 06:42 -!- esotericnonsense [~esotericn@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 260 seconds] 06:43 < sipa> you can't assume that other's signatures are - but the ones we create ourselves are 06:43 -!- jtimon [~quassel@172.56.6.224] has quit [Ping timeout: 258 seconds] 06:43 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:47 -!- jtimon [~quassel@172.56.6.224] has joined #bitcoin-core-dev 06:53 -!- jtimon [~quassel@172.56.6.224] has quit [Ping timeout: 248 seconds] 06:53 -!- jtimon_ [~quassel@89.202.135.61] has joined #bitcoin-core-dev 06:56 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [Read error: Connection reset by peer] 07:02 < aj> sipa: okay, again, correct me if i'm wrong, but i'm seeing "self.nodes[0].getnewaddress()" giving different results between test_runner.py invocations, which (even despite deterministic signing) should result in non-deterministic tx sizes aiui 07:03 < sipa> aj: oh, sure 07:03 < sipa> if the the transaction isn't the same 07:03 -!- jtimon_ [~quassel@89.202.135.61] has quit [Ping timeout: 248 seconds] 07:03 -!- jtimon [~quassel@89.202.135.61] has joined #bitcoin-core-dev 07:04 < aj> sipa: yeah. i wasn't following whether the implication was that there was meant to be deterministic generation of addresses/chains to have the test suite results be deterministic 07:04 -!- reds-stripe [6c3e0597@gateway/web/freenode/ip.108.62.5.151] has quit [Quit: Page closed] 07:05 < sipa> aj: i just read some more context of the discussion, i wasn't aware you were talking about entire tests being deterministic 07:06 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 07:08 < bitcoin-git> [bitcoin] promag opened pull request #11514: Iterate and remove nodes without container copy (master...201710-node-iterate-and-erase) https://github.com/bitcoin/bitcoin/pull/11514 07:10 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Quit: Leaving] 07:11 < bitcoin-git> [bitcoin] promag opened pull request #11515: Assert cs_main is held when retrieving node state (master...201710-node-state-guard) https://github.com/bitcoin/bitcoin/pull/11515 07:12 -!- shesek [~shesek@bzq-79-179-173-155.red.bezeqint.net] has joined #bitcoin-core-dev 07:12 -!- shesek [~shesek@bzq-79-179-173-155.red.bezeqint.net] has quit [Changing host] 07:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:12 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 07:12 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-girtjfkekblcqhra] has quit [Quit: Connection closed for inactivity] 07:15 -!- jtimon [~quassel@89.202.135.61] has quit [Ping timeout: 240 seconds] 07:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:22 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 07:22 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 07:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 07:33 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Quit: Leaving] 07:35 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 07:36 -!- sybarite [~sybarite@122.15.111.165] has quit [Ping timeout: 240 seconds] 07:45 < bitcoin-git> [bitcoin] practicalswift opened pull request #11516: crypto: Avoid creating of one-past-the-end pointer and performing a noop memset call (HMAC-SHA{256,512}) (master...one-past-the-end) https://github.com/bitcoin/bitcoin/pull/11516 07:56 < bitcoin-git> [bitcoin] simonmulser closed pull request #11510: Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER (master...add_log) https://github.com/bitcoin/bitcoin/pull/11510 08:36 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 08:38 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 08:42 < pedrobranco> Hello, any change of getting https://github.com/bitcoin/bitcoin/pull/11483 merged soon since it's a bug in importmulti? 08:57 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:08 < jonasschnelli> pedrobranco: Needs more reviews first.. 09:08 < jonasschnelli> Is it something we want to backport, right? 09:21 < pedrobranco> jonasschnelli: Yes it needs more reviews. 09:29 < bitcoin-git> [bitcoin] martinus opened pull request #11517: Tests: Improve benchmark precision by inlining performance critical code (master...improved-benchmarking) https://github.com/bitcoin/bitcoin/pull/11517 09:33 < jonasschnelli> pedrobranco: I guess another one and we'll be fine. Its a simple change 09:44 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:59 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:03 -!- Banzai10 [b19b400f@gateway/web/cgi-irc/kiwiirc.com/ip.177.155.64.15] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 10:04 -!- mess110 [~kiki@78.97.218.2] has joined #bitcoin-core-dev 10:07 < pedrobranco> jonasschnelli: ty 10:09 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 10:12 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-weedtecshdoqbmev] has joined #bitcoin-core-dev 10:15 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 10:15 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:22 -!- Emcy [~MC@unaffiliated/emcy] has quit [Ping timeout: 252 seconds] 10:25 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Ping timeout: 248 seconds] 10:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 10:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 10:25 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 10:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 10:28 < BlueMatt> #11483 could get a merge, imo, dunno if anyone merging is around today, though 10:28 < gribble> https://github.com/bitcoin/bitcoin/issues/11483 | Fix importmulti bug when importing an already imported key by pedrobranco · Pull Request #11483 · bitcoin/bitcoin · GitHub 10:29 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:30 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 10:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 10:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:34 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection] 10:34 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:37 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 10:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 10:39 < mess110> hi, working on adding a proxy icon, wanted to ask for feedback. 10:39 < mess110> do you think this icon https://ibb.co/eP9mGR is better than https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png ? 10:39 < mess110> it is made out of chevron-left and 3 device-desktop from http://s-ings.com/typicons/ 10:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 10:48 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 10:53 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 10:54 -!- Aaronvan_ is now known as AaronvanW 11:01 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Read error: Connection reset by peer] 11:04 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-xlmijyqbsdmkvzsa] has joined #bitcoin-core-dev 11:04 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 11:26 -!- mess110 [~kiki@78.97.218.2] has quit [Remote host closed the connection] 11:41 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has joined #bitcoin-core-dev 11:41 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has quit [Changing host] 11:41 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 11:42 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 12:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c66cea2d186...14b860bf6402 12:07 < bitcoin-git> bitcoin/master fc0176d John Newbery: [tests] use python3 for authproxy.py 12:07 < bitcoin-git> bitcoin/master 323d8f6 John Newbery: [tests] fix flake8 warnings in authproxy.py 12:07 < bitcoin-git> bitcoin/master 8f9e362 John Newbery: [tests] authproxy.py: tidy up __init__() 12:08 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513 12:38 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/14b860bf6402...808c84f89d0e 12:44 < bitcoin-git> bitcoin/master a44a215 Pedro Branco: Fix importmulti bug when importing an already imported key 12:44 < bitcoin-git> bitcoin/master 808c84f MarcoFalke: Merge #11483: Fix importmulti bug when importing an already imported key... 12:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483 12:46 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has joined #bitcoin-core-dev 12:47 -!- mess110 [~kiki@78.97.218.2] has joined #bitcoin-core-dev 12:47 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 12:47 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Remote host closed the connection] 12:53 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has joined #bitcoin-core-dev 12:56 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:01 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: This computer has gone to sleep] 13:03 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .] 13:06 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 13:10 < cfields> sipa: i forget your preference. You like a github review (batch), or individual comments? 13:17 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 258 seconds] 13:21 < BlueMatt> cfields: for the sake of (most peoples') inbox, batch 13:23 < cfields> heh, fair enough. iirc someone complained about the batches because it screwed up their workflow. 13:23 < cfields> hmm, maybe that was you, with your online/offline split? 13:26 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:31 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 13:34 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 13:35 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 13:39 < sdaftuar> cfields: i'm thinking about adding a way to mock out addrman for the purposes of regtest-testing our outbound peer logic. does that sound like a reasonable thing to do? 13:40 < cfields> sdaftuar: yep! I've already got it halfway done, though... 13:40 < sdaftuar> oh, cool 13:40 < sdaftuar> any chance you have a commit i can steal then? :) 13:40 < cfields> heh, it's just waiting on #11457 13:40 < gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub 13:40 < cfields> sure 13:41 < cfields> it's broken out the same way 13:42 < cfields> sdaftuar: will push it up tonight, need to clean up/rebase 13:42 < sdaftuar> cool, thanks. i'll takea look at 11457 13:46 -!- karelb [~karelb@li1380-211.members.linode.com] has quit [Quit: Bye!] 13:48 < bitcoin-git> [bitcoin] jnewbery opened pull request #11518: [WIP] [tests] Simplify/clarify the NodeConn/NodeConnCB mininode classes (master...node_conn_big_refactor) https://github.com/bitcoin/bitcoin/pull/11518 13:50 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has quit [Ping timeout: 246 seconds] 13:55 -!- aj [aj@cerulean.erisian.com.au] has quit [Quit: Lost terminal] 13:55 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Read error: Connection reset by peer] 14:00 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 14:02 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Quit: Page closed] 14:02 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 14:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:03 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 14:06 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 14:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:14 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 252 seconds] 14:19 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Quit: Ping timeout (120 seconds)] 14:21 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:23 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 14:29 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 260 seconds] 14:31 -!- pergaminho [~Cleber@201.47.91.172] has quit [Ping timeout: 240 seconds] 14:33 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 14:35 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:38 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 14:43 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 14:50 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 14:51 -!- jb55 [~jb55@184.68.162.218] has joined #bitcoin-core-dev 14:54 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:56 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: Saindo] 15:01 -!- jb55 [~jb55@184.68.162.218] has quit [Ping timeout: 240 seconds] 15:06 -!- jb55 [~jb55@184.68.162.218] has joined #bitcoin-core-dev 15:06 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:08 < promag> jnewbery: where is P2PInterface? 15:10 < promag> jnewbery: https://travis-ci.org/bitcoin/bitcoin/jobs/289221884#L741 15:11 < promag> nevermind 1st question 15:12 -!- mess110 [~kiki@78.97.218.2] has quit [Quit: Leaving] 15:13 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Remote host closed the connection] 15:14 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 15:17 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 15:22 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 248 seconds] 15:23 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:23 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 15:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:55 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 16:08 -!- nds_ [~sudden@62.116.243.132] has joined #bitcoin-core-dev 16:17 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 16:31 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 16:48 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 16:49 -!- jb55 [~jb55@184.68.162.218] has quit [Quit: WeeChat 1.9] 16:49 -!- jb55 [~jb55@184.68.162.218] has joined #bitcoin-core-dev 16:51 -!- rhavar [uid237883@gateway/web/irccloud.com/x-iptgikiwuufxvepg] has joined #bitcoin-core-dev 16:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:57 -!- jb55 [~jb55@184.68.162.218] has quit [Ping timeout: 240 seconds] 17:01 -!- jb55 [~jb55@216-71-192-56.dyn.novuscom.net] has joined #bitcoin-core-dev 17:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 17:06 -!- wxss [~chatzilla@185.145.38.239] has quit [Remote host closed the connection] 17:59 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:02 -!- jb55 [~jb55@216-71-192-56.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 18:12 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 18:18 -!- esotericnonsense [~esotericn@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev 18:41 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-weedtecshdoqbmev] has quit [Quit: Connection closed for inactivity] 18:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds] 18:50 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 19:11 -!- rhavar [uid237883@gateway/web/irccloud.com/x-iptgikiwuufxvepg] has quit [Quit: Connection closed for inactivity] 19:24 -!- brianhoffman [~brianhoff@pool-96-231-163-68.washdc.fios.verizon.net] has quit [Remote host closed the connection] 19:35 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:49 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 19:49 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 19:51 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has joined #bitcoin-core-dev 19:58 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 20:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1] 20:15 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 20:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:21 -!- ok [a2c4fd51@gateway/web/freenode/ip.162.196.253.81] has joined #bitcoin-core-dev 20:21 -!- ok [a2c4fd51@gateway/web/freenode/ip.162.196.253.81] has quit [Client Quit] 20:23 -!- dlb76 [~dlb76@unaffiliated/dlb76] has quit [Ping timeout: 255 seconds] 20:24 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-xlmijyqbsdmkvzsa] has quit [Quit: Connection closed for inactivity] 20:25 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Ping timeout: 240 seconds] 20:30 -!- jonasschnelli [~jonasschn@2a01:4f8:172:10da::2] has joined #bitcoin-core-dev 20:32 -!- dlb76 [~dlb76@unaffiliated/dlb76] has joined #bitcoin-core-dev 20:35 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Remote host closed the connection] 20:35 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 20:51 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fghskwtkrmkljqgt] has joined #bitcoin-core-dev 20:57 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 21:00 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 21:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:34 -!- cheetah2 [~cheetah2@172.242.103.133] has joined #bitcoin-core-dev 21:37 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds] 21:42 < cfields> sdaftuar: https://github.com/theuni/bitcoin/tree/move-addrdb . It builds on top of #11457, mostly as a cheap review beg :) 21:42 < gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub 21:44 < cfields> It still needs a few things. At minimum, it needs an interface class (similar to NetEventsInterface) to be useful for your tests. Then a few things to tidy up in CConnman, as it was just kinda shoved in there as-is. 21:45 < cfields> I'll try to get it finished up tomorrow. But I think that gets you mostly what you were after. 21:47 < cfields> oh, and loading the addrdb is very shoe-horned in there. Need to figure out where to stick that. IMO moving it into CAddrMan makes sense, as other implementations (tests) will likely be memory-backed anyway. 21:58 < ossifrage> This may be me seeing things, of the 87 nodes connected, the ones with the longest ping times are all 0.15.0 21:58 -!- Guest83 [~textual@2602:306:378a:6fb0:8833:60d9:81d6:303f] has joined #bitcoin-core-dev 22:00 -!- cheetah2 [~cheetah2@172.242.103.133] has quit [Quit: Mutter: www.mutterirc.com] 22:23 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 22:34 -!- harrymm_ [~harrymm@85.203.47.148] has quit [Ping timeout: 240 seconds] 22:47 -!- harrymm_ [~harrymm@85.203.47.146] has joined #bitcoin-core-dev 22:59 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has joined #bitcoin-core-dev 22:59 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has quit [Changing host] 22:59 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 23:12 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 23:17 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 23:20 -!- Emcy [~MC@unaffiliated/emcy] has quit [Ping timeout: 248 seconds] 23:47 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev