--- Day changed Thu Nov 02 2017 00:15 -!- Cogito_Ergo_Sum [~Myself@athedsl-314500.home.otenet.gr] has joined #bitcoin-core-dev 00:15 -!- Cogito_Ergo_Sum [~Myself@athedsl-314500.home.otenet.gr] has quit [Changing host] 00:15 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 00:23 < wumpus> MarcoFalke: yes, it seems we're not going to get around backporting some of the support PRs, I personally think backporting #10756 is ok, not pretty but trying to patch everything up while backporting is likely more risky than doing that 00:23 < gribble> https://github.com/bitcoin/bitcoin/issues/10756 | net processing: swap out signals for an interface class by theuni · Pull Request #10756 · bitcoin/bitcoin · GitHub 00:41 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:41 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 01:03 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:15 -!- schnerchi [~schnerchi@2a01:4f8:c0c:afe::2] has left #bitcoin-core-dev [] 01:15 -!- schnerchi [~schnerchi@2a01:4f8:c0c:afe::2] has joined #bitcoin-core-dev 01:16 -!- bitbee [~bitbee@138.197.209.248] has quit [Ping timeout: 260 seconds] 01:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:22 -!- bitbee [~bitbee@138.197.209.248] has joined #bitcoin-core-dev 01:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 01:30 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:08 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 02:11 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:12 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 02:15 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #bitcoin-core-dev 02:29 -!- promag [~promag@int.edigma.com] has joined #bitcoin-core-dev 02:54 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 02:56 -!- PaulCape_ [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #bitcoin-core-dev 02:56 -!- promag [~promag@int.edigma.com] has quit [Remote host closed the connection] 03:02 -!- Victor_sueca is now known as Victorsueca 03:13 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 03:15 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 03:26 -!- shoogz [~shoogz@unaffiliated/shoogz] has quit [Ping timeout: 252 seconds] 03:38 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 03:41 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:50 -!- shoogz [~shoogz@115-64-77-180.static.tpgi.com.au] has joined #bitcoin-core-dev 03:50 -!- shoogz [~shoogz@115-64-77-180.static.tpgi.com.au] has quit [Changing host] 03:50 -!- shoogz [~shoogz@unaffiliated/shoogz] has joined #bitcoin-core-dev 03:54 -!- promag [~promag@int.edigma.com] has joined #bitcoin-core-dev 03:57 -!- promag [~promag@int.edigma.com] has quit [Remote host closed the connection] 04:02 -!- promag [~promag@int.edigma.com] has joined #bitcoin-core-dev 04:13 -!- promag [~promag@int.edigma.com] has quit [Remote host closed the connection] 04:42 -!- promag [~promag@int.edigma.com] has joined #bitcoin-core-dev 04:45 -!- promag [~promag@int.edigma.com] has quit [Remote host closed the connection] 04:49 -!- promag [~promag@int.edigma.com] has joined #bitcoin-core-dev 04:51 -!- promag [~promag@int.edigma.com] has quit [Remote host closed the connection] 05:03 -!- shoogz- [~shoogz@115-64-77-180.static.tpgi.com.au] has joined #bitcoin-core-dev 05:05 -!- shoogz [~shoogz@unaffiliated/shoogz] has quit [Ping timeout: 255 seconds] 05:08 -!- shoogz- [~shoogz@115-64-77-180.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 05:09 -!- btcdrak [uid234579@gateway/web/irccloud.com/x-qdsxsqgjcrzzmffx] has joined #bitcoin-core-dev 05:14 -!- quantbot [~quantbot@38.101.106.141] has quit [Read error: Connection reset by peer] 05:15 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 05:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:36 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 240 seconds] 05:42 -!- zi0nman [~textual@51.15.57.117] has joined #bitcoin-core-dev 05:48 -!- Test1234 [792db421@gateway/web/freenode/ip.121.45.180.33] has joined #bitcoin-core-dev 05:51 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 05:51 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 05:56 -!- Test1234 [792db421@gateway/web/freenode/ip.121.45.180.33] has quit [Quit: Page closed] 06:02 -!- dcousens [~dcousens@CPE-101-181-191-60.lnse6.cha.bigpond.net.au] has quit [Quit: Ping timeout (120 seconds)] 06:03 -!- dcousens [~dcousens@CPE-101-181-191-60.lnse6.cha.bigpond.net.au] has joined #bitcoin-core-dev 06:17 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:90b7:91f7:1898:e5cc] has joined #bitcoin-core-dev 06:30 -!- quantbot_ [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 06:30 -!- quantbot [~quantbot@38.101.106.141] has quit [Read error: Connection reset by peer] 06:39 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 06:41 -!- quantbot [~quantbot@38.101.106.141] has quit [Remote host closed the connection] 06:43 -!- quantbot_ [~quantbot@38.101.106.141] has quit [Ping timeout: 264 seconds] 06:44 -!- zi0nman [~textual@51.15.57.117] has quit [Ping timeout: 240 seconds] 06:49 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 06:51 -!- quantbot [~quantbot@38.101.106.141] has quit [Remote host closed the connection] 07:00 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 07:00 -!- quantbot [~quantbot@38.101.106.141] has quit [Remote host closed the connection] 07:01 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 07:09 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-hngpjmmsbzyxzoxc] has quit [Quit: Connection closed for inactivity] 07:26 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:90b7:91f7:1898:e5cc] has quit [Quit: Leaving] 07:36 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 07:37 -!- kkode [~eliasc@ool-18bfd89e.dyn.optonline.net] has joined #bitcoin-core-dev 07:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:40 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:55 -!- unholymachine [~quassel@2601:8c:c003:9f16:ecd4:4011:efc:297a] has quit [Remote host closed the connection] 08:01 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 08:02 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 08:05 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Quit: Leaving] 08:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:10 -!- Aaronvan_ is now known as AaronvanW_ 08:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 08:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:15 -!- SoGi [2d4896b1@gateway/web/freenode/ip.45.72.150.177] has quit [Ping timeout: 260 seconds] 08:16 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:17 -!- AaronvanW_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 08:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 08:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 08:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:35 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 08:38 -!- kkode [~eliasc@ool-18bfd89e.dyn.optonline.net] has quit [Quit: kkode] 08:41 -!- unholymachine [~quassel@2601:8c:c003:9f16:cc34:f5a9:4774:c8db] has joined #bitcoin-core-dev 08:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:45 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 08:48 -!- LumberCartel [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 08:51 -!- dcousens [~dcousens@CPE-101-181-191-60.lnse6.cha.bigpond.net.au] has quit [Ping timeout: 255 seconds] 08:52 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:52 -!- dcousens [~dcousens@CPE-101-181-66-179.lnse4.cha.bigpond.net.au] has joined #bitcoin-core-dev 08:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:57 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 09:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 09:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:22 -!- Dyaheon [~Dya@dsl-trebng21-58c18a-250.dhcp.inet.fi] has quit [Ping timeout: 240 seconds] 09:22 -!- LumberCartel [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:28 < BlueMatt> sipa: yo 09:30 -!- xinxi [~xinxi@39.109.214.22] has joined #bitcoin-core-dev 09:30 < sipa> ow 09:30 < BlueMatt> sipa: sorry, I think there's lots of net context here that is being missed :( 09:31 < BlueMatt> sipa: I have, on a few branches, an explicit goal of net_processing not relying on *when* FinalizeNode is called 09:31 < BlueMatt> plus the ForEachNode garbage needs to die 09:31 < sipa> agree on the last point 09:31 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 09:31 < BlueMatt> where CNodeState will have the CNode* in it (but it is much more restricted as a "socket reference" essentially - a thing you pass to CConnman to tell it where to send a message) 09:32 < sipa> but FinalizeNode should, regardless of when it is called, call the scheduler to remove any pending actions for that peer, no? 09:32 < BlueMatt> but eg the pr I linked to to remove the cs_vNodes lock in ForEachNode almost breaks that logic anyway 09:32 < BlueMatt> scheduler? 09:32 < BlueMatt> FinalizeNode isnt on scheduler? 09:32 < BlueMatt> since it takes things out of vNodes, calls FinalizeNode on it, but the ForEachNode function will be working on a copy of vNodes 09:33 < BlueMatt> cfields: also 09:34 < sipa> BlueMatt: the issue here is that there is an action called from the scheduler which may be running while a node is being finalized, no? 09:34 < BlueMatt> in this case its not, because cs_main, but, yes 09:34 < BlueMatt> keep in mind also that scheduler is allowed to be multiple threads 09:34 < sipa> sure, but thinking a bit ahead when cs_main is broken up 09:34 < BlueMatt> even if it isnt atm 09:34 < sipa> sure 09:35 < sipa> hmm, i see - the scheduled action isn't specific for the peer 09:35 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 09:36 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 09:36 < BlueMatt> when interacting with CConnman I think we should be making essentially 0 assumptions about order of operations cause net frameworks are always all kinds of random 09:36 < BlueMatt> anyway, I think the pr is more than fine as-is 09:37 < BlueMatt> it should not be considered a bug for the nodestate to be missing during a ForEachNode 09:37 < BlueMatt> at least in new code 09:37 < sipa> BlueMatt: yes, i withdraw my comment about the assert - violating it is much less of a assumption failure then i thought 09:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:41 < promag> for those that have 1 min free, I would like to get some concept ack/nack in #11402 09:41 < gribble> https://github.com/bitcoin/bitcoin/issues/11402 | [wallet] Use shared pointer for wallet instances by promag · Pull Request #11402 · bitcoin/bitcoin · GitHub 09:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:42 < BlueMatt> #11100 backport or no? MarcoFalke was asking 09:42 < gribble> https://github.com/bitcoin/bitcoin/issues/11100 | Fix confusing blockmax{size,weight} options, dont default to throwing away money by TheBlueMatt · Pull Request #11100 · bitcoin/bitcoin · GitHub 09:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:43 < MarcoFalke> 0.15.0.2 is already huge, so I assumed 11100 wouldn't make it any worse. 09:44 < BlueMatt> I cant say I have a hugely strong opinion 09:44 < BlueMatt> its obviously a miner-only fix 09:45 < BlueMatt> it would be nice to get it in if miners switch to 0.15.0.2 as their 0.15 upgrade, but I'm not sure how common that will be 09:45 < BlueMatt> there are still a number of miners that appear to be mining small blocks due to this misconfiguration 09:45 < sdaftuar> i would prefer to include it for that ^ reason 09:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 09:46 < BlueMatt> (which is a chunk of the "but segwit has only been a small increase" arguments - miner misconfiguration) 09:48 < gmaxwell> 11100 is simple and harmless, and should really be backported. 10:02 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 10:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b8c88451b05...bfb270acfa30 10:02 < bitcoin-git> bitcoin/master 720d9e8 Jonas Schnelli: [Wallet] always show help-line of wallet encryption calls 10:02 < bitcoin-git> bitcoin/master bfb270a MarcoFalke: Merge #11590: [Wallet] always show help-line of wallet encryption calls... 10:03 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11590: [Wallet] always show help-line of wallet encryption calls (master...2017/10/enc_wallet_help) https://github.com/bitcoin/bitcoin/pull/11590 10:07 < MarcoFalke> fn github commit sorting 10:08 < MarcoFalke> Someone should complain about that 10:08 < sipa> i alreayd have, years ago 10:11 -!- Dyaheon [~Dya@dsl-trebng21-58c18a-250.dhcp.inet.fi] has joined #bitcoin-core-dev 10:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:21 < sdaftuar> sipa: i think #11560 is ready for merge now (only difference from the commit you ack'ed is the const change) 10:21 < gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub 10:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 10:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:24 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:26 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:28 -!- warxhead [warxhead@c-73-243-180-191.hsd1.co.comcast.net] has quit [Ping timeout: 260 seconds] 10:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 10:29 -!- quantbot [~quantbot@38.101.106.141] has quit [Read error: Connection reset by peer] 10:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kanlbmuhtoscerak] has joined #bitcoin-core-dev 10:29 -!- quantbot_ [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 10:29 -!- warxhead [warxhead@c-73-243-180-191.hsd1.co.comcast.net] has joined #bitcoin-core-dev 10:35 -!- Aaronvan_ is now known as AaronvanW 10:37 -!- LumberCartel [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 10:41 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 10:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 10:46 < cfields> query ryanofsky 10:46 * cfields dropped a / 10:48 * MarcoFalke picks up a / and hands it to cfields 10:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:49 < wumpus> hehe 10:50 < bitcoin-git> [bitcoin] practicalswift opened pull request #11596: Add missing cs_main locks when accessing chainActive (master...chainActive) https://github.com/bitcoin/bitcoin/pull/11596 10:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 10:57 -!- jeremyrubin [~jr@c-98-234-232-29.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 10:58 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:02 -!- xinxi [~xinxi@39.109.214.22] has quit [Remote host closed the connection] 11:03 -!- xinxi [~xinxi@39.109.214.22] has joined #bitcoin-core-dev 11:19 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 11:19 -!- quantbot_ [~quantbot@38.101.106.141] has quit [Read error: Connection reset by peer] 11:21 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 11:22 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 11:30 < bitcoin-git> [bitcoin] kallewoof opened pull request #11597: [trivial] Fix error message & styling for when new fee rate < min mem… (master...171102-feebumper-lowerfeetxt) https://github.com/bitcoin/bitcoin/pull/11597 11:40 < jonasschnelli> Is the meeting now in 1h21min? 11:40 < jonasschnelli> (wintertime) 11:40 < sdaftuar> 20 minutes 11:40 < jonasschnelli> Thanks 11:48 -!- LumberCartel [~randolf@69.166.112.240] has joined #bitcoin-core-dev 11:48 -!- PaulCape_ [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 11:50 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Read error: Connection reset by peer] 11:52 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #bitcoin-core-dev 11:52 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rdrxkvairomwnyex] has joined #bitcoin-core-dev 11:55 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Quit: .] 11:56 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 12:00 < sipa> *drumroll* 12:00 < achow101> meeting? 12:00 < BlueMatt> *rimshot* 12:01 < wumpus> #startmeeting 12:01 < lightningbot> Meeting started Thu Nov 2 19:01:26 2017 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:01 < jonasschnelli> hi 12:01 < achow101> hi 12:01 < meshcollider> hi 12:01 < jtimon> hi 12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag 12:02 < instagibbs> here 12:02 < sdaftuar> hello 12:02 < cfields> hi 12:02 < BlueMatt> 15.0.2 12:02 < MarcoFalke> #topic 0.15.0.2 12:02 < wumpus> yes, good idea 12:02 < achow101> it seems like things keep getting added to the milestone 12:02 < cfields> i think the outstanding PRs are pretty much ready to go 12:03 < wumpus> great! 12:03 < wumpus> achow101: only cfields's libevent fix 12:03 < BlueMatt> 11593 needs more review, 11560 could just be merged 12:03 < morcos> there are 3 PR's left in question: #11100 #11560 #11593 12:03 < BlueMatt> though I think 11593 is pretty reviewable 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11100 | Fix confusing blockmax{size,weight} options, dont default to throwing away money by TheBlueMatt · Pull Request #11100 · bitcoin/bitcoin · GitHub 12:03 < kanzure> hi. 12:03 < meshcollider> and more backports 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11593 | rpc: work-around an upstream libevent bug by theuni · Pull Request #11593 · bitcoin/bitcoin · GitHub 12:03 < BlueMatt> plus backports needs fixing 12:03 < wumpus> the other one is just the backports which need to be done to support all that 12:03 < morcos> i think whichever we can't merge to master and backport right now, we need to just skip.. 12:04 < achow101> backports is failing travis right now 12:04 < morcos> BlueMatt: backports for all others are fine... sdaftuar has tiny test fix 12:04 < BlueMatt> yea 12:04 < wumpus> ok 12:04 < morcos> although they could use more review, both sdaftuar and ryanofsky are reviewing now 12:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:05 < morcos> so we should just make decisions on those last 3 PR's.. 11100 is in master, so question is only whether to add it to backports? any objections? 12:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:06 < wumpus> none apparently 12:06 < gmaxwell> I really want to see 11100 appear in a release. 12:06 < BlueMatt> backports are already huge, but thats a simple pr and would be very nice to have 12:06 < gmaxwell> It's not the only misconfig now (I see blocks that clearly have minrelay fee cranked up-- e.g. legacy of 0.11-era mempool bloat attacks) but it's the biggest one. 12:06 < wumpus> although I think we should stop moving the goalposts 12:06 < MarcoFalke> ok, will amend the pull with sdaftuar's fix and 11100 12:07 < sipa> 11560 is mergable i think 12:07 < gmaxwell> Well, if there are any issues in backporting, feel free to drop IMO. 12:07 < BlueMatt> agreed 12:07 < wumpus> the point of 0.15.0.2 is to protect against an immediate problem, and we should release it if it improves the situation anything from 0.15.0.1 12:07 < BlueMatt> ok, last point of order then is the libevent fix 12:07 < BlueMatt> cfields: you want to say anything? 12:08 < jtimon> ack on #11100 backport 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/11100 | Fix confusing blockmax{size,weight} options, dont default to throwing away money by TheBlueMatt · Pull Request #11100 · bitcoin/bitcoin · GitHub 12:08 < cfields> i've narrowed the workaround even further, it basically just affects a single stable release 12:09 < jtimon> curious, why backport all in one pr? 12:09 < BlueMatt> (the release that people have been switching to as they upgrade ubuntu, afaiu, fwiw) 12:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:09 < wumpus> jtimon: because many things depend on each other 12:09 < promag> hi 12:09 < MarcoFalke> jtimon: I am not going to push to non-master branches 12:09 < wumpus> jtimon: many of them are not trivial, stand-alone backports... if only 12:09 -!- quantbot_ [~quantbot@38.101.106.141] has joined #bitcoin-core-dev 12:09 < MarcoFalke> also what wumpus said 12:10 -!- quantbot [~quantbot@38.101.106.141] has quit [Read error: Connection reset by peer] 12:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 12:10 -!- LumberCartel [~randolf@69.166.112.240] has quit [Ping timeout: 240 seconds] 12:10 < cfields> grr, sorry, irc client fell off 12:10 < wumpus> this way there's at least the chance to review, and for travis to test the backported code 12:10 * sipa picks up the irc lcient and hands it to cfields 12:10 < MarcoFalke> So action merge and bp 11560? 12:11 < sipa> MarcoFalke: ack 12:11 < achow101> +1 12:11 < jonasschnelli> BTW: should we also consider upgrading depends openssl due to CVE-2017-3736? 12:11 < jonasschnelli> Only BIP70 stuff is affected though 12:11 < BlueMatt> +merge and bp 11560 12:11 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bfb270acfa30...7008b07005c5 12:11 < bitcoin-git> bitcoin/master 6b58360 Cory Fields: rpc: work-around an upstream libevent bug... 12:11 < bitcoin-git> bitcoin/master 97932cd Cory Fields: rpc: further constrain the libevent workaround... 12:11 < bitcoin-git> bitcoin/master 7008b07 Wladimir J. van der Laan: Merge #11593: rpc: work-around an upstream libevent bug... 12:12 < wumpus> jonasschnelli: how dangerous is that? 12:12 < jonasschnelli> Not really... 12:12 < jonasschnelli> dangerous 12:12 < gmaxwell> jonasschnelli: man, openssl upgrades are really hard to review. :( 12:12 < wumpus> if not, let postpone it to 0.15.1? 12:12 < bitcoin-git> [bitcoin] laanwj closed pull request #11593: rpc: work-around an upstream libevent bug (master...fix-libevent-cb) https://github.com/bitcoin/bitcoin/pull/11593 12:12 < jonasschnelli> but we are using open ssl 1.0.1k which is no longer maintained 12:12 < sipa> The amount of resources 12:12 < sipa> required for such an attack would be very significant and likely only 12:12 < sipa> accessible to a limited number of attackers. An attacker would 12:12 < sipa> additionally need online access to an unpatched system using the target 12:12 < sipa> private key in a scenario with persistent DH parameters and a private 12:12 < sipa> key that is shared between multiple clients. 12:12 < gmaxwell> I'd rather be spending effort into further eliminating openssl. :) 12:12 < jonasschnelli> 0.15.1 should be fine IMO 12:12 < jtimon> is anybody using bip70? 12:12 < jonasschnelli> BIP70 without openssl is non-trivial to impossible 12:13 < jonasschnelli> we could remove BIP70 support... *duck* (luke-jr) 12:13 < achow101> jtimon: I'm pretty sure bitpay does 12:13 < BlueMatt> we could remove the ssl-checking part of bip70 12:13 < jonasschnelli> (no tests, no active maintenance) 12:13 < morcos> cfields: are there any changes to our httpserver/libevent code between master and 0.15, or its fine to just backport 11593 without thinking abou tit 12:13 < jtimon> achow101: thanks 12:13 < BlueMatt> and just treat it as a "better payment field" 12:13 < gmaxwell> meh, lets not discuss that now. 12:13 < jonasschnelli> Yes 12:13 < cfields> morcos: i'll double-check, but 99% a dumb backport is enough 12:14 < bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/7008b07005c5...2f959a58744d 12:14 < bitcoin-git> bitcoin/master 2d4327d Suhas Daftuar: net: Allow connecting to extra outbound peers 12:14 < bitcoin-git> bitcoin/master db32a65 Suhas Daftuar: Track tip update time and last new block announcement from each peer 12:14 < bitcoin-git> bitcoin/master ac7b37c Suhas Daftuar: Connect to an extra outbound peer if our tip is stale... 12:14 < jonasschnelli> I'd say action: upgrade openssl depends for 0.15.1 or 0.16 12:14 < morcos> woohoo! 12:14 < bitcoin-git> [bitcoin] laanwj closed pull request #11560: Connect to a new outbound peer if our tip is stale (master...2017-10-stale-tip-new-peer) https://github.com/bitcoin/bitcoin/pull/11560 12:14 < achow101> oh, look at that! 12:14 < jonasschnelli> \o/ 12:14 < sdaftuar> yay! 12:14 < gmaxwell> our work here is done. 12:14 < wumpus> whee 12:14 < wumpus> yep, ship it 12:15 < sdaftuar> we're shipping master right 12:15 < cfields> "This only affects processors that support the BMI1, BMI2 and ADX extensions like 12:15 < cfields> Intel Broadwell (5th generation) and later or AMD Ryzen." 12:15 < gmaxwell> :P 12:15 < achow101> it compiles, shit it 12:15 < achow101> *ship 12:15 < sipa> ok, backports are go 12:15 < wumpus> yes, we're releasing 0.16.0.2 instead of 0.15.0.2 :p 12:15 < morcos> achow101: exactly 12:15 < sipa> i do want to stress that these backports may be non-trivial compared to most point releases 12:15 < wumpus> yes, definitely 12:15 < BlueMatt> yea :( 12:16 < sipa> and we should review the patches, and possibly still decide to drop some 12:16 < gmaxwell> all the more reason to get a RC out stat. 12:16 < cfields> right. in addition to the usual checks, everyone should check their own fixes 12:16 < meshcollider> its massive for a point-point release lol 12:16 < wumpus> yes, that's what rcs are for 12:16 < sipa> absolutely 12:16 < wumpus> meshcollider: it's completely silly for a .0.2 12:16 < achow101> we've got two weeks 12:16 < MarcoFalke> its not even a point-release 12:16 < sipa> just pointing out that we're not really done 12:16 < meshcollider> so rc today? 12:17 < cfields> wumpus: don't forget the version bumps :) 12:17 < BlueMatt> hopefully? review backports 12:17 < sipa> meshcollider: review backports first 12:17 < gmaxwell> it's only a pointpoint release because we communicated the extended SW wallet support would be in 0.15.1. Otherwise this would be 0.15.1. 12:17 < wumpus> cfields: good point 12:17 < sdaftuar> #11592 12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/11592 | WIP 0.15: Backports by MarcoFalke · Pull Request #11592 · bitcoin/bitcoin · GitHub 12:17 < achow101> so review backports and rc tomorrow? 12:17 < wumpus> gmaxwell: I understand, but I expected a much smaller release 12:17 < sipa> wumpus: so did we all, i think 12:18 < wumpus> normally we don't even publically announce minor-minor releases, let alone have an extended rc cycle 12:18 < wumpus> but that's definitely needed now 12:18 < achow101> note to self for future: don't promise things in version numbers 12:19 < jtimon> achow101: 12:19 < jtimon> +1 12:19 < sipa> we should have called it 0.15.$SEGWIT 12:19 < wumpus> achow101: good point 12:19 < gmaxwell> beyond the B2X split fix, I think this release is pretty trivial. 12:19 < sipa> but i agree, achow101 12:19 < gmaxwell> fixes* 12:19 < wumpus> don't promise things, period :) 12:20 < jonasschnelli> ^ (especially not on a timeline) 12:20 < gmaxwell> well if you'd be more comfortable calling it 0.15.1 I'd support that too. it's not like it's a big deal to say 'nope segwit stuff got pushed back due to snafu-mitigation' 12:20 < jtimon> I would prefer to call it 0.15.1, but not a big deal\ 12:20 < cfields> from now on, we'll promise new features at block heights rather than timestamps :p 12:21 < sipa> we could of course also include #11167 (support for sending to bech32) and call it 0.15.1 *ducks* 12:21 < gribble> https://github.com/bitcoin/bitcoin/issues/11167 | Full BIP173 (Bech32) support by sipa · Pull Request #11167 · bitcoin/bitcoin · GitHub 12:21 < gmaxwell> too bad that has a bunch of refactors. 12:21 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/01e173f5b8985ad5ec14c1621531a003635f9800 12:21 < bitcoin-git> bitcoin/0.15 01e173f Wladimir J. van der Laan: build: Bump version to 0.15.0.2... 12:21 < sipa> (that's not a serious suggestion, please let's not delay things further) 12:22 < wumpus> oh okay, calling it 0.15.1 is also ok with me 12:22 < gmaxwell> for some context there, new electrum shipped that has 'segwit wallet support' -- which for them is BIP173 only. 12:22 < jonasschnelli> 0.15.1 seems to make more sense to me... I don't think many people do expect SW Wallet support 12:22 < wumpus> ok 12:22 < gmaxwell> so already getting some reports of not being able to send to it from Bitcoin Core, ::sigh:: :) 12:22 < wumpus> yes, definitely better 12:22 < sipa> gmaxwell: well, electrum's problem 12:23 < jonasschnelli> Slow transition.... no hurry 12:23 < wumpus> indeed, just a matter of time 12:23 < wumpus> some software can be ahead of others, that's what you'll always have 12:24 < instagibbs> Electrum supports multiwallet, it's fine 12:25 < wumpus> great 12:25 < sdaftuar> release notes? anyone started that? 12:25 < wumpus> so, everyone agree that the release will be 0.15.1? 12:25 < sdaftuar> wumpus: sounds good 12:26 < jonasschnelli> wumpus: ack 12:26 < gmaxwell> sounds fine. 12:26 < promag> lgtm 12:26 < sipa> ack 12:26 < meshcollider> is there a TODO for release notes 0.15.0.2? 12:26 < meshcollider> can only find 16.0 12:27 < wumpus> meshcollider: on the 0.15 branch 12:27 < bitcoin-git> [bitcoin] laanwj force-pushed 0.15 from 01e173f to f224cbc: https://github.com/bitcoin/bitcoin/commits/0.15 12:27 < bitcoin-git> bitcoin/0.15 f224cbc Wladimir J. van der Laan: build: Bump version to 0.15.1... 12:27 < achow101> 0.15.1 is fine with me 12:28 < wumpus> an actual point release, this feels much better 12:28 < meshcollider> wumpus: I mean an issue like 11054 12:28 < wumpus> release notes are certainly important, though they don't need to be ready for rc1 12:28 < morcos> one comment about the version 12:28 < morcos> i talked to Alyssa from CoinDesk abou tthis 12:29 < morcos> not sure if they published an article or about to 12:29 < wumpus> meshcollider: no, we don't make topics that for minor releases generally 12:29 < meshcollider> ah ok 12:30 < jtimon> morcos: should be easy to correct their article, no? 12:30 < wumpus> if you're in contact with them please let them know this is not the .1 they're expecting 12:30 < jonasschnelli> morcos: Maybe tell here that the SW2X aware version is now 0.15.1 and SW wallet version is *unknown" for now? 12:30 < morcos> yeah i don't see anything majorly published, i'll tell her now 12:31 < morcos> who knows if she was going to even say anything 12:31 < jtimon> just s/0.15.1/0.15.2 and s/0.15.0.2/0.15.1/ 12:31 < wumpus> yes, segwit wallet delayed due to necessary s2x preparations :( 12:31 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 12:32 < BlueMatt> s/necessary/hopefully unecessary, though possibly necessary/ 12:32 < sipa> arguably these were necessary preprations anyway - they're not specific to 2X 12:32 < BlueMatt> indeed 12:32 < wumpus> BlueMatt: better to be prepared at least 12:32 < BlueMatt> we now have outbound peer rotation! 12:32 < sipa> we just had to prioritize these P2P improvements 12:32 < jonasschnelli> but more pressing since SW2X 12:32 < BlueMatt> :bottlepop emoji" 12:32 < BlueMatt> : 12:32 < wumpus> sipa: sure, but the reason this was prioeritized over segwit I mean 12:32 < gmaxwell> yes, are generally good improvements which we should have done eventually regardless. 12:33 < morcos> ok i emailed her, i'm fine to switch it, i just wanted to be sure there wasn't already some article out there 12:33 < jonasschnelli> Who cares. :) 12:33 < sipa> i went back and edited some reddit comments i made about 0.15.1 12:33 < sipa> i think it's fine 12:33 < gmaxwell> morcos: inaccurate details in a press article about bitcoin?! Good thing you prevent that from ever happening. 12:33 < jonasschnelli> Things are in-move.... 12:33 < BlueMatt> lolol 12:33 < wumpus> then after this we can do segwit wallet as 0.15.2, or 0.16.0, depending on what makes sense in the time frame that things are ready 12:34 < jonasschnelli> Yeah.. I would not promis 0.15.2 now (even if it's very likely to happen with SW Wallet) 12:34 < sipa> ya 12:34 < wumpus> jonasschnelli: indeed 12:35 < jtimon> perhaps we could consider doing 0.16 faster instead of doing a 0.15.2 release with segwit? 12:35 < jonasschnelli> features are not tied to releases... releases are tied to the planed timeframe 12:35 < jtimon> I guess it would be a bad precedent 12:35 < BlueMatt> ok, more topics? 12:35 < wumpus> jtimon: I'm ok with that - though the original reasoning was exactly opposite, add some time to 0.16 to be able to do a segwit release in between - but yeah, things have changed 12:36 < gmaxwell> so 0.16 release next week? 12:36 * gmaxwell ducks 12:36 < jonasschnelli> ;-) 12:36 < BlueMatt> #action activate segwit? 12:36 < wumpus> jtimon: also to not have another hairy, big set of backports 12:36 < wumpus> gmaxwell: always optimistic :) 12:36 < jtimon> wumpus: yeah I'm perhaps more worried about the latter 12:37 * MarcoFalke have been obtained by ChainCode 12:37 < jonasschnelli> \o/ 12:37 < sipa> MarcoFalke: congrats! 12:37 < wumpus> congratulations MarcoFalke 12:37 < cfields> MarcoFalke: congrats :) 12:37 < gmaxwell> MarcoFalke: congrats. 12:37 < jonasschnelli> MarcoFalke: Congrats. Have fun in NY! 12:37 < sdaftuar> MarcoFalke: welcome! :) 12:37 < instagibbs> what does that bring the commit % to :P 12:38 < jtimon> yeah, cool 12:38 < BlueMatt> instagibbs: shhhhhhhhhhh 12:38 < instagibbs> congrats! 12:38 < cfields> heh 12:38 < BlueMatt> in the future, all coredev.tech events are required to occur in ny to minimize total flight time =D 12:38 < meshcollider> \o/ 12:38 < jtimon> chaincode conspiracies coming... 12:38 < instagibbs> Eastern US powerhouse too :) 12:38 < MarcoFalke> instagibbs: It's not retroactive ;) 12:38 < morcos> instagibbs: which ones, the ones we do ourselves or the ones under our blockstream contract? 12:38 < jonasschnelli> ChainCodeLabs marketing departure must confront now with new ChainCode Core conspiracy 12:38 < instagibbs> morcos, one and the same, right? 12:38 < jtimon> BlueMatt: lol 12:38 < achow101> chaincore 12:39 < jonasschnelli> heh 12:39 < cfields> BlockChain 12:39 < cfields> wait... 12:39 < sdaftuar> lol 12:39 < gmaxwell> lol 12:39 < morcos> took you long enough 12:39 < jonasschnelli> lol 12:39 < sipa> ChainStream 12:39 < wumpus> hah! 12:39 < jtimon> codestream 12:39 < jtimon> anyway, other topics? 12:40 < wumpus> let's get backporting then 12:40 < gmaxwell> I thought we were gonna ship master! :P 12:41 < jtimon> but that's afterwards, release 0.15.1, then rc master the day after, no? 12:41 < wumpus> we coulld do that too and make people choose :p 12:41 < gmaxwell> WE HERD U LIK CHOICES 12:41 < wumpus> YAH 12:42 < wumpus> #endmeeting 12:42 < lightningbot> Meeting ended Thu Nov 2 19:42:15 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:42 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-11-02-19.01.html 12:42 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-11-02-19.01.txt 12:42 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-11-02-19.01.log.html 12:42 < sipa> "Bitcoin Core now comes in multiple flavours! Bitcoin Core Home, Bitcoin Core Pro, Bitcoin Core XP, ..." 12:42 < jtimon> random non-priority review begging: https://github.com/bitcoin/bitcoin/pull/8994 12:42 < instagibbs> Bitcoin Core ME, don't forget ME 12:42 < achow101> Bitcoin Core Server Edition 12:43 < BlueMatt> achow101: no, thats FIBRE 12:44 < bitcoin-git> [bitcoin] jtimon closed pull request #11430: Add BIP16 to consensus params for consistency (master...b16-bip90-bip16) https://github.com/bitcoin/bitcoin/pull/11430 12:49 < cfields> MarcoFalke: any especially non-trivial backports we should give extra scrutiny? 12:51 < MarcoFalke> cfields: They are mostly clean cherry-picks (beside one or two minor conflicts) 12:51 < MarcoFalke> I am mostly worried about silent merge conflicts 12:51 < cfields> ok great, i was nervous that the signals/interface change might've introduced a bunch of conflicts 12:51 < MarcoFalke> but it compiles, so everything must be right 12:51 < MarcoFalke> right? 12:52 < cfields> hah, good enough 12:52 < BlueMatt> I mean our tests are prefect, right? 12:52 < sdaftuar> nothing could possibly go wrong 12:52 < jtimon> MarcoFalke: of course, it even passes travis, can't be wrong 12:53 < BlueMatt> someone wanna close #11575? Looks like his wallet got corrupted by sitting around for a few years....nothing to be done, he's just asking for support now... 12:53 < gribble> https://github.com/bitcoin/bitcoin/issues/11575 | CDBEnv::EnvShutdown: Error -30974 shutting down database environment: DB_RUNRECOVERY: Fatal error, run database recovery · Issue #11575 · bitcoin/bitcoin · GitHub 12:56 -!- LumberCartel [~randolf@96.53.47.42] has joined #bitcoin-core-dev 13:00 < karelb> Oh. I came to watch the meeting, I am one hour late because of daylight saving time. 13:00 < karelb> FINE 13:01 < meshcollider> heh DST is fun like that ;) 13:04 * instagibbs wondering if US DST will screw me up 13:06 < achow101> DST ends on sunday in the US 13:06 < meshcollider> does the whole US have one DST shift, or is it different for different parts? 13:07 -!- kkode [~eliasc@ool-18bfd89e.dyn.optonline.net] has joined #bitcoin-core-dev 13:07 < instagibbs> depends on state I believe 13:07 -!- kkode [~eliasc@ool-18bfd89e.dyn.optonline.net] has quit [Client Quit] 13:08 < achow101> It's state by state, but those that have DST shift at the same time IIRC 13:08 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 260 seconds] 13:19 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:90b7:91f7:1898:e5cc] has joined #bitcoin-core-dev 13:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 13:21 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 13:27 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:33 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 248 seconds] 13:37 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Remote host closed the connection] 13:47 < BlueMatt> hey! we can make travis bitch on here when master builds fail 13:47 < BlueMatt> ...maybe we should do that 13:47 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 13:50 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 13:51 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11598: Make travis complain on #bitcoin-core-dev when builds fail (master...2017-10-travis-irc-notifications) https://github.com/bitcoin/bitcoin/pull/11598 13:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 14:05 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #11598: Make travis complain on #bitcoin-core-dev when builds fail (master...2017-10-travis-irc-notifications) https://github.com/bitcoin/bitcoin/pull/11598 14:07 -!- dcousens [~dcousens@CPE-101-181-66-179.lnse4.cha.bigpond.net.au] has quit [Quit: The Lounge - https://thelounge.github.io] 14:13 -!- jb55 [~jb55@24.87.206.252] has joined #bitcoin-core-dev 14:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:19 -!- warxhead [warxhead@c-73-243-180-191.hsd1.co.comcast.net] has quit [] 14:23 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 14:30 -!- bomberb17 [~bomberb17@68.65.174.192] has joined #bitcoin-core-dev 14:31 < bomberb17> ? 14:33 -!- bomberb17 [~bomberb17@68.65.174.192] has quit [Client Quit] 14:34 -!- warxhead [warxhead@c-73-243-180-191.hsd1.co.comcast.net] has joined #bitcoin-core-dev 14:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:46 -!- malaka [~tux3do@ip72-201-18-238.ph.ph.cox.net] has joined #bitcoin-core-dev 14:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 14:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:52 -!- jb55 [~jb55@24.87.206.252] has quit [Ping timeout: 246 seconds] 14:59 -!- travis-ci [~travis-ci@ec2-54-197-141-164.compute-1.amazonaws.com] has joined #bitcoin-core-dev 14:59 < travis-ci> TheBlueMatt/bitcoin#674 (2017-10-travis-irc-notifications - f9cd8b4 : Matt Corallo): The build passed. 14:59 < travis-ci> Change view : https://github.com/TheBlueMatt/bitcoin/compare/5d465e396249^...f9cd8b458a92 14:59 < travis-ci> Build details : https://travis-ci.org/TheBlueMatt/bitcoin/builds/296471305 14:59 -!- travis-ci [~travis-ci@ec2-54-197-141-164.compute-1.amazonaws.com] has left #bitcoin-core-dev [] 14:59 < gribble> https://github.com/bitcoin/bitcoin/issues/674 | Cannot compile Mac · Issue #674 · bitcoin/bitcoin · GitHub 14:59 -!- jb55 [~jb55@24.87.206.252] has joined #bitcoin-core-dev 15:00 -!- LumberCartel [~randolf@96.53.47.42] has quit [Ping timeout: 258 seconds] 15:01 < BlueMatt> lol, cfields you were right 15:01 < cfields> heh 15:02 < gmaxwell> bot warz 15:03 < sipa> we must go deeper 15:16 < sipa> cfields: https://github.com/bitcoin/bitcoin/pull/11389#discussion_r146683391 -> what do you suggest I replace it with? 15:17 < sipa> i wanted to use std::numeric_limits::max_value, but that required adding an extra include 15:19 < gmaxwell> an extra include to bring in numeric limits sounds reasonable, ... they should be included pretty much everywhere regardless.... 15:19 < gmaxwell> an extra include of a boost header OTOH ... 15:22 < cfields> sipa: just dropping the 'U' would be enough to shut me up 15:22 < sipa> cfields: oh! 15:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:24 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 15:29 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 15:37 -!- jb55 [~jb55@24.87.206.252] has quit [Ping timeout: 258 seconds] 15:40 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 240 seconds] 16:09 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Read error: Connection reset by peer] 16:11 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 252 seconds] 16:13 -!- LeMiner2 [~LeMiner@unaffiliated/leminer] has quit [Ping timeout: 248 seconds] 16:17 -!- malaka [~tux3do@ip72-201-18-238.ph.ph.cox.net] has quit [Ping timeout: 248 seconds] 16:20 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 16:31 -!- grio [~grio@ip68-102-158-172.ks.ok.cox.net] has joined #bitcoin-core-dev 16:32 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 16:32 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:90b7:91f7:1898:e5cc] has quit [Quit: Leaving] 16:38 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 16:41 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 16:54 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 17:00 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 276 seconds] 17:02 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 17:14 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 17:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:35 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 17:37 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has quit [Ping timeout: 258 seconds] 17:43 -!- wxss [~chatzilla@185.145.38.236] has quit [Remote host closed the connection] 17:46 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:47 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 17:47 < fanquake> #conspiracy indeed 17:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 17:50 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 252 seconds] 18:01 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 18:02 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 18:11 -!- LumberCartel [~randolf@96.53.47.42] has joined #bitcoin-core-dev 18:17 -!- cheetah2 [~cheetah2@172.242.103.133] has joined #bitcoin-core-dev 18:22 -!- cheetah2 [~cheetah2@172.242.103.133] has quit [Client Quit] 18:28 -!- cheetah2 [~cheetah2@172.242.103.133] has joined #bitcoin-core-dev 18:30 -!- cheetah2 [~cheetah2@172.242.103.133] has quit [Client Quit] 18:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kanlbmuhtoscerak] has quit [Quit: Connection closed for inactivity] 19:06 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 246 seconds] 19:21 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 19:21 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 19:39 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 19:51 -!- Ironeo [187b0613@gateway/web/freenode/ip.24.123.6.19] has joined #bitcoin-core-dev 19:52 < Ironeo> Does anyone know of any Bitcoin ATM's in Evansville, Indiana ?? 19:52 < Ironeo> Guess not. 19:55 < sipa> #bitcoin 19:58 < LumberCartel> Ironeo: Patience is a virtue. It's common for many folks on IRC to lurk for hours before responding to questions. 19:59 * LumberCartel agrees with sipa that #bitcoin is the better place to ask that particular question. 20:10 < Ironeo> My sincere apology 20:11 < Ironeo> LumberCartel, Thx 20:13 -!- Ironeo [187b0613@gateway/web/freenode/ip.24.123.6.19] has quit [Quit: Page closed] 20:24 -!- uneeb [~uneeb@104.156.103.173] has joined #bitcoin-core-dev 20:30 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 20:38 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Quit: Leaving] 20:48 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:487:15f8:33fe:5d7f] has joined #bitcoin-core-dev 20:48 -!- MisterPaz [~PazPazPaz@2602:306:8348:2f70:487:15f8:33fe:5d7f] has joined #bitcoin-core-dev 20:49 -!- MisterPaz [~PazPazPaz@2602:306:8348:2f70:487:15f8:33fe:5d7f] has quit [Read error: Connection reset by peer] 20:59 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:487:15f8:33fe:5d7f] has quit [Read error: Connection reset by peer] 21:11 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has joined #bitcoin-core-dev 21:15 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Quit: Laters] 21:50 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 21:51 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 21:56 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev 22:36 -!- uneeb [~uneeb@104.156.103.173] has quit [Remote host closed the connection] 22:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 22:41 -!- dabura667 [~dabura667@210.164.9.14] has joined #bitcoin-core-dev 22:59 -!- dabura667 [~dabura667@210.164.9.14] has quit [Ping timeout: 252 seconds] 23:09 -!- dabura667 [~dabura667@210.164.9.14] has joined #bitcoin-core-dev 23:12 -!- dabura667 [~dabura667@210.164.9.14] has quit [Client Quit] 23:17 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 23:23 < kakobrekla> say you have a transaction with multiple outputs and multiple inputs resulting two inputs getting assigned the same amount, how do you uniquely identify those two 'subtx'es (preferably using bitcoind rpc)? 23:33 < jonasschnelli> kakobrekla: what do you mean with "uniquely identify"? 23:34 < jonasschnelli> And what is a 'subtx'? 23:38 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 23:40 < kakobrekla> so in one 'transaction' (one txid) you 'move' btcs from multiple outputs to multiple inputs, correct? 23:43 < kakobrekla> one transaction (has unique id) could have outputs o1, o2 and o3... 'reasigning' the coins to i1, i2, i3... 23:44 < kakobrekla> and it could be that i1 'used' in that tx twice 23:46 < kakobrekla> so i1 can get same amount assigned twice, all inside one tx 23:46 < kakobrekla> (iirc i had such case happening a few months ago, struggling to find the 'offending' tx atm) 23:48 < kakobrekla> i want to make sure that im not processing a tx twice so i have a limitation of unique key over 3 fields (txid, input address and amount) 23:48 < kakobrekla> but this can malfunction because of the case mentioned above 23:53 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 240 seconds]